Updated the if-else block with an optimised inverse operator. Thanks
for your suggestion Stephen.
On Fri, Aug 2, 2024 at 10:36 AM Tathagat Priyadarshi
wrote:
>
> The EOP and csum bit was not set for all the packets in mbuf chain
> causing packet transmission stalls for packets split across
> mbuf
The EOP and csum bit was not set for all the packets in mbuf chain
causing packet transmission stalls for packets split across
mbuf in chain.
Fixes: 4022f99 ("net/gve: support basic Tx data path for DQO")
Cc: sta...@dpdk.org
Signed-off-by: Tathagat Priyadarshi
Signed-off-by: Varun Lakkur Ambaji
在 2024/8/2 10:42, Stephen Hemminger 写道:
On Fri, 2 Aug 2024 10:23:12 +0800
"lihuisong (C)" wrote:
void
-virtio_update_packet_stats(struct virtnet_stats *stats, struct rte_mbuf *mbuf)
+virtio_update_packet_stats(struct virtnet_stats *const stats,
+ const struct rte_mbuf *const
在 2024/8/2 0:03, Morten Brørup 写道:
Optimized the performance of updating the virtio statistics counters by
reducing the number of branches.
Ordered the packet size comparisons according to the probability with
typical internet traffic mix.
Signed-off-by: Morten Brørup
---
v5:
* Do not inline
Acked-by: Joshua Washington
Thanks!
> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Thursday, 1 August 2024 18.18
>
> On Thu, 1 Aug 2024 16:03:12 +
> Morten Brørup wrote:
>
> > Optimized the performance of updating the virtio statistics counters
> by
> > reducing the number of branches.
> >
> > Ordered t
August 1, 2024
#
Attendees
* Patrick Robb
* Jeremy Spewock
* Nicholas Pratte
* Juraj Linkeš
* Alex Chapman
* Luca Vizzarro
#
Minutes
===
The existing verbose levels 1..3 provide a messy multi-line
output per packet. I found this unhelpful when diagnosing many
types of problems like packet flow.
This patch keeps the previous levels and adds two new levels:
4: one line per packet is printed in a format resembling
tshark output. Wi
Some tests for new packet dissector.
Signed-off-by: Stephen Hemminger
---
app/test/meson.build| 1 +
app/test/test_dissect.c | 245
2 files changed, 246 insertions(+)
create mode 100644 app/test/test_dissect.c
diff --git a/app/test/meson.build b/a
The function rte_dissect_mbuf is used to decode the contents
of an mbuf into ah uman readable format similar to what tshark uses.
For now, handles IP, IPv6, TCP, UDP, ICMP and ARP.
Signed-off-by: Stephen Hemminger
---
lib/net/meson.build | 2 +
lib/net/rte_dissect.c | 416 ++
Add more defines for additional defined ICMP types.
Signed-off-by: Stephen Hemminger
---
lib/net/rte_icmp.h | 22 ++
1 file changed, 18 insertions(+), 4 deletions(-)
diff --git a/lib/net/rte_icmp.h b/lib/net/rte_icmp.h
index 4bf64d70ad..b51b60a6d2 100644
--- a/lib/net/rte_ic
While debugging TAP rte_flow discovered that test pmd verbose output
was confusing and unhelpful. Instead, made a simple dissector that
prints one line per packet like this in test-pmd with verbose level 4.
v5 - breakout the additional ICMP types into header
- fix some decoding bugs in ARP and
Thanks for your suggestion Stephen, I have already updated the patch with
v4 & fixed the typo. Will consider your suggestion in the next version of
the patch.
On Fri, 2 Aug 2024 at 00:24, Stephen Hemminger
wrote:
> On Thu, 1 Aug 2024 17:27:53 +
> Tathagat Priyadarshi wrote:
>
> > +
Hi Josh,
Updated the patch
(https://patches.dpdk.org/project/dpdk/patch/1722534481-2405601-1-git-send-email-tathagat.d...@gmail.com/),
please ACK if it looks good.
Thanks!
On Thu, Aug 1, 2024 at 9:55 PM Joshua Washington wrote:
>
> Hi, can we try to serialize these patches? Let's fix the multi
The EOP and csum bit was not set for all the packets in mbuf chain
causing packet transmission stalls for packets split across
mbuf in chain.
Fixes: 4022f99 ("net/gve: support basic Tx data path for DQO")
Cc: sta...@dpdk.org
Signed-off-by: Tathagat Priyadarshi
Signed-off-by: Varun Lakkur Ambaji
These tests were not built since the conversion to meson.
Instead of using embedded resource functions, put data in include
file and generate temporary file before the test.
Signed-off-by: Stephen Hemminger
---
app/meson.build| 3 +-
app/test/meson.build | 6
This API was used only for cfgfile tests and was never built
after the conversion to meson. Will be replaced by simpler
method of doing cfgfile tests.
Signed-off-by: Stephen Hemminger
---
app/test/meson.build | 2 -
app/test/resource.c | 276 ---
ap
Simple script to read a file and make it into a initialized
C string in a header file.
Signed-off-by: Stephen Hemminger
---
buildtools/gen-header.py | 36
buildtools/meson.build | 2 +-
2 files changed, 37 insertions(+), 1 deletion(-)
create mode 100644 b
The cfgfile tests did not get built since conversion to meson
and they used an awkward way to manage the test data.
This patchset converts the tests to use a helper to take
text file and make it into a C header. Then use the C header
to generate temporary files as needed.
v4 - add special treatme
The EOP and csum bit was not set for all the packets in mbuf chain
causing packet transmission stalls for packets split across
mbuf in chain.
Fixes: 4022f99 ("net/gve: support basic Tx data path for DQO")
Cc: sta...@dpdk.org
Signed-off-by: Tathagat Priyadarshi
Signed-off-by: Varun Lakkur Ambaji
Hi, can we try to serialize these patches? Let's fix the multidescriptor
packets issue present in the driver first (ensuring that the entire
descriptor is written each time). The TSO support is an entirely new
feature and should likely not be backported to stable releases.
Optimized the performance of updating the virtio statistics counters by
reducing the number of branches.
Ordered the packet size comparisons according to the probability with
typical internet traffic mix.
Signed-off-by: Morten Brørup
---
v5:
* Do not inline the function. (Stephen)
v4:
* Consider
Don't use term "sanity" because it is considered derogatory.
Signed-off-by: Stephen Hemminger
Acked-by: Hemant Agrawal
---
drivers/bus/fslmc/qbman/qbman_sys_decl.h | 2 +-
drivers/common/cnxk/roc_nix_tm_ops.c | 2 +-
drivers/common/cnxk/roc_npa.c | 6 +++---
drivers/comm
Don't use the word sanity in the documentation
Signed-off-by: Stephen Hemminger
---
doc/guides/gpus/cuda.rst | 2 +-
doc/guides/sample_app_ug/eventdev_pipeline.rst | 2 +-
doc/guides/tools/testbbdev.rst | 8
3 files changed, 6 insertions(+), 6 delet
Sanity check is on the Tier 2 non-inclusive list.
Replace or remove it.
Signed-off-by: Stephen Hemminger
---
lib/graph/graph.c | 2 +-
lib/graph/graph_stats.c | 2 +-
lib/graph/node.c| 2 +-
lib/jobstats/rte_jobstats.c | 6 +++---
lib/metrics/rte_metrics.c | 2 +-
lib
Do not use non-inclusive terms.
Signed-off-by: Stephen Hemminger
---
examples/ipsec-secgw/event_helper.c | 2 +-
examples/qos_sched/args.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/examples/ipsec-secgw/event_helper.c
b/examples/ipsec-secgw/event_helper.c
i
The word "sanity" is on the not-allowed inclusive naming
list. Replace the unnecessary usage in tests.
Signed-off-by: Stephen Hemminger
---
app/test/test_bitmap.c | 4 +--
app/test/test_bpf.c| 6 ++--
app/test/test_common.c | 2 +-
app/test/test_distrib
Sanity check is on the Tier 2 non-inclusive list.
Replace or remove it.
Signed-off-by: Stephen Hemminger
Acked-by: Anatoly Burakov
---
lib/eal/common/eal_common_memory.c | 2 +-
lib/eal/common/eal_common_proc.c | 3 ++-
lib/eal/common/eal_common_trace.c | 2 +-
lib/eal/common/eal_memcfg.h
Replace rte_mbuf_sanity_check() with rte_mbuf_verify()
to match the similar macro RTE_VERIFY() in rte_debug.h
The term sanity check is on the Tier 2 list of words
that should be replaced.
Signed-off-by: Stephen Hemminger
Acked-by: Andrew Rybchenko
Acked-by: Morten Brørup
---
app/test/test_mbu
Remove use of expression sanity check across DPDK drivers
and documentation.
The term sanity-check is on the Tier 2 word list from the Inclusive
Naming project.
https://inclusivenaming.org/word-lists/tier-2/sanity-check/
Rationale
This term might be derogatory to neurodiverse people.
The existing hash functions in DPDK are not cryptographically
secure and can be subject to carefully crafted packets causing
DoS attack.
Add SipHash which is a fast and cryptographicly sound hash
created by Jean-Philippe Aumasson and Daniel J. Bernstein.
Siphash is widely used by Linux, FreeBSD, O
01/08/2024 15:03, Juraj Linkeš:
> On 30. 7. 2024 15:51, Thomas Monjalon wrote:
> > 12/07/2024 10:57, Juraj Linkeš:
> >> The tool used to generate DTS API docs is Sphinx, which is already in
> >> use in DPDK. The same configuration is used to preserve style with one
> >> DTS-specific configuration (
pdated a few instance to show the issue, there
> are
> >> many instances to fix, if we prefer to go this way.
> >> Other option is to disable warning but it can be useful for actual
> >> string usecases, so I prefer to keep it.
> >
> > Compiler warnings ar
Hi Dean,
I've just realised that you sent a new version but it was sent a
separate thread. Sorry about that! I'll try to send a review to that
one. Can you please make sure to reply to the original thread starting
email when you send new versions as per contributing guidelines[1]?
Thank you,
On 30. 7. 2024 15:51, Thomas Monjalon wrote:
12/07/2024 10:57, Juraj Linkeš:
The tool used to generate DTS API docs is Sphinx, which is already in
use in DPDK. The same configuration is used to preserve style with one
DTS-specific configuration (so that the DPDK docs are unchanged) that
modif
Similar to the previous commit, please follow contributing guidelines:
https://doc.dpdk.org/guides/contributing/patches.html#commit-messages-subject-line
Is there a reason to split this from the test suite commit?
Can you please rebase this on the latest changes, as the code will look
different for sure?
Three comments in the meantime:
* Is there a reason for sleeping for 6 seconds? If so could you please
explain it?
* Please follow naming standards consistently, variables should be in
snake_case
Hi Dean,
this patch is awfully identical to Nicholas' older patch:
http://inbox.dpdk.org/dev/20240702192422.2480-3-npra...@iol.unh.edu/
Can you explain what's going on here? As it's all very confusing. It
seems that maybe Nicholas dropped it in his late versions.
Best,
Luca
> From: Chengwen Feng
> Sent: Thursday, August 1, 2024 12:11 PM
> To: tho...@monjalon.net ; dev@dpdk.org
> Cc: Van Haaren, Harry ; wangchenxin...@huawei.com
>
> Subject: [PATCH] examples/eventdev: fix segment fault with generic pipeline
>
> There was a segmentation fault when executing eventdev
actual
>> string usecases, so I prefer to keep it.
>
> Compiler warnings are here to help, so +1 for fixing the code.
>
>>
>> [1]
>> gcc (GCC) 15.0.0 20240801 (experimental)
>>
>> [2]
>> ../lib/ethdev/rte_flow.h:906:36:
>> error: initializer-str
Hi Dean, thank you for your work.
On 08/07/2024 20:08, Dean Marx wrote:
+def set_multicast_all(self, on: bool, verify: bool = True):
+"""Turns multicast mode on/off for the specified port.
+
+Args:
+on: If :data:`True`, turns multicast mode on, otherwise turns off
Hi,
> -Original Message-
> From: Thomas Monjalon
> Sent: Wednesday, July 31, 2024 15:02
> To: Alex Chapman
> Cc: dev@dpdk.org; luca.vizza...@arm.com; paul.szczepa...@arm.com; Dariusz
> Sosnowski ; Slava Ovsiienko
> ; Bing Zhao ; Ori Kam
> ; Suanming Mou ; Matan Azrad
>
>
> Hello,
>
>
On Wed, 31 Jul 2024 at 20:37, wrote:
>
> Hi all,
>
> Here is a list of patches targeted for stable release 22.11.6.
>
> The planned date for the final release is August 20th.
>
> Please help with testing and validation of your use cases and report
> any issues/results with reply-all to this mail.
The EOP bit was not set for all the packets in mbuf chain
causing packet transmission stalls for packets split across
mbuf in chain.
Fixes: 4022f99 ("net/gve: support basic Tx data path for DQO")
Cc: sta...@dpdk.org
Signed-off-by: Tathagat Priyadarshi
Signed-off-by: Varun Lakkur Ambaji Rao
---
this patch only updated a few instance to show the issue, there are
> many instances to fix, if we prefer to go this way.
> Other option is to disable warning but it can be useful for actual
> string usecases, so I prefer to keep it.
Compiler warnings are here to help, so +1 fo
On 7/31/2024 5:38 PM, Tathagat Priyadarshi wrote:
> The EOP bit was not set for all the packets in mbuf chain
> causing packet transmission stalls for packets split across
> mbuf in chain.
>
> Signed-off-by: Tathagat Priyadarshi
> Signed-off-by: Varun Lakkur Ambaji Rao
>
> Fixes: 4022f99 ("net/
There was a segmentation fault when executing eventdev_pipeline with
command [1] with ConnectX-5 NIC card:
0x0079208c in rte_eth_tx_buffer (tx_pkt=0x16f8ed300, buffer=0x100,
queue_id=11, port_id=0) at ../lib/ethdev/rte_ethdev.h:6636
txa_service_tx (txa=0x17b19d080, ev=0xe500, n=4)
From: Jun Yang
This patch improves the errata handling for
"RTE_LIBRTE_DPAA_ERRATA_LS1043_A010022"
Signed-off-by: Jun Yang
---
drivers/net/dpaa/dpaa_rxtx.c | 40
1 file changed, 32 insertions(+), 8 deletions(-)
diff --git a/drivers/net/dpaa/dpaa_rxtx.c b/d
From: Gagandeep Singh
During DPAA cleanup in FMCLESS mode, application can
see segmentation fault in device close API and in DPAA
destructor execution.
Segmentation fault in device close is because driver
reducing the number of queues initialised during
device configuration without releasing the
From: Rohit Raj
The OH ports can also be used by two application, processing contexts
to communicate to each other.
This patch enables this mode for dpaa-eth OH port as ONIC port,
so that application can use the dpaa-eth to communicate to each
other on the same SoC.
Again,this properties is driv
From: Rohit Raj
NXP DPAA architecture supports the concept of DPAA
port as Offline Port - meaning - not connected to an actual MAC.
This is an virtual port to be used by application for exchanging data.
This property is completely driven by the device-tree. During the
DPAA bus scan, based on the
From: Vinod Pullabhatla
Add support to set Tx rate on DPAA platform through PMD APIs
Signed-off-by: Vinod Pullabhatla
Signed-off-by: Rohit Raj
---
.mailmap | 1 +
drivers/net/dpaa/dpaa_flow.c | 95 +---
drivers/net/dpaa/fmlib/fm_lib
From: Gagandeep Singh
This patch adds support to compile time debug the mempool
corruptions in dpaa driver.
Signed-off-by: Gagandeep Singh
---
drivers/net/dpaa/dpaa_rxtx.c | 40
1 file changed, 40 insertions(+)
diff --git a/drivers/net/dpaa/dpaa_rxtx.c b/d
This patch enhances the received packet debugging capability.
This help displaying the full packet parsing output.
Signed-off-by: Jun Yang
Signed-off-by: Hemant Agrawal
---
doc/guides/nics/dpaa.rst | 5 ++
drivers/net/dpaa/dpaa_ethdev.c | 6 ++
drivers/net/dpaa/dpaa_rxtx.c | 138 +++
This patch implements the detailed packet parsing using
the annotation info from the hardware.
decode parser to set RX muf packet type by dpaa_slow_parsing.
Support to identify the IPSec ESP, GRE and SCTP packets.
Signed-off-by: Jun Yang
Signed-off-by: Hemant Agrawal
---
drivers/net/dpaa/dpaa_
From: Vanshika Shukla
This patch adds the support for the ethdev APIs
to enable/disable and read/write/adjust IEEE1588
PTP timestamps for DPAA platform.
Signed-off-by: Vanshika Shukla
---
doc/guides/nics/dpaa.rst | 1 +
drivers/bus/dpaa/base/fman/fman.c | 15 ++
drivers/bus/dpaa/
From: Vanshika Shukla
This patch implements Rx/Tx timestamp read operations
for DPAA1 platform.
Signed-off-by: Vanshika Shukla
---
drivers/bus/dpaa/base/fman/fman.c| 21 +++-
drivers/bus/dpaa/base/fman/fman_hw.c | 6 ++-
drivers/bus/dpaa/include/fman.h | 18 ++-
drivers/net/d
From: Jun Yang
For Shared MAC:
1) Allocate RXQ from VSP scheme.
2) Allocate RXQ from CC directed to VSP.
2) Remove RXQ allocated which is reconfigured without VSP.
3) Don't alloc default queue and err queues.
Signed-off-by: Jun Yang
Acked-by: Hemant Agrawal
---
drivers/bus/dpaa/base/fman/fman
From: Vanshika Shukla
This patch separates Tx confirmation queues for kernel
and DPDK so as to support the VSP case.
Signed-off-by: Vanshika Shukla
Acked-by: Hemant Agrawal
---
drivers/bus/dpaa/include/fsl_qman.h | 4 ++-
drivers/net/dpaa/dpaa_ethdev.c | 47 +
From: Vanshika Shukla
TX confirmation provides dedicated confirmation
queues for transmitted packets. These queues are
used by software to get the status and release
transmitted packets buffers.
Signed-off-by: Vanshika Shukla
Acked-by: Hemant Agrawal
---
drivers/net/dpaa/dpaa_ethdev.c | 45 ++
Add BMI statistics and improving the existing extended
statistics
Signed-off-by: Hemant Agrawal
Signed-off-by: Gagandeep Singh
---
drivers/bus/dpaa/base/fman/fman_hw.c | 65 +++-
drivers/bus/dpaa/include/fman.h | 4 +-
drivers/bus/dpaa/include/fsl_fman.h | 12
No need to classify interface separately for 1G and 10G
Fixes: e0718bb2ca95 ("bus/dpaa: add virtual storage profile port init")
Cc: sta...@dpdk.org
Signed-off-by: Hemant Agrawal
---
drivers/bus/dpaa/base/fman/fman.c | 29 +++--
1 file changed, 27 insertions(+), 2 deletio
From: Rohit Raj
Avoid typecasting ch_id to u32 and passing it to another API since it
can corrupt other data. Instead, create new u32 variable and typecase
it back to u16 after it gets updated by the API.
NXP CID: 27996293
Fixes: 0c504f6950b6 ("net/dpaa: support push mode")
Cc: hemant.agra...@nx
From: Gagandeep Singh
When a Retire FQ command is executed on a FQ in the
Tentatively Scheduled or Parked states, in that case FQ
is retired immediately and a FQRNI (Frame Queue Retirement
Notification Immediate) message is generated. Software
must read this message from MR and consume it to free
This series adds several enhancement to the NXP DPAA Ethernet driver.
Primarily:
1. timestamp and IEEE 1588 support
2. OH and ONIC based virtual port config in DPAA
3. frame display and debugging infra
Gagandeep Singh (3):
bus/dpaa: fix PFDRs leaks due to FQRNIs
net/dpaa: support mempool debu
ce to show the issue, there are
> many instances to fix, if we prefer to go this way.
> Other option is to disable warning but it can be useful for actual
> string usecases, so I prefer to keep it.
>
> [1]
> gcc (GCC) 15.0.0 20240801 (experimental)
>
> [2]
> ../lib/eth
The following patch depends on
https://patches.dpdk.org/project/dpdk/patch/1722443901-2400194-1-git-send-email-tathagat.d...@gmail.com/
Will retrigger git patch checks post its approved and upstreamed. To
avoid conflicts.
On Thu, Aug 1, 2024 at 3:47 PM Tathagat Priyadarshi
wrote:
>
> The patch in
Hi Joshua,
We have addressed the checksum offload update for each mbuf in the
following patch (net/gve: Add support for TSO in DQO RDA).
https://patches.dpdk.org/project/dpdk/patch/1722507548-2401507-1-git-send-email-tathagat.d...@gmail.com/
Thanks a lot!
On Thu, Aug 1, 2024 at 2:00 AM Joshua W
The patch intends on adding support for TSO in DQO RDA format.
Signed-off-by: Tathagat Priyadarshi
Signed-off-by: Varun Lakkur Ambaji Rao
---
drivers/net/gve/gve_tx_dqo.c | 42 --
1 file changed, 36 insertions(+), 6 deletions(-)
diff --git a/drivers/net/
On 30. 7. 2024 15:28, Thomas Monjalon wrote:
12/07/2024 10:57, Juraj Linkeš:
The Sphinx script argument parsing improvement gives us more
flexibility going forward, such as the ability to add non-positional
arguments.
You should describe what is changed and why.
The Sphinx script argumen
Fix the following error when using dpdk as a subproject:
subprojects/dpdk/buildtools/subproject/meson.build:28:56:
ERROR: Unknown function "file".
This was obviously never tested in its submitted form.
Cc: sta...@dpdk.org
Fixes: 7d8c608faa7f ("buildtools/cmdline: allow using script in subproje
The tool used to generate DTS API docs is Sphinx, which is already in
use in DPDK. The same configuration is used to preserve style with one
DTS-specific configuration (so that the DPDK docs are unchanged) that
modifies how the sidebar displays the content.
Sphinx generates the documentation from
The Sphinx script argument parsing improvement gives us more
flexibility going forward, such as the ability to add non-positional
arguments.
Signed-off-by: Juraj Linkeš
Reviewed-by: Luca Vizzarro
Reviewed-by: Jeremy Spewock
Acked-by: Bruce Richardson
Tested-by: Luca Vizzarro
Tested-by: Nichol
These sources could be generated with the sphinx-apidoc utility, but
that doesn't give us enough flexibility, such as sorting the order of
modules or changing the headers of the modules.
The sources included in this patch were in fact generated by said
utility, but modified to improve the look of
Sphinx imports every Python module when generating documentation from
docstrings, meaning all DTS dependencies, including Python version,
must be satisfied.
By adding Sphinx to DTS dependencies we provide a convenient way to
generate the DTS API docs which satisfies all dependencies.
Signed-off-by
Address a few errors reported by Sphinx when generating documentation:
framework/params/__init__.py:docstring of framework.params.modify_str:3:
WARNING: Inline interpreted text or phrase reference start-string
without end-string.
framework/params/eal.py:docstring of framework.params.eal.Eal
The generation is done with Sphinx, which DPDK already uses, with
slightly modified configuration of the sidebar present in an if block.
Dependencies are installed using Poetry from the dts directory:
poetry install --with docs
After installing, enter the Poetry shell:
poetry shell
And then ru
On 31/07/2024 22:26, Wathsala Vithanage wrote:
Updates the tag of Arm IPsec-MB library to SECLIB-IPSEC-2024.07.08
in snow3g and zuc documentation.
Signed-off-by: Wathsala Vithanage
Reviewed-by: Dhruv Tripathi
Acked-by: Jack Bond-Preston
---
.mailmap | 1 +
doc/g
On 7/29/2024 5:38 PM, Ivan Malov wrote:
> Support the use of indirect counters in so-called SWITCH
> rules (second stage lookup and steering after supposed
> decapsulation) in tunnel offload. An indirect counter
> can either come instead of an inline counter or, when
> the latter is a conntrack-ass
g but it can be useful for actual
string usecases, so I prefer to keep it.
[1]
gcc (GCC) 15.0.0 20240801 (experimental)
[2]
../lib/ethdev/rte_flow.h:906:36:
error: initializer-string for array of ‘unsigned char’ is too long
[-Werror=unterminated-string-initialization
Hi Dean, thank you for your work! Some minor comments.
On 26/07/2024 15:15, Dean Marx wrote:
add dataclass for passing in flow rule creation arguments, as well as a
__str__ method for converting to a sendable testpmd command. Add
flow_create method to TestPmdShell class for initializing flow rul
The tool used to generate DTS API docs is Sphinx, which is already in
use in DPDK. The same configuration is used to preserve style with one
DTS-specific configuration (so that the DPDK docs are unchanged) that
modifies how the sidebar displays the content.
Sphinx generates the documentation from
The Sphinx script argument parsing improvement gives us more
flexibility going forward, such as the ability to add non-positional
arguments.
Signed-off-by: Juraj Linkeš
Reviewed-by: Luca Vizzarro
Reviewed-by: Jeremy Spewock
Acked-by: Bruce Richardson
Tested-by: Luca Vizzarro
Tested-by: Nichol
These sources could be generated with the sphinx-apidoc utility, but
that doesn't give us enough flexibility, such as sorting the order of
modules or changing the headers of the modules.
The sources included in this patch were in fact generated by said
utility, but modified to improve the look of
Sphinx imports every Python module when generating documentation from
docstrings, meaning all DTS dependencies, including Python version,
must be satisfied.
By adding Sphinx to DTS dependencies we provide a convenient way to
generate the DTS API docs which satisfies all dependencies.
Signed-off-by
Address a few errors reported by Sphinx when generating documentation:
framework/params/__init__.py:docstring of framework.params.modify_str:3:
WARNING: Inline interpreted text or phrase reference start-string
without end-string.
framework/params/eal.py:docstring of framework.params.eal.Eal
The generation is done with Sphinx, which DPDK already uses, with
slightly modified configuration of the sidebar present in an if block.
Dependencies are installed using Poetry from the dts directory:
poetry install --with docs
After installing, enter the Poetry shell:
poetry shell
And then ru
Signed-off-by: hailinx
---
doc/guides/nics/i40e.rst | 4
1 file changed, 4 insertions(+)
diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst
index ca6caa0cff..d4c9790d47 100644
--- a/doc/guides/nics/i40e.rst
+++ b/doc/guides/nics/i40e.rst
@@ -104,6 +104,8 @@ For X710/XL710/XXV7
Signed-off-by: hailinx
---
doc/guides/nics/ice.rst | 2 ++
1 file changed, 2 insertions(+)
diff --git a/doc/guides/nics/ice.rst b/doc/guides/nics/ice.rst
index ae975d19ad..59ed8e6808 100644
--- a/doc/guides/nics/ice.rst
+++ b/doc/guides/nics/ice.rst
@@ -79,6 +79,8 @@ are listed in the Tested Pla
On 30/07/2024 22:33, Jeremy Spewock wrote:
On Tue, Jul 30, 2024 at 9:37 AM wrote:
+class VerboseOLFlag(Flag):
+"""Flag representing the OL flags of a packet from Testpmd verbose
output."""
+
+#:
+RTE_MBUF_F_RX_RSS_HASH = auto()
+
+#:
+RTE_MBUF_F_RX_L4_CKSUM_GOOD = auto()
+
Great work Jeremy! Just a couple of minor passable improvement points.
On 30/07/2024 14:34, jspew...@iol.unh.edu wrote:
+@dataclass
+class TestPmdVerbosePacket(TextParser):
+"""Packet information provided by verbose output in Testpmd.
+
+The "receive/sent queue" information is not inclu
Hello, I am testing the QoS Schedule sample app with a traffic generator and I
notice that the latency of high priority traffic class (TC 0, for example)
increases when the load of the NIC increase. With that being said, may I ask is
there anyway to maintain the latency of high priority traffic
The previously planned update to the `rte_cryptodev_cb_fn` function
prototype is being reverted. The introduction of the
`rte_cryptodev_queue_pair_event_error_query` API provides a means for
applications to retrieve the queue pair ID that encountered an error
interrupt. This makes the addition of t
The previously planned update to the `rte_cryptodev_cb_fn` function
prototype is being reverted. The introduction of the
`rte_cryptodev_queue_pair_event_error_query` API provides a means for
applications to retrieve the queue pair ID that encountered an error
interrupt. This makes the addition of t
94 matches
Mail list logo
