Add two new per-service counters.
RTE_SERVICE_ATTR_IDLE_CALL_COUNT tracks the number of service function
invocations where no work was performed.
RTE_SERVICE_ATTR_ERROR_CALL_COUNT tracks the number invocations
resulting in an error.
The semantics of RTE_SERVICE_ATTR_CALL_COUNT remains the same (
Extend the bitset API with atomic versions of the most basic bitset
operations.
Signed-off-by: Mattias Rönnblom
---
lib/eal/include/rte_bitset.h | 155 +++
1 file changed, 155 insertions(+)
diff --git a/lib/eal/include/rte_bitset.h b/lib/eal/include/rte_bitset.h
Add test suite exercising .
Signed-off-by: Mattias Rönnblom
--
RFC v5:
* Parameterize tests to allow reuse across both atomic and non-atomic
functions.
RFC v4:
* Fix signed char issue in test cases. (Stephen Hemminger)
* Add test cases for logic operations.
* Use the unit test suite run
Introduce a set of functions and macros that operate on sets of bits,
kept in arrays of 64-bit words.
RTE bitset is designed for bitsets which are larger than what fits in
a single machine word (i.e., 64 bits). For very large bitsets, the
API may be a more appropriate choice.
Depends-on: series-
Extend bitset tests to cover the basic operation of the
rte_bitset_atomic_*() family of functions.
Signed-off-by: Mattias Rönnblom
---
app/test/test_bitset.c | 48 ++
1 file changed, 48 insertions(+)
diff --git a/app/test/test_bitset.c b/app/test/test_bit
Use a multi-word bitset to track which services are mapped to which
lcores, allowing the RTE_SERVICE_NUM_MAX compile-time constant to be >
64.
Replace array-of-bytes service-currently-active flags with a more
compact multi-word bitset-based representation, reducing memory
footprint somewhat.
Sign
Switch from using an open-coded, single-word bitset to using
to represent which event ports are linked to a
particular event queue.
Besides the cleaner code, this also allow the user to extend the
maximum port count beyond 64, by means of changing an "event_dev.h"
Signed-off-by: Mattias Rönnblom
Looks good to me, I just had a few comments about copyright lines but
the actual functionality seems like it's there to me:
Reviewed-by: Jeremy Spewock
On Thu, Aug 8, 2024 at 4:55 AM Juraj Linkeš wrote:
>
> The tool used to generate DTS API docs is Sphinx, which is already in
> use in DPDK. The
On Thu, Aug 8, 2024 at 4:54 AM Juraj Linkeš wrote:
>
> Sphinx imports every Python module (through the autodoc extension)
> when generating documentation from docstrings, meaning all DTS
> dependencies, including Python version, should be satisfied. This is not
> a hard requirement, as imports fro
This is a funny change I wouldn't have expected the series to need. I
don't doubt that it does need it of course and I don't think there is
any harm in the change, but, out of curiosity, is this because the or
operator is coming from one of the dependencies we are installing? I
thought it was just
The patch intends on adding support for TSO in DQO RDA format.
Signed-off-by: Tathagat Priyadarshi
Signed-off-by: Varun Lakkur Ambaji Rao
---
drivers/net/gve/gve_tx_dqo.c | 26 +++---
1 file changed, 23 insertions(+), 3 deletions(-)
diff --git a/drivers/net/gve/gve_tx_dqo.c
On Thu, Aug 8, 2024 at 4:54 AM Juraj Linkeš wrote:
>
> Address a few errors reported by Sphinx when generating documentation:
> framework/params/__init__.py:docstring of framework.params.modify_str:3:
> WARNING: Inline interpreted text or phrase reference start-string
> without end-string.
On Wed, Aug 7, 2024 at 3:43 PM Dean Marx wrote:
>
> Test suite for verifying VLAN filtering, stripping, and insertion
> functionality on Poll Mode Driver.
>
> Signed-off-by: Dean Marx
> ---
> +++ b/dts/tests/TestSuite_vlan.py
> @@ -0,0 +1,168 @@
> +# SPDX-License-Identifier: BSD-3-Clause
> +# Co
On Wed, Aug 7, 2024 at 3:43 PM Dean Marx wrote:
>
> added the following methods to testpmd shell class:
> vlan set filter on/off, rx vlan add/rm,
> vlan set strip on/off, port stop/start all/port,
> tx vlan set/reset, set promisc/verbose
>
> fixed bug in vlan_offload for
> show port info, removed
On 2024-08-09 18:31, Stephen Hemminger wrote:
On Fri, 9 Aug 2024 17:37:08 +0200
Mattias Rönnblom wrote:
On 2024-08-09 17:03, Stephen Hemminger wrote:
On Fri, 9 Aug 2024 11:04:36 +0200
Mattias Rönnblom wrote:
-uint32_t val32;
-uint64_t val64;
+#define GEN_TEST_BIT_ACCESS(test_name, set_f
On Fri, 9 Aug 2024 17:37:08 +0200
Mattias Rönnblom wrote:
> On 2024-08-09 17:03, Stephen Hemminger wrote:
> > On Fri, 9 Aug 2024 11:04:36 +0200
> > Mattias Rönnblom wrote:
> >
> >> -uint32_t val32;
> >> -uint64_t val64;
> >> +#define GEN_TEST_BIT_ACCESS(test_name, set_fun, clear_fun, assign_f
On Wed, Aug 7, 2024 at 3:36 PM Dean Marx wrote:
>
> This suite tests the ability of the Poll Mode Driver to enable
> and disable Rx/Tx queues on a port.
>
> Signed-off-by: Dean Marx
> ---
Reviewed-by: Jeremy Spewock
On Wed, Aug 7, 2024 at 3:36 PM Dean Marx wrote:
>
> added set promisc, set verbose, and port stop
> commands to testpmd shell.
>
> Signed-off-by: Dean Marx
> ---
Reviewed-by: Jeremy Spewock
Hey Nick,
Thanks for the patch. The way you did things all makes sense to me and
I like the idea of pulling out the definitions to make things more
compact in the main schema, the one thought I did have though was that
it isn't immediately obvious in the main schema where these values are
coming f
On 2024-08-09 17:03, Stephen Hemminger wrote:
On Fri, 9 Aug 2024 11:04:36 +0200
Mattias Rönnblom wrote:
-uint32_t val32;
-uint64_t val64;
+#define GEN_TEST_BIT_ACCESS(test_name, set_fun, clear_fun, assign_fun, \
+ flip_fun, test_fun, size) \
+
Hey Luca,
Thanks for the patch! Just a few pretty minor comments below.
On Tue, Aug 6, 2024 at 8:53 AM Luca Vizzarro wrote:
>
> Add a basic L2 forwarding test suite which tests the correct
> functionality of the forwarding facility built-in in the DPDK.
>
> The tests are performed with different
The alarm test had several issues:
- only negative tests were done, no positive test to make sure
API worked
- the set/cancel test had too short an interval and the alarm
might expire
- the test should have used the standard TEST macros.
Signed-off-by: Stephen Hemminger
---
ap
Yes the alarm API is supported on FreeBSD.
Signed-off-by: Stephen Hemminger
---
app/test/test_alarm.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/app/test/test_alarm.c b/app/test/test_alarm.c
index b4034339b8..0cdfad1374 100644
--- a/app/test/test_alarm.c
+++ b/app/test/test_alarm.c
Both Linux and FreeBSD, check parameters to rte_eal_alarm_set,
but Windows missed this. And the test was "fixed" instead.
This reverts commit a089d320338d708f5b7126dab5fd6861c82e6347.
Windows EAL should have been fixed rather than papering over
the bug.
Signed-off-by: Stephen Hemminger
---
app
This is the set of things which stood out as needing fixing when
looking at the rte_eal_alarm tests.
v2 - drop cleanup of eal alarm code for later
- add RTE_ATOMIC() to fix clang build
Stephen Hemminger (3):
eal: add missing parameter check to rte_eal_alarm_set on Windows
test: support ala
On Tue, Aug 6, 2024 at 8:49 AM Luca Vizzarro wrote:
>
> Add a facility to update the number of TX/RX queues during the runtime
> of testpmd.
>
> Signed-off-by: Luca Vizzarro
> Reviewed-by: Paul Szczepanek
> ---
> dts/framework/remote_session/testpmd_shell.py | 16
> 1 file chan
I tried to address this very same problem in the scatter expansion
patch series but, admittedly, I like your approach better. There is
one thing that Juraj and I discussed on that thread however that is
probably worth noting here regarding verification of the stopping and
starting ports. The main i
On Tue, Aug 6, 2024 at 8:49 AM Luca Vizzarro wrote:
>
> Add a basic utility that can create random L3 and L4 packets with random
> payloads and port numbers (if L4).
>
> Signed-off-by: Luca Vizzarro
> Reviewed-by: Paul Szczepanek
> Reviewed-by: Alex Chapman
> ---
Reviewed-by: Jeremy Spewock
Makes a lot of sense to me.
On Tue, Aug 6, 2024 at 8:49 AM Luca Vizzarro wrote:
>
> When introducing pseudo-random generation in the test runs we need to
> ensure that these can be reproduced by setting a pre-defined seed.
> This commits adds the ability to set one or allow for one to be
> genera
Hey Luca,
Thanks for the patch! I think this change makes a lot of sense in
general, and I like the idea of removing the duplication between
capturing traffic generators and the test suite. I just had one
thought that I left below, but otherwise:
Reviewed-by: Jeremy Spewock
On Tue, Aug 6, 2024
On Fri, 9 Aug 2024 11:04:36 +0200
Mattias Rönnblom wrote:
> -uint32_t val32;
> -uint64_t val64;
> +#define GEN_TEST_BIT_ACCESS(test_name, set_fun, clear_fun, assign_fun,
> \
> + flip_fun, test_fun, size) \
> + static int
On Fri, 9 Aug 2024 10:33:49 +0200
Morten Brørup wrote:
> > +++ b/lib/eal/linux/eal_alarm.c
> > @@ -53,6 +53,13 @@ static struct rte_intr_handle *intr_handle;
> > static int handler_registered = 0;
> > static void eal_alarm_callback(void *arg);
> >
> > +#ifndef LIST_FOREACH_SAFE
> > +#define LI
On Fri, 9 Aug 2024 10:23:24 +0300
Dmitry Kozlyuk wrote:
> 2024-08-08 12:46 (UTC-0700), Stephen Hemminger:
> > This reverts commit a089d320338d708f5b7126dab5fd6861c82e6347.
> >
> > Windows EAL should have been fixed rather than papering over
> > the bug.
>
> Linux and FreeBSD alarm implementat
09/08/2024 15:01, Bharath Paulraj:
> This commit fixes the bug in the registration API where it fails to
> set the log level if 'id' already exists.
Why registering twice?
This commit fixes the bug in the registration API where it fails to
set the log level if 'id' already exists.
Signed-off-by: Bharath Paulraj
---
.mailmap | 1 +
lib/log/log.c | 4 +++-
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/.mailmap b/.mailmap
index 4a508bafad..05eca1
> +#define rte_bit_test(addr, nr)
> \
> + _Generic((addr),\
> + uint32_t *: __rte_bit_test32, \
> + const uint32_t *: __rte_bit_test32,
From: Peter Morrow
If a SFP which supports SFF-8436 is present then
currently the DDM information present in the eeprom
is not read. Furthermore bnxt_get_module_eeprom()
will return -EINVAL for these eeproms since the
length of these eeproms is 512 bytes but we are
only ever selecting 2 pages (25
On Fri, 9 Aug 2024 at 11:20, Xu, HailinX wrote:
>
> Update the test status for Intel part. dpdk22.11.6-rc1 all validation test
> done. no new issue is found.
>
> # Basic Intel(R) NIC testing
> * Build & CFLAG compile: cover the build test combination with latest
> GCC/Clang version and the popul
Update the test status for Intel part. dpdk22.11.6-rc1 all validation test
done. no new issue is found.
# Basic Intel(R) NIC testing
* Build & CFLAG compile: cover the build test combination with latest GCC/Clang
version and the popular OS revision such as
Ubuntu24.04, Ubuntu22.04, Fedora40, R
Have rte_bit_[test|set|clear|assign|flip]() and rte_bit_atomic_*()
handle volatile-marked pointers.
Signed-off-by: Mattias Rönnblom
--
PATCH v2:
* Actually run the est_bit_atomic_v_access*() test functions.
---
app/test/test_bitops.c | 32 ++-
lib/eal/include/rte_bitops.h | 427 +++
Add atomic bit test/set/clear/assign/flip and
test-and-set/clear/assign/flip functions.
All atomic bit functions allow (and indeed, require) the caller to
specify a memory order.
Signed-off-by: Mattias Rönnblom
Acked-by: Morten Brørup
Acked-by: Tyler Retzlaff
--
PATCH:
* Add missing macro #
Add functionality to test and modify the value of individual bits in
32-bit or 64-bit words.
These functions have no implications on memory ordering, atomicity and
does not use volatile and thus does not prevent any compiler
optimizations.
Signed-off-by: Mattias Rönnblom
Acked-by: Morten Brørup
Extend bitops tests to cover the rte_bit_atomic_*() family of
functions.
Signed-off-by: Mattias Rönnblom
Acked-by: Morten Brørup
Acked-by: Tyler Retzlaff
--
RFC v4:
* Add atomicity test for atomic bit flip.
RFC v3:
* Rename variable 'main' to make ICC happy.
---
app/test/test_bitops.c | 3
Extend bitops tests to cover the
rte_bit_[test|set|clear|assign|flip]()
functions.
The tests are converted to use the test suite runner framework.
Signed-off-by: Mattias Rönnblom
Acked-by: Morten Brørup
Acked-by: Tyler Retzlaff
--
RFC v6:
* Test rte_bit_*test() usage through const pointers.
This patch set represent an attempt to improve and extend the RTE
bitops API, in particular for functions that operate on individual
bits.
All new functionality is exposed to the user as generic selection
macros, delegating the actual work to private (__-marked) static
inline functions. Public fun
The deeper the idle state, the lower the power consumption, but the longer
the resume time. Some service are delay sensitive and very except the low
resume time, like interrupt packet receiving mode.
And the "/sys/devices/system/cpu/cpuX/power/pm_qos_resume_latency_us" sysfs
interface is used to s
The deeper the idle state, the lower the power consumption, but the longer
the resume time. Some service are delay sensitive and very except the low
resume time, like interrupt packet receiving mode.
And the "/sys/devices/system/cpu/cpuX/power/pm_qos_resume_latency_us" sysfs
interface is used to s
Add PM QoS configuration to declease the delay after sleep in case of
entering deeper idle state.
Signed-off-by: Huisong Li
Acked-by: Morten Brørup
---
examples/l3fwd-power/main.c | 24
1 file changed, 24 insertions(+)
diff --git a/examples/l3fwd-power/main.c b/example
All maintainers,
Hi, kindly ping for review.
Thanks,
Jie Hai
On 2024/7/22 14:58, Jie Hai wrote:
The registers can be dumped through the API rte_eth_dev_get_reg_info.
However, only register values are exported, which is inconvenient for
users to interpret. Therefore, an extension of the structu
All maintainers,
Hi, kindly ping for review.
Thanks,
Jie Hai
On 2024/7/19 17:04, Jie Hai wrote:
For hns3 NIC, when KEEP_CRC offload is enabled, the CRC data is
still be stripped in rare scenarios. Some users of hns3 are
already using this feature. So driver has to recaculate packet CRC.
In add
Have rte_bit_[test|set|clear|assign|flip]() and rte_bit_atomic_*()
handle volatile-marked pointers.
Signed-off-by: Mattias Rönnblom
---
app/test/test_bitops.c | 30 ++-
lib/eal/include/rte_bitops.h | 427 ++-
2 files changed, 289 insertions(+), 168 deletion
Add atomic bit test/set/clear/assign/flip and
test-and-set/clear/assign/flip functions.
All atomic bit functions allow (and indeed, require) the caller to
specify a memory order.
RFC v8:
* Add missing macro #undef for C++ version of atomic bit flip.
RFC v7:
* Replace compare-exchange-based rte
This patch set represent an attempt to improve and extend the RTE
bitops API, in particular for functions that operate on individual
bits.
All new functionality is exposed to the user as generic selection
macros, delegating the actual work to private (__-marked) static
inline functions. Public fun
Extend bitops tests to cover the rte_bit_atomic_*() family of
functions.
RFC v4:
* Add atomicity test for atomic bit flip.
RFC v3:
* Rename variable 'main' to make ICC happy.
Signed-off-by: Mattias Rönnblom
Acked-by: Morten Brørup
Acked-by: Tyler Retzlaff
---
app/test/test_bitops.c | 313 +
Extend bitops tests to cover the
rte_bit_[test|set|clear|assign|flip]()
functions.
The tests are converted to use the test suite runner framework.
RFC v6:
* Test rte_bit_*test() usage through const pointers.
RFC v4:
* Remove redundant line continuations.
Signed-off-by: Mattias Rönnblom
Acked
Add functionality to test and modify the value of individual bits in
32-bit or 64-bit words.
These functions have no implications on memory ordering, atomicity and
does not use volatile and thus does not prevent any compiler
optimizations.
RFC v6:
* Have rte_bit_test() accept const-marked bitset
> +++ b/lib/eal/linux/eal_alarm.c
> @@ -53,6 +53,13 @@ static struct rte_intr_handle *intr_handle;
> static int handler_registered = 0;
> static void eal_alarm_callback(void *arg);
>
> +#ifndef LIST_FOREACH_SAFE
> +#define LIST_FOREACH_SAFE(var, head, field, tvar)\
> + fo
2024-08-09 10:23 (UTC+0300), Dmitry Kozlyuk:
> 2024-08-08 12:46 (UTC-0700), Stephen Hemminger:
> > This reverts commit a089d320338d708f5b7126dab5fd6861c82e6347.
> >
> > Windows EAL should have been fixed rather than papering over
> > the bug.
>
> Linux and FreeBSD alarm implementations use the
2024-08-08 12:46 (UTC-0700), Stephen Hemminger:
> This reverts commit a089d320338d708f5b7126dab5fd6861c82e6347.
>
> Windows EAL should have been fixed rather than papering over
> the bug.
Linux and FreeBSD alarm implementations use the same approach
that limits possible timeout range in API.
Test
enic_set_mac_address() (mac_addr_add callback) currently allows only
non-zero, unicast address to be added. It is overly restrictive.
rte_eth_dev_mac_addr_add() itself allows multicast addresses. And,
some applications do use rte_eth_dev_mac_addr_add() to accept
multicast addresses. So, remove the
Add 1400/14000 and 15000 models to the speed_capa list.
Signed-off-by: Hyong Youb Kim
Reviewed-by: John Daley
---
doc/guides/nics/enic.rst | 3 ++-
doc/guides/rel_notes/release_24_11.rst | 1 +
drivers/net/enic/enic_ethdev.c | 21 +
3 files changed, 2
The Linux VIC PF driver now requires the use of the admin channel
between PF and VF drivers. Certain devcmds are disabled for VF. The VF
driver is supposed to send control messages through the admin channel
to the PF driver to perform those devcmds. This commit adds the admin
channel to the VF driv
This series contains minor updates for net/enic. The first patch
supports SR-IOV VF, which now requires the use of admin channel. The
other patches are not related to VF, but included here to ease review.
---
v3:
* add spdx, doc, rel_notes (Ferruh's comments)
v2:
* fix compiler warnings
Hyong Y
63 matches
Mail list logo
