Re: [PATCH v5 00/18] NXP DPAA ETH driver enhancement and fixes

2024-10-01 Thread Ferruh Yigit
On 10/1/2024 12:03 PM, Hemant Agrawal wrote: > v5: fix individual patch compilation and checkpatch warning > v4: fix clang compilation issues > v3: addressed Ferruh's comments > - dropped Tx rate limit API patch > - added one small bug fix > - fixed removal/add of fman_offline type > > v2: add

[PATCH] net/gve: fix mbuf allocation memory leak for DQ Rx

2024-10-01 Thread Joshua Washington
Currently, gve_rxq_mbufs_alloc_dqo() allocates RING_SIZE buffers, but only posts RING_SIZE - 1 of them, inevitably leaking a buffer every time queues are stopped/started. This could eventually lead to running out of mbufs if an application stops/starts traffic enough. Fixes: b044845bb015 ("net/gve

[PATCH] net/gve: always attempt Rx refill on DQ

2024-10-01 Thread Joshua Washington
Before this patch, gve_rx_refill_dqo() is only called if the number of packets received in a cycle is non-zero. However, in a memory-constrained scenario, this doesn't behave well, as this could be a potential source of lockup, if there is no memory and all buffers have been received before memory

net/gve: attempt Rx refill even when no packets received on DQ

2024-10-01 Thread Joshua Washington
Before this patch, gve_rx_refill_dqo() is only called if the number of packets received in a cycle is non-zero. However, in a memory-constrained scenario, this doesn't behave well, as this could be a potential source of lockup, if there is no memory and all buffers have been received before memory

Re: [PATCH v3 2/2] timer/linux/x86: override TSC freq if no tsc_known_freq

2024-10-01 Thread Isaac Boukris
On Tue, Oct 1, 2024 at 11:01 PM Bruce Richardson wrote: > > On Tue, Oct 01, 2024 at 03:22:51AM +0300, Isaac Boukris wrote: > > If the tsc_known_freq cpu flag is missing, it means the kernel doesn't > > trust it and calculates its own. We should do the same to avoid drift. > > > > Signed-off-by: Is

[PATCH] eventdev: replace zero-length-array

2024-10-01 Thread Stephen Hemminger
Zero Length Array's (ZLA) are a Gcc extension, and standard Variable Length Array (VLA) should be used instead. Signed-off-by: Stephen Hemminger --- drivers/event/opdl/opdl_ring.c | 2 +- drivers/event/sw/event_ring.h| 2 +- lib/eventdev/rte_event_dma_adapter.h | 2 +- 3 files chan

Re: [PATCH v3 2/2] timer/linux/x86: override TSC freq if no tsc_known_freq

2024-10-01 Thread Isaac Boukris
On Tue, Oct 1, 2024 at 6:22 PM Stephen Hemminger wrote: > > On Tue, 1 Oct 2024 03:22:51 +0300 > Isaac Boukris wrote: > > > diff --git a/lib/eal/windows/eal_timer.c b/lib/eal/windows/eal_timer.c > > index b070cb7751..cfd6c267ac 100644 > > --- a/lib/eal/windows/eal_timer.c > > +++ b/lib/eal/window

Re: [PATCH v2 1/3] net: add thread-safe crc api

2024-10-01 Thread Stephen Hemminger
On Tue, 1 Oct 2024 19:11:48 +0100 Arkadiusz Kusztal wrote: > diff --git a/lib/net/version.map b/lib/net/version.map > index bec4ce23ea..47daf1464a 100644 > --- a/lib/net/version.map > +++ b/lib/net/version.map > @@ -4,11 +4,25 @@ DPDK_25 { > rte_eth_random_addr; > rte_ether_format_ad

Re: [PATCH 5/5] dts: add JSON schema generation script

2024-10-01 Thread Nicholas Pratte
Seems straightforward. There are actually some intersections here between my currently-existing config changes and some of the trimming you provide here which simplifies my upcoming series when I rebase it to use this series. Reviewed-by: Nicholas Pratte On Thu, Aug 22, 2024 at 12:40 PM Luca Viz

Re: [PATCH 4/5] dts: use TestSuiteSpec class imports

2024-10-01 Thread Nicholas Pratte
The code you have here makes sense, and I like the implementation as it removes a lot of fluff in DTSRunner. I know Jurja mentioned in an earlier patch in this series that this functionality intersects with the capabilities series, but I'm missing a lot of context to understand that fully. Maybe yo

[DPDK/DTS Bug 1557] dts: File permission issues for files copied to /tmp

2024-10-01 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1557 Bug ID: 1557 Summary: dts: File permission issues for files copied to /tmp Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity:

[PATCH v3 17/18] net/cnxk: support Tx burst vector for cn20k

2024-10-01 Thread Nithin Dabilpuram
Signed-off-by: Nithin Dabilpuram Signed-off-by: Jerin Jacob Signed-off-by: Rahul Bhansali Signed-off-by: Pavan Nikhilesh --- drivers/net/cnxk/cn20k_tx.h | 1444 ++- 1 file changed, 1440 insertions(+), 4 deletions(-) diff --git a/drivers/net/cnxk/cn20k_tx.h b/dr

Re: [PATCH] service: avoid worker lcore exit deadlock

2024-10-01 Thread David Marchand
Hello, On Tue, Jul 4, 2023 at 11:49 PM Mattias Rönnblom wrote: > > Calling rte_exit() from a worker lcore thread causes a deadlock in > rte_service_finalize(). > > This patch makes rte_service_finalize() deadlock-free by avoiding the > need to synchronize with service lcore threads, which in turn

[PATCH v2 1/3] net: add thread-safe crc api

2024-10-01 Thread Arkadiusz Kusztal
The current net CRC API is not thread-safe, this patch solves this by adding another, thread-safe API functions. This API is also safe to use across multiple processes, yet with limitations on max-simd-bitwidth, which will be checked only by the process that created the CRC context; all other proce

Re: [PATCH v3 2/2] timer/linux/x86: override TSC freq if no tsc_known_freq

2024-10-01 Thread Bruce Richardson
On Tue, Oct 01, 2024 at 03:22:51AM +0300, Isaac Boukris wrote: > If the tsc_known_freq cpu flag is missing, it means the kernel doesn't > trust it and calculates its own. We should do the same to avoid drift. > > Signed-off-by: Isaac Boukris > --- > lib/eal/common/eal_common_timer.c | 3 +- > l

RE: [EXTERNAL] [PATCH v8 2/8] common/zsda: configure device

2024-10-01 Thread Akhil Goyal
> Add support for zsdadev operations such as dev_start and dev_stop. The title of the patch suggest that it include device start and stop. But it seems there is code related to configuration of queue as well. Please move accordingly. > > Signed-off-by: Hanxiao Li > --- > config/rte_config.h

[PATCH v2 3/3] test/crc: replace thread-unsafe api functions

2024-10-01 Thread Arkadiusz Kusztal
This patch replaces thread-unsafe CRC functions with the safe ones. Signed-off-by: Arkadiusz Kusztal --- app/test/test_crc.c | 168 +--- 1 file changed, 67 insertions(+), 101 deletions(-) diff --git a/app/test/test_crc.c b/app/test/test_crc.c inde

[PATCH v2 2/3] crypto/qat: use process safe crc api

2024-10-01 Thread Arkadiusz Kusztal
This patch replaces thread-unsafe CRC functions with the safe ones. Signed-off-by: Arkadiusz Kusztal --- doc/guides/cryptodevs/qat.rst| 6 ++ drivers/crypto/qat/qat_sym.h | 6 ++ drivers/crypto/qat/qat_sym_session.c | 3 +++ drivers/crypto/qat/qat_sym_session.h | 2 ++ 4

[PATCH v2 0/3] net: add thread-safe crc api

2024-10-01 Thread Arkadiusz Kusztal
The current net CRC API is not thread-safe, this patch solves this by adding another, thread-safe API functions. This API is also safe to use across multiple processes, yet with limitations on max-simd-bitwidth, which will be checked only by the process that created the CRC context; all other proce

RE: [EXTERNAL] [PATCH v8 6/8] lib/cryptodev: add sm4 xts for crypto

2024-10-01 Thread Akhil Goyal
Title should be cryptodev: add SM4-XTS > add support of sm4 xts . > > Signed-off-by: Hanxiao Li Send this patch (along with test cases) as a separate patchset "not included in this series." Update documentation doc/guides/cryptodevs/features/defaults.ini Update release notes for adding new al

[PATCH v3 16/18] net/cnxk: support Tx multi-seg in cn20k

2024-10-01 Thread Nithin Dabilpuram
Add Tx multi-seg support in scalar for cn20k. Signed-off-by: Nithin Dabilpuram Signed-off-by: Jerin Jacob Signed-off-by: Rahul Bhansali Signed-off-by: Pavan Nikhilesh --- drivers/net/cnxk/cn20k_tx.h | 352 +++- 1 file changed, 347 insertions(+), 5 deletions(-)

[PATCH v3 14/18] net/cnxk: support Rx burst vector for cn20k

2024-10-01 Thread Nithin Dabilpuram
Add Rx vector support for cn20k Signed-off-by: Nithin Dabilpuram Signed-off-by: Jerin Jacob Signed-off-by: Rahul Bhansali Signed-off-by: Pavan Nikhilesh --- drivers/net/cnxk/cn20k_rx.h | 463 +++- 1 file changed, 459 insertions(+), 4 deletions(-) diff --git a/

[PATCH v3 15/18] net/cnxk: support Tx burst scalar for cn20k

2024-10-01 Thread Nithin Dabilpuram
Add scalar Tx support for cn20k. Signed-off-by: Nithin Dabilpuram Signed-off-by: Jerin Jacob Signed-off-by: Rahul Bhansali Signed-off-by: Pavan Nikhilesh --- drivers/net/cnxk/cn20k_ethdev.c | 127 drivers/net/cnxk/cn20k_tx.h | 986 +++- 2 files changed, 11

[PATCH v3 02/18] common/cnxk: accommodate change in aura field width

2024-10-01 Thread Nithin Dabilpuram
From: Ashwin Sekhar T K Aura field width has changed from 20 bits to 17 bits in cn20k. Adjust the bit fields accordingly for register reads/writes. Signed-off-by: Ashwin Sekhar T K --- drivers/common/cnxk/roc_npa.h | 24 1 file changed, 16 insertions(+), 8 deletions(-)

RE: [EXTERNAL] [PATCH v2 4/4] doc: updated feature matrix for AESNI MB PMD

2024-10-01 Thread Akhil Goyal
> Added support to the AESNI MB PMD feature matrix for SM3, SM3 HMAC, > SM4 CBC, SM4 ECB, SM4 CTR. Updated release notes with same. > > Signed-off-by: Brian Dooley > --- > doc/guides/cryptodevs/features/aesni_mb.ini | 5 + > doc/guides/rel_notes/release_24_11.rst | 4 > 2 files cha

[PATCH v3 03/18] common/cnxk: use new NPA aq enq mbox for cn20k

2024-10-01 Thread Nithin Dabilpuram
From: Ashwin Sekhar T K A new mbox npa_cn20k_aq_enq_req has been added for cn20k. Use this mbox for NPA configurations. Note that the size of these new mbox request and response remains same when compared to the older mboxes. Also the new contexts npa_cn20k_aura_s/ npa_cn20k_pool_s which has bee

[PATCH v3 05/18] common/cnxk: add cn20k NIX register definitions

2024-10-01 Thread Nithin Dabilpuram
From: Satha Rao Add cn20k NIX register definitions. Signed-off-by: Satha Rao Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/hw/nix.h | 524 + drivers/common/cnxk/hw/rvu.h | 7 +- drivers/common/cnxk/roc_mbox.h | 52 drivers/common/cnxk/roc

RE: [EXTERNAL] [PATCH v2] cryptodev: add ec points to sm2 op

2024-10-01 Thread Akhil Goyal
> In the case when PMD cannot support the full process of the SM2, > but elliptic curve computation only, additional fields > are needed to handle such a case. > > Points C1, kP therefore were added to the SM2 crypto operation struct. > > Signed-off-by: Arkadiusz Kusztal > --- > lib/cryptodev/r

[PATCH v3 09/18] common/cnxk: add RSS support for cn20k

2024-10-01 Thread Nithin Dabilpuram
From: Satha Rao Add RSS configuration support for cn20k. Signed-off-by: Satha Rao --- drivers/common/cnxk/roc_nix_rss.c | 74 +-- 1 file changed, 70 insertions(+), 4 deletions(-) diff --git a/drivers/common/cnxk/roc_nix_rss.c b/drivers/common/cnxk/roc_nix_rss.c in

[PATCH v3 01/18] mempool/cnxk: add cn20k PCI device ids

2024-10-01 Thread Nithin Dabilpuram
From: Ashwin Sekhar T K Add cn20k PCI device ids. Signed-off-by: Ashwin Sekhar T K --- doc/guides/rel_notes/release_24_11.rst | 4 drivers/mempool/cnxk/cnxk_mempool.c| 2 ++ 2 files changed, 6 insertions(+) diff --git a/doc/guides/rel_notes/release_24_11.rst b/doc/guides/rel_notes/r

Re: net/netvsc: problem with configuring netvsc port after first port start

2024-10-01 Thread Stephen Hemminger
On Tue, 1 Oct 2024 18:09:17 +0200 Edwin Brossette wrote: > testpmd> port stop 3 > Stopping ports... > Done > > -> Then, change something in the port config. This will trigger a call > to rte_eth_dev_configure() on the next port start. Here I change the link > speed/duplex: > testpmd> port c

RE: [EXTERNAL] [PATCH] app/test: refactor cryptodev test cases

2024-10-01 Thread Akhil Goyal
> This commit introduces several changes to the cryptodev > test cases that should make it easier to maintain. > > Changes included in this patch: > - If not needed by the specific test case, the device should be > started/stopped in the particular testsuite setup/teardown > function. > - Most of

[PATCH v2] net/iavf: preserve MAC address with i40e PF Linux driver

2024-10-01 Thread David Marchand
Following two upstream Linux kernel changes (see links), the mac address of a iavf port, serviced by a i40e PF driver, is lost when the DPDK iavf driver probes the port again (which may be triggered at any point of a DPDK application life, like when a reset event is triggered by the PF). A first c

Re: [PATCH v4 03/17] dma/ixd: fix incorrect free function in cleanup

2024-10-01 Thread Bruce Richardson
On Mon, Sep 30, 2024 at 11:43:57AM -0700, Stephen Hemminger wrote: > The data structure is allocated with rte_malloc and incorrectly > freed in cleanup logic using free. > > Bugzilla ID: 1549 > Fixes: 9449330a8458 ("dma/idxd: create dmadev instances on PCI probe") > Cc: kevin.la...@intel.com > Cc:

Re: [PATCH 4/5] dts: use TestSuiteSpec class imports

2024-10-01 Thread Dean Marx
On Thu, Aug 22, 2024 at 12:40 PM Luca Vizzarro wrote: > The introduction of TestSuiteSpec adds auto-discovery of test suites, > which are also automatically imported. This causes double imports as the > runner loads the test suites. This changes the behaviour of the runner > to load the imported

Re: [PATCH v5 03/17] dma/ixd: fix incorrect free function in cleanup

2024-10-01 Thread Bruce Richardson
On Tue, Oct 01, 2024 at 09:35:26AM -0700, Stephen Hemminger wrote: > The data structure is allocated with rte_malloc and incorrectly > freed in cleanup logic using free. > > Bugzilla ID: 1549 > Fixes: 9449330a8458 ("dma/idxd: create dmadev instances on PCI probe") > Cc: kevin.la...@intel.com > Cc:

[DPDK/DTS Bug 1556] dts: Add setuptools to poetry dependencies

2024-10-01 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1556 Bug ID: 1556 Summary: dts: Add setuptools to poetry dependencies Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: minor

[PATCH v5 17/17] eal: add function attributes for allocation functions

2024-10-01 Thread Stephen Hemminger
The allocation functions take a alignment argument that can be useful to hint the compiler optimizer. This is supported by GCC and Clang but only useful with GCC because Clang gives warning if alignment is 0. Newer versions of GCC have a malloc attribute that can be used to find mismatches between

[PATCH v5 16/17] common/idpf: fix use after free due

2024-10-01 Thread Stephen Hemminger
The macro in this driver was redefining LIST_FOR_EACH_ENTRY_SAFE as a simple LIST_FOR_EACH macro. But they are not the same the _SAFE variant guarantees that there will not be use after free. Fixes: fb4ac04e9bfa ("common/idpf: introduce common library") Cc: junfeng@intel.com Signed-off-by: Ste

[PATCH v5 15/17] baseband/la12xx: prevent use after free

2024-10-01 Thread Stephen Hemminger
It is possible that the info pointer (hp) could get freed twice. Fix by nulling after free. In function 'setup_la12xx_dev', inlined from 'la12xx_bbdev_create' at ../drivers/baseband/la12xx/bbdev_la12xx.c:1029:8, inlined from 'la12xx_bbdev_probe' at ../drivers/baseband/la12xx/bbdev_la12xx.c:1075:

[PATCH v5 14/17] drivers/ifpga: fix free function mismatch

2024-10-01 Thread Stephen Hemminger
The raw ifpga driver redefines malloc to be opae_malloc and free to be opae_free; which is a bad idea. This leads to case where interrupt efd array is allocated with calloc() and then passed to rte_free. The workaround is to allocate the array with rte_calloc() instead. Fixes: d61138d4f0e2 ("driv

[PATCH v5 13/17] common/qat: fix use after free

2024-10-01 Thread Stephen Hemminger
Checking return value of rte_memzone_free() is pointless and if it failed then it was because the pointer was null. Fixes: 7b1374b1e6e7 ("common/qat: limit configuration to primary process") Cc: arkadiuszx.kusz...@intel.com Signed-off-by: Stephen Hemminger --- drivers/common/qat/qat_device.c |

[PATCH v5 12/17] raw/ifpga/base: fix use after free

2024-10-01 Thread Stephen Hemminger
The TAILQ_FOREACH() macro would refer to info after it had been freed. Fix by introducing TAILQ_FOREACH_SAFE here. Fixes: 4a19f89104f8 ("raw/ifpga/base: support multiple cards") Cc: sta...@dpdk.org Signed-off-by: Stephen Hemminger --- drivers/raw/ifpga/base/opae_intel_max10.c | 11 +--

[PATCH v5 11/17] net/nfp: fix duplicate call to rte_free

2024-10-01 Thread Stephen Hemminger
Calling rte_free twice on same object will corrupt the heap. Warning is: In function 'nfp_pre_tun_table_check_del', inlined from 'nfp_flow_destroy' at ../drivers/net/nfp/flower/nfp_flower_flow.c:5143:9: ../drivers/net/nfp/flower/nfp_flower_flow.c:3830:9: error: pointer 'entry' used after 'rte_fre

[PATCH v5 10/17] net/cpfl: fix free of nonheap object

2024-10-01 Thread Stephen Hemminger
With proper annotation, GCC discovers that this driver is calling rte_free() on an object that was not allocated (it is part of array in another object). In function ‘cpfl_flow_js_mr_layout’, inlined from ‘cpfl_flow_js_mr_action’ at ../drivers/net/cpfl/cpfl_flow_parser.c:848:9, inlined fr

[PATCH v5 09/17] net/sfc: fix use-after-free warning messages

2024-10-01 Thread Stephen Hemminger
If compiler detection of use-after-free is enabled then this drivers debug messages will cause warnings. Change to move debug message before the object is freed. Bugzilla ID: 1551 Fixes: 55c1238246d5 ("net/sfc: add more debug messages to transfer flows") Signed-off-by: Stephen Hemminger Reviewed-

[PATCH v5 08/17] net/e1000: fix use-after-free

2024-10-01 Thread Stephen Hemminger
The driver cleanup code was freeing the filter object then dereferencing it. Bugzilla ID: 1550 Fixes: 6a4d050e2855 ("net/igb: flush all the filter") Cc: sta...@dpdk.org Signed-off-by: Stephen Hemminger --- drivers/net/e1000/igb_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH v5 07/17] bpf: fix free mismatch if convert fails

2024-10-01 Thread Stephen Hemminger
If conversion of cBF to eBPF fails then an object allocated with rte_malloc() would be passed to free(). [908/3201] Compiling C object lib/librte_bpf.a.p/bpf_bpf_convert.c.o ../lib/bpf/bpf_convert.c: In function ‘rte_bpf_convert’: ../lib/bpf/bpf_convert.c:559:17: warning: ‘free’ called on pointer

[PATCH v5 06/17] net/cnxk: fix use-after-free

2024-10-01 Thread Stephen Hemminger
The driver would refer to the mempool object after it was freed. Bugzilla ID: 1554 Fixes: 7ea187184a51 ("common/cnxk: support 1-N pool-aura per NIX LF") Cc: rbhans...@marvell.com Cc: sta...@dpdk.org Signed-off-by: Stephen Hemminger --- drivers/net/cnxk/cnxk_ethdev_sec.c | 2 +- 1 file changed,

[PATCH v5 05/17] examples/vhost: fix free function mismatch

2024-10-01 Thread Stephen Hemminger
The pointer bdev is allocated with rte_zmalloc() and then incorrectly freed with free() which will lead pool corruption. Bugzilla ID: 1553 Fixes: c19beb3f38cd ("examples/vhost_blk: introduce vhost storage sample") Cc: sta...@dpdk.org Signed-off-by: Stephen Hemminger Acked-by: Chengwen Feng ---

[PATCH v5 04/17] event/cnxk: fix pointer mismatch in cleanup

2024-10-01 Thread Stephen Hemminger
The code to cleanup in case of error was passing incorrect value to rte_free. The ports[] entry was allocated with rte_malloc and that should be used instead of the offset in that object. Fixes: 97a05c1fe634 ("event/cnxk: add port config") Cc: sthot...@marvell.com Cc: sta...@dpdk.org Signed-off-b

[PATCH v5 03/17] dma/ixd: fix incorrect free function in cleanup

2024-10-01 Thread Stephen Hemminger
The data structure is allocated with rte_malloc and incorrectly freed in cleanup logic using free. Bugzilla ID: 1549 Fixes: 9449330a8458 ("dma/idxd: create dmadev instances on PCI probe") Cc: kevin.la...@intel.com Cc: sta...@dpdk.org Signed-off-by: Stephen Hemminger --- drivers/dma/idxd/idxd_pc

[PATCH v5 02/17] cryptodev/bcmfs: fix mis-matched free

2024-10-01 Thread Stephen Hemminger
The device structure is allocated with rte_malloc() and then incorrectly freed with free(). This will lead to corrupt malloc pool. Bugzilla ID: 1552 Fixes: c8e79da7c676 ("crypto/bcmfs: introduce BCMFS driver") Cc: sta...@dpdk.org Signed-off-by: Stephen Hemminger Acked-by: Ajit Khaparde --- dri

[PATCH v5 01/17] memzone: fix use after free in tracing

2024-10-01 Thread Stephen Hemminger
Using the freed value for tracing is not a good idea. Although it is harmless for tracing, it will cause analyzers to flag this as unsafe. Signed-off-by: Stephen Hemminger Acked-by: Chengwen Feng Acked-by: Anatoly Burakov --- lib/eal/common/eal_common_memzone.c | 3 ++- 1 file changed, 2 inser

[PATCH v5 00/17] Fix allocation related bugs and add attributes

2024-10-01 Thread Stephen Hemminger
Recent versions of GCC have some additional function attributes that can help with DPDK performance and stability. The alloc_align attribute tells the compiler what the alignment of the allocation will be, and the optimizer can use this to produce better code (especially memcpy and structure copie

[PATCH v3 07/18] common/cnxk: support bandwidth profile for cn20k

2024-10-01 Thread Nithin Dabilpuram
From: Satha Rao Add support to setup bandwidth profile config for cn20k for Rx policier. Signed-off-by: Satha Rao --- drivers/common/cnxk/roc_nix_bpf.c | 528 ++-- drivers/common/cnxk/roc_nix_queue.c | 136 --- 2 files changed, 425 insertions(+), 239 deletions(-)

net/netvsc: problem with configuring netvsc port after first port start

2024-10-01 Thread Edwin Brossette
Hello, I have run into an issue since I switched from the failsafe/vdev-netvsc pmd to the netvsc pmd. I have noticed that once I have first started my port, if I try to stop and reconfigure it, the call to rte_eth_dev_configure() fails with a couple of error logged from the netvsc pmd. It can be r

[PATCH v3 04/18] mempool/cnxk: initialize mempool ops for cn20k

2024-10-01 Thread Nithin Dabilpuram
From: Ashwin Sekhar T K Initialize mempool ops for cn20k. Signed-off-by: Ashwin Sekhar T K --- drivers/mempool/cnxk/cnxk_mempool_ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mempool/cnxk/cnxk_mempool_ops.c b/drivers/mempool/cnxk/cnxk_mempool_ops.c index a1

Re: [PATCH v2] net/iavf: preserve MAC address with i40e PF Linux driver

2024-10-01 Thread Bruce Richardson
On Tue, Oct 01, 2024 at 11:12:54AM +0200, David Marchand wrote: > Following two upstream Linux kernel changes (see links), the mac address > of a iavf port, serviced by a i40e PF driver, is lost when the DPDK iavf > driver probes the port again (which may be triggered at any point of a > DPDK appli

[PATCH v3 00/18] add Marvell cn20k SOC support for mempool and net

2024-10-01 Thread Nithin Dabilpuram
This series adds support for Marvell cn20k SOC for mempool and net PMD's. This series also adds few net/cnxk PMD updates to expose IPsec features supported by HW that are very custom in nature and some enhancements for cn10k. Ashwin Sekhar T K (4): mempool/cnxk: add cn20k PCI device ids comm

[PATCH v3 06/18] common/cnxk: support NIX queue config for cn20k

2024-10-01 Thread Nithin Dabilpuram
From: Satha Rao Add support to setup NIX RQ, SQ, CQ for cn20k. Signed-off-by: Satha Rao --- drivers/common/cnxk/roc_nix_fc.c | 52 ++- drivers/common/cnxk/roc_nix_inl.c| 2 + drivers/common/cnxk/roc_nix_priv.h | 1 + drivers/common/cnxk/roc_nix_queue.c | 532 +++

[PATCH v3 18/18] net/cnxk: support Tx multi-seg in vector for cn20k

2024-10-01 Thread Nithin Dabilpuram
Add Tx multi-seg support for cn20k. Signed-off-by: Nithin Dabilpuram Signed-off-by: Jerin Jacob Signed-off-by: Rahul Bhansali Signed-off-by: Pavan Nikhilesh --- drivers/net/cnxk/cn20k_tx.h | 485 ++-- 1 file changed, 463 insertions(+), 22 deletions(-) diff --g

[PATCH v3 08/18] common/cnxk: support NIX debug for cn20k

2024-10-01 Thread Nithin Dabilpuram
From: Satha Rao Add support to dump cn20k queue structs and also provide the same in telemetry data. Signed-off-by: Satha Rao --- drivers/common/cnxk/cnxk_telemetry_nix.c | 260 ++- drivers/common/cnxk/roc_nix_debug.c | 234 +++- drivers/common/cnxk/roc

[PATCH] service: avoid worker lcore exit deadlock

2024-10-01 Thread Mattias Rönnblom
Calling rte_exit() from a worker lcore thread causes a deadlock in rte_service_finalize(). This patch makes rte_service_finalize() deadlock-free by avoiding the need to synchronize with service lcore threads, which in turn is achieved by moving service and per-lcore state from the heap to being st

[PATCH dpdk v2 09/16] pipeline: use ipv6 addr struct

2024-10-01 Thread Robin Jarry
Update rte_table_action_ipv6_header and rte_table_action_nat_params to use the recently added IPv6 address structure instead of uint8_t[16] arrays. Signed-off-by: Robin Jarry --- Notes: v2: updated changelog for 24.11 doc/guides/rel_notes/deprecation.rst | 2 -- doc/guides/rel_notes/rel

[PATCH dpdk v2 03/16] net: add structure for ipv6 addresses

2024-10-01 Thread Robin Jarry
There is currently no structure defined for IPv6 addresses. Introduce one that is simply a uint8_t array of 16 elements without any union. The idea is to ensure this structure alignment is 1 so that it can be mapped directly on unaligned packet memory. Signed-off-by: Robin Jarry --- lib/net/rte_

[PATCH dpdk v2 10/16] ipsec: use ipv6 addr struct

2024-10-01 Thread Robin Jarry
Update rte_ipsec_sadv6_key to use the recently introduced IPv6 address structure instead of ad-hoc uint8_t[16] arrays. Signed-off-by: Robin Jarry --- Notes: v2: updated changelog for 24.11 app/test-sad/main.c| 24 +++--- app/test/test_ipsec_sad.c |

[PATCH dpdk v2 01/16] net: split raw checksum functions in separate header

2024-10-01 Thread Robin Jarry
The checksum functions are used by both ipv4 and ipv6 functions. In preparation of moving ipv6 symbols to a new header, move the checksum related symbols to another dedicated header. Signed-off-by: Robin Jarry --- Notes: v2: cleaned up includes lib/net/meson.build | 1 + lib/net/rte_cksu

Re: [PATCH v2 03/14] net/dpaa: remove broken debug macros

2024-10-01 Thread Hemant Agrawal
On 01-10-2024 17:38, David Marchand wrote: On Tue, Oct 1, 2024 at 12:19 PM Thomas Monjalon wrote: 12/09/2024 10:26, David Marchand: Those debug macros never worked as existing callers never passed a 'level' argument. Remove them. Signed-off-by: David Marchand Why not removing the calls to

[PATCH v3 13/18] net/cnxk: support Rx burst scalar for cn20k

2024-10-01 Thread Nithin Dabilpuram
Add Rx burst support scalar version for cn20k. Signed-off-by: Nithin Dabilpuram Signed-off-by: Jerin Jacob Signed-off-by: Rahul Bhansali Signed-off-by: Pavan Nikhilesh --- drivers/net/cnxk/cn20k_ethdev.c| 126 + drivers/net/cnxk/cn20k_rx.h| 394

[RFC PATCH v13] mempool: fix mempool cache size

2024-10-01 Thread Morten Brørup
This patch refactors the mempool cache to fix two bugs: 1. When a mempool is created with a per-lcore cache size of N objects, the per-lcore caches were actually created with a size of 1.5 * N objects. 2. The mempool cache field names did not reflect their purpose; the "flushthresh" field held the

[PATCH v2 2/8] event/dlb2: use global AVX-512 variables

2024-10-01 Thread Bruce Richardson
Replace per-driver checks for AVX-512 with the standard variables from config/x86. Signed-off-by: Bruce Richardson --- drivers/event/dlb2/meson.build | 42 -- 1 file changed, 9 insertions(+), 33 deletions(-) diff --git a/drivers/event/dlb2/meson.build b/drivers/e

Re: [PATCH v4 00/18] NXP DPAA ETH driver enhancement and fixes

2024-10-01 Thread Ferruh Yigit
On 9/30/2024 1:15 PM, Hemant Agrawal wrote: > v4: fix clan compilation issues > v3: addressed Ferruh's comments > - dropped Tx rate limit API patch > - added one small bug fix > - fixed removal/add of fman_offline type > > v2: address review comments > - improve commit message > - add docume

Re: [PATCH v2 03/14] net/dpaa: remove broken debug macros

2024-10-01 Thread Thomas Monjalon
12/09/2024 10:26, David Marchand: > Those debug macros never worked as existing callers never passed a > 'level' argument. > Remove them. > > Signed-off-by: David Marchand > --- > drivers/net/dpaa/fmlib/fm_ext.h | 21 ++--- > 1 file changed, 2 insertions(+), 19 deletions(-) > >

[PATCH v2 3/8] common/idpf: use global AVX-512 variables

2024-10-01 Thread Bruce Richardson
Replace per-driver checks for AVX-512 with the standard variables from config/x86. Signed-off-by: Bruce Richardson --- drivers/common/idpf/meson.build | 17 ++--- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/drivers/common/idpf/meson.build b/drivers/common/idpf/meso

Re: [PATCH v4 01/17] memzone: fix use after free in tracing

2024-10-01 Thread Burakov, Anatoly
On 9/30/2024 8:43 PM, Stephen Hemminger wrote: Using the freed value for tracing is not a good idea. Although it is harmless for tracing, it will cause analyzers to flag this as unsafe. Signed-off-by: Stephen Hemminger Acked-by: Chengwen Feng --- lib/eal/common/eal_common_memzone.c | 3 ++-

Re: [PATCH v2] net/iavf: preserve MAC address with i40e PF Linux driver

2024-10-01 Thread Bruce Richardson
On Tue, Oct 01, 2024 at 11:12:54AM +0200, David Marchand wrote: > Following two upstream Linux kernel changes (see links), the mac address > of a iavf port, serviced by a i40e PF driver, is lost when the DPDK iavf > driver probes the port again (which may be triggered at any point of a > DPDK appli

Re: [PATCH v2 00/18] add Marvell cn20k SOC support for mempool and net

2024-10-01 Thread Jerin Jacob
On Fri, Sep 27, 2024 at 9:19 AM Nithin Dabilpuram wrote: > > This series adds support for Marvell cn20k SOC for mempool and > net PMD's. > > This series also adds few net/cnxk PMD updates to expose IPsec > features supported by HW that are very custom in nature and > some enhancements for cn10k. >

[PATCH v3 12/18] net/cnxk: support Tx function select for cn20k

2024-10-01 Thread Nithin Dabilpuram
Add support to select Tx function based on offload flags for cn20k. Signed-off-by: Nithin Dabilpuram --- drivers/net/cnxk/cn20k_ethdev.c | 80 ++ drivers/net/cnxk/cn20k_ethdev.h | 1 + drivers/net/cnxk/cn20k_tx.h | 237 ++ driv

[PATCH v2 8/8] net/idpf: use global AVX-512 variables

2024-10-01 Thread Bruce Richardson
Replace per-driver checks for AVX-512 with the standard variables from config/x86. Signed-off-by: Bruce Richardson --- drivers/net/idpf/meson.build | 19 ++- 1 file changed, 2 insertions(+), 17 deletions(-) diff --git a/drivers/net/idpf/meson.build b/drivers/net/idpf/meson.build

RE: [PATCH v4] eal: add build-time option to omit trace

2024-10-01 Thread Morten Brørup
> From: Jerin Jacob [mailto:jerinjac...@gmail.com] > Sent: Tuesday, 1 October 2024 17.02 > > On Tue, Oct 1, 2024 at 7:44 PM Morten Brørup > wrote: > > > > > From: Jerin Jacob [mailto:jerinjac...@gmail.com] > > > Sent: Tuesday, 1 October 2024 16.05 > > > > > > On Tue, Oct 1, 2024 at 7:19 PM Morten

RE: [PATCH v4] eal: add build-time option to omit trace

2024-10-01 Thread Morten Brørup
> From: Jerin Jacob [mailto:jerinjac...@gmail.com] > Sent: Tuesday, 1 October 2024 18.06 > > On Tue, Oct 1, 2024 at 9:32 PM Morten Brørup > wrote: > > > > > From: Jerin Jacob [mailto:jerinjac...@gmail.com] > > > Sent: Tuesday, 1 October 2024 17.02 > > > > > > On Tue, Oct 1, 2024 at 7:44 PM Morten

Re: [PATCH v4] eal: add build-time option to omit trace

2024-10-01 Thread Jerin Jacob
On Tue, Oct 1, 2024 at 9:32 PM Morten Brørup wrote: > > > From: Jerin Jacob [mailto:jerinjac...@gmail.com] > > Sent: Tuesday, 1 October 2024 17.02 > > > > On Tue, Oct 1, 2024 at 7:44 PM Morten Brørup > > wrote: > > > > > > > From: Jerin Jacob [mailto:jerinjac...@gmail.com] > > > > Sent: Tuesday,

RE: [EXTERNAL] [PATCH v2 4/4] doc: updated feature matrix for AESNI MB PMD

2024-10-01 Thread Akhil Goyal
> Added support to the AESNI MB PMD feature matrix for SM3, SM3 HMAC, > SM4 CBC, SM4 ECB, SM4 CTR. Updated release notes with same. > > Signed-off-by: Brian Dooley > --- > doc/guides/cryptodevs/features/aesni_mb.ini | 5 + > doc/guides/rel_notes/release_24_11.rst | 4 > 2 files cha

Re: [PATCH dpdk v2 06/16] net: add ipv6 address utilities

2024-10-01 Thread Stephen Hemminger
On Tue, 1 Oct 2024 10:17:18 +0200 Robin Jarry wrote: > +/** Shorthand to initialize IPv6 address values */ > +#define RTE_IPV6_ADDR(...) ((struct rte_ipv6_addr){.a = {__VA_ARGS__}}) > + > +/** > + * Copy an IPv6 address into another one. > + * > + * @param dst > + * The address into which to c

Re: [PATCH v3] common/cnxk: fix IRQ reconfiguration

2024-10-01 Thread Jerin Jacob
On Sun, Sep 29, 2024 at 9:38 PM wrote: > > From: Pavan Nikhilesh > > Unregister SSO device and NPA IRQs before resizing > IRQs to cleanup stale IRQ handles. > > Fixes: 993107f0f440 ("common/cnxk: limit SSO interrupt allocation count") > Cc: sta...@dpdk.org > > Signed-off-by: Pavan Nikhilesh > --

[PATCH dpdk v2 15/16] net: add utilities for well known ipv6 address types

2024-10-01 Thread Robin Jarry
Add more utilities to work with IPv6 addresses. These functions will be required in order to help building IPv6 routing applications. Signed-off-by: Robin Jarry --- Notes: v2: - added more multicast helpers - fixed all routers well known multicast addresses app/test/test_net_i

[PATCH dpdk v2 16/16] ipv6: add function to check ipv6 version

2024-10-01 Thread Robin Jarry
This is a slow path version to verify the version field in IPv6 headers. Signed-off-by: Robin Jarry --- Notes: v2: new patch app/test/test_net_ipv6.c | 16 lib/net/rte_ip6.h| 17 + 2 files changed, 33 insertions(+) diff --git a/app/test/test_net_ip

[PATCH dpdk v2 02/16] net: split ipv6 symbols in separate header

2024-10-01 Thread Robin Jarry
Move all ipv6 related symbols to a dedicated header. Update all code accordingly. Signed-off-by: Robin Jarry --- app/test/packet_burst_generator.c | 1 + app/test/test_cryptodev_security_ipsec.c| 1 + doc/guides/rel_notes/release_24_11.rst | 1 + drivers/common/cnxk/cnxk

[PATCH dpdk v2 13/16] rte_flow: use ipv6 addr struct

2024-10-01 Thread Robin Jarry
Update rte_flow_tunnel, rte_flow_action_set_ipv6, rte_flow_item_icmp6_nd_na and rte_flow_item_icmp6_nd_ns to use the recently introduced IPv6 address structure instead of uint8_t[16] arrays. Update all code accordingly. Signed-off-by: Robin Jarry --- Notes: v2: updated changelog for 24.11

[PATCH dpdk v2 14/16] rib6,fib6,lpm6: remove duplicate constants

2024-10-01 Thread Robin Jarry
Replace all address size and max depth macros with common ones from rte_ip6.h. Signed-off-by: Robin Jarry --- app/test/test_fib6.c | 50 ++-- lib/fib/rte_fib6.c | 6 +++--- lib/fib/rte_fib6.h | 4 lib/fib/trie.c | 6 +++--- lib/fib/trie.h

[PATCH dpdk v2 04/16] net: use ipv6 structure for header addresses

2024-10-01 Thread Robin Jarry
The rte_ipv6_hdr uses ad-hoc uint8_t[16] arrays to represent addresses. Replace these arrays with the previously introduced rte_ipv6_addr structure. Adapt all code accordingly. Signed-off-by: Robin Jarry --- Notes: v2: updated changelog for 24.11 app/test-flow-perf/items_gen.c |

[PATCH dpdk v2 06/16] net: add ipv6 address utilities

2024-10-01 Thread Robin Jarry
Add utility functions that use the previously introduced IPv6 address structure. Add basic unit tests to ensure everything works as expected. These functions will be used in the next commits to replace private and/or duplicated functions. Signed-off-by: Robin Jarry --- Notes: v2: -

Re: [PATCH v4] eal: add build-time option to omit trace

2024-10-01 Thread Jerin Jacob
On Tue, Oct 1, 2024 at 7:44 PM Morten Brørup wrote: > > > From: Jerin Jacob [mailto:jerinjac...@gmail.com] > > Sent: Tuesday, 1 October 2024 16.05 > > > > On Tue, Oct 1, 2024 at 7:19 PM Morten Brørup > > wrote: > > > > > > Jerin, > > > > > > If you have no further comments, please add review/ack

Re: [PATCH v4 17/17] eal: add function attributes for allocation functions

2024-10-01 Thread Stephen Hemminger
On Tue, 1 Oct 2024 14:25:46 +0200 David Marchand wrote: > On Tue, Oct 1, 2024 at 2:21 PM Burakov, Anatoly > wrote: > > > + > > > +/** > > > + * Frees the memory space pointed to by the provided pointer. > > > + * > > > + * This pointer must have been returned by a previous call to > > > + * rte_

[PATCH dpdk v2 00/16] IPv6 APIs overhaul

2024-10-01 Thread Robin Jarry
Hi everyone, As discussed recently [1], here is a first draft of the IPv6 APIs rework. The API change was announced before the 24.07 release [2]. This series is intended for 24.11. [1] http://inbox.dpdk.org/dev/d2sr8t1h39cj.jrqfi6jeh...@redhat.com/ [2] https://git.dpdk.org/dpdk/commit/?id=835d4c

[PATCH dpdk v2 08/16] graph,node: use ipv6 addr struct and utils

2024-10-01 Thread Robin Jarry
Replace ad-hoc uint8_t[16] arrays with the previously introduced IPv6 address structure. Signed-off-by: Robin Jarry --- Notes: v2: updated changelog for 24.11 app/graph/ethdev.c | 40 +++--- app/graph/ethdev.h | 9 +++-- app/graph/ip

Re: [PATCH v2] service: extend service function call statistics

2024-10-01 Thread David Marchand
On Mon, Sep 9, 2024 at 9:28 PM Mattias Rönnblom wrote: > > Add two new per-service counters. > > RTE_SERVICE_ATTR_IDLE_CALL_COUNT tracks the number of service function > invocations where no work was performed. > > RTE_SERVICE_ATTR_ERROR_CALL_COUNT tracks the number invocations > resulting in an e

[PATCH dpdk v2 12/16] gro: use ipv6 addr struct

2024-10-01 Thread Robin Jarry
Update tcp6_flow_key to use the recently introduced IPv6 address structure instead of uint8_t[16] arrays. Signed-off-by: Robin Jarry --- Notes: v2: updated changelog for 24.11 doc/guides/rel_notes/deprecation.rst | 2 -- doc/guides/rel_notes/release_24_11.rst | 2 ++ lib/gro/gro_tcp6.c

Re: [PATCH v2 1/1] net/octeon_ep: add device removal event callback

2024-10-01 Thread Jerin Jacob
On Fri, Sep 20, 2024 at 10:14 AM Vamsi Krishna wrote: > > From: Vamsi Attunuru > > Adds an event callback to catch any device removal > event occurred during driver probe. This callback helps > in terminating the execution if there is any device removal > event during the driver probe. > > Also m

  1   2   >