Re: [PATCH v12 1/4] lib: add generic support for reading PMU events

2024-10-06 Thread Jerin Jacob
On Sat, Sep 28, 2024 at 3:37 AM Tomasz Duszynski wrote: > > Add support for programming PMU counters and reading their values > in runtime bypassing kernel completely. > > This is especially useful in cases where CPU cores are isolated > i.e run dedicated tasks. In such cases one cannot use standa

RE: [PATCH v6] eal: add build-time option to omit trace

2024-10-06 Thread Morten Brørup
> From: Jerin Jacob [mailto:jerinjac...@gmail.com] > Sent: Monday, 7 October 2024 07.45 > > On Sun, Oct 6, 2024 at 7:44 PM Morten Brørup > wrote: > > > > Some applications want to omit the trace feature. > > Either to reduce the memory footprint, to reduce the exposed attack > > surface, or for o

Re: [PATCH v6] eal: add build-time option to omit trace

2024-10-06 Thread Jerin Jacob
On Sun, Oct 6, 2024 at 7:44 PM Morten Brørup wrote: > > Some applications want to omit the trace feature. > Either to reduce the memory footprint, to reduce the exposed attack > surface, or for other reasons. > > This patch adds an option in rte_config.h to include or omit trace in the > build. Tr

Re: [PATCH] net/ena: restructure the llq policy user setting

2024-10-06 Thread Ferruh Yigit
On 10/6/2024 1:32 PM, shaib...@amazon.com wrote: > From: Shai Brandes > > Replaced `enable_llq`, `normal_llq_hdr` and `large_llq_hdr` > devargs with a new shared devarg named `llq_policy` that > implements the same logic and accepts the following values: > 0 - Disable LLQ. > Use with extreme

Re: [PATCH v9 8/8] net/hns3: support filter registers by module names

2024-10-06 Thread Ferruh Yigit
On 10/4/2024 2:59 PM, David Marchand wrote: > On Thu, Sep 26, 2024 at 2:44 PM Jie Hai wrote: >> diff --git a/drivers/net/hns3/hns3_regs.c b/drivers/net/hns3/hns3_regs.c >> index a0d130302839..2e19add21265 100644 >> --- a/drivers/net/hns3/hns3_regs.c >> +++ b/drivers/net/hns3/hns3_regs.c > > [snip

Re: [PATCH] net/bnxt: fix newline character in speed display

2024-10-06 Thread Ferruh Yigit
On 10/4/2024 9:55 PM, Ajit Khaparde wrote: > On Fri, Oct 4, 2024 at 1:53 PM Damodharam Ammepalli > wrote: >> >> Mistakenly "\n" sneaked into bnxt_print_link_info which >> prints the speed and lanes information of Broadcom Thor2 NIC. >> This patch removes this newline character. >> >> Fixes: 7bc8e9

[PATCH v17 3/3] event/dsw: add capability for independent enqueue

2024-10-06 Thread Abdullah Sevincer
To use independent enqueue capability applications need to set flag RTE_EVENT_PORT_CFG_INDEPENDENT_ENQ during port setup only if the capability RTE_EVENT_DEV_CAP_INDEPENDENT_ENQ exists. Hence, this commit adds the capability of independent enqueue to the DSW driver. Signed-off-by: Abdullah Sevince

[PATCH v17 2/3] event/dlb2: add support for independent enqueue

2024-10-06 Thread Abdullah Sevincer
DLB devices need events to be enqueued in the same order they are dequeued. Applications are not suppose to change event order between dequeue and to enqueue. Since Eventdev standard does not add such restrictions independent enqueue support is needed for DLB PMD so that it restores dequeue order o

[PATCH v17 1/3] eventdev: add support for independent enqueue

2024-10-06 Thread Abdullah Sevincer
Support for independent enqueue feature and updates Event Device and PMD feature list. A new capability RTE_EVENT_DEV_CAP_INDEPENDENT_ENQ is introduced. It allows out-of-order enqueuing of RTE_EVENT_OP_FORWARD or RELEASE type events on an event port where this capability is enabled. To use this c

[PATCH v17 0/3] Independent Enqueue Support

2024-10-06 Thread Abdullah Sevincer
v17: Address comments. v16: Address comments. v15: Address comments. v14: Address comments. v13: Address comments. v12: Address comments. v11: Address comments. v10: Add acked-by reviewer name. v9: Address comments. v8: Address build issues. v7: Address documentation reviews. v6: Update patch with

[PATCH v2] doc: reword sample app guides

2024-10-06 Thread Nandini Persad
I have reviewed these sections for grammar/clarity and made small modifications to the formatting of sections to adhere to a template which will create uniformality in the sample application user guides overall. Signed-off-by: Nandini Persad --- .../prog_guide/switch_representation.rst | 18

[PATCH] doc: reword sample app guides

2024-10-06 Thread Nandini Persad
I have reviewed these sections for grammar/clarity and made small modifications to the formatting of sections to adhere to a template which will create uniformality in the sample application user guides overall. Signed-off-by: Nandini Persad --- .../prog_guide/switch_representation.rst | 18

Re: [PATCH v1 00/50] Provide: flow filter init API, Enable virtual queues, fix ntnic issues for release 24.07

2024-10-06 Thread Stephen Hemminger
On Sun, 6 Oct 2024 22:36:27 +0200 Serhii Iliushyk wrote: > *** BLURB HERE *** Please add a short paragraph to the cover letter > > Danylo Vodopianov (15): > net/ntnic: fix coverity issues: > net/ntnic: extend and fix logging implementation > net/ntnic: add basic queue operations > n

Re: [PATCH v6] doc: add new driver guidelines

2024-10-06 Thread Ferruh Yigit
On 10/6/2024 7:42 PM, Nandini Persad wrote: > This document was created to assist contributors in creating DPDK drivers > and provides suggestions and guidelines on how to upstream effectively. > > Signed-off-by: Ferruh Yigit > Signed-off-by: Nandini Persad > Reviewed-by: Stephen Hemminger > Ac

Re: [PATCH dpdk v2 04/16] net: use ipv6 structure for header addresses

2024-10-06 Thread Ferruh Yigit
On 10/4/2024 9:04 PM, Robin Jarry wrote: > Ferruh Yigit, Oct 04, 2024 at 20:01: >> On 10/1/2024 9:17 AM, Robin Jarry wrote: >>> @@ -918,12 +918,14 @@ static struct chrte_fparse parseitem[] = { >>> .fptr  = ch_rte_parsetype_ipv6, >>> .dmask = &(const struct rte_flow_item_ipv6) { >>

Re: Per queue stats

2024-10-06 Thread Ferruh Yigit
On 10/4/2024 9:40 PM, Stephen Hemminger wrote: > ... > The stats queue mapping was a feature that was hinted at being removed. > It only exists because of HW limitations on Intel ixgbe NIC and SW > limitations from RTE_ETHDEV_QUEUE_STAT_CNTRS. > We have a plan to re

[PATCH v1 49/50] net/ntnic: add functions for releasing virt queues

2024-10-06 Thread Serhii Iliushyk
From: Danylo Vodopianov Implemented handler busy states and shutdowns of hardware queues. Added functionality for releasing RX and TX virtual queue resources, managed and releasing packets back into the availability ring. Updated sg_ops structure to include new queue management functions. Sign

[PATCH v1 50/50] net/ntnic: add functions for retrieving and managing packets

2024-10-06 Thread Serhii Iliushyk
From: Danylo Vodopianov Implemented functionality for retrieving received packets from virtual queues, supporting both SPLIT_RING and PACKED_RING types. Updated sg_ops structure to include the new packet retrieval functions. Signed-off-by: Danylo Vodopianov --- doc/guides/nics/ntnic.rst

[PATCH v1 48/50] net/ntnic: virtqueue setup managed packed-ring was added

2024-10-06 Thread Serhii Iliushyk
From: Danylo Vodopianov Structures were enhanced with PACKED virtqueue fields. Managed function was extended with packed ring configuration and initialization support. Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/dbsconfig/ntnic_dbsconfig.c | 191 +- drivers/net/ntnic

[PATCH v1 47/50] net/ntnic: update FPGA registeris related to DBS

2024-10-06 Thread Serhii Iliushyk
DBS - DVIO Buffer System Signed-off-by: Serhii Iliushyk --- .../supported/nthw_fpga_9563_055_049_.c | 184 +- 1 file changed, 183 insertions(+), 1 deletion(-) diff --git a/drivers/net/ntnic/nthw/supported/nthw_fpga_9563_055_049_.c b/drivers/net/ntnic/nthw/supported/nt

[PATCH v1 45/50] net/ntnic: used writer data handling functions

2024-10-06 Thread Serhii Iliushyk
From: Danylo Vodopianov Introduced functions to set and flush RX and TX used writer data. Added support for setting shadow data with functions for guest physical address, host ID, queue size, packed, interrupt enable, vector, and ISTK for RX and TX. Implemented set_rx_used_writer_data and set_t

[PATCH v1 46/50] net/ntnic: add descriptor reader data handling functions

2024-10-06 Thread Serhii Iliushyk
From: Danylo Vodopianov Added functions for setting and flushing RX and TX descriptor reader data. Implemented internal strcutres to update shadow structures with guest physical address, host ID, queue size, header, and packed status. Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/dbs

[PATCH v1 40/50] net/ntnic: add queue setup operations

2024-10-06 Thread Serhii Iliushyk
From: Danylo Vodopianov Added TX and RX queue setup. Handles memory allocation and hardware Virtio queue setup. Allocates and configures memory for hardware Virtio queues, including handling IOMMU and VFIO mappings. Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/include/ntnic_virt_que

[PATCH v1 43/50] net/ntnic: add split-queue support

2024-10-06 Thread Serhii Iliushyk
From: Danylo Vodopianov Split-queue support was added. Internal structures were enhanced with additional managmnet fields. Implement a managed virtual queue function based on the queue type and configuration parameters. DBS control registers were added. Signed-off-by: Danylo Vodopianov ---

[PATCH v1 38/50] net/ntnic: enhance Ethernet device configuration

2024-10-06 Thread Serhii Iliushyk
From: Danylo Vodopianov Added eth_dev_close function to handle closing of Ethernet devices. It releases managed RX/TX virtual queues. Initialized scatter-gather queue system. Defined constants and macros for hardware RX/TX descriptors and packet buffer sizes. Defined structures for RX and TX p

[PATCH v1 37/50] net/ntnic: add basic queue operations

2024-10-06 Thread Serhii Iliushyk
From: Danylo Vodopianov Adds support for queue configure, start, stop, release. The internal macro and functions of ntnic were also added and initialized. Signed-off-by: Danylo Vodopianov --- doc/guides/nics/features/ntnic.ini | 1 + drivers/net/ntnic/include/ntos_drv.h | 34 + driver

[PATCH v1 44/50] net/ntnic: add functions for availability monitor management

2024-10-06 Thread Serhii Iliushyk
From: Danylo Vodopianov Implemented functions to configure and manage availability monitor data. Added functions to set and flush availability monitor data. Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/dbsconfig/ntnic_dbsconfig.c | 61 +++- drivers/net/ntnic/include/ntnic_dbs.h

[PATCH v1 42/50] net/ntnic: add init for virt queues in the DBS

2024-10-06 Thread Serhii Iliushyk
From: Danylo Vodopianov DBS (DVIO Buffer System) module controls the scatter-gather buffer system that let's the host CPU interact with packets. Macros and Definitions: Defined constants for queue management and polling speeds. Data Structures: Added structures and arrays for RX and TX queue ma

[PATCH v1 41/50] net/ntnic: add packet handler for virtio queues

2024-10-06 Thread Serhii Iliushyk
From: Danylo Vodopianov Added functionality to handles the copying of segmented queue data into a rte_mbuf and vice versa. Added functionality to manages packet transmission for a specified TX and RX queues. Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/include/ntnic_virt_queue.h |

[PATCH v1 39/50] net/ntnic: add scatter-gather HW deallocation

2024-10-06 Thread Serhii Iliushyk
From: Danylo Vodopianov Deallocates memory for hardware Virtio queues and unmaps VFIO resources. Updated eth_tx_queue_release and eth_rx_queue_release. Released hardware Virtio queues for TX and RX. Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/include/ntos_drv.h | 1 + drivers/net/

[PATCH v1 36/50] net/ntnic: add receive MAC converter (RMC) core module

2024-10-06 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The RX MAC Converter module is part of the control mechanism of the physical ports. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/adapter/nt4ga_adapter.c | 14 +++ drivers/net/ntnic/include/nt4ga_adapter.h | 1 + drivers/net/ntnic/include/ntnic_s

[PATCH v1 28/50] net/ntnic: add categorizer (CAT) FPGA module

2024-10-06 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Categorizer module’s main purpose is to is select the behavior of other modules in the FPGA pipeline depending on a protocol check. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/hw_mod_backend.h| 205 drivers/net/ntnic/meson.build

[PATCH v1 35/50] net/ntnic: add Tx Packet Editor (TPE) FPGA module

2024-10-06 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The TX Packet Editor is a software abstraction module, that keeps track of the handful of FPGA modules that are used to edit packets in the TX pipeline. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/hw_mod_backend.h| 80 + drivers/net/ntn

[PATCH v1 29/50] net/ntnic: add key match (KM) FPGA module

2024-10-06 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Key Matcher module checks the values of individual fields of a packet. It supports both exact match which is implemented with a CAM, and wildcards which is implemented with a TCAM. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/hw_mod_backend.h

[PATCH v1 34/50] net/ntnic: add packet descriptor builder (PDB) FPGA module

2024-10-06 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Packet Description Builder module creates packet meta-data for example virtio-net headers. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/hw_mod_backend.h| 34 drivers/net/ntnic/meson.build | 1 + drivers/net/ntnic

[PATCH v1 33/50] net/ntnic: add slicer (SLC LR) FPGA module

2024-10-06 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Slicer for Local Retransmit module can cut of the head a packet before the packet leaves the FPGA RX pipeline. This is used when the TX pipeline is configured to add a new head in the packet. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/hw_mo

[PATCH v1 30/50] net/ntnic: add flow matcher (FLM) FPGA module

2024-10-06 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Flow Matcher module is a high-performance stateful SDRAM lookup and programming engine which supported exact match lookup in line-rate of up to hundreds of millions of flows. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/hw_mod_backend.h|

[PATCH v1 32/50] net/ntnic: add queue select (QSL) FPGA module

2024-10-06 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Queue Selector module directs packets to a given destination which includes host queues, physical ports, exceptions paths, and discard. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/hw_mod_backend.h| 37 drivers/net/ntnic/meson.build

[PATCH v1 31/50] net/ntnic: add hasher (HSH) FPGA module

2024-10-06 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Hasher module calculates a configurable hash value to be used internally by the FPGA. The module support both Toeplitz and NT-hash. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/hw_mod_backend.h| 36 drivers/net/ntnic/meson.build

[PATCH v1 25/50] net/ntnic: add Tx Packet Editor (TPE) flow module

2024-10-06 Thread Serhii Iliushyk
The TX Packet Editor is a software abstraction module, that keeps track of the handful of FPGA modules that are used to edit packets in the TX pipeline. Signed-off-by: Serhii Iliushyk --- drivers/net/ntnic/include/hw_mod_backend.h| 27 ++ drivers/net/ntnic/include/hw_mod_tpe_v3.h | 126

[PATCH v1 26/50] net/ntnic: add base init and deinit of the NT flow API

2024-10-06 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets Add basic API for initialization resources required by flow filter API Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/flow_api.h | 82 ++ drivers/net/ntnic/include/flow_api_engine.h | 43 +++ drivers/net/ntnic/include/hw_mod_backen

[PATCH v1 27/50] net/ntnic: add base init and deinit the NT flow backend

2024-10-06 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets Add basic implementation of the NT flow backend API Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/flow_api.h | 3 + drivers/net/ntnic/include/flow_api_engine.h | 5 ++ drivers/net/ntnic/include/hw_mod_backend.h| 12 drivers/

[PATCH v1 24/50] net/ntnic: add replacer (Tx RPL) flow module

2024-10-06 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The TX Replacer module can replace a range of bytes in a packet. The replacing data is stored in a table in the module and will often contain tunnel data. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/meson.build | 1 + .../nthw/flow_api/

[PATCH v1 22/50] net/ntnic: add checksum update (CSU) flow module

2024-10-06 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Checksum Update module updates the checksums of packets that has been modified in any way. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/meson.build | 1 + .../nthw/flow_api/flow_backend/flow_backend.c | 13 .../ntnic/nthw/flow_f

[PATCH v1 23/50] net/ntnic: add insert (Tx INS) flow module

2024-10-06 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets he TX Inserter module injects zeros into an offset of a packet, effectively expanding the packet. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/meson.build | 1 + .../nthw/flow_api/flow_backend/flow_backend.c | 13 .../ntnic/nthw/flo

[PATCH v1 21/50] net/ntnic: add copier (Tx CPY) flow module

2024-10-06 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The TX Copy module writes data to packet fields based on the lookup performed by the FLM module. This is used for NAT and can support other actions based on the RTE action MODIFY_FIELD. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/meson.build

[PATCH v1 20/50] net/ntnic: add RPP local retransmit (RPP LR) flow module

2024-10-06 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The RX Packet Process for Local Retransmit module can add bytes in the FPGA TX pipeline, which is needed when the packet increases in size. Note, this makes room for packet expansion, but the actual expansion is done by the modules. Signed-off-by: Oleksandr Kolomeiets

[PATCH v1 18/50] net/ntnic: add packet descriptor builder (PDB) flow module

2024-10-06 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Packet Description Builder module creates packet meta-data for example virtio-net headers. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/hw_mod_backend.h| 16 ++ drivers/net/ntnic/include/hw_mod_pdb_v9.h | 42 drivers/net/ntnic/

[PATCH v1 19/50] net/ntnic: add header field update (HFU) flow module

2024-10-06 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Header Field Update module updates protocol fields if the packets have been changed, for example length fields and next protocol fields. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/meson.build | 1 + .../nthw/flow_api/flow_backend/f

[PATCH v1 16/50] net/ntnic: add queue select (QSL) flow module

2024-10-06 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Queue Selector module directs packets to a given destination which includes host queues, physical ports, exceptions paths, and discard. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/hw_mod_backend.h| 18 ++ drivers/net/ntnic/include/hw_mo

[PATCH v1 17/50] net/ntnic: add slicer (SLC LR) flow module

2024-10-06 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Slicer for Local Retransmit module can cut of the head a packet before the packet leaves the FPGA RX pipeline. This is used when the TX pipeline is configured to add a new head in the packet. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/hw_mo

[PATCH v1 13/50] net/ntnic: add flow matcher (FLM) flow module

2024-10-06 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Flow Matcher module is a high-performance stateful SDRAM lookup and programming engine which supported exact match lookup in line-rate of up to hundreds of millions of flows. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/hw_mod_backend.h|

[PATCH v1 15/50] net/ntnic: add hasher (HSH) flow module

2024-10-06 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Hasher module calculates a configurable hash value to be used internally by the FPGA. The module support both Toeplitz and NT-hash. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/hw_mod_backend.h| 16 ++ drivers/net/ntnic/include/hw_mod_hs

[PATCH v1 10/50] net/ntnic: add INFO flow module

2024-10-06 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The info module keeps track of the hardcoded parameters of the FPGA and provides an abstraction that can support if parameter is unsupported for a given FPGA. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/hw_mod_backend.h| 57 +++ drivers/net

[PATCH v1 11/50] net/ntnic: add categorizer (CAT) flow module

2024-10-06 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Categorizer module’s main purpose is to select the behavior of other modules in the FPGA pipeline, depending on a protocol check. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/hw_mod_backend.h| 51 + drivers/net/ntnic/include/hw_mod_cat_v

[PATCH v1 14/50] net/ntnic: add IP fragmenter (IFR) flow module

2024-10-06 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The IP Fragmenter module can fragment outgoing packets based on a programmable MTU. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/meson.build | 1 + .../nthw/flow_api/flow_backend/flow_backend.c | 12 .../ntnic/nthw/flow_filter/flow_

[PATCH v1 12/50] net/ntnic: add key match (KM) flow module

2024-10-06 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Key Matcher module checks the values of individual fields of a packet. It supports both exact match which is implemented with a CAM, and wildcards which is implemented with a TCAM. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/hw_mod_backend.h

[PATCH v1 08/50] net/ntnic: add flow backend initialization API

2024-10-06 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets Add high-level interfaces for the initialization of the backend. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/flow_api.h | 2 ++ drivers/net/ntnic/include/flow_filter.h | 14 ++ drivers/net/ntnic/meson.build

[PATCH v1 05/50] net/ntnic: extend and fix logging implementation

2024-10-06 Thread Serhii Iliushyk
From: Danylo Vodopianov Add suffixes logging Fix the issue with the configuration log level for a specific module Fix extended debug logging 3-letter abbreviation for log type Update documentation new log modules were added Log level in functions that initialize feature operations

[PATCH v1 09/50] net/ntnic: add flow backend deinitialization API

2024-10-06 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets Add high-level interfaces for the deinitialization of the backend. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/flow_api.h | 7 ++- drivers/net/ntnic/include/flow_filter.h | 1 + drivers/net/ntnic/include/hw_mod_backend.h

[PATCH v1 02/50] net/ntnic: fix coverity issues:

2024-10-06 Thread Serhii Iliushyk
From: Danylo Vodopianov CI founc couple coverity problems which were fixed in this commit. CID 440550, 440551, 440545, 440553, 440552, 440547: Null pointer dereferences (REVERSE_INULL) These issues were fixed by reworking variable NULL checking and adding NULL checking before var using. CID 44

[PATCH v1 07/50] net/ntnic: add flow filter deinitialization API

2024-10-06 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets Add high-level interfaces for the deinitialization of the flow filter. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/adapter/nt4ga_adapter.c | 17 + drivers/net/ntnic/ntnic_mod_reg.h | 1 + 2 files changed, 18 insertions(+) diff

[PATCH v1 00/50] Provide: flow filter init API, Enable virtual queues, fix ntnic issues for release 24.07

2024-10-06 Thread Serhii Iliushyk
*** BLURB HERE *** Danylo Vodopianov (15): net/ntnic: fix coverity issues: net/ntnic: extend and fix logging implementation net/ntnic: add basic queue operations net/ntnic: enhance Ethernet device configuration net/ntnic: add scatter-gather HW deallocation net/ntnic: add queue setup op

[PATCH v1 06/50] net/ntnic: add flow filter init API

2024-10-06 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets Add high-level interfaces for the initialization of the flow filter. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/adapter/nt4ga_adapter.c | 18 ++ drivers/net/ntnic/include/flow_api.h | 12 drivers/net/ntnic/include/nt4g

[PATCH v1 04/50] net/ntnic: remove extra calling of the API for release port

2024-10-06 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets During rte_eth_dev_close execution, eth_dev_close function exported by ntnic is called, followed by a call to rte_eth_dev_release_port. Since there is no possible returns between the calls, calling rte_eth_dev_release_port from eth_dev_close is redundant and error-pron

[PATCH v1 03/50] net/ntnic: update documentation

2024-10-06 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets Add forgotten feature to the documentation (ntnic.ini) Signed-off-by: Oleksandr Kolomeiets --- doc/guides/nics/features/ntnic.ini | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/guides/nics/features/ntnic.ini b/doc/guides/nics/features/ntnic.ini index 0a7481

[PATCH v1 01/50] net/ntnic: update NT NiC PMD driver with FPGA version

2024-10-06 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets Update base FPGA files to the new version(39->49) Fix code style problems Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/meson.build | 2 +- .../net/ntnic/nthw/model/nthw_fpga_model.c| 11 +++--- ...9_.c => nthw_fpga_9563_055_049_0

Re: [PATCH] doc: update TAP device features

2024-10-06 Thread Ferruh Yigit
On 10/4/2024 9:48 PM, Stephen Hemminger wrote: > On Fri, 4 Oct 2024 02:48:21 +0100 > Ferruh Yigit wrote: > >>> +Stats per queue = Y >>> >> >> This feature name is misleading, >> it is for 'rte_eth_dev_set_[rt]x_queue_stats_mapping()' API, which is >> indeed for covering limitation for some

[PATCH] doc: reword sample app guides

2024-10-06 Thread Nandini Persad
I have reviewed these sections for grammar/clarity and made small modifications to the formatting of sections to adhere to a template which will create uniformality in the sample application user guides overall. Signed-off-by: Nandini Persad --- .../prog_guide/switch_representation.rst | 18

[PATCH v6] doc: add new driver guidelines

2024-10-06 Thread Nandini Persad
This document was created to assist contributors in creating DPDK drivers and provides suggestions and guidelines on how to upstream effectively. Signed-off-by: Ferruh Yigit Signed-off-by: Nandini Persad Reviewed-by: Stephen Hemminger Acked-by: Chengwen Feng --- doc/guides/contributing/index.

[PATCH v8 6/6] examples: use eventdev pre-scheduling

2024-10-06 Thread pbhagavatula
From: Pavan Nikhilesh Enable event pre-scheduling if supported by the event device. Signed-off-by: Pavan Nikhilesh --- examples/eventdev_pipeline/pipeline_worker_generic.c | 6 ++ examples/eventdev_pipeline/pipeline_worker_tx.c | 6 ++ examples/ipsec-secgw/event_helper.c

[PATCH v8 5/6] app/test-eventdev: add pre-scheduling support

2024-10-06 Thread pbhagavatula
From: Pavan Nikhilesh Add support to configure pre-scheduling for eventdev test application. Option `--preschedule` 0 - Disable pre-scheduling. 1 - Enable pre-scheduling. 2 - Enable pre-schedule with adaptive mode (Default). Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/evt_common

[PATCH v8 4/6] event/cnkx: add pre-schedule support

2024-10-06 Thread pbhagavatula
From: Pavan Nikhilesh Add device level and port level pre-schedule support for cnxk eventdev. Signed-off-by: Pavan Nikhilesh --- doc/guides/eventdevs/cnxk.rst | 10 -- doc/guides/eventdevs/features/cnxk.ini | 1 + drivers/event/cnxk/cn10k_eventdev.c| 19 +-

[PATCH v8 3/6] eventdev: add event preschedule hint

2024-10-06 Thread pbhagavatula
From: Pavan Nikhilesh Add a new eventdev API to provide a hint to the eventdev PMD to pre-schedule the next event into the event port, without releasing the current flow context. Event device that support this feature advertises the capability using the RTE_EVENT_DEV_CAP_PRESCHEDULE_EXPLICIT capa

[PATCH v8 2/6] eventdev: add event port pre-schedule modify

2024-10-06 Thread pbhagavatula
From: Pavan Nikhilesh Some event devices allow pre-schedule types to be modified at runtime on an event port. Add `RTE_EVENT_DEV_CAP_PER_PORT_PRESCHEDULE` capability to indicate that the event device supports this feature. Add `rte_event_port_preschedule_modify()` API to modify the pre-schedule

[PATCH v8 1/6] eventdev: introduce event pre-scheduling

2024-10-06 Thread pbhagavatula
From: Pavan Nikhilesh Event pre-scheduling improves scheduling performance by assigning events to event ports in advance when dequeues are issued. The dequeue operation initiates the pre-schedule operation, which completes in parallel without affecting the dequeued event flow contexts and dequeue

[PATCH v8 0/6] Introduce event pre-scheduling

2024-10-06 Thread pbhagavatula
From: Pavan Nikhilesh Event pre-scheduling improves scheduling performance by assigning events to event ports in advance when dequeues are issued. This series introduces various types and levels of pre-scheduling to the eventdev library. pre-scheduling Types: * RTE_EVENT_PRESCHEDULE_NONE: No pr

RE: [EXTERNAL] Re: [PATCH v7 1/6] eventdev: introduce event pre-scheduling

2024-10-06 Thread Pavan Nikhilesh Bhagavatula
> On Sat, 5 Oct 2024 13:29:56 +0530 > wrote: > > > +static int > > +preschedule_test(enum rte_event_dev_preschedule_type > preschedule_type, const char *preschedule_name) > > +{ > > +#define NB_EVENTS 1024 > > + uint64_t start, total; > > + struct rte_event ev; > > + int rc, cnt; > > +

Re: [PATCH v12 1/7] buildtools/chkincs: relax C linkage requirement

2024-10-06 Thread Robin Jarry
Mattias Rönnblom, Oct 06, 2024 at 16:17: I think you need to change run_command() to custom_target(). I was thinking of this patch to be much simpler as follows: I started off with a shell script, but I switched to Python when I wanted to strip off comments. (Not that that can't be done in bou

Re: [RFC v2 0/2] Add high-performance timer facility

2024-10-06 Thread Mattias Rönnblom
On 2024-10-06 15:43, Morten Brørup wrote: From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] Sent: Sunday, 6 October 2024 15.03 On 2024-10-03 23:32, Morten Brørup wrote: From: Stephen Hemminger [mailto:step...@networkplumber.org] Sent: Thursday, 3 October 2024 20.37 On Wed, 15 Mar 2023 18:0

RE: [PATCH v12 1/4] lib: add generic support for reading PMU events

2024-10-06 Thread Morten Brørup
> From: Tomasz Duszynski [mailto:tduszyn...@marvell.com] > Sent: Saturday, 28 September 2024 00.06 > +int > +rte_pmu_init(void) > +{ > + int ret; > + > + /* Allow calling init from multiple contexts within a single > thread. This simplifies > + * resource management a bit e.g in case

Re: [PATCH v12 1/7] buildtools/chkincs: relax C linkage requirement

2024-10-06 Thread Mattias Rönnblom
On 2024-10-06 14:25, Robin Jarry wrote: Mattias Rönnblom, Oct 06, 2024 at 11:47: OK, so it does change something, but not for the better, seemingly. meson.build now somehow has to distinguished between two different "errors": 1) One or more offending header files were found. 2) Any other kind

RE: [PATCH v7] eal: add build-time option to omit trace

2024-10-06 Thread Morten Brørup
> From: Morten Brørup [mailto:m...@smartsharesystems.com] > Sent: Sunday, 6 October 2024 16.04 > > Some applications want to omit the trace feature. > Either to reduce the memory footprint, to reduce the exposed attack > surface, or for other reasons. > > This patch adds an option in rte_config.h

[PATCH v7] eal: add build-time option to omit trace

2024-10-06 Thread Morten Brørup
Some applications want to omit the trace feature. Either to reduce the memory footprint, to reduce the exposed attack surface, or for other reasons. This patch adds an option in rte_config.h to include or omit trace in the build. Trace is included by default. Omitting trace works by omitting all

[PATCH v6] eal: add build-time option to omit trace

2024-10-06 Thread Morten Brørup
Some applications want to omit the trace feature. Either to reduce the memory footprint, to reduce the exposed attack surface, or for other reasons. This patch adds an option in rte_config.h to include or omit trace in the build. Trace is included by default. Omitting trace works by omitting all

RE: [RFC v2 0/2] Add high-performance timer facility

2024-10-06 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] > Sent: Sunday, 6 October 2024 15.03 > > On 2024-10-03 23:32, Morten Brørup wrote: > >> From: Stephen Hemminger [mailto:step...@networkplumber.org] > >> Sent: Thursday, 3 October 2024 20.37 > >> > >> On Wed, 15 Mar 2023 18:03:40 +0100 > >> Ma

Re: [PATCH v12 1/7] buildtools/chkincs: relax C linkage requirement

2024-10-06 Thread Robin Jarry
Robin Jarry, Oct 06, 2024 at 14:25: I think you need to change run_command() to custom_target(). I was thinking of this patch to be much simpler as follows: diff --git a/buildtools/chkincs/check_extern_c.sh b/buildtools/chkincs/check_extern_c.sh Sorry, I didn't think about windows compatibil

Re: [RFC v2 0/2] Add high-performance timer facility

2024-10-06 Thread Mattias Rönnblom
On 2024-10-03 23:32, Morten Brørup wrote: From: Stephen Hemminger [mailto:step...@networkplumber.org] Sent: Thursday, 3 October 2024 20.37 On Wed, 15 Mar 2023 18:03:40 +0100 Mattias Rönnblom wrote: This patchset is an attempt to introduce a high-performance, highly scalable timer facility int

RE: [PATCH v4] eal: add build-time option to omit trace

2024-10-06 Thread Morten Brørup
> From: Jerin Jacob [mailto:jerinjac...@gmail.com] > Sent: Wednesday, 2 October 2024 18.18 > > On Tue, Oct 1, 2024 at 9:45 PM Morten Brørup > wrote: > > > > > From: Jerin Jacob [mailto:jerinjac...@gmail.com] > > > Sent: Tuesday, 1 October 2024 18.06 > > > > > > On Tue, Oct 1, 2024 at 9:32 PM Mort

[PATCH v5] eal: add build-time option to omit trace

2024-10-06 Thread Morten Brørup
Some applications want to omit the trace feature. Either to reduce the memory footprint, to reduce the exposed attack surface, or for other reasons. This patch adds an option in rte_config.h to include or omit trace in the build. Trace is included by default. Omitting trace works by omitting all

[PATCH] net/ena: restructure the llq policy user setting

2024-10-06 Thread shaibran
From: Shai Brandes Replaced `enable_llq`, `normal_llq_hdr` and `large_llq_hdr` devargs with a new shared devarg named `llq_policy` that implements the same logic and accepts the following values: 0 - Disable LLQ. Use with extreme caution as it leads to a huge performance degradation on AW

Re: [PATCH v12 1/7] buildtools/chkincs: relax C linkage requirement

2024-10-06 Thread Robin Jarry
Mattias Rönnblom, Oct 06, 2024 at 11:47: OK, so it does change something, but not for the better, seemingly. meson.build now somehow has to distinguished between two different "errors": 1) One or more offending header files were found. 2) Any other kind of error (file not found, access control i

RE: [PATCH] [RFC] cryptodev: replace LIST_END enumerators with APIs

2024-10-06 Thread Morten Brørup
> From: Akhil Goyal [mailto:gak...@marvell.com] > Sent: Thursday, 3 October 2024 09.01 > > Hi Morten, > > > > Apologies for delayed response. > > > Maybe a combination, returning the lowest end of the two versions > of the list, > > > would work... > > > > > > -- >

Re: [PATCH v12 1/7] buildtools/chkincs: relax C linkage requirement

2024-10-06 Thread Mattias Rönnblom
On 2024-10-06 10:55, Mattias Rönnblom wrote: On 2024-10-04 13:51, Robin Jarry wrote: Mattias Rönnblom, Oct 04, 2024 at 10:40: Making small scripts needlessly complicated is not good example, it's a bad one. I don't find adding argument checks needlessly complicated but this is a matter of pr

RE: [PATCH dpdk v2 00/16] IPv6 APIs overhaul

2024-10-06 Thread Morten Brørup
> From: Robin Jarry [mailto:rja...@redhat.com] > Sent: Tuesday, 1 October 2024 10.17 > > Hi everyone, > > As discussed recently [1], here is a first draft of the IPv6 APIs > rework. The > API change was announced before the 24.07 release [2]. This series is > intended > for 24.11. > > [1] http:/

RE: [PATCH dpdk v2 16/16] ipv6: add function to check ipv6 version

2024-10-06 Thread Morten Brørup
> From: Robin Jarry [mailto:rja...@redhat.com] > Sent: Tuesday, 1 October 2024 10.17 > > This is a slow path version to verify the version field in IPv6 > headers. It doesn't look slow to me. No need to mention slow path here. > > Signed-off-by: Robin Jarry > --- > > Notes: > v2: new patc

Re: [PATCH v12 1/7] buildtools/chkincs: relax C linkage requirement

2024-10-06 Thread Mattias Rönnblom
On 2024-10-04 13:51, Robin Jarry wrote: Mattias Rönnblom, Oct 04, 2024 at 10:40: Making small scripts needlessly complicated is not good example, it's a bad one. I don't find adding argument checks needlessly complicated but this is a matter of preference. To me, Python is not shell script. I

RE: [PATCH dpdk v2 03/16] net: add structure for ipv6 addresses

2024-10-06 Thread Morten Brørup
+to: Various CPU architecture maintainers +to: Stephen (already participating in this discussion) +cc: x86 CPU architecture maintainers > From: Robin Jarry [mailto:rja...@redhat.com] > Sent: Tuesday, 1 October 2024 10.17 > > There is currently no structure defined for IPv6 addresses. Introduce >

[DPDK/core Bug 1559] rte_pktmbuf_pool_create doesn't set the correct rte_errno

2024-10-06 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1559 Bug ID: 1559 Summary: rte_pktmbuf_pool_create doesn't set the correct rte_errno Product: DPDK Version: 24.03 Hardware: All OS: All Status: UNCONFIRMED