Re: [RFC] table: report victim replace stats in LRU tables

2024-10-11 Thread Stephen Hemminger
On Mon, 19 Aug 2024 07:23:30 +0200 Kamil Vojanec wrote: > LRU caches replace records when requested table bucket is full. There > is, however, no information about this happening in either the return > value or the statistics. This commit introduces a counter for such > cases. > > Signed-off-by:

RE: [PATCH v2 02/10] net/nfp: fix malloc name problem in secondary process

2024-10-11 Thread Chaoyong He
> On Sat, 12 Oct 2024 10:40:59 +0800 > Chaoyong He wrote: > > > The original logic keeps using the same name parameter when malloc > > memory in secondary process, which may cause error when using multiple > > PF cards. > > > > Fixes: 3b00109d2b65 ("net/nfp: add PF ID used to format symbols") >

Re: [PATCH v2 02/10] net/nfp: fix malloc name problem in secondary process

2024-10-11 Thread Stephen Hemminger
On Sat, 12 Oct 2024 10:40:59 +0800 Chaoyong He wrote: > The original logic keeps using the same name parameter when malloc > memory in secondary process, which may cause error when using > multiple PF cards. > > Fixes: 3b00109d2b65 ("net/nfp: add PF ID used to format symbols") > Cc: peng.zh...@c

Re: [PATCH v2 2/2] examples/l3fwd: fix read beyond array boundaries in ACL mode

2024-10-11 Thread Stephen Hemminger
On Tue, 30 Jul 2024 13:22:35 +0100 Konstantin Ananyev wrote: > From: Konstantin Ananyev > > With commit: ACL mode now can use send_packets_multi(). > What I missed with that changes: send_packets_multi() can't deal > properly with input dst_port[i] == BAD_PORT (though it can set > it itself), a

[PATCH v2 10/10] net/nfp: fix memory leak in VF initialization logic

2024-10-11 Thread Chaoyong He
Fix one memory leak problem in the logic of VF initialization. Fixes: d81e2b514dc9 ("net/nfp: move device info into process private data") Cc: sta...@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang Acked-by: Stephen Hemminger --- drivers/net/nfp/nfp_ethdev_vf

[PATCH v2 09/10] net/nfp: modify the comment of some control messages

2024-10-11 Thread Chaoyong He
The comment of some control messages are not right, which conflict with the data structure and may confuse the other developers. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Acked-by: Stephen Hemminger --- drivers/net/nfp/flower/nfp_flower_cmsg.h | 14 +++--- 1 file changed, 7 inser

[PATCH v2 08/10] net/nfp: fix problem caused by FEC set

2024-10-11 Thread Chaoyong He
The return value of 'nfp_eth_set_fec()' is three ways, the original logic considered it as two ways wrongly. Fixes: 37bd1b843a20 ("net/nfp: support setting FEC mode") Cc: zerun...@corigine.com Cc: sta...@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang Acked-by:

[PATCH v2 07/10] net/nfp: fix problem caused by commit end function

2024-10-11 Thread Chaoyong He
The return value of 'nfp_eth_config_commit_end()' is three ways, the original logic considered it as two ways wrongly. Fixes: 68aa35373a94 ("net/nfp: support setting pause frame switch mode") Cc: zerun...@corigine.com Cc: sta...@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-

[PATCH v2 05/10] net/nfp: fix problem caused by configure function

2024-10-11 Thread Chaoyong He
The return value of 'nfp_eth_set_configured()' is three ways, the original logic considered it as two ways wrongly. Fixes: 61d4008fe6bb ("net/nfp: support setting link up/down") Cc: sta...@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang Acked-by: Stephen Hemmin

[PATCH v2 06/10] net/nfp: add check logic for port up/down function

2024-10-11 Thread Chaoyong He
The 'nfp_eth_set_configured()' function is not always success, so need to check the return value of it. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang Acked-by: Stephen Hemminger --- .../net/nfp/flower/nfp_flower_representor.c| 18 +- drivers/net/n

[PATCH v2 04/10] net/nfp: improve the logic readability

2024-10-11 Thread Chaoyong He
Try our best to make the logic in secondary proess the same with the primary process and improve the readability, by add helper functions and rename function. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/nfp_ethdev.c | 86 +++--

[PATCH v2 03/10] net/nfp: simplify some function parameters

2024-10-11 Thread Chaoyong He
Refactor to the logic of initialize process to simplify some function parameters, both for primary and secodary process. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang Acked-by: Stephen Hemminger --- drivers/net/nfp/nfp_ethdev.c | 153 +++--

[PATCH v2 02/10] net/nfp: fix malloc name problem in secondary process

2024-10-11 Thread Chaoyong He
The original logic keeps using the same name parameter when malloc memory in secondary process, which may cause error when using multiple PF cards. Fixes: 3b00109d2b65 ("net/nfp: add PF ID used to format symbols") Cc: peng.zh...@corigine.com Cc: sta...@dpdk.org Signed-off-by: Chaoyong He Reviewe

[PATCH v2 01/10] net/nfp: use strlcpy for copying string

2024-10-11 Thread Chaoyong He
Replace 'snprintf()' with 'strlcpy()' where applicable. Using 'strlcpy()' is safe practice when copying strings, as it will include a null terminator. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang Acked-by: Stephen Hemminger --- drivers/net/nfp/flower/nfp_flower_repr

[PATCH v2 00/10] modify some logic of NFP PMD

2024-10-11 Thread Chaoyong He
This patch series refactor some logic of NFP PMD to make it more clear, also fix some bugs. --- v2: * Following the reviewer's request, change a little logic of patch 10/10. * Add 'Acked-by' tag from reviewer. --- Chaoyong He (10): net/nfp: use strlcpy for copying string net/nfp: fix malloc n

Re: [PATCH 1/4] ethdev: verify queue ID when Tx done cleanup

2024-10-11 Thread Ferruh Yigit
On 9/5/2024 8:33 AM, Andrew Rybchenko wrote: > On 9/5/24 09:46, Jie Hai wrote: >> From: Chengwen Feng >> >> Verify queue_id for rte_eth_tx_done_cleanup API. > > If I'm not mistaken the function is considered data path API (fast). > If so, it should not validate it's parameters as in rte_eth_tx_bu

Re: [PATCH 0/3] net/tap: queue limit patches

2024-10-11 Thread Stephen Hemminger
On Sat, 12 Oct 2024 02:01:12 +0100 Ferruh Yigit wrote: > On 10/11/2024 6:29 PM, Stephen Hemminger wrote: > > Some patches related to recent increase in possible queues. > > > > Stephen Hemminger (3): > > net/tap: handle increase in mp_max_fds > > net/tap: add static assert to make sure max q

[PATCH v2 3/3] net/tap: remove unnecessary checks in configure

2024-10-11 Thread Stephen Hemminger
The ethdev layer already validates that the number of requested queues is less than the reported max queues. Signed-off-by: Stephen Hemminger --- drivers/net/tap/rte_eth_tap.c | 16 1 file changed, 16 deletions(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte

[PATCH v2 1/3] net/tap: handle increase in mp_max_fds

2024-10-11 Thread Stephen Hemminger
Now that max MP fds has increased to 253 it is possible that the number of queues the TAP device can handle is less than that. Therefore the code to handle MP message should only allow the number of queues it can handle. Coverity issue: 445386 Signed-off-by: Stephen Hemminger --- drivers/net/tap

[PATCH v2 2/3] net/tap: increase the maximum allowable queues

2024-10-11 Thread Stephen Hemminger
The default of 16 is too low for larger systems. Upper bound is the maximum number of fd's that can be passed to secondary process (253) and the maximum number of queue's allowed by Linux kernel (256). Both these manifest constants, are not exposed in visible kernel API. Signed-off-by: Stephen He

[PATCH v2 0/3] net/tap: queue limit patches

2024-10-11 Thread Stephen Hemminger
Some patches related to recent queue limit changes. v2 - up the limit to maximum Linux can support dont use static_assert here get rid of unreachable checks in configure Stephen Hemminger (3): net/tap: handle increase in mp_max_fds net/tap: increase the maximum allowable queues ne

Re: [PATCH v10 0/2] power: introduce PM QoS interface

2024-10-11 Thread lihuisong (C)
Hi Thomas and Ferruh, Kindly ping for merge. /Huisong 在 2024/9/12 11:07, fengchengwen 写道: Series-reviewed-by: Chengwen Feng Thanks chengwen. On 2024/9/12 10:38, Huisong Li wrote: The deeper the idle state, the lower the power consumption, but the longer the resume time. Some service are de

Re: [PATCH v5 0/2] add two commands for testpmd application

2024-10-11 Thread Ferruh Yigit
On 10/10/2024 7:42 AM, Chaoyong He wrote: > This patch series aims to add two commands for the testpmd application: > - testpmd> set port eeprom magic \ > value offset > - testpmd> set port led > > --- > v5: > * Use 'accept_risk' rather than 'confirm' to make it clear enough. > *

Re: [PATCH 0/3] net/tap: queue limit patches

2024-10-11 Thread Ferruh Yigit
On 10/11/2024 6:29 PM, Stephen Hemminger wrote: > Some patches related to recent increase in possible queues. > > Stephen Hemminger (3): > net/tap: handle increase in mp_max_fds > net/tap: add static assert to make sure max queues less than fd limit > net/tap: increase the maximum allowable

Re: [PATCH v6 0/4] fix segment fault when parse args

2024-10-11 Thread fengchengwen
On 2024/10/11 22:13, David Marchand wrote: > On Wed, Oct 9, 2024 at 6:50 AM Chengwen Feng wrote: >> >> The rte_kvargs_process() was used to parse key-value (e.g. socket_id=0), >> it also supports to parse only-key (e.g. socket_id). But many drivers's >> callback can only handle key-value, it will

Re: [PATCH v3 0/3] add support for querying ethdev TM nodes

2024-10-11 Thread Ferruh Yigit
On 10/9/2024 11:32 AM, Bruce Richardson wrote: > Add support for an ethdev TM query function to allow apps to get details > of the TM nodes they previously configured. This patchset includes: > > * ethdev changes to add the API > * implementation of the function in "ice" pmd > * testpmd command to

Re: [PATCH v3 1/3] ethdev: add traffic manager query function

2024-10-11 Thread Ferruh Yigit
On 10/9/2024 11:32 AM, Bruce Richardson wrote: > Add function to allow querying a node in the scheduler tree. Returns > the parameters as were given to the add function. Adding this function > allows apps to just query the hierarchy rather than having to maintain > their own copies of it internall

Re: [PATCH 0/2] enhance the flower service framework

2024-10-11 Thread Ferruh Yigit
On 10/10/2024 8:45 AM, Chaoyong He wrote: > Enhance the NFP service framework when using the flower firmware, we can > using the alarm now when there is no service core. > > Long Wu (2): > net/nfp: rename flower service flag > net/nfp: enhance the flower service framework > Series applied to

Re: [PATCH v6 0/3] add frequency adjustment support for PTP

2024-10-11 Thread Ferruh Yigit
On 10/11/2024 7:34 AM, Mingjin Ye wrote: > [1/3] ethdev: add frequency adjustment API > [2/3] net/ice: add frequency adjustment support for PTP > [3/3] examples/ptpclient: add frequency adjustment > --- > v2: rte_eth_timesync_adjust_freq marked as experimental. > --- > v3: Add more description for

Re: [PATCH v6 2/3] net/ice: add frequency adjustment support for PTP

2024-10-11 Thread Ferruh Yigit
On 10/11/2024 9:02 AM, Bruce Richardson wrote: > On Fri, Oct 11, 2024 at 06:34:06AM +, Mingjin Ye wrote: >> Add ice support for new ethdev API to adjust frequency for IEEE1588 >> PTP. Also, this patch reworks code for converting software update >> to hardware update. >> >> Signed-off-by: Simei

Re: [PATCH v6 1/3] ethdev: add frequency adjustment API

2024-10-11 Thread Ferruh Yigit
On 10/11/2024 7:34 AM, Mingjin Ye wrote: > This patch adds freq adjustment API for PTP high accuracy. > > Signed-off-by: Simei Su > Signed-off-by: Mingjin Ye > Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.

Re: [PATCH v3 00/50] Provide: flow filter init API, Enable virtual queues, fix ntnic issues for release 24.07

2024-10-11 Thread Ferruh Yigit
On 10/10/2024 3:13 PM, Serhii Iliushyk wrote: > The list of updates provided by the patchset: > * Update the supported version of the FPGA to 9563.55.49 > * Fix Coverity issues > * Fix issues related to release 24.07 > * Extended and fixed the implementation of the logging > * Added NT fl

Re: [PATCH v3 0/4] ethdev: rework config restore

2024-10-11 Thread Ferruh Yigit
On 10/11/2024 7:51 PM, Dariusz Sosnowski wrote: > This patch series reworks the config restore procedure, > so that drivers are able to enable/disable certain parts of it. > Drivers can provide get_restore_flags() callback, > which will indicate to ethdev library what configuration to restore. > >

Re: [PATCH v6 3/3] examples/ptpclient: add frequency adjustment

2024-10-11 Thread Ferruh Yigit
On 10/11/2024 7:34 AM, Mingjin Ye wrote: > This patch adds PI servo controller to support frequency > adjustment API for IEEE1588 PTP. > > For example, the command for starting ptpclient with PI controller is: > dpdk-ptpclient -a :81:00.0 -c 1 -n 3 -- -T 0 -p 0x1 -c 1 > > Signed-off-by: Simei

Re: [PATCH] doc: correct definition of Stats per queue feature

2024-10-11 Thread Ferruh Yigit
On 10/11/2024 2:38 AM, Stephen Hemminger wrote: > Change the documentation to match current usage of this feature > in the NIC table. Moved this sub heading to be after basic > stats because the queue stats reported now are in the same structure. > > Although the "Stats per Queue" feature was orig

Re: [dpdk-dev] [PATCH 1/2] mk: fix build for clang 4

2024-10-11 Thread Stephen Hemminger
On Fri, 11 Oct 2024 20:20:12 +0200 Morten Brørup wrote: > rom: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Friday, 11 October 2024 19.48 > > > > On Fri, 11 Oct 2024 19:36:08 +0200 > > Morten Brørup wrote: > > > > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Fe

Re: [PATCH 3/3] net/tap: increase the maximum allowable queues

2024-10-11 Thread Stephen Hemminger
On Fri, 11 Oct 2024 10:29:25 -0700 Stephen Hemminger wrote: > The default of 16 is too low for larger systems, and the limit > is set at compile time. > > Signed-off-by: Stephen Hemminger > --- > drivers/net/tap/meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --gi

RE: [PATCH] Revert "build: disable gcc 10 zero-length-bounds warning"

2024-10-11 Thread Morten Brørup
More warnings enabled is always good. And even better when the code builds without those warnings. :-) Acked-by: Morten Brørup

[PATCH v3 4/4] net/mlx5: disable config restore

2024-10-11 Thread Dariusz Sosnowski
mlx5 PMD does not require configuration restore on rte_eth_dev_start(). Add implementation of get_restore_flags() indicating that. Signed-off-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5.c| 2 ++ drivers/net/mlx5/mlx5.h| 2 ++ drivers/net/mlx5/mlx5_ethdev.c | 18

[PATCH v3 3/4] ethdev: restore config only when requested

2024-10-11 Thread Dariusz Sosnowski
Use get_restore_flags() internal API introduced in previous commits in rte_eth_dev_start(), to restore only the configuration requested by the driver. Signed-off-by: Dariusz Sosnowski --- lib/ethdev/rte_ethdev.c | 31 +-- 1 file changed, 21 insertions(+), 10 deletions

[PATCH v3 2/4] ethdev: add get restore flags driver callback

2024-10-11 Thread Dariusz Sosnowski
Before this patch, ethdev layer assumed that all drivers require that it has to forcefully restore: - MAC addresses - promiscuous mode setting - all multicast mode setting upon rte_eth_dev_start(). This patch introduces a new callback to eth_dev_ops - get_restore_flags(). Drivers implementing th

[PATCH v3 1/4] ethdev: rework config restore

2024-10-11 Thread Dariusz Sosnowski
Extract promiscuous and all multicast configuration restore to separate functions. This change will allow easier integration of disabling these procedures for supporting PMDs in follow up commits. Signed-off-by: Dariusz Sosnowski --- lib/ethdev/rte_ethdev.c | 34 +

[PATCH v3 0/4] ethdev: rework config restore

2024-10-11 Thread Dariusz Sosnowski
This patch series reworks the config restore procedure, so that drivers are able to enable/disable certain parts of it. Drivers can provide get_restore_flags() callback, which will indicate to ethdev library what configuration to restore. If callback is not defined, then ethdev assumes that all co

[PATCH v3 4/4] test/thash: add tests for RSS key generation API

2024-10-11 Thread Vladimir Medvedkin
This patch adds tests for RSS key generation. In this test we measure distribution of hash LSBs for a given random tuple where only some part of bits is variable. At first we generate random hash key and measure the worst distribution for a given ReTa size value (RETA_SZ_LOG). Then we adjust the k

[PATCH v3 3/4] hash: implement RSS hash key generation API

2024-10-11 Thread Vladimir Medvedkin
This patch implements Toeplitz hash key generation function using the new polynomial generation function. Signed-off-by: Vladimir Medvedkin --- lib/hash/rte_thash.c | 23 ++- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/lib/hash/rte_thash.c b/lib/hash/rte_th

[PATCH v3 2/4] hash: add dynamic polynomial calculation

2024-10-11 Thread Vladimir Medvedkin
Current polynomial table has the following limitations: 1. It has polynomials up to degree 16 2. For each degree there are only 4 polynomials The above results in less entropy when generating Toeplitz hash key subsequences. This patch replaces the current static table approach with dynamic polyn

[PATCH v3 1/4] thash: add RSS hash key generation API

2024-10-11 Thread Vladimir Medvedkin
Currently the only way to have non static Toeplitz hash key is to generate it randomly. Such a key may not guarantee good packets distribution, especially if there are small number of flows. This patch adds stub implementation of the Toeplitz hash key generation function, which may improve Toeplit

[PATCH v3 0/4] RSS hash key generation

2024-10-11 Thread Vladimir Medvedkin
Currently there are 2 methods to get the RSS hash key. The first method is to randomly generate it. The second one is to use well known RSS hash keys. Both methods have drawbacks. The first method not always provides a good hash distribution. The second one does, but not for all ReTa sizes and not

[PATCH] Revert "build: disable gcc 10 zero-length-bounds warning"

2024-10-11 Thread Stephen Hemminger
The zero length array warning can be re-enabled. The zero length marker fields are now removed by commit 9e152e674c77 ("mbuf: remove marker fields") in DPDK 24.03. This reverts commit cfacbcb5a23bc26cb913528c372adddabbb33ca1. Signed-off-by: Stephen Hemminger --- config/meson.build | 5 + 1

[PATCH v4] fib: network byte order IPv4 lookup

2024-10-11 Thread Vladimir Medvedkin
Previously when running rte_fib_lookup IPv4 addresses must have been in host byte order. This patch adds a new flag RTE_FIB_FLAG_LOOKUP_BE that can be passed on fib create, which will allow to have IPv4 in network byte order on lookup. Signed-off-by: Vladimir Medvedkin --- app/test/test_fib.c

RE: [dpdk-dev] [PATCH 1/2] mk: fix build for clang 4

2024-10-11 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit > Sent: Monday, 17 April 2017 16.36 > > clang 4 gives "taking address of packed member may result in an > unaligned pointer value" warnings in a few locations [1]. > > Disabled "-Waddress-of-packed-member" warning for clang >= 4

[PATCH 3/3] net/tap: increase the maximum allowable queues

2024-10-11 Thread Stephen Hemminger
The default of 16 is too low for larger systems, and the limit is set at compile time. Signed-off-by: Stephen Hemminger --- drivers/net/tap/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/tap/meson.build b/drivers/net/tap/meson.build index 5e5a3ad3c6..

[PATCH 2/3] net/tap: add static assert to make sure max queues less than fd limit

2024-10-11 Thread Stephen Hemminger
Since tap needs to pass fd's between primary and secondary process. The number of tap queues must be less than the limit. Signed-off-by: Stephen Hemminger --- drivers/net/tap/rte_eth_tap.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_

[PATCH 1/3] net/tap: handle increase in mp_max_fds

2024-10-11 Thread Stephen Hemminger
Now that max MP fds has increased to 253 it is possible that the number of queues the TAP device can handle is less than that. Therefore the code to handle MP message should only allow the number of queues it can handle. Coverity issue: 445386 Signed-off-by: Stephen Hemminger --- drivers/net/tap

[PATCH 0/3] net/tap: queue limit patches

2024-10-11 Thread Stephen Hemminger
Some patches related to recent increase in possible queues. Stephen Hemminger (3): net/tap: handle increase in mp_max_fds net/tap: add static assert to make sure max queues less than fd limit net/tap: increase the maximum allowable queues drivers/net/tap/meson.build | 2 +- drivers/net/t

RE: [EXTERNAL] Re: [PATCH v4 1/5] graph: add support for node specific errors

2024-10-11 Thread Pavan Nikhilesh Bhagavatula
> On Fri, Aug 16, 2024 at 5:10 PM wrote: > > > > From: Pavan Nikhilesh > > > > Add ability for Nodes to advertise error counters > > during registration. > > > > Signed-off-by: Pavan Nikhilesh > > Such a series deserve a cover letter. > > It also deserves a RN update, and I see no removal of t

RE: [EXTERNAL] Re: [PATCH v4 1/5] graph: add support for node specific errors

2024-10-11 Thread Pavan Nikhilesh Bhagavatula
> I forgot to mention. > > If you submit a v5, could you squash all commits that deal with > lib/graph into a single patch? Including the public API to increment the > nodes xstats? I will squash (2/5, 3/5), (4/5, 5/5) and leave 1/5 alone as it is a very big patch containing updates to svg fil

RE: [EXTERNAL] Re: [PATCH v4 4/5] node: add error stats for ip4 lookup node

2024-10-11 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Robin Jarry > Sent: Friday, October 11, 2024 3:19 PM > To: Pavan Nikhilesh Bhagavatula ; Jerin Jacob > ; Nithin Kumar Dabilpuram > ; Kiran Kumar Kokkilagadda > ; zhirun@intel.com; Wathsala Vithanage > ; Bruce Richardson > ; Konstantin Ananyev > > Cc: de

RE: [EXTERNAL] Re: [PATCH v4 3/5] graph: add stats for node specific errors

2024-10-11 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Robin Jarry > Sent: Friday, October 11, 2024 3:24 PM > To: Pavan Nikhilesh Bhagavatula ; Jerin Jacob > ; Nithin Kumar Dabilpuram > ; Kiran Kumar Kokkilagadda > ; zhirun@intel.com; Zhirun Yan > > Cc: dev@dpdk.org > Subject: [EXTERNAL] Re: [PATCH v4 3/5]

[DPDK/ethdev Bug 1563] Many I219 variants not supported by E1000 druver

2024-10-11 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1563 Bug ID: 1563 Summary: Many I219 variants not supported by E1000 druver Product: DPDK Version: 24.11 Hardware: All OS: All Status: UNCONFIRMED Severity: normal

Re: [PATCH dpdk v2 03/16] net: add structure for ipv6 addresses

2024-10-11 Thread Stephen Hemminger
On Fri, 11 Oct 2024 14:37:35 +0200 Morten Brørup wrote: > > From: Robin Jarry [mailto:rja...@redhat.com] > > Sent: Thursday, 10 October 2024 22.08 > > > > Morten Brørup, Oct 06, 2024 at 10:18: > > > This has been discussed before, but I want to double check... > > > > > > If - sometime in the

[PATCH 9/9] net/ice/base: read VSI layer info from VSI

2024-10-11 Thread Bruce Richardson
Rather than computing from the number of HW layers the layer of the VSI, we can instead just read that info from the VSI node itself. This allows the layer to be changed at runtime. Signed-off-by: Bruce Richardson --- drivers/net/ice/base/ice_sched.c | 2 +- 1 file changed, 1 insertion(+), 1 del

[PATCH 8/9] net/ice/base: allow init without TC class sched nodes

2024-10-11 Thread Bruce Richardson
If DCB support is disabled via DDP image, there will not be any traffic class (TC) nodes in the scheduler tree immediately above the root level. To allow the driver to work with this scenario, we allow use of the root node as a dummy TC0 node in case where there are no TC nodes in the tree. For use

[PATCH 7/9] net/ice/base: remove flag checks before topology upload

2024-10-11 Thread Bruce Richardson
DPDK should support more than just 9-level or 5-level topologies, so remove the checks for those particular settings. Signed-off-by: Bruce Richardson --- drivers/net/ice/base/ice_ddp.c | 33 - 1 file changed, 33 deletions(-) diff --git a/drivers/net/ice/base/ice_

[PATCH 5/9] net/ice/base: set VSI index on newly created nodes

2024-10-11 Thread Bruce Richardson
The ice_sched_node type has got a field for the vsi to which the node belongs. This field was not getting set in "ice_sched_add_node", so add a line configuring this field for each node from its parent node. Similarly, when searching for a qgroup node, we can check for each node that the VSI inform

[PATCH 6/9] net/ice/base: optimize subtree searches

2024-10-11 Thread Bruce Richardson
In a number of places throughout the driver code, we want to confirm that a scheduler node is indeed a child of another node. Currently, this is confirmed by searching down the tree from the base until the desired node is hit, a search which may hit many irrelevant tree nodes when recursing down wr

[PATCH 4/9] net/ice/base: remove 255 limit on sched child nodes

2024-10-11 Thread Bruce Richardson
The Tx scheduler in the ice driver can be configured to have large numbers of child nodes at a given layer, but the driver code implicitly limited the number of nodes to 255 by using a u8 datatype for the number of children. Increase this to a 16-bit value throughout the code. Signed-off-by: Bruce

[PATCH 3/9] net/ice/base: fix VLAN replay after reset

2024-10-11 Thread Bruce Richardson
From: Dave Ertman If there is more than one VLAN defined when any reset that affects the PF is initiated, after the reset rebuild, no traffic will pass on any VLAN but the last one created. This is caused by the iteration though the VLANs during replay each clearing the vsi_map bitmap of the VSI

[PATCH 2/9] net/ice/base: add bounds check

2024-10-11 Thread Bruce Richardson
From: Fabio Pricoco Refactor while loop to add a check that the values read are in the correct range. Fixes: 6c1f26be50a2 ("net/ice/base: add control queue information") Cc: sta...@dpdk.org Signed-off-by: Fabio Pricoco Signed-off-by: Bruce Richardson --- drivers/net/ice/base/ice_controlq.c |

[PATCH 1/9] net/ice/base: re-enable bypass mode for E822

2024-10-11 Thread Bruce Richardson
From: Jacob Keller When removing bypass mode, the code for E822 bypass was completely removed in error. This code should be maintained in DPDK so re-add the necessary functions. Fixes: ce9ad8c5bc6d ("net/ice/base: remove PHY port timer bypass mode") Cc: sta...@dpdk.org Signed-off-by: Jacob Kell

[PATCH 0/9] net/ice: base code update for RC2

2024-10-11 Thread Bruce Richardson
A number of small fixes and other changes to enable Tx scheduler enhancements to our DPDK driver have been added to the base code. Upstream these changes for 24.11 RC2. Most have previously been submitted as part of the scheduler changes [1] [1] https://patches.dpdk.org/project/dpdk/list/?series=3

[RFC PATCH v2] net: 2-byte align packed headers

2024-10-11 Thread Morten Brørup
Network headers are (at minimum) 2-byte aligned. Mark them as such. Signed-off-by: Morten Brørup --- lib/net/rte_esp.h| 10 +- lib/net/rte_ether.h | 23 --- lib/net/rte_geneve.h | 2 +- lib/net/rte_icmp.h | 12 ++-- lib/net/rte_ip.h | 30 ++

RE: rte_ring move head question for machines with relaxed MO (arm/ppc)

2024-10-11 Thread Wathsala Wathawana Vithanage
> -Original Message- > From: Konstantin Ananyev > Sent: Friday, October 11, 2024 9:09 AM > To: Wathsala Wathawana Vithanage ; > dev@dpdk.org > Cc: Honnappa Nagarahalli ; > jer...@marvell.com; d...@linux.ibm.com > Subject: RE: rte_ring move head question for machines with relaxed MO > (a

RE: [PATCH v2 2/4] ethdev: add get restore flags driver callback

2024-10-11 Thread Dariusz Sosnowski
> -Original Message- > From: Konstantin Ananyev > Sent: Friday, October 11, 2024 14:54 > To: Dariusz Sosnowski ; NBU-Contact-Thomas > Monjalon (EXTERNAL) ; Ferruh Yigit > ; Andrew Rybchenko > Cc: dev@dpdk.org > Subject: RE: [PATCH v2 2/4] ethdev: add get restore flags driver callback > >

RE: [PATCH] test/bitops: check worker lcore availability

2024-10-11 Thread Morten Brørup
> From: David Marchand [mailto:david.march...@redhat.com] > Sent: Friday, 11 October 2024 17.26 > > Coverity is not able to understand that having 2 lcores means that > rte_get_next_lcore(-1, 0, 1) can't return RTE_MAX_LCORE. > Add an assert. > > Coverity issue: 445382, 445383, 445384, 445387, 44

[PATCH] test/bitops: check worker lcore availability

2024-10-11 Thread David Marchand
Coverity is not able to understand that having 2 lcores means that rte_get_next_lcore(-1, 0, 1) can't return RTE_MAX_LCORE. Add an assert. Coverity issue: 445382, 445383, 445384, 445387, 445389, 445391 Fixes: 35326b61aecb ("bitops: add atomic bit operations in new API") Signed-off-by: David March

Re: [PATCH v12 6/7] eal: add unit tests for atomic bit access functions

2024-10-11 Thread David Marchand
On Fri, Oct 11, 2024 at 5:16 PM Morten Brørup wrote: > > > > The Coverity report [1] just gave me an idea: > > > > > > worker_lcore_id = rte_get_next_lcore(-1, 1, 0); > > > + TEST_ASSERT(worker_lcore_id < RTE_MAX_LCORE, "Worker thread > > allocation failed"); > > > > > > Or even better: > > > Imp

RE: [PATCH v12 6/7] eal: add unit tests for atomic bit access functions

2024-10-11 Thread Morten Brørup
> > The Coverity report [1] just gave me an idea: > > > > worker_lcore_id = rte_get_next_lcore(-1, 1, 0); > > + TEST_ASSERT(worker_lcore_id < RTE_MAX_LCORE, "Worker thread > allocation failed"); > > > > Or even better: > > Improve rte_eal_remote_launch() by checking the validity of the > worker_id

Re: [PATCH v12 6/7] eal: add unit tests for atomic bit access functions

2024-10-11 Thread David Marchand
On Fri, Oct 11, 2024 at 5:06 PM Morten Brørup wrote: > > > From: David Marchand [mailto:david.march...@redhat.com] > > Sent: Thursday, 10 October 2024 12.45 > > > > On Fri, Sep 20, 2024 at 12:57 PM Mattias Rönnblom > > wrote: > > > + static int > > \ > > > + run_parallel_test_and_mod

RE: [PATCH v12 6/7] eal: add unit tests for atomic bit access functions

2024-10-11 Thread Morten Brørup
> From: David Marchand [mailto:david.march...@redhat.com] > Sent: Thursday, 10 October 2024 12.45 > > On Fri, Sep 20, 2024 at 12:57 PM Mattias Rönnblom > wrote: > > + static int > \ > > + run_parallel_test_and_modify ## size(void *arg) \ > > + { > \ > > + s

What important system information is missing from unit/compile test reports?

2024-10-11 Thread Patrick Robb
When the Community Lab sends a test report email for a unit/compile test, it provides a footer section with basic system info, for each system which ran a test. They look like: FreeBSD 14.1 Kernel: 14.1-RELEASE-p3 Compiler: clang 18.1.5 example: https://inbox.dpdk.org/test-report/6708ccf8

Re: [PATCH] eal: increase max file descriptor for secondary process device

2024-10-11 Thread David Marchand
On Thu, Oct 10, 2024 at 11:51 AM David Marchand wrote: > > On Thu, Sep 5, 2024 at 6:22 PM Stephen Hemminger > wrote: > > > > The TAP and XDP driver both are limited to only 8 queues when > > because of the small limit imposed by EAL. Increase the limit > > now since this release allows changing A

Re: [PATCH dpdk v7] graph: expose node context as pointers

2024-10-11 Thread David Marchand
On Mon, Sep 30, 2024 at 11:28 AM Robin Jarry wrote: > > In some cases, the node context data is used to store two pointers > because the data is larger than the reserved 16 bytes. Having to define > intermediate structures just to be able to cast is tedious. And without > intermediate structures,

Re: [PATCH dpdk] graph: make graphviz export more readable

2024-10-11 Thread David Marchand
On Wed, Aug 28, 2024 at 3:42 PM Robin Jarry wrote: > > Change the color of arrows leading to sink nodes to dark orange. Remove > the node oval shape around the sink nodes and make their text dark > orange. This results in a much more readable output for large graphs. > See the link below for an ex

Re: [PATCH dpdk] buildtools/cmdline: fix meson error when used as a subproject

2024-10-11 Thread Thomas Monjalon
07/08/2024 15:43, Bruce Richardson: > On Thu, Aug 01, 2024 at 12:01:54PM +0200, Robin Jarry wrote: > > Fix the following error when using dpdk as a subproject: > > > > subprojects/dpdk/buildtools/subproject/meson.build:28:56: > > ERROR: Unknown function "file". > > > > This was obviously never

Re: [PATCH v2] doc: announce single-event enqueue/dequeue ABI change

2024-10-11 Thread David Marchand
On Wed, Jul 5, 2023 at 1:18 PM Mattias Rönnblom wrote: > > Announce the removal of the single-event enqueue and dequeue > operations from the eventdev ABI. > > Signed-off-by: Mattias Rönnblom > > --- > PATCH v2: Fix commit subject prefix. > --- > doc/guides/rel_notes/deprecation.rst | 8

Re: [PATCH v3] fib: network byte order IPv4 lookup

2024-10-11 Thread David Marchand
On Fri, Oct 11, 2024 at 1:29 PM David Marchand wrote: > > @@ -214,6 +215,7 @@ rte_fib_create(const char *name, int socket_id, struct > > rte_fib_conf *conf) > > rte_strlcpy(fib->name, name, sizeof(fib->name)); > > fib->rib = rib; > > fib->type = conf->type; > > + fib

Re: [PATCH] doc: postpone deprecation of pipeline legacy API

2024-10-11 Thread David Marchand
On Wed, Jul 19, 2023 at 5:13 PM Cristian Dumitrescu wrote: > > Postpone the deprecation of the legacy pipeline, table and port > library API and gradual stabilization of the new API. > > Signed-off-by: Cristian Dumitrescu > --- > doc/guides/rel_notes/deprecation.rst | 21 + >

Re: [PATCH v4 1/5] graph: add support for node specific errors

2024-10-11 Thread David Marchand
On Fri, Aug 16, 2024 at 5:10 PM wrote: > > From: Pavan Nikhilesh > > Add ability for Nodes to advertise error counters > during registration. > > Signed-off-by: Pavan Nikhilesh Such a series deserve a cover letter. It also deserves a RN update, and I see no removal of the associated deprecatio

Re: [PATCH v10 0/7] Lcore variables

2024-10-11 Thread Stephen Hemminger
On Fri, 11 Oct 2024 10:18:54 +0200 Mattias Rönnblom wrote: > This patch set introduces a new API for static > per-lcore id data allocation. > > Please refer to the API documentation for both a > rationale for this new API, and a comparison to the alternatives > available. > > The adoption of

Re: [PATCH v14 1/4] lib: add generic support for reading PMU events

2024-10-11 Thread Stephen Hemminger
On Fri, 11 Oct 2024 11:56:04 + Konstantin Ananyev wrote: > > + * > > + * @return > > + * 0 in case of success, negative value otherwise. > > + */ > > +__rte_experimental > > +int > > +rte_pmu_init(void); > > + > > +/** > > + * @warning > > + * @b EXPERIMENTAL: this API may change without pr

Re: [PATCH v6 0/4] fix segment fault when parse args

2024-10-11 Thread David Marchand
On Wed, Oct 9, 2024 at 6:50 AM Chengwen Feng wrote: > > The rte_kvargs_process() was used to parse key-value (e.g. socket_id=0), > it also supports to parse only-key (e.g. socket_id). But many drivers's > callback can only handle key-value, it will segment fault if handles > only-key. so the patch

RE: rte_ring move head question for machines with relaxed MO (arm/ppc)

2024-10-11 Thread Konstantin Ananyev
> > > > > > > > > 1. rte_ring_generic_pvt.h: > > > > > > > = > > > > > > > > > > > > > > pseudo-c-code // > > > > > > > related armv8 instructions > > > > > > > > >

[PATCH v1] net/ice: fix incorrect reading of PHY timestamp

2024-10-11 Thread Soumyadeep Hore
In ICE PMD, previously the ready bitmap checking before reading PHY timestamp was not present. This caused incorrect Tx timestamping. The ready bitmap checking is enabled and PHY timestamp is read once the ready bitmap gives positive value. Fixes: 881169950d80 ("net/ice/base: implement initial PT

RE: [PATCH v2] eal/x86: cache queried CPU flags

2024-10-11 Thread Konstantin Ananyev
> Rather than re-querying the HW each time a CPU flag is requested, we can > just save the return value in the flags array. This should speed up > repeated querying of CPU flags, and provides a workaround for a reported > issue where errors are seen with constant querying of the AVX-512 CPU > fl

[PATCH v2] eal/x86: cache queried CPU flags

2024-10-11 Thread Bruce Richardson
Rather than re-querying the HW each time a CPU flag is requested, we can just save the return value in the flags array. This should speed up repeated querying of CPU flags, and provides a workaround for a reported issue where errors are seen with constant querying of the AVX-512 CPU flag from a non

[PATCH] eal/x86: cache queried CPU flags

2024-10-11 Thread Bruce Richardson
Rather than re-querying the HW each time a CPU flag is requested, we can just save the return value in the flags array. This should speed up repeated querying of CPU flags, and provides a workaround for a reported issue where errors are seen with constant querying of the AVX-512 CPU flag from a non

Re: [PATCH v14 4/4] eal: add PMU support to tracing library

2024-10-11 Thread David Marchand
On Fri, Oct 11, 2024 at 11:50 AM Tomasz Duszynski wrote: > diff --git a/lib/eal/meson.build b/lib/eal/meson.build > index e1d6c4cf17..2b1a1eb283 100644 > --- a/lib/eal/meson.build > +++ b/lib/eal/meson.build > @@ -14,7 +14,7 @@ subdir(exec_env) > > subdir(arch_subdir) > > -deps += ['log', 'kvargs

[RFC PATCH] net: TEST 2-byte align packed headers

2024-10-11 Thread Morten Brørup
Testing idea discussed in: https://inbox.dpdk.org/dev/20240821162516.610624-17-rja...@redhat.com/T/#mc598fde6ba5d540cde5096575cc3b6e27d9640cd Signed-off-by: Morten Brørup --- lib/net/rte_ether.h | 2 +- lib/net/rte_ip.h| 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --gi

Re: [v2 0/2] proc-info memory dump enhancement

2024-10-11 Thread David Marchand
On Tue, Jul 30, 2024 at 2:04 PM Gagandeep Singh wrote: > > v2 change: > * Handled a comment to add "MALLOC" while dumping > malloc heaps. > > Gagandeep Singh (2): > app/proc-info: add memory heap dump > eal: add total memory size in memory dump APIs Series applied, thanks. -- David March

  1   2   >