Re: [PATCH v2] dts: improve statistics

2024-11-12 Thread Patrick Robb
Thanks, I've reviewed this and tested it, and I think the results.json is good. This is not a problem, but I am noting here that the 1 value which was being tracked in the legacy DTS "test_results.json" which is not included here is device firmware version. Reviewed-by: Patrick Robb Tested-by: P

[PATCH v3 2/2] graph: add alignment to the member of rte_node

2024-11-12 Thread Huichao Cai
The members "dispatch" and "xstat_off" of the structure "rte_node" can be min cache aligned to make room for future expansion and to make sure have better performance. Due to the modification of the alignment of some members of the "rte_node" structure, update file release_24_11.rst. Signed-off-b

[PATCH] net/mlx5: fix Rx queue ref count in flushing user flows

2024-11-12 Thread Bing Zhao
Some indirect table and hrxq is created in the rule creation with QUEUE or RSS action. When stopping a port, the 'dev_started' is set to 0 in the beginning. The mlx5_ind_table_obj_release() should still do the dereference of the queue(s) when it is called in the polling of flow rule deletion, due t

Re: [PATCH] doc/guides: add security document

2024-11-12 Thread Hemant Agrawal
Hi Nandini,    On 13-11-2024 10:08, Nandini Persad wrote: This is a new document covering security protocols implemented in DPDK. Signed-off-by: Nandini Persad Signed-off-by: Thomas Monjalon Reviewed-by: Stephen Hemminger --- doc/guides/index.rst | 1 + doc/guides/secu

Re: [PATCH 2/3] net/dpaa2: remove unnecessary check for null before rte_free

2024-11-12 Thread Hemant Agrawal
Acked-by: Hemant Agrawal On 12-11-2024 23:08, Stephen Hemminger wrote: Calling rte_free() with NULL parameter is allowed. Found by nullfree.cocci Fixes: 5964d36a2904 ("net/dpaa2: release port upon close") Cc: sachin.sax...@oss.nxp.com Signed-off-by: Stephen Hemminger --- drivers/net/dpaa2/

Re: [PATCH 1/3] bus/fslmc: remove unnecessary null check

2024-11-12 Thread Hemant Agrawal
Acked-by: Hemant Agrawal On 12-11-2024 23:08, Stephen Hemminger wrote: No need for check for null before calling free(). Caught by nullfree.cocci script. Fixes: 57cb02edf122 ("bus/fslmc: enhance MC VFIO multi-process support") Cc: jun.y...@nxp.com Signed-off-by: Stephen Hemminger --- drive

Re: [PATCH 0/3] unnecessary checks for null

2024-11-12 Thread Stephen Hemminger
On Wed, 13 Nov 2024 01:25:37 + Ferruh Yigit wrote: > On 11/12/2024 5:38 PM, Stephen Hemminger wrote: > > Found by running nullfree.cocci on 24.11-rc2 > > > > Stephen Hemminger (3): > > bus/fslmc: remove unnecessary null check > > net/dpaa2: remove unnecessary check for null before rte_fr

[PATCH] doc/guides: add security document

2024-11-12 Thread Nandini Persad
This is a new document covering security protocols implemented in DPDK. Signed-off-by: Nandini Persad Signed-off-by: Thomas Monjalon Reviewed-by: Stephen Hemminger --- doc/guides/index.rst | 1 + doc/guides/security/index.rst | 333 ++ 2 files changed

Re: [PATCH v3 0/3] bugfix about KEEP CRC offload

2024-11-12 Thread Jie Hai
Hi, stephen, ferruh, thomas, This group of patches does not modify the API and is a problem for hns3 driver. Can the patches be applied in the current window? Best regards, Jie Hai On 2024/7/19 17:04, Jie Hai wrote: For hns3 NIC, when KEEP_CRC offload is enabled, the CRC data is still be strip

RE: [PATCH] rcu: shift 64-bit constant to avoid implicit 32 to 64 bit conversion

2024-11-12 Thread Morten Brørup
> From: Andre Muezerie [mailto:andre...@linux.microsoft.com] > Sent: Tuesday, 12 November 2024 23.03 > > ../lib/rcu/rte_rcu_qsbr.c(101): warning C4334: '<<': result of 32-bit > shift implicitly converted to 64 bits (was 64-bit shift intended?) > ../lib/rcu/rte_rcu_qsbr.c(107): warning C4334: '<<'

RE: [PATCH] mempool: enable code to be compiled with MSVC compiler

2024-11-12 Thread Morten Brørup
> From: Andre Muezerie [mailto:andre...@linux.microsoft.com] > Sent: Wednesday, 13 November 2024 02.25 > > The issues that were preventing mempool from getting compiled with > MSVC were fixed, so now it should not be excluded from the > build anymore. > > Signed-off-by: Andre Muezerie > --- Rev

Re: [PATCH] rcu: shift 64-bit constant to avoid implicit 32 to 64 bit conversion

2024-11-12 Thread Honnappa Nagarahalli
Thank you Andre for the patch. It looks good overall. > On Nov 12, 2024, at 4:02 PM, Andre Muezerie > wrote: > > ../lib/rcu/rte_rcu_qsbr.c(101): warning C4334: '<<': result of 32-bit > shift implicitly converted to 64 bits (was 64-bit shift intended?) > ../lib/rcu/rte_rcu_qsbr.c(107): warning C

[PATCH v22 10/13] compress/zsda: add zsda compressdev qp ops

2024-11-12 Thread Hanxiao Li
Add zsda compressdev qp interface implementation. Signed-off-by: Hanxiao Li --- drivers/common/zsda/zsda_device.c | 1 - drivers/common/zsda/zsda_device.h | 3 +- drivers/common/zsda/zsda_qp.c | 248 ++ drivers/common/zsda/zsda_qp.h | 85 +

[PATCH v22 12/13] compress/zsda: add zsda compressdev dequeue datapath

2024-11-12 Thread Hanxiao Li
Add zsda compressdev dequeue datapath. Signed-off-by: Hanxiao Li --- drivers/common/zsda/zsda_qp.c | 55 + drivers/common/zsda/zsda_qp.h | 1 + drivers/common/zsda/zsda_qp_common.h | 4 + drivers/compress/zsda/zsda_comp.c | 155 ++ driver

[PATCH v22 06/13] compress/zsda: add zsda compressdev driver skeleton

2024-11-12 Thread Hanxiao Li
Add zsda compressdev driver interface skeleton Signed-off-by: Hanxiao Li --- MAINTAINERS | 3 + doc/guides/compressdevs/features/zsda.ini | 6 + doc/guides/compressdevs/index.rst | 1 + doc/guides/compressdevs/zsda.rst | 178 ++

[PATCH v22 04/13] common/zsda: add functions to operate hardware queue

2024-11-12 Thread Hanxiao Li
Add functions to operate hardware queue, such as queue start,stop and clear. Signed-off-by: Hanxiao Li --- drivers/common/zsda/meson.build | 1 + drivers/common/zsda/zsda_device.c| 7 + drivers/common/zsda/zsda_qp.c| 196 +++ drivers/common/zsda/zsda_

[PATCH v22 13/13] compress/zsda: add zsda compressdev capabilities

2024-11-12 Thread Hanxiao Li
Add zsda compressdev capabilities. Signed-off-by: Hanxiao Li --- doc/guides/compressdevs/features/zsda.ini | 9 + doc/guides/compressdevs/zsda.rst | 23 +++ doc/guides/rel_notes/release_24_11.rst| 7 +++ drivers/compress/zsda/zsda_comp_pmd.c | 1

[PATCH v22 11/13] compress/zsda: add zsda compressdev enqueue datapath

2024-11-12 Thread Hanxiao Li
Add zsda compressdev enqueue datapath. Signed-off-by: Hanxiao Li --- drivers/common/zsda/meson.build | 2 +- drivers/common/zsda/zsda_qp.c | 107 drivers/common/zsda/zsda_qp.h | 23 ++- drivers/common/zsda/zsda_qp_common.c | 72 drivers/common/zsd

[PATCH v22 08/13] compress/zsda: add zsda compressdev stats ops

2024-11-12 Thread Hanxiao Li
Add zsda compressdev stats interface implementation. Signed-off-by: Hanxiao Li --- drivers/common/zsda/zsda_qp_common.c | 63 +++ drivers/common/zsda/zsda_qp_common.h | 16 +++ drivers/compress/zsda/zsda_comp_pmd.c | 25 ++- 3 files changed, 102 insertions(+

[PATCH v22 07/13] compress/zsda: add zsda compressdev dev ops

2024-11-12 Thread Hanxiao Li
add zsda compressdev dev interface implementation. Signed-off-by: Hanxiao Li --- drivers/common/zsda/meson.build | 1 + drivers/common/zsda/zsda_qp_common.c | 57 ++ drivers/common/zsda/zsda_qp_common.h | 36 +++ drivers/compress/zsda/zsda_comp_pmd.c | 144 +++

[PATCH v22 09/13] compress/zsda: add zsda compressdev xform ops

2024-11-12 Thread Hanxiao Li
Add zsda compressdev xform interface implementation. Signed-off-by: Hanxiao Li --- drivers/compress/zsda/zsda_comp_pmd.c | 55 +-- 1 file changed, 52 insertions(+), 3 deletions(-) diff --git a/drivers/compress/zsda/zsda_comp_pmd.c b/drivers/compress/zsda/zsda_comp_pmd.c

[PATCH v22 02/13] common/zsda: add zsdadev driver

2024-11-12 Thread Hanxiao Li
Add basic zsdadev init and register PCI probe functions Signed-off-by: Hanxiao Li --- MAINTAINERS | 3 + drivers/common/zsda/meson.build | 13 ++ drivers/common/zsda/zsda_device.c | 191 ++ drivers/common/zsda/zsda_device.h | 53 +

[PATCH v22 03/13] common/zsda: add logging macros

2024-11-12 Thread Hanxiao Li
Add zxdh logging implementation. Signed-off-by: Hanxiao Li --- drivers/common/zsda/meson.build | 1 + drivers/common/zsda/zsda_device.c | 23 --- drivers/common/zsda/zsda_logs.c | 19 +++ drivers/common/zsda/zsda_logs.h | 27 +++

[PATCH v22 05/13] common/zsda: add definition and use of msg chan.

2024-11-12 Thread Hanxiao Li
Add msg chan functions and the use to get hardware information or operate hardware. Signed-off-by: Hanxiao Li --- drivers/common/zsda/zsda_qp.c| 309 +++ drivers/common/zsda/zsda_qp.h| 52 + drivers/common/zsda/zsda_qp_common.h | 37 3 files cha

[PATCH v22 00/13] drivers/zsda: introduce zsda drivers

2024-11-12 Thread Hanxiao Li
v22: - modify misspelled errors. v21: - modify some errors. v20 - add release note which was forgot in last version v19: - delete cryptodev drivers and prepare to submit it next time. - only submit compressdev driver this time. - resplit the patches. v18: - add code in drivers/meson.build to co

[PATCH v22 01/13] config: add zsda device number

2024-11-12 Thread Hanxiao Li
Add the number of zsda devices. Signed-off-by: Hanxiao Li --- config/rte_config.h | 4 1 file changed, 4 insertions(+) diff --git a/config/rte_config.h b/config/rte_config.h index dd7bb0d35b..e1e85b3291 100644 --- a/config/rte_config.h +++ b/config/rte_config.h @@ -117,6 +117,10 @@ #defin

Re: [PATCH v4 0/2] examples/l3fwd: add more options

2024-11-12 Thread Jie Hai
Hi, Ferruh and Thomas, Kindly ping for reviews. Since this patchset has some Acked-bys and no comments, are there any comments or suggestions? Best regards, Jie Hai On 2024/10/18 9:08, Jie Hai wrote: Add options to support configuring RX burst size and cache size of mbuf mempoool. -- v4: 1.

Re: [PATCH 0/3] unnecessary checks for null

2024-11-12 Thread Ferruh Yigit
On 11/12/2024 5:38 PM, Stephen Hemminger wrote: > Found by running nullfree.cocci on 24.11-rc2 > > Stephen Hemminger (3): > bus/fslmc: remove unnecessary null check > net/dpaa2: remove unnecessary check for null before rte_free > net/ntnic: remove unnecessary check for null before free > Fo

Re: [PATCH v2] power: fix a typo in the PM QoS guide

2024-11-12 Thread lihuisong (C)
在 2024/11/12 20:55, Thomas Monjalon 写道: 12/11/2024 09:35, Huisong Li: The typo in the guide is hard to understand. Necessary to fix it. Fixes: dd6fd75bf662 ("power: introduce PM QoS API on CPU wide") Signed-off-by: Huisong Li --- --- a/doc/guides/prog_guide/power_man.rst +++ b/doc/guides/pr

[PATCH] mempool: enable code to be compiled with MSVC compiler

2024-11-12 Thread Andre Muezerie
The issues that were preventing mempool from getting compiled with MSVC were fixed, so now it should not be excluded from the build anymore. Signed-off-by: Andre Muezerie --- lib/mempool/meson.build | 6 -- 1 file changed, 6 deletions(-) diff --git a/lib/mempool/meson.build b/lib/mempool/me

[PATCH v3] power: fix a typo in the PM QoS guide

2024-11-12 Thread Huisong Li
The typo in the guide is hard to understand. Necessary to fix it. Fixes: dd6fd75bf662 ("power: introduce PM QoS API on CPU wide") Signed-off-by: Huisong Li --- doc/guides/prog_guide/power_man.rst | 2 +- lib/power/rte_power_qos.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions

Re: [PATCH] argparse: enable code to be compiled with MSVC compiler

2024-11-12 Thread fengchengwen
Acked-by: Chengwen Feng On 2024/11/13 6:48, Andre Muezerie wrote: > The issues that were preventing argparser from getting compiled with > MSVC were fixed, so now it should not be excluded from the > compilation anymore. > > Signed-off-by: Andre Muezerie > --- > lib/argparse/meson.build | 6 --

Re: [PATCH v7 00/17] modify code as suggested by the maintainer

2024-11-12 Thread Ferruh Yigit
On 11/12/2024 9:57 AM, Howard Wang wrote: > ./devtools/check- and some small issues > > Howard Wang (17): > net/r8169: add PMD driver skeleton > net/r8169: add logging structure > net/r8169: add hardware registers access routines > net/r8169: implement core logic for Tx/Rx > net/r816

Re: [PATCH v7 14/17] net/r8169: implement promisc and allmulti modes

2024-11-12 Thread Ferruh Yigit
On 11/12/2024 9:58 AM, Howard Wang wrote: > diff --git a/doc/guides/nics/features/r8169.ini > b/doc/guides/nics/features/r8169.ini > index e4bbcde2a0..d2ad94dcc6 100644 > --- a/doc/guides/nics/features/r8169.ini > +++ b/doc/guides/nics/features/r8169.ini > @@ -10,6 +10,10 @@ Link status =

Re: [PATCH v7 11/17] net/r8169: implement Rx path

2024-11-12 Thread Ferruh Yigit
On 11/12/2024 9:57 AM, Howard Wang wrote: > diff --git a/doc/guides/nics/features/r8169.ini > b/doc/guides/nics/features/r8169.ini > index ccb4cd9c23..889e211863 100644 > --- a/doc/guides/nics/features/r8169.ini > +++ b/doc/guides/nics/features/r8169.ini > @@ -8,7 +8,12 @@ Speed capabilities = Y

Re: [PATCH v7 01/17] net/r8169: add PMD driver skeleton

2024-11-12 Thread Ferruh Yigit
On 11/12/2024 9:57 AM, Howard Wang wrote: > Meson build infrastructure, r8169_ethdev minimal skeleton, > header with Realtek NIC device and vendor IDs. > > Signed-off-by: Howard Wang > --- > MAINTAINERS| 8 ++ > doc/guides/nics/features/r8169.ini | 9 ++ > doc

Re: [PATCH v7 08/17] net/r8169: add support for PHY configuration

2024-11-12 Thread Ferruh Yigit
On 11/12/2024 9:57 AM, Howard Wang wrote: > This patch is for phy configuration which contains phy power up/down, > phy config, ephy config and so on. > > Signed-off-by: Howard Wang > checkpatch warnings: CHECK:BOOL_COMPARISON: Using comparison to TRUE is error prone #407: FILE: drivers/net/r81

Re: [PATCH v7 07/17] net/r8169: add support for hardware operations

2024-11-12 Thread Ferruh Yigit
On 11/12/2024 9:57 AM, Howard Wang wrote: > + > +#define TRUE 1 > +#define FALSE 0 > Also checkpatch has BOOL_COMPARISON warnings [1], technically "(hw->NotWrMcuPatchCode == TRUE)" can be "(hw->NotWrMcuPatchCode)" they are same. As you are defining TRUE & FALSE as above (since this is compatibil

Re: [PATCH v15 4/4] eal: add PMU support to tracing library

2024-11-12 Thread Stephen Hemminger
On Fri, 25 Oct 2024 10:54:14 +0200 Tomasz Duszynski wrote: > In order to profile app one needs to store significant amount of samples > somewhere for an analysis later on. Since trace library supports > storing data in a CTF format lets take advantage of that and add a > dedicated PMU tracepoint.

Re: [PATCH v7 02/17] net/r8169: add logging structure

2024-11-12 Thread Ferruh Yigit
On 11/12/2024 9:57 AM, Howard Wang wrote: > Implement logging macros for debug purposes. > > Signed-off-by: Howard Wang > <...> > + > +#ifdef RTE_ETHDEV_DEBUG_RX > +#define PMD_RX_LOG(level, fmt, ...) \ > + RTE_LOG_DP_LINE(level, R8169_RX, "%s(): " fmt, __func__, ##__VA_ARGS__) > +#else >

[PATCH] argparse: enable code to be compiled with MSVC compiler

2024-11-12 Thread Andre Muezerie
The issues that were preventing argparser from getting compiled with MSVC were fixed, so now it should not be excluded from the compilation anymore. Signed-off-by: Andre Muezerie --- lib/argparse/meson.build | 6 -- 1 file changed, 6 deletions(-) diff --git a/lib/argparse/meson.build b/lib/

[PATCH] rcu: shift 64-bit constant to avoid implicit 32 to 64 bit conversion

2024-11-12 Thread Andre Muezerie
../lib/rcu/rte_rcu_qsbr.c(101): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?) ../lib/rcu/rte_rcu_qsbr.c(107): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?) ../lib/rcu/rte_rcu_qsbr

Re: [PATCH v2 2/4] dts: fix smoke tests docstring

2024-11-12 Thread Dean Marx
Reviewed-by: Dean Marx

[PATCH 3/3] net/ntnic: remove unnecessary check for null before free

2024-11-12 Thread Stephen Hemminger
It is unnecessary to check for NULL pointer before calling free. Found by nullfree.cocci Fixes: 1d3f62a0c4f1 ("net/ntnic: add base init and deinit of flow API") Cc: okl-...@napatech.com Signed-off-by: Stephen Hemminger --- drivers/net/ntnic/nthw/flow_api/flow_api.c | 6 ++

Re: [PATCH v3 4/4] dts: update autodoc sorting order

2024-11-12 Thread Dean Marx
Reviewed-by: Dean Marx

Re: [PATCH v3 1/4] dts: add tests package to API docs

2024-11-12 Thread Dean Marx
Reviewed-by: Dean Marx

RE: [PATCH v1] maintainers: update maintainer for DLB Driver

2024-11-12 Thread Sevincer, Abdullah
Acked-by: Abdullah Sevincer

Re: Bus scan is too chatty

2024-11-12 Thread Patrick Robb
No worries Ferruh, the reason is not very interesting so you can stop here. :) Thanks for rebasing on rc2. But for the record, the cause is the EAL message: "EAL: Scan for (fslmc) bus failed." Which I believe is now removed with this commit which is now in next-net: https://git.dpdk.org/next/dpdk

Re: Bus scan is too chatty

2024-11-12 Thread Ferruh Yigit
On 11/12/2024 5:35 PM, Patrick Robb wrote: > Hello, > > I'm noting here that the compressdev test failures reported over the > weekend for the Community Lab are related to this, as the DTS > compressdev tests fail if EAL contains "failed." So, these patchseries > failures can be ignored by maintai

[PATCH 4/4] net/bnx2x: fix duplicate branch

2024-11-12 Thread Stephen Hemminger
Coverity spotted that both legs of the conditional are the same. Looking at kernel driver there is additional code there, but the kernel driver supports Wake On Lan, and DPDK does not. Coverity issue: 362072 Fixes: 540a211084a7 ("bnx2x: driver core") Signed-off-by: Stephen Hemminger --- drivers

[PATCH 1/4] net/bnx2x: remove dead conditional

2024-11-12 Thread Stephen Hemminger
The second if test here is impossible because it contradicts previous line. Coverity issue: 384428 Fixes: 540a211084a7 ("bnx2x: driver core") Signed-off-by: Stephen Hemminger --- drivers/net/bnx2x/bnx2x_stats.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/bnx2x/bnx2x_stats.

[PATCH 2/4] net/bnx2x: fix always true expression

2024-11-12 Thread Stephen Hemminger
Coverity spotted that the check to enable single interrupt mode would evaluate as always true since: The or condition sc->interrupt_mode != 2 || sc->interrupt_mode != 3 will always be true because sc->interrupt_mode cannot be equal to two different values at the same time, so it must be not equ

[PATCH 3/4] net/bnx2x: fix possible infinite loop at startup

2024-11-12 Thread Stephen Hemminger
Coverity spotted that one of the loop conditions was always true. Fix by initializing the variable using same logic as Linux kernel driver. Coverity issue: 362057 Fixes: 540a211084a7 ("bnx2x: driver core") Signed-off-by: Stephen Hemminger --- drivers/net/bnx2x/bnx2x.c | 5 +++-- 1 file changed,

[PATCH 0/4] Coverity buf fixes for bnx2x

2024-11-12 Thread Stephen Hemminger
These are obvious issues spotted several releases ago by Coverity, and seem to have ended up assigned to me. Hold off the merge until it is tested on real hardware; sorry, I don't have this NIC. Stephen Hemminger (4): net/bnx2x: remove dead conditional net/bnx2x: fix always true expression

[PATCH 2/3] net/dpaa2: remove unnecessary check for null before rte_free

2024-11-12 Thread Stephen Hemminger
Calling rte_free() with NULL parameter is allowed. Found by nullfree.cocci Fixes: 5964d36a2904 ("net/dpaa2: release port upon close") Cc: sachin.sax...@oss.nxp.com Signed-off-by: Stephen Hemminger --- drivers/net/dpaa2/dpaa2_ethdev.c | 3 +-- drivers/net/dpaa2/dpaa2_flow.c | 27 +

[PATCH 1/3] bus/fslmc: remove unnecessary null check

2024-11-12 Thread Stephen Hemminger
No need for check for null before calling free(). Caught by nullfree.cocci script. Fixes: 57cb02edf122 ("bus/fslmc: enhance MC VFIO multi-process support") Cc: jun.y...@nxp.com Signed-off-by: Stephen Hemminger --- drivers/bus/fslmc/fslmc_vfio.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletio

[PATCH 0/3] unnecessary checks for null

2024-11-12 Thread Stephen Hemminger
Found by running nullfree.cocci on 24.11-rc2 Stephen Hemminger (3): bus/fslmc: remove unnecessary null check net/dpaa2: remove unnecessary check for null before rte_free net/ntnic: remove unnecessary check for null before free drivers/bus/fslmc/fslmc_vfio.c| 3 +-- drivers

Re: Bus scan is too chatty

2024-11-12 Thread Patrick Robb
Hello, I'm noting here that the compressdev test failures reported over the weekend for the Community Lab are related to this, as the DTS compressdev tests fail if EAL contains "failed." So, these patchseries failures can be ignored by maintainers. I see the fix from Hemant was merged by Thomas.

Re: [PATCH v3 2/3] dts: allow to get multiple expected packets

2024-11-12 Thread Dean Marx
Reviewed-by: Dean Marx

Re: [PATCH v3 1/3] dts: fix adjust L2/L3 addresses behavior

2024-11-12 Thread Dean Marx
Reviewed-by: Dean Marx

Re: [PATCH v7 01/17] net/r8169: add PMD driver skeleton

2024-11-12 Thread Stephen Hemminger
On Tue, 12 Nov 2024 17:57:48 +0800 Howard Wang wrote: > Meson build infrastructure, r8169_ethdev minimal skeleton, > header with Realtek NIC device and vendor IDs. > > Signed-off-by: Howard Wang > --- You should add yourself to .mailmap to fix. Also, needs rebase to apply cleanly now that rele

[PATCH v2] dts: improve statistics

2024-11-12 Thread Luca Vizzarro
From: Tomáš Ďurovec The previous version of statistics store only the last test run attribute and result. In this patch we are adding header for each test run and overall summary of test runs at the end. This is represented as textual summaries with basic information and json result with more det

RE: [EXTERNAL] Re: [PATCH v2] app/dma-perf: per device config support

2024-11-12 Thread Amit Prakash Shukla
12/11/2024 16:26, Amit Prakash Shukla: >> Hi Thomas, >> >> Gentle ping. >> >Yes it was not a top priority for -rc2, >so I will check it soon for -rc3. Sure, thanks.

Re: [PATCH v2] app/dma-perf: per device config support

2024-11-12 Thread Thomas Monjalon
12/11/2024 16:26, Amit Prakash Shukla: > Hi Thomas, > > Gentle ping. Yes it was not a top priority for -rc2, so I will check it soon for -rc3.

RE: [PATCH v2] app/dma-perf: per device config support

2024-11-12 Thread Amit Prakash Shukla
Hi Thomas, Gentle ping. Thanks, Amit Shukla > -Original Message- > From: Amit Prakash Shukla > Sent: Monday, October 21, 2024 2:07 PM > To: Thomas Monjalon > Cc: dev@dpdk.org; Jerin Jacob ; Vamsi Krishna > Attunuru ; Anoob Joseph ; > Gowrishankar Muthukrishnan ; Cheng Jiang > ; Chengwen

release candidate 24.11-rc2

2024-11-12 Thread Thomas Monjalon
A new DPDK release candidate is ready for testing: https://git.dpdk.org/dpdk/tag/?id=v24.11-rc2 There are 444 new patches in this snapshot, including some library features and new drivers. It is becoming a big release. Release notes: https://doc.dpdk.org/guides/rel_notes/release_2

RE: [PATCH v2] net/mlx5: fix miniCQEs number calculation

2024-11-12 Thread Slava Ovsiienko
> -Original Message- > From: Alexander Kozyrev > Sent: Monday, October 28, 2024 7:15 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Raslan Darawsheh ; Slava > Ovsiienko ; Matan Azrad ; > Dariusz Sosnowski ; Bing Zhao > ; Suanming Mou > Subject: [PATCH v2] net/mlx5: fix miniCQEs number calcu

RE: [PATCH v10 0/6] power: refactor power management library

2024-11-12 Thread Tummala, Sivaprasad
[AMD Official Use Only - AMD Internal Distribution Only] Hi David, -Original Message- From: David Marchand Sent: Tuesday, November 12, 2024 4:08 PM To: Tummala, Sivaprasad ; Thomas Monjalon Cc: david.h...@intel.com; anatoly.bura...@intel.com; jer...@marvell.com; radu.nico...@intel.com

Re: [PATCH v2 1/2] power: fix build with libvirt

2024-11-12 Thread David Marchand
On Tue, Nov 12, 2024 at 3:01 PM David Marchand wrote: > > Following moving rte_power_guest* API from the power library to the > kvm_vm driver, the symbols are not exposed anymore, since the library > hosting them is the kvm_vm driver binary. > > Finish this cleanup by hosting the rte_power_guest_c

Re: [PATCH v2] usertools/devbind: support all possible values in sysfs flag

2024-11-12 Thread Robin Jarry
Rogelio Domínguez Hernández, Nov 12, 2024 at 15:07: This patch adds support for 'y' and 'Y' values when reading vfio-pci unsafe_noiommu_mode flag. Possible values were taken from linux kernel (sysfs__read_bool() in tools/lib/api/fs/fs.c) Signed-off-by: Rogelio Domínguez Hernández Thanks! Re

[PATCH v2] usertools/devbind: support all possible values in sysfs flag

2024-11-12 Thread Rogelio Domínguez Hernández
This patch adds support for 'y' and 'Y' values when reading vfio-pci unsafe_noiommu_mode flag. Possible values were taken from linux kernel (sysfs__read_bool() in tools/lib/api/fs/fs.c) Signed-off-by: Rogelio Domínguez Hernández --- usertools/dpdk-devbind.py | 3 ++- 1 file changed, 2 insertion

[PATCH v2 2/2] ci: install libvirt

2024-11-12 Thread David Marchand
Install libvirt so that vm_power_manager example compilation is tested. Signed-off-by: David Marchand --- .github/workflows/build.yml | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index f7d3affbaa..067862d

[PATCH v2 1/2] power: fix build with libvirt

2024-11-12 Thread David Marchand
Following moving rte_power_guest* API from the power library to the kvm_vm driver, the symbols are not exposed anymore, since the library hosting them is the kvm_vm driver binary. Finish this cleanup by hosting the rte_power_guest_channel.h header in the driver, then version the symbols and add co

Re: [PATCH] usertools/devbind: support all possible values sysfs flag

2024-11-12 Thread Robin Jarry
Hi, Rogelio Domínguez Hernández, Nov 12, 2024 at 14:15: This patch adds support for 'y' and 'Y' values when reading vfio-pci unsafe_noiommu_mode flag. Possible values were taken from linux kernel (sysfs__read_bool() in tools/lib/api/fs/fs.c) Signed-off-by: Rogelio Domínguez Hernández --- use

Re: [PATCH v2] power: fix a typo in the PM QoS guide

2024-11-12 Thread Thomas Monjalon
12/11/2024 09:35, Huisong Li: > The typo in the guide is hard to understand. Necessary to fix it. > > Fixes: dd6fd75bf662 ("power: introduce PM QoS API on CPU wide") > > Signed-off-by: Huisong Li > --- > --- a/doc/guides/prog_guide/power_man.rst > +++ b/doc/guides/prog_guide/power_man.rst > -Som

[PATCH] usertools/devbind: support all possible values sysfs flag

2024-11-12 Thread Rogelio Domínguez Hernández
This patch adds support for 'y' and 'Y' values when reading vfio-pci unsafe_noiommu_mode flag. Possible values were taken from linux kernel (sysfs__read_bool() in tools/lib/api/fs/fs.c) Signed-off-by: Rogelio Domínguez Hernández --- usertools/dpdk-devbind.py | 3 ++- 1 file changed, 2 insertion

Re:RE: Re:RE: [EXTERNAL] [PATCH] graph: optimize graph search when scheduling nodes

2024-11-12 Thread Huichao Cai
>OK. @Huichao Cai Please send two patches (a) new proposal and (b) your >improvement as series. >Update ABI Changes section in doc/guides/rel_notes/release_24_11.rst Ok.I >will send these two patches soon.

Re: [PATCH v8 00/47] TruFlow update for Thor2

2024-11-12 Thread Thomas Monjalon
08/11/2024 03:14, Ajit Khaparde: > On Thu, Nov 7, 2024 at 6:05 PM Sriharsha Basavapatna > wrote: > > > v7->v8: > > > Changed logging macros CFA_TCAM_MGR_TRACE()->PMD_DRV_LOG_LINE() > > > Fixed the following checkpatch warnings: > > > Writing to stdout or stderr > > > Using __atomic_xxx/__ATOMI

Re: [PATCH v10 0/6] power: refactor power management library

2024-11-12 Thread David Marchand
On Tue, Nov 12, 2024 at 9:20 AM David Marchand wrote: > > Hello Siva, Thomas, > > On Sun, Nov 10, 2024 at 7:36 PM Thomas Monjalon wrote: > > > > 28/10/2024 20:55, Sivaprasad Tummala: > > > This patchset refactors the power management library, addressing both > > > core and uncore power management

[PATCH 2/2] ci: install libvirt

2024-11-12 Thread David Marchand
Install libvirt so that vm_power_manager example compilation is tested. Signed-off-by: David Marchand --- .github/workflows/build.yml | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index f7d3affbaa..067862d

[PATCH 1/2] power: fix build with libvirt

2024-11-12 Thread David Marchand
Following moving rte_power_guest* API from the power library to the kvm_vm driver, the symbols are not exposed anymore, since the library hosting them is the kvm_vm driver binary. Finish this cleanup by hosting the rte_power_guest_channel.h header in the driver, then version the symbols and add co

RE: Re:RE: [EXTERNAL] [PATCH] graph: optimize graph search when scheduling nodes

2024-11-12 Thread Jerin Jacob
> -Original Message- > From: David Marchand > Sent: Tuesday, November 12, 2024 2:21 PM > To: Jerin Jacob > Cc: Huichao Cai ; Kiran Kumar Kokkilagadda > ; Nithin Kumar Dabilpuram > ; yanzhirun_...@163.com; dev@dpdk.org; > Thomas Monjalon ; Robin Jarry > Subject: Re: Re:RE: [EXTERNAL] [

[PATCH] common/mlx5: fix misalignment issue detected by ASan

2024-11-12 Thread Shani Peretz
ASan reported a runtime error due to misalignment involving three structures. The first issue arises when accessing l_inconst->cache[MLX5_LIST_GLOBAL]->h. If struct mlx5_list_cache is not properly aligned, the pointer gc, assigned to l_inconst->cache[MLX5_LIST_GLOBAL], could be misaligned. To addr

[PATCH v7 03/17] net/r8169: add hardware registers access routines

2024-11-12 Thread Howard Wang
Add implementation for hardware registers access routines such as mmio read/write, mac ocp read/write, csi read/write and so on. Signed-off-by: Howard Wang --- drivers/net/r8169/meson.build| 1 + drivers/net/r8169/r8169_compat.h | 377 +++ drivers/net/r8169/r816

[PATCH v7 15/17] net/r8169: implement MTU configuration

2024-11-12 Thread Howard Wang
Add support for updating MTU value. Signed-off-by: Howard Wang --- doc/guides/nics/features/r8169.ini | 1 + drivers/net/r8169/r8169_ethdev.c | 20 2 files changed, 21 insertions(+) diff --git a/doc/guides/nics/features/r8169.ini b/doc/guides/nics/features/r8169.ini ind

[PATCH v7 04/17] net/r8169: implement core logic for Tx/Rx

2024-11-12 Thread Howard Wang
Add RX/TX function prototypes for further datapath development. Signed-off-by: Howard Wang --- drivers/net/r8169/meson.build| 1 + drivers/net/r8169/r8169_ethdev.c | 20 +- drivers/net/r8169/r8169_ethdev.h | 6 + drivers/net/r8169/r8169_rxtx.c | 45 +++

[dpdk-dev] [PATCH v3 2/2] net/cnxk: support rte flow on cn20k

2024-11-12 Thread psatheesh
From: Satheesh Paul Support for rte flow in cn20k. Signed-off-by: Satheesh Paul Reviewed-by: Kiran Kumar K --- drivers/net/cnxk/cn10k_flow.c | 227 ++--- drivers/net/cnxk/cn10k_flow.h | 10 +- drivers/net/cnxk/cn20k_ethdev.c| 4 + drivers/net/c

[PATCH v7 09/17] net/r8169: add support for HW initialization

2024-11-12 Thread Howard Wang
This patch initializes software variables, resets the NIC, and performs other hw initialization tasks. Signed-off-by: Howard Wang --- drivers/net/r8169/meson.build| 1 + drivers/net/r8169/r8169_compat.h | 39 +++ drivers/net/r8169/r8169_dash.c | 86 + drivers/net/r8169/r8169_dash.h

[PATCH v7 02/17] net/r8169: add logging structure

2024-11-12 Thread Howard Wang
Implement logging macros for debug purposes. Signed-off-by: Howard Wang --- drivers/net/r8169/r8169_ethdev.c | 9 +++ drivers/net/r8169/r8169_logs.h | 46 2 files changed, 55 insertions(+) create mode 100644 drivers/net/r8169/r8169_logs.h diff --git a/dr

[PATCH v7 17/17] net/r8169: add driver start and driver stop

2024-11-12 Thread Howard Wang
rtl8125ap and rtl8125bp need driver start and stop whether dash is enabled or not. Signed-off-by: Howard Wang --- drivers/net/r8169/base/rtl8126a_mcu.h | 1 + drivers/net/r8169/r8169_compat.h | 6 +- drivers/net/r8169/r8169_dash.c| 149 +- drivers/net/r81

[PATCH v7 16/17] net/r8169: add support for getting FW version

2024-11-12 Thread Howard Wang
Signed-off-by: Howard Wang --- doc/guides/nics/features/r8169.ini | 1 + drivers/net/r8169/r8169_ethdev.c | 20 2 files changed, 21 insertions(+) diff --git a/doc/guides/nics/features/r8169.ini b/doc/guides/nics/features/r8169.ini index 6c8f087ade..5ff4003986 100644 ---

[PATCH v7 14/17] net/r8169: implement promisc and allmulti modes

2024-11-12 Thread Howard Wang
Add support for promiscuous/allmulticast modes configuration. Signed-off-by: Howard Wang --- doc/guides/nics/features/r8169.ini | 4 ++ drivers/net/r8169/r8169_ethdev.c | 67 ++ 2 files changed, 71 insertions(+) diff --git a/doc/guides/nics/features/r8169.ini b/d

[PATCH v7 13/17] net/r8169: implement device statistics

2024-11-12 Thread Howard Wang
Signed-off-by: Howard Wang --- doc/guides/nics/features/r8169.ini | 1 + drivers/net/r8169/r8169_compat.h | 16 ++ drivers/net/r8169/r8169_ethdev.c | 48 ++ drivers/net/r8169/r8169_ethdev.h | 3 ++ drivers/net/r8169/r8169_hw.c | 80 ++

[PATCH v7 12/17] net/r8169: implement Tx path

2024-11-12 Thread Howard Wang
Add implementation for TX datapath. Signed-off-by: Howard Wang --- doc/guides/nics/features/r8169.ini | 1 + drivers/net/r8169/r8169_ethdev.c | 6 + drivers/net/r8169/r8169_ethdev.h | 11 + drivers/net/r8169/r8169_rxtx.c | 657 - 4 files changed, 671 inse

[PATCH v7 11/17] net/r8169: implement Rx path

2024-11-12 Thread Howard Wang
Add implementation for RX datapath. Signed-off-by: Howard Wang --- doc/guides/nics/features/r8169.ini | 5 + doc/guides/nics/r8169.rst | 8 + drivers/net/r8169/r8169_compat.h | 24 + drivers/net/r8169/r8169_ethdev.c | 76 ++- drivers/net/r8169/r8169_ethdev.h | 18 + drivers

[PATCH v7 10/17] net/r8169: add link status and interrupt management

2024-11-12 Thread Howard Wang
Signed-off-by: Howard Wang --- doc/guides/nics/features/r8169.ini | 5 + drivers/net/r8169/r8169_compat.h | 1 + drivers/net/r8169/r8169_ethdev.c | 278 - drivers/net/r8169/r8169_ethdev.h | 3 + drivers/net/r8169/r8169_hw.c | 8 +- drivers/net/r8169

[PATCH v7 08/17] net/r8169: add support for PHY configuration

2024-11-12 Thread Howard Wang
This patch is for phy configuration which contains phy power up/down, phy config, ephy config and so on. Signed-off-by: Howard Wang --- drivers/net/r8169/r8169_ethdev.c | 15 +- drivers/net/r8169/r8169_ethdev.h | 6 + drivers/net/r8169/r8169_phy.c| 449 +++ dri

[PATCH v7 06/17] net/r8169: add PHY registers access routines

2024-11-12 Thread Howard Wang
Signed-off-by: Howard Wang --- drivers/net/r8169/r8169_ethdev.h | 1 + drivers/net/r8169/r8169_hw.c | 2 +- drivers/net/r8169/r8169_phy.c| 219 +++ drivers/net/r8169/r8169_phy.h| 18 +++ 4 files changed, 239 insertions(+), 1 deletion(-) diff --git a/d

[PATCH v7 05/17] net/r8169: add support for HW config

2024-11-12 Thread Howard Wang
Implement the rtl_hw_config function to configure the hardware. This function is similar to rtl81xx_hw_config in Realtek Linux driver, primarily initializing some registers during the start. Signed-off-by: Howard Wang --- drivers/net/r8169/meson.build| 1 + drivers/net/r8169/r8169_compat.h

[dpdk-dev] [PATCH v3 1/2] common/cnxk: support NPC flow on cn20k

2024-11-12 Thread psatheesh
From: Satheesh Paul ROC changes to support NPC flow on cn20k. Signed-off-by: Satheesh Paul Reviewed-by: Kiran Kumar K --- v2: * Fixed generic platform compiler error. v3: * Removed compile time macros. drivers/common/cnxk/roc_mbox.h | 144 +- drivers/common/cnxk/roc_nix.h

  1   2   >