On 13-11-2024 22:18, David Marchand wrote:
Hello Hemant,
On Wed, Nov 13, 2024 at 5:15 PM Hemant Agrawal wrote:
The error handling is missing FQ unlock code.
Detected by pvr-studio
Bug 89-93: very suspicious synchronization
The analyzer issued a pack of V1020 warnings that a resource
might re
To avoid regressions on this topic, could you look into enabling clang
thread safety check?
Signed-off-by: David Marchand
Signed-off-by: Hemant Agrawal
---
drivers/bus/dpaa/base/qbman/qman.c | 35 --
drivers/bus/dpaa/meson.build | 2 --
2 files changed, 19 ins
Detected by pvs-studio
Bug 89-93: very suspicious synchronization
The analyzer issued a pack of V1020 warnings that a resource
might remain blocked.
Fixes: 080f57bceca4 ("examples/l2fwd-event: add eventdev main loop")
Cc: pbhagavat...@marvell.com
Cc: sta...@dpdk.org
Signed-off-by: Hemant Agrawal
The error handling is missing FQ unlock code.
Detected by pvs-studio
Bug 89-93: very suspicious synchronization
The analyzer issued a pack of V1020 warnings that a resource
might remain blocked.
Fixes: c47ff048b99a ("bus/dpaa: add QMAN driver core routines")
Cc: sta...@dpdk.org
Signed-off-by: Hem
> -Original Message-
> From: Medvedkin, Vladimir [mailto:vladimir.medved...@intel.com]
> Sent: Wednesday, 13 November 2024 20.39
> To: Robin Jarry; dev@dpdk.org
> Subject: RE: rte_fib network order bug
>
> I think control plane API should work with prefix addresses in CPU byte
> order. At
From: Kiran Kumar K
The graph autotest second run test is failing due to the
node name is already present in the node list. Adding changes
to free nodes at the time of test cleanup.
Fixes: 6b89650418fe ("test/graph: add functional tests")
Signed-off-by: Kiran Kumar K
---
app/test/test_graph.c
From: Sunil Kumar Kori
Bugzilla ID: 1513
Fixes: 03b152389fb1 ("net/cnxk: add option to enable custom inbound SA")
Fixes: 7df4ead35436 ("net/cnxk: support parsing custom SA action")
Fixes: 47cca253d605 ("net/cnxk: support Rx inject")
Cc: sta...@dpdk.org
Signed-off-by: Sunil Kumar Kori
---
drive
From: Sunil Kumar Kori
Bugzilla ID: 1513
Fixes: 72c00ae9dba7 ("regex/cn9k: use cnxk infrastructure")
Cc: sta...@dpdk.org
Signed-off-by: Sunil Kumar Kori
---
drivers/regex/cn9k/cn9k_regexdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regex/cn9k/cn9k_regexdev.c
From: Sunil Kumar Kori
Bugzilla ID: 1513
Fixes: 39ac394aa7a8 ("common/cnxk: fix device MSI-X greater than default value")
Cc: sta...@dpdk.org
Signed-off-by: Sunil Kumar Kori
---
drivers/common/cnxk/roc_irq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/common/cnx
> -Original Message-
> From: Huichao Cai
> Sent: Wednesday, November 13, 2024 1:06 PM
> To: Jerin Jacob ; Kiran Kumar Kokkilagadda
> ; Nithin Kumar Dabilpuram
> ; yanzhirun_...@163.com
> Cc: dev@dpdk.org
> Subject: [EXTERNAL] [PATCH v3 2/2] graph: add alignment to the member of
> rte_no
> -Original Message-
> From: Huichao Cai
> Sent: Wednesday, November 13, 2024 2:52 PM
> To: Jerin Jacob
> Cc: David Marchand ; Kiran Kumar
> Kokkilagadda ; Nithin Kumar Dabilpuram
> ; yanzhirun_...@163.com; dev@dpdk.org;
> Thomas Monjalon ; Robin Jarry
> Subject: Re:RE: Re:RE: [EXTERN
From: Kiran Kumar K
The node id is determined based on a global variable that is
incremented every time a node is created. Adding changes to
remove the global counter. Make sure that the node list is always
ordered by increasing node ids. When creating a new node, pick a free
id which is not allo
> + while (*addrs == '\0' && isspace(*addrs))
> addrs++;
This is never going to happen. Did you mean ||?
On 14-11-2024 06:06, Stephen Hemminger wrote:
Fallthrough warnings catch real bugs and should not be disabled.
There are warnings in this driver in current build.
The commit that added the disable is old, and the problematic code
appears to have been already removed.
Fixes: 2ab9a9483196 ("cry
As best as I can tell -1 vs -2 index is not important as they are named
args, and using the -2 breaks functionality. But we can chat tomorrow if
you don't agree.
Applied the v1 + my fixup per my comments above to next-dts.
add the tsc into the name.
Signed-off-by: Congjie Zhou
---
When multiple secondary processes run in different containers, names
identified by PIDs are not unique due to the pid namespace.
Add tsc to redefine a unique name.
lib/eal/linux/eal_memalloc.c | 5 +++--
1 file changed, 3 insertions(+)
Calling memset before free() has no effect and will be flagged
by security parsing tools as a potential bug. None of these data
structures have sensitive information.
Signed-off-by: Stephen Hemminger
---
drivers/net/ntnic/nthw/core/nthw_hif.c| 5 +
drivers/net/ntnic/nthw/core
Calling memset before rte_free not necessary, and could be
removed by the compiler. In this case, the data is not security
sensitive so the memset can be removed. Some security scanning
tools will flag this.
Signed-off-by: Stephen Hemminger
---
drivers/compress/octeontx/otx_zip.c | 1 -
driv
There is no need to cast memset to void.
Signed-off-by: Stephen Hemminger
---
drivers/net/ntnic/nim/i2c_nim.c | 2 +-
drivers/net/ntnic/nthw/flow_filter/flow_nthw_cat.c| 4 ++--
drivers/net/ntnic/nthw/flow_filter/flow_nthw_csu.c| 4 ++--
drivers/net/ntnic/nthw/flow_
Need to check the result of malloc() before calling memset.
This is only place in this driver that forgot, other code
does check.
Signed-off-by: Stephen Hemminger
---
drivers/net/ntnic/nthw/nthw_rac.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ntnic/nthw/n
Since tmp is not used later in the function, this memset
is unnecessary. Even though this is harmless,
it causes tools that look for security issues
around memset to flag this a bug.
Signed-off-by: Stephen Hemminger
---
app/test/test_cmdline_cirbuf.c | 2 --
1 file changed, 2 deletions(-)
diff
Regular memset maybe removed by compiler if done before a free
function. Use new rte_free_sensitive instead.
Signed-off-by: Stephen Hemminger
---
drivers/crypto/qat/qat_asym.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/crypto/qat/qat_asym.c b/drivers/crypto/q
Doing memset before free maybe removed by compiler, and
is flagged by security scanning tools as potential problem.
In this case the memset is unnecessary.
Signed-off-by: Stephen Hemminger
---
drivers/bus/uacce/uacce.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/bus/uacce/uacce.c
Although internally rte_free does poison the buffer in most
cases, it is useful to have function that explicitly does
this to avoid any security issues.
Signed-off-by: Stephen Hemminger
---
lib/eal/common/rte_malloc.c | 30 --
lib/eal/include/rte_malloc.h | 18 ++
The memset was always doing 0 bytes since size computed later.
Link: https://pvs-studio.com/en/blog/posts/cpp/1179/
Fixes: 3a80d7fb2ecd ("crypto/qat: support SHA3 plain hash")
Cc: sta...@dpdk.org
Signed-off-by: Stephen Hemminger
---
drivers/crypto/qat/qat_sym_session.c | 10 +-
1 file
When memset() is used before a release function such as free,
the compiler if allowed to optimize the memset away under
the as-if rules. This is normally ok, but in certain cases such
as passwords or security keys it is problematic.
Introduce a DPDK wrapper which is equivalent to the C++ memset_s
Just doing memset() on keys is not enough, compiler can optimize
it away. Need something with a barrier.
Signed-off-by: Stephen Hemminger
---
drivers/crypto/qat/qat_sym_session.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers/crypto/qat/qat_sym_sess
This series handles memset related bugs indentified by PVS Studio.
The root cause is that Gcc and other compilers are free to
optimize away memset called before free.
Most of the places memset was being used like this were bogus;
probably some developer debug habit, and can be safely removed.
v3
Although internally rte_free does poison the buffer in most
cases, it is useful to have function that explicitly does
this to avoid any security issues.
Signed-off-by: Stephen Hemminger
---
lib/eal/common/rte_malloc.c | 30 --
lib/eal/include/rte_malloc.h | 18 ++
The memset was always doing 0 bytes since size computed later.
Link: https://pvs-studio.com/en/blog/posts/cpp/1179/
Fixes: 3a80d7fb2ecd ("crypto/qat: support SHA3 plain hash")
Cc: sta...@dpdk.org
Signed-off-by: Stephen Hemminger
---
drivers/crypto/qat/qat_sym_session.c | 10 +-
1 file
This series handles memset related bugs indentified by PVS Studio.
The root cause is that Gcc and other compilers are free to
optimize away memset called before free.
Most of the places memset was being used like this were bogus;
probably some developer debug habit, and can be safely
removed.
Ste
Calling memset before rte_free not necessary, and could be
removed by the compiler. In this case, the data is not security
sensitive so the memset can be removed. Some security scanning
tools will flag this.
Signed-off-by: Stephen Hemminger
---
drivers/compress/octeontx/otx_zip.c | 1 -
driv
Since tmp is not used later in the function, this memset
is unnecessary. Even though this is harmless,
it causes tools that look for security issues
around memset to flag this a bug.
Signed-off-by: Stephen Hemminger
---
app/test/test_cmdline_cirbuf.c | 2 --
1 file changed, 2 deletions(-)
diff
Doing memset before free maybe removed by compiler, and
is flagged by security scanning tools as potential problem.
In this case the memset is unnecessary.
Signed-off-by: Stephen Hemminger
---
drivers/bus/uacce/uacce.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/bus/uacce/uacce.c
Regular memset maybe removed by compiler if done before a free
function. Use new rte_free_sensative instead.
Signed-off-by: Stephen Hemminger
---
drivers/crypto/qat/qat_asym.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/crypto/qat/qat_asym.c b/drivers/crypto/q
Just doing memset() on keys is not enough, compiler can optimize
it away. Need something with a barrier.
Signed-off-by: Stephen Hemminger
---
drivers/crypto/qat/qat_sym_session.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers/crypto/qat/qat_sym_sess
When memset() is used before a release function such as free,
the compiler if allowed to optimize the memset away under
the as-if rules. This is normally ok, but in certain cases such
as passwords or security keys it is problematic.
Introduce a DPDK wrapper which is equivalent to the C++ memset_s
Although internally rte_free does poison the buffer in most
cases, it is useful to have function that explicitly does
this to avoid any security issues.
Signed-off-by: Stephen Hemminger
---
lib/eal/common/rte_malloc.c | 30 --
lib/eal/include/rte_malloc.h | 18 ++
Just doing memset() on keys is not enough, compiler can optimize
it away. Need something with a barrier.
Signed-off-by: Stephen Hemminger
---
drivers/crypto/qat/qat_sym_session.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers/crypto/qat/qat_sym_sess
The PVS bug list pointed out a number of places where code is
trying to do memset() on sensative data which can be optimized
away. Introduce som helpers and example usage.
Stephen Hemminger (3):
eal: introduce rte_memset_sensative
crypto/qat: use rte_memset_sensative
eal: add rte_free_sensat
When memset() is used before a release function such as free,
the compiler if allowed to optimize the memset away under
the as-if rules. This is normally ok, but in certain cases such
as passwords or security keys it is problematic.
Introduce a DPDK wrapper which is equivalent to the C++ memset_s
On 2024/11/14 2:56, Stephen Hemminger wrote:
> Doing memset before free maybe removed by compiler, and
> is flagged by security scanning tools as potential problem.
> In this case the memset is unnecessary.
>
> Signed-off-by: Stephen Hemminger
> ---
> drivers/bus/uacce/uacce.c | 1 -
> 1 file ch
Fallthrough warnings catch real bugs and should not be disabled.
There are warnings in this driver in current build.
The commit that added the disable is old, and the problematic code
appears to have been already removed.
Fixes: 2ab9a9483196 ("crypto/dpaa2_sec: fix build with GCC 7")
Cc: tho...@m
There is an incorrect fallthrough identified by PVS studio.
Even though this is in base code it should be fixed, and
the warning should be re-enabled to prevent future bugs.
Link: https://pvs-studio.com/en/blog/posts/cpp/1183/
Fixes: f2553cb9eba6 ("net/e1000/base: add new I219 devices")
Cc: qimin
Fix lack of fallthrough checking and bug in e1000 driver.
Stephen Hemminger (2):
net/e1000: fix incorrect fallthrough in switch
common/dpaax: do not disable fallthrough warnings
drivers/common/dpaax/caamflib/rta/operation_cmd.h | 4
drivers/net/e1000/base/e1000_82575.c | 3
The test loop was much shorter than desired because when
MAX_NUM is defined with out paren's the divide operator /
takes precedence over shift.
But when MAX_NUM is fixed, some tests take too long
and have to modified to avoid running over full N^2
space of 1<<20.
Note: this is a very old bug, goe
There was useless loop when looking at the DMA address.
It looks like it was meant to skip whitespace before
calling strtok.
Good time to replace strtok with strtok_r as well.
Link: https://pvs-studio.com/en/blog/posts/cpp/1179/
Fixes: 623dc9364dc6 ("app/dma-perf: introduce DMA performance test"
The order of comparison is wrong, and potentially allows
referencing past the array.
Link: https://pvs-studio.com/en/blog/posts/cpp/1179/
Fixes: 3e3edab530a1 ("ethdev: add flow quota")
Cc: getel...@nvidia.com
Signed-off-by: Stephen Hemminger
---
app/test-pmd/cmdline_flow.c | 2 +-
1 file change
The loop over policy actions will always exit when it sees
the flow end action, so the next check is redundant.
Link: https://pvs-studio.com/en/blog/posts/cpp/1179/
Fixes: f29fa2c59b85 ("app/testpmd: support policy actions per color")
Cc: haif...@nvidia.com
Signed-off-by: Stephen Hemminger
---
The event_dev_config initialization had duplicate assignments
to the same element. Change to use structure initialization
so that compiler will catch this type of bug.
Link: https://pvs-studio.com/en/blog/posts/cpp/1179/
Fixes: f8f9d233ea0e ("test/eventdev: add unit tests")
Cc: jerin.ja...@cavium
The expression for checking which lcore is enabled for 0-7
was wrong (missing case for 6).
Link: https://pvs-studio.com/en/blog/posts/cpp/1179/
Fixes: b0209034f2bb ("test/eal: check number of cores before running subtests")
Cc: msant...@redhat.com
Signed-off-by: Stephen Hemminger
---
app/test/t
The code was duplicating the same condition three times?
Reading the commit message, the intention was:
Add unit tests to verify the zero len TLS records. Zero len packets are
allowed when content type is app data while zero packet length with
other content type (such as handshake) wou
Do not use same variable for outer and inner loop in bonding test.
Since the loop is just freeing the resulting burst use bulk free.
Link: https://pvs-studio.com/en/blog/posts/cpp/1179/
Fixes: 92073ef961ee ("bond: unit tests")
Cc: declan.dohe...@intel.com
Signed-off-by: Stephen Hemminger
---
a
The parenthesis were in the wrong place so that comparison
took precedence over assignment in handling IPv6 extension
headers. Break up the loop condition to avoid the problem.
Link: https://pvs-studio.com/en/blog/posts/cpp/1179/
Fixes: 15ccc647526e ("test/security: test inline reassembly with m
The first argument of 'memcmp' function was equal to the second argument.
Therefore ASSERT would always be true.
Link: https://pvs-studio.com/en/blog/posts/cpp/1179/
Fixes: 92073ef961ee ("bond: unit tests")
Cc: declan.dohe...@intel.com
Signed-off-by: Stephen Hemminger
---
app/test/test_link_bo
Recent blog post from PVS studio referenced lots bugs found by
their analyzer against DPDK. This set addresses the ones in
the test suite.
Stephen Hemminger (10):
app/test: do not duplicate loop variable
app/test: fix typo in mac address compare
app/test: fix paren typo
app/test: avoid dup
On Thu, 10 Oct 2024 16:13:30 +0200
Serhii Iliushyk wrote:
> +
> +void hsh_nthw_delete(struct hsh_nthw *p)
> +{
> + if (p) {
> + (void)memset(p, 0, sizeof(*p));
> + free(p);
> + }
> +}
This pattern of memset before free is repeated many times in ntnic and is
probl
>
>
> On Fri, Nov 8, 2024 at 8:38 AM Luca Vizzarro
> wrote:
>
>> Allow test suites to be configured individually. Moreover enable them to
>> implement their own custom configuration.
>>
>> This solution adds some new complexity to DTS, which is generated source
>> code. In order to ensure strong t
On 11/13/2024 9:28 AM, Howard Wang wrote:
> Fix some checkpatch warnings and documentation issues.
>
> Howard Wang (17):
> net/r8169: add PMD driver skeleton
> net/r8169: add logging structure
> net/r8169: add hardware registers access routines
> net/r8169: implement core logic for Tx/Rx
>
Applied to next-dts, pardon me. :)
Series applied to next-dts, thanks!
Applied with minor rewording of the commit message, thanks.
On Wed, Nov 13, 2024 at 2:55 AM Patrick Robb wrote:
> Thanks, I've reviewed this and tested it, and I think the results.json is
> good.
>
> This is not a problem, but I am noting here that the 1 value which was
> being tracked in the le
I think control plane API should work with prefix addresses in CPU byte order.
At least our RTE_IPV4 macro works this way. Also, prefix is an address + prefix
length (not the mask), so it is more natural if address is in cpu byte order.
Also, I think byte swap should be done on the interface wher
On Tue, 6 Aug 2024 09:11:20 +0530
Gagandeep Singh wrote:
> The current port ID validation logic in the routes add code has
> two issues:
>
> - It can pass if port ID in route is 31+.
> - It silently skips rules with disabled or invalid
>port IDs
>
> This patch is:
> - Improving the enab
13/11/2024 18:52, Stephen Hemminger:
> On Wed, 13 Nov 2024 18:33:15 +0100
> Thomas Monjalon wrote:
>
> > 24/10/2024 04:06, Ajit Khaparde:
> > > On Tue, Oct 22, 2024 at 10:26 AM Ajit Khaparde
> > > wrote:
> > > >
> > > > On Tue, Oct 22, 2024 at 9:39 AM Stephen Hemminger
> > > > wrote:
> > >
Regular memset maybe removed by compiler if done before a free
function. Use the C11 memset_s instead to ensure security
parameters are cleared.
Signed-off-by: Stephen Hemminger
---
drivers/crypto/qat/qat_asym.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/q
Since tmp is not used later in the function, this memset
is unnecessary. Even though this is harmless,
it causes tools that look for security issues
around memset to flag this a bug.
Signed-off-by: Stephen Hemminger
---
app/test/test_cmdline_cirbuf.c | 2 --
1 file changed, 2 deletions(-)
diff
Calling memset before rte_free not necessary, and could be
removed by the compiler. In this case, the data is not security
sensitive so the memset can be removed. Some security scanning
tools will flag this.
Signed-off-by: Stephen Hemminger
---
drivers/compress/octeontx/otx_zip.c | 1 -
driv
Doing memset before free maybe removed by compiler, and
is flagged by security scanning tools as potential problem.
In this case the memset is unnecessary.
Signed-off-by: Stephen Hemminger
---
drivers/bus/uacce/uacce.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/bus/uacce/uacce.c
The memset was always doing 0 bytes since size computed later.
PVS studio bug 24-27
Fixes: 3a80d7fb2ecd ("crypto/qat: support SHA3 plain hash")
Signed-off-by: Stephen Hemminger
---
drivers/crypto/qat/qat_sym_session.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git
Bruce mentioned recent security scan of DPDK
https://pvs-studio.com/en/blog/posts/cpp/1183/
There are some low hanging fruit things that can be easily addressed.
Stephen Hemminger (5):
crypto/qat: fix memset of SHA3 state
crypto/qat: use secure memset
bus/uacce: remove memset before
There exists a bug within i40e NICs in which the async sniffer does not
catch send packets as a result of the callback function sending packets
too quickly before the NICs are ready to start capturing.
There could be a multitude of reasons why this happens on these NICs, but
for the time being, in
On Wed, 13 Nov 2024 18:33:15 +0100
Thomas Monjalon wrote:
> 24/10/2024 04:06, Ajit Khaparde:
> > On Tue, Oct 22, 2024 at 10:26 AM Ajit Khaparde
> > wrote:
> > >
> > > On Tue, Oct 22, 2024 at 9:39 AM Stephen Hemminger
> > > wrote:
> > > >
> > > > On Fri, 14 Jun 2024 08:41:07 -0700
> > > > St
13/11/2024 04:04, pravin.pat...@intel.com:
> From: Pravin Pathak
>
> Signed-off-by: Pravin Pathak
[...]
> Intel DLB2
> -M: Abdullah Sevincer
> +M: Pravin Pathak
> F: drivers/event/dlb2/
> F: doc/guides/eventdevs/dlb2.rst
Acked-by: Abdullah Sevincer
Applied, thanks.
Note: I don't know wh
---
dts/framework/test_suite.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dts/framework/test_suite.py b/dts/framework/test_suite.py
index 23fe41a10e..7a75334cfa 100644
--- a/dts/framework/test_suite.py
+++ b/dts/framework/test_suite.py
@@ -334,7 +334,7 @@ def get_expected
At the moment there is only one facility that allows to prepare a packet
as it is expected to be received on the traffic generator end. Extend
this to allow to prepare multiple packets at the same time.
Signed-off-by: Luca Vizzarro
Reviewed-by: Paul Szczepanek
---
dts/framework/test_suite.py |
24/10/2024 04:06, Ajit Khaparde:
> On Tue, Oct 22, 2024 at 10:26 AM Ajit Khaparde
> wrote:
> >
> > On Tue, Oct 22, 2024 at 9:39 AM Stephen Hemminger
> > wrote:
> > >
> > > On Fri, 14 Jun 2024 08:41:07 -0700
> > > Stephen Hemminger wrote:
> > >
> > > > Remove one of the few remaining uses of mast
On 11/13/24 06:08, Morten Brørup wrote:
From: Andre Muezerie [mailto:andre...@linux.microsoft.com]
Sent: Wednesday, 13 November 2024 02.25
The issues that were preventing mempool from getting compiled with
MSVC were fixed, so now it should not be excluded from the
build anymore.
Signed-off-by:
Hello Hemant,
On Wed, Nov 13, 2024 at 5:15 PM Hemant Agrawal wrote:
>
> The error handling is missing FQ unlock code.
> Detected by pvr-studio
> Bug 89-93: very suspicious synchronization
> The analyzer issued a pack of V1020 warnings that a resource
> might remain blocked.
>
> Fixes: c47ff048b99
Add a basic L2 forwarding test suite which tests the correct
functionality of the forwarding facility built-in in the DPDK.
The tests are performed with different queues numbers per port.
Signed-off-by: Luca Vizzarro
Signed-off-by: Thomas Wilks
Reviewed-by: Paul Szczepanek
Reviewed-by: Dean Ma
At the moment there is only one facility that allows to prepare a packet
as it is expected to be received on the traffic generator end. Extend
this to allow to prepare multiple packets at the same time.
Signed-off-by: Luca Vizzarro
Reviewed-by: Paul Szczepanek
---
dts/framework/test_suite.py |
Add a basic L2 forwarding test suite which tests the correct
functionality of the forwarding facility built-in in the DPDK.
The tests are performed with different queues numbers per port.
Signed-off-by: Luca Vizzarro
Signed-off-by: Thomas Wilks
Reviewed-by: Paul Szczepanek
Reviewed-by: Dean Ma
At the moment there is only one facility that allows to prepare a packet
as it is expected to be received on the traffic generator end. Extend
this to allow to prepare multiple packets at the same time.
Signed-off-by: Luca Vizzarro
Reviewed-by: Paul Szczepanek
Reviewed-by: Dean Marx
Reviewed-by
The _adjust_addresses function has been updated to both modify the
original packets and return new updated copies of them. Having a double
behavior even if documented is not intuitive and can lead to bugs.
This changes the behavior to solely act on copies, leaving the original
packet untouched.
F
Hi there,
sending in a v5 for l2fwd.
v5:
- re-sent after error in sending v4
v4:
- fixed bug introduced in get_expected_packet
v3:
- addressed comments for docstrings
- make use of @requires
- add a get_expected_packet version for multiple packets
- fix an inconsistency bug with _adjust_addresses
The _adjust_addresses function has been updated to both modify the
original packets and return new updated copies of them. Having a double
behavior even if documented is not intuitive and can lead to bugs.
This changes the behavior to solely act on copies, leaving the original
packet untouched.
F
Add a basic L2 forwarding test suite which tests the correct
functionality of the forwarding facility built-in in the DPDK.
The tests are performed with different queues numbers per port.
Signed-off-by: Luca Vizzarro
Signed-off-by: Thomas Wilks
Reviewed-by: Paul Szczepanek
Reviewed-by: Dean Ma
Hi there,
sending in a v4 for l2fwd.
v4:
- fixed bug introduced in get_expected_packet
v3:
- addressed comments for docstrings
- make use of @requires
- add a get_expected_packet version for multiple packets
- fix an inconsistency bug with _adjust_addresses
- rebased
v2:
- added copyright
- rebas
../lib/rcu/rte_rcu_qsbr.c(101): warning C4334: '<<': result of 32-bit
shift implicitly converted to 64 bits (was 64-bit shift intended?)
../lib/rcu/rte_rcu_qsbr.c(107): warning C4334: '<<': result of 32-bit
shift implicitly converted to 64 bits (was 64-bit shift intended?)
../lib/rcu/rte_rcu_qsbr
https://bugs.dpdk.org/show_bug.cgi?id=1577
Bug ID: 1577
Summary: dts: Request for memory usage test in CI
Product: DPDK
Version: unspecified
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Detected by pvr-studio
Bug 89-93: very suspicious synchronization
The analyzer issued a pack of V1020 warnings that a resource
might remain blocked.
Fixes: 080f57bceca4 ("examples/l2fwd-event: add eventdev main loop")
Cc: pbhagavat...@marvell.com
Cc: sta...@dpdk.org
Signed-off-by: Hemant Agrawal
The error handling is missing FQ unlock code.
Detected by pvr-studio
Bug 89-93: very suspicious synchronization
The analyzer issued a pack of V1020 warnings that a resource
might remain blocked.
Fixes: c47ff048b99a ("bus/dpaa: add QMAN driver core routines")
Cc: sta...@dpdk.org
Signed-off-by: Hem
The function EVP_PKEY_CTX_free allows NULL parameter
(similar to free()).
Signed-off-by: Stephen Hemminger
---
drivers/crypto/openssl/rte_openssl_pmd.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c
b/drivers/crypto/openssl/
Reviewed-by: Patrick Robb
Tested-by: Patrick Robb
Reviewed-by: Patrick Robb
Tested-by: Patrick Robb
On Fri, Nov 8, 2024 at 12:01 PM Luca Vizzarro wrote:
> Add a basic L2 forwarding test suite which tests the correct
> functionality of the forwarding facility built-in in the DPDK.
>
> The tests are performed with different queues numbers per p
Reviewed-by: Patrick Robb
Tested-by: Patrick Robb
Hi,
From: Alexander Kozyrev
Sent: Wednesday, November 13, 2024 3:50 PM
To: dev@dpdk.org
Cc: sta...@dpdk.org; Raslan Darawsheh; Slava Ovsiienko; Matan Azrad; Dariusz
Sosnowski; Bing Zhao; Suanming Mou
Subject: [PATCH v3] net/mlx5: fix miniCQEs number calculation
Use the information from the CQE,
On Wed, 13 Nov 2024 17:22:57 +0800 (CST)
wrote:
> Hi Stephen，
>
> >> +char zxdh_gdma_driver_name[] = "rawdev_zxdh_gdma";>> +char dev_name[] =
> >> "zxdh_gdma";>> +>> +uint32_t>> +zxdh_gdma_read_reg(struct rte_rawdev *dev,
> >> uint16_t queue_id, uint32_t offset)>> +{>> +struct zxdh_gdma_ra
Hi,
From: Itamar Gozlan
Sent: Tuesday, October 29, 2024 3:24 PM
To: Itamar Gozlan; Erez Shitrit; Bing Zhao; NBU-Contact-Thomas Monjalon
(EXTERNAL); Suanming Mou; Dariusz Sosnowski; Slava Ovsiienko; Ori Kam; Matan
Azrad; Alex Vesker
Cc: dev@dpdk.org; sta...@dpdk.org
Subject: [PATCH] net/mlx5/hws
This patch is for phy configuration which contains phy power up/down,
phy config, ephy config and so on.
Signed-off-by: Howard Wang
---
drivers/net/r8169/r8169_ethdev.c | 15 +-
drivers/net/r8169/r8169_ethdev.h | 6 +
drivers/net/r8169/r8169_phy.c| 448 +++
dri
1 - 100 of 133 matches
Mail list logo
