Re: [PATCH] test/bonding: fix active backup rx test

2024-12-12 Thread lihuisong (C)
Hi Stephen, This patch looks good to me. But this test case still runs failure when I run "link_bonding_autotest" twice. like: --> ... EAL: Test assert configure_ethdev line 181 failed: rte_eth_dev_configure for port 7 failed EAL: Test assert initialize_bonding_device_with_members line 1138

Re: [PATCH v1] event/dlb2: add port attribute for independent enqueue

2024-12-12 Thread Thomas Monjalon
13/12/2024 05:33, pravin.pat...@intel.com: > From: Pravin Pathak > > Independent Enqueue support is added to DPDK 24.11 > Adding the attribute rte_event_port_attr_get() was missing > This commit adds it to retrieve port attributes > > Signed-off-by: Pravin Pathak The title mentions dlb2 but th

Re: [PATCH v2] net/mlx5: fix hypervisor detection in VLAN workaround

2024-12-12 Thread Thomas Monjalon
12/12/2024 18:27, Stephen Hemminger: > On Thu, 12 Dec 2024 11:52:51 +0100 > Thomas Monjalon wrote: > > > 06/12/2024 15:26, Viacheslav Ovsiienko: > > > The mlx5 PMD provides a specific workaround for the VMware ESXi > > > hypervisor, enabling on-demand routing configuration to virtual > > > machin

Re: [PATCH 2/3] power: defer lcore variable allocation

2024-12-12 Thread Mattias Rönnblom
On 2024-12-12 08:57, David Marchand wrote: On Fri, Dec 6, 2024 at 12:29 PM Mattias Rönnblom wrote: I would wrap all RTE_LCORE_VAR_LCORE() and RTE_LCORE_VAR(). static struct pmd_core_cfg * get_cfg_lcore(unsigned int lcore_id) { assure_lcore_cfgs_alloced(); return RTE_LCORE_VAR

Re: [PATCH v1] event/dlb2: add port attribute for independent enqueue

2024-12-12 Thread Mattias Rönnblom
On 2024-12-13 05:33, pravin.pat...@intel.com wrote: From: Pravin Pathak Independent Enqueue support is added to DPDK 24.11 "." Adding the attribute rte_event_port_attr_get() was missing There is something wrong with that sentence. "Add the corresponding rte_event_port_attr_get() attribut

[PATCH v1] event/dlb2: add port attribute for independent enqueue

2024-12-12 Thread pravin . pathak
From: Pravin Pathak Independent Enqueue support is added to DPDK 24.11 Adding the attribute rte_event_port_attr_get() was missing This commit adds it to retrieve port attributes Signed-off-by: Pravin Pathak --- lib/eventdev/rte_eventdev.c | 8 lib/eventdev/rte_eventdev.h | 6 ++ 2

[PATCH] app/test: fix stack overflow in lpm6_perf_autotest

2024-12-12 Thread Andre Muezerie
Test lpm6_perf_autotest was hitting a stack overflow on Windows with both MSVC and Clang. The fix is to move some of the data from the stack to the heap. Signed-off-by: Andre Muezerie --- app/test/test_lpm6_perf.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/a

Re: [PATCH v2 1/2] net/bonding: introduce direct link bonding mode

2024-12-12 Thread lihuisong (C)
在 2024/12/13 2:07, Stephen Hemminger 写道: On Fri, 12 Apr 2024 14:27:39 +0200 Kamil Vojanec wrote: This patch adds a new bonding mode: 'direct'. The purpose of this mode is to redirect output packets to the same member port on which they were received. In case the requested port is not among t

[PATCH v5] graph: mcore: optimize graph search

2024-12-12 Thread Huichao Cai
In the function __rte_graph_mcore_dispatch_sched_node_enqueue, use a slower loop to search for the graph, modify the search logic to record the result of the first search, and use this record for subsequent searches to improve search speed. Signed-off-by: Huichao Cai --- doc/guides/rel_notes/rel

[DPDK/ethdev Bug 1602] igc: hardware timestamp is always zero with RTE_ETH_RX_OFFLOAD_TIMESTAMP

2024-12-12 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1602 Bug ID: 1602 Summary: igc: hardware timestamp is always zero with RTE_ETH_RX_OFFLOAD_TIMESTAMP Product: DPDK Version: 23.11 Hardware: x86 OS: Linux Stat

[PATCH] test/bonding: fix active backup rx test

2024-12-12 Thread Stephen Hemminger
The test had incorrect assumptions about how active backup should work. When in active backup mode, the secondary (not primary) ports should be ignored. The test was always broken since initially written but earlier bug was masking the part of the test which tested non-primary ports. Bugzilla ID:

RE: 22.11.7 patches review and test

2024-12-12 Thread Xu, HailinX
> -Original Message- > From: luca.bocca...@gmail.com > Sent: Sunday, December 1, 2024 8:24 AM > To: sta...@dpdk.org > Cc: dev@dpdk.org; Abhishek Marathe ; > Ali Alnubani ; David Christensen > ; Hemant Agrawal ; > Stokes, Ian ; Jerin Jacob ; > Mcnamara, John ; Ju-Hyoung Lee > ; Kevin Trayno

[DPDK/DTS Bug 1601] Write TG subclass for a DPDK enabled traffic generator

2024-12-12 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1601 Bug ID: 1601 Summary: Write TG subclass for a DPDK enabled traffic generator Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity

DPDK 25.03 DPDK Test Suite Roadmap

2024-12-12 Thread Patrick Robb
25.03 DTS Roadmap Below is the 25.03 DTS Roadmap. There are both some carry over series from the previous (24.11) development cycle which are ongoing, as well as new items. 1. Add virtual function configuration support 1. Bugzilla: https://bugs.dpdk.org/show_bug.cgi?id=1500

[DPDK/DTS Bug 1600] Add test case/suite context parameters, e.g. required cores

2024-12-12 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1600 Bug ID: 1600 Summary: Add test case/suite context parameters, e.g. required cores Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCON

[DPDK/DTS Bug 1599] Update testsuite subclass docstrings so that they all use the “Steps” and “Verify” format for each testcase.

2024-12-12 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1599 Bug ID: 1599 Summary: Update testsuite subclass docstrings so that they all use the “Steps” and “Verify” format for each testcase. Product: DPDK Version: unspecified Hardware: All

[DPDK/DTS Bug 1598] Potential Implementation Problems With Certain conf.yaml attributes within DTS Framework

2024-12-12 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1598 Bug ID: 1598 Summary: Potential Implementation Problems With Certain conf.yaml attributes within DTS Framework Product: DPDK Version: 25.03 Hardware: All OS: All

[PATCH v1] dts: bug fixes for paramiko timeout and buffered_pipe issues

2024-12-12 Thread Nicholas Pratte
There exists some inconsistencies in the successful initialization of interactive applications within remote sessions. On some testbeds, there is a consistent failure in the first start-up attempt of an application, and 'stdin' and 'stdout' buffered pipes also indicate improper deallocation. The i

[DPDK/DTS Bug 1597] Assess and fix Paramiko buffered pipe and interactive shell initialization issues.

2024-12-12 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1597 Bug ID: 1597 Summary: Assess and fix Paramiko buffered pipe and interactive shell initialization issues. Product: DPDK Version: 25.03 Hardware: All OS: All

RE: [RFC 0/8] ioring: network driver

2024-12-12 Thread Konstantin Ananyev
> > > This is first draft of new simplified TAP device that uses > > > the Linux kernel ioring API to provide a read/write ring > > > with kernel. > > > > > > This is split from tap device because there are so many > > > unnecessary things in existing tap, and supporting ioring is > > > better wi

Re: [PATCH] net/failsafe: Fix crash due to in-valid sub-device port id

2024-12-12 Thread Stephen Hemminger
On Wed, 7 Dec 2022 17:21:42 + Ferruh Yigit wrote: > On 11/16/2022 12:11 PM, madhuker.myt...@oracle.com wrote: > > From: Madhuker Mythri > > > > Crash occurring while the DPDK secondary processes trying to probe the > > tap-device, where tap-device is a sub-device of Fail-safe device. > > So

Re: [PATCH v2] net/mlx5: fix hypervisor detection in VLAN workaround

2024-12-12 Thread Stephen Hemminger
On Thu, 12 Dec 2024 11:52:51 +0100 Thomas Monjalon wrote: > 06/12/2024 15:26, Viacheslav Ovsiienko: > > The mlx5 PMD provides a specific workaround for the VMware ESXi > > hypervisor, enabling on-demand routing configuration to virtual > > machines. This workaround activates when the device type

Re: 22.11.7 patches review and test

2024-12-12 Thread Luca Boccassi
On Thu, 12 Dec 2024 at 16:23, Ali Alnubani wrote: > > > -Original Message- > > From: luca.bocca...@gmail.com > > Sent: Sunday, December 1, 2024 2:24 AM > > To: sta...@dpdk.org > > Cc: dev@dpdk.org; Abhishek Marathe ; Ali > > Alnubani ; David Christensen ; > > Hemant Agrawal ; Ian Stokes >

RE: 23.11.3 patches review and test

2024-12-12 Thread Ali Alnubani
> -Original Message- > From: Xueming Li > Sent: Tuesday, December 10, 2024 4:49 PM > To: sta...@dpdk.org > Cc: dev@dpdk.org; Abhishek Marathe ; Ali > Alnubani ; David Christensen ; > Hemant Agrawal ; Ian Stokes > ; Jerin Jacob ; John McNamara > ; Ju-Hyoung Lee ; Kevin > Traynor ; Luca Bocc

RE: 22.11.7 patches review and test

2024-12-12 Thread Ali Alnubani
> -Original Message- > From: luca.bocca...@gmail.com > Sent: Sunday, December 1, 2024 2:24 AM > To: sta...@dpdk.org > Cc: dev@dpdk.org; Abhishek Marathe ; Ali > Alnubani ; David Christensen ; > Hemant Agrawal ; Ian Stokes > ; Jerin Jacob ; John McNamara > ; Ju-Hyoung Lee ; Kevin > Traynor

[PATCH v1 3/4] net/igc: prevent crashes in secondary processes

2024-12-12 Thread Anatoly Burakov
Currently, the architecture of the base driver is such that it uses function pointers internally. These are not guaranteed to be valid in secondary processes, which can lead to crashes. This patch prevents these functions from being executed in igc driver. Fixes: 4f09bc55ac3d ("net/igc: implement

[PATCH v1 4/4] net/ixgbe: prevent crashes in secondary processes

2024-12-12 Thread Anatoly Burakov
Currently, the architecture of the base driver is such that it uses function pointers internally. These are not guaranteed to be valid in secondary processes, which can lead to crashes. This patch prevents these functions from being executed in ixgbe driver. Bugzilla ID: 1575 Fixes: af75078fece3

[PATCH v1 2/4] net/igb: prevent crashes in secondary processes

2024-12-12 Thread Anatoly Burakov
Currently, the architecture of the base driver is such that it uses function pointers internally. These are not guaranteed to be valid in secondary processes, which can lead to crashes. This patch prevents these functions from being executed in igb driver. Fixes: af75078fece3 ("first public releas

[PATCH v1 1/4] net/e1000: prevent crashes in secondary processes

2024-12-12 Thread Anatoly Burakov
Currently, the architecture of the base driver is such that it uses function pointers internally. These are not guaranteed to be valid in secondary processes, which can lead to crashes. This patch prevents these functions from being executed in e1000 driver. Fixes: 805803445a02 ("e1000: support EM

[PATCH v2 2/3] eal: enhance lock annotations for spinlock and seqlock

2024-12-12 Thread David Marchand
Convert spinlock (and as a consequence seqlock) to the clang capability annotations. Signed-off-by: David Marchand Acked-by: Mattias Rönnnblom --- drivers/bus/dpaa/base/qbman/qman.c | 4 ++-- drivers/net/fm10k/fm10k_ethdev.c | 4 ++-- lib/eal/include/generic/rte_spinlock.h | 14

[PATCH v2 3/3] eal: enhance lock annotations for rwlock

2024-12-12 Thread David Marchand
Convert rwlock to the clang capability annotations. Signed-off-by: David Marchand --- lib/eal/common/eal_memalloc.h| 2 +- lib/eal/common/eal_private.h | 2 +- lib/eal/include/generic/rte_rwlock.h | 23 ++-- lib/eal/include/rte_eal_memconfig.h | 24 ++-- lib/ethdev/ethdev_

[PATCH v2 1/3] eal: add enhanced lock annotations

2024-12-12 Thread David Marchand
Clang 3.6+ offers enhanced lock annotations when it comes to shared vs exclusive capability/lock release. Introduce macros for those new function attributes. Signed-off-by: David Marchand --- Changes since RFC: - fixed build with clang < 11, --- doc/api/doxy-api.conf.in | 12 +

[PATCH v2 0/3] Improve lock annotations

2024-12-12 Thread David Marchand
A recent bug (see 22aa9a9c7099 ("vhost: fix deadlock in Rx async path")) made more visible a gap in the clang thread safety annotations that DPDK uses: no distinction is made between releasing a read lock and releasing a write lock. Clang 3.6 and later offers improved thread safety checks. Markin

[PATCH] net/ena: fix missing default llq policy

2024-12-12 Thread shaibran
From: Shai Brandes The driver failed to set a default llq_header_policy, causing LLQ to be disabled when the devarg value is not specified by the application. Fixes: d7918d19d25e ("net/ena: restructure LLQ policy user setting") Cc: sta...@dpdk.org Signed-off-by: Yosef Raisman Signed-off-by: Sha

[PATCH v2 2/7] dts: enable Ruff preview pydoclint rules

2024-12-12 Thread Luca Vizzarro
DTS requires a linter for docstrings but the current selection is limited. The most promising docstring linter is pydoclint. On the other hand, Ruff is currently in the process of implementing pydoclint rules. This would spare the project from supporting yet another linter, without any loss of bene

[PATCH v2 7/7] dts: update linters in doc page

2024-12-12 Thread Luca Vizzarro
Ruff has now superseded all the previous linters and formatters. Update DTS doc page accordingly. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- doc/guides/tools/dts.rst | 26 +++--- 1 file changed, 7 insertions(+), 19 deletions(-) diff --git a/doc/guides/too

[PATCH v2 6/7] dts: remove old linters and formatters

2024-12-12 Thread Luca Vizzarro
Since the addition of Ruff, all the previously used linters and formatters are no longer used, therefore remove. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- dts/poetry.lock| 170 + dts/pyproject.toml | 24 --- 2 files change

[PATCH v2 4/7] dts: apply Ruff formatting

2024-12-12 Thread Luca Vizzarro
While Ruff formatting is Black-compatible and is near-identical, it still requires formatting for a small set of elements. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- dts/framework/params/eal.py | 5 +- dts/framework/remote_session/dpdk_shell.py| 1 - d

[PATCH v2 5/7] dts: update dts-check-format to use Ruff

2024-12-12 Thread Luca Vizzarro
Replace the current linters and formatter in favour of Ruff in the dts-check-format tool. Bugzilla ID: 1358 Bugzilla ID: 1455 Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- devtools/dts-check-format.sh | 30 +++--- 1 file changed, 15 insertions(+), 15 del

[PATCH v2 3/7] dts: resolve docstring linter errors

2024-12-12 Thread Luca Vizzarro
The addition of Ruff pydocstyle and pydoclint rules has raised new problems in the docstrings which require to be fixed. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- .../single_active_interactive_shell.py| 11 +++- dts/framework/runner.py | 48

[PATCH v2 1/7] dts: add Ruff as linter and formatter

2024-12-12 Thread Luca Vizzarro
To improve and streamline the development process, Ruff presents itself as a very fast all-in-one linter that is able to apply fixes and formatter compatible with Black. Ruff implements all the rules that DTS currently use and expands on them, leaving space to easily enable more checks in the futur

[PATCH v2 2/2] dts: add port restart configuration persistency test

2024-12-12 Thread Thomas Wilks
Added test that sets various port settings and verifies that they persist after a port restart. Signed-off-by: Thomas Wilks Reviewed-by: Paul Szczepanek --- ...stSuite_port_restart_config_persistency.py | 101 ++ 1 file changed, 101 insertions(+) create mode 100644 dts/tests/Te

[PATCH v2 1/2] dts: add new testpmd shell functions

2024-12-12 Thread Thomas Wilks
Add support for setting Mac address, set flow control in the testpmd shell. Signed-off-by: Thomas Wilks Reviewed-by: Paul Szczepanek --- dts/framework/remote_session/testpmd_shell.py | 126 ++ 1 file changed, 126 insertions(+) diff --git a/dts/framework/remote_session/testpmd_s

[PATCH v2 0/2] dts: Add port restart configuration persistency testsuite

2024-12-12 Thread Thomas Wilks
v2: - Removed Vf check - Fixed spelling - Fixed Docstrings - Added verification to testpmd commands - Extracted flow control parameters into a dataclass - Fixed syntax in testsuite Thomas Wilks (2): dts: add new testpmd shell functions dts: add port restart configuration persistency test dts

Re: [PATCH v2] net/mlx5: fix hypervisor detection in VLAN workaround

2024-12-12 Thread Thomas Monjalon
06/12/2024 15:26, Viacheslav Ovsiienko: > The mlx5 PMD provides a specific workaround for the VMware ESXi > hypervisor, enabling on-demand routing configuration to virtual > machines. This workaround activates when the device type is > a Virtual Function and either an ESXi hypervisor is detected >

[PATCH] net/af_packet: allow disabling packet fanout

2024-12-12 Thread Tudor Cornea
This allows us to control whether the PMD will attempt to use the PACKET_FANOUT socket option, and allows the binary compiled against newer kernel headers to run on an older kernel, which lacks support for it. Signed-off-by: Tudor Cornea --- doc/guides/nics/af_packet.rst | 4 ++- dr