[PATCH v2] net/mlx5: fix flow create failure with GENEVE options match

2025-03-03 Thread Maayan Kashani
For non template API on top of HWS, geneve options were missing a parser and therefore it failed. In template API it geneve options is configured by the user using mlx5 set/apply tlv_options commands. To support hybrid mode, if no parser exists, added inner configuration of geneve parser, else, in

Re: [PATCH v3] lib/fib: remove warning about implicit 64-bit conversion

2025-03-03 Thread Stephen Hemminger
Better to cast the constant (1) to avoid warning, . That is what other code does like RTE_BIT macros On Mon, Mar 3, 2025, 23:55 Andre Muezerie wrote: > MSVC issues the warning below: > > ../lib/fib/trie.c(341): warning C4334: '<<': > result of 32-bit shift implicitly converted to 64 bits > (was

RE: [PATCH 2/2] net/mlx5: improve log file path

2025-03-03 Thread Bing Zhao
Hi Ming, > -Original Message- > From: Yang Ming > Sent: Friday, December 13, 2024 5:25 PM > To: Dariusz Sosnowski ; Slava Ovsiienko > ; Bing Zhao ; Ori Kam > ; Suanming Mou ; Matan Azrad > > Cc: dev@dpdk.org; Yang Ming > Subject: [PATCH 2/2] net/mlx5: improve log file path > > External

[PATCH] common/cnxk: add flag for enabling opaque mode

2025-03-03 Thread Nawal Kishor
Added flag that overrides the default natural alignment mode and uses opaque mode. Signed-off-by: Nawal Kishor --- drivers/common/cnxk/roc_npa.c | 3 +++ drivers/common/cnxk/roc_npa.h | 3 ++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/common/cnxk/roc_npa.c b/drivers/c

[PATCH] common/cnxk: fix aura offset

2025-03-03 Thread Nawal Kishor
Fix aura offset in NPA_LF_POOL_OP_INT. Fixes: 620fc02bf7eb ("common/cnxk: accommodate change in aura field width") Signed-off-by: Nawal Kishor --- drivers/common/cnxk/roc_npa_irq.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/common/cnxk/roc_npa_irq.c b/dr

Re: [PATCH] drivers/common: avoid truncation of constant value

2025-03-03 Thread Andre Muezerie
On Wed, Dec 18, 2024 at 08:05:12AM -0800, Andre Muezerie wrote: > This issue was flagged by MSVC warning below: > > drivers\common\idpf\base/virtchnl2.h(269): warning C4309: > 'initializing': truncation of constant value > > The problem is that 64-bit numbers are initialized in an enum. > >

Re: [PATCH] dmadev: enable lib to be compiled with MSVC

2025-03-03 Thread fengchengwen
Acked-by: Chengwen Feng Thanks On 2025/3/4 9:55, Andre Muezerie wrote: > With the outstanding issues preventing dmadev from being compiled > with MSVC being fixed, the lib can be enabled to be compiled with MSVC. > > Signed-off-by: Andre Muezerie > --- > lib/dmadev/meson.build | 6 -- > 1

[PATCH] dmadev: enable lib to be compiled with MSVC

2025-03-03 Thread Andre Muezerie
With the outstanding issues preventing dmadev from being compiled with MSVC being fixed, the lib can be enabled to be compiled with MSVC. Signed-off-by: Andre Muezerie --- lib/dmadev/meson.build | 6 -- 1 file changed, 6 deletions(-) diff --git a/lib/dmadev/meson.build b/lib/dmadev/meson.bu

[PATCH v3] lib/fib: remove warning about implicit 64-bit conversion

2025-03-03 Thread Andre Muezerie
MSVC issues the warning below: ../lib/fib/trie.c(341): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?) The fix is to cast the result explicitly to uintptr_t since it is used in pointer arithmetic. Signed-off-by: Andre Muezerie --- lib/fi

Re: [PATCH 2/2] app/test: add test_init_m128i using compiler intrinsic

2025-03-03 Thread Andre Muezerie
On Wed, Nov 27, 2024 at 02:57:58PM -0800, Andre Muezerie wrote: > This test initializes an __m128i data type using the old > non-portable way used until now and the more portable way > using compiler intrinsics. The test ensures the resulting > values after initialization match. > > Signed-off-by:

Re: [PATCH 1/2] lib/hash: initialize __m128i data type in a portable way

2025-03-03 Thread Andre Muezerie
On Wed, Nov 27, 2024 at 02:57:57PM -0800, Andre Muezerie wrote: > The mechanism used to initialize an __m128i data type in rte_thash.h is > non-portable and MSVC does not like it. It clearly is not doing what > is desired: > > ..\lib\hash\rte_thash.h(38): warning C4305: 'initializing': > trunc

Re: Segfault in rcu

2025-03-03 Thread Andre Muezerie
On Sat, Mar 01, 2025 at 10:35:48PM +0300, Dmitry Kozlyuk wrote: > Hi Andre, > > > @@ -386,7 +386,7 @@ rte_rcu_qsbr_dq_reclaim(struct rte_rcu_qsbr_dq *dq, > > unsigned int n, > > > > cnt = 0; > > > > -char data[dq->esize]; > > +char *data = alloca(dq->esize); > > /* Check reader

Re: [PATCH] member: use common top-level variable for easier maintenance

2025-03-03 Thread Andre Muezerie
On Mon, Mar 03, 2025 at 03:21:40PM +, Bruce Richardson wrote: > On Fri, Feb 28, 2025 at 11:01:01AM -0800, Andre Muezerie wrote: > > Updated meson.build to use common variable cc_avx512_flags for > > msvc and avoiding code duplication for other compilers. > > > > Signed-off-by: Andre Muezerie

[PATCH v2] member: use common top-level variable for easier maintenance

2025-03-03 Thread Andre Muezerie
Updated meson.build to use common variable cc_avx512_flags for msvc and avoiding code duplication for other compilers. Signed-off-by: Andre Muezerie --- lib/member/meson.build | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/lib/member/meson.build b/lib/member/meson

Re: [PATCH] acl: use common top-level variable for easier maintenance

2025-03-03 Thread Andre Muezerie
On Mon, Mar 03, 2025 at 03:19:49PM +, Bruce Richardson wrote: > On Fri, Feb 28, 2025 at 10:45:56AM -0800, Andre Muezerie wrote: > > Updated meson.build to use common variable cc_avx512_flags. > > > > Signed-off-by: Andre Muezerie > > --- > > config/x86/meson.build | 2 +- > > lib/acl/meson.b

[PATCH v2] acl: use common top-level variable for easier maintenance

2025-03-03 Thread Andre Muezerie
Updated meson.build to use common variables cc_has_avx512 and cc_avx512_flags. Signed-off-by: Andre Muezerie Acked-by: Bruce Richardson --- config/x86/meson.build | 2 +- lib/acl/meson.build| 8 ++-- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/config/x86/meson.build b

Re: MPLS Push action

2025-03-03 Thread Thomas Monjalon
Hi, This is the related code: /** * RTE_FLOW_ACTION_TYPE_OF_PUSH_MPLS * * Implements OFPAT_PUSH_MPLS ("push a new MPLS tag") as defined by the * OpenFlow Switch Specification. */ struct rte_flow_action_of_push_mpls { rte_be16_t ethertype; /**< EtherType. */ }; > On Mon, Mar 3, 2025 at

Re: MPLS Push action

2025-03-03 Thread Ajit Khaparde
+Thomas Monjalon On Mon, Mar 3, 2025 at 8:02 AM Kishore Padmanabha wrote: > > Hi, > > > > Anyone has any inputs on this. Or should I add new CLI commands in testpmd to > support action for push MPLS tag. > > > > Thanks, > > Kishore > > > > > > From: Kishore Padmanabha > Sent: Thursday, February

[PATCH] net/mlx5: add GRE as L4 layer for entropy calculation

2025-03-03 Thread Yaniv Rosner
Signed-off-by: Yaniv Rosner Acked-by: Bing Zhao --- drivers/net/mlx5/mlx5_flow_hw.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c index e72b87d70f..27ee9d6cd3 100644 --- a/drivers/net/mlx5/mlx5_flow_hw.c +++ b/drivers/net

RE: MPLS Push action

2025-03-03 Thread Kishore Padmanabha
Hi, Anyone has any inputs on this. Or should I add new CLI commands in testpmd to support action for push MPLS tag. Thanks, Kishore *From:* Kishore Padmanabha *Sent:* Thursday, February 27, 2025 6:35 PM *To:* 'dev@dpdk.org' *Subject:* MPLS Push action Hi, When MPLS push action i

Re: [PATCH] member: use common top-level variable for easier maintenance

2025-03-03 Thread Bruce Richardson
On Fri, Feb 28, 2025 at 11:01:01AM -0800, Andre Muezerie wrote: > Updated meson.build to use common variable cc_avx512_flags for > msvc and avoiding code duplication for other compilers. > > Signed-off-by: Andre Muezerie > --- > lib/member/meson.build | 11 --- > 1 file changed, 8 insert

Re: [PATCH] acl: use common top-level variable for easier maintenance

2025-03-03 Thread Bruce Richardson
On Fri, Feb 28, 2025 at 10:45:56AM -0800, Andre Muezerie wrote: > Updated meson.build to use common variable cc_avx512_flags. > > Signed-off-by: Andre Muezerie > --- > config/x86/meson.build | 2 +- > lib/acl/meson.build| 8 ++-- > 2 files changed, 3 insertions(+), 7 deletions(-) > One

[PATCH v4 7/7] dts: improve configuration errors

2025-03-03 Thread Luca Vizzarro
From: Luca Vizzarro Improve the way that configuration errors are displayed to the user. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- dts/framework/config/__init__.py | 4 ++-- dts/framework/config/test_run.py | 2 +- dts/framework/runner.py | 14 +- 3

[PATCH v4 6/7] dts: add per-test-suite configuration

2025-03-03 Thread Luca Vizzarro
From: Luca Vizzarro Allow test suites to be configured individually. Moreover enable them to implement their own custom configuration. Adds a new argument to the command line which enables the user to supply a YAML file to configure all of the requested test suites. This argument becomes mandato

[PATCH v4 5/7] dts: run only one test run per execution

2025-03-03 Thread Luca Vizzarro
From: Luca Vizzarro To aid configurability and flexibility both for the user and the developer, make DTS run only one test run per execution. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- doc/guides/tools/dts.rst | 18 dts/.gitignore | 2 +-

[PATCH v4 3/7] dts: fix smoke tests docstring

2025-03-03 Thread Luca Vizzarro
From: Luca Vizzarro Sphinx autodoc complains of is_blocking being duplicated. This is the case as the parent already holds a docstring for this attribute. Remove the duplication. Fixes: 6ef07151aac4 ("dts: update docstrings") Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- dts/

[PATCH v4 1/7] dts: add tests package to API docs

2025-03-03 Thread Luca Vizzarro
From: Luca Vizzarro The test suites are not documented in the API as their respective documentation files are missing. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- doc/api/dts/index.rst | 1 + doc/api/dts/tests.TestSuite_blocklist.rst

[PATCH v4 4/7] dts: update autodoc sorting order

2025-03-03 Thread Luca Vizzarro
From: Luca Vizzarro The autodoc member sorting order default is set to alphabetical, which translates to autodoc sorting every member in modules, classes etc. This also brings some side effects, like sorting capabilities which can't be compared and result in errors. This change prevents autodoc

[PATCH v4 2/7] dts: amend test suites docstring

2025-03-03 Thread Luca Vizzarro
From: Luca Vizzarro Amend the test suites docstring to conform to valid rst. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- dts/tests/TestSuite_dynamic_config.py | 10 +-- dts/tests/TestSuite_mac_filter.py | 42 +- dts/tests/TestSuite_mtu.py| 114 +

[PATCH v4 0/7] dts: add per-test-suite configuration

2025-03-03 Thread Luca Vizzarro
From: Luca Vizzarro Hi there, sending in v4 for the per-test-suite configuration patchset. v4: - rebased - Changed implementation: - test suites configurations are now provided through a dedicated optional configuration file. - running multiple test runs hinders flexibility in loading

[PATCH] net/mlx5: fix using wrong group ID for action translation

2025-03-03 Thread Maayan Kashani
From: Bing Zhao In HWS non-template API, the actual group ID is calculated in the flow_hw_translate_flow_actions(). This would be set into the dummy template table for the following usage. Since __flow_hw_translate_actions_template() is also called for the dummy action template and some fixed ac

[PATCH 1/2] net/mlx5: fix non template flow validation on validate

2025-03-03 Thread Maayan Kashani
For non template API on top of HWS, it’s validation function pointed to SWS legacy validation function, which does not match HWS restrictions. Added HWS validation function for non template rules. Fixes: e38776c36c8a ("net/mlx5: introduce HWS for non-template flow API") Cc: sta...@dpdk.org Signe

[PATCH 2/2] net/mlx5: fix non template flow validation on create

2025-03-03 Thread Maayan Kashani
Currently, a non template rule on top of HWS can be created successfully although validation fails. Added in flow creation, the rule validation, And deduce the items flags from the validation items loop. Fixes: 0989f6808401 ("net/mlx5: update NTA rule pattern and actions flags") Cc: sta...@dpdk.o

[PATCH] net/mlx5: fix flow create failure with GENEVE options match

2025-03-03 Thread Maayan Kashani
For non template API on top of HWS, geneve options were missing a parser and therefor it failed. In template API it geneve options is configured by the user using mlx5 set/apply tlv_options commands. To support hybrid mode, if no parser exists, added inner configuration of geneve parser, else, in

Re: [EXTERNAL] Re: [PATCH v2] net/virtio: add virtio hash report feature

2025-03-03 Thread Maxime Coquelin
On 2/27/25 10:44 AM, Shiva Shankar Kommula wrote: -Original Message- From: Maxime Coquelin Sent: Tuesday, February 25, 2025 9:39 PM To: Shiva Shankar Kommula ; dev@dpdk.org; chen...@nvidia.com Cc: david.march...@redhat.com; Jerin Jacob ; Nithin Kumar Dabilpuram ; Srujana Challa Subje

Re: [v9 6/6] examples/vhost_crypto: support asymmetric crypto

2025-03-03 Thread Maxime Coquelin
On 2/28/25 2:47 PM, Gowrishankar Muthukrishnan wrote: Support asymmetric crypto operations. Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Akhil Goyal --- doc/guides/sample_app_ug/vhost_crypto.rst | 5 +++ examples/vhost_crypto/main.c | 50 +-- 2 f

Re: [v9 5/6] vhost: support asymmetric RSA crypto ops

2025-03-03 Thread Maxime Coquelin
On 2/28/25 2:47 PM, Gowrishankar Muthukrishnan wrote: Support asymmetric RSA crypto operations in vhost-user. Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Akhil Goyal --- doc/guides/rel_notes/release_25_03.rst | 3 + lib/vhost/vhost_crypto.c | 484 +

Re: [v9 4/6] examples/vhost_crypto: fix user callbacks

2025-03-03 Thread Maxime Coquelin
On 2/28/25 2:47 PM, Gowrishankar Muthukrishnan wrote: In order to handle new vhost user connection, use new_connection and destroy_connection callbacks. Fixes: f5188211c721 ("examples/vhost_crypto: add sample application") Cc: sta...@dpdk.org Signed-off-by: Gowrishankar Muthukrishnan Acked-

Re: [v9 3/6] vhost: update vhost_user crypto session parameters

2025-03-03 Thread Maxime Coquelin
On 2/28/25 2:47 PM, Gowrishankar Muthukrishnan wrote: As per requirements on vhost_user spec, session id should be located at the end of session parameter. Update VhostUserCryptoSessionParam structure to support newer QEMU versions (v9). Due to additional parameters added in QEMU, received pa

Re: [v9 2/6] vhost: skip crypto op fetch before vring init

2025-03-03 Thread Maxime Coquelin
On 2/28/25 2:47 PM, Gowrishankar Muthukrishnan wrote: Until virtio avail ring is initialized (by VHOST_USER_SET_VRING_ADDR), worker thread should not try to fetch crypto op, which would lead to memory fault. Fixes: 939066d96563 ("vhost/crypto: add public function implementation") Cc: sta...@d

Re: [v9 1/6] vhost: fix thread safety checks for vhost crypto data req

2025-03-03 Thread Maxime Coquelin
On 2/28/25 2:47 PM, Gowrishankar Muthukrishnan wrote: For thread safety check to succeed (as in clang), calling function should ensure vq->iotlb_lock locked before passing vq to a function that has thread safety attribute, in vhost crypto implementation. When vhost_crypto_data_req is local an

RE: [PATCH v4 0/4] Introduce Topology NUMA grouping for lcores

2025-03-03 Thread Varghese, Vipin
[Public] Hi Morten, snipped > > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > Sent: Thursday, 13 February 2025 09.34 > > > > 13/02/2025 04:09, Varghese, Vipin: > > > [AMD Official Use Only - AMD Internal Distribution Only] > > > > > > Adding Thomas and Ajit to the loop. > > > > > >

RE: [PATCH v4 0/4] Introduce Topology NUMA grouping for lcores

2025-03-03 Thread Varghese, Vipin
[Public] Hi Thomas snipped > > > > Thomas and Ajith can we get some help to get this mainline too? > > Yes, sorry the review discussions did not start. > It has been forgotten. > > You could rebase a v2 to make it more visible. Sure will do this week. > > Minor note: the changelog should be aft

[PATCH v2 2/9] crypto/zsda: add device operations

2025-03-03 Thread Hanxiao Li
Add crypto device operations for zsda devices. Signed-off-by: Hanxiao Li --- drivers/crypto/zsda/zsda_sym_pmd.c | 94 -- 1 file changed, 89 insertions(+), 5 deletions(-) diff --git a/drivers/crypto/zsda/zsda_sym_pmd.c b/drivers/crypto/zsda/zsda_sym_pmd.c index 0f4bf

[PATCH v2 7/9] crypto/zsda: add dequeue datapath

2025-03-03 Thread Hanxiao Li
Add crypto dequeue datapath configuration for zsda device. Signed-off-by: Hanxiao Li --- drivers/crypto/zsda/zsda_sym.c | 16 drivers/crypto/zsda/zsda_sym.h | 2 ++ drivers/crypto/zsda/zsda_sym_pmd.c | 12 ++-- 3 files changed, 28 insertions(+), 2 deletions(-)

[PATCH v2 0/9] crypto/zsda: add zsda cryptodev driver

2025-03-03 Thread Hanxiao Li
v2: - Modify the errors about cryptodevs/zsda.rst. - Modify the errors about author. v1: - Add zsda cryptodev driver. Hanxiao Li (9): crypto/zsda: add skeleton crypto/zsda: add device operations crypto/zsda: add statistics crypto/zsda: add queue pair configuration crypto/zsda: add ses

[PATCH v2 6/9] crypto/zsda: add enqueue datapath

2025-03-03 Thread Hanxiao Li
Add crypto enqueue datapath configuration for zsda device. Signed-off-by: Hanxiao Li --- drivers/common/zsda/meson.build| 2 +- drivers/crypto/zsda/zsda_sym.c | 256 + drivers/crypto/zsda/zsda_sym.h | 45 + drivers/crypto/zsda/zsda_sym_pmd.c | 23 +

[PATCH v2 9/9] app/test: add zsda cryptodev test

2025-03-03 Thread Hanxiao Li
Add crypto test for zsda device and driver. Signed-off-by: Hanxiao Li --- app/test/test_cryptodev.c| 7 +++ app/test/test_cryptodev.h| 1 + doc/guides/compressdevs/zsda.rst | 6 ++ 3 files changed, 14 insertions(+) diff --git a/app/test/test_cryptodev.c b/app/test/test_c

[PATCH v2 5/9] crypto/zsda: add session configuration

2025-03-03 Thread Hanxiao Li
Add crypto session configuration for zsda device. Signed-off-by: Hanxiao Li --- drivers/common/zsda/meson.build| 2 +- drivers/crypto/zsda/zsda_sym_pmd.c | 42 ++- drivers/crypto/zsda/zsda_sym_session.c | 498 + drivers/crypto/zsda/zsda_sym_session.h | 81

[PATCH v2 3/9] crypto/zsda: add statistics

2025-03-03 Thread Hanxiao Li
Add crypto statistics operations for zsda devices. Signed-off-by: Hanxiao Li --- drivers/crypto/zsda/zsda_sym_pmd.c | 23 +-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/zsda/zsda_sym_pmd.c b/drivers/crypto/zsda/zsda_sym_pmd.c index 22c8d482

[PATCH v2 8/9] crypto/zsda: add capabilities

2025-03-03 Thread Hanxiao Li
Add crypto capabilities scope for zsda device. Signed-off-by: Hanxiao Li --- doc/guides/cryptodevs/features/zsda.ini | 19 +++- doc/guides/cryptodevs/zsda.rst | 24 + doc/guides/rel_notes/release_25_03.rst | 5 + drivers/crypto/zsda/zsda_sym_capabilities.h | 111 +++

[PATCH v2 4/9] crypto/zsda: add queue pair configuration

2025-03-03 Thread Hanxiao Li
Add crypto queue pair configuration operations for zsda device. Signed-off-by: Hanxiao Li --- drivers/crypto/zsda/zsda_sym_pmd.c | 68 +- 1 file changed, 66 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/zsda/zsda_sym_pmd.c b/drivers/crypto/zsda/zsda_sym_

[PATCH v2 1/9] crypto/zsda: add skeleton

2025-03-03 Thread Hanxiao Li
Add crypto driver skeleton for zsda devices. Signed-off-by: Hanxiao Li --- MAINTAINERS | 6 ++ doc/guides/compressdevs/zsda.rst| 9 ++ doc/guides/cryptodevs/features/zsda.ini | 38 doc/guides/cryptodevs/index.rst | 1 + doc/guides/crypt