release candidate 25.03-rc3

2025-03-18 Thread Thomas Monjalon
A new DPDK release candidate is ready for testing: https://git.dpdk.org/dpdk/tag/?id=v25.03-rc3 There are 71 new patches in this snapshot. Release notes: https://doc.dpdk.org/guides/rel_notes/release_25_03.html Please test and report new issues on https://bugs.dpdk.org If no maj

Re: [PATCH] doc/dmadevs: clarify naming constraints for idxd devices

2025-03-18 Thread Thomas Monjalon
18/02/2025 16:44, Kevin Laatz: > On 31/01/2025 14:49, Bruce Richardson wrote: > > The requirement to have DPDK in the DSA wq name is given in the idxd > > chapter section 5.3.3 [1]. However, that information should also be > > given in section 5.3.1 [2] where we list out the fields to be set and >

Re: [PATCH v1 1/1] usertools/devbind: add documentation for no-IOMMU mode

2025-03-18 Thread Thomas Monjalon
18/02/2025 10:46, Bruce Richardson: > On Mon, Dec 02, 2024 at 09:35:01AM +, Anatoly Burakov wrote: > > Support for `--noiommu-mode` flag was added, but documentation for it was > > not. Add documentation for the flag. > > > > Signed-off-by: Anatoly Burakov > > Acked-by: Bruce Richardson Ap

Re: [PATCH v4 1/1] usertools/devbind: allow changing UID/GID for VFIO

2025-03-18 Thread Thomas Monjalon
02/12/2024 10:35, Burakov, Anatoly: > On 12/2/2024 10:31 AM, Anatoly Burakov wrote: > > Currently, when binding a device to VFIO, the UID/GID for the device will > > always stay as system default (`root`). Yet, when running DPDK as non-root > > user, one has to change the UID/GID of the device to m

Re: [PATCH] examples/ipsec-secgw: fix cryptodev and eventdev ID

2025-03-18 Thread Thomas Monjalon
23/01/2025 11:27, Anoob Joseph: > > Subject: [PATCH] examples/ipsec-secgw: fix cryptodev and eventdev ID > > > > Fixing cryptodev and eventdev ID numbers. > > > > Fixes: 0dbe550a4af5 ("examples/ipsec-secgw: initialize event crypto > > adapter") > > Cc: sta...@dpdk.org > > > > Signed-off-by: Tej

Re: [PATCH] examples/flow_filtering: fix destination IP mask

2025-03-18 Thread Thomas Monjalon
10/03/2025 07:48, Shani Peretz: > From: Thomas Monjalon > > 12/01/2025 08:52, Shani Peretz: > > > This patch corrects the destination IP address mask to restore the > > > previous implementation's behavior. > > > > > > Also it fixes a misuse of rte_flow_item_tcp struct. > > > Replace it with the a

Re: [PATCH] pdump: clear statistics when enabled

2025-03-18 Thread Thomas Monjalon
20/12/2024 00:58, Stephen Hemminger: > The pdump statistics are used to keep track of the number > of packets captured, filtered, etc. These need not be cumalative > and instead should be start counting when capture starts. > > This fixes the issue where multiple invocations of dumpcap > would inc

Re: [PATCH v3] app/test: fix stack overflow in lpm6_perf_autotest

2025-03-18 Thread Thomas Monjalon
05/03/2025 21:04, Medvedkin, Vladimir: > On 05/03/2025 14:45, Andre Muezerie wrote: > > On Wed, Mar 05, 2025 at 10:08:33AM +, Bruce Richardson wrote: > >> On Wed, Dec 18, 2024 at 07:21:26AM -0800, Andre Muezerie wrote: > >>> Test lpm6_perf_autotest was hitting a stack overflow on Windows > >>>

Re: [PATCH] config/arm: fix march features not being set

2025-03-18 Thread Thomas Monjalon
> > From: Pavan Nikhilesh > > > > Fix extra_march_features not being added to mcpu flags when SoC > > configuration advertises them. > > > > Fixes: c02c01dbf907 ("config/arm: prefer strict use of -mcpu if supported") > > Acked-by: Jerin Jacob Applied, thanks.

Re: [PATCH] config/arm: add crypto to cn9k soc

2025-03-18 Thread Thomas Monjalon
08/03/2025 10:01, pbhagavat...@marvell.com: > From: Pavan Nikhilesh > > Add crypto as extra march feature to cn9k soc. > > Signed-off-by: Pavan Nikhilesh Applied, thanks.

[PATCH v3 02/11] net/intel: use common AVX build code

2025-03-18 Thread Bruce Richardson
Remove driver-specific build instructions for the AVX2 and AVX-512 code, and rely instead on the generic driver build file. Signed-off-by: Bruce Richardson --- drivers/net/intel/i40e/meson.build | 26 ++ drivers/net/intel/iavf/meson.build | 25 ++--- d

[PATCH v3 03/11] drivers/net: build use common AVX handling

2025-03-18 Thread Bruce Richardson
Remove from remaining net drivers the special-case code to handle AVX2 or AVX512 specific files. These can be built instead using drivers/meson.build. Signed-off-by: Bruce Richardson --- drivers/net/bnxt/meson.build | 10 +- drivers/net/enic/meson.build | 10 +- drivers

[PATCH v3 01/11] build: add generalized AVX handling for drivers

2025-03-18 Thread Bruce Richardson
Add support to the top-level driver build file for AVX2 and AVX512 specific sources. This should simplify driver builds by avoiding the need to constantly reimplement the same build logic Signed-off-by: Bruce Richardson --- drivers/meson.build | 30 ++ 1 file changed,

[PATCH v3 09/11] net: simplify build-time logic for x86

2025-03-18 Thread Bruce Richardson
All DPDK-supported versions of clang and gcc have the "-mpclmul" and "-maes" flags, so we never need to check for those. This allows the SSE code path to be unconditionally built on x86. For the AVX512 code path, simplify it by only checking for the build-time support, and always doing a separate

[PATCH v3 04/11] drivers/net: remove AVX2 build-time define

2025-03-18 Thread Bruce Richardson
Since all supported compilers can generate AVX2 code, we will always enable the build of the AVX2 files on x86. This means that CC_AVX2_SUPPORT is always true on x86, so it can be removed and a regular "#ifdef RTE_ARCH_x86" used in its place. Signed-off-by: Bruce Richardson --- drivers/net/bnxt/

[PATCH v3 08/11] fib: use common AVX build handling

2025-03-18 Thread Bruce Richardson
Remove custom logic for building AVX2 and AVX-512 files. Within the C code this requires some renaming of build macros to use the standard defines. Signed-off-by: Bruce Richardson --- lib/fib/dir24_8.c | 6 +++--- lib/fib/meson.build | 18 +- lib/fib/trie.c | 6 +++--- 3

Re: [PATCH v3 04/11] drivers/net: remove AVX2 build-time define

2025-03-18 Thread Ajit Khaparde
On Tue, Mar 18, 2025 at 10:35 AM Bruce Richardson wrote: > > Since all supported compilers can generate AVX2 code, we will always > enable the build of the AVX2 files on x86. This means that > CC_AVX2_SUPPORT is always true on x86, so it can be removed and a > regular "#ifdef RTE_ARCH_x86" used in

Re: [PATCH v2] eal: fix undetected NUMA nodes

2025-03-18 Thread Bruce Richardson
On Wed, Mar 05, 2025 at 04:24:58PM +, Bruce Richardson wrote: > In cases where the number of cores on a given socket is greater than > RTE_MAX_LCORES, then EAL will be unaware of all the sockets/numa nodes > on a system. Fix this limitation by having the EAL probe the NUMA node > for cores it i

[PATCH] dts: add Scapy asynchronous sniffer

2025-03-18 Thread Luca Vizzarro
Currently packet capturing in Scapy is used by running Scapy's own class AsyncSniffer in the same shell as packet sending. Because there is some start up time involved in the AsyncSniffer, doing this every single time a test case requires it can become slow and unreliable if sniffer was not ready y

[PATCH v3 11/11] member: use common AVX512 build support

2025-03-18 Thread Bruce Richardson
Use the support for building AVX512 code present in lib/meson.build rather than reimplementing it in the library meson.build file. Signed-off-by: Bruce Richardson --- lib/member/meson.build | 46 +++--- 1 file changed, 7 insertions(+), 39 deletions(-) diff --

[PATCH v3 10/11] net: use common AVX512 build code

2025-03-18 Thread Bruce Richardson
Use the common support for AVX512 code present in lib/meson.build, rather than hard-coding it. The only complication is an extra check for the "-mvpclmulqdq" command-line flag before adding the AVX512 sources. Signed-off-by: Bruce Richardson --- lib/net/meson.build | 13 - lib/net/

[PATCH v3 07/11] acl: use common AVX build handling

2025-03-18 Thread Bruce Richardson
remove custom logic for building AVX2 and AVX-512 files. Signed-off-by: Bruce Richardson --- lib/acl/meson.build | 54 - 1 file changed, 4 insertions(+), 50 deletions(-) diff --git a/lib/acl/meson.build b/lib/acl/meson.build index a80c172812..87e9f25f

[PATCH v3 06/11] build: add generalized AVX handling for libs

2025-03-18 Thread Bruce Richardson
Add support to the top-level lib build file for AVX2 and AVX512 specific sources. This should simplify library builds by avoiding the need to constantly reimplement the same build logic Signed-off-by: Bruce Richardson --- lib/meson.build | 34 +- 1 file changed, 3

[PATCH v3 05/11] event/dlb2: build using common AVX handling

2025-03-18 Thread Bruce Richardson
remove special-case handling for AVX512, and rely on mechanisms in the drivers meson.build file. Signed-off-by: Bruce Richardson --- drivers/event/dlb2/dlb2_sse.c | 4 drivers/event/dlb2/meson.build | 16 ++-- 2 files changed, 6 insertions(+), 14 deletions(-) diff --git a/dri

[PATCH v3 00/11] remove component-specific logic for AVX builds

2025-03-18 Thread Bruce Richardson
A number of libs and drivers had special optimized AVX2 and AVX512 code paths for performance reasons, and these tended to have copy-pasted logic to build those files. Centralise that logic in the main drivers/ and lib/ meson.build files to avoid duplication. v3: add patch for event/dlb2 AVX512 ha

Re: [PATCH 1/2] common/mlx5: add device duplication function

2025-03-18 Thread Raslan Darawsheh
Hi, From: Gregory Etelson Sent: Thursday, March 13, 2025 10:33 AM To: dev@dpdk.org Cc: Gregory Etelson; Maayan Kashani; Raslan Darawsheh; Michael Baum; Dariusz Sosnowski; Slava Ovsiienko; Bing Zhao; Ori Kam; Suanming Mou; Matan Azrad Subject: [PATCH 1/2] common/mlx5: add device duplication funct

DPDK Release Status Meeting 2025-03-18

2025-03-18 Thread Mcnamara, John
Release status meeting minutes 2025-03-18 = Agenda: * Release Dates * Subtrees * Roadmaps * LTS * Defects * Opens Participants: * Broadcom * ARM * Intel * Marvell * Nvidia * Red Hat Release Dates - The following are the proposed working dates

Re: [PATCH 1/2] net/iavf: fix missing check for interrupt errors

2025-03-18 Thread Bruce Richardson
On Tue, Mar 18, 2025 at 12:35:01PM +, Medvedkin, Vladimir wrote: > Acked-by: Vladimir Medvedkin > > On 10/03/2025 13:11, Bruce Richardson wrote: > > When registering interrupts, there was no check if the registration of > > the interrupt succeeded. Add in such a check, and go to fallback path

RE: [PATCH] config/arm: fix march features not being set

2025-03-18 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Pavan Nikhilesh Bhagavatula > Sent: Thursday, March 13, 2025 10:13 AM > To: Wathsala Wathawana Vithanage ; Jerin > Jacob ; Bruce Richardson > Cc: dev@dpdk.org; nd > Subject: RE: [PATCH] config/arm: fix march features not being set > > > Hi Pavan, > > > > I

Re: [PATCH 2/2] net/iavf: fix crash on app exit on FreeBSD

2025-03-18 Thread Medvedkin, Vladimir
Acked-by: Vladimir Medvedkin On 10/03/2025 13:11, Bruce Richardson wrote: With the fallback interrupt path now enabled on FreeBSD there are segmentation faults on app exit, due to the alarm interrupt trying to access invalid pointers. Add checks for null to fix these crashes. Fixes: cd3b12495

Re: [PATCH v2 0/4] remove driver-specific logic for AVX builds

2025-03-18 Thread Bruce Richardson
On Mon, Mar 17, 2025 at 10:50:24AM +0100, David Marchand wrote: > On Fri, Mar 14, 2025 at 6:44 PM Bruce Richardson > wrote: > > > > A number of drivers had special optimized AVX2 and AVX512 code paths > > for performance reasons, and these tended to have copy-pasted logic > > to build those files.

RE: release candidate 25.03-rc2

2025-03-18 Thread Xu, HailinX
> -Original Message- > From: Thomas Monjalon > Sent: Friday, March 7, 2025 1:42 AM > To: annou...@dpdk.org > Subject: release candidate 25.03-rc2 > > A new DPDK release candidate is ready for testing: > https://git.dpdk.org/dpdk/tag/?id=v25.03-rc2 > > There are 251 new patches in t

Re: [PATCH v3] rust: support raw DPDK API

2025-03-18 Thread Dariusz Sosnowski
On Tue, Mar 18, 2025 at 09:51:05AM +0100, Dariusz Sosnowski wrote: > > +use std::process::Command; > > + > > +pub fn main() { > > +let mut pkgconfig = Command::new("pkg-config"); > > + > > +match pkgconfig.args(["--libs", "libdpdk"]).output() { > > +Ok(output) => { > > +

Re: [RFC v4 0/8] Symbol versioning and export rework

2025-03-18 Thread David Marchand
On Mon, Mar 17, 2025 at 4:43 PM David Marchand wrote: > > So far, each DPDK library (or driver) exposing symbols in an ABI had to > maintain a version.map and use some macros for symbol versioning, > specially crafted with the GNU linker in mind. > > This series proposes to rework the whole princi