[V12 17/18] net/hinic3: add flow control and FDIR module

2025-09-19 Thread Feifei Wang
From: Yi Chen Added support for rte_flow, including ethertype, IPv4, IPv6, and tunnel VXLAN. In addition, user can add or delete filters. Signed-off-by: Yi Chen Reviewed-by: Xin Wang Reviewed-by: Feifei Wang --- drivers/net/hinic3/hinic3_ethdev.c | 65 ++ drivers/net/hinic3/hinic3_ethdev.h

[PATCH] examples/flow_filtering: add more snippets

2025-09-19 Thread Shani Peretz
Added the following snippets: - Steering by Integrity Check Flags - Match packet type - ECN in IP Header Modification - Random Match - VXLAN-GPE Header Fields Matching - VXLAN-GBP Header Fields Matching - NVGRE Matching - NAT64 Action Usage Signed-off-by: Shani Peretz --- examples/flow_filtering

[PATCH v9 17/17] net/nbl: add nbl device set MTU and promisc

2025-09-19 Thread Dimon Zhao
Implement NBL device set MTU and promisc functions Signed-off-by: Dimon Zhao --- drivers/net/nbl/nbl_core.h| 2 + drivers/net/nbl/nbl_dev/nbl_dev.c | 59 ++ drivers/net/nbl/nbl_dev/nbl_dev.h | 7 +- drivers/net/nbl/nbl_dispatch.c

回复: [V11 13/18] net/hinic3: add dev ops

2025-09-19 Thread wangfeifei (J)
> + > +/** > + * Clear the reference to the copy memory pool without freeing it. > + * > + * @param[in] nic_dev > + * Pointer to NIC device structure. > + */ > +static void > +hinic3_copy_mempool_uninit(struct hinic3_nic_dev *nic_dev) > +{ > + nic_dev->cpy_mpool = NULL; > +} > + > +/** [Feifei

Re: Re: [PATCH v3 3/4] lib/fib: R-V V rte_fib_lookup_bulk

2025-09-19 Thread 孙越池
Got it, thanks. > -原始邮件- > 发件人: "Thomas Monjalon" > 发送时间: 2025-09-20 01:48:18 (星期六) > 收件人: "Sun Yuechi" > 抄送: dev@dpdk.org, "Vladimir Medvedkin" , "Stanislaw Kardach" , u...@foxmail.com > 主题: Re: [PATCH v3 3/4] lib/fib: R-V V rte_fib_lookup_bulk > > 19/09/2025 18:33, u...@foxmail.com:

[PATCH v3 3/4] lib/fib: R-V V rte_fib_lookup_bulk

2025-09-19 Thread uk7b
From: Sun Yuechi Implement rte_fib_lookup_bulk function for RISC-V architecture using RISC-V Vector Extension instruction set Signed-off-by: Sun Yuechi --- lib/fib/dir24_8.c | 20 ++ lib/fib/dir24_8_rvv.c | 64 +++ lib/fib/dir24_8_rvv.h |

Re: [RFC v2 2/9] vfio: remove confusing check on VFIO presence

2025-09-19 Thread Burakov, Anatoly
On 9/3/2025 5:17 PM, David Marchand wrote: Contrary to what the VFIO_PRESENT macro may suggest, there is no check on whether VFIO is enabled in the (build system) Linux kernel configuration. Replace check on VFIO_PRESENT with RTE_EAL_VFIO (for components built on FreeBSD or Windows), or simply r

[DPDK/ethdev Bug 1789] vmxnet3_dev_start fails in vmxnet3_v4_rss_configure() for single queue in ESX8.0 causing application to exit

2025-09-19 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1789 Bug ID: 1789 Summary: vmxnet3_dev_start fails in vmxnet3_v4_rss_configure() for single queue in ESX8.0 causing application to exit Product: DPDK Version: 19.11 Hardware: All

[PATCH] maintainers: update for RISC-V

2025-09-19 Thread uk7b
From: Sun Yuechi Add myself as maintainer for RISC-V. Signed-off-by: Sun Yuechi --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 1a2729be66..df1d295f93 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -337,10 +337,10 @@ F: example

[PATCH 2/3] compress/zlib: support for dictionaries and PDCP checksum

2025-09-19 Thread Sameer Vaze
Support to calculate PDCP checksums. Includes changes to pass in dictionaries. Adds support for sync flush Change-Id: Ic4a1f68f2c4d614549e2e516224aadb8d748e800 Signed-off-by: Sameer Vaze --- drivers/compress/zlib/zlib_pmd.c | 175 +-- drivers/compress/zlib/zlib_pmd_pr

[PATCH 1/3] compressdev: support for dictionaries and PDCP checksum

2025-09-19 Thread Sameer Vaze
Adds definitions for PDCP checksums and apis to pass in dictionaries Change-Id: Idbfebdd4ee0203d78ece1759fae689afaea8d6e3 Signed-off-by: Sameer Vaze --- lib/compressdev/rte_comp.h | 31 +++ 1 file changed, 31 insertions(+) diff --git a/lib/compressdev/rte_comp.h b/li

[PATCH 3/3] app/compress-perf: support for dictionaries and PDCP checksum

2025-09-19 Thread Sameer Vaze
Adds support to read and apply dictionaries Signed-off-by: Sameer Vaze --- app/test-compress-perf/comp_perf_options.h| 4 + .../comp_perf_options_parse.c | 16 .../comp_perf_test_verify.c | 37 +++- app/test-compress-perf/main.c | 9

[PATCH 3/3] app/compress-perf: support for dictionaries and PDCP checksum

2025-09-19 Thread Sameer Vaze
Adds support to read and apply dictionaries Change-Id: Ia48a463358d414286ad1275d3bbeca0d98a80776 Signed-off-by: Sameer Vaze --- app/test-compress-perf/comp_perf_options.h| 4 + .../comp_perf_options_parse.c | 16 .../comp_perf_test_verify.c | 37 ++

[PATCH v2 1/3] compressdev: support for dictionaries and PDCP checksum

2025-09-19 Thread Sameer Vaze
Adds definitions for PDCP checksums and apis to pass in dictionaries Signed-off-by: Sameer Vaze --- lib/compressdev/rte_comp.h | 31 +++ 1 file changed, 31 insertions(+) diff --git a/lib/compressdev/rte_comp.h b/lib/compressdev/rte_comp.h index 96d9b276dd..169d3d960e

[PATCH v2 2/3] compress/zlib: support for dictionaries and PDCP checksum

2025-09-19 Thread Sameer Vaze
Support to calculate PDCP checksums. Includes changes to pass in dictionaries. Adds support for sync flush Signed-off-by: Sameer Vaze --- drivers/compress/zlib/zlib_pmd.c | 175 +-- drivers/compress/zlib/zlib_pmd_private.h | 8 ++ 2 files changed, 174 insertions(+),

[PATCH] eal/x86: remove useless include from spinlock header

2025-09-19 Thread Thomas Monjalon
rte_cpuflags.h is not used in rte_spinlock.h, so it is removed, and added back in .c files where needed. Signed-off-by: Thomas Monjalon --- drivers/crypto/ipsec_mb/ipsec_mb_private.c | 1 + lib/eal/x86/include/rte_spinlock.h | 1 - lib/eal/x86/rte_power_intrinsics.c | 1 + lib/fi

Re: [PATCH] test: raise fast test timeout to 60s on RISC-V

2025-09-19 Thread Thomas Monjalon
18/09/2025 16:37, 孙越池: > > 发件人: "Thomas Monjalon" > > 27/11/2024 04:26, Eric Long: > > > On 27/11/2024 04:29, David Marchand wrote: > > > > You can extend the timeout via the multiplier option (default > timeout > > > > of 10s * multiplier). > > > > So in your case: > > > > $ meson test -C --sui

Re: [PATCH v3 1/4] config/riscv: detect V extension

2025-09-19 Thread Thomas Monjalon
19/09/2025 20:52, 孙越池: > > Please could you add a cross file in config/riscv/ for rv64gcv > > and use it in devtools/test-meson-builds.sh so we can test compiling > > with the vector extension? > > Sure, I plan to submit this next week. > > > Another question about RISC-V maintenance in general,

Re: [RFC v2 6/9] eal/linux: remove internal VFIO wrappers for old Linux

2025-09-19 Thread Burakov, Anatoly
On 9/3/2025 5:17 PM, David Marchand wrote: DPDK now requires Linux v5.4 at least. VFIO_SPAPR_TCE_IOMMU is present in Linux since v3.11. VFIO_SPAPR_TCE_v2_IOMMU is present in Linux since v4.2. Remove wrappers accordingly. Signed-off-by: David Marchand --- Acked-by: Anatoly Burakov -- Thank

[PATCH 3/3] app/compress-perf: support for dictionaries and PDCP checksum

2025-09-19 Thread Sameer Vaze
Adds support to read and apply dictionaries Signed-off-by: Sameer Vaze --- app/test-compress-perf/comp_perf_options.h| 4 + .../comp_perf_options_parse.c | 16 .../comp_perf_test_verify.c | 37 +++- app/test-compress-perf/main.c | 9

[PATCH 3/3] app/compres-perf: support for dictionaries and PDCP checksum

2025-09-19 Thread Sameer Vaze
Adds support to read and apply dictionaries. Signed-off-by: Sameer Vaze --- app/test-compress-perf/comp_perf_options.h| 4 + .../comp_perf_options_parse.c | 16 .../comp_perf_test_verify.c | 37 +++- app/test-compress-perf/main.c |

[PATCH 1/3] compressdev: support for dictionaries and PDCP checksum

2025-09-19 Thread Sameer Vaze
Adds definitions for PDCP checksums and apis to pass in dictionaries Signed-off-by: Sameer Vaze --- lib/compressdev/rte_comp.h | 31 +++ 1 file changed, 31 insertions(+) diff --git a/lib/compressdev/rte_comp.h b/lib/compressdev/rte_comp.h index 96d9b276dd..169d3d960e

[PATCH 2/3] compress/zlib: support for dictionaries and PDCP checksum

2025-09-19 Thread Sameer Vaze
Support to calculate PDCP checksums. Includes changes to pass in dictionaries. Adds support for sync flush Signed-off-by: Sameer Vaze --- drivers/compress/zlib/zlib_pmd.c | 171 +-- drivers/compress/zlib/zlib_pmd_private.h | 8 ++ 2 files changed, 170 insertions(+),

Re: [PATCH v3 1/4] config/riscv: detect V extension

2025-09-19 Thread Thomas Monjalon
19/09/2025 18:33, u...@foxmail.com: > From: Sun Yuechi > > This patch is derived from "config/riscv: detect presence of Zbc > extension with modifications". > > The RISC-V C api defines architecture extension test macros > These let us detect whether the V extension is supported on the > compile

[PATCH 2/3] compress/zlib: support for dictionaries and PDCP checksum

2025-09-19 Thread Sameer Vaze
Support to calculate PDCP checksums. Includes changes to pass in dictionaries. Adds support for sync flush Signed-off-by: Sameer Vaze --- drivers/compress/zlib/zlib_pmd.c | 171 +-- drivers/compress/zlib/zlib_pmd_private.h | 8 ++ 2 files changed, 170 insertions(+),

[PATCH 1/3] compressdev: support for dictionaries and PDCP checksum

2025-09-19 Thread Sameer Vaze
Adds definitions for PDCP checksums and apis to pass in dictionaries Signed-off-by: Sameer Vaze --- lib/compressdev/rte_comp.h | 31 +++ 1 file changed, 31 insertions(+) diff --git a/lib/compressdev/rte_comp.h b/lib/compressdev/rte_comp.h index 96d9b276dd..169d3d960e

Re: [PATCH v3 3/4] lib/fib: R-V V rte_fib_lookup_bulk

2025-09-19 Thread Thomas Monjalon
19/09/2025 18:33, u...@foxmail.com: > From: Sun Yuechi > +#ifndef _DIR248_RVV_H_ > +#define _DIR248_RVV_H_ > + > +#include "rte_cpuflags.h" It should be #include and it should be only where really needed (.c probably). Don't bother doing another version, I'm working on it, and will merg

[PATCH v3 0/4] Add RISC-V V extension detection and LPM, FIB optimization

2025-09-19 Thread uk7b
From: Sun Yuechi This patch series adds support for the RISC-V Vector (V) extension and provides an optimized implementation of `rte_lpm_lookupx4` using RVV. The initialization of lpm/vtbl_entry is not fully vectorized here because doing so would require __riscv_vluxei32_v_u32m1, which is slower

[PATCH v3 1/4] config/riscv: detect V extension

2025-09-19 Thread uk7b
From: Sun Yuechi This patch is derived from "config/riscv: detect presence of Zbc extension with modifications". The RISC-V C api defines architecture extension test macros These let us detect whether the V extension is supported on the compiler and -march we're building with. The C api also def

[PATCH 2/3] compress/zlib: support for dictionaries and PDCP checksum

2025-09-19 Thread Sameer Vaze
Support to calculate PDCP checksums. Includes changes to pass in dictionaries. Adds support for sync flush Signed-off-by: Sameer Vaze --- drivers/compress/zlib/zlib_pmd.c | 171 +-- drivers/compress/zlib/zlib_pmd_private.h | 8 ++ 2 files changed, 170 insertions(+),

[PATCH 3/3] app/compress-perf: support for dictionaries and PDCP checksum

2025-09-19 Thread Sameer Vaze
Adds support to read and apply dictionaries. Signed-off-by: Sameer Vaze --- app/test-compress-perf/comp_perf_options.h| 4 + .../comp_perf_options_parse.c | 16 .../comp_perf_test_verify.c | 37 +++- app/test-compress-perf/main.c |

[PATCH 1/3] compressdev: support for dictionaries and PDCP checksum

2025-09-19 Thread Sameer Vaze
Adds definitions for PDCP checksums and apis to pass in dictionaries Signed-off-by: Sameer Vaze --- lib/compressdev/rte_comp.h | 31 +++ 1 file changed, 31 insertions(+) diff --git a/lib/compressdev/rte_comp.h b/lib/compressdev/rte_comp.h index 96d9b276dd..169d3d960e

[PATCH 3/3] app/compress-perf: support for dictionaries and PDCP checksum

2025-09-19 Thread Sameer Vaze
Adds support to read and apply dictionaries. Signed-off-by: Sameer Vaze --- app/test-compress-perf/comp_perf_options.h| 4 + .../comp_perf_options_parse.c | 16 .../comp_perf_test_verify.c | 37 +++- app/test-compress-perf/main.c |

Re: [PATCH v1 1/1] dts: update testsuite docs

2025-09-19 Thread Dean Marx
Reviewed-by: Dean Marx On Wed, Sep 10, 2025 at 3:43 PM Paul Szczepanek wrote: > > From: Thomas Wilks > > Updated and corrected test case doc strings inside of test suites. > > Changed helper functions inside of testsuites into private functions > and removed doc strings where redundant. > > Dep

Re: Re: [PATCH v2 2/5] eal/riscv/spinlock: add rte_cpuflag.h

2025-09-19 Thread 孙越池
Okay, I initially thought this was common practice across all architectures, but it turns out only x86 added #include "rte_cpuflags.h" here. I’ve now moved it to lib/fib/dir24_8_rvv.h and updated v3. > -原始邮件- > 发件人: "Thomas Monjalon" > 发送时间: 2025-09-19 23:13:19 (星期五) > 收件人: "Sun Yuechi"

[PATCH v3 4/4] riscv: override machine_args only when default

2025-09-19 Thread uk7b
From: Sun Yuechi Support using -Dcpu_instruction_set=rv64gcv to enable V extension. Signed-off-by: Sun Yuechi --- config/riscv/meson.build | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/config/riscv/meson.build b/config/riscv/meson.build index e3694cf2e6..

[PATCH v3 2/4] lib/lpm: R-V V rte_lpm_lookupx4

2025-09-19 Thread uk7b
From: Sun Yuechi Implement LPM lookupx4 function for RISC-V architecture using RISC-V Vector Extension instruction set Signed-off-by: Sun Yuechi --- MAINTAINERS | 2 ++ lib/lpm/meson.build | 1 + lib/lpm/rte_lpm.h | 2 ++ lib/lpm/rte_lpm_rvv.h | 59 ++

[V12 11/18] net/hinic3: add a mailbox communication module

2025-09-19 Thread Feifei Wang
From: Yi Chen This patch adds support for mailbox of hinic3 PMD driver, mailbox is used for communication between PF/VF driver and MPU. This patch provides mailbox-related data structures and functional code. Signed-off-by: Yi Chen Reviewed-by: Xin Wang Reviewed-by: Feifei Wang --- drivers/n

Re: [EXTERNAL] [PATCH] app/compress-perf: support dictionary files

2025-09-19 Thread Sameer Vaze
I don't see anything specific about creating and pushing a series : 9. Contributing Code to DPDK — Data Plane Development Kit 25.07.0 documentation. The only mention to a series above seems to use the depends-on tag. Thanks Sameer Vaze

Re: [PATCH v2 2/5] eal/riscv/spinlock: add rte_cpuflag.h

2025-09-19 Thread Thomas Monjalon
01/07/2025 20:20, u...@foxmail.com: > From: Sun Yuechi > > Same as the x86 style, include "rte_cpuflags.h" in rte_spinlock.h > so that files like lib/fib/dir24_8.c don’t need to include it. > > Signed-off-by: Sun Yuechi I disagree. I prefer removing useless includes like in x86 spinlock.

[V12 04/18] net/hinic3: add support for cmdq mechanism

2025-09-19 Thread Feifei Wang
From: Xin Wang Microcode is named ucode in SP series NIC. Its main responsibility is data transmission and reception. But it can also handle some administration works. It uses cmdq mechanism. This patch introduces data structures, initialization, interfaces, and commands sending functions of cmdq

[V12 14/18] net/hinic3: add device initialization

2025-09-19 Thread Feifei Wang
From: Xin Wang Add device initializationd function codes. Signed-off-by: Xin Wang Reviewed-by: Feifei Wang Reviewed-by: Yi Chen --- drivers/net/hinic3/hinic3_ethdev.c | 273 + 1 file changed, 273 insertions(+) diff --git a/drivers/net/hinic3/hinic3_ethdev.c b/dr

[V12 16/18] net/hinic3: add RSS promiscuous ops

2025-09-19 Thread Feifei Wang
From: Xin Wang Add RSS and promiscuous ops related function codes. Signed-off-by: Xin Wang Reviewed-by: Feifei Wang Reviewed-by: Yi Chen --- drivers/net/hinic3/hinic3_ethdev.c | 352 + drivers/net/hinic3/hinic3_ethdev.h | 6 + 2 files changed, 358 insertions(+)

[PATCH v2 3/4] member: remove AVX2 build-time checks

2025-09-19 Thread Thomas Monjalon
Since all supported compilers can generate AVX2 code, it is possible to force AVX2 compilation on some specific functions and remove the checks for AVX2 support when x86 arch is already checked. The functions have to be moved in a .c file, losing inlining. Signed-off-by: Thomas Monjalon --- ...

Re: [PATCH] gro: fix payload corruption in coalescing packets

2025-09-19 Thread Thomas Monjalon
18/09/2025 14:36, kumaraparameshwaran rathinavel: > Reviewed by : @kumaraparameshwaran rathinavel > > On Tue, Sep 2, 2025 at 4:14 PM Tathagat Priyadarshi > wrote: > > > In the current implementation when cmp is larger than 0, > > the new packet is appended to the original packet. However > > th

[V12 07/18] net/hinic3: add mgmt module function code

2025-09-19 Thread Feifei Wang
From: Yi Chen Mgmt module is a kind of administration module for the chip. It is responsible for handling administration command from host. It mainly uses aeq to implement. This patch adds related data structures, packaged interfaces and function codes. Signed-off-by: Yi Chen Reviewed-by: Xin W

[V12 09/18] net/hinic3: add a NIC business configuration module

2025-09-19 Thread Feifei Wang
From: Yi Chen The items of configurations and queries for NIC business include MAC, VLAN, MTU, RSS and so on. These configurations and queries are handled by mgmt module. This patch introduces related data structures and function codes. Signed-off-by: Yi Chen Reviewed-by: Xin Wang Reviewed-by:

[V12 03/18] net/hinic3: add hardware interfaces of BAR operation

2025-09-19 Thread Feifei Wang
From: Yi Chen This patch adds some HW interfaces for bar operatioin interfaces, including: mapped bar address geeting, HW attributes getting, msi-x reg operation, function type getting and so on. Signed-off-by: Yi Chen Reviewed-by: Xin Wang Reviewed-by: Feifei Wang --- drivers/net/hinic3/bas

[V12 18/18] drivers/net: add hinic3 PMD build and doc files

2025-09-19 Thread Feifei Wang
From: Yi Chen The hinic3.ini file and hinic3.rst file are added to this patch. Signed-off-by: Yi Chen Reviewed-by: Xin Wang Reviewed-by: Feifei Wang --- MAINTAINERS | 1 + doc/guides/nics/features/hinic3.ini | 60 + doc/guides/nics/hinic3.

[V12 15/18] net/hinic3: add Rx/Tx functions

2025-09-19 Thread Feifei Wang
From: Feifei Wang This patch add package sending and receiving function codes. Signed-off-by: Feifei Wang Signed-off-by: Yi Chen Reviewed-by: Xin Wang --- drivers/net/hinic3/hinic3_ethdev.c | 3 + drivers/net/hinic3/hinic3_rx.c | 285 +++ drivers/net/hinic3/hinic3_tx.c | 77

[V12 12/18] net/hinic3: add futions for initialization

2025-09-19 Thread Feifei Wang
From: Xin Wang This patch contains data structures and function codes related to device initialization. Signed-off-by: Xin Wang Reviewed-by: Feifei Wang Reviewed-by: Yi Chen --- drivers/net/hinic3/hinic3_ethdev.c | 255 + drivers/net/hinic3/hinic3_ethdev.h | 118 +

[V12 10/18] net/hinic3: add context and work queue support

2025-09-19 Thread Feifei Wang
From: Xin Wang Work queue is used for cmdq and tx/rx buff description. Nic business needs to configure cmdq context and txq/rxq context. This patch adds data structures and function codes for work queue and context. Signed-off-by: Xin Wang Reviewed-by: Feifei Wang Reviewed-by: Yi Chen --- dr

[V12 08/18] net/hinic3: add module about hardware operation

2025-09-19 Thread Feifei Wang
From: Yi Chen Add code and data structure for hardware operation, including configuration, query, initialization and release. Signed-off-by: Yi Chen Signed-off-by: Xin Wang Reviewed-by: Feifei Wang --- drivers/net/hinic3/base/hinic3_hw_cfg.c | 190 drivers/net/hinic3/base/hinic3_hw

[V12 05/18] net/hinic3: add NIC event module

2025-09-19 Thread Feifei Wang
From: Xin Wang Currently, there are two types of events: pf/vf connection status and port information printing. This patch contains related data structures and function codes. Signed-off-by: Xin Wang Reviewed-by: Yi Chen Reviewed-by: Feifei Wang --- drivers/net/hinic3/base/hinic3_nic_event.c

[V12 06/18] net/hinic3: add eq mechanism

2025-09-19 Thread Feifei Wang
From: Yi Chen Eqs include aeq and ceq. Aeq is a kind of queue for mgmt asynchronous message and mgmt command response message. This patch introduces data structures, initialization, and related interfaces about aeq. Signed-off-by: Yi Chen Reviewed-by: Xin Wang Reviewed-by: Feifei Wang --- dr

[V12 02/18] net/hinic3: add basic header files

2025-09-19 Thread Feifei Wang
From: Xin Wang Add HW registers definition header file for SP series NIC. Add some headers that define commands and basic defines for use in the code. Signed-off-by: Xin Wang Reviewed-by: Yi Chen Reviewed-by: Feifei Wang --- MAINTAINERS | 1 + drivers/net/hinic3

[V12 01/18] doc: add hinic3 driver

2025-09-19 Thread Feifei Wang
From: Yi Chen This patch adds document for hinic3 driver. Signed-off-by: Feifei Wang Signed-off-by: Yi Chen Reviewed-by: Xin Wang --- .mailmap | 4 +++- MAINTAINERS| 4 doc/guides/nics/index.rst | 1 + doc/guides/rel

[V12 00/18] add-hinic3-PMD-driver

2025-09-19 Thread Feifei Wang
The hinic3 PMD (**librte_net_hinic3**) provides poll mode driver support for 25Gbps/100Gbps/200Gbps Huawei SPx series Network Adapters. V12: -modify get_bit function -remove define but not used macro -modify time_before macro v11: -reorder code to avoid forward declarations -remove unused casts -

Re: [PATCH v2] eal: fix DMA mask validation inconsistency in IOVA VA

2025-09-19 Thread Thomas Monjalon
18/09/2025 09:55, Shani Peretz: > From: Shani Peretz > > > > When --iova-mode is explicitly specified in command line, DMA mask > > constraints were not being validated, leading to potential runtime failures > > when device DMA capabilities are exceeded. > > > > The issue occurred because rte_bu

Re: [PATCH v3] bus/pci: don't open uio device in secondary process

2025-09-19 Thread David Marchand
On Fri, 11 Oct 2024 at 13:17, Konrad Sztyber wrote: > > The uio_pci_generic driver clears the bus master bit when the device > file is closed. So, when the secondary process terminates after probing > a device, that device becomes unusable in the primary process. > > To avoid that, the device file

Re: [PATCH 1/4] net/idpf: use the new common vector capability function

2025-09-19 Thread Bruce Richardson
On Thu, Sep 11, 2025 at 02:31:42PM +, Ciara Loftus wrote: > Use the new function for determining the maximum simd bitwidth in the > idpf driver. An additional check is required for the AVX512DQ flag which > is not performed in the common function. Since no other drivers require > this flag, the

Re: [PATCH v2] net/af_packet: fix crash in secondary process

2025-09-19 Thread Stephen Hemminger
On Fri, 12 Sep 2025 14:35:25 +0300 Kerem Aksu wrote: > dumpcap crashes when trying to capture from af_packet devices. This is > caused by allocating interface name with > strdup (i.e. malloc). Interface name is not accessible from secondary > process and causes segmentation fault. Use rte_malloc

[PATCH v1 08/16] net/ntnic: change prefix ntlog_ to prefix nthw_log

2025-09-19 Thread Serhii Iliushyk
Change prefix ntlog_ to prefix nthw_log for logging functions. Signed-off-by: Serhii Iliushyk --- .../net/ntnic/nthw/model/nthw_fpga_model.c| 20 +-- drivers/net/ntnic/nthw/nthw_rac.c | 20 +-- drivers/net/ntnic/ntlog/ntlog.c | 6 +++

[PATCH v1 13/16] net/ntnic: rename get ops functions

2025-09-19 Thread Serhii Iliushyk
Add prefix nthw_ to get ops functions to follow naming convention. Signed-off-by: Serhii Iliushyk --- drivers/net/ntnic/adapter/nt4ga_adapter.c | 10 ++-- .../net/ntnic/adapter/nt4ga_stat/nt4ga_stat.c | 4 +- .../net/ntnic/nthw/core/include/nthw_fpga.h | 4 +- .../nthw/core/nt200a0x/nthw

[PATCH v1 16/16] net/ntnic: rename table id functions

2025-09-19 Thread Serhii Iliushyk
Extent table id functions with prefix nthw_. Signed-off-by: Serhii Iliushyk --- drivers/net/ntnic/nthw/flow_api/flow_id_table.c | 10 +- drivers/net/ntnic/nthw/flow_api/flow_id_table.h | 10 +- .../profile_inline/flow_api_profile_inline.c | 16 3 files chan

[PATCH v1 15/16] net/ntnic: rename nim agx setup function

2025-09-19 Thread Serhii Iliushyk
Add prefix nthw_ to nim_agx_setup to follow naming convention. Signed-off-by: Serhii Iliushyk --- drivers/net/ntnic/link_mgmt/link_agx_100g/nt4ga_agx_link_100g.c | 2 +- drivers/net/ntnic/nim/i2c_nim.c | 2 +- drivers/net/ntnic/nim/i2c_nim.h

[PATCH v1 12/16] net/ntnic: rename register ops function

2025-09-19 Thread Serhii Iliushyk
Add prefix nthw_ to register ops function to follow naming convention. Signed-off-by: Serhii Iliushyk --- drivers/net/ntnic/adapter/nt4ga_adapter.c | 2 +- .../net/ntnic/adapter/nt4ga_stat/nt4ga_stat.c | 2 +- drivers/net/ntnic/dbsconfig/ntnic_dbsconfig.c | 2 +- .../link_mgmt/link_100g/n

[PATCH v1 14/16] net/ntnic: rename ops_init functions

2025-09-19 Thread Serhii Iliushyk
Add prefix nthw_ to ops init function to follow the naming convention. Signed-off-by: Serhii Iliushyk --- .../net/ntnic/adapter/nt4ga_stat/nt4ga_stat.c | 2 +- .../link_agx_100g/nt4ga_agx_link_100g.c| 2 +- .../net/ntnic/nthw/core/include/nthw_fpga.h| 4 ++-- .../clock_profiles/n

[PATCH v1 11/16] net/ntnic: rename common hash and flow functions

2025-09-19 Thread Serhii Iliushyk
Rename common hash and flow functions to have consistent naming convention. Signed-off-by: Serhii Iliushyk --- drivers/net/ntnic/include/flow_api.h | 8 drivers/net/ntnic/nthw/flow_api/flow_api.c | 12 ++-- drivers/net/ntnic/nthw/flow_api/flow_hsh_cfg.

[PATCH v1 09/16] net/ntnic: change prefix km_ to prefix nthw_km_

2025-09-19 Thread Serhii Iliushyk
Change prefix km_ (key matcher) to prefix nthw_km_ for flow_api module. Signed-off-by: Serhii Iliushyk --- drivers/net/ntnic/include/flow_api_engine.h | 18 ++-- drivers/net/ntnic/nthw/flow_api/flow_api.c| 4 +- drivers/net/ntnic/nthw/flow_api/flow_kcc.c| 2 +- drivers/net/ntnic/nthw

[PATCH v1 05/16] net/ntnic: modify prefix flow_ with prefix nthw_

2025-09-19 Thread Serhii Iliushyk
Change the prefix flow_ with prefix nthw_flow to specify that the flow API belongs to the Napatech hardware (nthw). Signed-off-by: Serhii Iliushyk --- drivers/net/ntnic/nthw/flow_api/flow_api.c| 54 + .../nthw/flow_api/flow_backend/flow_backend.c | 4 +- .../profile_inline/flow_ap

[PATCH v1 10/16] net/ntnic: change prefix set_ to prefix nthw_set_

2025-09-19 Thread Serhii Iliushyk
Change setter functions prefix from set_ to nthw_set_ for DBS module Signed-off-by: Serhii Iliushyk --- drivers/net/ntnic/dbsconfig/ntnic_dbsconfig.c | 50 +-- drivers/net/ntnic/include/ntnic_dbs.h | 22 drivers/net/ntnic/nthw/dbs/nthw_dbs.c | 22

[PATCH v1 01/16] net/ntnic: single file function as static

2025-09-19 Thread Serhii Iliushyk
Refactoring: make single file functions static to avoid namespace pollution. Signed-off-by: Serhii Iliushyk --- drivers/net/ntnic/include/create_elements.h | 9 - drivers/net/ntnic/include/flow_api.h | 2 - drivers/net/ntnic/include/hw_mod_backend.h| 15 - drivers/net/ntnic/

[PATCH v1 06/16] net/ntnic: change prefix flm_ to prefix nthw_flm_

2025-09-19 Thread Serhii Iliushyk
Change the prefix flm_ to prefix nthw_flm_ to specify that these functions and part of the ntwh (Napatech Hardware). Signed-off-by: Serhii Iliushyk --- .../flow_api/profile_inline/flm_age_queue.c | 22 .../flow_api/profile_inline/flm_age_queue.h | 20 +++ .../flow_api/profile_in

[PATCH v1 07/16] net/ntnic: change prefix nt_ to prefix nthw_

2025-09-19 Thread Serhii Iliushyk
change prefix nt_ to prefix nthw_ to specify that this is related to Napatech hardware. Signed-off-by: Serhii Iliushyk --- .../net/ntnic/adapter/nt4ga_stat/nt4ga_stat.c | 2 +- drivers/net/ntnic/dbsconfig/ntnic_dbsconfig.c | 2 +- .../link_mgmt/link_100g/nt4ga_link_100g.c | 12 ++--- .../l

[PATCH v1 02/16] net/ntnic: remove unused functions

2025-09-19 Thread Serhii Iliushyk
Remove unused functions from various files in the ntnic PMD. Signed-off-by: Serhii Iliushyk --- drivers/net/ntnic/nthw/core/nthw_hif.c| 90 --- drivers/net/ntnic/nthw/core/nthw_mac_pcs.c| 11 --- drivers/net/ntnic/nthw/core/nthw_pcie3.c | 87 -- .

[PATCH v1 00/16] refactoring naming the for exported symbols

2025-09-19 Thread Serhii Iliushyk
This patch series dedicates to align the naming if the exported symbols in order to avoid potential conflicts with other application and libraries. The main change is to add the prefix "nthw_". Serhii Iliushyk (16): net/ntnic: single file function as static net/ntnic: remove unused functions

RE: [PATCH v2 1/4] mbuf: record mbuf operations history

2025-09-19 Thread Shani Peretz
> -Original Message- > From: Morten Brørup > Sent: Wednesday, 17 September 2025 17:46 > To: Shani Peretz ; dev@dpdk.org > Cc: step...@networkplumber.org; bruce.richard...@intel.com; > ajit.khapa...@broadcom.com; jer...@marvell.com; > konstantin.v.anan...@yandex.ru; david.march...@redhat.

Re: [RFC] lib/dma: introduce inter-process and inter-OS DMA

2025-09-19 Thread fengchengwen
Hi Vamsi, This commit change is more than discussed, it add control API which for group management. 1. Control API: I check this commit and Intel commit [1], it seem has a quite difference. I hope Intel guys can express views. I prefer not add this part if no response. 2. Data API: this co

Re: [PATCH] telemetry: remove deprecated functions

2025-09-19 Thread David Marchand
On Fri, 19 Sept 2025 at 09:57, Bruce Richardson wrote: > > The "_u64" telemetry functions were replaced by the "_uint" versions > back in 2023 [1], so can be removed from the release. > > Signed-off-by: Bruce Richardson With a release note update, Acked-by: David Marchand Cc: dpservice, fyi.

Re: [PATCH v2] build: remove deprecated kmods option

2025-09-19 Thread David Marchand
On Fri, 19 Sept 2025 at 10:45, Bruce Richardson wrote: > > The "enable_kmods" meson option was deprecated back in 2023[1], so can > now be removed from DPDK. > > Signed-off-by: Bruce Richardson We are missing a release note entry, but otherwise lgtm. You can add: Acked-by: David Marchand --

[PATCH v3 00/10] Cleanup VFIO API and import Linux uAPI header

2025-09-19 Thread David Marchand
The VFIO headers have a number of issues: - showing to the world a lot of internal considerations, - defining macros with the VFIO_ namespace (confusing, and a source of conflicts with the VFIO official uAPI), - wrapping around VFIO uAPI in case the kernel headers do not contain the expected AP

[PATCH v3 08/10] vfio: stop including Linux kernel header in public and driver API

2025-09-19 Thread David Marchand
The DPDK API is not dependent on the VFIO API itself. Remove inclusion in rte_vfio.h (and bus_fslmc_driver.h) and add explicit inclusion where needed. Signed-off-by: David Marchand Reviewed-by: Rosen Xu Acked-by: Anatoly Burakov --- drivers/bus/cdx/cdx_vfio.c | 3 +++ drivers/b

[PATCH v3 06/10] eal/linux: remove more internal VFIO macros

2025-09-19 Thread David Marchand
No need to redefine some VFIO_* macros that look like a define coming from standard linux/vfio.h header. Use RTE_DIM() and remove unneeded checks (like in get_vfio_group_idx() where j can't be >= RTE_DIM(vfio_cfg->vfio_groups)). Signed-off-by: David Marchand Acked-by: Anatoly Burakov --- lib/ea

[PATCH v2] build: remove deprecated kmods option

2025-09-19 Thread Bruce Richardson
The "enable_kmods" meson option was deprecated back in 2023[1], so can now be removed from DPDK. Signed-off-by: Bruce Richardson [1] https://doc.dpdk.org/guides-23.11/rel_notes/deprecation.html --- v2: remove missed references in DTS and in freebsd meson.build --- doc/guides/rel_notes/deprecat

[PATCH v3 09/10] uapi: import VFIO header

2025-09-19 Thread David Marchand
Import VFIO header (from v6.16) to be included in many parts of DPDK. Signed-off-by: David Marchand --- Changes since v3: - reimported header following script update, --- kernel/linux/uapi/linux/vfio.h | 1836 kernel/linux/uapi/version |2 +- 2 files ch

[PATCH v3 10/10] vfio: use imported uAPI header

2025-09-19 Thread David Marchand
Now that we have a v6.16 header in DPDK, we can remove all remaining wrappers around VFIO uapi. Signed-off-by: David Marchand Reviewed-by: Rosen Xu --- Changes since RFC v2: - fixed header inclusion order (see patch 1), - converted net/xsc, --- drivers/bus/cdx/cdx_vfio.c | 47 +

[PATCH v3 07/10] eal/linux: remove internal VFIO wrappers for old Linux

2025-09-19 Thread David Marchand
DPDK now requires Linux v5.4 at least. VFIO_SPAPR_TCE_IOMMU is present in Linux since v3.11. VFIO_SPAPR_TCE_v2_IOMMU is present in Linux since v4.2. Remove wrappers accordingly. Signed-off-by: David Marchand --- drivers/bus/fslmc/fslmc_vfio.c | 2 +- lib/eal/linux/eal_vfio.c | 4 +-- l

[PATCH v3 04/10] vfio: assume VFIO is always and only present on Linux

2025-09-19 Thread David Marchand
RTE_EAL_VFIO is directly mapped to is_linux in meson. Replace this intermediate build knob with RTE_EXEC_ENV_LINUX. This is an intermediate state before importing the VFIO uapi header. Note: crypto/bcmfs was functional only for OSes supporting VFIO iow Linux. Stop compiling it on other OSes. Sign

[PATCH v3 05/10] vfio: remove public wrappers

2025-09-19 Thread David Marchand
The public header defines a number of wrappers that can be removed or hidden internally. Either, those concern old Linux kernel versions that are not supported by dpdk anymore (DPDK now requires Linux v5.4 at least), like: - the request notifier feature, present since Linux v4.0, - the noiommu mod

[PATCH v3 03/10] vfio: remove confusing check on VFIO presence

2025-09-19 Thread David Marchand
Contrary to what the VFIO_PRESENT macro may suggest, there is no check on whether VFIO is enabled in the (build system) Linux kernel configuration. Replace check on VFIO_PRESENT with RTE_EAL_VFIO (for components built on FreeBSD or Windows), or simply remove it otherwise. Then remove inclusion of

[PATCH v3 02/10] drivers: remove unneeded VFIO header inclusion

2025-09-19 Thread David Marchand
Those drivers sources do nothing related to VFIO. Signed-off-by: David Marchand Acked-by: Anatoly Burakov --- drivers/common/qat/dev/qat_dev_gen_lce.c | 4 drivers/net/hns3/hns3_ethdev_vf.c| 1 - drivers/raw/ifpga/afu_pmd_he_hssi.c | 1 - drivers/raw/ifpga/afu_pmd_he_lpbk.c

[PATCH v3 01/10] uapi: fix include guards in VDUSE imported header

2025-09-19 Thread David Marchand
One issue with the currently imported header is that if a header (external to DPDK) starts including the equivalent system installed uapi header, then when DPDK code later includes its own uapi/ header, the header guard won't match, which may result in DPDK build failure. To address this issue, ad

Re: [RFC v2 8/9] uapi: import VFIO header

2025-09-19 Thread David Marchand
On Thu, 18 Sept 2025 at 17:17, Stephen Hemminger wrote: > > On Thu, 18 Sep 2025 10:48:12 +0200 > Thomas Monjalon wrote: > > > 06/09/2025 06:11, Stephen Hemminger: > > > On Wed, 3 Sep 2025 17:17:58 +0200 > > > David Marchand wrote: > > > > > > > Import VFIO header (from v6.16) to be included in

Re: [PATCH] build: remove deprecated kmods option

2025-09-19 Thread Bruce Richardson
On Fri, Sep 19, 2025 at 08:57:33AM +0100, Bruce Richardson wrote: > The "enable_kmods" meson option was deprecated back in 2023[1], so can > now be removed from DPDK. > > Signed-off-by: Bruce Richardson > > [1] https://doc.dpdk.org/guides-23.11/rel_notes/deprecation.html > --- > doc/guides/rel_

[PATCH] telemetry: remove deprecated functions

2025-09-19 Thread Bruce Richardson
The "_u64" telemetry functions were replaced by the "_uint" versions back in 2023 [1], so can be removed from the release. Signed-off-by: Bruce Richardson [1] https://doc.dpdk.org/guides-23.03/rel_notes/deprecation.html --- doc/guides/rel_notes/deprecation.rst | 5 lib/telemetry/rte_telem

[PATCH] build: remove deprecated kmods option

2025-09-19 Thread Bruce Richardson
The "enable_kmods" meson option was deprecated back in 2023[1], so can now be removed from DPDK. Signed-off-by: Bruce Richardson [1] https://doc.dpdk.org/guides-23.11/rel_notes/deprecation.html --- doc/guides/rel_notes/deprecation.rst | 7 --- meson_options.txt| 2 -- 2

RE: [PATCH] examples/ip_reassembly: remove conflicting Tx offload

2025-09-19 Thread Konstantin Ananyev
> > IP packet reassembly requires the MULTI_SEGS offload to be enabled in order > to handle fragmented packets across multiple memory segments. However, the > MBUF_FAST_FREE offload conflicts with MULTI_SEGS and cannot be enabled > simultaneously. > > Remove the MBUF_FAST_FREE offload to avoid