[dpdk-dev] [PATCH v4] test/crypto: check if RAW API is supported

2021-07-20 Thread Adam Dybkowski
This patch adds checking if RAW API is supported at the start of the test command "cryptodev_qat_raw_api_autotest". Signed-off-by: Adam Dybkowski --- app/test/test_cryptodev.c | 43 ++- 1 file changed, 42 insertions(+), 1 deletion(-) diff --git

[dpdk-dev] [PATCH v3] test/crypto: check if RAW API is supported

2021-07-19 Thread Adam Dybkowski
This patch adds checking if RAW API is supported at the start of the test command "cryptodev_qat_raw_api_autotest". Signed-off-by: Adam Dybkowski Acked-by: Fan Zhang --- app/test/test_cryptodev.c | 34 +- 1 file changed, 33 insertions(+), 1 deletio

[dpdk-dev] [PATCH] doc: update QAT compression PMD in 21.05 rel notes

2021-05-13 Thread Adam Dybkowski
This patch extends the DPDK 21.05 release notes with the QAT GEN3 compression update. Signed-off-by: Adam Dybkowski --- doc/guides/rel_notes/release_21_05.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides/rel_notes/release_21_05.rst b/doc/guides/rel_notes/release_21_05

[dpdk-dev] [PATCH] crypto/qat: fix NULL authentication request

2021-05-10 Thread Adam Dybkowski
This patch fixes the NULL auth generation case where the request shouldn't contain the authentication result address. Allows to run ipsec_autotest with a QAT device. Fixes: 65beb9abca6d ("crypto/qat: fix null auth when using VFIO") Signed-off-by: Adam Dybkowski --- drivers/crypt

[dpdk-dev] [PATCH 2/2] compress/qat: enable compression on QAT GEN3

2021-04-28 Thread Adam Dybkowski
e PMD cleaning phase. Fixes: a124830a6f00 ("compress/qat: enable dynamic huffman encoding") Fixes: 352332744c3a ("compress/qat: add dynamic SGL allocation") Signed-off-by: Adam Dybkowski --- drivers/compress/qat/qat_comp.c | 7 +- drivers/compress

[dpdk-dev] [PATCH 1/2] common/qat: increase IM buffer size for QAT GEN3

2021-04-28 Thread Adam Dybkowski
This patch increases the intermediate buffer size used for the compression on QAT GEN3 to accommodate new hardware versions. Fixes: a124830a6f00 ("compress/qat: enable dynamic huffman encoding") Signed-off-by: Adam Dybkowski --- drivers/common/qat/qat_device.h | 2 +- 1 file

[dpdk-dev] [PATCH v3 1/1] crypto/qat: support Single-Pass GMAC on QAT GEN3

2021-04-14 Thread Adam Dybkowski
This patch implements Single-Pass AES-GMAC possible on QAT GEN3 which improves the performance. On GEN1 and GEN2 the previous chained method is used. Signed-off-by: Adam Dybkowski --- drivers/common/qat/qat_qp.c | 3 +- drivers/crypto/qat/qat_sym.c | 72

[dpdk-dev] [PATCH v3 0/1] crypto/qat: support Single-Pass GMAC on QAT GEN3

2021-04-14 Thread Adam Dybkowski
Adam Dybkowski (1): crypto/qat: support Single-Pass GMAC on QAT GEN3 drivers/common/qat/qat_qp.c | 3 +- drivers/crypto/qat/qat_sym.c | 72 +++- drivers/crypto/qat/qat_sym.h | 66 - drivers/crypto/qat/qat_sym_pmd.c | 6

[dpdk-dev] [PATCH v3 2/2] app/crypto-perf: close PMD after benchmark run

2021-04-09 Thread Adam Dybkowski
This patch adds closing of the PMD after running the benchmark. Signed-off-by: Adam Dybkowski --- app/test-crypto-perf/main.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/app/test-crypto-perf/main.c b/app/test-crypto-perf/main.c index 49af812d8b

[dpdk-dev] [PATCH v3 1/2] test/crypto: close PMD after tests

2021-04-09 Thread Adam Dybkowski
This patch adds closing of the PMD after running the tests. Signed-off-by: Adam Dybkowski --- app/test/test_cryptodev.c | 5 + 1 file changed, 5 insertions(+) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index f91debc168..d68855c442 100644 --- a/app/test

[dpdk-dev] [PATCH v3 0/2] test/crypto: close PMD after tests

2021-04-09 Thread Adam Dybkowski
This patch adds closing of the PMD after running the tests. -- v3: * move the call from ut_teardown to testsuite_teardown v2: * display error message on close error Adam Dybkowski (2): test/crypto: close PMD after tests app/crypto-perf: close PMD after benchmark run app/test-crypto-perf

[dpdk-dev] [PATCH v2 2/2] app/crypto-perf: close PMD after benchmark run

2021-03-08 Thread Adam Dybkowski
This patch adds closing of the PMD after running the benchmark. Signed-off-by: Adam Dybkowski --- app/test-crypto-perf/main.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/app/test-crypto-perf/main.c b/app/test-crypto-perf/main.c index 49af812d8..70cb04a21

[dpdk-dev] [PATCH v2 1/2] test/crypto: close PMD after tests

2021-03-08 Thread Adam Dybkowski
This patch adds closing of the PMD after running the tests. Signed-off-by: Adam Dybkowski --- app/test/test_cryptodev.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index f91debc16..ea965a64a 100644 --- a/app/test

[dpdk-dev] [PATCH v2 0/2] test/crypto: close PMD after tests

2021-03-08 Thread Adam Dybkowski
This patch adds closing of the PMD after running the tests. -- v2: * display error message on close error Adam Dybkowski (2): test/crypto: close PMD after tests app/crypto-perf: close PMD after benchmark run app/test-crypto-perf/main.c | 15 +-- app/test/test_cryptodev.c

[dpdk-dev] [PATCH v2 1/1] crypto/qat: support Single-Pass GMAC on QAT GEN3

2021-03-05 Thread Adam Dybkowski
This patch implements Single-Pass AES-GMAC possible on QAT GEN3 which improves the performance. On GEN1 and GEN2 the previous chained method is used. Signed-off-by: Adam Dybkowski --- drivers/common/qat/qat_qp.c | 3 +- drivers/crypto/qat/qat_sym.c | 64

[dpdk-dev] [PATCH v2 0/1] crypto/qat: support Single-Pass GMAC on QAT GEN3

2021-03-05 Thread Adam Dybkowski
This patch implements Single-Pass AES-GMAC possible on QAT GEN3 which improves the performance. On GEN1 and GEN2 the previous chained method is used. -- v2: * fix minor building and style issues Adam Dybkowski (1): crypto/qat: support Single-Pass GMAC on QAT GEN3 drivers/common/qat/qat_qp.c

[dpdk-dev] [PATCH] crypto/qat: support Single-Pass GMAC on QAT GEN3

2021-03-05 Thread Adam Dybkowski
This patch implements Single-Pass AES-GMAC possible on QAT GEN3 which improves the performance. On GEN1 and GEN2 the previous chained method is used. Signed-off-by: Adam Dybkowski --- drivers/common/qat/qat_qp.c | 3 +- drivers/crypto/qat/qat_sym.c | 64

[dpdk-dev] [PATCH 2/2] app/crypto-perf: close PMD after benchmark run

2021-03-01 Thread Adam Dybkowski
This patch adds closing of the PMD after running the benchmark. Signed-off-by: Adam Dybkowski --- app/test-crypto-perf/main.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/app/test-crypto-perf/main.c b/app/test-crypto-perf/main.c index 49af812d8..c1d338fa4 100644

[dpdk-dev] [PATCH 1/2] test/crypto: close PMD after tests

2021-03-01 Thread Adam Dybkowski
This patch adds closing of the PMD after running the tests. Signed-off-by: Adam Dybkowski --- app/test/test_cryptodev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index f91debc16..7dcd255de 100644 --- a/app/test

[dpdk-dev] [PATCH v5 1/1] doc: document vfio-pci usage with QAT PMD

2020-10-13 Thread Adam Dybkowski
ernels 5.9 and later. Signed-off-by: Adam Dybkowski Acked-by: Anatoly Burakov --- doc/guides/cryptodevs/qat.rst | 64 +++ 1 file changed, 35 insertions(+), 29 deletions(-) diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst index 7c5629319.

[dpdk-dev] [PATCH v5 0/1] doc: document vfio-pci usage with QAT PMD

2020-10-13 Thread Adam Dybkowski
ernels 5.9 and later. v2: * add example command with disable_denylist option v3: * simplify binding/unbinding command examples by using python scripts * remove the description of old binding method v4: * rebase v5: * rebase against github dpdk main branch Adam Dybkowski (1): doc: documen

[dpdk-dev] [PATCH v4 1/1] doc: document vfio-pci usage with QAT PMD

2020-10-12 Thread Adam Dybkowski
ernels 5.9 and later. Signed-off-by: Adam Dybkowski --- doc/guides/cryptodevs/qat.rst | 63 +++ 1 file changed, 34 insertions(+), 29 deletions(-) diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst index e5d2cf499..dbbdec1c7 100644 --- a/

[dpdk-dev] [PATCH v4 0/1] doc: document vfio-pci usage with QAT PMD

2020-10-12 Thread Adam Dybkowski
ernels 5.9 and later. v2: * add example command with disable_denylist option v3: * simplify binding/unbinding command examples by using python scripts * remove the description of old binding method v4: * rebase Adam Dybkowski (1): doc: document vfio-pci usage with QAT PMD doc/guides/cryptode

[dpdk-dev] [PATCH v2 0/1] cryptodev: remove v20 ABI compatibility

2020-10-08 Thread Adam Dybkowski
This reverts commit cryptodev: fix ABI compatibility for ChaCha20-Poly1305 as the rte_cryptodev_info_get function versioning was a temporary solution to maintain ABI compatibility for ChaCha20-Poly1305 and is not needed in 20.11. Adam Dybkowski (1): cryptodev: remove v20 ABI compatibility

[dpdk-dev] [PATCH v2 1/1] cryptodev: remove v20 ABI compatibility

2020-10-08 Thread Adam Dybkowski
y1305") Signed-off-by: Adam Dybkowski Reviewed-by: Arek Kusztal Acked-by: Arek Kusztal --- lib/librte_cryptodev/meson.build | 1 - lib/librte_cryptodev/rte_cryptodev.c | 150 +- lib/librte_cryptodev/rte_cryptodev.h | 34 +--- .../rte_cryptodev_v

[dpdk-dev] [PATCH v2 0/1] crypto/scheduler: rename slave to worker

2020-09-28 Thread Adam Dybkowski
, the configuration value RTE_CRYPTODEV_SCHEDULER_MAX_NB_SLAVES was renamed to RTE_CRYPTODEV_SCHEDULER_MAX_NB_WORKERS. Adam Dybkowski (1): crypto/scheduler: rename slave to worker --- v2: Update release notes. Remove deprecation notice. --- app/test-crypto-perf/main.c | 2 +- app/test/test_cryptodev.c

[dpdk-dev] [PATCH v2 1/1] crypto/scheduler: rename slave to worker

2020-09-28 Thread Adam Dybkowski
, the configuration value RTE_CRYPTODEV_SCHEDULER_MAX_NB_SLAVES was renamed to RTE_CRYPTODEV_SCHEDULER_MAX_NB_WORKERS. Signed-off-by: Adam Dybkowski Acked-by: Fan Zhang --- app/test-crypto-perf/main.c | 2 +- app/test/test_cryptodev.c | 20 +- doc/guides/cryptodevs/qat.rst

[dpdk-dev] [PATCH v3 0/1] doc: document vfio-pci usage with QAT PMD

2020-09-15 Thread Adam Dybkowski
ernels 5.9 and later. v2: * add example command with disable_denylist option v3: * simplify binding/unbinding command examples by using python scripts * remove the description of old binding method Adam Dybkowski (1): doc: document vfio-pci usage with QAT PMD doc/guides/cryptodevs/qa

[dpdk-dev] [PATCH v3 1/1] doc: document vfio-pci usage with QAT PMD

2020-09-15 Thread Adam Dybkowski
ernels 5.9 and later. Signed-off-by: Adam Dybkowski --- doc/guides/cryptodevs/qat.rst | 63 +++ 1 file changed, 34 insertions(+), 29 deletions(-) diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst index e5d2cf499..dbbdec1c7 100644 --- a/

[dpdk-dev] [PATCH v2 0/1] doc: document vfio-pci usage with QAT PMD

2020-09-08 Thread Adam Dybkowski
ernels 5.9 and later. v2: * add example command with disable_denylist option Adam Dybkowski (1): doc: document vfio-pci usage with QAT PMD doc/guides/cryptodevs/qat.rst | 36 --- 1 file changed, 25 insertions(+), 11 deletions(-) -- 2.25.1

[dpdk-dev] [PATCH v2 1/1] doc: document vfio-pci usage with QAT PMD

2020-09-08 Thread Adam Dybkowski
ernels 5.9 and later. Signed-off-by: Adam Dybkowski Acked-by: Fiona Trahe --- doc/guides/cryptodevs/qat.rst | 36 --- 1 file changed, 25 insertions(+), 11 deletions(-) diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst index e5d2cf499.

[dpdk-dev] [PATCH] doc: document vfio-pci usage with QAT PMD

2020-09-08 Thread Adam Dybkowski
ernels 5.9 and later. Signed-off-by: Adam Dybkowski --- doc/guides/cryptodevs/qat.rst | 33 ++--- 1 file changed, 22 insertions(+), 11 deletions(-) diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst index e5d2cf499..bd4743aa7 100644 --- a/

[dpdk-dev] [PATCH] crypto/scheduler: rename slave to worker

2020-08-26 Thread Adam Dybkowski
, the configuration value RTE_CRYPTODEV_SCHEDULER_MAX_NB_SLAVES was renamed to RTE_CRYPTODEV_SCHEDULER_MAX_NB_WORKERS. Signed-off-by: Adam Dybkowski --- app/test-crypto-perf/main.c | 2 +- app/test/test_cryptodev.c | 20 +- doc/guides/cryptodevs/qat.rst | 2 +- doc/guides

[dpdk-dev] [PATCH] cryptodev: revert ABI compatibility for ChaCha20-Poly1305

2020-08-14 Thread Adam Dybkowski
y1305") Signed-off-by: Adam Dybkowski Reviewed-by: Arek Kusztal --- lib/librte_cryptodev/meson.build | 1 - lib/librte_cryptodev/rte_cryptodev.c | 147 +- lib/librte_cryptodev/rte_cryptodev.h | 34 +--- .../rte_cryptodev_version.map

[dpdk-dev] [PATCH v5 2/2] doc: update QAT PMD release notes

2020-07-27 Thread Adam Dybkowski
This patch updates 20.08 release notes inside the part that describe changes in Intel QuickAssist PMD. Fixes: faa57df0b458 ("crypto/qat: support ChaCha20-Poly1305") Fixes: 9904ff684981 ("common/qat: improve multi-process handling") Signed-off-by: Adam Dybkowski Acked-by: F

[dpdk-dev] [PATCH v5 1/2] common/qat: support GEN2 QAT device 200xx

2020-07-27 Thread Adam Dybkowski
This adds pci detection and documentation for Intel GEN2 QuickAssist device 200xx (PF Did 0x18ee, VF Did 0x18ef). Signed-off-by: Adam Dybkowski Acked-by: Fiona Trahe --- doc/guides/cryptodevs/qat.rst | 7 +-- doc/guides/rel_notes/release_20_08.rst | 2 ++ drivers/common/qat

[dpdk-dev] [PATCH v5 0/2] common/qat: support GEN2 QAT device 200xx

2020-07-27 Thread Adam Dybkowski
This adds pci detection and documentation for Intel GEN2 QuickAssist device 200xx (PF Did 0x18ee, VF Did 0x18ef). v2: * rename the device v3: * improve release notes v4: * simplify release notes v5: * split actual implementation patch and additional release notes update Adam Dybkowski (2

[dpdk-dev] [PATCH] doc: scheduler API deprecation notice

2020-07-27 Thread Adam Dybkowski
This patch adds a deprecation notice about upcoming changes in public API of the Scheduler PMD. Signed-off-by: Adam Dybkowski Acked-by: Fan Zhang --- doc/guides/rel_notes/deprecation.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc

[dpdk-dev] [PATCH] common/qat: fix uninitialized variable bug

2020-07-24 Thread Adam Dybkowski
This patch fixes the uninitialized variable bug in QAT PMD. Fixes: 9f27a860dc16 ("crypto/qat: move generic qp function to qp file") Signed-off-by: Adam Dybkowski --- drivers/common/qat/qat_qp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/common/qat/

[dpdk-dev] [PATCH] crypto/scheduler: replace usage of master/slave

2020-07-22 Thread Adam Dybkowski
This patch replaces the usage of master/slave in QAT PMD and Scheduler PMD as well as in their docs. Also the test app was modified to use the new wording. Signed-off-by: Adam Dybkowski --- app/test/test_cryptodev.c | 16 +- doc/guides/cryptodevs/qat.rst

[dpdk-dev] [PATCH v4 0/1] common/qat: support GEN2 QAT device 200xx

2020-07-22 Thread Adam Dybkowski
This adds pci detection and documentation for Intel GEN2 QuickAssist device 200xx (PF Did 0x18ee, VF Did 0x18ef). v2: * rename the device v3: * improve release notes v4: * simplify release notes Adam Dybkowski (1): common/qat: support GEN2 QAT device 200xx doc/guides/cryptodevs/qat.rst

[dpdk-dev] [PATCH v4 1/1] common/qat: support GEN2 QAT device 200xx

2020-07-22 Thread Adam Dybkowski
This adds pci detection and documentation for Intel GEN2 QuickAssist device 200xx (PF Did 0x18ee, VF Did 0x18ef). Signed-off-by: Adam Dybkowski --- doc/guides/cryptodevs/qat.rst | 7 +-- doc/guides/rel_notes/release_20_08.rst | 8 +--- drivers/common/qat/qat_device.c| 6

[dpdk-dev] [PATCH] common/qat: remove unused fields

2020-07-21 Thread Adam Dybkowski
This patch removes unused fields from structs qat_qp and qat_qp_config, together with their initializations. Signed-off-by: Adam Dybkowski --- drivers/common/qat/qat_qp.c | 1 - drivers/common/qat/qat_qp.h | 8 +--- drivers/compress/qat/qat_comp_pmd.c | 1 - drivers/crypto

[dpdk-dev] [PATCH v3 2/2] doc: update QAT PMD release notes

2020-07-16 Thread Adam Dybkowski
This patch separates QAT PMD paragraphs in the release notes into three parts, for QAT Symmetric Crypto PMD, QAT Asymmetric Crypto PMD and QAT Compression PMD. Signed-off-by: Adam Dybkowski --- doc/guides/rel_notes/release_20_08.rst | 10 +- 1 file changed, 9 insertions(+), 1 deletion

[dpdk-dev] [PATCH v3 1/2] common/qat: support GEN2 QAT device 200xx

2020-07-16 Thread Adam Dybkowski
This adds pci detection and documentation for Intel GEN2 QuickAssist device 200xx (PF Did 0x18ee, VF Did 0x18ef). Signed-off-by: Adam Dybkowski --- doc/guides/cryptodevs/qat.rst | 7 +-- doc/guides/rel_notes/release_20_08.rst | 2 ++ drivers/common/qat/qat_device.c| 6

[dpdk-dev] [PATCH v3 0/2] common/qat: support GEN2 QAT device 200xx

2020-07-16 Thread Adam Dybkowski
This adds pci detection and documentation for Intel GEN2 QuickAssist device 200xx (PF Did 0x18ee, VF Did 0x18ef). Adam Dybkowski (2): common/qat: support GEN2 QAT device 200xx doc: update QAT PMD release notes doc/guides/cryptodevs/qat.rst | 7 +-- doc/guides/rel_notes

[dpdk-dev] [PATCH] doc: update QAT driver version for D15xx

2020-07-16 Thread Adam Dybkowski
This patch updates the minimum driver version that supports Intel QuickAssist device D15xx. Signed-off-by: Adam Dybkowski --- doc/guides/cryptodevs/qat.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst index

[dpdk-dev] [PATCH v2 0/1] compress/qat: revert change in GEN3 marketing name

2020-07-13 Thread Adam Dybkowski
The patch reverts the commit that updated Intel QuickAssist GEN3 marketing name. The change was not backported and has to be withdrawn. v2: * add cover letter with more explanation Adam Dybkowski (1): compress/qat: revert change in GEN3 marketing name doc/guides/cryptodevs/qat.rst | 6

[dpdk-dev] [PATCH v2 1/1] compress/qat: revert change in GEN3 marketing name

2020-07-13 Thread Adam Dybkowski
This reverts commit 9cd9d3e702fba4700539c1a2eddac13dd14ecf70. Signed-off-by: Adam Dybkowski --- doc/guides/cryptodevs/qat.rst | 6 +++--- drivers/compress/qat/qat_comp_pmd.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides

[dpdk-dev] [PATCH v2 1/1] common/qat: support GEN2 QAT device 200xx

2020-07-13 Thread Adam Dybkowski
This adds pci detection and documentation for Intel GEN2 QuickAssist device 200xx (PF Did 0x18ee, VF Did 0x18ef). Signed-off-by: Adam Dybkowski --- doc/guides/compressdevs/qat_comp.rst | 3 ++- doc/guides/cryptodevs/qat.rst | 8 ++-- doc/guides/rel_notes/release_20_08.rst | 5

[dpdk-dev] [PATCH v2 0/1] common/qat: support GEN2 QAT device 200xx

2020-07-13 Thread Adam Dybkowski
This adds pci detection and documentation for Intel GEN2 QuickAssist device 200xx (PF Did 0x18ee, VF Did 0x18ef). -- v2: * update the marketing name Adam Dybkowski (1): common/qat: support GEN2 QAT device 200xx doc/guides/compressdevs/qat_comp.rst | 3 ++- doc/guides/cryptodevs/qat.rst

[dpdk-dev] [PATCH] crypto/qat: fix AES-XTS capabilities

2020-06-26 Thread Adam Dybkowski
This patch fixes the increment field of the AES-XTS cipher key size. Fixes: 7d5ef3bb32cd ("crypto/qat: support XTS") Cc: sta...@dpdk.org Signed-off-by: Adam Dybkowski --- drivers/crypto/qat/qat_sym_capabilities.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[dpdk-dev] [PATCH] common/qat: support GEN2 device C34xx

2020-06-09 Thread Adam Dybkowski
This adds pci detection and documentation for Intel GEN2 QuickAssist device C34xx (PF Did 0x18ee, VF Did 0x18ef). Signed-off-by: Adam Dybkowski --- doc/guides/compressdevs/qat_comp.rst | 3 ++- doc/guides/cryptodevs/qat.rst | 8 ++-- doc/guides/rel_notes/release_20_08.rst | 5

[dpdk-dev] [PATCH] compress/qat: revert change in GEN3 marketing name

2020-06-08 Thread Adam Dybkowski
This reverts commit 9cd9d3e702fba4700539c1a2eddac13dd14ecf70. Signed-off-by: Adam Dybkowski --- doc/guides/cryptodevs/qat.rst | 6 +++--- drivers/compress/qat/qat_comp_pmd.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides

[dpdk-dev] [PATCH 2/3] cryptodev: verify session mempool element size

2020-06-08 Thread Adam Dybkowski
This patch adds the verification of the element size of the mempool provided for the session creation. Returns the error if the element size is too small to hold the session object. Signed-off-by: Adam Dybkowski --- lib/librte_cryptodev/rte_cryptodev.c | 45 +++- 1 file

[dpdk-dev] [PATCH 3/3] crypto/qat: verify session IOVA

2020-06-08 Thread Adam Dybkowski
This patch adds the verification of the crypto session IOVA that should be known (not zero) to proceed with the session initialisation. In case of unknown IOVA the error code -EINVAL is returned. Signed-off-by: Adam Dybkowski --- drivers/crypto/qat/qat_sym_session.c | 10 +- 1 file

[dpdk-dev] [PATCH 1/3] test/crypto: fix asym session mempool creation

2020-06-08 Thread Adam Dybkowski
This patch fixes the element size of the mempool used for allocating asym crypto sessions and their private data. Fixes: 2c6dab9cd93d ("test/crypto: add RSA and Mod tests") Cc: sta...@dpdk.org Signed-off-by: Adam Dybkowski --- app/test/test_cryptodev_asym.c | 5 +++-- 1 file

[dpdk-dev] [PATCH v4 1/1] cryptodev: fix SHA-1 digest enum comment

2020-05-21 Thread Adam Dybkowski
This patch fixes improper SHA-1 digest size in the enum comment and also adds the note about HMAC-SHA-1-96. Fixes: 1bd407fac80b ("cryptodev: extract symmetric operations") Cc: sta...@dpdk.org Signed-off-by: Adam Dybkowski Acked-by: Fiona Trahe Acked-by: Anoob Joseph --- lib/librte

[dpdk-dev] [PATCH v4 0/1] cryptodev: fix SHA-1 digest enum comment

2020-05-21 Thread Adam Dybkowski
This patch fixes improper SHA-1 digest size in the enum comment and also adds the note about HMAC-SHA-1-96. v2: * add info about HMAC-SHA-1-96 v3: * fix multi-line comment formatting v4: * fix wording Adam Dybkowski (1): cryptodev: fix SHA-1 digest enum comment lib/librte_cryptodev

[dpdk-dev] [PATCH v3 1/1] cryptodev: fix SHA-1 digest enum comment

2020-05-21 Thread Adam Dybkowski
This patch fixes improper SHA-1 digest size in the enum comment and also adds the note about HMAC-SHA-1-96. Fixes: 1bd407fac80b ("cryptodev: extract symmetric operations") Cc: sta...@dpdk.org Signed-off-by: Adam Dybkowski --- lib/librte_cryptodev/rte_crypto_sym.h | 6 -- 1 file

[dpdk-dev] [PATCH v3 0/1] cryptodev: fix SHA-1 digest enum comment

2020-05-21 Thread Adam Dybkowski
This patch fixes improper SHA-1 digest size in the enum comment and also adds the note about HMAC-SHA-1-96. v2: * add info about HMAC-SHA-1-96 v3: * fix multi-line comment formatting Adam Dybkowski (1): cryptodev: fix SHA-1 digest enum comment lib/librte_cryptodev/rte_crypto_sym.h | 6

[dpdk-dev] [PATCH v2 0/1] cryptodev: fix SHA-1 digest enum comment

2020-05-19 Thread Adam Dybkowski
This patch fixes improper SHA-1 digest size in the enum comment and also adds the note about HMAC-SHA-1-96. v2: * add info about HMAC-SHA-1-96 Adam Dybkowski (1): cryptodev: fix SHA-1 digest enum comment lib/librte_cryptodev/rte_crypto_sym.h | 5 +++-- 1 file changed, 3 insertions(+), 2

[dpdk-dev] [PATCH v2 1/1] cryptodev: fix SHA-1 digest enum comment

2020-05-19 Thread Adam Dybkowski
This patch fixes improper SHA-1 digest size in the enum comment and also adds the note about HMAC-SHA-1-96. Fixes: 1bd407fac80b ("cryptodev: extract symmetric operations") Cc: sta...@dpdk.org Signed-off-by: Adam Dybkowski --- lib/librte_cryptodev/rte_crypto_sym.h | 5 +++-- 1 file

[dpdk-dev] [PATCH] cryptodev: fix SHA-1 digest enum comment

2020-05-18 Thread Adam Dybkowski
This patch fixes improper SHA-1 digest size in the enum comment. Fixes: 1bd407fac80b ("cryptodev: extract symmetric operations") Cc: sta...@dpdk.org Signed-off-by: Adam Dybkowski --- lib/librte_cryptodev/rte_crypto_sym.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) di

[dpdk-dev] [PATCH] common/qat: fix coverity issue

2020-05-06 Thread Adam Dybkowski
This patch fixes Coverity issue #357770 by removing the non-essential check for NULL pointer. Fixes: c13cecf60f12 ("compress/qat: support IM buffer too small operation") Signed-off-by: Adam Dybkowski --- drivers/common/qat/qat_qp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletio

[dpdk-dev] [PATCH] common/qat: fix stats update

2020-05-06 Thread Adam Dybkowski
rt IM buffer too small operation") Signed-off-by: Adam Dybkowski --- Requires applying other patch first: http://patches.dpdk.org/patch/69765/ --- drivers/common/qat/qat_qp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/common/qat/qat_qp.c b/drivers/

[dpdk-dev] [PATCH] common/qat: fix queue head update

2020-05-05 Thread Adam Dybkowski
This patch fixes missing queue head update that occured when a multiple-request dynamic Huffman compression operation was not complete within one qat_dequeue_op_burst function call. Fixes: c13cecf60f12 ("compress/qat: support IM buffer too small operation") Signed-off-by: Adam

[dpdk-dev] [PATCH] app/crypto-perf: fix display of sample test vector

2020-04-29 Thread Adam Dybkowski
ation") Cc: sta...@dpdk.org Signed-off-by: Adam Dybkowski --- app/test-crypto-perf/main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/test-crypto-perf/main.c b/app/test-crypto-perf/main.c index 52a1860fb..7bb286ccb 100644 --- a/app/test-crypto-perf/main.c +++

[dpdk-dev] [PATCH v3 2/2] test/compress: im buffer too small - add unit tests

2020-04-17 Thread Adam Dybkowski
This patch adds new tests for verification of the "internal QAT IM buffer too small" case handling. These unit tests aren't specific to the QAT PMD only - they pass or skip on other PMDs like ISAL and ZLIB (depending on particular PMD capabilities). Signed-off-by: Adam Dybkowski

[dpdk-dev] [PATCH v3 1/2] compress/qat: im buffer too small - split op

2020-04-17 Thread Adam Dybkowski
their results are then combined and copied into the output buffer. This is not possible if any checksum calculation was requested - in such case the code falls back to fixed compression as before. Signed-off-by: Adam Dybkowski Acked-by: Fiona Trahe --- doc/guides/compressdevs/qat_comp.rst | 3

[dpdk-dev] [PATCH v3 0/2] compress/qat: im buffer too small - split op

2020-04-17 Thread Adam Dybkowski
adding a new test suite separate for QAT-specific tests Adam Dybkowski (2): compress/qat: im buffer too small - split op test/compress: im buffer too small - add unit tests app/test/test_compressdev.c| 1185 ++-- doc/guides/compressdevs/qat_comp.rst |3 - doc

[dpdk-dev] [PATCH v2 1/1] crypto/qat: support plain SHA1..SHA512 hashes

2020-04-16 Thread Adam Dybkowski
This patch adds support for plain SHA-1, SHA-224, SHA-256, SHA-384 and SHA-512 hashes to QAT PMD. Signed-off-by: Adam Dybkowski Acked-by: Fiona Trahe --- doc/guides/cryptodevs/features/qat.ini| 5 + doc/guides/cryptodevs/qat.rst | 5 + doc/guides/rel_notes/release_20_05.rst

[dpdk-dev] [PATCH v2 0/1] crypto/qat: support plain SHA1..SHA512 hashes

2020-04-16 Thread Adam Dybkowski
This patch adds support for plain SHA-1, SHA-224, SHA-256, SHA-384 and SHA-512 hashes to QAT PMD. v2: * simplify the tests, rebase the code on top of Pablo De Lara Guarch patches * update the release notes Adam Dybkowski (1): crypto/qat: support plain SHA1..SHA512 hashes doc/guides

[dpdk-dev] [PATCH] crypto/qat: support plain SHA1..SHA512 hashes

2020-04-14 Thread Adam Dybkowski
This patch adds support for plain SHA-1, SHA-224, SHA-256, SHA-384 and SHA-512 hashes to QAT PMD. Signed-off-by: Adam Dybkowski --- app/test/test_cryptodev_hash_test_vectors.h | 10 ++ doc/guides/cryptodevs/features/qat.ini | 5 + doc/guides/cryptodevs/qat.rst | 5

[dpdk-dev] [PATCH v2 2/2] test/compress: im buffer too small - add unit tests

2020-04-08 Thread Adam Dybkowski
This patch adds a new test suite for verification of the "internal QAT IM buffer too small" case handling. These unit tests are specific to the QAT PMD only - that's why they are contained in a separate test suite. Signed-off-by: Adam Dybkowski --- app/test/test_compr

[dpdk-dev] [PATCH v2 1/2] compress/qat: im buffer too small - split op

2020-04-08 Thread Adam Dybkowski
their results are then combined and copied into the output buffer. This is not possible if any checksum calculation was requested - in such case the code falls back to fixed compression as before. Signed-off-by: Adam Dybkowski --- doc/guides/compressdevs/qat_comp.rst | 3 - doc/guides

[dpdk-dev] [PATCH v2 0/2] compress/qat: im buffer too small - split op

2020-04-08 Thread Adam Dybkowski
their results are then combined and copied into the output buffer. This is not possible if any checksum calculation was requested - in such case the code falls back to fixed compression as before. v2: * various post-review small fixes Adam Dybkowski (2): compress/qat: im buffer too small - split

[dpdk-dev] [PATCH v4 0/2] crypto/qat: handle mixed hash-cipher crypto on GEN2 QAT

2020-03-26 Thread Adam Dybkowski
documentation Adam Dybkowski (2): common/qat: get version of QAT firmware crypto/qat: handle mixed hash-cipher crypto on GEN2 QAT doc/guides/cryptodevs/qat.rst | 13 ++-- doc/guides/rel_notes/release_20_05.rst | 7 ++ drivers/common/qat/qat_adf/icp_qat_fw.h | 2 + drivers/common

[dpdk-dev] [PATCH v4 1/2] common/qat: get version of QAT firmware

2020-03-26 Thread Adam Dybkowski
This patch adds the function for retrieving QAT firmware version, required to check the internal capabilities that depend on the FW version. Signed-off-by: Adam Dybkowski --- drivers/common/qat/qat_adf/icp_qat_fw.h | 2 + drivers/common/qat/qat_qp.c | 93

[dpdk-dev] [PATCH v4 2/2] crypto/qat: handle mixed hash-cipher crypto on GEN2 QAT

2020-03-26 Thread Adam Dybkowski
This patch adds handling of mixed hash-cipher algorithms available on GEN2 QAT in particular firmware versions. Also the documentation is updated to show the mixed crypto algorithms are supported on QAT GEN2. Signed-off-by: Adam Dybkowski --- doc/guides/cryptodevs/qat.rst | 13

[dpdk-dev] [PATCH 2/2] test/compress: im buffer too small - add unit tests

2020-03-18 Thread Adam Dybkowski
This patch adds new test suites for verification of the "internal QAT IM buffer too small" case handling. These unit tests are specific to the QAT PMD only - that's why they are contained in new test suites (separate for positive and negative tests for better maintability). Sign

[dpdk-dev] [PATCH 1/2] drivers/qat: im buffer too small - split op

2020-03-18 Thread Adam Dybkowski
their results are then combined and copied into the output buffer. This is not possible if any checksum calculation was requested - in such case the code falls back to fixed compression as before. Signed-off-by: Adam Dybkowski --- drivers/common/qat/qat_qp.c | 231 -- drivers

[dpdk-dev] [PATCH v3 0/2] crypto/qat: handle mixed hash-cipher crypto on GEN2 QAT

2020-03-16 Thread Adam Dybkowski
This patch set adds handling of mixed hash-cipher algorithms available on GEN2 QAT in particular firmware versions. Also the documentation is updated to show the mixed crypto algorithms are supported on QAT GEN2. v2: * minor fixes and improvements v3: * include missing header file Adam

[dpdk-dev] [PATCH v3 1/2] common/qat: get version of QAT firmware

2020-03-16 Thread Adam Dybkowski
This patch adds the function for retrieving QAT firmware version, required to check the internal capabilities that depend on the FW version. Signed-off-by: Adam Dybkowski --- drivers/common/qat/qat_adf/icp_qat_fw.h | 2 + drivers/common/qat/qat_qp.c | 93

[dpdk-dev] [PATCH v3 2/2] crypto/qat: handle mixed hash-cipher crypto on GEN2 QAT

2020-03-16 Thread Adam Dybkowski
This patch adds handling of mixed hash-cipher algorithms available on GEN2 QAT in particular firmware versions. Also the documentation is updated to show the mixed crypto algorithms are supported on QAT GEN2. Signed-off-by: Adam Dybkowski --- doc/guides/cryptodevs/qat.rst | 9

[dpdk-dev] [PATCH v2 2/2] crypto/qat: handle mixed hash-cipher crypto on GEN2 QAT

2020-03-13 Thread Adam Dybkowski
This patch adds handling of mixed hash-cipher algorithms available on GEN2 QAT in particular firmware versions. Also the documentation is updated to show the mixed crypto algorithms are supported on QAT GEN2. Signed-off-by: Adam Dybkowski --- doc/guides/cryptodevs/qat.rst | 9

[dpdk-dev] [PATCH v2 1/2] common/qat: get version of QAT firmware

2020-03-13 Thread Adam Dybkowski
This patch adds the function for retrieving QAT firmware version, required to check the internal capabilities that depend on the FW version. Signed-off-by: Adam Dybkowski --- drivers/common/qat/qat_adf/icp_qat_fw.h | 2 + drivers/common/qat/qat_qp.c | 92

[dpdk-dev] [PATCH v2 0/2] crypto/qat: handle mixed hash-cipher crypto on GEN2 QAT

2020-03-13 Thread Adam Dybkowski
This patch set adds handling of mixed hash-cipher algorithms available on GEN2 QAT in particular firmware versions. Also the documentation is updated to show the mixed crypto algorithms are supported on QAT GEN2. v2: * minor fixes and improvements Adam Dybkowski (2): common/qat: get version of

[dpdk-dev] [PATCH 1/2] common/qat: get version of QAT firmware

2020-03-12 Thread Adam Dybkowski
This patch adds the function for retrieving QAT firmware version, required to check the internal capabilities that depend on the FW version. Signed-off-by: Adam Dybkowski --- drivers/common/qat/qat_adf/icp_qat_fw.h | 2 + drivers/common/qat/qat_qp.c | 89

[dpdk-dev] [PATCH 2/2] crypto/qat: handle mixed hash-cipher crypto on GEN2 QAT

2020-03-12 Thread Adam Dybkowski
This patch adds handling of mixed hash-cipher algorithms available on GEN2 QAT in particular firmware versions. Also the documentation is updated to show the mixed crypto algorithms are supported on QAT GEN2. Signed-off-by: Adam Dybkowski --- doc/guides/cryptodevs/qat.rst | 9

[dpdk-dev] [PATCH 3/3] common/qat: optimise calculation of cookie index

2020-03-11 Thread Adam Dybkowski
From: Fiona Trahe Avoid costly division, use shift instead. Signed-off-by: Fiona Trahe --- drivers/common/qat/qat_qp.c | 9 ++--- drivers/common/qat/qat_qp.h | 1 + 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/common/qat/qat_qp.c b/drivers/common/qat/qat_qp.c inde

[dpdk-dev] [PATCH 2/3] crypto/qat: optimise check for chained mbufs

2020-03-11 Thread Adam Dybkowski
From: Fiona Trahe To detect if sgl, use nb_segs > 1, instead of checking for next pointer, as nb_segs is in first cache-line while next is in second cache-line. Signed-off-by: Fiona Trahe --- drivers/crypto/qat/qat_sym.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dri

[dpdk-dev] [PATCH 1/3] crypto/qat: improve out-of-place conditional check

2020-03-11 Thread Adam Dybkowski
From: Fiona Trahe Improve case where application set m_dst to same as m_src so really an in-place operation, though would have been treated as out-of-place. No functional change but this path can now benefit from DMA alignment. Signed-off-by: Fiona Trahe --- drivers/crypto/qat/qat_sym.c | 8 ++

[dpdk-dev] [PATCH 2/2] doc: fix QAT GEN3 marketing name in release notes

2020-03-04 Thread Adam Dybkowski
This patch fixes the marketing name of the QAT GEN3 to P5xxx. Fixes: aa983f03ad2e ("crypto/qat: handle Single Pass Crypto Requests on GEN3") Cc: sta...@dpdk.org Signed-off-by: Adam Dybkowski --- doc/guides/rel_notes/release_19_11.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletio

[dpdk-dev] [PATCH 1/2] compress/qat: fix QAT GEN3 marketing name

2020-03-04 Thread Adam Dybkowski
Cc: sta...@dpdk.org Signed-off-by: Adam Dybkowski --- doc/guides/cryptodevs/qat.rst | 6 +++--- drivers/compress/qat/qat_comp_pmd.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst index 06985e319..1e83ed626 100

[dpdk-dev] [PATCH] cryptodev: fix missing device id range checking

2020-02-20 Thread Adam Dybkowski
This patch adds range-checking of the device id passed from the user app code. It prevents out-of-range array accesses which in some situations resulted in an application crash (segfault). Fixes: 3dd4435cf473 ("cryptodev: fix checks related to device id") Cc: sta...@dpdk.org Signed-of

[dpdk-dev] [PATCH v2 0/1] test/crypto: remove repeated test and enable on QAT

2020-01-22 Thread Adam Dybkowski
Remove one AES GCM scatter-gather unit test repetition and enable this test on QAT (after a fix included in the commit b26ef1a11f21). --- v2: * Repair referenced commit id. Adam Dybkowski (1): test/crypto: remove repeated test and enable on QAT app/test/test_cryptodev.c | 7 --- 1 file

[dpdk-dev] [PATCH v2 1/1] test/crypto: remove repeated test and enable on QAT

2020-01-22 Thread Adam Dybkowski
Remove one AES GCM scatter-gather unit test repetition and enable this test on QAT (after a fix included in the commit b26ef1a11f21). Fixes: 157d0b11d204 ("test/crypto: add capability checks") Fixes: b26ef1a11f21 ("test/crypto: fix missing operation status check") Signed-of

[dpdk-dev] [PATCH] test/crypto: remove repeated test and enable on QAT

2020-01-21 Thread Adam Dybkowski
Remove one AES GCM scatter-gather unit test repetition and enable this test on QAT (after a fix included in the commit b26ef1a11f21). Fixes: 280dce9a0f6d ("test/crypto: add capability checks") Fixes: b26ef1a11f21 ("test/crypto: fix missing operation status check") Signed-of

[dpdk-dev] [PATCH v7 3/3] test/crypto: refactor unit tests into one combined array

2020-01-20 Thread Adam Dybkowski
these PMDs: null, aesni_mb, aesni_gcm, openssl, qat, sw_snow3g, sw_kasumi, sw_zuc. Signed-off-by: Adam Dybkowski --- app/test/test_cryptodev.c | 1132 +--- app/test/test_cryptodev_blockcipher.c |2 +- app/test/test_cryptodev_des_test_vectors.h |6 +- 3

  1   2   >