[PATCH v4] net/netvsc: fix number Tx queues > Rx queues

2024-04-15 Thread Alan Elder
receiving Tx completion messages. mbuf pool and Rx ring are not allocated for these additional Rx queues and RSS configuration ensures that no packets are received on them. Fixes: 4e9c73e96e83 ("net/netvsc: add Hyper-V network device") Cc: sthem...@microsoft.com Cc: sta...@dpdk.org Sig

RE: [EXTERNAL] Re: [PATCH v3] net/netvsc: fix number Tx queues > Rx queues

2024-04-12 Thread Alan Elder
> -Original Message- > From: Ferruh Yigit > Sent: Friday, April 12, 2024 6:23 AM > To: Alan Elder ; Long Li ; > Andrew Rybchenko > Cc: dev@dpdk.org; stephen > Subject: Re: [EXTERNAL] Re: [PATCH v3] net/netvsc: fix number Tx queues > Rx > queues > >

RE: [EXTERNAL] Re: [PATCH v3] net/netvsc: fix number Tx queues > Rx queues

2024-04-11 Thread Alan Elder
> -Original Message- > From: Ferruh Yigit > Sent: Thursday, April 11, 2024 7:38 AM > To: Alan Elder ; Long Li ; > Andrew Rybchenko > Cc: dev@dpdk.org; stephen > Subject: [EXTERNAL] Re: [PATCH v3] net/netvsc: fix number Tx queues > Rx > queues > > On 3/

RE: [PATCH v2] net/netvsc: fix number Tx queues > Rx queues

2024-03-19 Thread Alan Elder
ather than causing a segfault. Cheers, Alan > -Original Message- > From: Long Li > Sent: Tuesday, March 12, 2024 7:09 PM > To: Alan Elder ; Ferruh Yigit > ; Andrew Rybchenko > > Cc: dev@dpdk.org; stephen > Subject: RE: [PATCH v2] net/netvsc: fix number Tx queues >

[PATCH v3] net/netvsc: fix number Tx queues > Rx queues

2024-03-19 Thread Alan Elder
a...@dpdk.org Signed-off-by: Alan Elder --- v3: * Handle case of Rx queue creation failure in hn_dev_tx_queue_setup. * Re-use rx queue if it has already been allocated. * Don't allocate an mbuf if pool is NULL. This avoids segfault if RSS configuration is incorrect. v2: * Remove function decl

RE: [PATCH] net/netvsc: fix number Tx queues > Rx queues

2024-03-08 Thread Alan Elder
> Subject: RE: [PATCH] net/netvsc: fix number Tx queues > Rx queues > > > Subject: Re: [PATCH] net/netvsc: fix number Tx queues > Rx queues > > > > On Thu, 29 Feb 2024 19:29:11 + > > Alan Elder wrote: > > > > > The previous code allowed

[PATCH v2] net/netvsc: fix number Tx queues > Rx queues

2024-03-08 Thread Alan Elder
a...@dpdk.org Signed-off-by: Alan Elder --- v2: * Remove function declaration for static non-member function --- drivers/net/netvsc/hn_ethdev.c | 9 +++ drivers/net/netvsc/hn_rxtx.c | 46 +++--- 2 files changed, 52 insertions(+), 3 deletions(-) diff --git a/drive

[PATCH] net/netvsc: fix number Tx queues > Rx queues

2024-02-29 Thread Alan Elder
a...@dpdk.org Signed-off-by: Alan Elder --- drivers/net/netvsc/hn_ethdev.c | 9 drivers/net/netvsc/hn_rxtx.c | 40 ++ drivers/net/netvsc/hn_var.h| 1 + 3 files changed, 50 insertions(+) diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvs

RE: [EXTERNAL] Re: [PATCH v6] net/netvsc: fix parsing of VLAN metadata

2024-02-19 Thread Alan Elder
On 2/16/2024 11:40 AM, Ferruh Yigit: > I missed v6 but put some comment on v5, briefly can you please split the > patch for lib/net and driver? I've tried to split the patch - hopefully got the formatting right - please let me know if not (it's my first time submitting a patch and I don't have a

[PATCH v7 2/2] net/netvsc: fix parsing of VLAN metadata

2024-02-19 Thread Alan Elder
: add Hyper-V network device") Cc: sthem...@microsoft.com Cc: sta...@dpdk.org Signed-off-by: Alan Elder --- v7: * Split into two patches, one for lib and one for driver v6: * Line length can be 100 - un-split lines v5: * Move the VLAN parsing macros to rte_ether.h v4: * Make consistent with Fr

[PATCH v7 1/2] lib/net: fix parsing of VLAN metadata

2024-02-19 Thread Alan Elder
Add common macros for extracting parts of VLAN tag. Fixes: 4e9c73e96e83 ("net/netvsc: add Hyper-V network device") Cc: sthem...@microsoft.com Cc: sta...@dpdk.org Signed-off-by: Alan Elder --- v7: * Split patches for lib and driver v6: * Line length can be 100 - un-split lines v5:

[PATCH v7 0/2] fix parsing of VLAN metadata

2024-02-19 Thread Alan Elder
. Alan Elder (2): lib/net: fix parsing of VLAN metadata net/netvsc: fix parsing of VLAN metadata --- v7: * Split patches for lib and driver v6: * Line length can be 100 - un-split lines v5: * Move the VLAN parsing macros to rte_ether.h v4: * Make consistent with FreeBSD code --- .mailmap

[PATCH v6] net/netvsc: fix parsing of VLAN metadata

2024-02-16 Thread Alan Elder
: add Hyper-V network device") Cc: sthem...@microsoft.com Cc: sta...@dpdk.org Signed-off-by: Alan Elder --- V6: * Line length can be 100 - un-split lines v5: * Move the VLAN parsing macros to rte_ether.h v4: * Make consistent with FreeBSD code --- .mailmap | 1 + drivers/

[PATCH v5] net/netvsc: fix parsing of VLAN metadata

2024-02-15 Thread Alan Elder
: add Hyper-V network device") Cc: sthem...@microsoft.com Cc: sta...@dpdk.org Signed-off-by: Alan Elder --- v5: * Move the VLAN parsing macros to rte_ether.h v4: * Make consistent with FreeBSD code --- .mailmap | 1 + drivers/net/netvsc/hn_rxtx.c | 8 ++-- lib/net/r

[PATCH v4] net/netvsc: fix parsing of VLAN metadata

2024-02-09 Thread Alan Elder
: add Hyper-V network device") Cc: sthem...@microsoft.com Cc: sta...@dpdk.org Signed-off-by: Alan Elder --- v4: * Make consistent with FreeBSD code .mailmap | 1 + drivers/net/netvsc/hn_rxtx.c | 21 +++-- 2 files changed, 20 insertions(+), 2 deletions(-) di

RE: [PATCH v2] net/netvsc: fix parsing of VLAN metadata

2024-02-09 Thread Alan Elder
-Original Message- From: Long Li Sent: Friday, February 9, 2024 1:14 AM To: stephen ; Alan Elder Cc: dev@dpdk.org Subject: RE: [PATCH v2] net/netvsc: fix parsing of VLAN metadata > > Most of this driver came from FreeBSD. Did you look there to make sure > naming is the

[PATCH v3] net/netvsc: fix parsing of VLAN metadata

2024-02-08 Thread Alan Elder
Linux netvsc driver and defines an explicit structure to use for parsing. Fixes: 4e9c73e96e83 ("net/netvsc: add Hyper-V network device") Cc: sthem...@microsoft.com Cc: sta...@dpdk.org Signed-off-by: Alan Elder --- .mailmap | 1 + drivers/net/netvsc/hn_r

[PATCH v2] net/netvsc: fix parsing of VLAN metadata

2024-02-08 Thread Alan Elder
Linux netvsc driver and defines an explicit structure to use for parsing. Fixes: 4e9c73e96e83 ("net/netvsc: add Hyper-V network device") Cc: sthem...@microsoft.com Cc: sta...@dpdk.org Signed-off-by: Alan Elder --- .mailmap | 1 + drivers/net/netvsc/hn_r

[PATCH] net/netvsc: fix parsing of VLAN metadata

2024-02-08 Thread Alan Elder
Linux netvsc driver and defines an explicit structure to use for parsing. Fixes: 4e9c73e96e83 ("net/netvsc: add Hyper-V network device") Cc: sthem...@microsoft.com<mailto:sthem...@microsoft.com> Cc: sta...@dpdk.org<mailto:sta...@dpdk.org> Signed-off-by: Alan Elder al