Re: [PATCH v2] PCI: Explicitly put devices into D0 when initializing

2025-06-11 Thread Alex Williamson
On Wed, 11 Jun 2025 07:56:21 -0700 Mario Limonciello wrote: > On 6/11/2025 7:14 AM, Nicolas Dichtel wrote: > > Le 06/05/2025 à 01:06, Bjorn Helgaas a écrit : > >> On Wed, Apr 23, 2025 at 11:31:32PM -0500, Mario Limonciello wrote: > >>> From: Mario Limonciello > >>> > >>> AMD BIOS team has ro

Re: [dpdk-dev] [PATCH v3 0/7] vfio/pci: SR-IOV support

2020-03-19 Thread Alex Williamson
On Thu, 19 Mar 2020 06:32:25 + "Tian, Kevin" wrote: > > From: Alex Williamson > > Sent: Thursday, March 12, 2020 5:58 AM > > > > Only minor tweaks since v2, GET and SET on VFIO_DEVICE_FEATURE are > > enforced mutually exclusive except with the PROB

[dpdk-dev] [PATCH v3 5/7] vfio/pci: Add sriov_configure support

2020-03-11 Thread Alex Williamson
the host sysfs interface and the PF driver user cannot create or remove VFs. Signed-off-by: Alex Williamson --- drivers/vfio/pci/vfio_pci.c | 106 +++ drivers/vfio/pci/vfio_pci_private.h |2 + 2 files changed, 97 insertions(+), 11 deletions(-) diff --git

[dpdk-dev] [PATCH v3 6/7] vfio/pci: Remove dev_fmt definition

2020-03-11 Thread Alex Williamson
It currently results in messages like: "vfio-pci :03:00.0: vfio_pci: ..." Which is quite a bit redundant. Reviewed-by: Cornelia Huck Signed-off-by: Alex Williamson --- drivers/vfio/pci/vfio_pci.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/vfio/pci/vfio_pci.c

[dpdk-dev] [PATCH v3 7/7] vfio/pci: Cleanup .probe() exit paths

2020-03-11 Thread Alex Williamson
The cleanup is getting a tad long. Signed-off-by: Alex Williamson --- drivers/vfio/pci/vfio_pci.c | 54 --- 1 file changed, 25 insertions(+), 29 deletions(-) diff --git a/drivers/vfio/pci/vfio_pci.c b/drivers/vfio/pci/vfio_pci.c index af1ba9867201

[dpdk-dev] [PATCH v3 1/7] vfio: Include optional device match in vfio_device_ops callbacks

2020-03-11 Thread Alex Williamson
Allow bus drivers to provide their own callback to match a device to the user provided string. Reviewed-by: Cornelia Huck Signed-off-by: Alex Williamson --- drivers/vfio/vfio.c | 20 include/linux/vfio.h |4 2 files changed, 20 insertions(+), 4 deletions

[dpdk-dev] [PATCH v3 4/7] vfio: Introduce VFIO_DEVICE_FEATURE ioctl and first user

2020-03-11 Thread Alex Williamson
, whether the given operation on the feature is supported. The first user of this ioctl is for setting the vfio-pci VF token, where the user provides a shared secret key (UUID) on a SR-IOV PF device, which users must provide when opening associated VF devices. Signed-off-by: Alex Williamson

[dpdk-dev] [PATCH v3 2/7] vfio/pci: Implement match ops

2020-03-11 Thread Alex Williamson
This currently serves the same purpose as the default implementation but will be expanded for additional functionality. Reviewed-by: Cornelia Huck Signed-off-by: Alex Williamson --- drivers/vfio/pci/vfio_pci.c |8 1 file changed, 8 insertions(+) diff --git a/drivers/vfio/pci

[dpdk-dev] [PATCH v3 3/7] vfio/pci: Introduce VF token

2020-03-11 Thread Alex Williamson
ide of these cases will return an error, as discussed above. Signed-off-by: Alex Williamson --- drivers/vfio/pci/vfio_pci.c | 198 +++ drivers/vfio/pci/vfio_pci_private.h |8 + 2 files changed, 205 insertions(+), 1 deletion(-) diff --git a/drivers

[dpdk-dev] [PATCH v3 0/7] vfio/pci: SR-IOV support

2020-03-11 Thread Alex Williamson
ome/ v2: https://lore.kernel.org/lkml/158213716959.17090.8399427017403507114.st...@gimli.home/ --- Alex Williamson (7): vfio: Include optional device match in vfio_device_ops callbacks vfio/pci: Implement match ops vfio/pci: Introduce VF token vfio: Introduce VFIO_DEVICE_FEATURE

Re: [dpdk-dev] [PATCH v2 3/7] vfio/pci: Introduce VF token

2020-03-09 Thread Alex Williamson
On Mon, 9 Mar 2020 01:33:48 + "Tian, Kevin" wrote: > > From: Tian, Kevin > > Sent: Monday, March 9, 2020 9:22 AM > > > > > From: Alex Williamson > > > Sent: Monday, March 9, 2020 8:46 AM > > > > > > On Sat, 7 Mar 2020 0

Re: [dpdk-dev] [PATCH v2 5/7] vfio/pci: Add sriov_configure support

2020-03-09 Thread Alex Williamson
On Mon, 9 Mar 2020 01:48:11 + "Tian, Kevin" wrote: > > From: Alex Williamson > > Sent: Monday, March 9, 2020 8:46 AM > > > > On Sat, 7 Mar 2020 01:35:23 + > > "Tian, Kevin" wrote: > > > > > > From: Alex Williamson

Re: [dpdk-dev] [PATCH v2 0/7] vfio/pci: SR-IOV support

2020-03-09 Thread Alex Williamson
On Mon, 9 Mar 2020 11:36:46 +0800 Jason Wang wrote: > On 2020/3/7 上午12:24, Alex Williamson wrote: > > On Fri, 6 Mar 2020 11:35:21 +0800 > > Jason Wang wrote: > > > >> On 2020/3/6 上午1:14, Alex Williamson wrote: > >>> On Tue, 25 Feb 2

Re: [dpdk-dev] [PATCH v2 3/7] vfio/pci: Introduce VF token

2020-03-08 Thread Alex Williamson
On Sat, 7 Mar 2020 01:04:41 + "Tian, Kevin" wrote: > > From: Alex Williamson > > Sent: Friday, March 6, 2020 11:39 PM > > > > On Fri, 6 Mar 2020 08:32:40 + > > "Tian, Kevin" wrote: > > > > > > From: Alex Williamson

Re: [dpdk-dev] [PATCH v2 5/7] vfio/pci: Add sriov_configure support

2020-03-08 Thread Alex Williamson
On Sat, 7 Mar 2020 01:35:23 + "Tian, Kevin" wrote: > > From: Alex Williamson > > Sent: Saturday, March 7, 2020 6:18 AM > > > > On Fri, 6 Mar 2020 07:57:19 + > > "Tian, Kevin" wrote: > > > > > > From: Alex Williamson

Re: [dpdk-dev] [PATCH v2 5/7] vfio/pci: Add sriov_configure support

2020-03-06 Thread Alex Williamson
On Fri, 6 Mar 2020 07:57:19 + "Tian, Kevin" wrote: > > From: Alex Williamson > > Sent: Friday, March 6, 2020 2:23 AM > > > > On Tue, 25 Feb 2020 03:08:00 + > > "Tian, Kevin" wrote: > > > > > > Fro

Re: [dpdk-dev] [PATCH v2 0/7] vfio/pci: SR-IOV support

2020-03-06 Thread Alex Williamson
On Fri, 6 Mar 2020 11:35:21 +0800 Jason Wang wrote: > On 2020/3/6 上午1:14, Alex Williamson wrote: > > On Tue, 25 Feb 2020 14:09:07 +0800 > > Jason Wang wrote: > > > >> On 2020/2/25 上午10:33, Tian, Kevin wrote: > >>>> From: Alex Williamson >

Re: [dpdk-dev] [PATCH v2 5/7] vfio/pci: Add sriov_configure support

2020-03-06 Thread Alex Williamson
On Fri, 6 Mar 2020 09:45:40 + "Tian, Kevin" wrote: > > From: Tian, Kevin > > Sent: Friday, March 6, 2020 3:57 PM > > > > > From: Alex Williamson > > > Sent: Friday, March 6, 2020 2:23 AM > > > > > > On Tue, 25 Feb 2020 0

Re: [dpdk-dev] [PATCH v2 3/7] vfio/pci: Introduce VF token

2020-03-06 Thread Alex Williamson
On Fri, 6 Mar 2020 08:32:40 + "Tian, Kevin" wrote: > > From: Alex Williamson > > Sent: Friday, March 6, 2020 2:18 AM > > > > On Tue, 25 Feb 2020 02:59:37 + > > "Tian, Kevin" wrote: > > > > > > Fro

Re: [dpdk-dev] [PATCH v2 4/7] vfio: Introduce VFIO_DEVICE_FEATURE ioctl and first user

2020-03-05 Thread Alex Williamson
On Thu, 27 Feb 2020 18:34:07 +0100 Cornelia Huck wrote: > On Wed, 19 Feb 2020 11:54:18 -0700 > Alex Williamson wrote: > > > The VFIO_DEVICE_FEATURE ioctl is meant to be a general purpose, device > > agnostic ioctl for setting, retrieving, and probing device features. &g

Re: [dpdk-dev] [PATCH v2 5/7] vfio/pci: Add sriov_configure support

2020-03-05 Thread Alex Williamson
On Tue, 25 Feb 2020 03:08:00 + "Tian, Kevin" wrote: > > From: Alex Williamson > > Sent: Thursday, February 20, 2020 2:54 AM > > > > With the VF Token interface we can now expect that a vfio userspace > > driver must be in collaboration with the PF d

Re: [dpdk-dev] [PATCH v2 3/7] vfio/pci: Introduce VF token

2020-03-05 Thread Alex Williamson
On Tue, 25 Feb 2020 02:59:37 + "Tian, Kevin" wrote: > > From: Alex Williamson > > Sent: Thursday, February 20, 2020 2:54 AM > > > > If we enable SR-IOV on a vfio-pci owned PF, the resulting VFs are not > > fully isolated from the PF. The PF can alw

Re: [dpdk-dev] [PATCH v2 0/7] vfio/pci: SR-IOV support

2020-03-05 Thread Alex Williamson
Hi Kevin, Sorry for the delay, I've been out on PTO... On Tue, 25 Feb 2020 02:33:27 + "Tian, Kevin" wrote: > > From: Alex Williamson > > Sent: Thursday, February 20, 2020 2:54 AM > > > > Changes since v1 are primarily to patch 3/7 where the commit

Re: [dpdk-dev] [PATCH v2 0/7] vfio/pci: SR-IOV support

2020-03-05 Thread Alex Williamson
On Tue, 25 Feb 2020 14:09:07 +0800 Jason Wang wrote: > On 2020/2/25 上午10:33, Tian, Kevin wrote: > >> From: Alex Williamson > >> Sent: Thursday, February 20, 2020 2:54 AM > >> > >> Changes since v1 are primarily to patch 3/7 where the commit log is > &

[dpdk-dev] [PATCH v2 7/7] vfio/pci: Cleanup .probe() exit paths

2020-02-19 Thread Alex Williamson
The cleanup is getting a tad long. Signed-off-by: Alex Williamson --- drivers/vfio/pci/vfio_pci.c | 54 --- 1 file changed, 25 insertions(+), 29 deletions(-) diff --git a/drivers/vfio/pci/vfio_pci.c b/drivers/vfio/pci/vfio_pci.c index 497ecadef2ba

[dpdk-dev] [PATCH v2 5/7] vfio/pci: Add sriov_configure support

2020-02-19 Thread Alex Williamson
the host sysfs interface and the PF driver user cannot create or remove VFs. Signed-off-by: Alex Williamson --- drivers/vfio/pci/vfio_pci.c | 106 +++ drivers/vfio/pci/vfio_pci_private.h |2 + 2 files changed, 97 insertions(+), 11 deletions(-) diff --git

[dpdk-dev] [PATCH v2 6/7] vfio/pci: Remove dev_fmt definition

2020-02-19 Thread Alex Williamson
It currently results in messages like: "vfio-pci :03:00.0: vfio_pci: ..." Which is quite a bit redundant. Reviewed-by: Cornelia Huck Signed-off-by: Alex Williamson --- drivers/vfio/pci/vfio_pci.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/vfio/pci/vfio_pci.c

[dpdk-dev] [PATCH v2 1/7] vfio: Include optional device match in vfio_device_ops callbacks

2020-02-19 Thread Alex Williamson
Allow bus drivers to provide their own callback to match a device to the user provided string. Reviewed-by: Cornelia Huck Signed-off-by: Alex Williamson --- drivers/vfio/vfio.c | 20 include/linux/vfio.h |4 2 files changed, 20 insertions(+), 4 deletions

[dpdk-dev] [PATCH v2 2/7] vfio/pci: Implement match ops

2020-02-19 Thread Alex Williamson
This currently serves the same purpose as the default implementation but will be expanded for additional functionality. Reviewed-by: Cornelia Huck Signed-off-by: Alex Williamson --- drivers/vfio/pci/vfio_pci.c |8 1 file changed, 8 insertions(+) diff --git a/drivers/vfio/pci

[dpdk-dev] [PATCH v2 4/7] vfio: Introduce VFIO_DEVICE_FEATURE ioctl and first user

2020-02-19 Thread Alex Williamson
, whether the given operation on the feature is supported. The first user of this ioctl is for setting the vfio-pci VF token, where the user provides a shared secret key (UUID) on a SR-IOV PF device, which users must provide when opening associated VF devices. Signed-off-by: Alex Williamson

[dpdk-dev] [PATCH v2 3/7] vfio/pci: Introduce VF token

2020-02-19 Thread Alex Williamson
ide of these cases will return an error, as discussed above. Signed-off-by: Alex Williamson --- drivers/vfio/pci/vfio_pci.c | 198 +++ drivers/vfio/pci/vfio_pci_private.h |8 + 2 files changed, 205 insertions(+), 1 deletion(-) diff --git a/drivers

[dpdk-dev] [PATCH v2 0/7] vfio/pci: SR-IOV support

2020-02-19 Thread Alex Williamson
QEMU implementation provided with the RFC is still current for this version. Thanks, Alex RFC: https://lore.kernel.org/lkml/158085337582.9445.17682266437583505502.st...@gimli.home/ v1: https://lore.kernel.org/lkml/158145472604.16827.15751375540102298130.st...@gimli.home/ --- Alex Willia

Re: [dpdk-dev] [PATCH 3/7] vfio/pci: Introduce VF token

2020-02-14 Thread Alex Williamson
On Thu, 13 Feb 2020 19:35:16 +0100 Cornelia Huck wrote: > On Thu, 13 Feb 2020 10:23:21 -0700 > Alex Williamson wrote: > > > On Thu, 13 Feb 2020 12:46:54 +0100 > > Cornelia Huck wrote: > > > > > On Tue, 11 Feb 2020 16:05:42 -0700 > > > Alex Willi

Re: [dpdk-dev] [PATCH 0/7] vfio/pci: SR-IOV support

2020-02-14 Thread Alex Williamson
On Fri, 14 Feb 2020 15:57:04 +1100 Alexey Kardashevskiy wrote: > On 12/02/2020 10:05, Alex Williamson wrote: > > Given the mostly positive feedback from the RFC[1], here's a new > > non-RFC revision. Changes since RFC: > > > > - vfio_device_ops.match semantic

Re: [dpdk-dev] [PATCH 4/7] vfio: Introduce VFIO_DEVICE_FEATURE ioctl and first user

2020-02-13 Thread Alex Williamson
On Thu, 13 Feb 2020 13:41:21 +0100 Cornelia Huck wrote: > On Tue, 11 Feb 2020 16:05:51 -0700 > Alex Williamson wrote: > > > The VFIO_DEVICE_FEATURE ioctl is meant to be a general purpose, device > > agnostic ioctl for setting, retrieving, and probing device features. &g

Re: [dpdk-dev] [PATCH 3/7] vfio/pci: Introduce VF token

2020-02-13 Thread Alex Williamson
On Thu, 13 Feb 2020 12:46:54 +0100 Cornelia Huck wrote: > On Tue, 11 Feb 2020 16:05:42 -0700 > Alex Williamson wrote: > > > If we enable SR-IOV on a vfio-pci owned PF, the resulting VFs are not > > fully isolated from the PF. The PF can always cause a denial of > >

[dpdk-dev] [PATCH 5/7] vfio/pci: Add sriov_configure support

2020-02-11 Thread Alex Williamson
d the PF driver user cannot create and remove VF. Signed-off-by: Alex Williamson --- drivers/vfio/pci/vfio_pci.c | 106 +++ drivers/vfio/pci/vfio_pci_private.h |2 + 2 files changed, 97 insertions(+), 11 deletions(-) diff --git a/drivers/vfio/p

[dpdk-dev] [PATCH 7/7] vfio/pci: Cleanup .probe() exit paths

2020-02-11 Thread Alex Williamson
The cleanup is getting a tad long. Signed-off-by: Alex Williamson --- drivers/vfio/pci/vfio_pci.c | 54 --- 1 file changed, 25 insertions(+), 29 deletions(-) diff --git a/drivers/vfio/pci/vfio_pci.c b/drivers/vfio/pci/vfio_pci.c index a88b45ce1cc7

[dpdk-dev] [PATCH 6/7] vfio/pci: Remove dev_fmt definition

2020-02-11 Thread Alex Williamson
It currently results in messages like: "vfio-pci :03:00.0: vfio_pci: ..." Which is quite a bit redundant. Reviewed-by: Cornelia Huck Signed-off-by: Alex Williamson --- drivers/vfio/pci/vfio_pci.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/vfio/pci/vfio_pci.c

[dpdk-dev] [PATCH 2/7] vfio/pci: Implement match ops

2020-02-11 Thread Alex Williamson
This currently serves the same purpose as the default implementation but will be expanded for additional functionality. Signed-off-by: Alex Williamson --- drivers/vfio/pci/vfio_pci.c |8 1 file changed, 8 insertions(+) diff --git a/drivers/vfio/pci/vfio_pci.c b/drivers/vfio/pci

[dpdk-dev] [PATCH 0/7] vfio/pci: SR-IOV support

2020-02-11 Thread Alex Williamson
d test. The example QEMU implementation provided with the RFC[2] is still current for this version. Thanks, Alex [1] https://lore.kernel.org/lkml/158085337582.9445.17682266437583505502.st...@gimli.home/ [2] https://lore.kernel.org/lkml/20200204161737.34696...@w520.home/ --- Alex Williamson (7):

[dpdk-dev] [PATCH 1/7] vfio: Include optional device match in vfio_device_ops callbacks

2020-02-11 Thread Alex Williamson
Allow bus drivers to provide their own callback to match a device to the user provided string. Signed-off-by: Alex Williamson --- drivers/vfio/vfio.c | 20 include/linux/vfio.h |4 2 files changed, 20 insertions(+), 4 deletions(-) diff --git a/drivers/vfio

[dpdk-dev] [PATCH 3/7] vfio/pci: Introduce VF token

2020-02-11 Thread Alex Williamson
ice must also provide the current vf_token as authentication. This is intended to prevent a VF driver starting with a trusted PF driver and later being replaced by an unknown driver. A vf_token is not required to open the PF device when none of the VF devices are in use by vfio-pci drivers. Sign

[dpdk-dev] [PATCH 4/7] vfio: Introduce VFIO_DEVICE_FEATURE ioctl and first user

2020-02-11 Thread Alex Williamson
, whether the given operation on the feature is supported. The first user of this ioctl is for setting the vfio-pci VF token, where the user provides a shared secret key (UUID) on a SR-IOV PF device, which users must provide when opening associated VF devices. Signed-off-by: Alex Williamson

Re: [dpdk-dev] [RFC PATCH 0/7] vfio/pci: SR-IOV support

2020-02-11 Thread Alex Williamson
On Tue, 11 Feb 2020 16:48:47 +0530 Jerin Jacob wrote: > On Wed, Feb 5, 2020 at 4:35 AM Alex Williamson > wrote: > > > > There seems to be an ongoing desire to use userspace, vfio-based > > drivers for both SR-IOV PF and VF devices. The fundamental issue > > with

Re: [dpdk-dev] [RFC PATCH 1/7] vfio: Include optional device match in vfio_device_ops callbacks

2020-02-06 Thread Alex Williamson
On Thu, 6 Feb 2020 12:14:19 +0100 Cornelia Huck wrote: > On Tue, 04 Feb 2020 16:05:43 -0700 > Alex Williamson wrote: > > > Allow bus drivers to provide their own callback to match a device to > > the user provided string. > > > > Signed-off-by: Alex Will

Re: [dpdk-dev] [RFC PATCH 0/7] vfio/pci: SR-IOV support

2020-02-05 Thread Alex Williamson
On Wed, 5 Feb 2020 07:57:36 + "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Wednesday, February 5, 2020 7:18 AM > > To: k...@vger.kernel.org > > Subject: Re: [RFC PATCH 0/7] vfio/pci: SR-IOV support > > > > > >

Re: [dpdk-dev] [RFC PATCH 3/7] vfio/pci: Introduce VF token

2020-02-05 Thread Alex Williamson
On Wed, 5 Feb 2020 07:57:29 + "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Wednesday, February 5, 2020 7:06 AM > > To: k...@vger.kernel.org > > Subject: [RFC PATCH 3/7] vfio/pci: Introduce VF token > > > > If we enable SR-IOV on

Re: [dpdk-dev] [RFC PATCH 0/7] vfio/pci: SR-IOV support

2020-02-05 Thread Alex Williamson
On Wed, 5 Feb 2020 07:57:21 + "Liu, Yi L" wrote: > Hi Alex, > > Silly questions on the background: > > > From: Alex Williamson > > Sent: Wednesday, February 5, 2020 7:06 AM > > Subject: [RFC PATCH 0/7] vfio/pci: SR-IOV support > > > >

Re: [dpdk-dev] [RFC PATCH 0/7] vfio/pci: SR-IOV support

2020-02-05 Thread Alex Williamson
On Tue, 4 Feb 2020 23:01:09 -0800 Christoph Hellwig wrote: > On Tue, Feb 04, 2020 at 04:05:34PM -0700, Alex Williamson wrote: > > We address this in a few ways in this series. First, we can use a bus > > notifier and the driver_override facility to make sure VFs are bound >

Re: [dpdk-dev] [RFC PATCH 0/7] vfio/pci: SR-IOV support

2020-02-04 Thread Alex Williamson
Promised example QEMU test case... commit 3557c63bcb286c71f3f7242cad632edd9e297d26 Author: Alex Williamson Date: Tue Feb 4 13:47:41 2020 -0700 vfio-pci: QEMU support for vfio-pci VF tokens Example support for using a vf_token to gain access to a device as well as using the

[dpdk-dev] [RFC PATCH 6/7] vfio/pci: Remove dev_fmt definition

2020-02-04 Thread Alex Williamson
It currently results in messages like: "vfio-pci :03:00.0: vfio_pci: ..." Which is quite a bit redundant. Signed-off-by: Alex Williamson --- drivers/vfio/pci/vfio_pci.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/vfio/pci/vfio_pci.c b/drivers/vfio/pci/vfio_p

[dpdk-dev] [RFC PATCH 4/7] vfio: Introduce VFIO_DEVICE_FEATURE ioctl and first user

2020-02-04 Thread Alex Williamson
, whether the given operation on the feature is supported. The first user of this ioctl is for setting the vfio-pci VF token, where the user provides a shared secret key (UUID) on a SR-IOV PF device, which users must provide when opening associated VF devices. Signed-off-by: Alex Williamson

[dpdk-dev] [RFC PATCH 5/7] vfio/pci: Add sriov_configure support

2020-02-04 Thread Alex Williamson
d the PF driver user cannot create and remove VF. Signed-off-by: Alex Williamson --- drivers/vfio/pci/vfio_pci.c | 113 --- drivers/vfio/pci/vfio_pci_private.h |2 + 2 files changed, 104 insertions(+), 11 deletions(-) diff --git a/drivers/vfio/p

[dpdk-dev] [RFC PATCH 7/7] vfio/pci: Cleanup .probe() exit paths

2020-02-04 Thread Alex Williamson
The cleanup is getting a tad long. Signed-off-by: Alex Williamson --- drivers/vfio/pci/vfio_pci.c | 54 --- 1 file changed, 25 insertions(+), 29 deletions(-) diff --git a/drivers/vfio/pci/vfio_pci.c b/drivers/vfio/pci/vfio_pci.c index 343fe38ed06b

[dpdk-dev] [RFC PATCH 3/7] vfio/pci: Introduce VF token

2020-02-04 Thread Alex Williamson
ice must also provide the current vf_token as authentication. This is intended to prevent a VF driver starting with a trusted PF driver and later being replaced by an unknown driver. A vf_token is not required to open the PF device when none of the VF devices are in use by vfio-pci drivers. Sign

[dpdk-dev] [RFC PATCH 0/7] vfio/pci: SR-IOV support

2020-02-04 Thread Alex Williamson
w to manage, and might be static (and not very secret) for a given set of drivers. Thanks, Alex --- Alex Williamson (7): vfio: Include optional device match in vfio_device_ops callbacks vfio/pci: Implement match ops vfio/pci: Introduce VF token vfio: Introduce VFIO_DEVICE_FEAT

[dpdk-dev] [RFC PATCH 2/7] vfio/pci: Implement match ops

2020-02-04 Thread Alex Williamson
This currently serves the same purpose as the default implementation but will be expanded for additional functionality. Signed-off-by: Alex Williamson --- drivers/vfio/pci/vfio_pci.c |8 1 file changed, 8 insertions(+) diff --git a/drivers/vfio/pci/vfio_pci.c b/drivers/vfio/pci

[dpdk-dev] [RFC PATCH 1/7] vfio: Include optional device match in vfio_device_ops callbacks

2020-02-04 Thread Alex Williamson
Allow bus drivers to provide their own callback to match a device to the user provided string. Signed-off-by: Alex Williamson --- drivers/vfio/vfio.c | 19 +++ include/linux/vfio.h |3 +++ 2 files changed, 18 insertions(+), 4 deletions(-) diff --git a/drivers/vfio/vfio.c

Re: [dpdk-dev] [PATCH v1 1/1] kernel/linux: introduce vfio_pf kernel module

2019-11-06 Thread Alex Williamson
On Thu, 31 Oct 2019 18:03:53 +0100 Thomas Monjalon wrote: > We don't get enough attention on this topic. > Let me rephrase the issue and the proposals with more people Cc'ed. > > We are talking about SR-IOV VFs in VMs > with a PF managed on the host by DPDK. > The PF driver is either a (1) bifur

[dpdk-dev] [bug] dpdk-vfio: Invalid region/index assumption

2016-07-28 Thread Alex Williamson
On Thu, 28 Jul 2016 09:42:13 + "Burakov, Anatoly" wrote: > > Hi, > > > > 2016-07-27 16:14, Alex Williamson: > > > I took a quick look at the dpdk vfio code and spotted an invalid > > > assumption that should probably be corrected ASAP.

[dpdk-dev] [bug] dpdk-vfio: Invalid region/index assumption

2016-07-27 Thread Alex Williamson
Hi, I took a quick look at the dpdk vfio code and spotted an invalid assumption that should probably be corrected ASAP. That is: lib/librte_eal/linuxapp/eal/eal_vfio.h: #define VFIO_GET_REGION_ADDR(x) ((uint64_t) x << 40ULL) #define VFIO_GET_REGION_IDX(x) (x >> 40) Region offset to index is an

[dpdk-dev] [PATCH] vfio/noiommu: Don't use iommu_present() to track fake groups

2016-01-22 Thread Alex Williamson
e the address of the noiommu switch itself. Reported-by: Alexey Kardashevskiy Fixes: 03a76b60f8ba ("vfio: Include No-IOMMU mode") Signed-off-by: Alex Williamson --- Copying some DPDK folks and would appreciate validation that this still works for the intended no-iommu us

[dpdk-dev] VFIO no-iommu

2016-01-13 Thread Alex Williamson
On Thu, 2016-01-14 at 14:03 +0800, Jike Song wrote: > On Wed, Dec 16, 2015 at 12:38 PM, Alex Williamson > wrote: > > > > So it works.??Is it acceptable???Useful???Sufficiently complete???Does > > it imply deprecating the uio interface???I believe the feature that > &g

[dpdk-dev] [PATCH] eal: map io resources for non x86 architectures

2015-12-29 Thread Alex Williamson
On Tue, 2015-12-29 at 16:17 +0530, Santosh Shukla wrote: > On Tue, Dec 29, 2015 at 3:26 PM, Burakov, Anatoly > wrote: > > Hi Santosh, > > > > > On Fri, Dec 18, 2015 at 6:25 PM, Santosh Shukla > > om> > > > wrote: > > > > On Fri, Dec 18, 2015 at 1:51 PM, Yuanhan Liu > > > > wrote: > > > > > On F

[dpdk-dev] VFIO no-iommu

2015-12-22 Thread Alex Williamson
On Mon, 2015-12-21 at 12:22 -0700, Alex Williamson wrote: > On Mon, 2015-12-21 at 11:46 +, Yigit, Ferruh wrote: > > On Fri, Dec 18, 2015 at 02:50:17PM -0700, Alex Williamson wrote: > > > On Fri, 2015-12-18 at 07:38 -0700, Alex Williamson wrote: > > > > On Fri, 20

[dpdk-dev] [PATCH v4] vfio: Include No-IOMMU mode

2015-12-22 Thread Alex Williamson
rt for the vfio-pci bus driver only. Signed-off-by: Alex Williamson Acked-by: Michael S. Tsirkin --- v4: Fix build without CONFIG_VFIO_NOIOMMU (oops). Also avoid local noiommu variable in vfio_create_group() to avoid scope confusion with global of the same name. drivers/vfio/Kconfig

[dpdk-dev] [PATCH v3] vfio: Include No-IOMMU mode

2015-12-22 Thread Alex Williamson
rt for the vfio-pci bus driver only. Signed-off-by: Alex Williamson Acked-by: Michael S. Tsirkin --- v3: Version 2 was dropped from kernel v4.4 due to lack of a user. We now have a working DPDK port to this interface, so I'm proposing it again for v4.5. The changes since v2 can be

[dpdk-dev] VFIO no-iommu

2015-12-21 Thread Alex Williamson
On Mon, 2015-12-21 at 11:46 +, Yigit, Ferruh wrote: > On Fri, Dec 18, 2015 at 02:50:17PM -0700, Alex Williamson wrote: > > On Fri, 2015-12-18 at 07:38 -0700, Alex Williamson wrote: > > > On Fri, 2015-12-18 at 10:43 +, Yigit, Ferruh wrote: > > > > On Thu, De

[dpdk-dev] VFIO no-iommu

2015-12-18 Thread Alex Williamson
On Fri, 2015-12-18 at 07:38 -0700, Alex Williamson wrote: > On Fri, 2015-12-18 at 10:43 +, Yigit, Ferruh wrote: > > On Thu, Dec 17, 2015 at 09:43:59AM -0700, Alex Williamson wrote: > > <...> > > > > > > > > > > > >

[dpdk-dev] VFIO no-iommu

2015-12-18 Thread Alex Williamson
On Fri, 2015-12-18 at 10:43 +, Yigit, Ferruh wrote: > On Thu, Dec 17, 2015 at 09:43:59AM -0700, Alex Williamson wrote: > <...> > > > > > > > > > > > > > > Also I need to disable VFIO_CHECK_EXTENSION ioctl, > >

[dpdk-dev] VFIO no-iommu

2015-12-17 Thread Alex Williamson
On Wed, 2015-12-16 at 17:22 +, Burakov, Anatoly wrote: > Hi Alex, > > > On Wed, 2015-12-16 at 08:35 +, Burakov, Anatoly wrote: > > > Hi Alex, > > > > > > > On Wed, 2015-12-16 at 04:04 +, Ferruh Yigit wrote: > > > > >

[dpdk-dev] VFIO no-iommu

2015-12-16 Thread Alex Williamson
On Wed, 2015-12-16 at 08:35 +, Burakov, Anatoly wrote: > Hi Alex, > > > On Wed, 2015-12-16 at 04:04 +, Ferruh Yigit wrote: > > > On Tue, Dec 15, 2015 at 09:53:18AM -0700, Alex Williamson wrote: > > > I tested the DPDK (HEAD of master) with the patch, with h

[dpdk-dev] VFIO no-iommu

2015-12-15 Thread Alex Williamson
On Wed, 2015-12-16 at 04:04 +, Ferruh Yigit wrote: > On Tue, Dec 15, 2015 at 09:53:18AM -0700, Alex Williamson wrote: > > On Tue, 2015-12-15 at 13:43 +, O'Driscoll, Tim wrote: > > > > -Original Message- > > > > From: dev [mailto:dev-

[dpdk-dev] VFIO no-iommu

2015-12-15 Thread Alex Williamson
On Tue, 2015-12-15 at 13:43 +, O'Driscoll, Tim wrote: > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Alex > > Williamson > > Sent: Friday, December 11, 2015 11:03 PM > > To: Vincent JARDIN; dev at dpdk.org > &

[dpdk-dev] VFIO no-iommu

2015-12-11 Thread Alex Williamson
On Fri, 2015-12-11 at 23:12 +0100, Vincent JARDIN wrote: > Thanks Thomas for putting back this topic. > > Alex, > > I'd like to hear more about the impacts of "unsupported": > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commi > t/?id=033291eccbdb1b70ffc02641edae19ac825dc75d >

[dpdk-dev] [PATCH] vfio: support iommu group zero

2015-12-09 Thread Alex Williamson
On Wed, 2015-12-09 at 16:52 -0800, Stephen Hemminger wrote: > On Wed, 09 Dec 2015 16:22:14 -0700 > Alex Williamson wrote: > > > On Wed, 2015-12-09 at 15:12 -0800, Stephen Hemminger wrote: > > > On Wed, 09 Dec 2015 23:49:59 +0100 > > > Thomas Monjalon wrote

[dpdk-dev] [PATCH] vfio: support iommu group zero

2015-12-09 Thread Alex Williamson
On Wed, 2015-12-09 at 15:12 -0800, Stephen Hemminger wrote: > On Wed, 09 Dec 2015 23:49:59 +0100 > Thomas Monjalon wrote: > > > 2015-12-09 13:58, Stephen Hemminger: > > > On Wed, 09 Dec 2015 22:12:33 +0100 > > > Thomas Monjalon wrote: > > > > > > > 2015-12-09 09:55, Stephen Hemminger: > > > > >

[dpdk-dev] [PATCH] vfio: Include No-IOMMU mode

2015-12-02 Thread Alex Williamson
On Mon, 2015-11-16 at 19:12 +0200, Avi Kivity wrote: > On 11/16/2015 07:06 PM, Alex Williamson wrote: > > On Wed, 2015-10-28 at 15:21 -0600, Alex Williamson wrote: > >> There is really no way to safely give a user full access to a DMA > >> capable device without an IOMMU