Re: [dpdk-dev] [PATCH 0/7] vfio/pci: SR-IOV support

2020-02-13 Thread Alexey Kardashevskiy
On 12/02/2020 10:05, Alex Williamson wrote: > Given the mostly positive feedback from the RFC[1], here's a new > non-RFC revision. Changes since RFC: > > - vfio_device_ops.match semantics refined > - Use helpers for struct pci_dev.physfn to avoid breakage without >CONFIG_PCI_IOV > - Rel

Re: [dpdk-dev] [PATCH dpdk v2] vfio/ppc64/spapr: Warn if DMA window was created at unexpected offset

2017-10-17 Thread Alexey Kardashevskiy
On 18/10/17 03:13, Thomas Monjalon wrote: > 28/04/2017 13:19, Burakov, Anatoly: >> From: Alexey Kardashevskiy >>> VFIO_IOMMU_SPAPR_TCE_CREATE ioctl() returns the actual bus address for >>> just created DMA window. It happens to start from zero because the default >&g

Re: [dpdk-dev] [PATCH v4] vfio: fix sPAPR IOMMU DMA window size

2017-08-09 Thread Alexey Kardashevskiy
ferle Reviewed-by: Alexey Kardashevskiy > --- > v2: > * roundup to next power 2 function without loop. > > v3: > * Replace roundup_next_pow2 with rte_align64pow2 > > v4: > * do not assume ordering of physical addresses of memsegs > > lib/librte_eal/linuxa

Re: [dpdk-dev] [PATCH] vfio: fix sPAPR IOMMU DMA window size

2017-08-08 Thread Alexey Kardashevskiy
g/gitweb.cgi?p=qemu.git;a=blob;f=include/qemu/host-utils.h;h=95cf4f4163e50457cdf808263065ca5ef3f935da;hb=f22ab6cb0c47bd2a2785b7d58130949bd7d8d9af#l382 Anyway, seems working. Reviewed-by: Alexey Kardashevskiy > static int > vfio_spapr_dma_map(int vfio_container_fd) > { > @@ -759,10 +771,12 @@ vfio_spapr_dma_map

Re: [dpdk-dev] [PATCH dpdk v2] bnx2x: Update firmware versions

2017-04-28 Thread Alexey Kardashevskiy
On 29/04/17 10:31, Mody, Rasesh wrote: > Hi Alexey, > >> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] >> Sent: Wednesday, April 26, 2017 2:18 AM >> >> On 4/26/2017 9:08 AM, Alexey Kardashevskiy wrote: >>> Recent kernels/distros have updated firmware

Re: [dpdk-dev] [PATCH dpdk v2] bnx2x: Update firmware versions

2017-04-26 Thread Alexey Kardashevskiy
On Wed, 26 Apr 2017 10:18:29 +0100 Ferruh Yigit wrote: > On 4/26/2017 9:08 AM, Alexey Kardashevskiy wrote: > > Recent kernels/distros have updated firmware images, use them. > > In order to keep support of older distros (such as Fedora 19 or > > Ubuntu 14.04), this also

[dpdk-dev] [PATCH dpdk v2] vfio/ppc64/spapr: Warn if DMA window was created at unexpected offset

2017-04-26 Thread Alexey Kardashevskiy
, this adds a check and an error message. Signed-off-by: Alexey Kardashevskiy --- Changes: v2: * this just prints warning and fails instead of incorrectly changing IOVA addresses --- lib/librte_eal/linuxapp/eal/eal_vfio.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a

[dpdk-dev] [PATCH dpdk v2] bnx2x: Update firmware versions

2017-04-26 Thread Alexey Kardashevskiy
Recent kernels/distros have updated firmware images, use them. In order to keep support of older distros (such as Fedora 19 or Ubuntu 14.04), this also tries fallback to an order firmware version. Signed-off-by: Alexey Kardashevskiy --- Changes: v2: * in addition to the very new firmware images

[dpdk-dev] [PATCH dpdk v2] pci: Initialize common rte driver pointer

2017-04-26 Thread Alexey Kardashevskiy
The existing code initializes a PCI driver pointer but not the common one. As the result, ring_dma_zone_reserve() in drivers/net/bnx2x/bnx2x_rxtx.c crashed as dev->device->driver==NULL. This adds missing initialization. Signed-off-by: Alexey Kardashevskiy --- Changes: v2: * no change

[dpdk-dev] [PATCH dpdk v2] vfio/ppc64/spapr: Use correct structures for add/remove windows

2017-04-26 Thread Alexey Kardashevskiy
VFIO_IOMMU_SPAPR_TCE_REMOVE ioctls. No change in behaviour is expected if installed linux UAPI headers have knowledge of VFIO_SPAPR_TCE_v2_IOMMU. Signed-off-by: Alexey Kardashevskiy --- Changes: v2: * changed commit log after I realized that the linux UAPI headers are currently used and if a distro is quite fresh, it

Re: [dpdk-dev] [PATCH dpdk 4/5] vfio: Do try setting IOMMU type if already set

2017-04-26 Thread Alexey Kardashevskiy
On 21/04/17 18:54, Andrew Rybchenko wrote: > On 04/20/2017 10:24 AM, Alexey Kardashevskiy wrote: >> The existing code correctly checks if a container is set to a group and >> does not try attaching a group to a container for a second/third/... >> device from the same IOMMU gr

Re: [dpdk-dev] [PATCH dpdk 0/5] ppc64/spapr: Attempt to use on POWER8

2017-04-23 Thread Alexey Kardashevskiy
ctor DPDK > Mellanox Technologies, Raanana Israel > > > > >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Alexey >> Kardashevskiy >> Sent: Thursday, April 20, 2017 10:24 AM >> To: dev@dpdk.org >> Cc: Alexey Kar

Re: [dpdk-dev] [PATCH dpdk 5/5] RFC: vfio/ppc64/spapr: Use correct bus addresses for DMA map

2017-04-21 Thread Alexey Kardashevskiy
On 21/04/17 19:19, Jonas Pfefferle1 wrote: > Alexey Kardashevskiy wrote on 21/04/2017 10:43:53: > >> From: Alexey Kardashevskiy >> To: gowrishankar muthukrishnan >> Cc: Jonas Pfefferle1 , Gowrishankar >> Muthukrishnan , Adrian Schuepbach >> , "

Re: [dpdk-dev] [PATCH dpdk 5/5] RFC: vfio/ppc64/spapr: Use correct bus addresses for DMA map

2017-04-21 Thread Alexey Kardashevskiy
On 21/04/17 18:35, Jonas Pfefferle1 wrote: > > Jonas Pfefferle > Cloud Storage & Analytics > IBM Zurich Research Laboratory > Saeumerstrasse 4 > CH-8803 Rueschlikon, Switzerland > +41 44 724 8539 > > Alexey Kardashevski

Re: [dpdk-dev] [PATCH dpdk 5/5] RFC: vfio/ppc64/spapr: Use correct bus addresses for DMA map

2017-04-21 Thread Alexey Kardashevskiy
On 21/04/17 13:42, Alexey Kardashevskiy wrote: > On 21/04/17 05:16, gowrishankar muthukrishnan wrote: >> On Thursday 20 April 2017 07:52 PM, Alexey Kardashevskiy wrote: >>> On 20/04/17 23:25, Alexey Kardashevskiy wrote: >>>> On 20/04/17 19:04, Jonas Pfefferle1 wro

Re: [dpdk-dev] [PATCH dpdk 5/5] RFC: vfio/ppc64/spapr: Use correct bus addresses for DMA map

2017-04-20 Thread Alexey Kardashevskiy
On 21/04/17 05:16, gowrishankar muthukrishnan wrote: > On Thursday 20 April 2017 07:52 PM, Alexey Kardashevskiy wrote: >> On 20/04/17 23:25, Alexey Kardashevskiy wrote: >>> On 20/04/17 19:04, Jonas Pfefferle1 wrote: >>>> Alexey Kardashevskiy wrote on 20/04/2017 09:

Re: [dpdk-dev] [PATCH dpdk] i40e/ppc64/altivec: Fix compile errors on POWER8

2017-04-20 Thread Alexey Kardashevskiy
On 21/04/17 13:10, Alexey Kardashevskiy wrote: > Fixes: 67f038076657 ("net/i40e: enable per-device packet type mapping") > Signed-off-by: Alexey Kardashevskiy ah, never mind, fixed already. > --- > drivers/net/i40e/i40e_rxtx_vec_altivec.c | 8 > 1 file ch

[dpdk-dev] [PATCH dpdk] i40e/ppc64/altivec: Fix compile errors on POWER8

2017-04-20 Thread Alexey Kardashevskiy
Fixes: 67f038076657 ("net/i40e: enable per-device packet type mapping") Signed-off-by: Alexey Kardashevskiy --- drivers/net/i40e/i40e_rxtx_vec_altivec.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/i40e/i40e_rxtx_vec_altivec.c b/driver

Re: [dpdk-dev] [PATCH dpdk 5/5] RFC: vfio/ppc64/spapr: Use correct bus addresses for DMA map

2017-04-20 Thread Alexey Kardashevskiy
On 21/04/17 01:15, Jonas Pfefferle1 wrote: > Alexey Kardashevskiy wrote on 20/04/2017 16:22:01: > >> From: Alexey Kardashevskiy >> To: Jonas Pfefferle1 >> Cc: dev@dpdk.org, Gowrishankar Muthukrishnan >> , Adrian Schuepbach >> Date: 20/04/2017 16:22 >&g

Re: [dpdk-dev] [PATCH dpdk 5/5] RFC: vfio/ppc64/spapr: Use correct bus addresses for DMA map

2017-04-20 Thread Alexey Kardashevskiy
On 20/04/17 23:25, Alexey Kardashevskiy wrote: > On 20/04/17 19:04, Jonas Pfefferle1 wrote: >> Alexey Kardashevskiy wrote on 20/04/2017 09:24:02: >> >>> From: Alexey Kardashevskiy >>> To: dev@dpdk.org >>> Cc: Alexey Kardashevskiy , j...@zurich.ibm.com

Re: [dpdk-dev] [PATCH dpdk 5/5] RFC: vfio/ppc64/spapr: Use correct bus addresses for DMA map

2017-04-20 Thread Alexey Kardashevskiy
On 20/04/17 19:04, Jonas Pfefferle1 wrote: > Alexey Kardashevskiy wrote on 20/04/2017 09:24:02: > >> From: Alexey Kardashevskiy >> To: dev@dpdk.org >> Cc: Alexey Kardashevskiy , j...@zurich.ibm.com, >> Gowrishankar Muthukrishnan >> Date: 20/04/2017 09:24 &g

[dpdk-dev] [PATCH dpdk 5/5] RFC: vfio/ppc64/spapr: Use correct bus addresses for DMA map

2017-04-20 Thread Alexey Kardashevskiy
, this adds an error check. Another issue is that IOVA passed to VFIO_IOMMU_MAP_DMA should be a PCI bus address while in this case a physical address of a user page is used. This changes IOVA to start from zero in a hope that the rest of DPDK expects this. Signed-off-by: Alexey Kardashevskiy

[dpdk-dev] [PATCH dpdk 4/5] vfio: Do try setting IOMMU type if already set

2017-04-20 Thread Alexey Kardashevskiy
container and group fds. This moves vfio_set_iommu_type() and DMA mapping code under: if (!(group_status.flags & VFIO_GROUP_FLAGS_CONTAINER_SET)) Signed-off-by: Alexey Kardashevskiy --- lib/librte_eal/linuxapp/eal/eal_vfio.c | 50 +- 1 file changed, 25 insert

[dpdk-dev] [PATCH dpdk 2/5] pci: Initialize common rte driver pointer

2017-04-20 Thread Alexey Kardashevskiy
The existing code initializes a PCI driver pointer but not the common one. As the result, ring_dma_zone_reserve() in drivers/net/bnx2x/bnx2x_rxtx.c crashed as dev->device->driver==NULL. This adds missing initialization. Signed-off-by: Alexey Kardashevskiy --- lib/librte_eal/

[dpdk-dev] [PATCH dpdk 3/5] RFC: bnx2x: Update firmware versions

2017-04-20 Thread Alexey Kardashevskiy
Recent kernels/distros have updated firmware images, use them. Signed-off-by: Alexey Kardashevskiy --- drivers/net/bnx2x/bnx2x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c index 1a7e1c8e1..17e8c6b4c 100644 --- a

[dpdk-dev] [PATCH dpdk 1/5] vfio/ppc64/spapr: Use correct structures for add/remove windows

2017-04-20 Thread Alexey Kardashevskiy
This copies structures passed via VFIO_IOMMU_SPAPR_TCE_CREATE and VFIO_IOMMU_SPAPR_TCE_REMOVE ioctls. The existing ones cannot possible work. Signed-off-by: Alexey Kardashevskiy --- lib/librte_eal/linuxapp/eal/eal_vfio.h | 8 1 file changed, 8 insertions(+) diff --git a/lib/librte_eal

[dpdk-dev] [PATCH dpdk 0/5] ppc64/spapr: Attempt to use on POWER8

2017-04-20 Thread Alexey Kardashevskiy
ease comment. Thanks. Alexey Kardashevskiy (5): vfio/ppc64/spapr: Use correct structures for add/remove windows pci: Initialize common rte driver pointer RFC: bnx2x: Update firmware versions vfio: Do try setting IOMMU type if already set RFC: vfio/ppc64/spapr: Use correct bus address

[dpdk-dev] [PATCH] vfio/noiommu: Don't use iommu_present() to track fake groups

2016-01-25 Thread Alexey Kardashevskiy
mmu purposes. The iommudata we set is purely > arbitrary since we're only comparing the address, so we use the > address of the noiommu switch itself. > > Reported-by: Alexey Kardashevskiy > Fixes: 03a76b60f8ba ("vfio: Include No-IOMMU mode") > Signed-off-by: Alex Williamson Reviewed-by: Alexey Kardashevskiy Tested-by: Alexey Kardashevskiy Thanks! -- Alexey