Re: [dpdk-dev] [PATCH v3 1/1] net/ionic: use standard stdbool.h

2020-03-10 Thread Alfredo Cardigliano
> On 10 Mar 2020, at 16:21, Ferruh Yigit wrote: > > On 3/9/2020 9:09 AM, Sunil Kumar Kori wrote: >> Any DPDK public header file which includes stdbool.h may conflict with >> local definition of bool, if any, which further results in compilation >> error. To avoid, used standard stdbool.h inste

[dpdk-dev] [PATCH] net/ionic: fix packet type mask

2020-01-30 Thread Alfredo Cardigliano
Fix the IONIC_RXQ_COMP_PKT_TYPE_MASK define. This fixes the coverity defect #353608 Signed-off-by: Alfredo Cardigliano --- drivers/net/ionic/ionic_if.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ionic/ionic_if.h b/drivers/net/ionic/ionic_if.h index ab300be6e

Re: [dpdk-dev] [PATCH v2] net/ionic: ignore missing field initializers warning

2020-01-21 Thread Alfredo Cardigliano
> On 21 Jan 2020, at 10:58, Ferruh Yigit wrote: > > The compiler warning is: > from .../drivers/net/ionic/ionic_dev.c:7: > .../drivers/net/ionic/ionic_if.h:202:5: note: ‘rsvd’ declared here > u8 rsvd[62]; > ^ > > This has been observed with gcc 4.8.5, newer 9+ compiler are not giving >

[dpdk-dev] [PATCH v5 15/17] net/ionic: add stats

2020-01-19 Thread Alfredo Cardigliano
Add basic, per queue and extended statistics for RX and TX, both from the adapter and the driver. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- doc/guides/nics/features/ionic.ini | 3 + drivers/net/ionic/ionic_ethdev.c | 253 + drivers/net

[dpdk-dev] [PATCH v5 16/17] net/ionic: add Tx checksum support

2020-01-19 Thread Alfredo Cardigliano
Add support for Tx checksumming. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- drivers/net/ionic/ionic_ethdev.c | 5 ++ drivers/net/ionic/ionic_lif.c| 1 + drivers/net/ionic/ionic_lif.h| 1 + drivers/net/ionic/ionic_rxtx.c | 88

[dpdk-dev] [PATCH v5 14/17] net/ionic: add RSS support

2020-01-19 Thread Alfredo Cardigliano
Add code to manipulate the RSS configuration used by the adapter. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- doc/guides/nics/features/ionic.ini | 3 + drivers/net/ionic/ionic_ethdev.c | 175 + drivers/net/ionic/ionic_ethdev.h | 8

[dpdk-dev] [PATCH v5 17/17] net/ionic: read Fw version

2020-01-19 Thread Alfredo Cardigliano
Add support for reading the firmware version. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- doc/guides/nics/features/ionic.ini | 1 + drivers/net/ionic/ionic.h | 1 + drivers/net/ionic/ionic_dev.c | 8 drivers/net/ionic/ionic_ethdev.c | 20

[dpdk-dev] [PATCH v5 08/17] net/ionic: add adminq support

2020-01-19 Thread Alfredo Cardigliano
Add support for the admin queue, which is used for most of the NIC configurations. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- drivers/net/ionic/ionic.h | 3 + drivers/net/ionic/ionic_dev.c | 255 drivers/net/ionic/ionic_dev.h | 94

[dpdk-dev] [PATCH v5 13/17] net/ionic: add Rx and Tx handling

2020-01-19 Thread Alfredo Cardigliano
Add Rx and Tx queues setup and handling. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- doc/guides/nics/features/ionic.ini | 10 + drivers/net/ionic/Makefile | 1 + drivers/net/ionic/ionic_dev.h | 1 + drivers/net/ionic/ionic_ethdev.c | 115 drivers

[dpdk-dev] [PATCH v5 09/17] net/ionic: add notifyq support

2020-01-19 Thread Alfredo Cardigliano
Add support for the notify queue, which is used for events published by the NIC. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- drivers/net/ionic/ionic.h| 2 + drivers/net/ionic/ionic_ethdev.c | 97 drivers/net/ionic/ionic_lif.c| 191

[dpdk-dev] [PATCH v5 10/17] net/ionic: add basic port operations

2020-01-19 Thread Alfredo Cardigliano
Add support for port start/stop and handle basic features including mtu and link up/down. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- doc/guides/nics/features/ionic.ini | 4 + drivers/net/ionic/ionic.h | 1 + drivers/net/ionic/ionic_dev.h | 3

[dpdk-dev] [PATCH v5 11/17] net/ionic: add Rx filters support

2020-01-19 Thread Alfredo Cardigliano
Add support for managing RX filters based on MAC and VLAN. Hardware cannot provide the list of filters, thus we keep a local list. Add support for promisc and allmulticast modes. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- doc/guides/nics/features/ionic.ini | 4

[dpdk-dev] [PATCH v5 12/17] net/ionic: add Flow Control support

2020-01-19 Thread Alfredo Cardigliano
Add support for managing Flow Control. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- doc/guides/nics/features/ionic.ini | 1 + drivers/net/ionic/ionic_ethdev.c | 56 ++ 2 files changed, 57 insertions(+) diff --git a/doc/guides/nics/features

[dpdk-dev] [PATCH v5 04/17] net/ionic: register and initialize the adapter

2020-01-19 Thread Alfredo Cardigliano
Register the Pensando ionic PMD (net_ionic) and define initial probe and remove callbacks with adapter initialization. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- doc/guides/nics/features/ionic.ini | 2 + drivers/net/ionic/Makefile | 3 + drivers/net/ionic

[dpdk-dev] [PATCH v5 07/17] net/ionic: add doorbells

2020-01-19 Thread Alfredo Cardigliano
Doorbell registers are used by the driver to signal to the NIC that requests are waiting on the message queues. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- drivers/net/ionic/ionic_dev.c | 15 +++ drivers/net/ionic/ionic_dev.h | 18 ++ drivers

[dpdk-dev] [PATCH v5 05/17] net/ionic: add port management commands

2020-01-19 Thread Alfredo Cardigliano
Add port management commands that apply to the physical ports associated with the PCI device, which might be shared among several logical interfaces. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- drivers/net/ionic/ionic.h| 6 ++ drivers/net/ionic/ionic_dev.c

[dpdk-dev] [PATCH v5 03/17] net/ionic: add log

2020-01-19 Thread Alfredo Cardigliano
Add debug options to the config file. Define macros used for logs and make use of config file options to enable them. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- drivers/net/ionic/Makefile | 2 +- drivers/net/ionic/ionic_ethdev.c | 14 ++ drivers/net

[dpdk-dev] [PATCH v5 06/17] net/ionic: add basic lif support

2020-01-19 Thread Alfredo Cardigliano
Initialize LIFs (Logical Interfaces) which represents external connections. The NIC can multiplex many LIFs to a single port, but in most setups, LIF0 is the primary control for the port. Create a device for each LIF. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- drivers

[dpdk-dev] [PATCH v5 02/17] net/ionic: add hardware structures definitions

2020-01-19 Thread Alfredo Cardigliano
Add hardware structures and message commands definitions for Pensando network adapters. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- drivers/net/ionic/ionic_if.h | 2491 ++ 1 file changed, 2491 insertions(+) create mode 100644 drivers/net

[dpdk-dev] [PATCH v5 00/17] Introduces net/ionic PMD

2020-01-19 Thread Alfredo Cardigliano
style cleanup Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson Alfredo Cardigliano (17): net/ionic: add skeleton net/ionic: add hardware structures definitions net/ionic: add log net/ionic: register and initialize the adapter net/ionic: add port management commands net

[dpdk-dev] [PATCH v5 01/17] net/ionic: add skeleton

2020-01-19 Thread Alfredo Cardigliano
Add makefile and config file options to compile the Pensando ionic PMD. Add feature and version map file. Update maintainers file. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- MAINTAINERS | 6 +++ config/common_armv8a_linux

Re: [dpdk-dev] [PATCH v4 02/17] net/ionic: add hardware structures definitions

2020-01-03 Thread Alfredo Cardigliano
> On 20 Dec 2019, at 01:16, Stephen Hemminger > wrote: > > On Thu, 19 Dec 2019 23:18:32 +0100 > Alfredo Cardigliano wrote: > >> + >> +#pragma pack(push, 1) >> + > > Really, packing leads to unaligned data structures and is generally >

[dpdk-dev] [PATCH v4 17/17] net/ionic: read fw version

2019-12-19 Thread Alfredo Cardigliano
Add support for reading the firmware version. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- doc/guides/nics/features/ionic.ini | 1 + drivers/net/ionic/ionic.h | 1 + drivers/net/ionic/ionic_dev.c | 8 drivers/net/ionic/ionic_ethdev.c | 20

[dpdk-dev] [PATCH v4 15/17] net/ionic: add stats

2019-12-19 Thread Alfredo Cardigliano
Add basic, per queue and extended statistics for RX and TX, both from the adapter and the driver. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- doc/guides/nics/features/ionic.ini | 3 + drivers/net/ionic/ionic_ethdev.c | 253 + drivers/net

[dpdk-dev] [PATCH v4 11/17] net/ionic: add RX filters support

2019-12-19 Thread Alfredo Cardigliano
Add support for managing RX filters based on MAC and VLAN. Hardware cannot provide the list of filters, thus we keep a local list. Add support for promisc and allmulticast modes. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- doc/guides/nics/features/ionic.ini | 4

[dpdk-dev] [PATCH v4 13/17] net/ionic: add RX and TX handling

2019-12-19 Thread Alfredo Cardigliano
Add RX and TX queues setup and handling. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- doc/guides/nics/features/ionic.ini | 10 + drivers/net/ionic/Makefile | 1 + drivers/net/ionic/ionic_dev.h | 1 + drivers/net/ionic/ionic_ethdev.c | 115 drivers

[dpdk-dev] [PATCH v4 16/17] net/ionic: add TX checksum support

2019-12-19 Thread Alfredo Cardigliano
Add support for TX checksumming. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- drivers/net/ionic/ionic_ethdev.c | 5 ++ drivers/net/ionic/ionic_lif.c| 1 + drivers/net/ionic/ionic_lif.h| 1 + drivers/net/ionic/ionic_rxtx.c | 88

[dpdk-dev] [PATCH v4 14/17] net/ionic: add RSS support

2019-12-19 Thread Alfredo Cardigliano
Add code to manipulate the RSS configuration used by the adapter. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- doc/guides/nics/features/ionic.ini | 3 + drivers/net/ionic/ionic_ethdev.c | 175 + drivers/net/ionic/ionic_ethdev.h | 8

[dpdk-dev] [PATCH v4 10/17] net/ionic: add basic port operations

2019-12-19 Thread Alfredo Cardigliano
Add support for port start/stop and handle basic features including mtu and link up/down. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- doc/guides/nics/features/ionic.ini | 4 + drivers/net/ionic/ionic.h | 1 + drivers/net/ionic/ionic_dev.h | 3

[dpdk-dev] [PATCH v4 12/17] net/ionic: add Flow Control support

2019-12-19 Thread Alfredo Cardigliano
Add support for managing Flow Control. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- doc/guides/nics/features/ionic.ini | 1 + drivers/net/ionic/ionic_ethdev.c | 56 ++ 2 files changed, 57 insertions(+) diff --git a/doc/guides/nics/features

[dpdk-dev] [PATCH v4 07/17] net/ionic: add doorbells

2019-12-19 Thread Alfredo Cardigliano
Doorbell registers are used by the driver to signal to the NIC that requests are waiting on the message queues. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- drivers/net/ionic/ionic_dev.c | 15 +++ drivers/net/ionic/ionic_dev.h | 19 +++ drivers

[dpdk-dev] [PATCH v4 06/17] net/ionic: add basic lif support

2019-12-19 Thread Alfredo Cardigliano
Initialize LIFs (Logical Interfaces) which represents external connections. The NIC can multiplex many LIFs to a single port, but in most setups, LIF0 is the primary control for the port. Create a device for each LIF. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- drivers

[dpdk-dev] [PATCH v4 04/17] net/ionic: register and initialize the adapter

2019-12-19 Thread Alfredo Cardigliano
Register the Pensando ionic PMD (net_ionic) and define initial probe and remove callbacks with adapter initialization. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- doc/guides/nics/features/ionic.ini | 2 + drivers/net/ionic/Makefile | 3 + drivers/net/ionic

[dpdk-dev] [PATCH v4 09/17] net/ionic: add notifyq support

2019-12-19 Thread Alfredo Cardigliano
Add support for the notify queue, which is used for events published by the NIC. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- drivers/net/ionic/ionic.h| 2 + drivers/net/ionic/ionic_ethdev.c | 97 +++ drivers/net/ionic/ionic_lif.c| 196

[dpdk-dev] [PATCH v4 08/17] net/ionic: add adminq support

2019-12-19 Thread Alfredo Cardigliano
Add support for the admin queue, which is used for most of the NIC configurations. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- drivers/net/ionic/ionic.h | 3 + drivers/net/ionic/ionic_dev.c | 255 +++ drivers/net/ionic/ionic_dev.h | 95

[dpdk-dev] [PATCH v4 05/17] net/ionic: add port management commands

2019-12-19 Thread Alfredo Cardigliano
Add port management commands that apply to the physical ports associated with the PCI device, which might be shared among several logical interfaces. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- drivers/net/ionic/ionic.h| 6 ++ drivers/net/ionic/ionic_dev.c

[dpdk-dev] [PATCH v4 03/17] net/ionic: add log

2019-12-19 Thread Alfredo Cardigliano
Add debug options to the config file. Define macros used for logs and make use of config file options to enable them. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- drivers/net/ionic/Makefile | 2 +- drivers/net/ionic/ionic_ethdev.c | 15 +++ drivers/net

[dpdk-dev] [PATCH v4 01/17] net/ionic: add skeleton

2019-12-19 Thread Alfredo Cardigliano
Add makefile and config file options to compile the Pensando ionic PMD. Add feature and version map file. Update maintainers file. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- MAINTAINERS | 6 +++ config/common_armv8a_linux

[dpdk-dev] [PATCH v4 00/17] Introduces net/ionic PMD

2019-12-19 Thread Alfredo Cardigliano
adapters description pages - Fix compilation warnings - Other minor fixes Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson Alfredo Cardigliano (17): net/ionic: add skeleton net/ionic: add hardware structures definitions net/ionic: add log net/ionic: register and initialize the

[dpdk-dev] [PATCH v4 02/17] net/ionic: add hardware structures definitions

2019-12-19 Thread Alfredo Cardigliano
Add hardware structures and message commands definitions for Pensando network adapters. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- drivers/net/ionic/ionic_if.h | 2491 ++ 1 file changed, 2491 insertions(+) create mode 100644 drivers/net

Re: [dpdk-dev] [PATCH v3 02/17] net/ionic: add hardware structures definitions

2019-12-17 Thread Alfredo Cardigliano
h > >> -Original Message- >> From: Ferruh Yigit >> Sent: Wednesday, December 11, 2019 12:19 AM >> To: Alfredo Cardigliano >> Cc: dev@dpdk.org; Hemant Agrawal ; Stephen >> Hemminger >> Subject: Re: [dpdk-dev] [PATCH v3 02/17] net/ionic: add hardw

Re: [dpdk-dev] [PATCH v3 01/17] net/ionic: add skeleton

2019-12-12 Thread Alfredo Cardigliano
> On 12 Dec 2019, at 13:39, Ferruh Yigit wrote: > > On 12/12/2019 12:01 PM, Alfredo Cardigliano wrote: >> >> >>> On 10 Dec 2019, at 19:48, Ferruh Yigit wrote: >>> >>> On 12/9/2019 9:46 PM, Alfredo Cardigliano wrote: >>>> Add ma

Re: [dpdk-dev] [PATCH v3 04/17] net/ionic: register and initialize the adapter

2019-12-12 Thread Alfredo Cardigliano
> On 10 Dec 2019, at 19:50, Ferruh Yigit wrote: > > On 12/9/2019 9:46 PM, Alfredo Cardigliano wrote: >> Register the Pensando ionic PMD (net_ionic) and define initial probe >> and remove callbacks with adapter initialization. >> >> Signed-off-by: Alfredo Car

Re: [dpdk-dev] [PATCH v3 01/17] net/ionic: add skeleton

2019-12-12 Thread Alfredo Cardigliano
> On 10 Dec 2019, at 19:48, Ferruh Yigit wrote: > > On 12/9/2019 9:46 PM, Alfredo Cardigliano wrote: >> Add makefile and config file options to compile the Pensando ionic PMD. >> Add feature and version map file. >> Update maintainers file. >> >

[dpdk-dev] [PATCH v3 16/17] net/ionic: add TX checksum support

2019-12-09 Thread Alfredo Cardigliano
Add support for TX checksumming. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- drivers/net/ionic/ionic_ethdev.c | 5 ++ drivers/net/ionic/ionic_lif.c| 1 + drivers/net/ionic/ionic_lif.h| 1 + drivers/net/ionic/ionic_rxtx.c | 90

[dpdk-dev] [PATCH v3 17/17] net/ionic: read fw version

2019-12-09 Thread Alfredo Cardigliano
Add support for reading the firmware version. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- doc/guides/nics/features/ionic.ini | 1 + drivers/net/ionic/ionic.h | 1 + drivers/net/ionic/ionic_dev.c | 8 drivers/net/ionic/ionic_ethdev.c | 20

[dpdk-dev] [PATCH v3 11/17] net/ionic: add RX filters support

2019-12-09 Thread Alfredo Cardigliano
Add support for managing RX filters based on MAC and VLAN. Hardware cannot provide the list of filters, thus we keep a local list. Add support for promisc and allmulticast modes. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- doc/guides/nics/features/ionic.ini | 4

[dpdk-dev] [PATCH v3 14/17] net/ionic: add RSS support

2019-12-09 Thread Alfredo Cardigliano
Add code to manipulate the RSS configuration used by the adapter. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- doc/guides/nics/features/ionic.ini | 3 + drivers/net/ionic/ionic_ethdev.c | 175 + drivers/net/ionic/ionic_ethdev.h | 8

[dpdk-dev] [PATCH v3 15/17] net/ionic: add stats

2019-12-09 Thread Alfredo Cardigliano
Add basic, per queue and extended statistics for RX and TX, both from the adapter and the driver. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- doc/guides/nics/features/ionic.ini | 3 + drivers/net/ionic/ionic_ethdev.c | 253 + drivers/net

[dpdk-dev] [PATCH v3 13/17] net/ionic: add RX and TX handling

2019-12-09 Thread Alfredo Cardigliano
Add RX and TX queues setup and handling. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- doc/guides/nics/features/ionic.ini | 11 + drivers/net/ionic/Makefile | 1 + drivers/net/ionic/ionic_dev.h | 1 + drivers/net/ionic/ionic_ethdev.c | 115 drivers

[dpdk-dev] [PATCH v3 12/17] net/ionic: add Flow Control support

2019-12-09 Thread Alfredo Cardigliano
Add support for managing Flow Control. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- doc/guides/nics/features/ionic.ini | 1 + drivers/net/ionic/ionic_ethdev.c | 56 ++ 2 files changed, 57 insertions(+) diff --git a/doc/guides/nics/features

[dpdk-dev] [PATCH v3 09/17] net/ionic: add notifyq support

2019-12-09 Thread Alfredo Cardigliano
Add support for the notify queue, which is used for events published by the NIC. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- drivers/net/ionic/ionic.h| 2 + drivers/net/ionic/ionic_ethdev.c | 97 +++ drivers/net/ionic/ionic_lif.c| 196

[dpdk-dev] [PATCH v3 10/17] net/ionic: add basic port operations

2019-12-09 Thread Alfredo Cardigliano
Add support for port start/stop and handle basic features including mtu and link up/down. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- doc/guides/nics/features/ionic.ini | 4 + drivers/net/ionic/ionic.h | 1 + drivers/net/ionic/ionic_dev.h | 3

[dpdk-dev] [PATCH v3 08/17] net/ionic: add adminq support

2019-12-09 Thread Alfredo Cardigliano
Add support for the admin queue, which is used for most of the NIC configurations. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- drivers/net/ionic/ionic.h | 3 + drivers/net/ionic/ionic_dev.c | 255 +++ drivers/net/ionic/ionic_dev.h | 95

[dpdk-dev] [PATCH v3 07/17] net/ionic: add doorbells

2019-12-09 Thread Alfredo Cardigliano
Doorbell registers are used by the driver to signal to the NIC that requests are waiting on the message queues. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- drivers/net/ionic/ionic_dev.c | 15 +++ drivers/net/ionic/ionic_dev.h | 19 +++ drivers

[dpdk-dev] [PATCH v3 06/17] net/ionic: add basic lif support

2019-12-09 Thread Alfredo Cardigliano
Initialize LIFs (Logical Interfaces) which represents external connections. The NIC can multiplex many LIFs to a single port, but in most setups, LIF0 is the primary control for the port. Create a device for each LIF. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- drivers

[dpdk-dev] [PATCH v3 03/17] net/ionic: add log

2019-12-09 Thread Alfredo Cardigliano
Add debug options to the config file. Define macros used for logs and make use of config file options to enable them. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- drivers/net/ionic/Makefile | 2 +- drivers/net/ionic/ionic_ethdev.c | 15 +++ drivers/net

[dpdk-dev] [PATCH v3 04/17] net/ionic: register and initialize the adapter

2019-12-09 Thread Alfredo Cardigliano
Register the Pensando ionic PMD (net_ionic) and define initial probe and remove callbacks with adapter initialization. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- doc/guides/nics/features/ionic.ini | 2 + drivers/net/ionic/Makefile | 3 + drivers/net/ionic

[dpdk-dev] [PATCH v3 05/17] net/ionic: add port management commands

2019-12-09 Thread Alfredo Cardigliano
Add port management commands that apply to the physical ports associated with the PCI device, which might be shared among several logical interfaces. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- drivers/net/ionic/ionic.h| 6 ++ drivers/net/ionic/ionic_dev.c

[dpdk-dev] [PATCH v3 01/17] net/ionic: add skeleton

2019-12-09 Thread Alfredo Cardigliano
Add makefile and config file options to compile the Pensando ionic PMD. Add feature and version map file. Update maintainers file. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- MAINTAINERS | 6 config/common_base

[dpdk-dev] [PATCH v3 02/17] net/ionic: add hardware structures definitions

2019-12-09 Thread Alfredo Cardigliano
Add hardware structures and message commands definitions for Pensando network adapters. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- drivers/net/ionic/ionic_if.h | 2491 ++ 1 file changed, 2491 insertions(+) create mode 100644 drivers/net

[dpdk-dev] [PATCH v3 00/17] Introduces net/ionic PMD

2019-12-09 Thread Alfredo Cardigliano
structures size check - Other minor code cleanup Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson Alfredo Cardigliano (17): net/ionic: add skeleton net/ionic: add hardware structures definitions net/ionic: add log net/ionic: register and initialize the adapter net/ionic

Re: [dpdk-dev] [PATCH v2 04/17] net/ionic: register and initialize the adapter

2019-12-08 Thread Alfredo Cardigliano
> On 2 Dec 2019, at 17:09, Ferruh Yigit wrote: > >> + * There is no room in struct rte_pci_driver to keep a reference >> + * to the adapter, using a static list for the time being. >> + */ >> +static LIST_HEAD(ionic_pci_adapters_list, ionic_adapter) ionic_pci_adapters >> = >> +LIST

Re: [dpdk-dev] [PATCH v2 02/17] net/ionic: add hardware structures definitions

2019-12-04 Thread Alfredo Cardigliano
> On 2 Dec 2019, at 17:33, Stephen Hemminger wrote: > > On Tue, 15 Oct 2019 10:22:20 +0200 > Alfredo Cardigliano wrote: > >> Add hardware structures and message commands definitions for >> Pensando network adapters. >> >> Signed-off-by: Alfredo Card

[dpdk-dev] [PATCH v2 16/17] net/ionic: add TX checksum support

2019-10-15 Thread Alfredo Cardigliano
Add support for TX checksumming. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- drivers/net/ionic/ionic_ethdev.c | 5 ++ drivers/net/ionic/ionic_lif.c| 1 + drivers/net/ionic/ionic_lif.h| 1 + drivers/net/ionic/ionic_rxtx.c | 86

[dpdk-dev] [PATCH v2 14/17] net/ionic: add RSS support

2019-10-15 Thread Alfredo Cardigliano
Add code to manipulate the RSS configuration used by the adapter. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- doc/guides/nics/features/ionic.ini | 3 + drivers/net/ionic/ionic_ethdev.c | 175 + drivers/net/ionic/ionic_ethdev.h | 8

[dpdk-dev] [PATCH v2 13/17] net/ionic: add RX and TX handling

2019-10-15 Thread Alfredo Cardigliano
Add RX and TX queues setup and handling. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- doc/guides/nics/features/ionic.ini | 10 + drivers/net/ionic/Makefile | 1 + drivers/net/ionic/ionic_dev.h | 1 + drivers/net/ionic/ionic_ethdev.c | 114 drivers

[dpdk-dev] [PATCH v2 17/17] net/ionic: read fw version

2019-10-15 Thread Alfredo Cardigliano
Add support for reading the firmware version. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- doc/guides/nics/features/ionic.ini | 1 + drivers/net/ionic/ionic.h | 1 + drivers/net/ionic/ionic_dev.c | 8 drivers/net/ionic/ionic_ethdev.c | 20

[dpdk-dev] [PATCH v2 12/17] net/ionic: add Flow Control support

2019-10-15 Thread Alfredo Cardigliano
Add support for managing Flow Control. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- doc/guides/nics/features/ionic.ini | 1 + drivers/net/ionic/ionic_ethdev.c | 56 ++ 2 files changed, 57 insertions(+) diff --git a/doc/guides/nics/features

[dpdk-dev] [PATCH v2 11/17] net/ionic: add RX filters support

2019-10-15 Thread Alfredo Cardigliano
Add support for managing RX filters based on MAC and VLAN. Hardware cannot provide the list of filters, thus we keep a local list. Add support for promisc and allmulticast modes. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- doc/guides/nics/features/ionic.ini | 4

[dpdk-dev] [PATCH v2 15/17] net/ionic: add stats

2019-10-15 Thread Alfredo Cardigliano
Add basic, per queue and extended statistics for RX and TX, both from the adapter and the driver. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- doc/guides/nics/features/ionic.ini | 3 + drivers/net/ionic/ionic_ethdev.c | 253 + drivers/net

[dpdk-dev] [PATCH v2 10/17] net/ionic: add basic port operations

2019-10-15 Thread Alfredo Cardigliano
Add support for port start/stop and handle basic features including mtu and link up/down. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- doc/guides/nics/features/ionic.ini | 4 + drivers/net/ionic/ionic.h | 1 + drivers/net/ionic/ionic_dev.h | 3

[dpdk-dev] [PATCH v2 07/17] net/ionic: add doorbells

2019-10-15 Thread Alfredo Cardigliano
Doorbell registers are used by the driver to signal to the NIC that requests are waiting on the message queues. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- drivers/net/ionic/ionic_dev.c | 15 +++ drivers/net/ionic/ionic_dev.h | 19 +++ drivers

[dpdk-dev] [PATCH v2 08/17] net/ionic: add adminq support

2019-10-15 Thread Alfredo Cardigliano
Add support for the admin queue, which is used for most of the NIC configurations. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- drivers/net/ionic/ionic.h | 4 + drivers/net/ionic/ionic_dev.c | 256 drivers/net/ionic/ionic_dev.h | 96

[dpdk-dev] [PATCH v2 09/17] net/ionic: add notifyq support

2019-10-15 Thread Alfredo Cardigliano
Add support for the notify queue, which is used for events published by the NIC. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- drivers/net/ionic/ionic.h| 2 + drivers/net/ionic/ionic_ethdev.c | 97 drivers/net/ionic/ionic_lif.c| 192

[dpdk-dev] [PATCH v2 06/17] net/ionic: add basic lif support

2019-10-15 Thread Alfredo Cardigliano
Initialize LIFs (Logical Interfaces) which represents external connections. The NIC can multiplex many LIFs to a single port, but in most setups, LIF0 is the primary control for the port. Create a device for each LIF. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- drivers

[dpdk-dev] [PATCH v2 04/17] net/ionic: register and initialize the adapter

2019-10-15 Thread Alfredo Cardigliano
Register the Pensando ionic PMD (net_ionic) and define initial probe and remove callbacks with adapter initialization. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- doc/guides/nics/features/ionic.ini | 2 + drivers/net/ionic/Makefile | 3 + drivers/net/ionic

[dpdk-dev] [PATCH v2 05/17] net/ionic: add port management commands

2019-10-15 Thread Alfredo Cardigliano
Add port management commands that apply to the physical ports associated with the PCI device, which might be shared among several logical interfaces. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- drivers/net/ionic/ionic.h| 6 ++ drivers/net/ionic/ionic_dev.c

[dpdk-dev] [PATCH v2 03/17] net/ionic: add log

2019-10-15 Thread Alfredo Cardigliano
Add debug options to the config file. Define macros used for logs and make use of config file options to enable them. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- drivers/net/ionic/Makefile | 2 +- drivers/net/ionic/ionic_ethdev.c | 21

[dpdk-dev] [PATCH v2 02/17] net/ionic: add hardware structures definitions

2019-10-15 Thread Alfredo Cardigliano
Add hardware structures and message commands definitions for Pensando network adapters. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- drivers/net/ionic/ionic_if.h | 2491 ++ 1 file changed, 2491 insertions(+) create mode 100644 drivers/net

[dpdk-dev] [PATCH v2 00/17] Introduces net/ionic PMD

2019-10-15 Thread Alfredo Cardigliano
The patch series provides an initial version of a poll mode driver for Pensando network adapters. The driver name is ionic. v2 Changes: -- - Fix checkpatch warnings - Remove unused log macros - Remove -Wno-deprecated-declarations - Move the RSS patch after Rx/Tx handling Alfredo

[dpdk-dev] [PATCH v2 01/17] net/ionic: add skeleton

2019-10-15 Thread Alfredo Cardigliano
Add makefile and config file options to compile the Pensando ionic PMD. Add feature and version map file. Update maintainers file. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- MAINTAINERS | 6 +++ config/common_base

Re: [dpdk-dev] [PATCH 00/17] Series short description

2019-10-14 Thread Alfredo Cardigliano
Hi Stephen yes, we were thinking of doing a single post for just that reason, but Thomas recommended that we split it up. Thank you Alfredo > On 12 Oct 2019, at 17:28, Stephen Hemminger > wrote: > > On Sat, 12 Oct 2019 02:26:26 +0200 > Alfredo Cardigliano wrote: > &

[dpdk-dev] [PATCH 16/17] net/ionic: add TX checksum support

2019-10-11 Thread Alfredo Cardigliano
Add support for TX checksumming. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- drivers/net/ionic/ionic_ethdev.c |5 ++ drivers/net/ionic/ionic_lif.c|1 drivers/net/ionic/ionic_lif.h|1 drivers/net/ionic/ionic_rxtx.c | 86

[dpdk-dev] [PATCH 17/17] net/ionic: read fw version

2019-10-11 Thread Alfredo Cardigliano
Add support for reading the firmware version. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- doc/guides/nics/features/ionic.ini |1 + drivers/net/ionic/ionic.h |1 + drivers/net/ionic/ionic_dev.c |8 drivers/net/ionic/ionic_ethdev.c

[dpdk-dev] [PATCH 15/17] net/ionic: add stats

2019-10-11 Thread Alfredo Cardigliano
Add basic, per queue and extended statistics for RX and TX, both from the adapter and the driver. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- doc/guides/nics/features/ionic.ini |3 drivers/net/ionic/ionic_ethdev.c | 253

[dpdk-dev] [PATCH 10/17] net/ionic: add basic port operations

2019-10-11 Thread Alfredo Cardigliano
Add support for port start/stop and handle basic features including mtu and link up/down. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- doc/guides/nics/features/ionic.ini |4 drivers/net/ionic/ionic.h |1 drivers/net/ionic/ionic_dev.h |3

[dpdk-dev] [PATCH 09/17] net/ionic: add notifyq support

2019-10-11 Thread Alfredo Cardigliano
Add support for the notify queue, which is used for events published by the NIC. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- drivers/net/ionic/ionic.h|2 drivers/net/ionic/ionic_ethdev.c | 97 +++ drivers/net/ionic/ionic_lif.c| 192

[dpdk-dev] [PATCH 14/17] net/ionic: add RX and TX handling

2019-10-11 Thread Alfredo Cardigliano
Add RX and TX queues setup and handling. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- doc/guides/nics/features/ionic.ini | 10 drivers/net/ionic/Makefile |1 drivers/net/ionic/ionic_dev.h |1 drivers/net/ionic/ionic_ethdev.c | 114

[dpdk-dev] [PATCH 13/17] net/ionic: add RSS support

2019-10-11 Thread Alfredo Cardigliano
Add code to manipulate the RSS configuration used by the adapter. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- doc/guides/nics/features/ionic.ini |3 + drivers/net/ionic/ionic_ethdev.c | 175 drivers/net/ionic/ionic_ethdev.h

[dpdk-dev] [PATCH 11/17] net/ionic: add RX filters support

2019-10-11 Thread Alfredo Cardigliano
Add support for managing RX filters based on MAC and VLAN. Hardware cannot provide the list of filters, thus we keep a local list. Add support for promisc and allmulticast modes. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- doc/guides/nics/features/ionic.ini |4

[dpdk-dev] [PATCH 12/17] net/ionic: net-ionic-add-flow-control-support

2019-10-11 Thread Alfredo Cardigliano
Add support for managing Flow Control. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- doc/guides/nics/features/ionic.ini |1 + drivers/net/ionic/ionic_ethdev.c | 56 2 files changed, 57 insertions(+) diff --git a/doc/guides/nics

[dpdk-dev] [PATCH 07/17] net/ionic: add doorbells

2019-10-11 Thread Alfredo Cardigliano
Doorbell registers are used by the driver to signal to the NIC that requests are waiting on the message queues. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- drivers/net/ionic/ionic_dev.c | 15 +++ drivers/net/ionic/ionic_dev.h | 19

[dpdk-dev] [PATCH 06/17] net/ionic: add basic lif support

2019-10-11 Thread Alfredo Cardigliano
Initialize LIFs (Logical Interfaces) which represents external connections. The NIC can multiplex many LIFs to a single port, but in most setups, LIF0 is the primary control for the port. Create a device for each LIF. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- drivers

[dpdk-dev] [PATCH 08/17] net/ionic: add adminq support

2019-10-11 Thread Alfredo Cardigliano
Add support for the admin queue, which is used for most of the NIC configurations. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- drivers/net/ionic/ionic.h |4 drivers/net/ionic/ionic_dev.c | 256 + drivers/net/ionic/ionic_dev.h

[dpdk-dev] [PATCH 04/17] net/ionic: register and initialize the adapter

2019-10-11 Thread Alfredo Cardigliano
Register the Pensando ionic PMD (net_ionic) and define initial probe and remove callbacks with adapter initialization. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- doc/guides/nics/features/ionic.ini |2 + drivers/net/ionic/Makefile |3 + drivers/net/ionic

[dpdk-dev] [PATCH 05/17] net/ionic: add port management commands

2019-10-11 Thread Alfredo Cardigliano
Add port management commands that apply to the physical ports associated with the PCI device, which might be shared among several logical interfaces. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- drivers/net/ionic/ionic.h|6 ++ drivers/net/ionic/ionic_dev.c

[dpdk-dev] [PATCH 03/17] net/ionic: add log

2019-10-11 Thread Alfredo Cardigliano
Add debug options to the config file. Define macros used for logs and make use of config file options to enable them. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- config/common_base |2 ++ drivers/net/ionic/Makefile |2 +- drivers/net/ionic

[dpdk-dev] [PATCH 01/17] net/ionic: add skeleton

2019-10-11 Thread Alfredo Cardigliano
Add makefile and config file options to compile the Pensando ionic PMD. Add feature and version map file. Update maintainers file. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- MAINTAINERS |6 +++ config/common_base

[dpdk-dev] [PATCH 00/17] Series short description

2019-10-11 Thread Alfredo Cardigliano
The patch series provides an initial version of a poll mode driver for Pensando network adapters. The driver name is ionic. --- Alfredo Cardigliano (17): net/ionic: add skeleton net/ionic: add hardware structures definitions net/ionic: add log net/ionic: register and

  1   2   >