[dpdk-dev] [PATCH] app/testbbdev: fix checking for return value

2019-01-02 Thread Amr Mokhtar
Added assert check for rte_bbdev_*_op_alloc_bulk in bbdev test app Coverity issue: 328516 Coverity issue: 328525 Fixes: f714a18885a6 ("app/testbbdev: add test application for bbdev") Signed-off-by: Amr Mokhtar --- app/test-bbdev/test_bbdev_perf.c | 10 -- 1 file changed, 8

[dpdk-dev] [PATCH v2] bbdev: add missing APIs to map file and tag all experimental

2018-12-19 Thread Amr Mokhtar
- add missing APIs to map file - add experimental tag to all bbdev APIs Signed-off-by: Amr Mokhtar --- lib/librte_bbdev/rte_bbdev.h | 8 lib/librte_bbdev/rte_bbdev_op.h| 12 ++-- lib/librte_bbdev/rte_bbdev_version.map | 4 3 files changed, 14 insertions

[dpdk-dev] [PATCH] bbdev: add missing APIs to map file

2018-12-14 Thread Amr Mokhtar
some application facing functions are missing from the map file. these are added by this patch. Signed-off-by: Amr Mokhtar --- lib/librte_bbdev/rte_bbdev_version.map | 4 1 file changed, 4 insertions(+) diff --git a/lib/librte_bbdev/rte_bbdev_version.map b/lib/librte_bbdev

[dpdk-dev] [PATCH] baseband/turbo_sw: update Turbo driver for FlexRAN 1.6.0

2018-07-19 Thread Amr Mokhtar
Update BBDEV Turbo SW driver download/build instructions for FlexRAN 1.6.0 release Signed-off-by: Amr Mokhtar --- doc/guides/bbdevs/turbo_sw.rst | 38 +++- drivers/baseband/turbo_sw/bbdev_turbo_software.c | 8 ++--- 2 files changed, 22 insertions(+), 24

[dpdk-dev] [PATCH] doc: update turbo software driver build instructions

2018-04-18 Thread Amr Mokhtar
* Download and build instructions for BBDEV turbo_sw driver in compliance with FlexRAN SDK 1.4.0 release. * Added a note to enable building as a shared lib * Minor update for test execution example instruction * Minor update for capabilities supported Signed-off-by: Amr Mokhtar --- doc/guides

[dpdk-dev] [PATCH v2] bbdev: fix exported dynamic log type

2018-02-06 Thread Amr Mokhtar
v lib, * in bbdev null pmd and turbo sw pmd. Fixes: 4935e1e9f76e ("bbdev: introduce wireless base band device lib") Fixes: b8cfe2c9aed2 ("bb/turbo_sw: add software turbo driver") Fixes: 7dc2b1589440 ("bb/null: add null base band device driver") Cc: tho...@monja

[dpdk-dev] [PATCH] bb/turbo_sw: fix exported dynamic log type

2018-02-05 Thread Amr Mokhtar
river") Cc: tho...@monjalon.net Signed-off-by: Amr Mokhtar --- drivers/bbdev/null/bbdev_null.c | 30 +++-- drivers/bbdev/turbo_sw/bbdev_turbo_software.c | 95 +--- lib/librte_bbdev/rte_bbdev.c | 154 +- lib/librte_bbdev/rte_bbdev.h

[dpdk-dev] [PATCH] bb/null: fix exported dynamic log type

2018-02-05 Thread Amr Mokhtar
tho...@monjalon.net Signed-off-by: Amr Mokhtar --- drivers/bbdev/null/bbdev_null.c| 30 --- lib/librte_bbdev/rte_bbdev.c | 154 + lib/librte_bbdev/rte_bbdev.h | 28 +- lib/librte_bbdev/rte_bbdev_op.h| 68 +

[dpdk-dev] [PATCH] examples/bbdev: fix unchecked return value

2018-01-31 Thread Amr Mokhtar
Added a check on rte_bbdev_stats_get() return before printing out the statistics results. Coverity issue: 257018 Fixes: 1ffee690eaa1 ("examples/bbdev: add sample app") Signed-off-by: Amr Mokhtar --- examples/bbdev_app/main.c | 10 +- 1 file changed, 9 insertions(+), 1 deletio

[dpdk-dev] [PATCH] examples/bbdev: fix memory leak

2018-01-31 Thread Amr Mokhtar
xstats and xstats_names buffers were allocated for the purpose of printing eth_xstats, but were not freed before exit. A fix is added to free before exit points. Coverity issue: 257013 Fixes: 1ffee690eaa1 ("examples/bbdev: add sample app") Signed-off-by: Amr Mokhtar --- examples

[dpdk-dev] [PATCH] examples/bbdev: fix out-of-bounds access

2018-01-31 Thread Amr Mokhtar
eth_address was improperly accessed in bbdev example app, this patch removes the use of port_id, it is irrelevant here. Coverity issue: 257021 Fixes: 1ffee690eaa1 ("examples/bbdev: add sample app") Signed-off-by: Amr Mokhtar --- examples/bbdev_app/main.c | 12 ++-- 1 file

[dpdk-dev] [PATCH] app/testbbdev: fix unchecked return value

2018-01-31 Thread Amr Mokhtar
add check for rte_bbdev_callback_register() retun Coverity issue: 257027 Fixes: f714a18885a6 ("app/testbbdev: add test application for bbdev") Signed-off-by: Amr Mokhtar --- app/test-bbdev/test_bbdev_perf.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[dpdk-dev] [PATCH] app/testbbdev: fix out-of-bounds read

2018-01-31 Thread Amr Mokhtar
Coverity issue: 257033 Fixes: f714a18885a6 ("app/testbbdev: add test application for bbdev") Signed-off-by: Amr Mokhtar --- app/test-bbdev/test_bbdev_vector.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-bbdev/test_bbdev_vector.c b/app/

[dpdk-dev] [PATCH] app/testbbdev: fix division or modulo by float zero

2018-01-31 Thread Amr Mokhtar
check that iter > 0 before division Coverity issue: 257027 Coverity issue: 257038 Coverity issue: 257014 Fixes: f714a18885a6 ("app/testbbdev: add test application for bbdev") Signed-off-by: Amr Mokhtar --- app/test-bbdev/test_bbdev_perf.c | 6 +++--- 1 file changed, 3 ins

[dpdk-dev] [PATCH] app/testbbdev: fix buffer null termination due to strncpy

2018-01-31 Thread Amr Mokhtar
use snprintf instead of strncpy to ensure null termination when copying test_vector_filename from cmd arguments. Coverity issue: 257001 Fixes: f714a18885a6 ("app/testbbdev: add test application for bbdev") Signed-off-by: Amr Mokhtar --- app/test-bbdev/main.c | 5 +++-- 1 file

[dpdk-dev] [PATCH v5 0/5] Introducing Wirless Base Band Device (bbdev) abstraction library

2018-01-11 Thread Amr Mokhtar
h/29447/ http://dpdk.org/dev/patchwork/patch/29448/ http://dpdk.org/dev/patchwork/patch/29450/ http://dpdk.org/dev/patchwork/patch/29449/ http://dpdk.org/dev/patchwork/patch/29452/ http://dpdk.org/dev/patchwork/patch/29451/ RFC: http://dpdk.org/dev/patchwork/patch/27984/ Amr Mokhtar (5): bbdev

[dpdk-dev] [PATCH v5 5/5] bbdev: sample app

2018-01-11 Thread Amr Mokhtar
peration-> dequeued -> compared with original signal -> looped-back to the ethdev port Signed-off-by: Amr Mokhtar --- MAINTAINERS|2 + doc/guides/sample_app_ug/bbdev_app.rst | 132 doc/guides/sample_app_ug/index.rst |1 + examples/Makefile

[dpdk-dev] [PATCH v5 3/5] bbdev: software turbo driver

2018-01-11 Thread Amr Mokhtar
- bbdev 'turbo_sw' is the software accelerated version of 3GPP L1 Turbo coding operation using the optimized Intel FlexRAN SDK libraries. - 'turbo_sw' pmd is disabled by default Signed-off-by: Amr Mokhtar Acked-by: Ferruh Yigit --- config/common_base

[dpdk-dev] [PATCH v5 2/5] bbdev: null device driver

2018-01-11 Thread Amr Mokhtar
- 'bbdev_null' is a basic pmd that performs a minimalistic bbdev operation - useful for bbdev smoke testing and in measuring the overhead introduced by the bbdev library - 'bbdev_null' pmd is enabled by default Signed-off-by: Amr Mokhtar Acked-by: Ferruh Yig

[dpdk-dev] [PATCH v5 1/5] bbdev: introducing wireless base band device abstraction lib

2018-01-11 Thread Amr Mokhtar
- wireless baseband device (bbdev) library files - bbdev is tagged as EXPERIMENTAL - Makefiles and configuration macros definition - bbdev library is enabled by default - release notes of the initial version Signed-off-by: Amr Mokhtar Acked-by: Ferruh Yigit --- MAINTAINERS

[dpdk-dev] [PATCH v4 5/5] bbdev: sample app

2017-12-22 Thread Amr Mokhtar
peration-> dequeued -> compared with original signal -> looped-back to the ethdev port Signed-off-by: Amr Mokhtar --- MAINTAINERS|2 + doc/guides/sample_app_ug/bbdev_app.rst | 133 doc/guides/sample_app_ug/index.rst |1 + examples/Makefile

[dpdk-dev] [PATCH v4 0/5] Introducing Wirless Base Band Device (bbdev) abstraction library

2017-12-22 Thread Amr Mokhtar
/dpdk.org/dev/patchwork/patch/29452/ http://dpdk.org/dev/patchwork/patch/29451/ RFC: http://dpdk.org/dev/patchwork/patch/27984/ Amr Mokhtar (5): bbdev: introducing wireless base band device (BBDEV) abstraction library bbdev: PMD drivers (1. bbdev_null) bbdev: PMD drivers (2. turbo_sw)

[dpdk-dev] [PATCH v4 2/5] bbdev: PMD drivers (1. bbdev_null)

2017-12-22 Thread Amr Mokhtar
- 'bbdev_null' is a basic pmd that performs a minimalistic bbdev operation - useful for bbdev smoke testing and in measuring the overhead introduced by the bbdev library - 'bbdev_null' pmd is enabled by default Signed-off-by: Amr Mokht

[dpdk-dev] [PATCH v4 3/5] bbdev: PMD drivers (2. turbo_sw)

2017-12-22 Thread Amr Mokhtar
- bbdev 'turbo_sw' is the software accelerated version of 3GPP L1 Turbo coding operation using the optimized Intel FlexRAN SDK libraries. - 'turbo_sw' pmd is disabled by default Signed-off-by: Amr Mokhtar --- config/common_base |5

[dpdk-dev] [PATCH v4 1/5] bbdev: introducing wireless base band device (BBDEV) abstraction library

2017-12-22 Thread Amr Mokhtar
- wireless baseband device (bbdev) library files - bbdev is tagged as EXPERIMENTAL - makefiles and configuration macros definition - bbdev library is enabled by default - release notes of the initial version Signed-off-by: Amr Mokhtar --- MAINTAINERS|5 + config

[dpdk-dev] [PATCH v3 0/5] Wireless Baseband Device (bbdev)

2017-12-07 Thread Amr Mokhtar
k/patch/29452/ http://dpdk.org/dev/patchwork/patch/29451/ RFC: [1] http://dpdk.org/ml/archives/dev/2017-August/073585.html [2] http://dpdk.org/ml/archives/dev/2017-August/073584.html Amr Mokhtar (5): bbdev: librte_bbdev library bbdev: PMD drivers (null/turbo_sw) bbdev: test applications bbde

[dpdk-dev] [PATCH v3 5/5] bbdev: documentation

2017-12-07 Thread Amr Mokhtar
- Wireless Baseband Device Library Programmer’s Guide - test-bbdev User Guide - BBDEV Sample Application User Guides - Baseband Device Drivers Guides - Doxygen API Signed-off-by: Amr Mokhtar --- doc/api/doxy-api-index.md | 1 + doc/api/doxy-api.conf | 1 + doc

[dpdk-dev] [PATCH v3 4/5] bbdev: sample app

2017-12-07 Thread Amr Mokhtar
- Sample application performing a loop-back over ethernet using a bbbdev device - A packet is received on an Rx ethdev port -> enqueued for baseband operation -> dequeued -> looped-back to a Tx ethdev port - 'Turbo_sw' PMD must be enabled for the app to be functional Signed-

[dpdk-dev] [PATCH v3 2/5] bbdev: PMD drivers (null/turbo_sw)

2017-12-07 Thread Amr Mokhtar
- bbdev 'null' PMD enabled by default - bbdev 'turbo_sw' PMD disabled by default - 'turbo_sw' requires the external FLEXRAN SDK libraries Signed-off-by: Amr Mokhtar --- drivers/Makefile |2 + drivers/bbdev/Makefile

[dpdk-dev] [PATCH v3 1/5] bbdev: librte_bbdev library

2017-12-07 Thread Amr Mokhtar
AINTAINERS @@ -272,6 +272,17 @@ F: lib/librte_cryptodev/ F: test/test/test_cryptodev* F: examples/l2fwd-crypto/ +BBDEV API - EXPERIMENTAL +M: Amr Mokhtar +F: lib/librte_bbdev/ +F: drivers/bbdev/ +F: app/test-bbdev +F: examples/bbdev_app/ +F: doc/guides/bbdevs/ +F: doc/guides/prog_guide/bbdev.r

[dpdk-dev] [PATCH v2 0/5] Wireless Base Band Device (bbdev)

2017-10-17 Thread Amr Mokhtar
dk.org/ml/archives/dev/2017-August/073584.html Amr Mokhtar (5): bbdev: librte_bbdev library bbdev: PMD drivers (null/turbo_sw) bbdev: test applications bbdev: sample app bbdev: documentation MAINTAINERS| 10 + app

[dpdk-dev] [PATCH v2 5/5] bbdev: documentation

2017-10-17 Thread Amr Mokhtar
- Wireless Baseband Device Library Programmer’s Guide - test-bbdev User Guide - BBDEV Sample Application User Guides - Baseband Device Drivers Guides - Doxygen API Signed-off-by: Amr Mokhtar --- doc/api/doxy-api-index.md | 1 + doc/api/doxy-api.conf | 1 + doc

[dpdk-dev] [PATCH v2 4/5] bbdev: sample app

2017-10-17 Thread Amr Mokhtar
- Sample application performing a loop-back over ethernet using a bbbdev device - A packet is received on an Rx ethdev port -> enqueued for baseband operation -> dequeued -> looped-back to a Tx ethdev port - 'Turbo_sw' PMD must be enabled for the app to be functional Signed-

[dpdk-dev] [PATCH v2 2/5] bbdev: PMD drivers (null/turbo_sw)

2017-10-17 Thread Amr Mokhtar
- bbdev 'null' PMD enabled by default - bbdev 'turbo_sw' PMD disabled by default - 'turbo_sw' requires the external FLEXRAN SDK libraries Signed-off-by: Amr Mokhtar --- drivers/Makefile |2 + drivers/bbdev/Makefile

[dpdk-dev] [PATCH v2 1/5] bbdev: librte_bbdev library

2017-10-17 Thread Amr Mokhtar
ff --git a/MAINTAINERS b/MAINTAINERS index 2a58378..df63f3f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -275,6 +275,16 @@ T: git://dpdk.org/next/dpdk-next-eventdev F: lib/librte_eventdev/*eth_rx_adapter* F: test/test/test_event_eth_rx_adapter.c +BBDEV API - EXPERIMENTAL +M: Amr Mokhtar +F: lib/li

[dpdk-dev] [PATCH v1 6/6] bbdev: auxiliary changes to DPDK framework

2017-09-29 Thread Amr Mokhtar
Signed-off-by: Amr Mokhtar --- MAINTAINERS| 10 ++ config/common_base | 23 +++ doc/guides/rel_notes/release_17_11.rst | 10 ++ mk/rte.app.mk | 13 + 4 files changed, 56

[dpdk-dev] [PATCH v1 5/6] bbdev: documentation

2017-09-29 Thread Amr Mokhtar
Signed-off-by: Amr Mokhtar --- doc/api/doxy-api-index.md| 1 + doc/api/doxy-api.conf| 1 + doc/guides/bbdevs/index.rst | 40 ++ doc/guides/bbdevs/null.rst | 77 doc/guides/bbdevs/turbo_sw.rst

[dpdk-dev] [PATCH v1 4/6] bbdev: sample app

2017-09-29 Thread Amr Mokhtar
Signed-off-by: Amr Mokhtar --- examples/Makefile |1 + examples/bbdev_app/Makefile | 50 ++ examples/bbdev_app/main.c | 1260 +++ 3 files changed, 1311 insertions(+) create mode 100644 examples/bbdev_app/Makefile create mode 100644

[dpdk-dev] [PATCH v1 0/6] Wireless Base Band Device (bbdev)

2017-09-29 Thread Amr Mokhtar
/prog_guide/bbdev.rst [1] http://dpdk.org/ml/archives/dev/2017-August/073585.html [1] http://dpdk.org/ml/archives/dev/2017-August/073584.html Amr Mokhtar (6): bbdev: librte_bbdev library bbdev: PMD drivers (null/turbo_sw) bbdev: test applications bbdev: sample app bbdev: documentation

[dpdk-dev] [PATCH v1 1/6] bbdev: librte_bbdev library

2017-09-29 Thread Amr Mokhtar
Signed-off-by: Amr Mokhtar --- lib/Makefile |3 + lib/librte_bbdev/Makefile | 59 ++ lib/librte_bbdev/rte_bbdev.c | 1065 lib/librte_bbdev/rte_bbdev.h | 637 +++ lib/librte_bbdev

[dpdk-dev] [PATCH v1 2/6] bbdev: PMD drivers (null/turbo_sw)

2017-09-29 Thread Amr Mokhtar
Signed-off-by: Amr Mokhtar --- drivers/Makefile |2 + drivers/bbdev/Makefile | 41 + drivers/bbdev/null/Makefile| 54 + drivers/bbdev/null/bbdev_null.c| 350 + drivers/bbdev

[dpdk-dev] [RFC] Wireless Base Band Device (bbdev)

2017-08-25 Thread Amr Mokhtar
Signed-off-by: Amr Mokhtar --- lib/librte_bbdev/rte_bbdev.h | 636 +++ lib/librte_bbdev/rte_bbdev_op.h | 333 lib/librte_bbdev/rte_bbdev_pmd.h | 407 + 3 files changed, 1376 insertions(+) create mode 100644

[dpdk-dev] [RFC] Wireless Base Band Device (bbdev)

2017-08-25 Thread Amr Mokhtar
*turbo_enc; }; }; Find the enclosed patch for the complete API specification, application- and driver-facing APIs. Looking forward to getting comments from both the application and driver Amr Mokhtar (1): Wireless Base Band Device (bbdev) lib/librte_bbdev/rte_bbdev.h