Re: [PATCH] ethdev: convert string initialization

2024-10-04 Thread Andrew Rybchenko
1135 | .hdr.vni = "\xff\xff\xff", |^~ Signed-off-by: Ferruh Yigit Acked-by: Morten Brørup Acked-by: Bruce Richardson Acked-by: Andrew Rybchenko

Re: [PATCH v3 09/18] net/sfc: fix use-after-free warning messages

2024-09-29 Thread Andrew Rybchenko
flows") Signed-off-by: Stephen Hemminger Reviewed-by: Ivan Malov Acked-by: Andrew Rybchenko

Re: [PATCH v1] ethdev: fix int overflow in descriptor count logic

2024-09-23 Thread Andrew Rybchenko
or the fix. Reviewed-by: Andrew Rybchenko

Re: [PATCH 11/11] drivers: use per line logging in helpers

2024-09-09 Thread Andrew Rybchenko
On 9/9/24 09:55, David Marchand wrote: On Sun, Sep 8, 2024 at 10:55 AM Andrew Rybchenko wrote: On 9/7/24 17:54, David Marchand wrote: Use RTE_LOG_LINE in existing macros that append a \n. Signed-off-by: David Marchand [snip] diff --git a/drivers/common/sfc_efx/sfc_efx_log.h b/drivers

Re: [PATCH 11/11] drivers: use per line logging in helpers

2024-09-08 Thread Andrew Rybchenko
On 9/7/24 17:54, David Marchand wrote: Use RTE_LOG_LINE in existing macros that append a \n. Signed-off-by: David Marchand [snip] diff --git a/drivers/common/sfc_efx/sfc_efx_log.h b/drivers/common/sfc_efx/sfc_efx_log.h index 1519ebdc17..b41ef3490b 100644 --- a/drivers/common/sfc_efx/sfc_ef

Re: [PATCH 05/11] drivers: reuse default logtype for SFC drivers

2024-09-08 Thread Andrew Rybchenko
On 9/7/24 17:54, David Marchand wrote: Nothing is fixed here, just reuse the value coming from the build framework rather than use a fixed string that may get wrong in the future. Signed-off-by: David Marchand Reviewed-by: Andrew Rybchenko

Re: [PATCH 04/11] net/sfc: fix driver logtype token

2024-09-08 Thread Andrew Rybchenko
t; SFC_KVARG_VALUES_FW_VARIANT " " SFC_KVARG_RXD_WAIT_TIMEOUT_NS "= " SFC_KVARG_STATS_UPDATE_PERIOD_MS "="); -RTE_LOG_REGISTER_SUFFIX(sfc_logtype_driver, "driver", NOTICE); +RTE_LOG_REGISTER_SUFFIX(sfc_logtype_driver, driver, NOTICE); Reviewed-by: Andrew Rybchenko

Re: virtio: RSS support capa

2024-09-08 Thread Andrew Rybchenko
On 9/7/24 23:55, Morten Brørup wrote: From: Morten Brørup [mailto:m...@smartsharesystems.com] Sent: Friday, 6 September 2024 21.38 Maxime, Chenbo, If the virtio PMD supports RSS, it should be announced in its capabilities. I think this should be added to virtio_dev_info_get(): if (hos

Re: [PATCH 1/4] ethdev: verify queue ID when Tx done cleanup

2024-09-05 Thread Andrew Rybchenko
On 9/5/24 09:46, Jie Hai wrote: From: Chengwen Feng Verify queue_id for rte_eth_tx_done_cleanup API. If I'm not mistaken the function is considered data path API (fast). If so, it should not validate it's parameters as in rte_eth_tx_burst(). It may be done under RTE_ETHDEV_DEBUG_TX only. May

Re: [PATCH v3 1/3] ethdev: add description for KEEP CRC offload

2024-09-04 Thread Andrew Rybchenko
ength to pkt_len. So it is very necessary to add comments for this. Fixes: 70815c9ecadd ("ethdev: add new offload flag to keep CRC") Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang Acked-by: Morten Brørup Acked-by: Huisong Li Acked-by: Jie Hai Acked-by: Andrew Rybchenko

Re: [PATCH 3/6] net/sfc: remove use of EAL logtype

2024-06-25 Thread Andrew Rybchenko
On 6/25/24 15:24, David Marchand wrote: When registering a common logtype for this driver, instead of explicitly fall back to EAL, rely on the log registration macro to achieve the same. Signed-off-by: David Marchand Reviewed-by: Andrew Rybchenko Thanks

Re: [PATCH 1/6] vdpa/sfc: remove dead code

2024-06-25 Thread Andrew Rybchenko
d Marchand Reviewed-by: Andrew Rybchenko

Re: [PATCH] mempool: dump includes list of memory chunks

2024-06-10 Thread Andrew Rybchenko
On 5/16/24 11:59, Morten Brørup wrote: Added information about the memory chunks holding the objects in the mempool when dumping the status of the mempool to a file. Signed-off-by: Morten Brørup Reviewed-by: Andrew Rybchenko

Re: [PATCH] net/hns3: fix Rx packet truncation when KEEP CRC enabled

2024-06-03 Thread Andrew Rybchenko
On 6/3/24 05:33, Stephen Hemminger wrote: On Mon, 3 Jun 2024 09:38:19 +0800 Jie Hai wrote: On 2024/3/1 19:10, Ferruh Yigit wrote: On 3/1/2024 6:55 AM, huangdengdui wrote: On 2024/2/29 17:25, Ferruh Yigit wrote: On 2/29/2024 3:58 AM, huangdengdui wrote: On 2024/2/28 21:07, Ferruh Yigit

Re: [PATCH 2/2] mempool: use rte constant macro instead of GCC builtin

2024-05-29 Thread Andrew Rybchenko
Retzlaff --- Reviewed-by: Morten Brørup Reviewed-by: Andrew Rybchenko

Re: [PATCH 1/2] eal: provide macro for GCC builtin constant intrinsic

2024-05-29 Thread Andrew Rybchenko
RTE_TOOLCHAIN_MSVC +#define __rte_constant(e) 0 +#else +#define __rte_constant(e) __extension__(__builtin_constant_p(e)) +#endif + Acked-by: Bruce Richardson Reviewed-by: Andrew Rybchenko

Re: [PATCH 1/2] eal: provide macro for GCC builtin constant intrinsic

2024-05-29 Thread Andrew Rybchenko
On 4/1/24 11:34, Morten Brørup wrote: From: Stephen Hemminger [mailto:step...@networkplumber.org] Sent: Monday, 1 April 2024 00.03 On Wed, 20 Mar 2024 14:33:35 -0700 Tyler Retzlaff wrote: +#ifdef RTE_TOOLCHAIN_MSVC +#define __rte_constant(e) 0 +#else +#define __rte_constant(e) __extension__(_

Re: [PATCH v2] app/testpmd: use Tx preparation in txonly engine

2024-02-23 Thread Andrew Rybchenko
On 2/22/24 21:28, Konstantin Ananyev wrote: +CC: Ethernet API maintainers +CC: Jerin (commented on another branch of this thread) From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com] Sent: Sunday, 11 February 2024 16.04 TSO breaks when MSS spans more than 8 data fragments. Those

Re: [PATCH] common/sfc: replace out of bounds condition with static_assert

2024-02-12 Thread Andrew Rybchenko
nd for toolchain issues with missing C11 macro in FreeBSD. Maybe not in this file, but somewhere. Acked-by: Morten Brørup Acked-by: Andrew Rybchenko

Re: [PATCH v2 8/8] net/sfc: fix calloc parameters

2024-01-24 Thread Andrew Rybchenko
Reviewed-by: Andrew Rybchenko

Re: [PATCH v4 1/6] eal: introduce RTE_MIN_T() and RTE_MAX_T() macros

2024-01-18 Thread Andrew Rybchenko
in other scenarios when bounded range is useful. Naming is chosen to be similar to Linux kernel conventions. Signed-off-by: Stephen Hemminger Acked-by: Andrew Rybchenko

Re: [PATCH v4 2/6] event/opdl: fix non-constant compile time assertion

2024-01-18 Thread Andrew Rybchenko
("event/opdl: add OPDL ring infrastructure library") Cc: liang.j...@intel.com Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson Acked-by: Tyler Retzlaff Acked-by: Andrew Rybchenko

Re: [PATCH v4 5/6] mempool: avoid floating point expression in static assertion

2024-01-18 Thread Andrew Rybchenko
with same effect. Modify comment in mlx5 so that developers don't go searching for old value. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Reviewed-by: Andrew Rybchenko

Re: [PATCH v4 3/6] net/sfc: fix non-constant expression in RTE_BUILD_BUG_ON()

2024-01-18 Thread Andrew Rybchenko
ative datapath") Cc: ivan.ma...@oktetlabs.ru Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff One nit below, anyway: Reviewed-by: Andrew Rybchenko --- drivers/net/sfc/sfc_ef100_tx.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/sfc/sfc_ef

Re: [PATCH v3 1/1] ethdev: parsing multiple representor devargs string

2024-01-17 Thread Andrew Rybchenko
On 1/16/24 12:55, Harman Kalra wrote: Adding support for parsing multiple representor devargs strings passed to a PCI BDF. There may be scenario where port representors for various PFs or VFs under PFs are required and all these are representor ports shall be backed by single pci device. In such

Re: static_assert, sfc, and clang issues

2024-01-17 Thread Andrew Rybchenko
On 1/17/24 01:49, Stephen Hemminger wrote: On Tue, 16 Jan 2024 23:14:36 +0100 Morten Brørup wrote: +1 for #2 just make it a block. I prefer that you implement the workaround in the RTE_BUILD_BUG_ON() macro, by surrounding it by "do { } while (0)", like this: #define RTE_BUILD_BUG_ON(condit

Re: [PATCH v3 4/5] mempool: avoid floating point expression in static assertion

2024-01-17 Thread Andrew Rybchenko
On 1/16/24 21:41, Stephen Hemminger wrote: Clang does not handle casts in static_assert() expressions. It doesn't like use of floating point to calculate threshold. Use a different expression with same effect; yes this will cause checkpatch nag. Signed-off-by: Stephen Hemminger --- lib/mempoo

Re: [PATCH v3 1/5] event/opdl: fix non-constant compile time assertion

2024-01-16 Thread Andrew Rybchenko
On 1/16/24 21:41, Stephen Hemminger wrote: RTE_BUILD_BUG_ON() was being used with a non-constant value. The inline function rte_is_power_of_2() is not constant since inline expansion happens later in the compile process. Replace it with macro which will be constant. Fixes: 4236ce9bf5bf ("event/o

Re: [PATCH v3 2/5] net/sfc: fix non-constant expression in RTE_BUILD_BUG_ON()

2024-01-16 Thread Andrew Rybchenko
On 1/16/24 21:41, Stephen Hemminger wrote: The macro RTE_MIN has some hidden assignments to provide type safety which means the statement can not be fully evaluated in first pass of compiler. Replace RTE_MIN() with equivalent macro. This will cause errors from checkpatch about multiple evaluatio

Re: [PATCH v3 5/5] eal: replace out of bounds VLA with static_assert

2024-01-16 Thread Andrew Rybchenko
Acked-by: Tyler Retzlaff Acked-by: Andrew Rybchenko Does it imply any limitations on Gcc / Clang versions to be used? Is it documented somewhere in DPDK?

Re: [PATCH v2 2/3] ethdev: add compare item

2024-01-12 Thread Andrew Rybchenko
than) - RTE_FLOW_ITEM_COMPARE_LE (less than or equal) - RTE_FLOW_ITEM_COMPARE_GT (great than) - RTE_FLOW_ITEM_COMPARE_GE (great than or equal) Signed-off-by: Suanming Mou Just one nit below, anyway Acked-by: Andrew Rybchenko I dislike that many line of code are moved, but it looks like

Re: [PATCH v2 1/3] ethdev: rename action modify field data structure

2024-01-12 Thread Andrew Rybchenko
to "rte_flow_field_data" making it compatible to be used by item. Signed-off-by: Suanming Mou --- Acked-by: Ori Kam Best, Ori Acked-by: Andrew Rybchenko

Re: [RFC] ethdev: introduce entropy calculation

2024-01-11 Thread Andrew Rybchenko
Hi Ori, sorry for delay with reply. On 12/17/23 13:07, Ori Kam wrote: Hi Andrew, -Original Message- From: Andrew Rybchenko Sent: Saturday, December 16, 2023 11:19 AM On 12/10/23 11:30, Ori Kam wrote: When offloading rules with the encap action, the HW may calculate entropy based

Re: [PATCH 2/2] doc: multiple representors in one device

2024-01-11 Thread Andrew Rybchenko
On 1/11/24 09:44, Harman Kalra wrote: Updating the documentation with the pattern format for enabling multiple representors in one device Signed-off-by: Harman Kalra IMHO it should be squashed into previous patch.

Re: [PATCH 1/2] ethdev: parsing multiple representor devargs string

2024-01-11 Thread Andrew Rybchenko
On 1/11/24 09:44, Harman Kalra wrote: Adding support for parsing multiple representor devargs strings passed to a PCI BDF. There may be scenario where port representors for various PFs or VFs under PFs are required and all these are representor ports shall be backed by single pci device. In such

Re: [dpdk-dev v4 2/2] net/tap: fix buffer overflow for ptypes list through driver API update

2024-01-11 Thread Andrew Rybchenko
On 1/4/24 20:51, Sivaramakrishnan Venkat wrote: Incorrect ptypes list causes buffer overflow for Address Sanitizer run. Previously, the last element in the ptypes lists to be "RTE_PTYPE_UNKNOWN" for rte_eth_dev_get_supported_ptypes(), but this was not clearly documented and many PMDs did not foll

Re: [dpdk-dev] [v1] ethdev: support Tx queue used count

2024-01-11 Thread Andrew Rybchenko
. A notable use case could be implementing Random Early Discard (RED) in software based on Tx queue occupancy. Signed-off-by: Jerin Jacob with few nits below Reviewed-by: Andrew Rybchenko [snip] diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst index f7d9980849

Re: [PATCH v3 08/14] lib: simplify multilines log messages

2023-12-18 Thread Andrew Rybchenko
On 12/18/23 12:27, David Marchand wrote: Those error log messages don't need to span on multiple lines. Signed-off-by: David Marchand Acked-by: Tyler Retzlaff Reviewed-by: Andrew Rybchenko

Re: [PATCH v4 5/5] bus/vdev: check result of rte_vdev_device_name

2023-12-16 Thread Andrew Rybchenko
(function name). Other than that: Reviewed-by: Andrew Rybchenko

Re: [PATCH v4 2/5] ethdev: check return result of rte_eth_dev_info_get

2023-12-16 Thread Andrew Rybchenko
On 12/16/23 13:06, Andrew Rybchenko wrote: On 7/10/23 20:07, Stephen Hemminger wrote: From: Sinan Kaya rte_class_eth: eth_mac_cmp: The status of this call to rte_eth_dev_info_get is not checked, potentially leaving dev_info uninitialized. Signed-off-by: Sinan Kaya Signed-off-by: Stephen

Re: [PATCH v4 2/5] ethdev: check return result of rte_eth_dev_info_get

2023-12-16 Thread Andrew Rybchenko
Reviewed-by: Andrew Rybchenko

Re: [PATCH v3 11/22] ethdev: replace strtok with reentrant version

2023-12-16 Thread Andrew Rybchenko
-reentrant, it is better to replace it with a reentrant version. Fixes: f38f62650f7b ("ethdev: add Rx queue telemetry query") Fixes: 9e7533aeb80a ("ethdev: add telemetry command for TM level capabilities") Cc: sta...@dpdk.org Signed-off-by: Jie Hai Acked-by: Chengwen Feng

Re: [RFC v2 03/14] lib: use dedicated logtypes

2023-12-16 Thread Andrew Rybchenko
the rest of eventdev (private) macros. Cc: sta...@dpdk.org Signed-off-by: David Marchand Reviewed-by: Andrew Rybchenko

Re: [RFC v2 04/14] lib: add newline in logs

2023-12-16 Thread Andrew Rybchenko
On 12/8/23 17:59, David Marchand wrote: Fix places leading to a log message not terminated with a newline. Cc: sta...@dpdk.org Signed-off-by: David Marchand For ethdev: Reviewed-by: Andrew Rybchenko

Re: [RFC v2 13/14] lib: replace logging helpers

2023-12-16 Thread Andrew Rybchenko
y publicly exposed logging helpers, when such helper is not publicly used (iow in public inline API), it is removed from the public API (this is the case for the member library), Signed-off-by: David Marchand For ethdev Reviewed-by: Andrew Rybchenko

Re: [RFC v2 14/14] lib: use per line logging in helpers

2023-12-16 Thread Andrew Rybchenko
On 12/8/23 17:59, David Marchand wrote: Use RTE_LOG_LINE in existing macros that append a \n. Signed-off-by: David Marchand --- Changes since RFC v1: - converted all logging helpers in lib/, --- For ethdev Reviewed-by: Andrew Rybchenko

Re: [RFC v2 12/14] lib: convert to per line logging

2023-12-16 Thread Andrew Rybchenko
cial cases, Signed-off-by: David Marchand For mempool, Reviewed-by: Andrew Rybchenko

Re: [RFC v2 08/14] lib: simplify multilines log messages

2023-12-16 Thread Andrew Rybchenko
On 12/8/23 20:05, Stephen Hemminger wrote: On Fri, 8 Dec 2023 15:59:42 +0100 David Marchand wrote: Those error log messages don't need to span on multiple lines. Signed-off-by: David Marchand --- lib/acl/tb_mem.c| 2 +- lib/bpf/bpf_stub.c | 4 ++-- lib/eal

Re: [RFC] ethdev: introduce entropy calculation

2023-12-16 Thread Andrew Rybchenko
On 12/10/23 11:30, Ori Kam wrote: When offloading rules with the encap action, the HW may calculate entropy based on the encap protocol. Each HW can implement a different algorithm. When the application receives packets that should have been encaped by the HW, but didn't reach this stage yet (f

Re: [RFC] ethdev: introduce entropy calculation

2023-12-16 Thread Andrew Rybchenko
On 12/15/23 19:21, Thomas Monjalon wrote: 15/12/2023 14:44, Ferruh Yigit: On 12/14/2023 5:26 PM, Stephen Hemminger wrote: On Thu, 14 Dec 2023 17:18:25 + Ori Kam wrote: Since encap groups number of different 5 tuples together, if HW doesn’t know how to RSS based on the inner application w

Re: [PATCH v2] ethdev: account for smaller MTU when setting default

2023-11-08 Thread Andrew Rybchenko
minimum of the maximum suported MTU and the default DPDK MTU. Fixes: 1bb4a528c4 ("ethdev: fix max Rx packet length") Signed-off-by: Joshua Washington Signed-off-by: Rushil Gupta Acked-by: Andrew Rybchenko

Re: [PATCH v5 2/5] net/sfc: use new API to parse kvargs

2023-11-06 Thread Andrew Rybchenko
On 11/6/23 15:29, fengchengwen wrote: Hi Andrew, On 2023/11/6 18:28, Andrew Rybchenko wrote: On 11/6/23 10:31, Chengwen Feng wrote: The sfc_kvargs_process() and sfc_efx_dev_class_get() function could handle both key=value and only-key, so they should use rte_kvargs_process_opt() instead of

Re: [PATCH v2 1/2] mempool: fix internal function documentation

2023-11-06 Thread Andrew Rybchenko
On 10/23/23 12:38, Ferruh Yigit wrote: static function `rte_mempool_do_generic_get()` returns zero on success, not >=0 as its function comment documents. Since this function called by public API, the comment causes confusion on the public API return value. Fixing the internal function documenta

Re: [PATCH v9 1/9] ethdev: overwrite some comment related to RSS

2023-11-06 Thread Andrew Rybchenko
On 11/2/23 11:20, Jie Hai wrote: In rte_eth_dev_rss_hash_conf_get(), the "rss_key_len" should be greater than or equal to the "hash_key_size" which get from rte_eth_dev_info_get() API. And the "rss_key" should contain at least "hash_key_size" bytes. If these requirements are not met, the query un

Re: [PATCH v9 7/9] ethdev: add API to get RSS algorithm names

2023-11-06 Thread Andrew Rybchenko
On 11/2/23 11:20, Jie Hai wrote: This patch adds new API rte_eth_dev_rss_algo_name() to get name of a RSS algorithm and document it. Signed-off-by: Jie Hai Acked-by: Huisong Li Acked-by: Chengwen Feng @@ -4791,6 +4802,20 @@ rte_eth_dev_rss_hash_conf_get(uint16_t port_id, return r

Re: [PATCH v5 2/5] net/sfc: use new API to parse kvargs

2023-11-06 Thread Andrew Rybchenko
On 11/6/23 10:31, Chengwen Feng wrote: The sfc_kvargs_process() and sfc_efx_dev_class_get() function could handle both key=value and only-key, so they should use rte_kvargs_process_opt() instead of rte_kvargs_process() to parse. Signed-off-by: Chengwen Feng --- drivers/common/sfc_efx/sfc_efx.

Re: [PATCH] maintainers: update for mempool library

2023-11-01 Thread Andrew Rybchenko
On November 1, 2023 19:20:29 Morten Brørup wrote: Add co-maintainer for Memory pool. Suggested-by: Thomas Monjalon Signed-off-by: Morten Brørup Acked-by: Andrew Rybchenko --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 4083658697

Re: [PATCH] net/sfc: support packet replay in transfer flows

2023-09-29 Thread Andrew Rybchenko
-off-by: Ivan Malov Reviewed-by: Andy Moreton Acked-by: Andrew Rybchenko

Re: [PATCH] mempool: add cache guard to per-lcore debug statistics

2023-09-29 Thread Andrew Rybchenko
Reviewed-by: Andrew Rybchenko

Re: [PATCH 2/2] net/sfc: support updating indirect VXLAN encap action

2023-09-21 Thread Andrew Rybchenko
On 8/10/23 21:06, Ivan Malov wrote: Such updates are helpful as they let applications avoid costly flow re-insertions when the header data changes. Signed-off-by: Ivan Malov Reviewed-by: Andy Moreton Acked-by: Andrew Rybchenko

Re: [PATCH 1/2] net/sfc: offer indirect VXLAN encap action in transfer flows

2023-09-21 Thread Andrew Rybchenko
Malov Reviewed-by: Andy Moreton Acked-by: Andrew Rybchenko

Re: [PATCH 07/11] drivers: convert to internal control threads

2023-09-11 Thread Andrew Rybchenko
t would be interesting to rework them in future. Signed-off-by: Thomas Monjalon For net/sfc Acked-by: Andrew Rybchenko

Re: [PATCH] net/sfc: account for data offset on Tx

2023-09-11 Thread Andrew Rybchenko
C DMA memory mapping type") Cc: sta...@dpdk.org Signed-off-by: Viacheslav Galaktionov Reviewed-by: Ivan Malov Reviewed-by: Andy Moreton Acked-by: Andrew Rybchenko

Re: [PATCH] net/sfc: set max Rx packet length for representors

2023-09-11 Thread Andrew Rybchenko
On 9/11/23 13:47, Viacheslav Galaktionov wrote: Maximum packet length must be set to configure representor devices. Fixes: a62ec90522a6 ("net/sfc: add port representors infrastructure") Cc: sta...@dpdk.org Signed-off-by: Viacheslav Galaktionov Reviewed-by: Andy Moreton Acked-

Re: [PATCH 30/36] net/sfc: fix Rx and Tx queue state

2023-09-08 Thread Andrew Rybchenko
On 9/8/23 14:28, Jie Hai wrote: The DPDK framework reports the queue state, which is stored in dev->data->tx_queue_state and dev->data->rx_queue_state. The state is maintained by the driver. Users may determine whether a queue participates in packet forwarding based on the state. Therefore, the d

Re: [RFC] ethdev: introduce maximum Rx buffer size

2023-08-11 Thread Andrew Rybchenko
On 8/8/23 07:02, Huisong Li wrote: The Rx buffer size stands for the size hardware supported to receive packets in one mbuf. The "min_rx_bufsize" is the minimum buffer hardware supported in Rx. Actually, some engines also have the maximum buffer specification, like, hns3. For these engines, the a

Re: [PATCH] doc: announce ethdev operation struct changes

2023-07-17 Thread Andrew Rybchenko
interrupt to the application, -- 2.25.1 Ping~ Acked-by: Morten Brørup Acked-by: Andrew Rybchenko

Re: [PATCH 1/1] net/sfc: add explicit fail path for unknown tunnel flow type

2023-07-17 Thread Andrew Rybchenko
urces") Cc: sta...@dpdk.org Signed-off-by: Ivan Malov Acked-by: Andrew Rybchenko

Re: [PATCH 1/1] net/sfc: drop redundant null check from IPv4 flow item parse

2023-07-13 Thread Andrew Rybchenko
") Cc: sta...@dpdk.org Signed-off-by: Ivan Malov Acked-by: Andrew Rybchenko

Re: [PATCH v7 2/4] common/sfc_efx/base: add API to get installed filters count

2023-06-22 Thread Andrew Rybchenko
On 6/22/23 18:11, Artemii Morozov wrote: This API allows to get number of installed filters. This will be used in the future patches. Signed-off-by: Artemii Morozov Acked-by: Andrew Rybchenko However, it would be good if it is reviewed as well by Andy and Ivan.

Re: [PATCH v7 4/4] net/sfc: support VLAN stripping offload

2023-06-22 Thread Andrew Rybchenko
Reviewed-by: Andy Moreton Acked-by: Andrew Rybchenko

Re: [PATCH v7 3/4] common/sfc_efx/base: add support to enable VLAN stripping

2023-06-22 Thread Andrew Rybchenko
Moreton Acked-by: Andrew Rybchenko

Re: [PATCH v6 4/4] net/sfc: support VLAN stripping offload

2023-06-22 Thread Andrew Rybchenko
On 6/22/23 14:31, Artemii Morozov wrote: Extract VLAN TCI provided by the HW in the prefix and put it to mbuf. VLAN stripping is supported for ef100 datapath only. This is device level offload. Signed-off-by: Artemii Morozov Reviewed-by: Viacheslav Galaktionov Reviewed-by: Ivan Malov Reviewed

Re: [PATCH v6 3/4] common/sfc_efx/base: add support to enable VLAN stripping

2023-06-22 Thread Andrew Rybchenko
Moreton with minor style fix, see below: Acked-by: Andrew Rybchenko diff --git a/drivers/common/sfc_efx/base/ef10_filter.c b/drivers/common/sfc_efx/base/ef10_filter.c index 278502fb61..827b3e8f00 100644 --- a/drivers/common/sfc_efx/base/ef10_filter.c +++ b/drivers/common/sfc_efx/base

Re: [PATCH v6 2/4] common/sfc_efx/base: add API to get installed filters count

2023-06-22 Thread Andrew Rybchenko
On 6/22/23 14:31, Artemii Morozov wrote: This API allows to get number of installed filters. This will be used in the future patches. Signed-off-by: Artemii Morozov --- drivers/common/sfc_efx/base/ef10_filter.c | 20 + drivers/common/sfc_efx/base/ef10_impl.h | 6 + dr

Re: [PATCH v6 1/4] common/sfc_efx/base: report VLAN stripping capability

2023-06-22 Thread Andrew Rybchenko
On 6/22/23 14:31, Artemii Morozov wrote: These changes are necessary in order to add support for stripping VLAN tags in the future. Signed-off-by: Artemii Morozov Reviewed-by: Ivan Malov Reviewed-by: Andy Moreton Acked-by: Andrew Rybchenko

Re: [PATCH v2 4/4] net/sfc: add configurable Rx CRC stripping

2023-06-22 Thread Andrew Rybchenko
contain CRC length. At the same time, CRC length should be removed from stats. Signed-off-by: Denis Pryazhennikov Signed-off-by: Roman Zhukov Reviewed-by: Andy Moreton Acked-by: Andrew Rybchenko

Re: [PATCH v2 1/4] common/sfc_efx/base: discover NIC partitioning mode

2023-06-22 Thread Andrew Rybchenko
-off-by: Denis Pryazhennikov Reviewed-by: Andy Moreton Overall LGMT with few style notes: Acked-by: Andrew Rybchenko [snip] +#define CAP_PFS_TO_PORTS(_n) \ + (MC_CMD_GET_CAPABILITIES_V2_OUT_PFS_TO_PORTS_ASSIGNMENT_ ## _n) + + encp->enc_port_usage = EFX_PORT_USAGE_UNKN

Re: [PATCH v3] common/sfc_efx/base: set return code in case of the error

2023-06-22 Thread Andrew Rybchenko
sh") I guess Cc: sta...@dpdk.org is missing Signed-off-by: Artemii Morozov Reviewed-by: Andy Moreton Acked-by: Andrew Rybchenko

Re: [PATCH v5 2/3] common/sfc_efx/base: add support to enable VLAN stripping

2023-06-20 Thread Andrew Rybchenko
On 6/20/23 16:10, Artemii Morozov wrote: On 6/20/23 15:50, Andrew Rybchenko wrote: On 6/20/23 12:55, Artemii Morozov wrote: On 6/19/23 14:28, Andrew Rybchenko wrote: On 6/13/23 18:12, Artemii Morozov wrote: To enable VLAN stripping, two conditions must be met: the corresponding flag must

Re: [PATCH v5 2/3] common/sfc_efx/base: add support to enable VLAN stripping

2023-06-20 Thread Andrew Rybchenko
On 6/20/23 12:55, Artemii Morozov wrote: On 6/19/23 14:28, Andrew Rybchenko wrote: On 6/13/23 18:12, Artemii Morozov wrote: To enable VLAN stripping, two conditions must be met: the corresponding flag must be set and the appropriate RX prefix should be requested. RX -> Rx VLAN stripp

Re: [PATCH 1/3] net/sfc: split link update function

2023-06-20 Thread Andrew Rybchenko
On 6/20/23 14:25, Ferruh Yigit wrote: On 6/2/2023 9:52 AM, Andrew Rybchenko wrote: On 6/2/23 01:23, Denis Pryazhennikov wrote: Separate the original link update function into two functions: state retrieval and update. This improves code clarity and maintainability. Signed-off-by: Denis

Re: [RFC PATCH v2] ethdev: advertise flow restore in mbuf

2023-06-19 Thread Andrew Rybchenko
rte_eth_rx_metadata_negotiate() and hid rte_flow_restore_info_dynflag_register() into ethdev internals, For ethdev and net/sfc: Acked-by: Andrew Rybchenko

Re: [PATCH v5 3/3] net/sfc: support VLAN stripping offload

2023-06-19 Thread Andrew Rybchenko
Reviewed-by: Andy Moreton Overall LGMT Acked-by: Andrew Rybchenko @@ -892,6 +902,12 @@ sfc_ef100_rx_qstart(struct sfc_dp_rxq *dp_rxq, unsigned int evq_read_ptr, (rxq->flags & SFC_EF100_RXQ_INGRESS_MPORT)) return ENOTSUP; + if ((unsup_rx_prefix

Re: [PATCH v5 2/3] common/sfc_efx/base: add support to enable VLAN stripping

2023-06-19 Thread Andrew Rybchenko
On 6/13/23 18:12, Artemii Morozov wrote: To enable VLAN stripping, two conditions must be met: the corresponding flag must be set and the appropriate RX prefix should be requested. RX -> Rx VLAN stripping is supported for ef100 datapath only. "ef100 datapath" does not make sense in libefx.

Re: [PATCH v5 1/3] common/sfc_efx/base: report VLAN stripping capability

2023-06-19 Thread Andrew Rybchenko
On 6/13/23 18:12, Artemii Morozov wrote: These changes are necessary in order to add support for stripping VLAN tags in the future. Signed-off-by: Artemii Morozov Reviewed-by: Ivan Malov Reviewed-by: Andy Moreton Acked-by: Andrew Rybchenko

Re: [PATCH] ethdev: rename functions checking queue validity

2023-06-19 Thread Andrew Rybchenko
fix, and the verb is at the end. That's why I propose renaming into: rte_eth_*x_queue_is_valid() Fixes: 7ea7e0cd3a08 ("ethdev: add functions to check queue validity") Signed-off-by: Thomas Monjalon Shorter is better. Acked-by: Stephen Hemminger Acked-by: Andrew Rybchenko

Re: [PATCH v2 3/3] net/sfc: support FEC feature

2023-06-19 Thread Andrew Rybchenko
Reviewed-by: Ferruh Yigit Acked-by: Andrew Rybchenko diff --git a/doc/guides/rel_notes/release_23_07.rst b/doc/guides/rel_notes/release_23_07.rst index 027ae7bd2d64..59a215a4a4f8 100644 --- a/doc/guides/rel_notes/release_23_07.rst +++ b/doc/guides/rel_notes/release_23_07.rst @@ -170,6

Re: [PATCH v4 2/3] common/sfc_efx/base: add support to enable VLAN stripping

2023-06-08 Thread Andrew Rybchenko
On 6/8/23 14:16, Artemii Morozov wrote: Hello, On 6/2/23 12:32, Andrew Rybchenko wrote: On 6/1/23 18:30, Artemii Morozov wrote: To enable VLAN stripping, two conditions must be met: the corresponding flag must be set and the appropriate RX prefix should be requested. RX -> Rx V

Re: [PATCH v4 00/34] net/sfc: support HW conntrack assistance

2023-06-08 Thread Andrew Rybchenko
On 6/7/23 16:02, Ivan Malov wrote: On EF100 hardware, match-action engine (MAE) can be equipped with an assistance table for connection tracking (CT). In it, an entry key is a set of exact match fields: an EtherType, a pair of IP addresses, a L4 protocol ID and a pair of L4 port numbers. An entry

Re: [PATCH v3 00/34] net/sfc: support HW conntrack assistance

2023-06-07 Thread Andrew Rybchenko
create mode 100644 drivers/net/sfc/sfc_tbls.c create mode 100644 drivers/net/sfc/sfc_tbls.h With minor notes on some patches fixed Series-acked-by: Andrew Rybchenko

Re: [PATCH v3 10/34] net/sfc: attach to HW table API

2023-06-07 Thread Andrew Rybchenko
On 6/5/23 02:24, Ivan Malov wrote: From: Denis Pryazhennikov The patch adds APIs to initialise, manipulate and finalise HW tables API-specific context in NIC control structure. The context itself will be used to store HW tables-related info, like table descriptors and field descriptors. Signed

Re: [PATCH v3 05/34] common/sfc_efx/base: add API to get HW table desc

2023-06-07 Thread Andrew Rybchenko
On 6/5/23 02:24, Ivan Malov wrote: From: Denis Pryazhennikov Table's descriptor and fields' descriptors can be taken by table ID using a new API. In the near future, only the CT table is planned to be used, so only fields that are required for these purposes were added to the efx. Signed-off-b

Re: [PATCH v3 09/34] net/sfc: add functions to manipulate MCDI table fields

2023-06-07 Thread Andrew Rybchenko
On 6/5/23 02:24, Ivan Malov wrote: From: Denis Pryazhennikov Implemented functions that help to fill user data for manipulation with HW tables in the required format. Signed-off-by: Denis Pryazhennikov Reviewed-by: Ivan Malov Reviewed-by: Andy Moreton --- drivers/net/sfc/meson.build | 1

Re: [PATCH v3 08/34] net/sfc: add MCDI wrappers for BCAM tables

2023-06-07 Thread Andrew Rybchenko
On 6/5/23 02:24, Ivan Malov wrote: From: Denis Pryazhennikov A "table" is structure used for lookups, consisting of a set of entries which can be matched against an N-bit "request", to return either a "hit" with an M-bit "response", or a "miss" if there is no match. There are a number of HW tab

Re: [PATCH v3 05/34] common/sfc_efx/base: add API to get HW table desc

2023-06-07 Thread Andrew Rybchenko
On 6/5/23 02:24, Ivan Malov wrote: From: Denis Pryazhennikov Table's descriptor and fields' descriptors can be taken by table ID using a new API. In the near future, only the CT table is planned to be used, so only fields that are required for these purposes were added to the efx. Signed-off-b

Re: [PATCH 4/4] net/sfc: add configurable Rx CRC stripping

2023-06-07 Thread Andrew Rybchenko
On 6/1/23 14:42, Denis Pryazhennikov wrote: Configurable Rx CRC stripping is allowed only if running firmware variant supports it and if NIC is configured with single PF per port and without VFs. I'd like to double-check one thing. Doesn't it require fixes on datapath to report correct length?

Re: [PATCH 3/4] common/sfc_efx/base: add support for configure MAC to keep FCS

2023-06-07 Thread Andrew Rybchenko
. Signed-off-by: Roman Zhukov Signed-off-by: Denis Pryazhennikov Reviewed-by: Andy Moreton Acked-by: Andrew Rybchenko Please, ensure that initial author of the patch is used in From.

Re: [PATCH 2/4] common/sfc_efx/base: detect and report FCS include support

2023-06-07 Thread Andrew Rybchenko
On 6/1/23 14:42, Denis Pryazhennikov wrote: A new variable was added to efx_nic_cfg_s to detect and report if FCS is supported by FW. Signed-off-by: Roman Zhukov Signed-off-by: Denis Pryazhennikov Reviewed-by: Viacheslav Galaktionov Acked-by: Andrew Rybchenko Please, ensure that initial

Re: [PATCH 1/4] common/sfc_efx/base: NIC Partitioning mode discovery using heuristic approach

2023-06-02 Thread Andrew Rybchenko
Summary must not be a statement. Also summary is too long. On 6/1/23 14:42, Denis Pryazhennikov wrote: NIC Partitioning mode in SFN devices means multiple PFs per network port. When NIC Partitioning is configured, apart from the privileged adapter(s) the other unprivileged adapter(s) will share

  1   2   3   4   5   6   7   8   9   10   >