Re: [dpdk-dev] [PATCH v2 1/4] ethdev: introduce indirect action APIs

2021-04-13 Thread Andrey Vesnovaty
com.com; Gregory Etelson > ; Andrey Vesnovaty > Subject: [PATCH v2 1/4] ethdev: introduce indirect action APIs > > Right now, rte_flow_shared_action_* APIs are used for some shared > actions, like RSS, count. The shared action should be created before > using it inside a flow. These

[dpdk-dev] [PATCH] net/mlx5: fix shared RSS action update

2020-11-22 Thread Andrey Vesnovaty
RSS property to update is queues, the rest of the properties ignored. Fixes: d2046c09aa64 ("net/mlx5: support shared action for RSS") Signed-off-by: Andrey Vesnovaty --- drivers/net/mlx5/mlx5.h | 8 +- drivers/net/mlx5/mlx5_devx.c| 84 +++-- driver

Re: [dpdk-dev] [PATCH v3 1/2] ethdev: introduce transfer attribute to shared action conf

2020-11-03 Thread Andrey Vesnovaty
> -Original Message- > From: Ferruh Yigit > Sent: Monday, November 2, 2020 8:55 PM > To: Ivan Malov ; dev@dpdk.org; Andrey Vesnovaty > > Cc: Xueming(Steven) Li ; Ori Kam ; > NBU-Contact-Thomas Monjalon ; Andrew Rybchenko > > Subject: Re: [PATCH v3 1/2]

Re: [dpdk-dev] [RFC 3/3] sft: introduce API

2020-11-02 Thread Andrey Vesnovaty
riginal Message- > From: Andrew Rybchenko > Sent: Friday, September 18, 2020 10:44 AM > To: Ori Kam ; Andrey Vesnovaty ; > dev@dpdk.org > Cc: tho...@nvidia.net; Slava Ovsiienko ; > andrey.vesnov...@gmail.com; Oz Shlomo ; Eli Britstein > ; Alex Rosenbaum ; Roni Bar Yanai &g

[dpdk-dev] [PATCH v2 4/4] net/mlx5: driver support for shared action

2020-10-23 Thread Andrey Vesnovaty
handling shared RSS action. The lookup for hash RX queue object inside shared action is performed by hash only. Current implementation limited to DV flow driver operations i.e. verbs flow driver operations doesn't support shared action. Signed-off-by: Andrey Vesnovaty --- drivers/net

[dpdk-dev] [PATCH v2 2/4] net/mlx5: modify hash Rx queue objects

2020-10-23 Thread Andrey Vesnovaty
bject is prerequisite to implement rete_flow_shared_action_update() for shared RSS action in mlx5 PMD. Signed-off-by: Andrey Vesnovaty --- drivers/net/mlx5/mlx5.h| 5 + drivers/net/mlx5/mlx5_devx.c | 151 ++--- drivers/net/mlx5/mlx5_flow_dv.c

[dpdk-dev] [PATCH v2 1/4] common/mlx5: modify advanced Rx object via DevX

2020-10-23 Thread Andrey Vesnovaty
-related structures for TIR modification add in mlx5_prm.h. Signed-off-by: Andrey Vesnovaty --- drivers/common/mlx5/mlx5_devx_cmds.c | 84 drivers/common/mlx5/mlx5_devx_cmds.h | 10 drivers/common/mlx5/mlx5_prm.h | 29 ++ drivers/common/mlx5

[dpdk-dev] [PATCH v2 3/4] net/mlx5: shared action PMD

2020-10-23 Thread Andrey Vesnovaty
operations (see struct mlx5_flow_driver_ops). Signed-off-by: Andrey Vesnovaty --- drivers/net/mlx5/mlx5.c | 1 + drivers/net/mlx5/mlx5.h | 2 + drivers/net/mlx5/mlx5_defs.h | 3 + drivers/net/mlx5/mlx5_flow.c | 499 +-- drivers/net/mlx5/mlx5_flow.h | 86

[dpdk-dev] [PATCH v2 0/4] Shared action RSS PMD impl

2020-10-23 Thread Andrey Vesnovaty
315-1-andr...@mellanox.com/ [2] RTE flow shared action API v4 http://inbox.dpdk.org/dev/20201006200835.30017-1-andr...@nvidia.com/ [3] RTE flow shared action API v8 http://inbox.dpdk.org/dev/20201014114015.17197-1-andr...@nvidia.com/ Andrey Vesnovaty (4): common/mlx5: modify advanced Rx objec

Re: [dpdk-dev] [PATCH v7 1/2] ethdev: add flow shared action API

2020-10-14 Thread Andrey Vesnovaty
Hi Ajit All your suggestions applied in v8 series. BW Thomas & Andrew pointed to testpmd example in RTE flow API. Thanks, Andrey > -Original Message- > From: Ajit Khaparde > Sent: Friday, October 9, 2020 1:31 AM > To: Andrey Vesnovaty > Cc: dpdk-dev ; j...@marve

Re: [dpdk-dev] [PATCH v7 1/2] ethdev: add flow shared action API

2020-10-14 Thread Andrey Vesnovaty
Hi Thomas All your suggestions applied in v8 series. Thanks, Andrey > -Original Message- > From: Thomas Monjalon > Sent: Wednesday, October 14, 2020 10:23 AM > To: Andrey Vesnovaty > Cc: dev@dpdk.org; Andrew Rybchenko ; > jer...@marvell.com; ferruh.yi.

Re: [dpdk-dev] [PATCH v7 1/2] ethdev: add flow shared action API

2020-10-14 Thread Andrey Vesnovaty
Hi Andrew All your suggestions applied in v8 series. Thanks, Andrey > -Original Message- > From: Andrew Rybchenko > Sent: Wednesday, October 14, 2020 9:50 AM > To: Andrey Vesnovaty ; dev@dpdk.org > Cc: j...@marvell.com; jerinjac...@gmail.com; NBU-Contact-Thomas Monjalo

[dpdk-dev] [PATCH v8 2/2] app/testpmd: support shared action

2020-10-14 Thread Andrey Vesnovaty
hared action query CLI output depends on action type. Signed-off-by: Andrey Vesnovaty Acked-by: Ori Kam Acked-by: Ajit Khaparde --- app/test-pmd/cmdline.c | 18 ++ app/test-pmd/cmdline_flow.c | 294 +++- app/test-pmd/config.c

[dpdk-dev] [PATCH v8 0/2] RTE flow shared action

2020-10-14 Thread Andrey Vesnovaty
add 2 more queues > flow shared_action 0 modify 100 action rss queues 1 2 3 4 end / end Andrey Vesnovaty (2): ethdev: add shared actions to flow API app/testpmd: support shared action app/test-pmd/cmdline.c | 18 ++ app/test-pmd/cmdline_flow.c

[dpdk-dev] [PATCH v8 1/2] ethdev: add shared actions to flow API

2020-10-14 Thread Andrey Vesnovaty
dated_action, error); /* * from now on all flows 1 till N will act according to configuration of * updated_action */ /* skipped: destroy all flows 1 till N */ rte_flow_shared_action_destroy(port_id, handle, error); Signed-off-by: Andrey Vesnovaty Acked-by: Ori Kam Acked-by: Ajit Khaparde --- doc/g

Re: [dpdk-dev] [PATCH v7 1/2] ethdev: add flow shared action API

2020-10-13 Thread Andrey Vesnovaty
Hi Andrew. Thanks for the input. All spelling & rephrases will be applied PSB for the rest. Will publish v8 very soon. Thanks, Andrey > -Original Message- > From: Andrew Rybchenko > Sent: Monday, October 12, 2020 5:19 PM > To: Andrey Vesnovaty ; dev@dpdk.org > C

[dpdk-dev] [PATCH 4/4] net/mlx5: driver support for shared action

2020-10-08 Thread Andrey Vesnovaty
From: Andrey Vesnovaty Implement shared action create/destroy/update/query. Implement RSS shared action and handle shared RSS on flow apply and release. Note: currently implemented for sharede RSS action only Signed-off-by: Andrey Vesnovaty --- drivers/net/mlx5/mlx5_flow_dv.c | 684

[dpdk-dev] [PATCH 3/4] net/mlx5: shared action PMD

2020-10-08 Thread Andrey Vesnovaty
From: Andrey Vesnovaty Implement rte_flow shared action API for mlx5 PMD. Handle shared action on flow create/destroy. Signed-off-by: Andrey Vesnovaty --- drivers/net/mlx5/mlx5.c | 1 + drivers/net/mlx5/mlx5.h | 2 + drivers/net/mlx5/mlx5_defs.h | 3 + drivers/net/mlx5

[dpdk-dev] [PATCH 2/4] net/mlx5: modify hash Rx queue objects

2020-10-08 Thread Andrey Vesnovaty
From: Andrey Vesnovaty Implement mlx5_hrxq_modify() to modify hash RX queue object. This commit relays on capability to modify TIR object via DevX. Signed-off-by: Andrey Vesnovaty --- drivers/net/mlx5/mlx5.h | 4 + drivers/net/mlx5/mlx5_devx.c | 173

[dpdk-dev] [PATCH 1/4] common/mlx5: modify advanced Rx object via DevX

2020-10-08 Thread Andrey Vesnovaty
From: Andrey Vesnovaty Implement mlx5_devx_cmd_modify_tir() to modify TIR object using DevX API. Add related structs in mlx5_prm.h. Signed-off-by: Andrey Vesnovaty --- drivers/common/mlx5/mlx5_devx_cmds.c | 84 +++ drivers/common/mlx5/mlx5_devx_cmds.h | 10

[dpdk-dev] [PATCH 0/4] Shared action RSS PMD impl

2020-10-08 Thread Andrey Vesnovaty
red action API v7 http://inbox.dpdk.org/dev/20201008115143.13208-1-andr...@nvidia.com/ Andrey Vesnovaty (4): common/mlx5: modify advanced Rx object via DevX net/mlx5: modify hash Rx queue objects net/mlx5: shared action PMD net/mlx5: driver support for shared action drivers/common/mlx5/ml

[dpdk-dev] [PATCH v7 2/2] app/testpmd: support shared action

2020-10-08 Thread Andrey Vesnovaty
hared action query CLI output depends on action type. Signed-off-by: Andrey Vesnovaty Acked-by: Ori Kam --- app/test-pmd/cmdline.c | 18 ++ app/test-pmd/cmdline_flow.c | 294 +++- app/test-pmd/config.c | 216

[dpdk-dev] [PATCH v7 1/2] ethdev: add flow shared action API

2020-10-08 Thread Andrey Vesnovaty
ndle, &updated_action, error); /* * from now on all flows 1 till N will act according to configuration of * updated_action */ /* skipped: destroy all flows 1 till N */ rte_flow_shared_action_destroy(port_id, handle, error); Signed-off-by: Andrey Vesnovaty Acked-by: Ori Kam --- doc/guides/prog_gu

[dpdk-dev] [PATCH v7 0/2] RTE flow shared action

2020-10-08 Thread Andrey Vesnovaty
updated * tetspmd: * added handling of direction arguments for shared action create CLI * shared action create/update CLIs can receive all RTE flow action types Andrey Vesnovaty (2): ethdev: add flow shared action API app/testpmd: support shared action app/test-pmd/cmdline.c

Re: [dpdk-dev] [PATCH v6 2/2] app/testpmd: support shared action

2020-10-08 Thread Andrey Vesnovaty
flow action types now. PSB my suggestion regarding improving update CLI. Thanks, Andrey > -Original Message- > From: Ajit Khaparde > Sent: Wednesday, October 7, 2020 11:02 PM > To: Andrey Vesnovaty > Cc: dpdk-dev ; j...@marvell.com; Jerin Jacob > ; NBU-Contact-Thomas Mon

Re: [dpdk-dev] [PATCH v5 1/2] ethdev: add flow shared action API

2020-10-08 Thread Andrey Vesnovaty
aparde > Sent: Thursday, October 8, 2020 12:23 AM > To: Andrey Vesnovaty > Cc: dpdk-dev ; j...@marvell.com; Jerin Jacob > ; NBU-Contact-Thomas Monjalon > ; Ferruh Yigit ; Stephen > Hemminger ; Bruce Richardson > ; Ori Kam ; Slava Ovsiienko > ; andrey.vesnov...@gmail.com; Ray

[dpdk-dev] [PATCH v6 2/2] app/testpmd: support shared action

2020-10-07 Thread Andrey Vesnovaty
f-by: Andrey Vesnovaty Acked-by: Ori Kam Signed-off-by: Andrey Vesnovaty --- app/test-pmd/cmdline_flow.c | 262 +++- app/test-pmd/config.c | 215 app/test-pmd/testpmd.h | 19 ++ doc/guides/te

[dpdk-dev] [PATCH v6 1/2] ethdev: add flow shared action API

2020-10-07 Thread Andrey Vesnovaty
/* * from now on all flows 1 till N will act according to configuration of * updated_action */ /* skipped: destroy all flows 1 till N */ rte_flow_shared_action_destroy(port_id, handle, error); Signed-off-by: Andrey Vesnovaty Acked-by: Ori Kam --- doc/guides/prog_guide/rte_flow.rst |

[dpdk-dev] [PATCH v6 0/2] RTE flow shared action

2020-10-07 Thread Andrey Vesnovaty
This patchset introduces shared action API for RTE flow. v6 changes: * fix build warning in testpmd Andrey Vesnovaty (2): ethdev: add flow shared action API app/testpmd: support shared action app/test-pmd/cmdline_flow.c | 262 +++- app/test-pmd/config.c

[dpdk-dev] [PATCH v5 2/2] app/testpmd: support shared action

2020-10-07 Thread Andrey Vesnovaty
flow create 0 ingress pattern ... / end \ actions shared 100 / end This creates flow rule where rss action is shared rss action having id 100. All shared action CLIs report status of the command. Shared action query CLI output depends on action type. Signed-of

[dpdk-dev] [PATCH v5 0/2] RTE flow shared action

2020-10-07 Thread Andrey Vesnovaty
This patchset introduces shared action API for RTE flow. v5 changes: * updated RTE flow programmers guide * misc elaborations in code comments Andrey Vesnovaty (2): ethdev: add flow shared action API app/testpmd: support shared action app/test-pmd/cmdline_flow.c | 262

[dpdk-dev] [PATCH v5 1/2] ethdev: add flow shared action API

2020-10-07 Thread Andrey Vesnovaty
/* * from now on all flows 1 till N will act according to configuration of * updated_action */ /* skipped: destroy all flows 1 till N */ rte_flow_shared_action_destroy(port_id, handle, error); Signed-off-by: Andrey Vesnovaty --- doc/guides/prog_guide/rte_flow.rst | 19 +++ doc/guides/rel_

[dpdk-dev] [PATCH v4 1/2] ethdev: add flow shared action API

2020-10-06 Thread Andrey Vesnovaty
/* * from now on all flows 1 till N will act according to configuration of * updated_action */ /* skipped: destroy all flows 1 till N */ rte_flow_shared_action_destroy(port_id, handle, error); Signed-off-by: Andrey Vesnovaty --- doc/guides/rel_notes/release_20_11.rst | 9 ++ li

[dpdk-dev] [PATCH v4 2/2] app/testpmd: support shared action

2020-10-06 Thread Andrey Vesnovaty
flow create 0 ingress pattern ... / end \ actions shared 100 / end This creates flow rule where rss action is shared rss action having id 100. All shared action CLIs report status of the command. Shared action query CLI output depends on action type. Signed-of

[dpdk-dev] [PATCH v4 0/2] RTE flow shared action

2020-10-06 Thread Andrey Vesnovaty
spelling fixes and rephrase in commit messages * flow_filtering example removed in favor of testpmd Andrey Vesnovaty (2): ethdev: add flow shared action API app/testpmd: support shared action app/test-pmd/cmdline_flow.c | 262 +++- app/test-pmd/config.c

Re: [dpdk-dev] [PATCH v3 10/10] app/testpmd: support shared action

2020-10-06 Thread Andrey Vesnovaty
Hi Ori. testpmd documentation will be added in v4. Thanks, Andrey > -Original Message- > From: Ori Kam > Sent: Sunday, October 4, 2020 3:05 PM > To: Ori Kam ; Andrey Vesnovaty ; > dev@dpdk.org > Cc: j...@marvell.com; jerinjac...@gmail.com; NBU-Contact-Thomas Monj

Re: [dpdk-dev] [PATCH v3 09/10] examples/flow_filtering: utilize shared RSS action

2020-10-06 Thread Andrey Vesnovaty
Hi Ori, PSB Thanks, Andrey > -Original Message- > From: Ori Kam > Sent: Sunday, October 4, 2020 2:22 PM > To: Andrey Vesnovaty ; dev@dpdk.org > Cc: j...@marvell.com; jerinjac...@gmail.com; NBU-Contact-Thomas Monjalon > ; ferruh.yi...@intel.com; > step.

Re: [dpdk-dev] [PATCH v3 02/10] ethdev: add conf arg to shared action icreate API

2020-10-06 Thread Andrey Vesnovaty
PSB > -Original Message- > From: Ori Kam > Sent: Sunday, October 4, 2020 2:11 PM > To: Andrey Vesnovaty ; dev@dpdk.org > Cc: j...@marvell.com; jerinjac...@gmail.com; NBU-Contact-Thomas Monjalon > ; ferruh.yi...@intel.com; > step...@networkplumber.org; bruce.richar

Re: [dpdk-dev] [PATCH v3 00/10] RTE flow shared action

2020-10-06 Thread Andrey Vesnovaty
PSB > -Original Message- > From: Ori Kam > Sent: Sunday, October 4, 2020 2:14 PM > To: Andrey Vesnovaty ; dev@dpdk.org > Cc: j...@marvell.com; jerinjac...@gmail.com; NBU-Contact-Thomas Monjalon > ; ferruh.yi...@intel.com; > step...@networkplumber.org; bruce.richar

Re: [dpdk-dev] [PATCH v3 01/10] ethdev: add flow shared action API

2020-10-06 Thread Andrey Vesnovaty
Hi Ori, PSB Thanks, Andrey > -Original Message- > From: Ori Kam > Sent: Sunday, October 4, 2020 2:10 PM > To: Andrey Vesnovaty ; dev@dpdk.org > Cc: j...@marvell.com; jerinjac...@gmail.com; NBU-Contact-Thomas Monjalon > ; ferruh.yi...@intel.com; > step.

[dpdk-dev] [PATCH v3 10/10] app/testpmd: support shared action

2020-10-03 Thread Andrey Vesnovaty
flow create 0 ingress pattern ... / end \ actions shared 100 / end This creates flow rule where rss action is shared rss action having id 100. All shared action CLIs report status of the command. Shared action query CLI output depends on action type. Signed-of

[dpdk-dev] [PATCH v3 08/10] net/mlx5: shared action create conf drv support

2020-10-03 Thread Andrey Vesnovaty
Add support for configuration argument in shared action validate/create API. Currently the inly shared action implemented is RSS. For shared RSS action configuration argument ignpred but it can be utilized by other types of shared actions. Signed-off-by: Andrey Vesnovaty --- drivers/net/mlx5

[dpdk-dev] [PATCH v3 07/10] net/mlx5: driver support for shared action

2020-10-03 Thread Andrey Vesnovaty
From: Andrey Vesnovaty Implement shared action create/destroy/update/query. Implement RSS shared action and handle shared RSS on flow apply and release. Note: currently implemented for sharede RSS action only Signed-off-by: Andrey Vesnovaty --- drivers/net/mlx5/mlx5_flow_dv.c | 671

[dpdk-dev] [PATCH v3 09/10] examples/flow_filtering: utilize shared RSS action

2020-10-03 Thread Andrey Vesnovaty
From: Andrey Vesnovaty This commit give very first shared RSS action usage example. Queue action used by the flow replaced by shared RSS action having single queue. On each RX burst queue switched 0 <-> 1 utilizing rte_flow_shared_action_update() API. User supposed to observe consistent

[dpdk-dev] [PATCH v3 05/10] net/mlx5: shared action PMD

2020-10-03 Thread Andrey Vesnovaty
From: Andrey Vesnovaty Implement rte_flow shared action API for mlx5 PMD. Handle shared action on flow create/destroy. Signed-off-by: Andrey Vesnovaty --- drivers/net/mlx5/mlx5.c | 1 + drivers/net/mlx5/mlx5.h | 2 + drivers/net/mlx5/mlx5_defs.h | 3 + drivers/net/mlx5

[dpdk-dev] [PATCH v3 04/10] net/mlx5: modify hash Rx queue objects

2020-10-03 Thread Andrey Vesnovaty
From: Andrey Vesnovaty Implement mlx5_hrxq_modify() to modify hash RX queue object. This commit relays on capability to modify TIR object via DevX. Signed-off-by: Andrey Vesnovaty --- drivers/net/mlx5/mlx5.h | 4 + drivers/net/mlx5/mlx5_devx.c | 178

[dpdk-dev] [PATCH v3 06/10] net/mlx5: shared action PMD create conf arg

2020-10-03 Thread Andrey Vesnovaty
Add support for configuration argument in shared action create API. Configuration structure forwarded to verbs/devx layer. Signed-off-by: Andrey Vesnovaty --- drivers/net/mlx5/mlx5_flow.c | 23 ++- drivers/net/mlx5/mlx5_flow.h | 9 ++--- 2 files changed, 20 insertions

[dpdk-dev] [PATCH v3 03/10] common/mlx5: modify advanced Rx object via DevX

2020-10-03 Thread Andrey Vesnovaty
From: Andrey Vesnovaty Implement mlx5_devx_cmd_modify_tir() to modify TIR object using DevX API. Add related structs in mlx5_prm.h. Signed-off-by: Andrey Vesnovaty --- drivers/common/mlx5/mlx5_devx_cmds.c | 84 +++ drivers/common/mlx5/mlx5_devx_cmds.h | 10

[dpdk-dev] [PATCH v3 02/10] ethdev: add conf arg to shared action icreate API

2020-10-03 Thread Andrey Vesnovaty
Add configuration argument to shared action create interface. Currently there is only ingress & egress fields but more fields can be added later. Shared action configuration & implementation are PMD specific. Signed-off-by: Andrey Vesnovaty --- lib/librte_ethdev/rte_flow.c| 4 +

[dpdk-dev] [PATCH v3 01/10] ethdev: add flow shared action API

2020-10-03 Thread Andrey Vesnovaty
n * configuration change */ rte_flow_shared_action_update(port_id, handle, &updated_action, error); /* * from now on all flows 1 till N will act according to configuration of * updated_action */ /* skipped: destroy all flows 1 till N */ rte_flow_shared_action_destroy(port_id, handle, er

[dpdk-dev] [PATCH v3 00/10] RTE flow shared action

2020-10-03 Thread Andrey Vesnovaty
This patchset introduces shared action for RTE flow. V3 changes: - implement testpmd for shared action - fix flow_filtering example application - add conf arg to shared action create API Notes: PMD implementation should be considered as draft Andrey Vesnovaty (10): ethdev: add flow shared

Re: [dpdk-dev] [PATCH v2 1/6] ethdev: add flow shared action API

2020-09-26 Thread Andrey Vesnovaty
Hi Ajit, Andrew & Ori. PSB 😉 > -Original Message- > From: Ajit Khaparde > Sent: Thursday, September 24, 2020 10:25 PM > To: Ori Kam > Cc: Andrew Rybchenko ; Andrey Vesnovaty > ; NBU-Contact-Thomas Monjalon > ; Slava Ovsiienko ; > jer...@marvell.com; dpdk-d

Re: [dpdk-dev] [PATCH v2 1/6] ethdev: add flow shared action API

2020-09-16 Thread Andrey Vesnovaty
? Thanks, Andrey > -Original Message- > From: Ajit Khaparde > Sent: Tuesday, September 15, 2020 6:49 PM > To: Andrey Vesnovaty > Cc: NBU-Contact-Thomas Monjalon ; Ori Kam > ; Slava Ovsiienko ; > jer...@marvell.com; Andrew Rybchenko ; dpdk- > dev ; j...@marvell.com; Jeri

Re: [dpdk-dev] [RFC 0/3] introduce Stateful Flow Table

2020-09-15 Thread Andrey Vesnovaty
+ Ferruh & Andrew. Adding more people that may find this discussion relevant. Any feedback highly appreciated. Thanks, Andrey > -Original Message- > From: dev On Behalf Of Andrey Vesnovaty > Sent: Wednesday, September 9, 2020 11:30 PM > To: dev@dpdk.org > Cc: tho...@

Re: [dpdk-dev] [PATCH v2 1/6] ethdev: add flow shared action API

2020-09-15 Thread Andrey Vesnovaty
Hi Ajit, PSB. Thanks, Andrey > -Original Message- > From: Ajit Khaparde > Sent: Saturday, September 12, 2020 5:18 AM > To: Andrey Vesnovaty > Cc: dpdk-dev ; j...@marvell.com; Jerin Jacob > ; NBU-Contact-Thomas Monjalon > ; Ferruh Yigit ; Stephen > Hemminger ;

Re: [dpdk-dev] [PATCH v2 1/6] ethdev: add flow shared action API

2020-09-15 Thread Andrey Vesnovaty
dnesday, July 15, 2020 11:54 AM > To: Andrey Vesnovaty ; Neil Horman > ; Thomas Monjalon ; > Ferruh Yigit ; Andrew Rybchenko > ; Ori Kam > Cc: Kinsella, Ray ; dev@dpdk.org; jerinjac...@gmail.com; > step...@networkplumber.org; bruce.richard...@intel.com; Slava Ovsiienko > ; andrey.ve

[dpdk-dev] [RFC 3/3] sft: introduce API

2020-09-09 Thread Andrey Vesnovaty
systems (IDS/IPS): Suricata, snort - SW/Virtual Switching: OVS The goals of the SFT library: - Accelerate flow recognition & its context retrieval for further lookaside processing. - Enable context-aware flow handling offload. Signed-off-by: Andrey Vesnovaty --- lib/librte_sft/Make

[dpdk-dev] [RFC 1/3] ethdev: add item/action for SFT

2020-09-09 Thread Andrey Vesnovaty
Attach SFT flow context to packet with SFT action. Match on SFT flow context (attached to packet), with SFT item. Signed-off-by: Andrey Vesnovaty --- lib/librte_ethdev/rte_flow.h | 84 1 file changed, 84 insertions(+) diff --git a/lib/librte_ethdev

[dpdk-dev] [RFC 2/3] ethdev: support SFT APIs

2020-09-09 Thread Andrey Vesnovaty
ethdev updated to support SFT lookup offload to ethernet device. Signed-off-by: Andrey Vesnovaty --- lib/librte_ethdev/rte_ethdev.c | 7 +++ lib/librte_ethdev/rte_ethdev.h | 16 lib/librte_ethdev/rte_ethdev_core.h | 1 + 3 files changed, 24 insertions(+) diff

[dpdk-dev] [RFC 0/3] introduce Stateful Flow Table

2020-09-09 Thread Andrey Vesnovaty
recognition & its context retrieval for further lookaside processing. - Enable context-aware flow handling offload. Andrey Vesnovaty (3): ethdev: add item/action for SFT ethdev: support SFT APIs sft: introduce API lib/librte_ethdev/rte_ethdev.c | 7 + lib/librte_et

Re: [dpdk-dev] [PATCH v2 6/6] examples/flow_filtering: utilize shared RSS action

2020-07-09 Thread Andrey Vesnovaty
sday, July 9, 2020 9:09 AM To: Jerin Jacob ; Andrey Vesnovaty Cc: dpdk-dev ; j...@marvell.com; Thomas Monjalon ; Ferruh Yigit ; Stephen Hemminger ; Richardson, Bruce ; Slava Ovsiienko ; Andrey Vesnovaty ; Marko Kovacevic ; Radu Nicolau ; Akhil Goyal ; Tomasz Kantecki ; Sunil Kumar Kori ;

[dpdk-dev] [PATCH v2 6/6] examples/flow_filtering: utilize shared RSS action

2020-07-08 Thread Andrey Vesnovaty
configured instead of queue action in original application. On each RX queue burst shared RSS action reconfigured via rte_flow_shared_action_update() API to switch queue 0 to 1 & 1 to 0. User supposed to observe consistent queue switches on each packet burst. Signed-off-by: Andrey Vesno

[dpdk-dev] [PATCH v2 2/6] common/mlx5: modify advanced Rx object via DevX

2020-07-08 Thread Andrey Vesnovaty
Implement mlx5_devx_cmd_modify_tir() to modify TIR object using DevX API. Add related structs in mlx5_prm.h. Signed-off-by: Andrey Vesnovaty --- drivers/common/mlx5/mlx5_devx_cmds.c | 84 +++ drivers/common/mlx5/mlx5_devx_cmds.h | 10 +++ drivers/common/mlx5

[dpdk-dev] [PATCH v2 5/6] net/mlx5: driver support for shared action

2020-07-08 Thread Andrey Vesnovaty
Implement shared action create/destroy/update/query. Implement RSS shared action and handle shared RSS on flow apply and release. Note: currently implemented for sharede RSS action only Signed-off-by: Andrey Vesnovaty --- drivers/net/mlx5/mlx5_flow_dv.c | 671

[dpdk-dev] [PATCH v2 4/6] net/mlx5: shared action PMD

2020-07-08 Thread Andrey Vesnovaty
Implement rte_flow shared action API for mlx5 PMD. Handle shared action on flow create/destroy. Signed-off-by: Andrey Vesnovaty --- drivers/net/mlx5/mlx5.c | 1 + drivers/net/mlx5/mlx5.h | 2 + drivers/net/mlx5/mlx5_defs.h | 3 + drivers/net/mlx5/mlx5_flow.c | 492

[dpdk-dev] [PATCH v2 0/6] add flow shared action API + PMD

2020-07-08 Thread Andrey Vesnovaty
to converge our API discussion and reach consensus on it. Thanks, Andrey Andrey Vesnovaty (6): ethdev: add flow shared action API common/mlx5: modify advanced Rx object via DevX net/mlx5: modify hash Rx queue objects net/mlx5: shared action PMD net/mlx5: driver support for shared action

[dpdk-dev] [PATCH v2 1/6] ethdev: add flow shared action API

2020-07-08 Thread Andrey Vesnovaty
From: Andrey Vesnovaty This commit introduces extension of DPDK flow action API enabling sharing of single rte_flow_action in multiple flows. The API intended for PMDs where multiple HW offloaded flows can reuse the same HW essence/object representing flow action and modification of such an

[dpdk-dev] [PATCH v2 3/6] net/mlx5: modify hash Rx queue objects

2020-07-08 Thread Andrey Vesnovaty
Implement mlx5_hrxq_modify() to modify hash RX queue object. This commit relays on capability to modify TIR object via DevX. Signed-off-by: Andrey Vesnovaty --- drivers/net/mlx5/mlx5_rxq.c | 300 --- drivers/net/mlx5/mlx5_rxtx.h | 4 + 2 files changed, 243

Re: [dpdk-dev] [PATCH] add flow shared action API

2020-07-06 Thread Andrey Vesnovaty
; > Ori > > > > > > > -Original Message- > > > > From: Jerin Jacob > > > > Sent: Saturday, July 4, 2020 3:33 PM > > > > dpdk-dev > > > > Subject: Re: [dpdk-dev] [PATCH] add flow shared action API > > > >

Re: [dpdk-dev] [PATCH] add flow shared action API

2020-07-04 Thread Andrey Vesnovaty
Thanks, Andrey Vesnovaty (+972)*526775512* | *Skype:* andrey775512 On Fri, Jul 3, 2020 at 6:02 PM Jerin Jacob wrote: > On Fri, Jul 3, 2020 at 8:07 PM Andrey Vesnovaty > wrote: > > > > From: Andrey Vesnovaty > > > > This commit introduces extension of

Re: [dpdk-dev] [PATCH] add flow shared action API

2020-07-04 Thread Andrey Vesnovaty
Hi, Jerin & Thomas. On Fri, Jul 3, 2020 at 6:21 PM Thomas Monjalon wrote: > 03/07/2020 17:02, Jerin Jacob: > > On Fri, Jul 3, 2020 at 8:07 PM Andrey Vesnovaty > wrote: > > > Signed-off-by: Andrey Vesnovaty > > > Signed-off-by: Andrey Vesnovaty >

[dpdk-dev] [PATCH] add flow shared action API

2020-07-03 Thread Andrey Vesnovaty
From: Andrey Vesnovaty This commit introduces extension of DPDK flow action API enabling sharing of single rte_flow_action in multiple flows. The API intended for PMDs where multiple HW offloaded flows can reuse the same HW essence/object representing flow action and modification of such an

Re: [dpdk-dev] [RFC v2 1/1] add flow shared action API

2020-07-02 Thread Andrey Vesnovaty
On Thu, Jul 2, 2020 at 10:20 AM Ori Kam wrote: > Hi Stephen, > > > -Original Message- > > From: Stephen Hemminger > > Sent: Thursday, July 2, 2020 3:24 AM > > To: Andrey Vesnovaty > > Cc: Thomas Monjalon ; Ferruh Yigit > > ; Andrew Rybc

Re: [dpdk-dev] [RFC v2 0/1] add flow action context API

2020-07-01 Thread Andrey Vesnovaty
On Tue, Jun 30, 2020 at 12:52 PM Jerin Jacob wrote: > On Mon, Jun 29, 2020 at 3:52 PM Andrey Vesnovaty > wrote: > > > > > > > > On Sun, Jun 28, 2020 at 4:42 PM Jerin Jacob > wrote: > >> > >> On Sun, Jun 28, 2020 at 2:14 PM Andrey Vesnovaty

Re: [dpdk-dev] [RFC v2 0/1] add flow action context API

2020-06-29 Thread Andrey Vesnovaty
On Sun, Jun 28, 2020 at 4:42 PM Jerin Jacob wrote: > On Sun, Jun 28, 2020 at 2:14 PM Andrey Vesnovaty > wrote: > > > > Hi > > > > On Fri, Jun 26, 2020 at 2:44 PM Jerin Jacob > wrote: > >> > >> On Sat, Jun 20, 2020 at 7:02 PM Andrey Vesnovaty

Re: [dpdk-dev] [RFC v2 0/1] add flow action context API

2020-06-28 Thread Andrey Vesnovaty
Hi On Fri, Jun 26, 2020 at 2:44 PM Jerin Jacob wrote: > On Sat, Jun 20, 2020 at 7:02 PM Andrey Vesnovaty > wrote: > > > > Hi, and thanks a lot for your RFC v1 comments. > > > > RFC v2 emphasize the intent for sharing the flow action: > > * The term '

Re: [dpdk-dev] [RFC v2 0/1] add flow action context API

2020-06-22 Thread Andrey Vesnovaty
On Mon, Jun 22, 2020 at 6:22 PM Thomas Monjalon wrote: > 20/06/2020 15:32, Andrey Vesnovaty: > > Hi, and thanks a lot for your RFC v1 comments. > > > > RFC v2 emphasize the intent for sharing the flow action: > > * The term 'action context' was unclear an

[dpdk-dev] [RFC v2 0/1] add flow action context API

2020-06-20 Thread Andrey Vesnovaty
& unclear. I hope v2 will be better at least in terms of clarity. @Thomas Monjalon: rte_flow_action_ctx_modify() -> rte_flow_action_ctx_modify() Looking forward to your responses on v2, thanks in advance. Andrey Vesnovaty (1): add flow shared action API lib/librte_ethdev/rte_ethdev_v

[dpdk-dev] [RFC v2 1/1] add flow shared action API

2020-06-20 Thread Andrey Vesnovaty
* from now on all flows 1 till N will act according to configuration of * updated_action */ /* skipped: destroy all flows 1 till N */ rte_flow_shared_action_destroy(port_id, handle, error); Signed-off-by: Andrey Vesnovaty --- lib/librte_ethdev/rte_ethdev_version.map | 6 + lib/librte_ethdev/r

Re: [dpdk-dev] [RFC] add flow action context API

2020-06-04 Thread Andrey Vesnovaty
On Thu, Jun 4, 2020 at 3:37 PM Jerin Jacob wrote: > I would suggest adding rte_flow driver implementers if there is a > change in rte_flow_ops in RFC so that > your patch will get enough. I added the maintainers of rte_flow PMD[1] > implementers in Cc. > > > >> > >> Would the following additional

Re: [dpdk-dev] [RFC] add flow action context API

2020-06-04 Thread Andrey Vesnovaty
On Wed, Jun 3, 2020 at 1:53 PM Jerin Jacob wrote: > On Wed, May 20, 2020 at 2:48 PM Andrey Vesnovaty > wrote: > > > > This commit introduces extension of DPDK flow action API enabling > > modification of single rte_flow_action. > > > > Motivation and exampl

Re: [dpdk-dev] [RFC] add flow action context API

2020-06-04 Thread Andrey Vesnovaty
On Wed, Jun 3, 2020 at 1:02 PM Thomas Monjalon wrote: > 20/05/2020 11:18, Andrey Vesnovaty: > > This commit introduces extension of DPDK flow action API enabling > > modification of single rte_flow_action. > > > > Motivation and example > > === > > Addin

[dpdk-dev] [RFC] add flow action context API

2020-05-20 Thread Andrey Vesnovaty
2 3 4 Signed-off-by: Andrey Vesnovaty --- lib/librte_ethdev/rte_ethdev_version.map | 6 + lib/librte_ethdev/rte_flow.c | 85 ++ lib/librte_ethdev/rte_flow.h | 135 ++- lib/librte_ethdev/rte_flow_driver.h | 22 4 files changed, 2