Re: [dpdk-dev] [PATCH] security: remove experimental tag

2018-11-14 Thread Boris Pismenny
Acked-By: Boris Pismenny > -Original Message- > From: dev On Behalf Of Akhil Goyal > Sent: Tuesday, November 13, 2018 3:28 AM > To: dev@dpdk.org > Cc: Thomas Monjalon ; > konstantin.anan...@intel.com; jerin.ja...@caviumnetworks.com; > anoob.jos...@caviumne

Re: [dpdk-dev] [PATCH v2] security: remove experimental tag from security APIs

2018-07-04 Thread Boris Pismenny
On 7/4/2018 3:03 PM, Radu Nicolau wrote: On 7/4/2018 10:05 AM, Hemant Agrawal wrote: Signed-off-by: Hemant Agrawal --- v2: fix the release version Acked-by: Radu Nicolau Acked-by: Boris Pismenny

Re: [dpdk-dev] [RFC] tunnel endpoint hw acceleration enablement

2018-01-02 Thread Boris Pismenny
Hi Declan, On 12/22/2017 12:21 AM, Doherty, Declan wrote: This RFC contains a proposal to add a new tunnel endpoint API to DPDK that when used in conjunction with rte_flow enables the configuration of inline data path encapsulation and decapsulation of tunnel endpoint network overlays on acce

Re: [dpdk-dev] [PATCH v3 2/2] examples/ipsec-secgw: add target queues in flow actions

2017-12-21 Thread Boris Pismenny
Hi Anoob, On 12/21/2017 10:06 AM, Anoob Joseph wrote: HI Boris, On 12/20/2017 09:49 PM, Boris Pismenny wrote: Hi, On Wed, Dec 13, 2017 at 07:14:19PM, Nelio Laranjeiro wrote: Hi, On Wed, Dec 13, 2017 at 07:23:19PM +0530, Anoob Joseph wrote: Hi Nelio, On 12/13/2017 06:23 PM, Nelio

Re: [dpdk-dev] [PATCH v3 2/2] examples/ipsec-secgw: add target queues in flow actions

2017-12-20 Thread Boris Pismenny
Hi, > On Wed, Dec 13, 2017 at 07:14:19PM, Nelio Laranjeiro wrote: > > Hi, > > On Wed, Dec 13, 2017 at 07:23:19PM +0530, Anoob Joseph wrote: > > Hi Nelio, > > > > > > On 12/13/2017 06:23 PM, Nelio Laranjeiro wrote: > > > Hi Anoob, > > > > > > On Wed, Dec 13, 2017 at 05:08:19PM +0530, Anoob Joseph

Re: [dpdk-dev] [PATCH 05/11] lib/librte_mbuf: add security crypto flags and mbuf fields

2017-09-26 Thread Boris Pismenny
Hi Olivier, Thanks for the feedback. I'll submit the fixes for our V2 of this series. Some comments inline. Olivier Matz wrote: > > Hi Boris, > > Some comments inline. > > On Mon, Sep 18, 2017 at 07:54:03AM +, Boris Pismenny wrote: > > Hi Olivier, > &g

Re: [dpdk-dev] [PATCH 07/11] ethdev: add rte flow action for crypto

2017-09-21 Thread Boris Pismenny
Subject: [PATCH 07/11] ethdev: add rte flow action for crypto > > X-Mailer: git-send-email 2.9.3 > > > > From: Boris Pismenny > > Hi Boris, > > > > > The crypto action is specified by an application to request crypto > > offl

Re: [dpdk-dev] [PATCH 05/11] lib/librte_mbuf: add security crypto flags and mbuf fields

2017-09-18 Thread Boris Pismenny
Hi Olivier, On 9/14/2017 11:27 AM, Akhil Goyal wrote: > > From: Boris Pismenny > > add security crypto flags and update mbuf fields to support > IPsec crypto offload for transmitted packets, and to indicate > crypto result for received packets. > > Signed-off-by: Avia

Re: [dpdk-dev] [PATCH 01/11] lib/rte_security: add security library

2017-09-17 Thread Boris Pismenny
Hi Hemant, On 9/15/2017 8:33 AM, Hemant Agrawal wrote: > > Hi, > > On 9/14/2017 1:56 PM, Akhil Goyal wrote: > .. > > > diff --git a/lib/librte_security/rte_security.c > > b/lib/librte_security/rte_security.c > > new file mode 100644 > > index 000..5776246 > > --- /dev/null > > +++ b/lib/lib

[dpdk-dev] [PATCH] examples/ipsec-secgw: fix rte flow egress

2017-09-17 Thread Boris Pismenny
This patch ensures that the egress flag is set for outbound inline flows. Signed-off-by: Boris Pismenny --- examples/ipsec-secgw/ipsec.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/examples/ipsec-secgw/ipsec.c b/examples/ipsec-secgw/ipsec.c index 3d241a2..b3694a5 100644 --- a

[dpdk-dev] [PATCH 0/2] Document rte_flow security action

2017-09-17 Thread Boris Pismenny
[ESP | GRE | TCP]. By providing the full pattern we resolve the ambiguity and define the order of encapsulation. While actions describe the encapsulation operation related to each header. The patches are based on the integration branch of dpdk-draft-ipsec. Boris Pismenny (2): doc: add detai

[dpdk-dev] [PATCH 2/2] ethdev: update documentation for security action

2017-09-17 Thread Boris Pismenny
Signed-off-by: Boris Pismenny --- lib/librte_ether/rte_flow.h | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/lib/librte_ether/rte_flow.h b/lib/librte_ether/rte_flow.h index dce92ca..48d4fca 100644 --- a/lib/librte_ether/rte_flow.h +++ b/lib

[dpdk-dev] [PATCH 1/2] doc: add details of rte_flow security actions

2017-09-17 Thread Boris Pismenny
Signed-off-by: Boris Pismenny --- doc/guides/prog_guide/rte_flow.rst | 83 +- 1 file changed, 81 insertions(+), 2 deletions(-) diff --git a/doc/guides/prog_guide/rte_flow.rst b/doc/guides/prog_guide/rte_flow.rst index 662a912..62da436 100644 --- a/doc/guides

Re: [dpdk-dev] [PATCH 04/11] lib/librte_net: add ESP header to generic flow steering

2017-09-17 Thread Boris Pismenny
Hi Hemant, > On 9/15/2017 07:51 AM, Hemant Agrawal wrote: > Hi Boris, > > On 9/14/2017 1:56 PM, Akhil Goyal wrote: > > From: Boris Pismenny > > > > The ESP header is required for IPsec crypto actions. > > > > > Signed-off-by: Boris Pismenny > &

Re: [dpdk-dev] [RFC PATCH 0/5] Enable IPSec Inline for IXGBE PMD

2017-08-29 Thread Boris Pismenny
Hi Radu, In the our previous RFC, I got the impression that we had a consensus about using rte_flow for inline and full protocol offload to net PMDs. However, this patchset doesn't follow this convention. The rte_flow API allows for all future encapsulations of these protocols to be expressed with

Re: [dpdk-dev] [RFC PATCH 1/4] rte_security: API definitions

2017-08-21 Thread Boris Pismenny
2:17 > To: Hemant Agrawal > Cc: Akhil Goyal ; Radu Nicolau > ; dev@dpdk.org; declan.dohe...@intel.com; Aviad > Yehezkel ; Boris Pismenny ; > pablo.de.lara.gua...@intel.com; sergio.gonzalez.mon...@intel.com; Sandeep > Malik ; techbo...@dpdk.org > Subject: Re: [RFC PATCH 1/4] rte_sec

Re: [dpdk-dev] [PATCH] doc: announce ABI change for cryptodev and ethdev

2017-08-07 Thread Boris Pismenny
> > > Acked-by: Hemant Agrawal > > No more opinions outside of NXP? > It seems there is not yet a consensus on how to manage IPsec offloading. > I heard there were some phone calls about these stuff but nothing clear > appears publicly on the mailing list. > Looks to be a community failure. We agreed to go ahead with this approach on one such phone call. I hope we could use the dpdk github for development. Acked-by: Boris Pismenny

Re: [dpdk-dev] [RFC 0/7] ipsec inline

2017-07-12 Thread Boris Pismenny
Hi Declan, > Hey Boris, we've been working on v2 of the RFC based on the feedback you > and others gave on our original , but as what we were going to propose > is largely inline with your proposal here, with one or 2 exceptions, > mainly on the IPsec SA management elements, I'll just comment here

[dpdk-dev] [RFC 1/7] ethdev: add device ipsec encrypt/decrypt capability flags

2017-07-10 Thread Boris Pismenny
A PMD that presents these flags supports IPsec crypto offload. Encryption and authentication on SA entries can be offloaded to the PMD. After adding a SA to hardware, crypto can be offloaded on well-formed IPsec packets. Signed-off-by: Boris Pismenny Signed-off-by: Aviad Yehezkel --- lib

[dpdk-dev] [RFC 2/7] ethdev: Add ESP header to generic flow steering

2017-07-10 Thread Boris Pismenny
The ESP header is required for IPsec crypto actions. Signed-off-by: Boris Pismenny Signed-off-by: Aviad Yehezkel --- lib/librte_ether/rte_flow.h | 24 lib/librte_net/Makefile | 2 +- 2 files changed, 25 insertions(+), 1 deletion(-) diff --git a/lib/librte_ether

[dpdk-dev] [RFC 7/7] example/ipsec_gw: Support SA offload in datapath

2017-07-10 Thread Boris Pismenny
_add_rules constructs the rte_flow_item specification and the crypto rte_flow_action. 3. create_session calls rte_flow_create with sa parameters from step 2. Signed-off-by: Aviad Yehezkel Signed-off-by: Boris Pismenny --- examples/ipsec-secgw/esp.c | 68 - examples/ipsec-s

[dpdk-dev] [RFC 0/7] ipsec inline

2017-07-10 Thread Boris Pismenny
involved. Aviad Yehezkel (2): mbuf: Added next_esp_proto field example/ipsec_gw: Support SA offload in datapath Boris Pismenny (5): ethdev: add device ipsec encrypt/decrypt capability flags ethdev: Add ESP header to generic flow steering ethdev: add rte flow action for crypto crypto

[dpdk-dev] [RFC 5/7] mbuf: Add IPsec crypto flags

2017-07-10 Thread Boris Pismenny
This patch adds flags to request IPsec crypto offload for transmitted packets, and to indicate crypto result for received packets. Signed-off-by: Boris Pismenny Signed-off-by: Aviad Yehezkel --- lib/librte_mbuf/rte_mbuf.c | 16 lib/librte_mbuf/rte_mbuf.h | 29

[dpdk-dev] [RFC 4/7] cryptodev: add ipsec xform

2017-07-10 Thread Boris Pismenny
This patch add a xform that is used with the crypto flow steering action to offload ipsec crypto inline. Signed-off-by: Boris Pismenny Signed-off-by: Aviad Yehezkel --- lib/librte_cryptodev/rte_crypto_sym.h | 42 ++- 1 file changed, 41 insertions(+), 1 deletion

[dpdk-dev] [RFC 3/7] ethdev: add rte flow action for crypto

2017-07-10 Thread Boris Pismenny
The crypto action is specified by an application to request crypto offload for a flow. Signed-off-by: Boris Pismenny Signed-off-by: Aviad Yehezkel --- lib/Makefile| 1 + lib/librte_ether/rte_flow.h | 26 ++ 2 files changed, 27 insertions(+) diff --git

[dpdk-dev] [RFC 6/7] mbuf: Added next_esp_proto field

2017-07-10 Thread Boris Pismenny
From: Aviad Yehezkel Signed-off-by: Aviad Yehezkel Signed-off-by: Boris Pismenny --- lib/librte_mbuf/rte_mbuf.h | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h index b8ab7ed..234c9de 100644 --- a/lib

Re: [dpdk-dev] [RFC][PATCH 0/5] cryptodev: Adding support for inline crypto processing of IPsec flows

2017-05-10 Thread Boris Pismenny
> >> 5. The addition of inline crypto metadata into the rte_mbuf structure to > allow the required egress metadata to be given to the NIC PMD to build the > necessary transmit descriptors in tx_burst processing when the > PKT_TX_IPSEC_INLINE_CRYPTO is set. We are looking for feedback on a > better

Re: [dpdk-dev] [RFC][PATCH 0/5] cryptodev: Adding support for inline crypto processing of IPsec flows

2017-05-10 Thread Boris Pismenny
> 5. The addition of inline crypto metadata into the rte_mbuf structure to > allow the required egress metadata to be given to the NIC PMD to build the > necessary transmit descriptors in tx_burst processing when the > PKT_TX_IPSEC_INLINE_CRYPTO is set. We are looking for feedback on a better