[PATCH v3] crypto/ipsec_mb: bump minimum IPsec MB version

2024-10-10 Thread Brian Dooley
AESNI_MB SW PMDs increment Intel IPsec MB version to 1.4. A minimum IPsec Multi-buffer version of 1.4 or greater is now required for the 24.11 LTS release. Signed-off-by: Brian Dooley Acked-by: Kai Ji Acked-by: Pablo de Lara --- This patch relates to a deprecation notice sent in the 24.03

[PATCH v2] crypto/ipsec_mb: bump minimum IPsec MB version

2024-10-07 Thread Brian Dooley
AESNI_MB SW PMDs increment Intel IPsec MB version to 1.4. A minimum IPsec Multi-buffer version of 1.4 or greater is now required for the 24.11 LTS release. Signed-off-by: Brian Dooley Acked-by: Kai Ji Acked-by: Pablo de Lara --- This patch relates to a deprecation notice sent in the 24.03

[PATCH v1] crypto/ipsec_mb: bump minimum IPsec MB version

2024-10-04 Thread Brian Dooley
AESNI_MB SW PMDs increment Intel IPsec MB version to 1.4. A minimum IPsec Multi-buffer version of 1.4 or greater is now required for the 24.11 LTS release. Signed-off-by: Brian Dooley --- This patch relates to a deprecation notice sent in the 24.03 release. Intel IPsec MB minimum version being

[PATCH v3 3/3] crypto/ipsec_mb: add SM4 algorithm support

2024-10-03 Thread Brian Dooley
This patch introduces SM4 CBC, SM4 ECB and SM4 CTR algorithm support to the AESNI_MB PMD. SM4 CTR is available in the v2.0 release of Intel IPsec MB. Signed-off-by: Brian Dooley --- v2: Add Intel IPsec MB version check to capabilities Add SM4 CTR algorithm support v3: Fix

[PATCH v3 2/3] crypto/ipsec_mb: add HMAC SM3 algorithm support

2024-10-03 Thread Brian Dooley
This patch introduces HMAC SM3 algorithm support to the AESNI_MB PMD. Signed-off-by: Brian Dooley --- v3: Add documentation --- doc/guides/cryptodevs/aesni_mb.rst | 1 + doc/guides/cryptodevs/features/aesni_mb.ini | 1 + doc/guides/rel_notes/release_24_11.rst | 1

[PATCH v3 1/3] crypto/ipsec_mb: add SM3 algorithm support

2024-10-03 Thread Brian Dooley
This patch introduces SM3 algorithm support to the AESNI_MB PMD. Signed-off-by: Brian Dooley --- v3: Add ipsec mb version check Add documentation --- doc/guides/cryptodevs/aesni_mb.rst | 1 + doc/guides/cryptodevs/features/aesni_mb.ini | 1 + doc/guides/rel_notes

[PATCH v2 4/4] doc: updated feature matrix for AESNI MB PMD

2024-09-30 Thread Brian Dooley
Added support to the AESNI MB PMD feature matrix for SM3, SM3 HMAC, SM4 CBC, SM4 ECB, SM4 CTR. Updated release notes with same. Signed-off-by: Brian Dooley --- doc/guides/cryptodevs/features/aesni_mb.ini | 5 + doc/guides/rel_notes/release_24_11.rst | 4 2 files changed, 9

[PATCH v2 3/4] crypto/ipsec_mb: add SM4 algorithm support

2024-09-30 Thread Brian Dooley
This patch introduces SM4 algorithm support for SM4 CBC, SM4 ECB and SM4 CTR to the AESNI_MB PMD. Signed-off-by: Brian Dooley --- v2: Add Intel IPsec MB version check to capabilities Add SM4 CTR algorithm support --- drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 26

[PATCH v2 2/4] crypto/ipsec_mb: add HMAC SM3 algorithm support

2024-09-30 Thread Brian Dooley
This patch introduces HMAC SM3 algorithm support to the AESNI_MB PMD. Signed-off-by: Brian Dooley --- drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 3 +++ drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h | 24 - 2 files changed, 26 insertions(+), 1 deletion(-) diff --git a

[PATCH v2 1/4] crypto/ipsec_mb: add SM3 algorithm support

2024-09-30 Thread Brian Dooley
This patch introduces SM3 algorithm support to the AESNI_MB PMD. Signed-off-by: Brian Dooley --- drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 5 drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h | 26 - 2 files changed, 30 insertions(+), 1 deletion(-) diff --git a/drivers

[PATCH v1 3/3] crypto/ipsec_mb: add SM4 algorithm support

2024-09-06 Thread Brian Dooley
This patch introduces SM4 algorithm support to the AESNI_MB PMD. Signed-off-by: Brian Dooley --- drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 22 ++ drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h | 47 + 2 files changed, 69 insertions(+) diff --git a/drivers/crypto

[PATCH v1 2/3] crypto/ipsec_mb: add HMAC SM3 algorithm support

2024-09-06 Thread Brian Dooley
This patch introduces HMAC SM3 algorithm support to the AESNI_MB PMD. Signed-off-by: Brian Dooley --- drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 3 +++ drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h | 24 - 2 files changed, 26 insertions(+), 1 deletion(-) diff --git a

[PATCH v1 1/3] crypto/ipsec_mb: add SM3 algorithm support

2024-09-06 Thread Brian Dooley
This patch introduces SM3 algorithm support to the AESNI_MB PMD. Signed-off-by: Brian Dooley --- drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 5 drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h | 26 - 2 files changed, 30 insertions(+), 1 deletion(-) diff --git a/drivers

[PATCH v1] crypto/qat: add fix for Gen4 WRITE

2024-07-12 Thread Brian Dooley
om Cc: sta...@dpdk.org Signed-off-by: Brian Dooley --- drivers/crypto/qat/dev/qat_crypto_pmd_gen4.c | 121 ++- drivers/crypto/qat/dev/qat_crypto_pmd_gens.h | 6 + 2 files changed, 123 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/qat/dev/qat_crypto_pmd_gen4.c b/driv

[PATCH v2 1/1] crypto/ipsec_mb: unify some IPsec MB PMDs

2024-06-14 Thread Brian Dooley
IPsec MB direct API for these PMDs. Signed-off-by: Brian Dooley --- v2: * fix doc indentation --- doc/guides/rel_notes/release_24_07.rst| 5 + drivers/crypto/ipsec_mb/pmd_aesni_mb.c| 10 +- drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h | 15 +- drivers/crypto/ipsec_mb

[PATCH v2 0/1] Unifying IPsec MB

2024-06-14 Thread Brian Dooley
Unifying some PMDs in the ipsec_mb crypto driver As discussed previously on the mailing list: https://patches.dpdk.org/project/dpdk/patch/20240228113301.934291-1-brian.doo...@intel.com/ v2: * fix doc indentation Brian Dooley (1): crypto/ipsec_mb: unify some IPsec MB PMDs doc/guides/rel_notes

[PATCH v1 1/1] crypto/ipsec_mb: unify some IPsec MB PMDs

2024-06-05 Thread Brian Dooley
IPsec MB direct API for these PMDs. Signed-off-by: Brian Dooley --- doc/guides/rel_notes/release_24_07.rst| 3 + drivers/crypto/ipsec_mb/pmd_aesni_mb.c| 10 +- drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h | 15 +- drivers/crypto/ipsec_mb/pmd_chacha_poly.c | 340

[PATCH v1 0/1] Unifying IPsec MB

2024-06-05 Thread Brian Dooley
Unifying some PMDs in the ipsec_mb crypto driver As discussed previously on the mailing list: https://patches.dpdk.org/project/dpdk/patch/20240228113301.934291-1-brian.doo...@intel.com/ Brian Dooley (1): crypto/ipsec_mb: unify some IPsec MB PMDs doc/guides/rel_notes/release_24_07.rst

[PATCH v1] crypto/ipsec_mb: use new ipad/opad calculation API

2024-06-05 Thread Brian Dooley
From: Pablo de Lara IPSec Multi-buffer library v1.4 added a new API to calculate inner/outer padding for HMAC-SHAx/MD5. Signed-off-by: Pablo de Lara Signed-off-by: Brian Dooley --- drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 34 +- 1 file changed, 33 insertions(+), 1

[PATCH v7 2/2] doc: announce Intel IPsec MB version bump

2024-03-14 Thread Brian Dooley
The Intel IPsec Multi-buffer version is set to be bumped to a minimum version of 1.4 for the 24.11 LTS release. Signed-off-by: Brian Dooley --- doc/guides/rel_notes/deprecation.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides

[PATCH v7 1/2] doc: remove outdated version details

2024-03-14 Thread Brian Dooley
SW PMDs documentation is updated to remove details of unsupported IPsec Multi-buffer versions. DPDK older than 20.11 is end of life. So, older DPDK versions are removed from the Crypto library version table. Signed-off-by: Sivaramakrishnan Venkat Signed-off-by: Brian Dooley Acked-by: Pablo de

[PATCH v6 5/5] crypto/ipsec_mb: unify some IPsec MB PMDs

2024-03-12 Thread Brian Dooley
IPsec MB direct API for these PMDs. Signed-off-by: Brian Dooley Acked-by: Ciara Power Acked-by: Wathsala Vithanage --- v6: - Reintroduce SNOW3G and ZUC PMDs v5: - Rebased and added patchset v4: - Keep AES GCM PMD and fix extern issue v3: - Remove session configure pointer for each PMD v2: - Fix

[PATCH v6 4/5] crypto/ipsec_mb: use new ipad/opad calculation API

2024-03-12 Thread Brian Dooley
IPSec Multi-buffer library v1.4 added a new API to calculate inner/outer padding for HMAC-SHAx/MD5. Signed-off-by: Pablo de Lara Signed-off-by: Brian Dooley Acked-by: Ciara Power Acked-by: Wathsala Vithanage --- v5: - Rebased and added to patchset v2: - Remove ipsec mb version checks

[PATCH v6 3/5] doc: remove outdated version details

2024-03-12 Thread Brian Dooley
From: Sivaramakrishnan Venkat SW PMDs documentation is updated to remove details of unsupported IPsec Multi-buffer versions.DPDK older than 20.11 is end of life. So, older DPDK versions are removed from the Crypto library version table. Signed-off-by: Sivaramakrishnan Venkat Acked-by: Pablo de

[PATCH v6 2/5] crypto/ipsec_mb: bump minimum IPsec Multi-buffer version

2024-03-12 Thread Brian Dooley
From: Sivaramakrishnan Venkat SW PMDs increment IPsec Multi-buffer version to 1.4. A minimum IPsec Multi-buffer version of 1.4 or greater is now required. Signed-off-by: Sivaramakrishnan Venkat Acked-by: Ciara Power Acked-by: Pablo de Lara Acked-by: Wathsala Vithanage --- v5: - Rebase

[PATCH v6 1/5] ci: replace IPsec-mb package install

2024-03-12 Thread Brian Dooley
From: Ciara Power The IPsec-mb version that is available through current package managers is 1.2. This release moves the minimum required IPsec-mb version for IPsec-mb based SW PMDs to 1.4. To compile these PMDs, a manual step is added to install IPsec-mb v1.4 using dpkg. Signed-off-by: Ciara Po

[PATCH v5 4/4] crypto/ipsec_mb: unified IPsec MB interface

2024-03-05 Thread Brian Dooley
use of the IPsec MB direct API for these PMDs. Signed-off-by: Brian Dooley Acked-by: Ciara Power Acked-by: Wathsala Vithanage --- v5: - Rebased and added patchset v4: - Keep AES GCM PMD and fix extern issue v3: - Remove session configure pointer for each PMD v2: - Fix compilation failure

[PATCH v5 3/4] crypto/ipsec_mb: use new ipad/opad calculation API

2024-03-05 Thread Brian Dooley
IPSec Multi-buffer library v1.4 added a new API to calculate inner/outer padding for HMAC-SHAx/MD5. Signed-off-by: Pablo de Lara Signed-off-by: Brian Dooley Acked-by: Ciara Power Acked-by: Wathsala Vithanage --- v5: - Rebased and added to patchset v2: - Remove ipsec mb version checks

[PATCH v5 2/4] doc: remove outdated version details

2024-03-05 Thread Brian Dooley
From: Sivaramakrishnan Venkat SW PMDs documentation is updated to remove details of unsupported IPsec Multi-buffer versions.DPDK older than 20.11 is end of life. So, older DPDK versions are removed from the Crypto library version table. Signed-off-by: Sivaramakrishnan Venkat Acked-by: Pablo de

[PATCH v5 1/4] crypto/ipsec_mb: bump minimum IPsec Multi-buffer version

2024-03-05 Thread Brian Dooley
From: Sivaramakrishnan Venkat SW PMDs increment IPsec Multi-buffer version to 1.4. A minimum IPsec Multi-buffer version of 1.4 or greater is now required. Signed-off-by: Sivaramakrishnan Venkat Acked-by: Ciara Power Acked-by: Pablo de Lara Acked-by: Wathsala Vithanage --- v5: - Rebase

[PATCH v4] crypto/ipsec_mb: unified IPsec MB interface

2024-02-28 Thread Brian Dooley
use of the IPsec MB direct API for these PMDs. Signed-off-by: Brian Dooley --- v2: - Fix compilation failure v3: - Remove session configure pointer for each PMD v4: - Keep AES GCM PMD and fix extern issue --- doc/guides/rel_notes/release_24_03.rst| 6 + drivers/crypto/ipsec_mb

[PATCH v2] crypto/ipsec_mb: use new ipad/opad calculation API

2024-02-11 Thread Brian Dooley
IPSec Multi-buffer library v1.4 added a new API to calculate inner/outer padding for HMAC-SHAx/MD5. Signed-off-by: Pablo de Lara Signed-off-by: Brian Dooley Acked-by: Ciara Power Depends-on: series-30989 ("crypto/ipsec_mb: bump minimum IPsec Multi-buffer version") v2: - Remov

[PATCH v3] crypto/ipsec_mb: unified IPsec MB interface

2024-01-18 Thread Brian Dooley
remove all use of the IPsec MB direct API for these PMDs. Signed-off-by: Brian Dooley --- v2: - Fix compilation failure v3: - Remove session configure pointer for each PMD --- drivers/crypto/ipsec_mb/pmd_aesni_gcm.c | 757 +- drivers/crypto/ipsec_mb/pmd_aesni_gcm_priv.h

[PATCH v1] common/qat: option to disable asym driver

2023-12-21 Thread Brian Dooley
Currently the QAT sym and asym drivers can only be disabled together when building. Add an option to disable the QAT asym driver. Signed-off-by: Brian Dooley --- drivers/common/qat/meson.build | 22 +--- drivers/crypto/qat/dev/qat_crypto_pmd_gen2.c | 2 ++ drivers

[PATCH v1] crypto/ipsec_mb: use new ipad/opad calculation API

2023-12-14 Thread Brian Dooley
From: Pablo de Lara IPSec Multi-buffer library v1.4 added a new API to calculate inner/outer padding for HMAC-SHAx/MD5. Signed-off-by: Pablo de Lara Signed-off-by: Brian Dooley --- drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 34 +- 1 file changed, 33 insertions(+), 1

[PATCH v2] crypto/ipsec_mb: unified IPsec MB interface

2023-12-14 Thread Brian Dooley
remove all use of the IPsec MB direct API for these PMDs. Signed-off-by: Brian Dooley --- v2: - Fix compilation failure --- drivers/crypto/ipsec_mb/pmd_aesni_gcm.c | 758 +--- drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 8 +- drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h

[PATCH v1] crypto/ipsec_mb: unified IPsec MB interface

2023-12-12 Thread Brian Dooley
remove all use of the IPsec MB direct API for these PMDs. Signed-off-by: Brian Dooley --- drivers/crypto/ipsec_mb/pmd_aesni_gcm.c | 758 +- drivers/crypto/ipsec_mb/pmd_aesni_gcm_priv.h | 21 - drivers/crypto/ipsec_mb/pmd_aesni_mb.c| 6 +- drivers/crypto/ipsec_mb

[PATCH] crypto/qat: fix gen3 legacy capabilities

2023-11-15 Thread Brian Dooley
From: Ciara Power When the legacy capability flag was enabled for QAT GEN3, in the case of the last legacy capability in the list being SM3 or SM4, when no slice is on the device, the loop continues instead of checking if the end of the legacy capbilities list has been met. To fix this, the chec

[PATCH] examples/ipsec-secgw: fix partial overflow

2023-11-15 Thread Brian Dooley
.@dpdk.org Signed-off-by: Brian Dooley --- examples/ipsec-secgw/ipsec.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/examples/ipsec-secgw/ipsec.h b/examples/ipsec-secgw/ipsec.h index 5059418456..10e7fc179b 100644 --- a/examples/ipsec-secgw/ipsec.h +++ b/examples/ipsec-secgw/ipsec.h

[PATCH v2] doc: update QAT kernel module entry

2023-10-13 Thread Brian Dooley
The Kernel Module entry for 2.0 devices was incorrect in the doc table. Updated table with Kernel Module qat_4xxx. Fixes: f4eac3a09c51 ("common/qat: enable GEN4 b devices") Cc: arkadiuszx.kusz...@intel.com Signed-off-by: Brian Dooley --- v2: Correct Fixes tag --- doc/guides/cryptode

[PATCH v1] doc: update QAT kernel module entry

2023-10-13 Thread Brian Dooley
The Kernel Module entry for 2.0 devices was incorrect in the doc table. Updated table with Kernel Module qat_4xxx. Fixes: 83ce3b393176 ("doc: update QAT device support") Signed-off-by: Brian Dooley --- doc/guides/cryptodevs/qat.rst | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH v9 3/3] test/crypto: fix failing synchronous tests

2023-09-19 Thread Brian Dooley
Some synchronous tests are not supported for cpu crypto and need to be skipped. This commit adds in extra skips for these tests. Fixes: 55ab4a8c4fb5 ("test/crypto: disable wireless cases for CPU crypto API") Cc: pablo.de.lara.gua...@intel.com Cc: sta...@dpdk.org Signed-off-by: Br

[PATCH v9 2/3] test/crypto: fix IV in some vectors

2023-09-19 Thread Brian Dooley
SNOW3G and ZUC algorithms require non-zero length IVs. Fixes: c6c267a00a92 ("test/crypto: add mixed encypted-digest") Cc: adamx.dybkow...@intel.com Cc: sta...@dpdk.org Signed-off-by: Brian Dooley Acked-by: Ciara Power --- app/test/test_cryptodev_mixed_test_vectors.h | 8 ++

[PATCH v9 1/3] crypto/ipsec_mb: add digest encrypted feature

2023-09-19 Thread Brian Dooley
AESNI_MB PMD does not support Digest Encrypted. This patch adds a check and support for this feature. Signed-off-by: Brian Dooley Acked-by: Ciara Power --- v9: Added release notes v7: Separate synchronous fix into separate commit v6: Add skipping tests for synchronous crypto v5: Fix checkpatch

[PATCH v9 0/3] Add Digest Encrypted to aesni_mb PMD

2023-09-19 Thread Brian Dooley
v6: Add skipping tests for synchronous crypto v5: Fix checkpatch warnings v4: Add comments and small refactor v3: Add Digest encrypted support to docs v2: Fixed CHECKPATCH warning Brian Dooley (3): crypto/ipsec_mb: add digest encrypted feature test/crypto: fix IV in some vectors test/crypto

[PATCH v8 3/3] test/crypto: fix failing synchronous tests

2023-09-14 Thread Brian Dooley
Signed-off-by: Brian Dooley --- v8: Reword commit and add cc stable --- app/test/test_cryptodev.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index 956268bfcd..70f6b7ece1 100644 --- a/app/test/test_cryptodev.c +++

[PATCH v8 2/3] test/crypto: fix IV in some vectors

2023-09-14 Thread Brian Dooley
SNOW3G and ZUC algorithms require non-zero length IVs. Fixes: c6c267a00a92 ("test/crypto: add mixed encypted-digest") Cc: adamx.dybkow...@intel.com Cc: sta...@dpdk.org Acked-by: Ciara Power Signed-off-by: Brian Dooley -- v8: Add cc stable --- app/test/test_cryptodev_mixed_test_vec

[PATCH v8 1/3] crypto/ipsec_mb: add digest encrypted feature

2023-09-14 Thread Brian Dooley
AESNI_MB PMD does not support Digest Encrypted. This patch adds a check and support for this feature. Acked-by: Ciara Power Signed-off-by: Brian Dooley --- v2: Fixed CHECKPATCH warning v3: Add Digest encrypted support to docs v4: Add comments and small refactor v5: Fix checkpatch warnings v6

[PATCH v8 0/3] Add Digest Encrypted to aesni_mb PMD

2023-09-14 Thread Brian Dooley
checkpatch warnings v6: Add skipping tests for synchronous crypto v7: Separate synchronous fix into separate commit v8: Reword commit and add stable Brian Dooley (3): crypto/ipsec_mb: add digest encrypted feature test/crypto: fix IV in some vectors test/crypto: fix failing synchronous tests

[PATCH v7 3/3] test/crypto: fix failing synchronous tests

2023-09-07 Thread Brian Dooley
Some synchronous tests do not support digest encrypted and need to be skipped. This commit adds in extra skips for these tests. Fixes: 55ab4a8c4fb5 ("test/crypto: disable wireless cases for CPU crypto API") Cc: pablo.de.lara.gua...@intel.com Acked-by: Ciara Power Signed-off-by: Br

[PATCH v7 2/3] test/crypto: fix IV in some vectors

2023-09-07 Thread Brian Dooley
SNOW3G and ZUC algorithms require non-zero length IVs. Fixes: c6c267a00a92 ("test/crypto: add mixed encypted-digest") Cc: adamx.dybkow...@intel.com Acked-by: Ciara Power Signed-off-by: Brian Dooley --- app/test/test_cryptodev_mixed_test_vectors.h | 8 ++-- 1 file changed, 6

[PATCH v7 1/3] crypto/ipsec_mb: add digest encrypted feature

2023-09-07 Thread Brian Dooley
AESNI_MB PMD does not support Digest Encrypted. This patch adds a check and support for this feature. Acked-by: Ciara Power Signed-off-by: Brian Dooley --- v2: Fixed CHECKPATCH warning v3: Add Digest encrypted support to docs v4: Add comments and small refactor v5: Fix checkpatch warnings v6

[PATCH v7 0/3] Add Digest Encrypted to aesni_mb PMD

2023-09-07 Thread Brian Dooley
checkpatch warnings v6: Add skipping tests for synchronous crypto v7: Separate synchronous fix into separate commit Brian Dooley (3): crypto/ipsec_mb: add digest encrypted feature test/crypto: fix IV in some vectors test/crypto: fix failing synchronous tests app/test/test_cryptodev.c

[PATCH v6 2/2] test/crypto: fix IV in some vectors

2023-09-07 Thread Brian Dooley
SNOW3G and ZUC algorithms require non-zero length IVs. Fixes: c6c267a00a92 ("test/crypto: add mixed encypted-digest") Cc: adamx.dybkow...@intel.com Signed-off-by: Brian Dooley --- app/test/test_cryptodev_mixed_test_vectors.h | 8 ++-- 1 file changed, 6 insertions(+), 2 deletion

[PATCH v6 1/2] crypto/ipsec_mb: add digest encrypted feature

2023-09-07 Thread Brian Dooley
AESNI_MB PMD does not support Digest Encrypted. This patch adds a check and support for this feature. Signed-off-by: Brian Dooley --- v2: Fixed CHECKPATCH warning v3: Add Digest encrypted support to docs v4: Add comments and small refactor v5: Fix checkpatch warnings v6: Add skipping tests for

[PATCH v5 0/2] Add Digest Encrypted to aesni_mb PMD

2023-09-07 Thread Brian Dooley
checkpatch warnings v6: Add skipping tests for synchronous crypto Brian Dooley (2): crypto/ipsec_mb: add digest encrypted feature test/crypto: fix IV in some vectors app/test/test_cryptodev_mixed_test_vectors.h | 8 +- doc/guides/cryptodevs/features/aesni_mb.ini | 1 + drivers/crypto

[PATCH v5 2/2] test/crypto: fix IV in some vectors

2023-09-05 Thread Brian Dooley
SNOW3G and ZUC algorithms require non-zero length IVs. Fixes: c6c267a00a92 ("test/crypto: add mixed encypted-digest") Cc: adamx.dybkow...@intel.com Signed-off-by: Brian Dooley --- app/test/test_cryptodev_mixed_test_vectors.h | 8 ++-- 1 file changed, 6 insertions(+), 2 deletion

[PATCH v5 1/2] crypto/ipsec_mb: add digest encrypted feature

2023-09-05 Thread Brian Dooley
AESNI_MB PMD does not support Digest Encrypted. This patch adds a check and support for this feature. Signed-off-by: Brian Dooley --- v2: Fixed CHECKPATCH warning v3: Add Digest encrypted support to docs v4: Add comments and small refactor v5: Fix checkpatch warnings --- doc/guides/cryptodevs

[PATCH v5 0/2] Add Digest Encrypted to aesni_mb PMD

2023-09-05 Thread Brian Dooley
checkpatch warnings Brian Dooley (2): crypto/ipsec_mb: add digest encrypted feature test/crypto: fix IV in some vectors app/test/test_cryptodev_mixed_test_vectors.h | 8 +- doc/guides/cryptodevs/features/aesni_mb.ini | 1 + drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 107

[PATCH v4 2/2] test/crypto: fix IV in some vectors

2023-09-05 Thread Brian Dooley
SNOW3G and ZUC algorithms require non-zero length IVs. Fixes: c6c267a00a92 ("test/crypto: add mixed encypted-digest") Cc: adamx.dybkow...@intel.com Signed-off-by: Brian Dooley --- app/test/test_cryptodev_mixed_test_vectors.h | 8 ++-- 1 file changed, 6 insertions(+), 2 deletion

[PATCH v4 1/2] crypto/ipsec_mb: add digest encrypted feature

2023-09-05 Thread Brian Dooley
AESNI_MB PMD does not support Digest Encrypted. This patch adds a check and support for this feature. Signed-off-by: Brian Dooley --- v2: Fixed CHECKPATCH warning v3: Add Digest encrypted support to docs v4: add comments and refactor --- doc/guides/cryptodevs/features/aesni_mb.ini | 1

[PATCH v4 0/2] Add Digest Encrypted to aesni_mb PMD

2023-09-05 Thread Brian Dooley
This series adds the Digest Encrypted feature to the AESNI_MB PMD. It also fixes an issue where IV data in SNOW3G and ZUC algorithms were incorrect and are required to be non-zero length. v2: Fixed CHECKPATCH warning v3: Add Digest encrypted support to docs v4: add comments and refactor Brian

[PATCH v3] crypto/ipsec_mb: add digest encrypted feature

2023-08-25 Thread Brian Dooley
AESNI_MB PMD does not support Digest Encrypted. This patch adds a check and support for this feature. Signed-off-by: Brian Dooley --- v2: Fixed CHECKPATCH warning v3: Add Digest encrypted support to docs --- doc/guides/cryptodevs/features/aesni_mb.ini | 1 + drivers/crypto/ipsec_mb

[PATCH v2] crypto/ipsec_mb: add digest encrypted feature

2023-08-21 Thread Brian Dooley
AESNI_MB PMD does not support Digest Encrypted. This patch adds a check and support for this feature. Signed-off-by: Brian Dooley --- v2: Fixed CHECKPATCH warning --- drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 107 +++-- 1 file changed, 102 insertions(+), 5 deletions(-) diff

[PATCH v1] crypto/ipsec_mb: add digest encrypted feature

2023-07-20 Thread Brian Dooley
AESNI_MB PMD does not support Digest Encrypted. This patch adds support for this feature. Signed-off-by: Brian Dooley --- drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 107 +++-- 1 file changed, 102 insertions(+), 5 deletions(-) diff --git a/drivers/crypto/ipsec_mb

[PATCH v3 2/2] common/qat: change define header

2023-07-06 Thread Brian Dooley
change define from RTE_LIB_SECURITY to BUILD_QAT_SYM as RTE_ETHER_CRC_LEN value is protected by BUILD_QAT_SYM. Fixes: ce7a737c8f02 ("crypto/qat: support cipher-CRC offload") Cc: kevin.osulli...@intel.com Signed-off-by: Brian Dooley --- drivers/common/qat/qat_qp.c | 2 +- 1 file

[PATCH v3 1/2] crypto/ipsec_mb: remove unused defines

2023-07-06 Thread Brian Dooley
removed AESNI_MB_DOCSIS_SEC_ENABLED defines as they are no longer used. Fixes: 798f9d134519 ("crypto/ipsec_mb: remove security lib presence checks") Cc: maxime.coque...@redhat.com Signed-off-by: Brian Dooley --- drivers/crypto/ipsec_mb/ipsec_mb_private.c | 4 drivers/crypt

[PATCH v3 0/2] remove unused defines

2023-07-06 Thread Brian Dooley
This series removes some unused defines throughout common qat drivers and crypto ipsec mb drivers. It also removes some defines that should have been removed previously. v3: Incorrect fixline v2: more defines removed in additional patch and changed fixline Brian Dooley (2): crypto/ipsec_mb

[PATCH v2 2/2] common/qat: change define header

2023-07-06 Thread Brian Dooley
change define from RTE_LIB_SECURITY to BUILD_QAT_SYM as RTE_ETHER_CRC_LEN value is protected by BUILD_QAT_SYM. Fixes: ce7a737c8f02 ("crypto/qat: support cipher-CRC offload") Cc: kevin.osulli...@intel.com Signed-off-by: Brian Dooley --- drivers/common/qat/qat_qp.c | 2 +- 1 file

[PATCH v2 1/2] crypto/ipsec_mb: remove unused defines

2023-07-06 Thread Brian Dooley
removed AESNI_MB_DOCSIS_SEC_ENABLED defines as they are no longer used. Fixes: 66a9d8d0bc6d ("crypto/qat: remove security library presence checks") Cc: maxime.coque...@redhat.com Signed-off-by: Brian Dooley --- drivers/crypto/ipsec_mb/ipsec_mb_private.c | 4 drivers/crypt

[PATCH v2 0/2] remove unused defines

2023-07-06 Thread Brian Dooley
This series removes some unused defines throughout common qat drivers and crypto ipsec mb drivers. It also removes some defines that should have been removed previously. v2: more defines removed in additional patch and changed fixline Brian Dooley (2): crypto/ipsec_mb: remove unused defines

[PATCH v1] crypto/ipsec_mb: remove unused defines

2023-07-06 Thread Brian Dooley
removed AESNI_MB_DOCSIS_SEC_ENABLED defines as they are no longer used. Fixes: fda5216fba55 ("crypto/aesni_mb: support DOCSIS protocol") Cc: david.co...@intel.com Signed-off-by: Brian Dooley --- drivers/crypto/ipsec_mb/ipsec_mb_private.c | 4 drivers/crypto/ipsec_mb/pmd_

[PATCH v1] crypto/qat: fix struct alignment

2023-06-30 Thread Brian Dooley
The qat_sym_session struct variable alignment was causing a segfault. AES expansion keys require 16-byte alignment. Added __rte_aligned to the expansion keys. Fixes: ca0ba0e48129 ("crypto/qat: default to IPsec MB for computations") Signed-off-by: Brian Dooley --- drivers/

[PATCH v7] crypto/qat: default to IPsec MB for computations

2023-06-20 Thread Brian Dooley
IPsec MB does not support the necessary algorithms. Added version checks for libipsecmb and libcrypto into meson build. Added directives for detecting IPsec MB or OpenSSL. Signed-off-by: Brian Dooley Acked-by: Kai Ji Acked-by: Pablo de Lara Acked-by: Ciara Power --- v7: Rebase for-main v6: Fix

[PATCH v6] crypto/qat: default to IPsec MB for computations

2023-06-16 Thread Brian Dooley
IPsec MB does not support the necessary algorithms. Added version checks for libipsecmb and libcrypto into meson build. Added directives for detecting IPsec MB or OpenSSL. Signed-off-by: Brian Dooley Acked-by: Kai Ji Acked-by: Pablo de Lara --- v6: Fix for arm support and add extra wrappers for

[PATCH v5] crypto/qat: default to IPsec MB for computations

2023-06-06 Thread Brian Dooley
into meson build. Added directives for detecting IPsec MB or OpenSSL. Signed-off-by: Brian Dooley Acked-by: Kai Ji Acked-by: Pablo de Lara --- v5: Remove ipsec mb define and add previous ack v4: Rebase and fix conflicts v3: Fix checkpatch warnings by replacing return with goto v2: OpenSSL code

[PATCH v4] crypto/qat: default to IPsec MB for computations

2023-05-26 Thread Brian Dooley
into meson build. Added directives for detecting IPsec MB or OpenSSL. Signed-off-by: Brian Dooley --- v4: Rebase and fix conflicts v3: Fix checkpatch warnings by replacing return with goto v2: OpenSSL code reintroduced as a fallback feature if Intel IPsec MB 1.4 not available --- doc/guides

[PATCH v3] crypto/qat: default to IPsec MB for pre and post computes

2023-05-22 Thread Brian Dooley
into meson build. Added directives for detecting IPsec MB or OpenSSL. Signed-off-by: Brian Dooley --- v3: Fix checkpatch warnings by replacing return with goto v2: OpenSSL code reintroduced as a fallback feature if Intel IPsec MB 1.4 not available --- doc/guides/cryptodevs/qat.rst

[PATCH v2] crypto/qat: default to IPsec MB for pre and post computes

2023-05-19 Thread Brian Dooley
into meson build. Added directives for detecting IPsec MB or OpenSSL. Signed-off-by: Brian Dooley --- v2: OpenSSL code reintroduced as a fallback feature if Intel IPsec MB 1.4 not available --- doc/guides/cryptodevs/qat.rst| 14 +- drivers/common/qat/meson.build

[PATCH v1] crypto/ipsec_mb: add digest encrypted feature in AESNI_MB

2023-04-21 Thread Brian Dooley
AESNI_MB PMD does not support Digest Encrypted. This patch adds partial support for this feature. Signed-off-by: Brian Dooley --- Some out-of-place tests are still failing. Only some in-place tests are passing. Working on adding support for this feature in v2. --- app/test/1.diff

[PATCH v1] crypto/qat: add IPsec MB AES and DES Docsis support

2023-04-18 Thread Brian Dooley
v1.4. Signed-off-by: Brian Dooley --- A fallback feature is planned for v2 where IPsec MB v1.4 is the default option and the fallback option is to use OpenSSL. The code removed in this patch will be added back in for the fallback feature. IPsec MB is v1.4 is not yet released. --- doc/guides

[PATCH v2] doc: update QAT device support

2022-11-18 Thread Brian Dooley
Update what drivers and devices are supported for Asymmetric Crypto Service on QAT Signed-off-by: Brian Dooley --- doc/guides/cryptodevs/qat.rst | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst

[PATCH v1] doc: update QAT device support

2022-11-15 Thread Brian Dooley
Update Asymmetric Crypto Service on QAT devices. Signed-off-by: Brian Dooley --- doc/guides/cryptodevs/qat.rst | 1 - 1 file changed, 1 deletion(-) diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst index 2d895e61ac..9a5a4e6203 100644 --- a/doc/guides/cryptodevs/qat.rst

[PATCH v1] examples/fips_validation: fix IV generation for gmac

2022-11-02 Thread Brian Dooley
Replace rand() call in fips validation example with rte_rand(). Coverity issue: 381668 Fixes: e27268bd2103 ("examples/fips_validation: add parsing for AES-GMAC") Signed-off-by: Brian Dooley --- examples/fips_validation/main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[PATCH v2] crypto/qat: fix reallocate OpenSSL version check

2022-11-02 Thread Brian Dooley
Move the ossl_legacy_provider_unload() into the right place for secure protocol for QAT. Remove unnecessary unload from session destroy. Fixes: 52d59b92b06d ("crypto/qat: enable OpenSSL legacy provider in session") Cc: kai...@intel.com CC: sta...@dpdk.org Signed-off-by: Brian Dool

[PATCH v1] crypto/qat: fix reallocate OpenSSL version check

2022-10-31 Thread Brian Dooley
Move the ossl_legacy_provider_unload() into the right place for secure protocol for QAT. Remove unnecessary unload from session destroy. Fixes: 52d59b92b06d ("crypto/qat: enable OpenSSL legacy provider in session") Cc: kai...@intel.com CC: sta...@dpdk.org Signed-off-by: Brian Dooley --

[PATCH v1] crypto/qat: fix null hash algorithm digest size

2022-10-27 Thread Brian Dooley
Add check for null hash algorithm digest size. Digest size should be 4B or request will be rejected. Fixes: 1703e94ac5ce ("qat: add driver for QuickAssist devices") Cc: declan.dohe...@intel.com Cc: sta...@dpdk.org Signed-off-by: Brian Dooley --- drivers/crypto/qat/qat_sym_sess

[PATCH v1] examples/fips_validation: parse block error fix

2022-10-24 Thread Brian Dooley
When parsing request files check for file type. This fix will remove dependence on command line parameter for using libjansson Fixes: 0f42f3d6034c ("examples/fips_validation: share callback with multiple keys") Cc: gmuthukri...@marvell.com Signed-off-by: Brian Dooley ---

[PATCH v5] examples/fips_validation: add parsing for AES CTR

2022-10-07 Thread Brian Dooley
Added functionality to parse algorithm for AES CTR test Signed-off-by: Brian Dooley Acked-by: Kai Ji Acked-by: Gowrishankar Muthukrishnan --- v2: fix clang warning for int-in-bool-context --- v3: in reply to fix and patchwork CI --- v4: missing acks --- v5: add documentation --- doc/guides

[PATCH v2] crypto/qat: reallocate on openssl version check

2022-10-07 Thread Brian Dooley
This patch reallocates the openssl version check from qat_session_configure() to a proper qat_security_session_create() routine Fixes: 3227bc7138f5 ("crypto/qat: use intel-ipsec-mb for partial hash and AES") Cc: sta...@dpdk.org Signed-off-by: Brian Dooley --- v2: rebase on main --

[PATCH v1] crypto/qat: reallocate on openssl version check

2022-10-03 Thread Brian Dooley
This patch reallocates the openssl version check from qat_session_configure() to a proper qat_security_session_create() routine Fixes: 3227bc7138f5 ("crypto/qat: use intel-ipsec-mb for partial hash and AES") Cc: sta...@dpdk.org Signed-off-by: Brian Dooley --- drivers/

[PATCH v4] examples/fips_validation: add parsing for AES CTR

2022-09-30 Thread Brian Dooley
Added functionality to parse algorithm for AES CTR test Signed-off-by: Brian Dooley Acked-by: Kai Ji Acked-by: Gowrishankar Muthukrishnan --- v2: fix clang warning for int-in-bool-context --- v3: in reply to fix and patchwork CI --- v4: missing acks --- examples/fips_validation

[PATCH v3] examples/fips_validation: add parsing for AES CTR

2022-09-16 Thread Brian Dooley
Added functionality to parse algorithm for AES CTR test Signed-off-by: Brian Dooley Acked-by: Kai Ji --- v2: fix clang warning for int-in-bool-context --- v3: in reply to fix and patchwork CI --- examples/fips_validation/fips_validation.c | 2 ++ examples/fips_validation/fips_validation.h

[PATCH v3] examples/fips_validation: add parsing for AES GMAC

2022-09-16 Thread Brian Dooley
Added functionality to parse algorithm for AES GMAC test Signed-off-by: Brian Dooley Acked-by: Kai Ji --- v2: add random internal iv generation --- v3: in reply to fix and patchwork CI --- examples/fips_validation/fips_validation.c| 2 ++ examples/fips_validation/fips_validation.h| 1

[PATCH v2] examples/fips_validation: add parsing for AES GMAC

2022-09-01 Thread Brian Dooley
Added functionality to parse algorithm for AES GMAC test Signed-off-by: Brian Dooley --- v2: add random internal iv generation --- examples/fips_validation/fips_validation.c| 2 ++ examples/fips_validation/fips_validation.h| 1 + .../fips_validation/fips_validation_gcm.c | 13

[PATCH v2] examples/fips_validation: add parsing for AES CTR

2022-08-22 Thread Brian Dooley
Added functionality to parse algorithm for AES CTR test Signed-off-by: Brian Dooley --- v2: fix clang warning for int-in-bool-context --- examples/fips_validation/fips_validation.c | 2 ++ examples/fips_validation/fips_validation.h | 2 ++ examples/fips_validation/fips_validation_aes.c

[PATCH v1] examples/fips_validation: add parsing for AES GMAC

2022-08-19 Thread Brian Dooley
Added functionality to parse algorithm for AES GMAC test Signed-off-by: Brian Dooley --- examples/fips_validation/fips_validation.c | 2 ++ examples/fips_validation/fips_validation.h | 1 + examples/fips_validation/main.c| 6 ++ 3 files changed, 9 insertions(+) diff --git a

[PATCH v1] examples/fips_validation: add parsing for AES CTR

2022-08-19 Thread Brian Dooley
Added functionality to parse algorithm for AES CTR test Signed-off-by: Brian Dooley --- examples/fips_validation/fips_validation.c | 2 ++ examples/fips_validation/fips_validation.h | 2 ++ examples/fips_validation/fips_validation_aes.c | 5 + examples/fips_validation/main.c

[RFC] examples/fips_validation: add fips 140-3 acvp aes-cbc test

2022-05-20 Thread Brian Dooley
rect result set as the IV update part has yet to be implemented. This will be addressed in next revision. Signed-off-by: Brian Dooley --- examples/fips_validation/fips_test_acvp.c | 183 + examples/fips_validation/fips_validation.h | 34 examples/fips_validation/ma

[PATCH] maintainers: Update MAINTAINERS for FIPS validation

2022-03-07 Thread Brian Dooley
Replace Marko Kovacevic with Brian Dooley and Fan Zhang Signed-off-by: Brian Dooley Cc: Marko Kovacevic Cc: Fan Zhang Cc: Akhil Goyal --- MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 75778343a5..c9c1cf7285 100644 --- a

  1   2   >