Re: [dpdk-dev] [PATCH] app/procinfo: add device registers dump

2021-07-19 Thread Chengchang Tang
On 2021/7/18 1:53, Stephen Hemminger wrote: > On Sun, 25 Apr 2021 21:02:22 +0800 > "Min Hu (Connor)" wrote: > >> snprintf(file_name, MAX_FILE_NAME_SZ, "%s-port%u", >> +file_prefix, i); >> +fp_regs = fopen(file_name, "wb"); >> +if

Re: [dpdk-dev] [PATCH] app/procinfo: add device registers dump

2021-07-18 Thread Chengchang Tang
On 2021/7/18 1:51, Stephen Hemminger wrote: > On Sun, 25 Apr 2021 21:02:22 +0800 > "Min Hu (Connor)" wrote: > >> + >> +memset(®_info, 0, sizeof(reg_info)); >> +memset(&dev_info, 0, sizeof(dev_info)); > > This memset is redundant, rte_eth_dev_info_get already has the sam

Re: [dpdk-dev] [PATCH 1/2] net/bonding: support Tx prepare for bonding

2021-06-10 Thread Chengchang Tang
On 2021/6/9 17:35, Andrew Rybchenko wrote: > On 6/9/21 9:42 AM, Chengchang Tang wrote: >> Hi, Andrew and Ferruh >> >> On 2021/6/8 17:49, Andrew Rybchenko wrote: >>> "for bonding" is redundant in the summary since it is already "net/bonding".

Re: [dpdk-dev] [PATCH 1/2] net/bonding: support Tx prepare for bonding

2021-06-09 Thread Chengchang Tang
On 2021/6/9 18:25, Ananyev, Konstantin wrote: >>> On 4/23/21 12:46 PM, Chengchang Tang wrote: >>>> To use the HW offloads capability (e.g. checksum and TSO) in the Tx >>>> direction, the upper-layer users need to call rte_eth_dev_prepare to do >>>>

Re: [dpdk-dev] [PATCH 2/2] net/bonding: support configuring Tx offloading for bonding

2021-06-09 Thread Chengchang Tang
s already >>>> "net/bonding" >>>> >>>> On 4/23/21 12:46 PM, Chengchang Tang wrote: >>>>> Currently, the TX offloading of the bonding device will not take effect by >>>> >>>> TX -> Tx >>>> >>>>>

Re: [dpdk-dev] [PATCH 2/2] net/bonding: support configuring Tx offloading for bonding

2021-06-08 Thread Chengchang Tang
On 2021/6/8 17:49, Andrew Rybchenko wrote: > "for bonding" is redundant in the summary since it is already > "net/bonding" > > On 4/23/21 12:46 PM, Chengchang Tang wrote: >> Currently, the TX offloading of the bonding device will not take effect by &

Re: [dpdk-dev] [PATCH 1/2] net/bonding: support Tx prepare for bonding

2021-06-08 Thread Chengchang Tang
Hi, Andrew and Ferruh On 2021/6/8 17:49, Andrew Rybchenko wrote: > "for bonding" is redundant in the summary since it is already "net/bonding". > > On 4/23/21 12:46 PM, Chengchang Tang wrote: >> To use the HW offloads capability (e.g. checksum and TSO) in t

Re: [dpdk-dev] [PATCH] app/procinfo: add device registers dump

2021-06-04 Thread Chengchang Tang
On 2021/6/4 23:04, Pattan, Reshma wrote: > > >> -Original Message- >> From: Min Hu (Connor) > > > >> +ret = rte_eth_dev_get_reg_info(i, ®_info); >> +if (ret) { >> +printf("Error getting device reg info: %d\n", ret); >> +

Re: [dpdk-dev] [PATCH 0/2] add Tx prepare support for bonding device

2021-06-02 Thread Chengchang Tang
Hi,all Any comments to these patches? On 2021/4/23 17:46, Chengchang Tang wrote: > This patch set add Tx prepare for bonding device. > > Currently, the bonding driver has not implemented the callback of > rte_eth_tx_prepare function. Therefore, the TX prepare function of the > sla

Re: [dpdk-dev] [PATCH] examples/timer: fix incorrect time interval

2021-05-06 Thread Chengchang Tang
On 2021/5/6 16:08, Thomas Monjalon wrote: > 06/05/2021 04:06, Chengchang Tang: >> >> On 2021/5/6 5:37, Thomas Monjalon wrote: >>> 15/04/2021 09:12, Min Hu (Connor): >>>> From: Chengchang Tang >>>> >>>> Timer sample example assumes t

Re: [dpdk-dev] [PATCH] examples/timer: fix incorrect time interval

2021-05-05 Thread Chengchang Tang
On 2021/5/6 5:37, Thomas Monjalon wrote: > 15/04/2021 09:12, Min Hu (Connor): >> From: Chengchang Tang >> >> Timer sample example assumes that the frequency of the timer is about >> 2Ghz to control the period of calling rte_timer_manage(). But this >> assump

Re: [dpdk-dev] [PATCH 0/2] add Tx prepare support for bonding device

2021-04-29 Thread Chengchang Tang
Hi,all Any comments? On 2021/4/23 17:46, Chengchang Tang wrote: > This patch set add Tx prepare for bonding device. > > Currently, the bonding driver has not implemented the callback of > rte_eth_tx_prepare function. Therefore, the TX prepare function of the > slave devices will n

Re: [dpdk-dev] [PATCH] net/bonding: fix socket id check

2021-04-26 Thread Chengchang Tang
On 2021/4/26 22:54, Ferruh Yigit wrote: > On 4/22/2021 8:12 AM, Min Hu (Connor) wrote: >> From: Chengchang Tang >> >> The socket ID entered by user is cast to an unsigned integer. However, >> the value may be an illegal negative value, which may cause some >>

[dpdk-dev] [PATCH 0/2] add Tx prepare support for bonding device

2021-04-23 Thread Chengchang Tang
tx_prepare and its impact on performance depend on the design of slave PMDs. And configuring Tx offloading for bonding is also added in this patchset. This solves the problem that we need to configure slave devices one by one when configuring Tx offloading. Chengchang Tang (2): net/bonding

[dpdk-dev] [PATCH 1/2] net/bonding: support Tx prepare for bonding

2021-04-23 Thread Chengchang Tang
needs to be sent by all slave ports. Different PMDs process the packets differently in tx_prepare. As a result, the sent packet may be incorrect. Signed-off-by: Chengchang Tang --- drivers/net/bonding/rte_eth_bond.h | 1 - drivers/net/bonding/rte_eth_bond_pmd.c | 28 --

[dpdk-dev] [PATCH 2/2] net/bonding: support configuring Tx offloading for bonding

2021-04-23 Thread Chengchang Tang
: Chengchang Tang --- drivers/net/bonding/rte_eth_bond_pmd.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c index 84af348..9922657 100644 --- a/drivers/net/bonding/rte_eth_bond_pmd.c +++ b/drivers/net

Re: [dpdk-dev] [PATCH] examples/timer: fix incorrect time interval

2021-04-21 Thread Chengchang Tang
Hi On 2021/4/22 2:34, Thomas Monjalon wrote: > 15/04/2021 09:12, Min Hu (Connor): >> From: Chengchang Tang >> >> Timer sample example assumes that the frequency of the timer is about >> 2Ghz to control the period of calling rte_timer_manage(). But this >> assump

Re: [dpdk-dev] [RFC 0/2] add Tx prepare support for bonding device

2021-04-20 Thread Chengchang Tang
On 2021/4/20 21:18, Ananyev, Konstantin wrote: > > >> -Original Message----- >> From: Chengchang Tang >> Sent: Tuesday, April 20, 2021 1:44 PM >> To: Ananyev, Konstantin ; Yigit, Ferruh >> ; dev@dpdk.org >> Cc: linux...@huawei.com; ch...@att.com

Re: [dpdk-dev] [RFC 0/2] add Tx prepare support for bonding device

2021-04-20 Thread Chengchang Tang
Hi On 2021/4/20 16:33, Ananyev, Konstantin wrote: > Hi everyone, > >> >> On 2021/4/20 9:26, Ferruh Yigit wrote: >>> On 4/16/2021 12:04 PM, Chengchang Tang wrote: >>>> This patch add Tx prepare for bonding device. >>>> >>>> Cu

Re: [dpdk-dev] [RFC 0/2] add Tx prepare support for bonding device

2021-04-19 Thread Chengchang Tang
On 2021/4/20 9:26, Ferruh Yigit wrote: > On 4/16/2021 12:04 PM, Chengchang Tang wrote: >> This patch add Tx prepare for bonding device. >> >> Currently, the bonding driver has not implemented the callback of >> rte_eth_tx_prepare function. Therefore, the TX prepare funct

[dpdk-dev] [RFC 1/2] net/bonding: add Tx prepare for bonding

2021-04-16 Thread Chengchang Tang
Note: The rte_eth_tx_prepare is not added to bond mode 3(Broadcast). This is because in broadcast mode, a packet needs to be sent by all slave ports. Different PMDs process the packets differently in tx_prepare. As a result, the sent packet may be incorrect. Signed-off-by: Chengchang Tang --- driver

[dpdk-dev] [RFC 2/2] app/testpmd: add cmd for bonding Tx prepare

2021-04-16 Thread Chengchang Tang
driver would call rte_eth_dev_prepare to do some adjustment to the packets in the fast path to meet the device's requirement to turn on some HW offload(e.g. processing pseudo headers when Tx checksum offload enabled). This help bonded device to use more Tx offloads. Signed-off-by: Chengchang

[dpdk-dev] [RFC 0/2] add Tx prepare support for bonding device

2021-04-16 Thread Chengchang Tang
bonded device need call the rte_eth_tx_prepare. If upper-layer users need to use some TX offloading that depend on tx_prepare , they should enable the preparation function. In this way, the bonded device will call the rte_eth_tx_prepare for the fast path packets in the tx_burst callback. Chengchang Tang

Re: [dpdk-dev] [PATCH v19 0/3] Arm build options rework

2021-04-11 Thread Chengchang Tang
project/dpdk/list/?series=15918 I reworked our configuration based on this series and then tested it on our platform (i.e. Kunpeng 920/ Kunpeng 930 SoC). Tested-by: Chengchang Tang > Juraj Linkeš (3): > build: disable/enable drivers in Arm builds > build: add 'platform' me

Re: [dpdk-dev] [Question about 'rte_eth_tx_prepare']

2021-02-08 Thread Chengchang Tang
On 2021/2/8 16:40, Olivier Matz wrote: > Hi, > > On Mon, Feb 08, 2021 at 09:07:39AM +0100, Thomas Monjalon wrote: >> 08/02/2021 07:29, Chengchang Tang: >>> Hi, Thomas Monjalon and Ferruh Yigit and others. >>> >>> Here are two questions: >>> 1. W

[dpdk-dev] [Question about 'rte_eth_tx_prepare']

2021-02-07 Thread Chengchang Tang
ocessing? (it seems not transplantable) If so, it seems that PMDs need to avoid doing this in 'tx_prepare'. Here are two questions: 1. What functions should be included in the 'tx_prepare' for PMDs? 2. Whether an app must invoke 'rte_eth_tx_prepare' or under which conditions an app must invoke the 'rte_eth_tx_prepare'? Thanks Chengchang Tang

Re: [dpdk-dev] [PATCH v3 3/6] app/testpmd: remove restriction on txpkts set

2020-09-23 Thread Chengchang Tang
gt; On 9/19/2020 11:47 AM, Wei Hu (Xavier) wrote: >>>>> From: Chengchang Tang >>>>> >>>>> Currently, if nb_txd is not set, the txpkts is not allowed to be set >>>>> because the nb_txd is used to avoid the numer of segments exceed the Tx >>&g

[dpdk-dev] [PATCH v5 1/2] ethdev: add a field for rxq info structure

2020-09-21 Thread Chengchang Tang
Add a field named rx_buf_size in rte_eth_rxq_info to indicate the buffer size used in receiving packets for HW. In this way, upper-layer users can get this information by calling rte_eth_rx_queue_info_get. Signed-off-by: Chengchang Tang Reviewed-by: Wei Hu (Xavier) Acked-by: Andrew Rybchenko

[dpdk-dev] [PATCH v5 0/2] add Rx buffer size for rxq info structure

2020-09-21 Thread Chengchang Tang
Chengchang Tang (2): ethdev: add a field for rxq info structure net/hns3: add Rx buffer size to Rx qinfo query app/proc-info/main.c | 13 + app/test-pmd/config.c| 2 ++ doc/guides/rel_notes/deprecation.rst | 5 - drivers/net/hns3/hns3_rxtx.c

[dpdk-dev] [PATCH v5 2/2] net/hns3: add Rx buffer size to Rx qinfo query

2020-09-21 Thread Chengchang Tang
Report hns3 PMD configured Rx buffer size in Rx queue information query. Signed-off-by: Chengchang Tang Reviewed-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_rxtx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/hns3/hns3_rxtx.c b/drivers/net/hns3/hns3_rxtx.c index 308d0a6

Re: [dpdk-dev] [PATCH v4 3/5] app/procinfo: add Rx buffer size to --show-port

2020-09-20 Thread Chengchang Tang
; On Mon, 7 Sep 2020 17:14:48 +0800 > Chengchang Tang wrote: > >> On 2020/9/6 0:59, Stephen Hemminger wrote: >>> On Sat, 5 Sep 2020 17:07:32 +0800 >>> Chengchang Tang wrote: >>> >>>>

Re: [dpdk-dev] [PATCH v4 2/5] app/testpmd: add Rx buffer size display in queue info query

2020-09-20 Thread Chengchang Tang
On 2020/9/18 16:54, Ferruh Yigit wrote: > On 9/5/2020 10:07 AM, Chengchang Tang wrote: >> Add Rx buffer size to queue info querry cmd so that the user can get the >> buffer length used by HW queue for receiving packets. >> >> Signed-off-by: Chengchang Tang >

Re: [dpdk-dev] [PATCH v2 3/4] app/testpmd: fix packet header in txonly mode

2020-09-17 Thread Chengchang Tang
On 2020/9/17 19:16, Ferruh Yigit wrote: > On 9/17/2020 8:10 AM, Chengchang Tang wrote: >> >> >> On 2020/9/15 0:23, Ferruh Yigit wrote: >>> On 8/20/2020 2:42 AM, Wei Hu (Xavier) wrote: >>>> From: Chengchang Tang >>>> >>>>

Re: [dpdk-dev] [PATCH v2 3/4] app/testpmd: fix packet header in txonly mode

2020-09-17 Thread Chengchang Tang
On 2020/9/15 0:23, Ferruh Yigit wrote: > On 8/20/2020 2:42 AM, Wei Hu (Xavier) wrote: >> From: Chengchang Tang >> >> In txonly forward mode, the packet header is fixed by the initial >> setting, including the packet length and checksum. So when the packets >>

Re: [dpdk-dev] [PATCH v3 1/4] ethdev: add a field for rxq info structure

2020-09-07 Thread Chengchang Tang
Hi Matan On 2020/9/7 16:28, Matan Azrad wrote: > > Hi Chengchang > > From: Chengchang Tang: >> Hi Matan >> >> On 2020/9/6 21:45, Matan Azrad wrote: >>> >>> Hi Chengchang >>> >>> From: Chengchang Tang: >>>>

Re: [dpdk-dev] [PATCH v4 3/5] app/procinfo: add Rx buffer size to --show-port

2020-09-07 Thread Chengchang Tang
On 2020/9/6 0:59, Stephen Hemminger wrote: > On Sat, 5 Sep 2020 17:07:32 +0800 > Chengchang Tang wrote: > >> printf("\t -- queue %d rx scatter %d" >>

Re: [dpdk-dev] [PATCH v4 5/5] doc: remove rxq info structure deprecation notice

2020-09-07 Thread Chengchang Tang
On 2020/9/6 0:33, Thomas Monjalon wrote: > 05/09/2020 11:07, Chengchang Tang: >> The change has been applied, so remove the notice. > > It should be atomic with the patch doing the change, > i.e. you can squash. > > I think the oneline patches in testpmd and pr

Re: [dpdk-dev] [PATCH v3 1/4] ethdev: add a field for rxq info structure

2020-09-07 Thread Chengchang Tang
Hi Matan On 2020/9/6 21:45, Matan Azrad wrote: > > Hi Chengchang > > From: Chengchang Tang: >> Hi, Matan >> >> On 2020/9/2 18:30, Matan Azrad wrote: >>> Hi Chengchang >>> >>> From: Chengchang Tang >>>> Hi, Matan >

[dpdk-dev] [PATCH v4 5/5] doc: remove rxq info structure deprecation notice

2020-09-05 Thread Chengchang Tang
The change has been applied, so remove the notice. Signed-off-by: Chengchang Tang --- doc/guides/rel_notes/deprecation.rst | 5 - 1 file changed, 5 deletions(-) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index 345c38d..b6d57b9 100644 --- a/doc

[dpdk-dev] [PATCH v4 1/5] ethdev: add a field for rxq info structure

2020-09-05 Thread Chengchang Tang
Add a field named rx_buf_size in rte_eth_rxq_info to indicate the buffer size used in receiving packets for HW. In this way, upper-layer users can get this information by calling rte_eth_rx_queue_info_get. Signed-off-by: Chengchang Tang Reviewed-by: Wei Hu (Xavier) Acked-by: Andrew Rybchenko

[dpdk-dev] [PATCH v4 2/5] app/testpmd: add Rx buffer size display in queue info query

2020-09-05 Thread Chengchang Tang
Add Rx buffer size to queue info querry cmd so that the user can get the buffer length used by HW queue for receiving packets. Signed-off-by: Chengchang Tang Reviewed-by: Wei Hu (Xavier) --- app/test-pmd/config.c | 1 + 1 file changed, 1 insertion(+) diff --git a/app/test-pmd/config.c b/app

[dpdk-dev] [PATCH v4 3/5] app/procinfo: add Rx buffer size to --show-port

2020-09-05 Thread Chengchang Tang
Add Rx buffer size to show_port function to display it in the port PMD information so that the user can get the buffer length used by HW queue of receiving packets. Signed-off-by: Chengchang Tang --- app/proc-info/main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/proc-info/main.c

[dpdk-dev] [PATCH v4 0/5] add Rx buffer size for rxq info structure

2020-09-05 Thread Chengchang Tang
indicate the buffer size used in receiving packets for HW. And this field is optional, so there is no need to forcibly update all PMDs. This patchset also update testpmd, proc-info tools and add hns3 PMD implementation. v4: - remove deprecation notice once changes applied Chengchang Tang (5): ethdev

[dpdk-dev] [PATCH v4 4/5] net/hns3: add Rx buffer size to Rx qinfo query

2020-09-05 Thread Chengchang Tang
Report hns3 PMD configured Rx buffer size in Rx queue information query. Signed-off-by: Chengchang Tang Reviewed-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_rxtx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/hns3/hns3_rxtx.c b/drivers/net/hns3/hns3_rxtx.c index fc1a256

Re: [dpdk-dev] [PATCH v3 1/4] ethdev: add a field for rxq info structure

2020-09-03 Thread Chengchang Tang
On 2020/9/3 23:01, Ferruh Yigit wrote: > On 8/29/2020 8:13 AM, Chengchang Tang wrote: >> Add a field named rx_buf_size in rte_eth_rxq_info to indicate the buffer >> size used in receiving packets for HW. >> >> In this way, upper-layer users can get

Re: [dpdk-dev] [PATCH v3 1/4] ethdev: add a field for rxq info structure

2020-09-02 Thread Chengchang Tang
Hi, Matan On 2020/9/2 18:30, Matan Azrad wrote: > Hi Chengchang > > From: Chengchang Tang >> Hi, Matan >> >> On 2020/9/2 15:19, Matan Azrad wrote: >>> >>> Hi Chengchang >>> >>> From: Chengchang Tang >>>> Hi, Mata

Re: [dpdk-dev] [PATCH v3 1/4] ethdev: add a field for rxq info structure

2020-09-02 Thread Chengchang Tang
Hi, Matan On 2020/9/2 15:19, Matan Azrad wrote: > > Hi Chengchang > > From: Chengchang Tang >> Hi, Matan >> >> On 2020/9/1 23:33, Matan Azrad wrote: >>> >>> Hi Chengchang >>> >>> Please see some question below. >>> >&

Re: [dpdk-dev] [PATCH v3 1/4] ethdev: add a field for rxq info structure

2020-09-01 Thread Chengchang Tang
Hi, Matan On 2020/9/1 23:33, Matan Azrad wrote: > > Hi Chengchang > > Please see some question below. > > From: Chengchang Tang >> Add a field named rx_buf_size in rte_eth_rxq_info to indicate the buffer size >> used in receiving packets for HW. >> >&

[dpdk-dev] [PATCH v3 4/4] net/hns3: add Rx buffer size to Rx qinfo query

2020-08-29 Thread Chengchang Tang
Report hns3 PMD configured Rx buffer size in Rx queue information query. Signed-off-by: Chengchang Tang Reviewed-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_rxtx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/hns3/hns3_rxtx.c b/drivers/net/hns3/hns3_rxtx.c index fc1a256

[dpdk-dev] [PATCH v3 2/4] app/testpmd: add Rx buffer size display in queue info query

2020-08-29 Thread Chengchang Tang
Add Rx buffer size to queue info querry cmd so that the user can get the buffer length used by HW queue for receiving packets. Signed-off-by: Chengchang Tang Reviewed-by: Wei Hu (Xavier) --- app/test-pmd/config.c | 1 + 1 file changed, 1 insertion(+) diff --git a/app/test-pmd/config.c b/app

[dpdk-dev] [PATCH v3 1/4] ethdev: add a field for rxq info structure

2020-08-29 Thread Chengchang Tang
Add a field named rx_buf_size in rte_eth_rxq_info to indicate the buffer size used in receiving packets for HW. In this way, upper-layer users can get this information by calling rte_eth_rx_queue_info_get. Signed-off-by: Chengchang Tang Reviewed-by: Wei Hu (Xavier) Acked-by: Andrew Rybchenko

[dpdk-dev] [PATCH v3 3/4] app/procinfo: add Rx buffer size to --show-port

2020-08-29 Thread Chengchang Tang
Add Rx buffer size to show_port function to display it in the port PMD information so that the user can get the buffer length used by HW queue of receiving packets. Signed-off-by: Chengchang Tang --- app/proc-info/main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/proc-info/main.c

[dpdk-dev] [PATCH v3 0/4] add Rx buffer size for rxq info structure

2020-08-29 Thread Chengchang Tang
indicate the buffer size used in receiving packets for HW. And this field is optional, so there is no need to forcibly update all PMDs. This patchset also update testpmd, proc-info tools and add hns3 PMD implementation. Chengchang Tang (4): ethdev: add a field for rxq info structure app/testpmd: add

Re: [dpdk-dev] [PATCH v2 2/3] app/testpmd: add Rx buffer size display in queue info query

2020-08-28 Thread Chengchang Tang
Hi, Stephen Hemminger On 2020/8/26 22:42, Stephen Hemminger wrote: > On Wed, 26 Aug 2020 15:12:22 +0800 > Chengchang Tang wrote: > >> Add Rx buffer size to queue info querry cmd so that the user can get the >> buffer length used by HW queue for receiving packets. >> &

[dpdk-dev] [PATCH v2 3/3] net/hns3: add Rx buffer size to Rx qinfo query

2020-08-26 Thread Chengchang Tang
Report hns3 PMD configured Rx buffer size in Rx queue information query. Signed-off-by: Chengchang Tang --- v1 -> v2: fix some spelling mistake. --- drivers/net/hns3/hns3_rxtx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/hns3/hns3_rxtx.c b/drivers/net/hns3/hns3_rxt

[dpdk-dev] [PATCH v2 2/3] app/testpmd: add Rx buffer size display in queue info query

2020-08-26 Thread Chengchang Tang
Add Rx buffer size to queue info querry cmd so that the user can get the buffer length used by HW queue for receiving packets. Signed-off-by: Chengchang Tang --- v1 -> v2: fix some spelling mistake --- app/test-pmd/config.c | 1 + 1 file changed, 1 insertion(+) diff --git a/app/test-

[dpdk-dev] [PATCH v2 1/3] ethdev: add a field for rxq info structure

2020-08-26 Thread Chengchang Tang
Add a field named rx_buf_size in rte_eth_rxq_info to indicate the buffer size used in receiving packets for HW. In this way, upper-layer users can get this information by calling rte_eth_rx_queue_info_get. Signed-off-by: Chengchang Tang Acked-by: Andrew Rybchenko --- v1 -> v2: fix wr

[dpdk-dev] [PATCH v2 0/3] add Rx buffer size for rxq info structure

2020-08-26 Thread Chengchang Tang
indicate the buffer size used in receiving packets for HW. And this field is optional, so there is no need to forcibly update all PMDs. This patchset also add hns3 PMD implementation and update the testpmd. Chengchang Tang (3): ethdev: add a field for rxq info structure app/testpmd: add Rx buffer

[dpdk-dev] [PATCH 0/3] add RX buffer size for rte_eth_rxq_info

2020-08-25 Thread Chengchang Tang
indicate the buffer size used in receiving packets for HW. And this field is optional, so there is no need to forcibly update all PMDs. This patchset also add hns3 PMD implementation and update the testpmd. Chengchang Tang (3): ethdev: add a field for rte_eth_rxq_info app/testpmd: Add RX buffer size

[dpdk-dev] [PATCH 3/3] net/hns3: add RX buffer size to rx qinfo querry

2020-08-25 Thread Chengchang Tang
Report hns3 PMD configured RX buffer size in RX qinfo querry. Signed-off-by: Chengchang Tang --- drivers/net/hns3/hns3_rxtx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/hns3/hns3_rxtx.c b/drivers/net/hns3/hns3_rxtx.c index fc1a256..50881d4 100644 --- a/drivers/net/hns3

[dpdk-dev] [PATCH 1/3] ethdev: add a field for rte_eth_rxq_info

2020-08-25 Thread Chengchang Tang
Add a field named rx_buf_size in rte_eth_rxq_info to indicate the buffer size used in receiving packets for HW. In this way, upper-layer users can get this information by calling rte_eth_rx_queue_info_get. Signed-off-by: Chengchang Tang Acked-by: Andrew Rybchenko --- lib/librte_ethdev

[dpdk-dev] [PATCH 2/3] app/testpmd: Add RX buffer size display in queue info querry

2020-08-25 Thread Chengchang Tang
Add RX buffer size to queue info querry cmd so that the user can get the buffer length used by HW queue for receiving packets. Signed-off-by: Chengchang Tang --- app/test-pmd/config.c | 1 + 1 file changed, 1 insertion(+) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 30bee33

[dpdk-dev] [PATCH v3] doc: add new field to rxq info struct

2020-08-07 Thread Chengchang Tang
/dev/2020-July/176135.html Signed-off-by: Chengchang Tang Acked-by: Andrew Rybchenko Acked-by: Viacheslav Ovsiienko --- v3: - Remove redundant sentences. v2: - Remove field name. - Fix some spelling mistake. --- doc/guides/rel_notes/deprecation.rst | 5 + 1 file changed, 5 insertions

Re: [dpdk-dev] [PATCH v2] doc: add new field to rxq info struct

2020-08-06 Thread Chengchang Tang
On 2020/8/6 20:50, Slava Ovsiienko wrote: >> -Original Message- >> From: dev On Behalf Of Chengchang Tang >> Sent: Thursday, August 6, 2020 7:01 >> To: dev@dpdk.org >> Cc: linux...@huawei.com; Thomas Monjalon ; >> ferruh.yi...@intel.com

Re: [dpdk-dev] [PATCH v2] doc: add new field to rxq info struct

2020-08-06 Thread Chengchang Tang
On 2020/8/6 23:25, Ferruh Yigit wrote: > On 8/6/2020 5:00 AM, Chengchang Tang wrote: >> Struct rte_eth_rxq_info will be modified to include a new field, indicating >> the size of each buffer that could be used for hw to receive packets. Add >> this field to rte_eth_rxq_in

[dpdk-dev] [PATCH v2] doc: add new field to rxq info struct

2020-08-05 Thread Chengchang Tang
/dev/2020-July/176135.html Signed-off-by: Chengchang Tang Acked-by: Andrew Rybchenko --- v2: - Remove field name. - Fix some spelling mistakes. --- doc/guides/rel_notes/deprecation.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc

[dpdk-dev] [PATCH v2] doc: add new field to rxq info struct

2020-08-05 Thread Chengchang Tang
/dev/2020-July/176135.html Signed-off-by: Chengchang Tang Acked-by: Andrew Rybchenko --- doc/guides/rel_notes/deprecation.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index ea4cfa7..f08b5f9 100644

[dpdk-dev] [PATCH] doc: add new field to rxq info struct

2020-08-05 Thread Chengchang Tang
/dev/2020-July/176135.html Signed-off-by: Chengchang Tang --- doc/guides/rel_notes/deprecation.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index ea4cfa7..f931091 100644 --- a/doc/guides/rel_notes

Re: [dpdk-dev] [RFC v2 0/3] add rx buffer size for rte_eth_rxq_info

2020-07-28 Thread Chengchang Tang
On 2020/7/28 17:30, Ferruh Yigit wrote: > On 7/28/2020 7:29 AM, Chengchang Tang wrote: >> Friendly ping > > Hi Tang, > > Sorry for not making it clear, since it is a library change, the change is > already late for this release (20.08), and it will be considered for next

Re: [dpdk-dev] [RFC v2 0/3] add rx buffer size for rte_eth_rxq_info

2020-07-27 Thread Chengchang Tang
Friendly ping On 2020/7/22 14:38, Chengchang Tang wrote: > In common practice, PMD configure the rx buffer size which indicate the > buffer length could be used for hw in receiving packts according to the > data room size of the object in mempool. But in fact the final value is > re

[dpdk-dev] [RFC v2 3/3] app/testpmd: Add RX buffer size dispaly in queue info querry

2020-07-21 Thread Chengchang Tang
Add RX buffer size to queue info querry cmd so that the user can get the buffer length used by hw queue for receiving packets. Signed-off-by: Chengchang Tang --- app/test-pmd/config.c | 1 + 1 file changed, 1 insertion(+) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 30bee33

[dpdk-dev] [RFC v2 0/3] add rx buffer size for rte_eth_rxq_info

2020-07-21 Thread Chengchang Tang
indicate the buffer size used in recieving pkts for hw. And this patchset also add hns3 PMD implementation and update the testpmd to clarify intention. v2: Add hns3 implementation and update testpmd. Chengchang Tang (2): ethdev: add a field for rte_eth_rxq_info app/testpmd: Add RX buffer size

[dpdk-dev] [RFC v2 2/3] net/hns3: add support for query of rx/tx queue info

2020-07-21 Thread Chengchang Tang
From: Huisong Li This patch adds support for query of rx/tx queue info for hns3. And the new field rx_buf_size in rte_eth_rxq_info is also filled. Signed-off-by: Huisong Li Signed-off-by: Chengchang Tang Reviewed-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_ethdev.c| 2 ++ drivers/net

[dpdk-dev] [RFC v2 1/3] ethdev: add a field for rte_eth_rxq_info

2020-07-21 Thread Chengchang Tang
Add a field named rx_buf_size in rte_eth_rxq_info to indicate the buffer size used in recieving pkts for hw. Signed-off-by: Chengchang Tang Acked-by: Andrew Rybchenko --- v1->v2: modify the name and add more comments. --- lib/librte_ethdev/rte_ethdev.h | 2 ++ 1 file changed, 2 inserti

Re: [dpdk-dev] [RFC] ethdev: add a field for rte_eth_rxq_info

2020-06-23 Thread Chengchang Tang
On 2020/6/23 17:30, Andrew Rybchenko wrote: > On 6/23/20 9:48 AM, Chengchang Tang wrote: >> In common practice, PMD configure the rx_buf_size according to the data >> room size of the object in mempool. But in fact the final value is related >> to the specifications of hw

[dpdk-dev] [RFC] ethdev: add a field for rte_eth_rxq_info

2020-06-22 Thread Chengchang Tang
relevant information to upper layer users. Add a field named rx_bufsize in rte_eth_rxq_info to indicate the buffer size used in recieving pkts for hw. Signed-off-by: Chengchang Tang --- lib/librte_ethdev/rte_ethdev.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_ethdev/rte_ethdev.h b

[dpdk-dev] [RFC] ethdev: add a field for rte_eth_rxq_info

2020-06-18 Thread Chengchang Tang
relevant information to upper layer users. Add a field named rx_bufsize in rte_eth_rxq_info to indicate the buffer size used in recieving pkts for hw. Signed-off-by: Chengchang Tang --- lib/librte_ethdev/rte_ethdev.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_ethdev/rte_ethdev.h b