Re: [dpdk-dev] [PATCH] build: force pkg-config for dependency detection

2021-01-21 Thread Daly, Lee
ffin, John > ; Jain, Deepak K ; Daly, > Lee ; Ashish Gupta ; > Sunila Sahu ; Ruifeng Wang > ; Somalapuram Amaranath > ; Michael Shamis ; > Doherty, Declan ; Loftus, Ciara > ; Zhang, Qi Z ; Rasesh Mody > ; Shahed Shaikh ; Zyta > Szpak ; Martin Spinler ; Hunt, David > ; A

Re: [dpdk-dev] [PATCH] compress/isal: check allocation in qp setup

2020-11-19 Thread Daly, Lee
> From: wangyunjian > Sent: Monday, November 2, 2020 11:36 AM > To: dev@dpdk.org > Cc: Daly, Lee ; jerry.lili...@huawei.com; > xudin...@huawei.com; Yunjian Wang ; > sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] compress/isal: check allocation in qp setup > > From: Yunj

Re: [dpdk-dev] [PATCH v5 13/20] doc: remove references to make from compressdevs guides

2020-10-02 Thread Daly, Lee
> -Original Message- > From: Power, Ciara > Sent: Monday, September 21, 2020 2:59 PM > To: dev@dpdk.org > Cc: Power, Ciara ; Daly, Lee ; > Mcnamara, John ; Kovacevic, Marko > ; Ashish Gupta ; > Sunila Sahu > Subject: [PATCH v5 13/20] doc: remove reference

Re: [dpdk-dev] [PATCH 3/3] examples/power_guest: send request for specified core capabilities

2019-09-30 Thread Daly, Lee
> -Original Message- > From: Daly, Lee > Sent: Monday, September 30, 2019 11:55 AM > To: 'Hajkowski' ; Hunt, David > > Cc: dev@dpdk.org; Hajkowski, MarcinX > Subject: RE: [dpdk-dev] [PATCH 3/3] examples/power_guest: send request > for specified cor

Re: [dpdk-dev] [PATCH 2/3] examples/power_manager: send cpu capabilities on vm request

2019-09-30 Thread Daly, Lee
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Hajkowski > Sent: Thursday, May 30, 2019 5:15 PM > To: Hunt, David > Cc: dev@dpdk.org; Hajkowski, MarcinX > Subject: [dpdk-dev] [PATCH 2/3] examples/power_manager: send cpu > capabilities on vm request > > Fro

Re: [dpdk-dev] [PATCH 1/3] power: add new packet type for capabilities

2019-09-30 Thread Daly, Lee
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Hajkowski > Sent: Thursday, May 30, 2019 5:15 PM > To: Hunt, David > Cc: dev@dpdk.org; Hajkowski, MarcinX > Subject: [dpdk-dev] [PATCH 1/3] power: add new packet type for capabilities > > From: Marcin Hajkowsk

Re: [dpdk-dev] [PATCH 3/3] examples/power_guest: send request for specified core capabilities

2019-09-30 Thread Daly, Lee
Hi dave, See comments below. > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Hajkowski > Sent: Thursday, May 30, 2019 5:15 PM > To: Hunt, David > Cc: dev@dpdk.org; Hajkowski, MarcinX > Subject: [dpdk-dev] [PATCH 3/3] examples/power_guest: send request for > s

Re: [dpdk-dev] [PATCH 4/4] power: add cmd to query CPU freq.

2019-09-27 Thread Daly, Lee
> -Original Message- > From: Hajkowski, MarcinX > Sent: Wednesday, April 3, 2019 6:16 PM > To: Hunt, David > Cc: dev@dpdk.org; Hajkowski, MarcinX > Subject: [PATCH 4/4] power: add cmd to query CPU freq. > > From: Marcin Hajkowski > > Add command and related logic to query CPU freque

Re: [dpdk-dev] [PATCH v5 2/4] power: extend guest channel API for reading

2019-09-26 Thread Daly, Lee
> On 05/04/2019 14:24, Hajkowski wrote: > > From: Marcin Hajkowski > > > > Added new experimental API rte_power_guest_channel_receive_msg > > which gives possibility to receive messages send to guest. > > > > Signed-off-by: Marcin Hajkowski > > --- > > lib/librte_power/channel_commands.h|

Re: [dpdk-dev] [PATCH v5 3/4] power: process incoming confirmation cmds

2019-09-26 Thread Daly, Lee
> On 05/04/2019 14:24, Hajkowski wrote: > > From: Marcin Hajkowski > > > > Extend vm_power_guest to check incoming confirmations of messages > > previously sent to host. > > > > Signed-off-by: Marcin Hajkowski > > --- > > examples/vm_power_manager/guest_cli/Makefile | 1 + > > .../guest_cli/

Re: [dpdk-dev] [PATCH v5 4/4] power: send confirmation cmd to vm guest

2019-09-26 Thread Daly, Lee
> On 05/04/2019 14:24, Hajkowski wrote: > > From: Marcin Hajkowski > > > > Use new guest channel API to send confirmation message for received > > power command. > > > > Signed-off-by: Marcin Hajkowski > > --- > > examples/vm_power_manager/channel_monitor.c | 68 > +++-- > > 1

Re: [dpdk-dev] [PATCH] compress/isal: create shorter qp name

2019-08-06 Thread Daly, Lee
Hi Adam, Take care to add the maintainer of the code you are changing to your email, a list can be found in the MAINTAINERS file. This will hopefully ensure a response to the change. Thanks. > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Adam Dybkowski > Sen

Re: [dpdk-dev] [PATCH] compress/isal: fix use after free

2019-05-21 Thread Daly, Lee
Hi Stephen, Thanks for the patch. > -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Tuesday, May 21, 2019 3:47 PM > To: Daly, Lee > Cc: dev@dpdk.org; Stephen Hemminger > Subject: [PATCH] compress/isal: fix use after fre

Re: [dpdk-dev] [PATCH] compress/isal: fix getting information about CPU

2019-03-29 Thread Daly, Lee
Hi Tomasz, After some testing I can now see the approach in your patch in the best method for getting the CPU info. Rgds, Lee. > -Original Message- > From: Daly, Lee > Sent: Wednesday, March 27, 2019 3:01 PM > To: Akhil Goyal ; Cel, TomaszX > ; dev@dpdk.org > C

Re: [dpdk-dev] [PATCH v3 1/1] compress/isal: fix compression stream initialization

2019-03-28 Thread Daly, Lee
> -Original Message- > From: Trahe, Fiona > Sent: Thursday, March 28, 2019 12:59 PM > To: Cel, TomaszX ; dev@dpdk.org > Cc: sta...@dpdk.org; Daly, Lee ; Tucker, Greg B > ; Jozwiak, TomaszX > Subject: RE: [PATCH v3 1/1] compress/isal: fix compression st

Re: [dpdk-dev] [PATCH] compress/isal: fix getting information about CPU

2019-03-27 Thread Daly, Lee
Hi Tomasz, This patch makes sense to check does the CPU have the capability of certain instructions before Adding it to the dev_info flags. I think one more addition should be made in isal_compress_pmd.c When checking what compression level should be used , decided by the AVX instructi

Re: [dpdk-dev] [PATCH] compress/isal: fix compression stream initialization

2019-03-27 Thread Daly, Lee
Hi Tomasz, > -Original Message- > From: Cel, TomaszX > Sent: Tuesday, March 26, 2019 9:42 AM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Trahe, Fiona ; Daly, Lee > ; Tucker, Greg B ; Jozwiak, > TomaszX > Subject: [PATCH] compress/isal: fix compression stream initia

Re: [dpdk-dev] [PATCH v3] test/compress: add mbuf offset unit test

2019-02-25 Thread Daly, Lee
Not in its current state. -Fiona: Does the current team plan on sending another version of membuf_offset UT for 19.05? > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Monday, February 25, 2019 9:32 AM > To: Daly, Lee > Cc: dev@dpd

Re: [dpdk-dev] [PATCH v3] test/compress: add mbuf offset unit test

2019-02-25 Thread Daly, Lee
Hi Thomas, This patch was deferred to a later release, Patchwork did not reflect this so I have now changed it. Rgds, Lee. > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Sunday, February 24, 2019 10:59 PM > To: Daly, Lee > C

Re: [dpdk-dev] [PATCH] compress/isal: add ISA-L lib version display

2019-02-11 Thread Daly, Lee
Hi Tomasz, Looks good to me. > -Original Message- > From: Cel, TomaszX > Sent: Monday, February 11, 2019 9:19 AM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Trahe, Fiona ; Daly, Lee > ; De Lara Guarch, Pablo > ; Jozwiak, TomaszX > ; Cel, TomaszX > Subject:

Re: [dpdk-dev] [PATCH v3 3/3] doc: update ISA-L guide to reflect checksum support

2019-01-07 Thread Daly, Lee
Hi Vipin, thanks for your suggestion. I will send another version with the change. /Lee. > -Original Message- > From: Varghese, Vipin > Sent: Friday, December 28, 2018 5:05 AM > To: Daly, Lee ; akhil.go...@nxp.com > Cc: dev@dpdk.org; Daly, Lee > Subject: RE: [dpdk-

Re: [dpdk-dev] [PATCH v4 1/3] compress/isal: enable checksum support in driver

2018-12-17 Thread Daly, Lee
Hi Vipin, thanks for the question. > -Original Message- > From: Varghese, Vipin > Sent: Monday, December 17, 2018 8:20 AM > To: Daly, Lee ; akhil.go...@nxp.com > Cc: dev@dpdk.org; Daly, Lee > Subject: RE: [dpdk-dev] [PATCH v4 1/3] compress/isal: enable checksum &

Re: [dpdk-dev] [PATCH v1 2/2] test/compress: add varied buffer input/outputs

2018-12-14 Thread Daly, Lee
> -Original Message- > From: Kovacevic, Marko > Sent: Friday, December 14, 2018 3:33 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Daly, Lee ; Jozwiak, TomaszX > ; O'Hare, Cathal ; > Trahe, Fiona ; Kovacevic, Marko > > Subject: [PATCH v1 2/2] test/c

Re: [dpdk-dev] [PATCH v1 1/2] test/compress: add out of space test

2018-12-14 Thread Daly, Lee
> -Original Message- > From: Kovacevic, Marko > Sent: Friday, December 14, 2018 3:33 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Daly, Lee ; Jozwiak, TomaszX > ; O'Hare, Cathal ; > Trahe, Fiona ; Kovacevic, Marko > > Subject: [PATCH v1 1/2] test

Re: [dpdk-dev] [PATCH v5 0/5] add initial version of compress-perf

2018-12-05 Thread Daly, Lee
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tomasz Jozwiak > Sent: Wednesday, December 5, 2018 8:47 AM > To: dev@dpdk.org; Trahe, Fiona ; Jozwiak, TomaszX > ; shally.ve...@cavium.com; > akhil.go...@nxp.com > Subject: [dpdk-dev] [PATCH v5 0/5] add initial v

Re: [dpdk-dev] [PATCH 2/2] test/compress: use bulk free operations api

2018-11-22 Thread Daly, Lee
> -Original Message- > From: Trahe, Fiona > Sent: Monday, November 19, 2018 10:10 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Jozwiak, TomaszX ; > shally.ve...@caviumnetworks.com; ashish.gu...@caviumnetworks.com; > Daly, Lee ; Trahe, Fiona > Subject: [PATCH

Re: [dpdk-dev] [PATCH] test/compress: improve trace

2018-10-31 Thread Daly, Lee
> -Original Message- > From: Trahe, Fiona > Sent: Wednesday, October 31, 2018 12:42 AM > To: dev@dpdk.org > Cc: tho...@monjalon.net; akhil.go...@nxp.com; Jozwiak, TomaszX > ; Daly, Lee ; Trahe, Fiona > > Subject: [PATCH] test/compress: improve trace > &

Re: [dpdk-dev] [PATCH 2/3] app/compress-perf: add performance measurement

2018-10-15 Thread Daly, Lee
Thanks for your input Shally see comments below. I will be reviewing these changes while Tomasz is out this week. > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Verma, Shally > Sent: Friday, October 12, 2018 11:16 AM > To: Jozwiak, TomaszX ; dev@dpdk.org; Tra

Re: [dpdk-dev] [PATCH] test/compress: add offset tests

2018-07-31 Thread Daly, Lee
This test will not be up streamed in 18.08. V2, containing a fix for this error, will be sent for 18.11. > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Tuesday, July 31, 2018 4:02 PM > To: Daly, Lee > Cc: dev@dpdk.org; De Lara Guarch,

[dpdk-dev] [PATCH v4] compress/isal: add chained mbuf support

2018-07-24 Thread Daly, Lee
This patch adds chained mbuf support for input or output buffers during compression/decompression operations. V2 - split chained mbuf functionality into separate functions. - code optimizations. V3 - bug fixes & optimizations. v4 - bug fixes & optimizations. Signed-off-by: Lee Daly --- doc

[dpdk-dev] [PATCH v3] compress/isal: add chained mbuf support

2018-07-23 Thread Daly, Lee
This patch adds chained mbuf support for input or output buffers during compression/decompression operations. Signed-off-by: Lee Daly --- doc/guides/compressdevs/features/isal.ini | 17 +- doc/guides/compressdevs/isal.rst | 2 - drivers/compress/isal/isal_compress_pmd.c |

Re: [dpdk-dev] [PATCH] test/compress: add scatter-gather tests

2018-07-16 Thread Daly, Lee
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Tuesday, July 3, 2018 1:52 AM > To: Trahe, Fiona ; > ashish.gu...@caviumnetworks.com; Daly, Lee > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: [PATCH] test/compress: add scatter-gather tests > >

Re: [dpdk-dev] [PATCH 1/3] compress/isal: fix logtype name

2018-07-11 Thread Daly, Lee
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Wednesday, July 11, 2018 7:39 AM > To: Daly, Lee > Cc: dev@dpdk.org; De Lara Guarch, Pablo ; > sta...@dpdk.org > Subject: [PATCH 1/3] compress/isal: fix logtype name > > There is a naming conv

Re: [dpdk-dev] [PATCH 2/3] compress/isal: set null pointer after freeing

2018-07-11 Thread Daly, Lee
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Wednesday, July 11, 2018 7:39 AM > To: Daly, Lee > Cc: dev@dpdk.org; De Lara Guarch, Pablo ; > sta...@dpdk.org > Subject: [PATCH 2/3] compress/isal: set null pointer after freeing > > Fixes: b0e23c

Re: [dpdk-dev] [PATCH 3/3] compress/isal: fix memory leak

2018-07-11 Thread Daly, Lee
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Wednesday, July 11, 2018 7:39 AM > To: Daly, Lee > Cc: dev@dpdk.org; De Lara Guarch, Pablo ; > sta...@dpdk.org > Subject: [PATCH 3/3] compress/isal: fix memory leak > > Processed operations ring is

Re: [dpdk-dev] [PATCH v3 1/4] doc: cleanup ISA-L PMD feature matrix

2018-07-05 Thread Daly, Lee
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Wednesday, July 4, 2018 3:11 PM > To: shally.ve...@caviumnetworks.com; > ashish.gu...@caviumnetworks.com; Trahe, Fiona ; > Daly, Lee > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: [PATCH v3 1/4

Re: [dpdk-dev] [PATCH 2/2] compressdev: add huffman encoding flags

2018-06-28 Thread Daly, Lee
Hi Pablo, > -Original Message- > From: De Lara Guarch, Pablo > Sent: Wednesday, June 27, 2018 6:51 AM > To: Trahe, Fiona ; > ashish.gu...@caviumnetworks.com; Daly, Lee > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: [PATCH 2/2] compressdev: add huffman enco

Re: [dpdk-dev] [PATCH v1 2/6] compress/zlib: add device setup PMD ops

2018-06-25 Thread Daly, Lee
> > > >> -Original Message- > >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shally Verma > >> Sent: Tuesday, May 15, 2018 11:32 AM > >> To: De Lara Guarch, Pablo > >> Cc: Trahe, Fiona ; dev@dpdk.org; > >> pathr...@caviumnetworks.com; Sunila Sahu > >> ; Ashish Gupta > >> > >> Sub

Re: [dpdk-dev] [PATCH v1 2/6] compress/zlib: add device setup PMD ops

2018-06-15 Thread Daly, Lee
Hi Shally, Comments inline. > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shally Verma > Sent: Tuesday, May 15, 2018 11:32 AM > To: De Lara Guarch, Pablo > Cc: Trahe, Fiona ; dev@dpdk.org; > pathr...@caviumnetworks.com; Sunila Sahu > ; Ashish Gupta > > Subj

Re: [dpdk-dev] [PATCH v1 6/6] doc: add ZLIB PMD documentation

2018-06-15 Thread Daly, Lee
Hi, Comments inline. > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shally Verma > Sent: Tuesday, May 15, 2018 11:32 AM > To: De Lara Guarch, Pablo > Cc: Trahe, Fiona ; dev@dpdk.org; > pathr...@caviumnetworks.com; Sunila Sahu > ; Ashish Gupta > > Subject: [dp

Re: [dpdk-dev] [PATCH v1 4/6] compress/zlib: add enq deq apis

2018-06-15 Thread Daly, Lee
Comments inline. > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shally Verma > Sent: Tuesday, May 15, 2018 11:32 AM > To: De Lara Guarch, Pablo > Cc: Trahe, Fiona ; dev@dpdk.org; > pathr...@caviumnetworks.com; Sunila Sahu > ; Ashish Gupta > > Subject: [dpdk-d

Re: [dpdk-dev] [PATCH v1 3/6] compress/zlib: add xform and stream create support

2018-06-15 Thread Daly, Lee
Comment Inline. > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shally Verma > Sent: Tuesday, May 15, 2018 11:32 AM > To: De Lara Guarch, Pablo > Cc: Trahe, Fiona ; dev@dpdk.org; > pathr...@caviumnetworks.com; Sunila Sahu > ; Ashish Gupta > > Subject: [dpdk-de

Re: [dpdk-dev] [PATCH v1 1/6] compress/zlib: add ZLIB PMD support

2018-06-15 Thread Daly, Lee
Hi, thanks for the work, reviewed the PMD see comments below. > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shally Verma > Sent: Tuesday, May 15, 2018 11:32 AM > To: De Lara Guarch, Pablo > Cc: Trahe, Fiona ; dev@dpdk.org; > pathr...@caviumnetworks.com; Suni

Re: [dpdk-dev] [PATCH v3 4/5] test/compress: add multi xform test

2018-05-02 Thread Daly, Lee
Hi Pablo, Feedback for a small change below. > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pablo de Lara > Sent: Friday, April 27, 2018 3:15 PM > To: dev@dpdk.org > Cc: Trahe, Fiona ; shally.ve...@cavium.com; > ahmed.mans...@nxp.com; ashish.gu...@cavium.com; D

Re: [dpdk-dev] [PATCH v3 1/5] test/compress: add initial unit tests

2018-05-02 Thread Daly, Lee
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pablo de Lara > Sent: Friday, April 27, 2018 3:15 PM > To: dev@dpdk.org > Cc: Trahe, Fiona ; shally.ve...@cavium.com; > ahmed.mans...@nxp.com; ashish.gu...@cavium.com; De Lara Guarch, > Pablo ; Ashish Gupta > ; Sh

Re: [dpdk-dev] [PATCH v3 0/5] Initial compressdev unit tests

2018-05-01 Thread Daly, Lee
<...> > Added initial tests for Compressdev library. > The tests are performed compressing a test buffer (or multiple test buffers) > with compressdev or Zlib, and decompressing it/them with the other library > (if compression is done with compressdev, decompression is done with Zlib, > and vicev

Re: [dpdk-dev] [PATCH v3 05/11] compress/isal: add queue pair related ops

2018-04-26 Thread Daly, Lee
<...> > > -Original Message- > > From: Daly, Lee > > Sent: Tuesday, April 17, 2018 2:35 PM > > To: dev@dpdk.org > > Cc: De Lara Guarch, Pablo ; Tucker, > > Greg B ; Jain, Deepak K > > ; Trahe, Fiona ; Daly, > > Lee > > Subject

Re: [dpdk-dev] [PATCH v3 10/11] compress/isal: add generic compression driver docs

2018-04-25 Thread Daly, Lee
Thanks for the feedback on the patch set Pablo, V4 in progress. > -Original Message- > From: De Lara Guarch, Pablo > Sent: Tuesday, April 24, 2018 12:07 PM > To: Daly, Lee ; dev@dpdk.org > Cc: Tucker, Greg B ; Jain, Deepak K > ; Trahe, Fiona > Subject: RE: [PATCH v3

Re: [dpdk-dev] [PATCH v3 11/11] compress/isal: add ISA-L compression PMD docs

2018-04-23 Thread Daly, Lee
//snip > Subject: RE: [dpdk-dev] [PATCH v3 11/11] compress/isal: add ISA-L compression > PMD docs > > > > Signed-off-by: Lee Daly > > --- > > MAINTAINERS | 5 ++ > > devtools/test-build.sh| 4 ++ > > doc/guides/compressdevs/features/isal.ini |

Re: [dpdk-dev] [PATCH] examples: update copyrights and license

2018-02-08 Thread Daly, Lee
> -Original Message- > From: Hemant Agrawal [mailto:hemant.agra...@nxp.com] > Sent: Thursday, February 8, 2018 8:49 AM > To: Daly, Lee ; Mcnamara, John > ; De Lara Guarch, Pablo > ; Richardson, Bruce > ; Van Haaren, Harry > ; hala...@gmail.com > Cc: dev@dpd

Re: [dpdk-dev] [PATCH 2/2] lib: optimize _xstats_by_ids APIs

2017-12-11 Thread Daly, Lee
> Subject: [dpdk-dev] [PATCH 2/2] lib: optimize _xstats_by_ids APIs > > Introduced a check to detect if the stats IDs being requested are all basic > stats IDs. In that case, ensured that only the basic stats would be retrieved. > Previously, both basic stats and xstats were being retrieved even i

Re: [dpdk-dev] [PATCH 1/2] lib: refactor basic stats code

2017-12-11 Thread Daly, Lee
> Subject: [dpdk-dev] [PATCH 1/2] lib: refactor basic stats code > > Moved the code to get the basic stats names and values into static functions. > > Signed-off-by: Elza Mathew Reviewed-by: Lee Daly