shift to. But it was left in a state where it
almost worked under VFIO, in a sense that the NVME card entered a
fault state and I had not invested enough time to figure out why.
If it's due to this bug, then I would be able to finally close this
one. But that's a bit hopeful, though. Happy to find actual users of
the changes.
--
Dan Aloni
On Mon, Aug 17, 2015 at 10:55:35AM +0200, Olivier MATZ wrote:
> On 08/16/2015 09:08 PM, Dan Aloni wrote:
[..]
> > /* Check that pg_num and pg_shift parameters are valid. */
> > - if (pg_num < RTE_DIM(mp->elt_pa) || pg_shift > MEMPOOL_PG_SHIFT_MAX) {
> > + i
The rest of the code expects pg_num <= RTE_DIM(mp->elt_pa).
Signed-off-by: Dan Aloni
---
lib/librte_mempool/rte_mempool.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c
index 8e185c545479..edcfa8
heir registers in the same BAR
> > but on a different page. For example, Intel's NVME adapter, though
> > not a network adapter, provides only one MMIO BAR that contains
> > the MSI-X table.
> >
> > Signed-off-by: Dan Aloni
> > Signed-off-by: Anatoly Burakov
>
only one MMIO BAR that contains
the MSI-X table.
Signed-off-by: Dan Aloni
Signed-off-by: Anatoly Burakov
---
lib/librte_eal/linuxapp/eal/eal_pci.c | 5 +-
lib/librte_eal/linuxapp/eal/eal_pci_init.h | 2 +-
lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 4 +-
lib/librte_eal/linuxapp/eal
1].offset && memreg[1].size) {
> > + uint8_t *second_addr =
> > + ((uint8_t *)bar_addr +
> > memreg[1].offset);
>
> Nitpicking, but probably better to use void* and RTE_PTR_ADD here.
Nitpicking very justified. New patch coming your way.
--
Dan Aloni
On Thu, Jan 22, 2015 at 10:36:11AM +0200, Dan Aloni wrote:
> While VFIO doesn't allow us to map complete BARs with MSI-X tables,
> it does allow us to map around them in PAGE_SIZE granularity. There
> might be adapters that provide their registers in the same BAR
> but on a di
only one MMIO BAR that contains
the MSI-X table.
Signed-off-by: Dan Aloni
CC: Anatoly Burakov
---
lib/librte_eal/linuxapp/eal/eal_pci.c | 5 +-
lib/librte_eal/linuxapp/eal/eal_pci_init.h | 2 +-
lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 4 +-
lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
8 matches
Mail list logo
