RE: [PATCH v4 1/1] vhost: handle virtqueue locking for memory hotplug

2025-06-19 Thread Danylo Vodopianov
ts about this? Or I should rework my patchset according to this described solution above ? От: Maxime Coquelin Отправлено: 12 июня 2025 г. 14:38 Кому: Danylo Vodopianov ; tho...@monjalon.net ; aman.deep.si...@intel.com ; yuying.zh...@intel.com ; or...@nvidia

RE: [PATCH v4 1/1] vhost: handle virtqueue locking for memory hotplug

2025-06-04 Thread Danylo Vodopianov
но: 3 июня 2025 г. 15:30 Кому: Danylo Vodopianov ; tho...@monjalon.net ; aman.deep.si...@intel.com ; yuying.zh...@intel.com ; or...@nvidia.com ; mcoqu...@redhat.com ; Christian Koue Muf ; ma...@mellanox.com ; david.march...@redhat.com ; Mykola Kostenok ; Serhii Iliushyk Копия: step...@networkp

[PATCH v2 1/1] vhost: handle virtqueue locking for memory hotplug

2025-06-02 Thread Danylo Vodopianov
lug the guest memory. This fix does not impact access lock when vDPA driver is configured for other unnecessary message handlers. Manual memory configuring with "--socket-mem" option allows to avoid hotplug mechanism using. Signed-off-by: Danylo Vodopianov --- lib/vhost/vhost_user.c |

[PATCH v4 1/1] vhost: handle virtqueue locking for memory hotplug

2025-06-02 Thread Danylo Vodopianov
lug the guest memory. This fix does not impact access lock when vDPA driver is configured for other unnecessary message handlers. Manual memory configuring with "--socket-mem" option allows to avoid hotplug mechanism using. Signed-off-by: Danylo Vodopianov --- lib/vhost/vhost_user.c |

[PATCH v4 0/1] Memory hotplug fix

2025-06-02 Thread Danylo Vodopianov
request VHOST_USER_SET_MEM_TABLE. Something like this, in general https://git.dpdk.org/dpdk-stable/tree/lib/vhost/vhost_user.c#n3179 if (!(dev->flags & VIRTIO_DEV_VDPA_CONFIGURED) || request == VHOST_USER_SET_MEM_TABLE) { ... Danylo Vodopianov (1): vhost: handle virtqueue locking for

[PATCH v3 0/1] Memory hotplug fix

2025-06-02 Thread Danylo Vodopianov
request VHOST_USER_SET_MEM_TABLE. Something like this, in general https://git.dpdk.org/dpdk-stable/tree/lib/vhost/vhost_user.c#n3179 if (!(dev->flags & VIRTIO_DEV_VDPA_CONFIGURED) || request == VHOST_USER_SET_MEM_TABLE) { ... Danylo Vodopianov (1): vhost: handle virtqueue locking for

[PATCH v3 1/1] vhost: handle virtqueue locking for memory hotplug

2025-06-02 Thread Danylo Vodopianov
lug the guest memory. This fix does not impact access lock when vDPA driver is configured for other unnecessary message handlers. Manual memory configuring with "--socket-mem" option allows to avoid hotplug mechanism using. Signed-off-by: Danylo Vodopianov --- lib/vhost/vhost_user.c |

[PATCH v1 1/1] vhost: handle virtqueue locking for memory hotplug

2025-05-29 Thread Danylo Vodopianov
lug the guest memory. This fix does not impact access lock when vDPA driver is configured for other unnecessary message handlers. Manual memory configuring with "--socket-mem" option allows to avoid hotplug mechanism using. Signed-off-by: Danylo Vodopianov --- lib/vhost/vhost_user.c |

[PATCH v1 0/1] Memory hotplug fix

2025-05-29 Thread Danylo Vodopianov
request VHOST_USER_SET_MEM_TABLE. Something like this, in general https://git.dpdk.org/dpdk-stable/tree/lib/vhost/vhost_user.c#n3179 if (!(dev->flags & VIRTIO_DEV_VDPA_CONFIGURED) || request == VHOST_USER_SET_MEM_TABLE) { ... Danylo Vodopianov (1): vhost: handle virtqueue locking for

[PATCH v1 1/1] vhost: handle virtqueue locking for memory hotplug

2025-05-29 Thread Danylo Vodopianov
lug the guest memory. This fix does not impact access lock when vDPA driver is configured for other unnecessary message handlers. Manual memory configuring with "--socket-mem" option allows to avoid hotplug mechanism using. Signed-off-by: Danylo Vodopianov --- lib/vhost/vhost_user.c |

[PATCH v1 0/1] Memory hotplug fix

2025-05-29 Thread Danylo Vodopianov
request VHOST_USER_SET_MEM_TABLE. Something like this, in general https://git.dpdk.org/dpdk-stable/tree/lib/vhost/vhost_user.c#n3179 if (!(dev->flags & VIRTIO_DEV_VDPA_CONFIGURED) || request == VHOST_USER_SET_MEM_TABLE) { ... Danylo Vodopianov (1): vhost: handle virtqueue locking for

[PATCH v2 0/2] Testpmd flow update/destroy fixes

2024-11-18 Thread Danylo Vodopianov
. Copy user_id to the flow list for flow_update command. 3. Enclose the case's body for flow_destroy command in braces. Danylo Vodopianov (2): app/testpmd: fix flow update app/testpmd: fix aged flow destroy app/test-pmd/config.c | 27 --- 1 file change

[PATCH v3 2/2] app/testpmd: fix aged flow destroy

2024-11-18 Thread Danylo Vodopianov
t and it always is 0, thus 1st flow is removed. A local copy of flow->id must be used to call of port_flow_destroy() to avoid access and processing of flow->id after the flow is removed. Fixes: de956d5ecf08 ("app/testpmd: support age shared action context") Cc: sta...@dpdk.or

[PATCH v3 0/2] Testpmd flow update/destroy fixes

2024-11-18 Thread Danylo Vodopianov
. 2. Copy user_id to the flow list for flow_update command. 3. Enclose the case's body for flow_destroy command in braces. v3: 1. Update commit message 2. Aligned variable declaration code style Danylo Vodopianov (2): app/testpmd: fix flow update app/testpmd: fix

[PATCH v2 0/2] Testpmd flow update/destroy fixes

2024-11-18 Thread Danylo Vodopianov
. Copy user_id to the flow list for flow_update command. 3. Enclose the case's body for flow_destroy command in braces. Danylo Vodopianov (2): app/testpmd: fix flow update app/testpmd: fix aged flow destroy app/test-pmd/config.c | 27 --- 1 file change

[PATCH v3 1/2] app/testpmd: fix flow update

2024-11-18 Thread Danylo Vodopianov
2. Set age context if age action is present. 3. Replace flow in the flow list. Fixes: 2d9c7e56e52c ("app/testpmd: support updating flow rule actions") Cc: sta...@dpdk.org Signed-off-by: Danylo Vodopianov --- app/test-pmd/config.c | 21 - 1 file changed, 20 inser

[PATCH v2 0/2] Testpmd flow update/destroy fixes

2024-11-18 Thread Danylo Vodopianov
. Copy user_id to the flow list for flow_update command. 3. Enclose the case's body for flow_destroy command in braces. Danylo Vodopianov (2): app/testpmd: fix flow update app/testpmd: fix aged flow destroy app/test-pmd/config.c | 27 --- 1 file change

[PATCH v2 2/2] app/testpmd: fix aged flow destroy

2024-11-18 Thread Danylo Vodopianov
() function never assumed that rule array can be freed when it's executing, and port_flow_aged() just violated that assumption. Fixes: de956d5ecf08 ("app/testpmd: support age shared action context") Cc: sta...@dpdk.org Signed-off-by: Danylo Vodopianov --- app/test-pmd/config.c | 6

[PATCH v2 1/2] app/testpmd: fix flow update

2024-11-18 Thread Danylo Vodopianov
2. Set age context if age action is present. 3. Replace flow in the flow list. Fixes: 2d9c7e56e52c ("app/testpmd: support updating flow rule actions") Cc: sta...@dpdk.org Signed-off-by: Danylo Vodopianov --- app/test-pmd/config.c | 21 - 1 file changed, 20 inser

[PATCH v2 1/2] app/testpmd: fix flow update

2024-11-18 Thread Danylo Vodopianov
2. Set age context if age action is present. 3. Replace flow in the flow list. Fixes: 2d9c7e56e52c ("app/testpmd: support updating flow rule actions") Cc: sta...@dpdk.org Signed-off-by: Danylo Vodopianov --- app/test-pmd/config.c | 21 - 1 file changed, 20 inser

[PATCH v2 2/2] app/testpmd: fix aged flow destroy

2024-11-18 Thread Danylo Vodopianov
() function never assumed that rule array can be freed when it's executing, and port_flow_aged() just violated that assumption. Fixes: de956d5ecf08 ("app/testpmd: support age shared action context") Cc: sta...@dpdk.org Signed-off-by: Danylo Vodopianov --- app/test-pmd/config.c | 6

[PATCH v2 2/2] app/testpmd: fix aged flow destroy

2024-11-18 Thread Danylo Vodopianov
() function never assumed that rule array can be freed when it's executing, and port_flow_aged() just violated that assumption. Fixes: de956d5ecf08 ("app/testpmd: support age shared action context") Cc: sta...@dpdk.org Signed-off-by: Danylo Vodopianov --- app/test-pmd/config.c | 6

[PATCH v2 1/2] app/testpmd: fix flow update

2024-11-18 Thread Danylo Vodopianov
2. Set age context if age action is present. 3. Replace flow in the flow list. Fixes: 2d9c7e56e52c ("app/testpmd: support updating flow rule actions") Cc: sta...@dpdk.org Signed-off-by: Danylo Vodopianov --- app/test-pmd/config.c | 21 - 1 file changed, 20 inser

[PATCH v1 0/2] Testpmd flow update/destroy fixes

2024-10-31 Thread Danylo Vodopianov
These patches provide next fixes: 1. The testpmd command “flow update…“ provides a nullptr as the context variable. 2. Avoid removal of additional flows after requested number of flows has been already removed. Danylo Vodopianov (2): app/testpmd: fix flow

[PATCH v1 1/2] app/testpmd: fix flow update

2024-10-31 Thread Danylo Vodopianov
flow list. Fixes: 2d9c7e56e52c ("app/testpmd: support updating flow rule actions") Signed-off-by: Danylo Vodopianov --- app/test-pmd/config.c | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 88

[PATCH v1 2/2] app/testpmd: fix flow destroy

2024-10-31 Thread Danylo Vodopianov
pointer with “given ID” and thus remove additional flow. Fixes: de956d5ecf08 ("app/testpmd: support age shared action context") Signed-off-by: Danylo Vodopianov --- app/test-pmd/config.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/config.c b/ap