Re: [dpdk-dev] [PATCH v3 05/11] baseband/acc100: add LDPC processing functions

2020-09-03 Thread Dave Burley
Acked-by: Dave Burley From: Chautru, Nicolas Sent: 20 August 2020 22:05 To: Dave Burley ; dev@dpdk.org Cc: Richardson, Bruce Subject: RE: [dpdk-dev] [PATCH v3 05/11] baseband/acc100: add LDPC processing functions   > From: Dave Burley > > Hi Nic > > Thank you - it wou

Re: [dpdk-dev] [PATCH v3 1/7] app/bbdev: add explicit ut for latency vs validation

2020-09-15 Thread Dave Burley
Acked-by: Dave Burley From: dev on behalf of Nicolas Chautru Sent: 19 August 2020 01:05 To: dev@dpdk.org ; akhil.go...@nxp.com Cc: bruce.richard...@intel.com ; Nicolas Chautru Subject: [dpdk-dev] [PATCH v3 1/7] app/bbdev: add explicit ut for latency vs validation   Adding explicit

Re: [dpdk-dev] [PATCH v3 2/7] app/bbdev: add explicit check for counters

2020-09-15 Thread Dave Burley
Acked-by: Dave Burley From: dev on behalf of Nicolas Chautru Sent: 19 August 2020 01:05 To: dev@dpdk.org ; akhil.go...@nxp.com Cc: bruce.richard...@intel.com ; Nicolas Chautru Subject: [dpdk-dev] [PATCH v3 2/7] app/bbdev: add explicit check for counters   Adding explicit check in ut that

Re: [dpdk-dev] [PATCH v3 5/7] app/bbdev: skip bler ut when compression is used

2020-09-15 Thread Dave Burley
Acked-by: Dave Burley From: dev on behalf of Nicolas Chautru Sent: 19 August 2020 01:05 To: dev@dpdk.org ; akhil.go...@nxp.com Cc: bruce.richard...@intel.com ; Nicolas Chautru Subject: [dpdk-dev] [PATCH v3 5/7] app/bbdev: skip bler ut when compression is used   bler test results are

Re: [dpdk-dev] [PATCH v3 7/7] app/bbdev: update offload test to dequeue full ring

2020-09-15 Thread Dave Burley
Acked-by: Dave Burley From: dev on behalf of Nicolas Chautru Sent: 19 August 2020 01:05 To: dev@dpdk.org ; akhil.go...@nxp.com Cc: bruce.richard...@intel.com ; Nicolas Chautru Subject: [dpdk-dev] [PATCH v3 7/7] app/bbdev: update offload test to dequeue full ring   update offload dequeue

Re: [dpdk-dev] [PATCH v1] app/bbdev: fix test vector symlink

2020-09-15 Thread Dave Burley
Acked-by: Dave Burley From: dev on behalf of Nicolas Chautru Sent: 09 September 2020 22:15 To: dev@dpdk.org Cc: sta...@dpdk.org ; tianjiao@intel.com ; Nicolas Chautru Subject: [dpdk-dev] [PATCH v1] app/bbdev: fix test vector symlink   5G DL default symlink was pointing to a 4G vector

Re: [dpdk-dev] [PATCH v3 01/14] bbdev: add capability flag for filler bits inclusion in HARQ

2020-03-13 Thread Dave Burley
Acked-by: Dave Burley On 04/03/2020 18:54, Nicolas Chautru wrote: From: Nic Chautru Adding capability flag for device variants when HARQ buffer may or may not include the filler bits. Minor cosmetic changes in same file. Signed-off-by: Nic Chautru --- lib/librte_bbdev/rte_bbdev.h| 2

Re: [dpdk-dev] [PATCH v3 02/14] bbdev: expose device HARQ buffer size at device level

2020-03-13 Thread Dave Burley
Acked-by: Dave Burley On 04/03/2020 18:54, Nicolas Chautru wrote: From: Nic Chautru This exposes the HARQ buffer size at the device driver level instead of using the capability of a specific operation. This is currently not yet used by a device until future commit. Signed-off-by: Nic

Re: [dpdk-dev] [PATCH v3 05/14] test-bbdev: rename FPGA LTE macros to be more explicit

2020-03-13 Thread Dave Burley
Acked-by: Dave Burley On 04/03/2020 18:54, Nicolas Chautru wrote: From: Nic Chautru Self-contained and cosmetic renaming of macro so that to be more explicit for future extension. Signed-off-by: Nic Chautru --- app/test-bbdev/test_bbdev_perf.c | 51

Re: [dpdk-dev] [PATCH v3 07/14] test-bbdev: support for performance tests

2020-03-13 Thread Dave Burley
Acked-by: Dave Burley On 04/03/2020 18:54, Nicolas Chautru wrote: From: Nic Chautru Includes support for BLER wireless performance test with new arguments for SNR and number of iterations for 5G. Signed-off-by: Nic Chautru --- app/test-bbdev/main.c| 29 ++- app/test-bbdev

Re: [dpdk-dev] [PATCH v3 08/14] test-bbdev: support for LDPC interrupt test

2020-03-13 Thread Dave Burley
Acked-by: Dave Burley On 04/03/2020 18:54, Nicolas Chautru wrote: From: Nic Chautru Adding missing implementation for the interrupt tests for LDPC encoder and decoders. Signed-off-by: Nic Chautru --- app/test-bbdev/test_bbdev_perf.c | 202 ++- 1 file

Re: [dpdk-dev] [PATCH v3 11/14] doc: update of testbbdev documentation

2020-03-13 Thread Dave Burley
Acked-by: Dave Burley On 04/03/2020 18:54, Nicolas Chautru wrote: From: Nic Chautru Update related to the changes introduced by the previous commits. Signed-off-by: Nic Chautru --- doc/guides/tools/testbbdev.rst | 337 +++-- 1 file changed, 291

Re: [dpdk-dev] [PATCH v3 12/14] drivers/baseband: add PMD for FPGA 5GNR FEC

2020-03-13 Thread Dave Burley
Acked-by: Dave Burley On 04/03/2020 18:55, Nicolas Chautru wrote: From: Nic Chautru Supports for FEC 5G PMD Driver on FPGA card PAC N3000 Signed-off-by: Nic Chautru --- config/common_base |5 + doc/guides/bbdevs/fpga_5gnr_fec.rst| 297

Re: [dpdk-dev] [PATCH v3 13/14] test-bbdev: add support for FPGA driver initialization

2020-03-13 Thread Dave Burley
Acked-by: Dave Burley On 04/03/2020 18:55, Nicolas Chautru wrote: From: Nic Chautru Adding capacity to initialize the device driver from the test-bbdev environment for the new device FPGA for 5GNR FEC. Signed-off-by: Nic Chautru --- app/test-bbdev/Makefile | 3 +++ app/test

Re: [dpdk-dev] [PATCH v3 14/14] doc: add feature matrix table for bbdev devices

2020-03-13 Thread Dave Burley
Acked-by: Dave Burley On 04/03/2020 18:55, Nicolas Chautru wrote: From: Nic Chautru Adding missing overview page in documentation with comparison of feature set by PMD implementation. Signed-off-by: Nic Chautru --- .gitignore | 1 + doc/guides/bbdevs

Re: [dpdk-dev] [PATCH v3 04/14] baseband/turbo_sw: support large size code block

2020-03-13 Thread Dave Burley
Acked-by: Dave Burley On 04/03/2020 18:54, Nicolas Chautru wrote: From: Nic Chautru This is to support cases when the input data for decoding a code block is larger than 64kB and would not fit as a contiguous block of data into one mbuf. In that case the length from the opearation supersedes

Re: [dpdk-dev] [PATCH v5 00/10] bbdev new features

2020-03-27 Thread Dave Burley
Acked-by: Dave Burley On 26/03/2020 03:27, Nicolas Chautru wrote: v5: cosmetic change v4: Changes based on review comments from Akhil. Also taking the new PMD out of this serie to be pushed in separate serie. v3: squash the release notes updates into the related commits v2: including release

Re: [dpdk-dev] [PATCH v5 01/10] bbdev: add capability flag for filler bits inclusion in HARQ

2020-03-27 Thread Dave Burley
Acked-by: Dave Burley On 26/03/2020 03:27, Nicolas Chautru wrote: From: Nic Chautru Adding capability flag for device variants when HARQ buffer may or may not include the filler bits. Minor cosmetic changes in same file. Signed-off-by: Nic Chautru --- lib/librte_bbdev/rte_bbdev.h| 2

Re: [dpdk-dev] [PATCH v5 03/10] baseband/turbo_sw: fix the exposed LLR decimals assumption

2020-03-27 Thread Dave Burley
Acked-by: Dave Burley On 26/03/2020 03:27, Nicolas Chautru wrote: From: Nic Chautru The actual LLR representation was incorrectly assumed to be 2 instead of 4. This would impact wireless performance but is not critical to be back ported on LTS branches. Fixes: c769c711757a ("bas

Re: [dpdk-dev] [PATCH v5 02/10] bbdev: expose device HARQ buffer size at device level

2020-03-27 Thread Dave Burley
Acked-by: Dave Burley On 26/03/2020 03:27, Nicolas Chautru wrote: From: Nic Chautru This exposes the HARQ buffer size at the device driver level instead of using the capability of a specific operation. This is currently not yet used by a device until future commit. Signed-off-by: Nic

Re: [dpdk-dev] [PATCH v5 04/10] baseband/turbo_sw: support large size code block

2020-03-27 Thread Dave Burley
Acked-by: Dave Burley On 26/03/2020 03:27, Nicolas Chautru wrote: From: Nic Chautru This is to support cases when the input data for decoding a code block is larger than 64kB and would not fit as a contiguous block of data into one mbuf. In that case the length from the operation supersedes

Re: [dpdk-dev] [PATCH v5 05/10] test-bbdev: rename FPGA LTE macros to be more explicit

2020-03-27 Thread Dave Burley
Acked-by: Dave Burley On 26/03/2020 03:27, Nicolas Chautru wrote: From: Nic Chautru Self-contained and cosmetic renaming of macro so that to be more explicit for future extension. Signed-off-by: Nic Chautru --- app/test-bbdev/test_bbdev_perf.c | 51

Re: [dpdk-dev] [PATCH v5 06/10] test-bbdev: support HARQ validation

2020-03-27 Thread Dave Burley
Acked-by: Dave Burley On 26/03/2020 03:27, Nicolas Chautru wrote: From: Nic Chautru Adding functionality to validate HARQ for different devices implementation. Adding capacity to fetch HARQ data when required as part of this validation. Signed-off-by: Nic Chautru --- app/test-bbdev

Re: [dpdk-dev] [PATCH v5 07/10] test-bbdev: support for performance tests

2020-03-27 Thread Dave Burley
Acked-by: Dave Burley On 26/03/2020 03:27, Nicolas Chautru wrote: From: Nic Chautru Includes support for BLER (Block Error Rate) wireless performance test with new arguments for SNR and number of iterations for 5G. This generates LLRs for a given SNR level then measures the ratio of code

Re: [dpdk-dev] [PATCH v5 08/10] test-bbdev: support for LDPC interrupt test

2020-03-27 Thread Dave Burley
Acked-by: Dave Burley On 26/03/2020 03:27, Nicolas Chautru wrote: From: Nic Chautru Adding missing implementation for the interrupt tests for LDPC encoder and decoders. Signed-off-by: Nic Chautru --- app/test-bbdev/test_bbdev_perf.c | 202 ++- 1 file

Re: [dpdk-dev] [PATCH v5 09/10] test-bbdev: support for offload test for LDPC

2020-03-27 Thread Dave Burley
Acked-by: Dave Burley On 26/03/2020 03:27, Nicolas Chautru wrote: From: Nic Chautru Adding support for the offload latency tests when using the LDPC encoder and decoder operations. Signed-off-by: Nic Chautru --- app/test-bbdev/test_bbdev_perf.c | 26 +++--- 1 file

Re: [dpdk-dev] [PATCH v3 05/11] baseband/acc100: add LDPC processing functions

2020-08-20 Thread Dave Burley
Hi Nic, As you've now specified the use of RTE_BBDEV_LDPC_LLR_COMPRESSION for this PMB, please could you confirm what the packed format of the LLRs in memory looks like? Best Regards Dave Burley From: dev on behalf of Nicolas Chautru Sent: 19 August 2020 01:25 To: dev@dpd

Re: [dpdk-dev] [PATCH v3 05/11] baseband/acc100: add LDPC processing functions

2020-08-20 Thread Dave Burley
Hi Nic Thank you - it would be useful to have further documentation for clarification as the data format isn't explicitly documented in BBDEV. Best Regards Dave From: Chautru, Nicolas Sent: 20 August 2020 15:52 To: Dave Burley ; dev@dpdk.org Cc: Richardson, Bruce Subject: RE: [dpd

Re: [dpdk-dev] [PATCH v4 1/8] bbdev: add network order data capability

2021-04-26 Thread Dave Burley
Hi Hemant Can I ask what the usage case is for RTE_BBDEV_LDPC_ENC_NETWORK_ORDER/RTE_BBDEV_LDPC_DEC_NETWORK_ORDER ? Thanks Dave From: dev on behalf of Hemant Agrawal Sent: 24 April 2021 11:36 To: dev@dpdk.org ; gak...@marvell.com ; nicolas.chau...@intel.co