t;mcfg >= CFG_METHOD_48 && hw->mcfg <= CFG_METHOD_53) seems more
robust and is easier to read.
--
David Marchand
/
> > + 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11,
> > 0x11, /*47*/
> > + 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11,
> > 0x11, /*48*/
> > + 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11,
> > 0x11, /*49*/
> > },
> > .len = 4000
> > },
>
> This is very ugly to have the source code. Can we find a better way to do
On the other hand, this file is already full of fixed arrays filled
explicitly (like zuc_test_auth_5670b for example).
I would just drop the comments and avoid a special init case just for
this array.
> this, e.g. init this at runtime using memset, or else just disable the
> build of this test case on windows?
--
David Marchand
On Fri, Jun 13, 2025 at 10:10 AM David Marchand
wrote:
>
> Don't *require* mlx5dev library when testing its presence.
For the record, this was seen in a UNH env that seems to have
partially installed mlx5 dependencies.
Has header "mlx5devx.h" : YES
drivers\common\mlx5\win
Don't *require* mlx5dev library when testing its presence.
Fixes: 85c51a4ffab8 ("common/mlx5: get Windows dependency from standard
variables")
Signed-off-by: David Marchand
---
drivers/common/mlx5/windows/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
chnical details if needed
> 2. Make any necessary adjustments based on your feedback
Is the kernel driver being upstreamed?
--
David Marchand
On Wed, Jun 11, 2025 at 11:45 AM David Marchand
wrote:
>
> This is a rework of Andre v5, trying to hide the ugly details in a
> driver only macro not exposed publicly.
>
>
> --
> David Marchand
>
> Changes since v6:
> - changed this_pmd_name symbols construction,
&
On Mon, Jan 20, 2025 at 10:53 AM Zaiyu Wang wrote:
>
> Add myself as co-maintainer for Wangxun drivers.
>
> Signed-off-by: Zaiyu Wang
Acked-by: Jiawen Wu
Applied, thanks.
--
David Marchand
On Wed, Apr 16, 2025 at 4:43 AM Joshua Washington wrote:
Rushil is not working on DPDK topics anymore.
> Signed-off-by: Joshua Washington
Acked-by: Rushil Gupta
Applied, thanks.
--
David Marchand
rd for longer to make sure multiple samples are taken.
>
> Signed-off-by: Stephen Hemminger
We have random failures on aarch64 in OBS.
https://bugs.dpdk.org/show_bug.cgi?id=1723
It may be related to this change, does it make the test more
susceptible to timing issues?
--
David Marchand
This test triggers random failures in the CI.
Disable it until we have a fix.
Bugzilla ID: 1720
Fixes: de09387f1313 ("eventdev/vector: add default software vector adapter")
Signed-off-by: David Marchand
---
app/test/test_event_vector_adapter.c | 8 +---
1 file changed, 5 insert
__COUNTER__ is not supported by MSVC.
Plus the this_pmd_name* symbols will become global (again for MSVC) in a
next commit.
Prefer the driver name to generate a unique symbol.
Signed-off-by: David Marchand
---
buildtools/pmdinfogen.py | 2 +-
drivers/bus/auxiliary
On Wed, Apr 2, 2025 at 10:54 AM Jie Hai wrote:
>
> I am moving on to other things and dengdui is going to
> take over the role of hns3 maintainer. Update the
> MAINTAINERS accordingly.
>
> Signed-off-by: Jie Hai
Thanks for all your contributions.
Applied.
--
David Marchand
hanks for all your contributions Ian.
Applied.
--
David Marchand
ing devargs on vdev uninit.
>
> Fixes: f5b2eff0847d ("bus/vdev: fix devargs after multi-process bus scan")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Mingjin Ye
I see back and forth on this topic but this still seems strange we
would have to revert such an old commit.
Please add a unit test showing the bug.
--
David Marchand
The macros for tagging/exporting informations about a driver do not need
to be exported in the public API.
Move this to driver only header.
Signed-off-by: David Marchand
---
lib/eal/include/dev_driver.h | 41
lib/eal/include/rte_dev.h| 41
al binaries.
Signed-off-by: Andre Muezerie
Signed-off-by: David Marchand
---
drivers/bus/cdx/bus_cdx_driver.h| 3 +--
lib/eal/common/eal_common_options.c | 2 +-
lib/eal/include/dev_driver.h| 19 ---
3 files changed, 14 insertions(+), 10 deletions(-)
diff --g
From: Andre Muezerie
Script usertools\dpdk-pmdinfo.py was enhanced to also be able to parse
symbols from sections in PE images.
Signed-off-by: Andre Muezerie
Acked-by: Robin Jarry
---
usertools/dpdk-pmdinfo.py | 53 +++
1 file changed, 43 insertions(+), 10
From: Andre Muezerie
The archiver tool from the MSVC toolset is lib.exe. It has different
parameters then it's GNU counterpart "ar".
buildtools\meson.build was updated to use lib.exe when MSVC compiler is
used. This is to allow the code to be built without requiring GNU "ar"
to be installed in t
This is a rework of Andre v5, trying to hide the ugly details in a
driver only macro not exposed publicly.
--
David Marchand
Changes since v6:
- changed this_pmd_name symbols construction,
Changes since v5:
- moved details in dev_driver.h,
- renamed RTE_INCLUDE as RTE_PMD_EXPORT_SYMBOL
On Tue, Jun 10, 2025 at 10:37 AM David Marchand
wrote:
>
> MSVC warns about atomic qualifier:
> ../app/test/test_per_lcore.c(101): error C2220: the following warning is
> treated as an error
> ../app/test/test_per_lcore.c(101): warning C4090: 'function': dif
On Tue, Jun 10, 2025 at 12:10 PM David Marchand
wrote:
>
> From: Andre Muezerie
>
> DPDK uses GCC attribute "used" through macro __rte_used to indicate
> that a variable not referenced in the code should be assumed being
> used and therefore not be optimized away. Thi
From: Andre Muezerie
The archiver tool from the MSVC toolset is lib.exe. It has different
parameters then it's GNU counterpart "ar".
buildtools\meson.build was updated to use lib.exe when MSVC compiler is
used. This is to allow the code to be built without requiring GNU "ar"
to be installed in t
final binaries.
The elimination of "static" for some of these variables caused name
clashes when __COUNTER__ predefined macro was used. As a workaround,
predefined macro __LINE__ was used instead.
Signed-off-by: Andre Muezerie
Signed-off-by: David Marchand
---
drivers/bus/auxilia
From: Andre Muezerie
Script usertools\dpdk-pmdinfo.py was enhanced to also be able to parse
symbols from sections in PE images.
Signed-off-by: Andre Muezerie
---
usertools/dpdk-pmdinfo.py | 53 +++
1 file changed, 43 insertions(+), 10 deletions(-)
diff --gi
This is a rework of Andre v5, trying to hide the ugly details in a
driver only macro not exposed publicly.
--
David Marchand
Changes since v5:
- moved details in dev_driver.h,
- renamed RTE_INCLUDE as RTE_PMD_EXPORT_SYMBOL,
Andre Muezerie (3):
dev: export driver information with MSVC
The macros for tagging/exporting informations about a driver do not need
to be exported in the public API.
Move this to driver only header.
Signed-off-by: David Marchand
---
lib/eal/include/dev_driver.h | 41
lib/eal/include/rte_dev.h| 41
ix race in per-lcore test")
Signed-off-by: David Marchand
---
app/test/test_per_lcore.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test/test_per_lcore.c b/app/test/test_per_lcore.c
index 9c72f0fa21..e0674b0e70 100644
--- a/app/test/test_per_lcore.c
+++ b/app/
Some trivial builds warnings with MSVC were missed as those were not
treated as errors.
Signed-off-by: David Marchand
---
.github/workflows/build.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 1e289979e3
On Thu, Jun 5, 2025 at 4:55 PM Eugenio Perez Martin wrote:
>
> On Thu, Jun 5, 2025 at 1:50 PM David Marchand
> wrote:
> >
> > On Thu, Jun 5, 2025 at 1:36 PM Eugenio Pérez wrote:
> > >
> > > QEMU's shadow virtqueue and VDUSE exposes these are
clear to me.
What is the impact from a user pov?
--
David Marchand
Signed-off-by: Oleksandr Nahnybida
> Acked-by: Sunil Kumar Kori
Applied, thanks.
--
David Marchand
he secondary process.
> This patch use to skip this kind of useless detection for this
> scenario.
>
> Signed-off-by: Yang Ming
> Acked-by: Anatoly Burakov
Applied, thanks.
--
David Marchand
uot;mem: move virtual area function in common directory")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Dengdui Huang
> Acked-by: Dmitry Kozlyuk
Applied, thanks.
--
David Marchand
t;app: various tests update")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Bruce Richardson
> Acked-by: Chengwen Feng
Applied, thanks.
--
David Marchand
vedkin
Applied, thanks.
--
David Marchand
his patchset.
Open question, since the submission of this series, __rte_used is used
in the new symbol export macros.
It seems those macros are not affected by the problem you described
(and fixed with RTE_INCLUDE).
Is it because the symbols are explicitly listed as exported?
--
David Marchand
27;s not really needed, especially since the same value is also
> stored in dev->data->mtu, so the kernel query can easily be replaced
> with reading dev->data->mtu.
Good point, which makes this priv->mtu even less useful.
Thanks Dariusz.
--
David Marchand
bprocess.PIPE,
> +check=True,
> +)
> +.stdout.decode()
> +.splitlines()
> +):
> if os.path.exists(name):
> paths.append(name)
Indent after the change seems strange.
And we need a rebase of this series in any case.
Please send a new revision.
--
David Marchand
so they really should be in a "utils" library.
> But that's another story, so let's not burden Andre with that.
Orthogonal to the question.
--
David Marchand
ws.
>
> This patch eliminates the use of tempfile.TemporaryDirectory, which
> was triggering the issue.
>
> Signed-off-by: Andre Muezerie
Applied, thanks.
--
David Marchand
644 app/test/test_math.c
> create mode 100644 lib/eal/include/rte_math.h
I am not a fan of adding such public API, an internal API would be enough.
Do you plan to add more helpers for math operations?
For the current helper, the only user is a driver (base code).
Can't we just wrap a __builtin_add_overflow (under #ifdef msvc) in the
osdep.h header?
--
David Marchand
On Sat, Jan 4, 2025 at 11:10 PM Andre Muezerie
wrote:
>
> Removed a few includes which were not needed and included
> rte_os_shim.h to handle strtok_r which does not exist on
> Windows with that exact name.
>
> Signed-off-by: Andre Muezerie
Applied, thanks.
--
David Marchand
h MSVC.
Series applied, thanks.
--
David Marchand
On Fri, May 16, 2025 at 7:37 PM Andre Muezerie
wrote:
>
> This patchset resolves all issues related to lpm that until now prevented
> it from being built using MSVC.
>
> After resolving the issues it enables lpm to be compiled with MSVC.
Series applied, thanks.
--
David Marchand
On Fri, May 9, 2025 at 11:52 PM Andre Muezerie
wrote:
>
> Now that mbuf is compiling on Windows, this library can be enabled as
> well.
>
> Signed-off-by: Andre Muezerie
I enabled app/test-regex at the same time.
Applied, thanks.
--
David Marchand
On Fri, May 16, 2025 at 4:44 PM Thomas Monjalon wrote:
>
> 16/05/2025 14:50, Andre Muezerie:
> > On Fri, May 16, 2025 at 10:01:42AM +0200, David Marchand wrote:
> > > On Fri, May 9, 2025 at 11:52 PM Andre Muezerie
> > > wrote:
> > > >
> > > &g
in priv.
There is only one user of the value, and it is for configuration
operation that can do a query to the kernel.
--
David Marchand
gs in a
single repository with the main DPDK branch, and the DPDK/dpdk github
repository seemed like the best location.
I have just set up this mirroring down to 20.11 branch.
The DPDK/dpdk github repository now contains most (if not all) of the
active branches and tags.
--
David Marchand
Hello Luca, Xueming,
On Wed, Jan 31, 2024 at 6:44 PM David Marchand
wrote:
>
> Fedora 37 has reached end of life in December 2023.
> Ubuntu 20.04 is getting quite old.
>
> Switch to more recent versions.
>
> With this move, some packages provided by those distributions are n
t redzone: f1
Stack mid redzone: f2
Stack right redzone: f3
Stack after return: f5
Stack use after scope: f8
Global redzone: f9
Global init order: f6
Poisoned by user:f7
Container overflow: fc
Array cookie: ac
Intra object redzone:bb
ASan internal: fe
Left alloca redzone: ca
Right alloca redzone:cb
==55106==ABORTING
--
David Marchand
ries depends on additions to vfio uapi that
> enable TPH icotl in the vfio-pci driver in the Linux kernel.
> These additions have not yet been merged into the upstream kernel.
Could you provide a link to the ongoing discussions (ml archive maybe)?
Thanks.
--
David Marchand
rt_unmap(struct rte_pci_ioport *p)
>
> return ret;
> }
> +
> +RTE_EXPORT_EXPERIMENTAL_SYMBOL(rte_pci_tph_enable, 25.03)
The release currently prepared is 25.07.
(no need for a respin for just this comment, this series is not ready
for merge in any case)
--
David Marchand
ns 0
> ../app/test/test_ipfrag.c(160): warning C4034: sizeof returns 0
>
> The fix is to simplify the code and remove the zero-size array.
>
> Signed-off-by: Andre Muezerie
Applied, thanks.
--
David Marchand
On Fri, May 16, 2025 at 3:09 PM Andre Muezerie
wrote:
>
> On Fri, May 16, 2025 at 11:22:05AM +0200, David Marchand wrote:
> > Andre,
> >
> > On Fri, Mar 7, 2025 at 2:40 AM Andre Muezerie
> > wrote:
> > >
> > > There are two lines that were u
mpatibility work.
> The long-term plan involves API changes and therefore can only be applied
> with a new release. This long-term plan consists of introducing some
> reasonable limitation on RCU DQ element size.
>
> Signed-off-by: Andre Muezerie
Applied with enabling RCU compilation on MSVC.
Thanks.
--
David Marchand
On Wed, Apr 16, 2025 at 2:34 PM Maxime Coquelin
wrote:
>
> This series documents the license exception granted by both
> the technical and governing boards to import uAPI header
> files.
>
> It also imports VDUSE uAPI header file from Kernel v6.14.
>
> David Marchand (1)
g/project/dpdk/list/?series=35065&state=%2A&archive=both
--
David Marchand
MSVC depends on this current patch and a fix
in test/ipfrag:
https://patchwork.dpdk.org/project/dpdk/patch/1741313581-14300-1-git-send-email-andre...@linux.microsoft.com/.
Is there anything else missing?
If not, then I would be for doing this enabling as part of this
current patch (I can do this when applying).
WDYT?
--
David Marchand
ns 0
> ../app/test/test_ipfrag.c(160): warning C4034: sizeof returns 0
>
> The fix is to simplify the code and remove the zero-size array.
>
> Signed-off-by: Andre Muezerie
Looks simple enough and valid.
Reviewed-by: David Marchand
--
David Marchand
rikanth Yalavarthi
Applied, thanks.
--
David Marchand
Hello,
On Thu, Apr 10, 2025 at 1:39 PM David Marchand
wrote:
>
> On Fri, Mar 7, 2025 at 2:40 AM Andre Muezerie
> wrote:
> >
> > There are two lines that were using VLAs, which are not supported by
> > MSVC.
> >
> > 1)
> > ../lib/rcu/rte_rcu_qsbr.
is_ms_compiler).
--
David Marchand
rt/2025-May/877981.html
This is probably related to the meson version in the build env, since
this patch increases the minimum version to 0.57.2.
Can you have a look please?
--
David Marchand
he secondary process.
> This patch use to skip this kind of useless detection for this
> scenario.
>
> Signed-off-by: Yang Ming
With such a change, is the check on the passed kernel module still needed?
--
David Marchand
e")
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: Yang Ming
> Acked-by: Stephen Hemminger
Applied, thanks.
--
David Marchand
r way, making the code more readable and
> likely allowing Coverity to make the right determination.
>
> Signed-off-by: Andre Muezerie
Reviewed-by: David Marchand
Applied, thanks.
--
David Marchand
On Thu, May 15, 2025 at 11:37 AM Bruce Richardson
wrote:
>
> On Thu, May 15, 2025 at 09:09:22AM +0200, David Marchand wrote:
> > On Tue, May 13, 2025 at 11:00 AM Bruce Richardson
> > wrote:
> > >
> > > Add a script to buildtools to report the minimum meson ve
mminger
> Reviewed-by: Patrick Robb
> ---
> v2: rebased to latest main
This patch is reverting dbcd72f3fba0 ("ci: fix unit tests with Fedora 37").
There were some strange errors raised by UNH, though I don't see the
same python backtrace.
Let's try again:
Recheck-request: iol-unit-arm64-testing, iol-unit-amd64-testing
--
David Marchand
of this false positive today.
https://lab.dpdk.org/results/dashboard/patchsets/33170/
--
David Marchand
gt; releases, we can drop the check for this condition from all the
> Makefiles. More recent pkg-config versions don't have this issue.
>
> Signed-off-by: Bruce Richardson
Reviewed-by: David Marchand
Applied, thanks Bruce.
--
David Marchand
On Tue, Apr 8, 2025 at 7:19 PM Bruce Richardson
wrote:
>
> Latest DPDK releases no longer officially support RHEL 7 as a target
> platform, so remove the note about pkg-config not working on those
> systems.
>
> Signed-off-by: Bruce Richardson
Applied, thanks.
--
David Marchand
if this additional change was squashed in
96a1290b6258 ("net/gve: support for gVNIC PCI revision 1 and later")
while pulling.)
But otherwise this cleanup can be merged after.
In any case, for net drivers update, please continue basing your work
on next-net.
Thanks.
--
David Marchand
On Tue, Apr 8, 2025 at 7:19 PM Bruce Richardson
wrote:
>
> Latest DPDK releases no longer officially support RHEL 7 as a target
> platform, so remove the note about pkg-config not working on those
> systems.
>
> Signed-off-by: Bruce Richardson
Reviewed-by: David Marchand
I
On Mon, May 12, 2025 at 5:28 PM Bruce Richardson
wrote:
> On Thu, May 08, 2025 at 06:42:29AM +0200, David Marchand wrote:
> > A recent change broke disabling developer mode:
> > $ meson setup plop -Ddeveloper_mode=disabled
> > ...
> > drivers/meson.build:150:14:
rguments.
EAL: Error - exiting with code: 1
Cannot init EAL: Invalid argument
Add a better hint to help the user.
Fixes: 2eba8d21f3c9 ("eal: restrict cores auto detection")
Cc: sta...@dpdk.org
Signed-off-by: David Marchand
---
lib/eal/common/eal_common_options.c | 5 +
1 file changed
A recent change broke disabling developer mode:
$ meson setup plop -Ddeveloper_mode=disabled
...
drivers/meson.build:150:14: ERROR: Unknown variable "fs".
Fixes: 8fa3af6c05f8 ("build: add generic support for base code in drivers")
Signed-off-by: David Marchand
---
meson.b
> 25 files changed, 60 insertions(+), 160 deletions(-)
> >
> >
> > Looks ok to me. Since depends on the Intel part, lets take this through
> > next-intel tree.
> >
> > Series-Acked-by: Stephen Hemminger
>
> While I can take this in next-intel, the required changes from the Intel
> side are already present in main, so this should be ok to take through
> either the net tree or, better, the main tree (since it's not just net
> drivers it affects).
>
> Thomas, David, do you want to take this (well, the v2) through main tree?
Sorry, I was looking at v2, but I replied on the v1 thread.
In any case, yes, I merged it to main.
--
David Marchand
ld | 18 ++
> drivers/net/txgbe/meson.build | 3 ---
> drivers/raw/ifpga/base/meson.build | 21 ++---
> drivers/raw/ifpga/meson.build | 15 ---
> 25 files changed, 60 insertions(+), 160 deletions(-)
Series applied.
Thanks for this cleanup Bruce.
--
David Marchand
->dev_id,
> > + qp_id, NULL, 0,
> > + RTE_IPSEC_MB_MP_REQ_QP_FREE);
> > }
> > return 0;
> > }
>
> Hi Experts,
>
> Is there any chance to review and accept this patch?
Don't forget to Cc maintainers.
--
David Marchand
perly?
> I am on Linux Mint. Are there dependencies that I should've instaslled?
Ciara, Maryam, could you help Vivek?
Thanks.
--
David Marchand
Copying the trace framework maintainers who will have a better idea.
--
David Marchand
On Wed, Apr 16, 2025 at 4:37 PM Stephen Hemminger
wrote:
>
> On Wed, 16 Apr 2025 08:10:34 +0200
> David Marchand wrote:
>
> > The PCI standard defines registers for:
> > - subsystem id,
> > - revision id,
> > - status of the device,
> > - vital product d
The PCI standard defines registers for:
- subsystem id,
- revision id,
- status of the device,
- vital product data,
Add them to rte_pci.h and use in existing drivers.
Signed-off-by: David Marchand
---
drivers/dma/hisilicon/hisi_dmadev.c | 3 +--
drivers/dma/hisilicon/hisi_dmadev.h | 1
Call check-spdx.tag.sh so that all committed files are checked.
Signed-off-by: David Marchand
---
.github/workflows/build.yml | 1 +
1 file changed, 1 insertion(+)
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 7a6b679fe5..1e289979e3 100644
--- a/.github/workflows
ugh technically perhaps not as good as [1], this avoids significant
> divergence from the shared base code, while still fixing the core issue.
>
> Acked-by: Bruce Richardson
>
>
> [1]
> https://patches.dpdk.org/project/dpdk/patch/1734537913-1159-1-git-send-email-andre...@linux.microsoft.com/
LGTM.
I marked Andre patch as rejected.
--
David Marchand
al/include/rte_common.h| 34 +-
> 13 files changed, 109 insertions(+), 78 deletions(-)
I replaced patch 5 with the alternative that I sent yesterday.
Series applied.
We now have dpdk-test and dpdk-testpmd built with MSVC in the CI.
We are still missing net/null and mempool/ring to do some basic test
like devtools/test-null.sh.
On the other hand, what prevents us from running the fast-tests
testsuite in the CI?
--
David Marchand
gt; +include_directories: includes,
> +c_args: sve_cflags)
> +objs += sve_lib.extract_objects(sources_sve)
> +endif
> +endif
> +
> # generate pmdinfo sources by building a temporary
> # lib and then running pmdinfogen on the contents of
> # that lib. The final lib reuses the object files and
On the principle, sources_sve must be passed to gen_version_map like
other sources_XXX.
--
David Marchand
on "mbuf" which will now get fulfilled.
>
> Signed-off-by: Andre Muezerie
> Acked-by: Bruce Richardson
Applied, thanks.
--
David Marchand
which does not make sense with testpmd.
I sent a simpler fix, could you have a look?
https://patchwork.dpdk.org/project/dpdk/patch/20250410160237.3067629-1-david.march...@redhat.com/
--
David Marchand
Compiling with MSVC results in warnings like below:
app/test-pmd/cmdline.c(9023): warning C5101: use of preprocessor
directive in function-like macro argument list is undefined behavior
Construct token list at runtime.
Signed-off-by: David Marchand
---
Note: this is an alternative to
https
mpatibility work.
> The long-term plan involves API changes and therefore can only be applied
> with a new release. This long-term plan consists of introducing some
> reasonable limitation on RCU DQ element size.
>
> Signed-off-by: Andre Muezerie
Honnappa, any objection?
--
David Marchand
.
I would move those declarations to rte_string_fns.h but this can wait
a followup patch since other helper was already in rte_common.h.
Series applied, thanks.
--
David Marchand
On Thu, Mar 27, 2025 at 7:06 PM Bruce Richardson
wrote:
>
> On Wed, Mar 26, 2025 at 11:39:28AM +0100, David Marchand wrote:
> > Caught in OBS for Fedora Rawhide on aarch64:
> >
> > [ 198s] In file included from ../lib/acl/acl_run_neon.h:7,
> > [ 198s]
t; +cflags += option
> +endif
> +endforeach
What guarantee do we have that MSVC builds with those instructions?
> # only build AVX-512 support if we also have PCLMULQDQ support
> if cc.has_argument('-mvpclmulqdq')
> sources_avx512 += files('net_crc_avx512.c')
--
David Marchand
No version.map touching anymore, those files are generated at build
time, so developers don't need to care about them.
In lib/node/node_mbuf_dynfield.c, you need to include eal_export.h and add:
+RTE_EXPORT_EXPERIMENTAL_SYMBOL(rte_node_mbuf_dynfield_register, 25.07)
+int rte_node_mbuf_dynfield_register(void)
+{
...
--
David Marchand
as unknown to this glue library:
>
> drivers/common/mlx5/linux/mlx5_glue.c:19:10: fatal error:
> eal_export.h: No such file or directory
>
> Fixes: c7020bb20fc7 ("build: mark exported symbols")
>
> Reported-by: Ali Alnubani
> Signed-off-by: Thomas Monjalon
lgtm.
Acked-by: David Marchand
--
David Marchand
endency on "mbuf" which will now get fulfilled.
>
> Signed-off-by: Andre Muezerie
> Acked-by: Bruce Richardson
I just merged the symbol export / versioning rework series.
Could you please resend this patch only, for the CI to have a go?
Thank you.
--
David Marchand
On Thu, Apr 3, 2025 at 6:59 PM David Marchand wrote:
>
> So far, each DPDK library (or driver) exposing symbols in an ABI had to
> maintain a version.map and use some macros for symbol versioning,
> specially crafted with the GNU linker in mind.
>
> This series proposes t
automatic mapping of high lcore ids
> >
> Ping for review.
>
> At a high level, does this feature seem useful to users?
This seems useful, though I am not I would touch the existing options.
I would have gone with a simple -L option (taking the same kind of
input than -l but with new behavior), and not combine a flag with
existing options.
I scanned through the series, not much to say.
Maybe add a unit test for new cmdline option.
--
David Marchand
ap_opt));
> } else {
> eal_auto_detect_cores(cfg);
> }
> diff --git a/lib/eal/include/rte_eal.h b/lib/eal/include/rte_eal.h
> index c826e143f1..013075487c 100644
> --- a/lib/eal/include/rte_eal.h
> +++ b/lib/eal/include/rte_eal.h
> @@ -493,22 +493,20 @@ rte_eal_get_runtime_dir(void);
> /**
> * Convert a string describing a mask of core ids into an array of core ids.
> *
> - * On success, the passed array is filled with the orders of the core ids
> - * present in the mask (-1 indicating that a core id is absent).
> - * For example, passing a 0xa coremask results in cores[1] = 0, cores[3] = 1,
> - * and the rest of the array is set to -1.
> + * On success, the passed array is filled with the core ids present in the
> mask.
> *
> * @param coremask
> * A string describing a mask of core ids.
> * @param cores
> - * An array where to store the core ids orders.
> + * The output array to store the core ids.
> * This array must be at least RTE_MAX_LCORE large.
> * @return
> - * 0 on success, -1 if the string content was invalid.
> + * The number of cores in the coremask, and in the returned "cores" array,
> + * -1 if the string content was invalid.
> */
> __rte_internal
> int
> -rte_eal_parse_coremask(const char *coremask, int *cores);
> +rte_eal_expand_coremask(const char *coremask, int *cores);
>
> #ifdef __cplusplus
> }
> diff --git a/lib/eal/version.map b/lib/eal/version.map
> index a20c713eb1..b51051ee38 100644
> --- a/lib/eal/version.map
> +++ b/lib/eal/version.map
> @@ -405,8 +405,8 @@ INTERNAL {
>
> rte_bus_register;
> rte_bus_unregister;
> + rte_eal_expand_coremask;
> rte_eal_get_baseaddr;
> - rte_eal_parse_coremask;
> rte_firmware_read;
> rte_intr_allow_others;
> rte_intr_cap_multiple;
> --
> 2.45.2
>
--
David Marchand
1 - 100 of 2117 matches
Mail list logo
