[PATCH] config: limit lcore variable maximum size to 4k

2112 bytes object. Limit the lcore variable maximum size to 4k which looks more reasonable. Fixes: 5bce9bed67ad ("eal: add static per-lcore memory allocation facility") Signed-off-by: David Marchand --- config/rte_config.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --gi

Re: [PATCH v32 00/12] Log library enhancements

On Fri, Nov 8, 2024 at 9:57 AM David Marchand wrote: > > Improvements and unification of logging library. > This version works on all platforms: Linux, Windows and FreeBSD. > > This is update to rework patch set. It adds several new features > to the console log output.

Re: [PATCH v5 00/25]

luding rte_os_shim.h in examples breaks compilation. Too late for taking in rc2, I may consider in rc3 if the series is fixed by then. Thanks. -- David Marchand

Re: [PATCH v2 0/2] gpudev: annotate memory allocation functions

--- > 2 files changed, 27 insertions(+), 35 deletions(-) There is a build error due to referencing experimental symbol in annotation. -- David Marchand

Re: [PATCH v2] test/fib: clarify FIB RCU negative tests

ir Medvedkin I kept Stephen ack from v1. Applied, thanks. -- David Marchand

Re: Re:RE: [EXTERNAL] [PATCH] graph: optimize graph search when scheduling nodes

be a short term solution, but in my opinion, the slow path part should be entirely hidden and we only expose the fp part. Reminder, those holes must be in a "known state" as we release v24.11 so that the presence of future additions can be safely detected. -- David Marchand

Re: [PATCH] eal: fix cleanup on Windows

ion: > exit status 3221226356 or signal 3221226228 SIGinvalid > with MALLOC_PERTURB_=86 > > Fixes: 5bce9bed67ad ("eal: add static per-lcore memory allocation facility") > > Reported-by: David Marchand > Signed-off-by: Thomas Monjalon Reviewed-by: David Marchand -- David Marchand

[PATCH v32 11/12] log: colorize log output

From: Stephen Hemminger Like dmesg, colorize the log output (unless redirected to file). Timestamp is green, the subsystem is in yellow and the message is red if urgent, boldface if an error, and normal for info and debug messages. The default is to not use color since it may disturb automatic t

[PATCH v32 12/12] maintainers: update for log library

From: Stephen Hemminger "You touch it you own it". Add myself as maintainer for log library. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Chengwen Feng Acked-by: Bruce Richardson --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --gi

[PATCH v32 09/12] log: add timestamp option

From: Stephen Hemminger When debugging driver or startup issues, it is useful to have a timestamp on each message printed. The messages in syslog already have a timestamp, but often syslog is not available during testing. There are multiple timestamp formats similar to Linux dmesg. The default i

[PATCH v32 10/12] log: support systemd journal

From: Stephen Hemminger If DPDK application is being run as a systemd service, then it can use the journal protocol which allows putting more information in the log such as priority and other information. The use of journal protocol is automatically detected and handled. Rather than having a dep

[PATCH v32 08/12] log: add hook for printing log messages

From: Stephen Hemminger This is useful for when decorating log output for console or journal. Provide basic version in this patch. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Acked-by: Bruce Richardson Acked-by: Chengwen Feng --- lib/log/log.c | 8 +++- 1 file changed, 7 in

[PATCH v32 07/12] eal: initialize log before everything else

From: Stephen Hemminger In order for all log messages (including CPU mismatch) to come out through the logging library, it must be initialized as early in rte_eal_init() as possible on all platforms. Where it was done before was likely historical, based on the support of non-OS isolated CPU's wh

[PATCH v32 06/12] log: rework syslog handling

From: Stephen Hemminger Refactor how syslog is handled, make it common to Linux and FreeBSD The syslog facility property is better handled in lib/log rather than in eal. This also adds syslog support to FreeBSD. Log to syslog only if option is specified. If no --syslog is given then use only sta

[PATCH v32 05/12] eal: improve exit output log

From: Stephen Hemminger The rte_exit() output format confuses the timestamp and coloring options. Change it to use be a single line with proper prefix. Before: [ 0.006481] EAL: Error - exiting with code: 1 Cause: [ 0.006489] Cannot init EAL: Permission denied After: [ 0.006238] EA

[PATCH v32 04/12] eal: do not log init failure twice

From: Stephen Hemminger The message already goes through logging, and does not need to be printed on stderr. Message level should be ALERT to match function name. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Bruce Richardson Acked-by: Chengwen F

[PATCH v32 02/12] eal: factorize parser for log level

From: Stephen Hemminger The code to parse for log-level option should be same on all OS variants. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Bruce Richardson --- lib/eal/common/eal_common_options.c | 40 +++ lib/eal/co

[PATCH v32 03/12] eal: introduce log options parser

Rename existing log level option parser and add a little helper tracking all options related to logs. This will make it easier to add more log options in the next commits. Signed-off-by: David Marchand --- lib/eal/common/eal_common_options.c | 26 ++ lib/eal/common

[PATCH v32 01/12] eal/windows: align getopt to FreeBSD

From: Stephen Hemminger Having different prototypes on different platforms can lead to lots of unnecessary workarounds. It looks like the version of getopt used from windows was based on an older out of date version from FreeBSD. This patch changes getopt, getopt_long, etc to have the same const

[PATCH v32 00/12] Log library enhancements

facility code update in relevant patch, - removed dead reference to eal_log_set_default, -- David Marchand David Marchand (1): eal: introduce log options parser Stephen Hemminger (11): eal/windows: align getopt to FreeBSD eal: factorize parser for log level eal: do not log init failure

[PATCH v32 01/12] eal/windows: align getopt to FreeBSD

From: Stephen Hemminger Having different prototypes on different platforms can lead to lots of unnecessary workarounds. It looks like the version of getopt used from windows was based on an older out of date version from FreeBSD. This patch changes getopt, getopt_long, etc to have the same const

Re: [PATCH v31 00/12] Log library enhancements

On Thu, Nov 7, 2024 at 9:52 PM David Marchand wrote: > > Improvements and unification of logging library. > This version works on all platforms: Linux, Windows and FreeBSD. > > This is update to rework patch set. It adds several new features > to the console log output.

[PATCH v32 06/12] log: rework syslog handling

From: Stephen Hemminger Refactor how syslog is handled, make it common to Linux and FreeBSD The syslog facility property is better handled in lib/log rather than in eal. This also adds syslog support to FreeBSD. Log to syslog only if option is specified. If no --syslog is given then use only sta

[PATCH v32 12/12] maintainers: update for log library

From: Stephen Hemminger "You touch it you own it". Add myself as maintainer for log library. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Chengwen Feng Acked-by: Bruce Richardson --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --gi

[PATCH v32 11/12] log: colorize log output

From: Stephen Hemminger Like dmesg, colorize the log output (unless redirected to file). Timestamp is green, the subsystem is in yellow and the message is red if urgent, boldface if an error, and normal for info and debug messages. The default is to not use color since it may disturb automatic t

[PATCH v32 10/12] log: support systemd journal

From: Stephen Hemminger If DPDK application is being run as a systemd service, then it can use the journal protocol which allows putting more information in the log such as priority and other information. The use of journal protocol is automatically detected and handled. Rather than having a dep

[PATCH v32 09/12] log: add timestamp option

From: Stephen Hemminger When debugging driver or startup issues, it is useful to have a timestamp on each message printed. The messages in syslog already have a timestamp, but often syslog is not available during testing. There are multiple timestamp formats similar to Linux dmesg. The default i

[PATCH v32 08/12] log: add hook for printing log messages

From: Stephen Hemminger This is useful for when decorating log output for console or journal. Provide basic version in this patch. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Acked-by: Bruce Richardson Acked-by: Chengwen Feng --- lib/log/log.c | 8 +++- 1 file changed, 7 in

[PATCH v32 07/12] eal: initialize log before everything else

From: Stephen Hemminger In order for all log messages (including CPU mismatch) to come out through the logging library, it must be initialized as early in rte_eal_init() as possible on all platforms. Where it was done before was likely historical, based on the support of non-OS isolated CPU's wh

[PATCH v31 00/12] Log library enhancements

facility code update in relevant patch, - removed dead reference to eal_log_set_default, -- David Marchand David Marchand (1): eal: introduce log options parser Stephen Hemminger (11): eal/windows: align getopt to FreeBSD eal: factorize parser for log level eal: do not log init failure

[PATCH v32 05/12] eal: improve exit output log

From: Stephen Hemminger The rte_exit() output format confuses the timestamp and coloring options. Change it to use be a single line with proper prefix. Before: [ 0.006481] EAL: Error - exiting with code: 1 Cause: [ 0.006489] Cannot init EAL: Permission denied After: [ 0.006238] EA

[PATCH v32 02/12] eal: factorize parser for log level

From: Stephen Hemminger The code to parse for log-level option should be same on all OS variants. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Bruce Richardson --- lib/eal/common/eal_common_options.c | 40 +++ lib/eal/co

[PATCH v32 04/12] eal: do not log init failure twice

From: Stephen Hemminger The message already goes through logging, and does not need to be printed on stderr. Message level should be ALERT to match function name. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Bruce Richardson Acked-by: Chengwen F

[PATCH v32 03/12] eal: introduce log options parser

Rename existing log level option parser and add a little helper tracking all options related to logs. This will make it easier to add more log options in the next commits. Signed-off-by: David Marchand --- lib/eal/common/eal_common_options.c | 26 ++ lib/eal/common

[PATCH v31 12/12] maintainers: update for log library

From: Stephen Hemminger "You touch it you own it". Add myself as maintainer for log library. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Chengwen Feng Acked-by: Bruce Richardson --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --gi

[PATCH v31 11/12] log: colorize log output

From: Stephen Hemminger Like dmesg, colorize the log output (unless redirected to file). Timestamp is green, the subsystem is in yellow and the message is red if urgent, boldface if an error, and normal for info and debug messages. The default is to not use color since it may disturb automatic t

[PATCH v31 10/12] log: support systemd journal

From: Stephen Hemminger If DPDK application is being run as a systemd service, then it can use the journal protocol which allows putting more information in the log such as priority and other information. The use of journal protocol is automatically detected and handled. Rather than having a dep

[PATCH v31 09/12] log: add timestamp option

From: Stephen Hemminger When debugging driver or startup issues, it is useful to have a timestamp on each message printed. The messages in syslog already have a timestamp, but often syslog is not available during testing. There are multiple timestamp formats similar to Linux dmesg. The default i

[PATCH v31 08/12] log: add hook for printing log messages

From: Stephen Hemminger This is useful for when decorating log output for console or journal. Provide basic version in this patch. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Acked-by: Bruce Richardson Acked-by: Chengwen Feng --- lib/log/log.c | 8 +++- 1 file changed, 7 in

[PATCH v31 07/12] eal: initialize log before everything else

From: Stephen Hemminger In order for all log messages (including CPU mismatch) to come out through the logging library, it must be initialized as early in rte_eal_init() as possible on all platforms. Where it was done before was likely historical, based on the support of non-OS isolated CPU's wh

[PATCH v31 06/12] log: rework syslog handling

From: Stephen Hemminger Refactor how syslog is handled, make it common to Linux and FreeBSD The syslog facility property is better handled in lib/log rather than in eal. This also adds syslog support to FreeBSD. Log to syslog only if option is specified. If no --syslog is given then use only sta

[PATCH v31 05/12] eal: improve exit output log

From: Stephen Hemminger The rte_exit() output format confuses the timestamp and coloring options. Change it to use be a single line with proper prefix. Before: [ 0.006481] EAL: Error - exiting with code: 1 Cause: [ 0.006489] Cannot init EAL: Permission denied After: [ 0.006238] EA

[PATCH v31 04/12] eal: do not log init failure twice

From: Stephen Hemminger The message already goes through logging, and does not need to be printed on stderr. Message level should be ALERT to match function name. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Bruce Richardson Acked-by: Chengwen F

[PATCH v31 03/12] eal: introduce log options parser

Rename existing log level option parser and add a little helper tracking all options related to logs. This will make it easier to add more log options in the next commits. Signed-off-by: David Marchand --- lib/eal/common/eal_common_options.c | 26 ++ lib/eal/common

[PATCH v31 02/12] eal: factorize parser for log level

From: Stephen Hemminger The code to parse for log-level option should be same on all OS variants. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Bruce Richardson --- lib/eal/common/eal_common_options.c | 40 +++ lib/eal/co

[PATCH v31 01/12] eal/windows: align getopt to FreeBSD

From: Stephen Hemminger Having different prototypes on different platforms can lead to lots of unnecessary workarounds. It looks like the version of getopt used from windows was based on an older out of date version from FreeBSD. This patch changes getopt, getopt_long, etc to have the same const

[PATCH v31 00/12] Log library enhancements

, -- David Marchand David Marchand (1): eal: introduce log options parser Stephen Hemminger (11): eal/windows: align getopt to FreeBSD eal: factorize parser for log level eal: do not log init failure twice eal: improve exit output log log: rework syslog handling eal: initialize log

Re: [PATCH] test/fib: clarify FIB RCU negative tests

"Secondary RCU was mistakenly > attached\n"); > + RTE_TEST_ASSERT(status = -EEXIST, "Secondary RCU was mistakenly > attached\n"); My eyes stopped on this. Should be == right? > > rte_fib_free(fib); > rte_free(qsv); -- David Marchand

[PATCH] ci: remove workaround for ASan in Ubuntu GHA images

This workaround is directly applied inside Ubuntu GHA images themselves. Link: https://github.com/actions/runner-images/commit/9485052d98ba055be3355565e23630de8f8c4ef8 Signed-off-by: David Marchand --- .github/workflows/build.yml | 7 --- 1 file changed, 7 deletions(-) diff --git a

Re: [PATCH] app/dumpcap: remove unused struct array

emminger > > Signed-off-by: Bruce Richardson > Acked-by: Stephen Hemminger Applied, thanks. -- David Marchand

Re: [PATCH dpdk 0/2] IPv6: Fix coverity issues

On Tue, Nov 5, 2024 at 10:05 PM David Marchand wrote: > On Thu, Oct 24, 2024 at 5:20 PM Robin Jarry wrote: > > > > Here are fixes for three coverity issues: > > This series fixes two coverity issues. The fixes look correct. > But the Coverity reports are not obvious to m

Re: [PATCH dpdk v2] net: enforce 2-bytes alignment on IPv6 headers

; > Signed-off-by: Robin Jarry > Reviewed-by: Morten Brørup Applied, thanks. -- David Marchand

Re: [PATCH] net: fix IPv4 cksum simple function

On Tue, Nov 5, 2024 at 10:09 AM Morten Brørup wrote: > > > From: David Marchand [mailto:david.march...@redhat.com] > > Sent: Tuesday, 5 November 2024 09.59 > > > > The new function breaks compilation with -Wcast-align. > > > > In file included from /home/ru

Re: [PATCH v2] graph: fix memory leak in node clone

On Tue, Nov 5, 2024 at 2:28 PM David Marchand wrote: > On Fri, Nov 1, 2024 at 8:54 AM wrote: > > > > From: Pavan Nikhilesh > > > > Free memory allocated for the node when xstats memory > > allocation fails. > > > > Coverity issue: 445529 > &g

Re: [PATCH v4 00/13] replace strtok with reentrant version

as to remove the backport request (iow no Cc: sta...@dpdk.org in the commitlogs), not to drop the changes. -- David Marchand

[PATCH] net/zxdh: remove redundant log prefix

By using RTE_LOG*() macros, the log messages are prefixed by the logtype. RTE_LOG_LINE_PREFIX(level, ZXDH_RX, "zxdh rx %s(): ", ... will emit messages like "ZXDH_RX: zxdh rx %s(): ...\n" There is no need to add a prefix repeating the same information. Signed-off-by: Davi

Re: [PATCH dpdk 0/2] IPv6: Fix coverity issues

onfirm the two issues are indeed fixed? -- David Marchand

Re: [PATCH] dpdk: remove redundant null check when parse kvargs

char *name = (char *)extra_args; if (value) { ... } return 0; } The rest of the patch looks correct to me, and I did not spot a missed update. Thanks. -- David Marchand

Re: [PATCH v2] graph: fix memory leak in node clone

On Fri, Nov 1, 2024 at 8:54 AM wrote: > > From: Pavan Nikhilesh > > Free memory allocated for the node when xstats memory > allocation fails. > > Coverity issue: 445529 > Fixes: 070db97e017b ("graph: support node xstats") > > Signed-off-by: Pavan Nikhiles

Re: [PATCH] net: fix IPv4 cksum simple function

On Tue, Nov 5, 2024 at 12:08 PM Bruce Richardson wrote: > > On Tue, Nov 05, 2024 at 11:49:52AM +0100, David Marchand wrote: > > On Tue, Nov 5, 2024 at 11:20 AM Morten Brørup > > wrote: > > > > But there is still the question of packed structures with MSVC. > &g

Re: [PATCH] net: fix IPv4 cksum simple function

is > packed when not hidden away at the end of the structure. __RTE_PACKED(struct __rte_aligned(2) rte_ipv4_hdr { ... }); Agreed, looks better. -- David Marchand

Re: [PATCH] net: fix IPv4 cksum simple function

Tyler proposal seemed to rely on the current __rte_packed conventional position. https://patchwork.dpdk.org/project/dpdk/patch/1713225913-20792-2-git-send-email-roret...@linux.microsoft.com/ Note that I am not a fan of this push/pop stuff. Maybe Andre will find a better solution. In any case, I prefer we keep __rte_packed position as is until this question is resolved. -- David Marchand

[PATCH] net: fix IPv4 cksum simple function

this by aligning rte_ipv4_hdr to two bytes, and point at the start of the structure rather than the first field (which happens to be 1 byte large). Fixes: f9e1d67f237a ("net: add IPv4 cksum function for simple cases") Signed-off-by: David Marchand --- doc/guides/rel_notes/release_24_

Re: [PATCH v4 18/19] test: remove use of VLAs for Windows built code in bitset tests

in the patch. > Signed-off-by: Andre Muezerie gcc 13 (at least) complains about this patch. https://github.com/ovsrobot/dpdk/actions/runs/11677008675/job/32514228727#step:12:3658 I suspect you may have to change some "static" bitset into a dynamically allocated one. -- David Marchand

Re: [PATCH v4 02/19] eal/linux: remove use of VLAs

s) leaked in 1 allocation(s). -- It will need some rework. -- David Marchand

Re: [PATCH v2] Revert "eal/unix: fix thread creation"

Hello Luca, On Sat, Nov 2, 2024 at 11:09 AM David Marchand wrote: > > On Thu, Oct 31, 2024 at 9:46 PM Stephen Hemminger > wrote: > > > > On Thu, 31 Oct 2024 14:05:16 + > > Luca Boccassi wrote: > > > > > On Thu, 31 Oct 2024 at 13:04, David Marchand

Re: [PATCH v4] eal/unix: optimize thread creation

On Mon, Nov 4, 2024 at 9:57 AM David Marchand wrote: > > Setting the cpu affinity of the child thread from the parent thread is > racy when using pthread_setaffinity_np, as the child thread may start > running and initialize before affinity is set. > > On the other hand, settin

Re: [PATCH v9 0/9] net/zxdh: introduce net zxdh driver

d patch by patch build to the CI? > I hit the same issue in multiple series in this release. I would love to have patch by patch tests too, but I don't think UNH can handle such load. We could limit at doing this patch by patch in GHA / ovsrobot only (which I think it is done for OVS CI). -- David Marchand

[PATCH v4] eal/unix: optimize thread creation

pthread_attr_setaffinity_np available in FreeBSD and glibc, but not available in musl. Fixes: b28c6196b132 ("eal/unix: fix thread creation") Cc: sta...@dpdk.org Signed-off-by: David Marchand Acked-by: Luca Boccassi Acked-by: Stephen Hemminger Acked-by: Chengwen Feng --- Changes since v3: -

[PATCH v3] eal/unix: optimize thread creation with glibc

pthread_attr_setaffinity_np, but it is not available with musl. Fixes: b28c6196b132 ("eal/unix: fix thread creation") Cc: sta...@dpdk.org Signed-off-by: David Marchand Acked-by: Luca Boccassi --- Changes since v2: - added pthread_attr_setaffinity_np() detection, Changes since v1: - fixed

Re: [PATCH] eal/unix: optimize thread creation with glibc

On Sat, Nov 2, 2024 at 8:58 PM Stephen Hemminger wrote: > > On Sat, 2 Nov 2024 11:08:39 +0100 > David Marchand wrote: > > > Setting the cpu affinity of the child thread from the parent thread is > > racy when using pthread_setaffinity_np, as the child thread may start &g

[PATCH v2] eal/unix: optimize thread creation with glibc

pthread_attr_setaffinity_np, but it is not available with musl. Assume availability by relying on __USE_GNU that is set with glibc. Fixes: b28c6196b132 ("eal/unix: fix thread creation") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- Changes since v1: - fixed build with FreeBSD, --- li

Re: [PATCH v2] Revert "eal/unix: fix thread creation"

On Thu, Oct 31, 2024 at 9:46 PM Stephen Hemminger wrote: > > On Thu, 31 Oct 2024 14:05:16 + > Luca Boccassi wrote: > > > On Thu, 31 Oct 2024 at 13:04, David Marchand > > wrote: > > > > > > On Thu, Oct 31, 2024 at 1:58 PM Luca Boccassi > >

[PATCH] eal/unix: optimize thread creation with glibc

pthread_attr_setaffinity_np, but it is not available with musl. Assume availability by relying on __USE_GNU that is not set with musl. Fixes: b28c6196b132 ("eal/unix: fix thread creation") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- lib/eal/unix/rte_thread.c | 26 +++

Re: [PATCH v2] Revert "eal/unix: fix thread creation"

OK 1.87s This vm runs on: # lspcu Architecture: aarch64 CPU op-mode(s): 32-bit, 64-bit Byte Order: Little Endian CPU(s): 3 On-line CPU(s) list:0-2 Vendor ID:ARM BIOS Vendor ID: QEMU Model name: Neoverse-N1 BIOS Model name: virt-rhel8.6.0 CPU @ 2.0GHz ... -- David Marchand

Re: [PATCH v2] Revert "eal/unix: fix thread creation"

On Thu, Oct 31, 2024 at 1:58 PM Luca Boccassi wrote: > > On Thu, 31 Oct 2024 at 12:52, David Marchand > wrote: > > > > On Thu, Oct 31, 2024 at 1:47 PM David Marchand > > wrote: > > > Could you share a backtrace when hitting this deadlock? > > > >

Re: [PATCH v2] Revert "eal/unix: fix thread creation"

On Thu, Oct 31, 2024 at 1:47 PM David Marchand wrote: > Could you share a backtrace when hitting this deadlock? If the backtrace is not possible, running with --log-level=lib.eal:debug may help. -- David Marchand

Re: [RFC PATCH v2] net: 2-byte align packed headers

On Wed, Oct 30, 2024 at 1:55 PM Morten Brørup wrote: > > Recheck-request: rebase=main, iol-unit-amd64-testing There is a conflict because of a change in rte_ether.h and the rte_ip.h split into rte_ip4.h/rte_ip6.h (Robin series). Could you send a new revision? Thanks. -- David Marchand

Re: [PATCH v8 3/9] net/zxdh: add zxdh device pci init implementation

ts/helpers. To make it easier for you, I recommend having a look at: $ git show a10b6e53fe baa9c55009 7bb1168d98 -- drivers/net/virtio/virtio_pci.c -- David Marchand

Re: [PATCH v2 5/6] net: add smaller IPv4 cksum function for simple cases

On Wed, Oct 30, 2024 at 12:32 PM Morten Brørup wrote: > > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > Sent: Wednesday, 30 October 2024 12.28 > > > > On Wed, Oct 30, 2024 at 12:21:00PM +0100, David Marchand wrote: > > > Hello Bruce, > &g

Re: [PATCH] dumpcap: check return value from adding interface

On Sun, Oct 27, 2024 at 7:29 PM Stephen Hemminger wrote: > > The rte_pcapng_add_interface could fail. > For example: running out of space for the file. > > Covertity issue: 446742 Coverity* > Signed-off-by: Stephen Hemminger Applied, thanks. -- David Marchand

Re: [RFC PATCH v2] net: 2-byte align packed headers

On Wed, Oct 30, 2024 at 1:35 PM Morten Brørup wrote: > > Recheck-request: iol-unit-amd64-testing It will need some rebase, regardless of the retest. -- David Marchand

Re: [PATCH v2 5/6] net: add smaller IPv4 cksum function for simple cases

s-of-packed-member compiler flag. > > Signed-off-by: Bruce Richardson > Acked-by: Stephen Hemminger > Acked-by: Morten Brørup This added function triggers a build error with OVS because of -Wcast-align: https://github.com/david-marchand/ovs/actions/runs/11401635820/job/32273090691#

Re: [PATCH v2] test/bitops: check worker lcore availability

On Fri, Oct 25, 2024 at 9:39 AM David Marchand wrote: > > Coverity is not able to understand that having 2 lcores means that > rte_get_next_lcore(-1, 0, 1) can't return RTE_MAX_LCORE. > Add a check. > > Coverity issue: 445382, 445383, 445384, 445387, 445389, 445391 > Fi

Re: [PATCH] app/dumpcap: replace use of __builtin_clzl

On Wed, Oct 16, 2024 at 10:52 PM Stephen Hemminger wrote: > > DPDK applications should avoid direct use of compiler builtin. > > Fixes: cbb44143be74 ("app/dumpcap: add new packet capture application") > > Signed-off-by: Stephen Hemminger Applied, thanks. -- David Marchand

Re: [PATCH v2 0/6] Clean up many __builtin_* in drivers.

On Fri, Oct 25, 2024 at 9:04 AM David Marchand wrote: > > Here is a series cleaning up most of uses of __builtin_* helpers in > drivers when they have a direct replacement in EAL. > > checkpatch is extended to forbid new additions. > > -- > David Marchand > > Chang

Re: [PATCH] bus/vmbus: remove unnecessary packed attribute

re exported as public headers. All those seem to be for use only in drivers, for resources attached on such a bus. Would an application benefit from talking directly to the hyperv? -- David Marchand

Re: [PATCH 0/3] eal: mark API's as stable

rsion.map| 10 -- > 4 files changed, 4 insertions(+), 22 deletions(-) Series applied, thanks Stephen. -- David Marchand

Re: [PATCH v3 0/3] Import Kernel uAPI header files

On Tue, Oct 29, 2024 at 3:42 PM David Marchand wrote: > > On Mon, Oct 28, 2024 at 4:48 PM Maxime Coquelin > wrote: > > > > This series enables importing Linux Kernel uAPI headers > > into the DPDK repository. It aims at solving alignment > > issues betwee

Re: [PATCH v1] config/x86: add lcore support for AMD EPYC Zen5 platforms

MD EPYC") > > As agreed earlier in mailing list, this patch adjusts the limit > for specific AMD EPYC target/cross builds. > > Signed-off-by: Sivaprasad Tummala Applied, thanks. -- David Marchand

Re: [PATCH] config/arm: fix warning for native build with meson >= 0.55

On Mon, Oct 28, 2024 at 2:11 PM David Marchand wrote: > > Caught in UNH logs for native compilation on ARM: > > Program /./dpdk/config/arm/armv8_machine.py found: YES > (/./dpdk/config/arm/armv8_machine.py) > WARNING: Project targeting '>= 0.57' but

Re: [PATCH v2 0/6] Reduce scope address-of-packed-member warning

eassembly.c| 4 +- > lib/net/rte_ip4.h| 32 > lib/pipeline/rte_table_action.c | 2 +- > lib/vhost/meson.build | 5 ++- > 14 files changed, 59 insertions(+), 154 deletions(-) Series applied, thanks Bruce. -- David Marchand

Re: [PATCH v3 0/3] Import Kernel uAPI header files

devtools/linux-uapi.sh +F: doc/guides/contributing/linux_uapi.rst +F: kernel/linux/uapi/ + Build System M: Bruce Richardson F: Makefile -- David Marchand

[PATCH] config/arm: fix warning for native build with meson >= 0.55

inimum meson version to 0.57") Signed-off-by: David Marchand --- config/arm/meson.build | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/config/arm/meson.build b/config/arm/meson.build index 55be7c8711..95500c8ed3 100644 --- a/config/arm/meson.build +++ b/conf

Re: [PATCH] net/i40e/base: fix invalid log format characters

re left at PRIu64. Change them to PRIu32, fixing the build when > additional format warnings were enabled. > > Fixes: cb593a832630 ("net/i40e/base: reduce size of time variables") > > Signed-off-by: Bruce Richardson Applied, thanks. -- David Marchand

Re: [PATCH 0/6] Reduce scope address-of-packed-member warning

On Fri, Oct 25, 2024 at 3:24 PM David Marchand wrote: > > On Thu, Oct 17, 2024 at 4:22 PM Bruce Richardson > wrote: > > > > The warning for address-of-packed-member was being disabled globally in > > DPDK. While for drivers which need to access hardware-defined >

Re: [PATCH 0/6] Reduce scope address-of-packed-member warning

_action.c | 2 +- > lib/vhost/meson.build| 5 ++- > 14 files changed, 60 insertions(+), 154 deletions(-) Recheck-request: rebase=main,iol-unit-amd64-testing,iol-unit-arm64-testing -- David Marchand

Re: [PATCH] net/i40e/base: fix invalid log format characters

re left at PRIu64. Change them to PRIu32, fixing the build when > additional format warnings were enabled. > > Fixes: cb593a832630 ("net/i40e/base: reduce size of time variables") > > Signed-off-by: Bruce Richardson Reviewed-by: David Marchand I'll wait for the CI the

Re: [PATCH v1 27/30] net/i40e/base: change time variables from 64 bit to 32 bit

On Thu, Oct 17, 2024 at 1:43 PM David Marchand wrote: > > On Mon, Sep 2, 2024 at 11:58 AM Anatoly Burakov > wrote: > > > > From: Jaroslaw Ilgiewicz > > > > Time variables were designed for 32 bit and 64 bit variables are not > > necessary. Changed all to

Re: [PATCH 4/6] crypto/openssl: fix 3DES-CTR with big endian CPUs

On Thu, Oct 24, 2024 at 3:17 PM David Marchand wrote: > @@ -1209,14 +1195,16 @@ process_openssl_cipher_des3ctr(struct rte_mbuf > *mbuf_src, uint8_t *dst, > l = rte_pktmbuf_data_len(m) - offset; > > memcpy(ctr, iv, 8); > + host_ctr = rte_be_64_to_cpu(ctr);

  1   2   3   4   5   6   7   8   9   10   >