[PATCH v4 4/4] net/sfc: add configurable Rx CRC stripping

2023-06-22 Thread Denis Pryazhennikov
should be removed from stats. Signed-off-by: Denis Pryazhennikov Signed-off-by: Roman Zhukov Reviewed-by: Andy Moreton Acked-by: Andrew Rybchenko --- doc/guides/nics/features/sfc.ini | 1 + doc/guides/nics/sfc_efx.rst| 6 -- doc/guides/rel_notes/release_23_07.rst | 2

[PATCH v4 3/4] common/sfc_efx/base: add support for configure MAC to keep FCS

2023-06-22 Thread Denis Pryazhennikov
Signed-off-by: Denis Pryazhennikov Reviewed-by: Andy Moreton Acked-by: Andrew Rybchenko --- drivers/common/sfc_efx/base/ef10_mac.c | 5 +-- drivers/common/sfc_efx/base/efx.h | 5 +++ drivers/common/sfc_efx/base/efx_impl.h | 1 + drivers/common/sfc_efx/base/efx_mac.c | 48

[PATCH v4 2/4] common/sfc_efx/base: detect and report FCS include support

2023-06-22 Thread Denis Pryazhennikov
From: Roman Zhukov A new variable was added to efx_nic_cfg_s to detect and report if FCS is supported by FW. Signed-off-by: Roman Zhukov Signed-off-by: Denis Pryazhennikov Reviewed-by: Viacheslav Galaktionov Acked-by: Andrew Rybchenko --- drivers/common/sfc_efx/base/ef10_nic.c | 6

[PATCH v4 0/4] net/sfc: support KEEP_CRC offload

2023-06-22 Thread Denis Pryazhennikov
This patch series adds support for RTE_ETH_RX_OFFLOAD_KEEP_CRC offload in the SFC driver. Changes in v2: * Applied review notes; * Fixed stats handling; * Added missing release notes to [4/4]. Changes in v3: * Fixed wrong indents in [1/4]. Changes in v4: * Fixed "From" section in [3/

[PATCH v4 1/4] common/sfc_efx/base: discover NIC partitioning mode

2023-06-22 Thread Denis Pryazhennikov
necessary action(s) for unprivileged adapter to work seamlessly. NIC Partitioning is determined using heuristic approach. If the physical ports are shared between PFs then either NIC Partitioning or SR-IOV is in use. Signed-off-by: Sandilya Bhagi Signed-off-by: Denis Pryazhennikov Reviewed-by: Andy

[PATCH v3 4/4] net/sfc: add configurable Rx CRC stripping

2023-06-22 Thread Denis Pryazhennikov
should be removed from stats. Signed-off-by: Denis Pryazhennikov Signed-off-by: Roman Zhukov Reviewed-by: Andy Moreton Acked-by: Andrew Rybchenko --- doc/guides/nics/features/sfc.ini | 1 + doc/guides/nics/sfc_efx.rst| 6 -- doc/guides/rel_notes/release_23_07.rst | 2

[PATCH v3 3/4] common/sfc_efx/base: add support for configure MAC to keep FCS

2023-06-22 Thread Denis Pryazhennikov
From: Roman Zhukov Signed-off-by: Denis Pryazhennikov Reviewed-by: Andy Moreton Acked-by: Andrew Rybchenko --- drivers/common/sfc_efx/base/ef10_mac.c | 5 +-- drivers/common/sfc_efx/base/efx.h | 5 +++ drivers/common/sfc_efx/base/efx_impl.h | 1 + drivers/common/sfc_efx/base/efx_mac.c

[PATCH v3 1/4] common/sfc_efx/base: discover NIC partitioning mode

2023-06-22 Thread Denis Pryazhennikov
necessary action(s) for unprivileged adapter to work seamlessly. NIC Partitioning is determined using heuristic approach. If the physical ports are shared between PFs then either NIC Partitioning or SR-IOV is in use. Signed-off-by: Sandilya Bhagi Signed-off-by: Denis Pryazhennikov Reviewed-by: Andy

[PATCH v3 2/4] common/sfc_efx/base: detect and report FCS include support

2023-06-22 Thread Denis Pryazhennikov
From: Roman Zhukov A new variable was added to efx_nic_cfg_s to detect and report if FCS is supported by FW. Signed-off-by: Roman Zhukov Signed-off-by: Denis Pryazhennikov Reviewed-by: Viacheslav Galaktionov Acked-by: Andrew Rybchenko --- drivers/common/sfc_efx/base/ef10_nic.c | 6

[PATCH v3 0/4] net/sfc: support KEEP_CRC offload

2023-06-22 Thread Denis Pryazhennikov
This patch series adds support for RTE_ETH_RX_OFFLOAD_KEEP_CRC offload in the SFC driver. Changes in v2: * Applied review notes; * Fixed stats handling; * Added missing release notes to [4/4]. Changes in v3: * Fixed wrong indents in [1/4]. Denis Pryazhennikov (3): common/sfc_efx/base: detect

[PATCH v2 4/4] net/sfc: add configurable Rx CRC stripping

2023-06-21 Thread Denis Pryazhennikov
should be removed from stats. Signed-off-by: Denis Pryazhennikov Signed-off-by: Roman Zhukov Reviewed-by: Andy Moreton --- doc/guides/nics/features/sfc.ini | 1 + doc/guides/nics/sfc_efx.rst| 6 -- doc/guides/rel_notes/release_23_07.rst | 2 ++ drivers/net/sfc/sfc.h

[PATCH v2 3/4] common/sfc_efx/base: add support for configure MAC to keep FCS

2023-06-21 Thread Denis Pryazhennikov
Signed-off-by: Denis Pryazhennikov Reviewed-by: Andy Moreton Acked-by: Andrew Rybchenko --- drivers/common/sfc_efx/base/ef10_mac.c | 5 +-- drivers/common/sfc_efx/base/efx.h | 5 +++ drivers/common/sfc_efx/base/efx_impl.h | 1 + drivers/common/sfc_efx/base/efx_mac.c | 48

[PATCH v2 2/4] common/sfc_efx/base: detect and report FCS include support

2023-06-21 Thread Denis Pryazhennikov
From: Roman Zhukov A new variable was added to efx_nic_cfg_s to detect and report if FCS is supported by FW. Signed-off-by: Roman Zhukov Signed-off-by: Denis Pryazhennikov Reviewed-by: Viacheslav Galaktionov Acked-by: Andrew Rybchenko --- drivers/common/sfc_efx/base/ef10_nic.c | 6

[PATCH v2 1/4] common/sfc_efx/base: discover NIC partitioning mode

2023-06-21 Thread Denis Pryazhennikov
necessary action(s) for unprivileged adapter to work seamlessly. BNIC Partitioning is determined using heuristic approach. If the physical ports are shared between PFs then either NIC Partitioning or SR-IOV is in use. Signed-off-by: Sandilya Bhagi Signed-off-by: Denis Pryazhennikov Reviewed-by: Andy

[PATCH v2 0/4] net/sfc: support KEEP_CRC offload

2023-06-21 Thread Denis Pryazhennikov
This patch series adds support for RTE_ETH_RX_OFFLOAD_KEEP_CRC offload in the SFC driver. Changes in v2: * Applied review notes; * Fixed stats handling; * Added missing release notes to [4/4]. Denis Pryazhennikov (3): common/sfc_efx/base: detect and report FCS include support common/sfc_efx

[PATCH v2 2/3] common/sfc_efx/base: add FEC related macros

2023-06-15 Thread Denis Pryazhennikov
Added new macros to simplify working with FEC bits. Signed-off-by: Denis Pryazhennikov Reviewed-by: Andy Moreton Acked-by: Andrew Rybchenko --- drivers/common/sfc_efx/base/efx.h | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/common/sfc_efx/base/efx.h b/drivers/common

[PATCH v2 3/3] net/sfc: support FEC feature

2023-06-15 Thread Denis Pryazhennikov
Support ethdev methods to query and set FEC information. Limitations: ignoring rte_eth_fec_get_capability() results can lead to NOFEC if the device is not strated. Signed-off-by: Denis Pryazhennikov Reviewed-by: Ivan Malov Reviewed-by: Andy Moreton Reviewed-by: Ferruh Yigit --- doc/guides

[PATCH v2 1/3] net/sfc: split link update function

2023-06-15 Thread Denis Pryazhennikov
Separate the original link update function into two functions: state retrieval and update. This improves code clarity and maintainability. Signed-off-by: Denis Pryazhennikov Reviewed-by: Ivan Malov Reviewed-by: Andy Moreton Acked-by: Andrew Rybchenko --- drivers/net/sfc/sfc_ethdev.c | 28

[PATCH v2 0/3] net/sfc: support FEC feature

2023-06-15 Thread Denis Pryazhennikov
sfc_fec_get_capa_speed_to_fec(); * Fixed error handling. Denis Pryazhennikov (3): net/sfc: split link update function common/sfc_efx/base: add FEC related macros net/sfc: support FEC feature doc/guides/nics/features/sfc.ini | 1 + doc/guides/rel_notes/release_23_07.rst | 6 + drivers

[PATCH 3/3] net/sfc: support FEC feature

2023-06-01 Thread Denis Pryazhennikov
Support ethdev methods to query and set FEC information. Limitations: ignoring rte_eth_fec_get_capability() results can lead to NOFEC if the device is not strated. Signed-off-by: Denis Pryazhennikov Reviewed-by: Ivan Malov Reviewed-by: Andy Moreton Reviewed-by: Ferruh Yigit --- doc/guides

[PATCH 2/3] common/sfc_efx/base: add FEC related macros

2023-06-01 Thread Denis Pryazhennikov
Added new macros to simplify working with FEC bits Signed-off-by: Denis Pryazhennikov Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/base/efx.h | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/common/sfc_efx/base/efx.h b/drivers/common/sfc_efx/base/efx.h index

[PATCH 1/3] net/sfc: split link update function

2023-06-01 Thread Denis Pryazhennikov
Separate the original link update function into two functions: state retrieval and update. This improves code clarity and maintainability. Signed-off-by: Denis Pryazhennikov Reviewed-by: Ivan Malov Reviewed-by: Andy Moreton --- drivers/net/sfc/sfc_ethdev.c | 28 +++- 1

[PATCH 0/3] net/sfc: support FEC feature

2023-06-01 Thread Denis Pryazhennikov
This patch series adds setting and querying of Forward error correction (FEC). AUTO, BASER and RS modes are supported by EF10/EF100 hardware. LLRS mode is not supported. Denis Pryazhennikov (3): net/sfc: split link update function common/sfc_efx/base: add FEC related macros net/sfc: support

[PATCH 4/4] net/sfc: add configurable Rx CRC stripping

2023-06-01 Thread Denis Pryazhennikov
Configurable Rx CRC stripping is allowed only if running firmware variant supports it and if NIC is configured with single PF per port and without VFs. Signed-off-by: Roman Zhukov Signed-off-by: Denis Pryazhennikov Reviewed-by: Andy Moreton --- doc/guides/nics/features/sfc.ini | 1 + doc

[PATCH 3/4] common/sfc_efx/base: add support for configure MAC to keep FCS

2023-06-01 Thread Denis Pryazhennikov
VFs or additional PFs); it can set the MAC configuration and it never expects packets it sends to be looped back then it can assume that changed the MAC configuration to include the FCS is safe and that all received packets will include their FCS. Signed-off-by: Roman Zhukov Signed-off-by: Denis

[PATCH 2/4] common/sfc_efx/base: detect and report FCS include support

2023-06-01 Thread Denis Pryazhennikov
A new variable was added to efx_nic_cfg_s to detect and report if FCS is supported by FW. Signed-off-by: Roman Zhukov Signed-off-by: Denis Pryazhennikov Reviewed-by: Viacheslav Galaktionov --- drivers/common/sfc_efx/base/ef10_nic.c | 6 ++ drivers/common/sfc_efx/base/efx.h | 1

[PATCH 1/4] common/sfc_efx/base: NIC Partitioning mode discovery using heuristic approach

2023-06-01 Thread Denis Pryazhennikov
seamlessly configure any valid MTU. hg-changeset: 7f0abee725a8e9c6524e773e5e5d6286a3b027a4 Signed-off-by: Sandilya Bhagi Signed-off-by: Denis Pryazhennikov Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/base/ef10_nic.c | 109 + drivers/common/sfc_efx/base/efx.h

[PATCH 0/4] net/sfc: support KEEP_CRC offload

2023-06-01 Thread Denis Pryazhennikov
This patch series adds support for RTE_ETH_RX_OFFLOAD_KEEP_CRC offload in the SFC driver. Denis Pryazhennikov (3): common/sfc_efx/base: detect and report FCS include support common/sfc_efx/base: add support for configure MAC to keep FCS net/sfc: add configurable Rx CRC stripping Sandilya

[RFC PATCH v2 3/3] ethdev: update documentation for API to get FEC

2023-05-08 Thread Denis Pryazhennikov
The documentation for the rte_eth_fec_get() is updated to clarify the description for the fec_capa parameter. The previous description implied that more than one FEC mode can be obtained. Signed-off-by: Denis Pryazhennikov --- lib/ethdev/rte_ethdev.h | 5 + 1 file changed, 1 insertion(+), 4

[RFC PATCH v2 1/3] ethdev: update documentation for API to set FEC

2023-05-08 Thread Denis Pryazhennikov
The documentation for the rte_eth_fec_set() is updated to provide more detailed information about how FEC modes are handled. It also includes a description of the case when only the AUTO bit is set. Signed-off-by: Denis Pryazhennikov Acked-by: Ivan Malov Acked-by: Viacheslav Galaktionov

[RFC PATCH v2 2/3] ethdev: check that at least one FEC mode is specified

2023-05-08 Thread Denis Pryazhennikov
The behaviour is undefined in the rte_eth_fec_set() function when the fec_capa parameter is equal to zero. Add a check to handle this case. Signed-off-by: Denis Pryazhennikov Acked-by: Ivan Malov Acked-by: Viacheslav Galaktionov --- lib/ethdev/rte_ethdev.c | 5 + 1 file changed, 5

[RFC PATCH v2 0/3] improve FEC API usage

2023-05-08 Thread Denis Pryazhennikov
er of rte_eth_fec_get() but add a proper description instead. Denis Pryazhennikov (3): ethdev: update documentation for API to set FEC ethdev: check that at least one FEC mode is specified ethdev: update documentation for API to get FEC lib/ethdev/rte_ethdev.c | 5 + lib/ethdev/rte_eth

Re: [RFC PATCH 3/3] ethdev: rename parameter in API to get FEC

2023-05-04 Thread Denis Pryazhennikov
aram, what do you think? Andrew Rybchenko asked to replace 'mode' with 'fec_capa' for 'rte_eth_fec_set()' in https://inbox.dpdk.org/dev/aa745bd1-a564-fa8c-c77b-2d99c9769...@solarflare.com/ I don't think we need to change it for rte_eth_fec_set(). On 5/2/23 7:02 PM, Fer

[RFC PATCH 3/3] ethdev: rename parameter in API to get FEC

2023-04-28 Thread Denis Pryazhennikov
Only one valid FEC mode can be get by rte_eth_fec_get(). The previous name implied that more than one FEC mode can be obtained. Documentation was updated accordingly. Signed-off-by: Denis Pryazhennikov Acked-by: Ivan Malov Acked-by: Viacheslav Galaktionov --- lib/ethdev/rte_ethdev.c | 8

[RFC PATCH 2/3] ethdev: check that at least one FEC mode is specified

2023-04-28 Thread Denis Pryazhennikov
The behaviour is undefined in the rte_eth_fec_set() function when the fec_capa parameter is equal to zero. Add a check to handle this case. Signed-off-by: Denis Pryazhennikov Acked-by: Ivan Malov Acked-by: Viacheslav Galaktionov --- lib/ethdev/rte_ethdev.c | 5 + 1 file changed, 5

[RFC PATCH 1/3] ethdev: update documentation for API to set FEC

2023-04-28 Thread Denis Pryazhennikov
The documentation for the rte_eth_fec_set() is updated to provide more detailed information about how FEC modes are handled. It also includes a description of the case when only the AUTO bit is set. Signed-off-by: Denis Pryazhennikov Acked-by: Ivan Malov Acked-by: Viacheslav Galaktionov

[RFC PATCH 0/3] improve FEC API usage

2023-04-28 Thread Denis Pryazhennikov
these issues, a patch series has been created that updates the FEC API documentation, renames one of the parameters to improve its clarity and adds a check for zero fec_capability. Denis Pryazhennikov (3): ethdev: update documentation for API to set FEC ethdev: check that at least one FEC mode

Clarify FEC capabilities

2023-04-11 Thread Denis Pryazhennikov
Hi, We are currently working on implementing the Forward Error Correction (FEC) feature in our driver, but we have encountered some difficulties in understanding the interpretation of the semantics of 'fec_capa', a bitmask of allowed FEC modes. Specifically, we are unclear about the meaning o

Clarify FEC capabilities

2023-04-07 Thread Denis Pryazhennikov
Hi, We are currently working on implementing the Forward Error Correction (FEC) feature in our driver, but we have encountered some difficulties in understanding the interpretation of the semantics of 'fec_capa', a bitmask of allowed FEC modes. Specifically, we are unclear about the meaning o