[PATCH v5] net/ark: fix index arithmetic bug

2024-07-17 Thread Ed Czeck
: 9ee9e0d3b85e ("net/ark: update to reflect FPGA updates") Cc: sta...@dpdk.org Signed-off-by: Ed Czeck --- v5: * fix typo in comment v4: * fix typo in comment v3: * Clarify commit message. int_32_t overflow is undefined, while uint32_t is defined as modulo. * Additional comments in code. v2

[PATCH v4] net/ark: fix index arithmetic bug

2024-07-17 Thread Ed Czeck
: 9ee9e0d3b85e ("net/ark: update to reflect FPGA updates") Cc: sta...@dpdk.org Signed-off-by: Ed Czeck --- v4: * fix typo in comment v3: * Clarify commit message. int_32_t overflow is undefined, while uint32_t is defined as modulo. * Additional comments in code. v2: * update patch to apply to

[PATCH v3] net/ark: fix index arithmetic bug

2024-07-17 Thread Ed Czeck
: 9ee9e0d3b85e ("net/ark: update to reflect FPGA updates") Cc: sta...@dpdk.org Signed-off-by: Ed Czeck --- v3: * Clarify commit message. int_32_t overflow is undefined, while uint32_t is defined as modulo. * Additional comments in code. v2: * update patch to apply to dpdk-next-net --- drive

[PATCH v2] net/ark: fix index arithmetic optimization bug

2024-07-16 Thread Ed Czeck
a...@dpdk.org Signed-off-by: Ed Czeck --- v2: * update patch to apply to dpdk-next-net --- drivers/net/ark/ark_ethdev_tx.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/net/ark/ark_ethdev_tx.c b/drivers/net/ark/ark_ethdev_tx.c index 9c89c85f50..3013

[PATCH] net/ark: fix index arithmetic optimization bug

2024-07-16 Thread Ed Czeck
a...@dpdk.org Signed-off-by: Ed Czeck --- drivers/net/ark/ark_ethdev_tx.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/net/ark/ark_ethdev_tx.c b/drivers/net/ark/ark_ethdev_tx.c index d02a786ee0..b387dadf80 100644 --- a/drivers/net/ark/ark_ethdev_tx.c

Re: [PATCH v9 15/23] net/ark: replace use of term sanity

2024-02-05 Thread Ed Czeck
44 > --- a/drivers/net/ark/ark_ethdev_rx.c > +++ b/drivers/net/ark/ark_ethdev_rx.c > @@ -283,7 +283,7 @@ eth_ark_recv_pkts(void *rx_queue, > mbuf->pkt_len = meta->pkt_len; > mbuf->data_len = meta->pkt_len; > > - if (ARK_DEBUG_CORE) { /* debug sanity checks */ > + if (ARK_DEBUG_CORE) { /* debug checks */ > > if ((meta->pkt_len > (1024 * 16)) || > (meta->pkt_len == 0)) { > -- > 2.43.0 > Acked-by: Ed Czeck

[PATCH] net/ark: add PCIe ids for Atomic Rules TK242 devices

2024-01-29 Thread Ed Czeck
Update documentation and release notes. Signed-off-by: Ed Czeck --- doc/guides/nics/ark.rst| 3 +++ doc/guides/rel_notes/release_24_03.rst | 4 drivers/net/ark/ark_ethdev.c | 3 +++ 3 files changed, 10 insertions(+) diff --git a/doc/guides/nics/ark.rst b/doc

[PATCH v2 3/3] net/ark: support for large dataroom in FPGA

2023-10-10 Thread Ed Czeck
Allow for non-standard dataroom sizes for upstream data motion when using a custom mbuf pool. - New firmware version for UDM (Upstream Data Mover) - New layout on ark_rx_meta data Signed-off-by: Ed Czeck --- doc/guides/nics/ark.rst | 1 + drivers/net/ark/ark_ethdev_rx.c | 8

[PATCH v2 2/3] net/ark: remove RQ pacing firmware from PMD

2023-10-10 Thread Ed Czeck
features and function have been removed from FPGA firmware Signed-off-by: Ed Czeck --- v2: * restore previously incorrectly deleted line --- drivers/net/ark/ark_ethdev.c | 60 --- drivers/net/ark/ark_global.h | 3 -- drivers/net/ark/ark_rqp.c| 70

[PATCH v2 1/3] net/ark: support for single function with multiple port

2023-10-10 Thread Ed Czeck
. Fixes: 6799275eeea6 ("net/ark: support virtual functions") Cc: sta...@dpdk.org Backporting is not requested. Signed-off-by: Ed Czeck --- drivers/net/ark/ark_ethdev.c| 15 ++- drivers/net/ark/ark_ethdev_rx.c | 6 +++--- drivers/net/ark/ark_ethdev_tx.c | 2 +- drive

[PATCH v2 2/3] net/ark: remove RQ pacing firmware from PMD

2023-10-10 Thread Ed Czeck
features and function have been removed from FPGA firmware Signed-off-by: Ed Czeck --- v2: * restore previously incorrectly deleted line --- drivers/net/ark/ark_ethdev.c | 60 --- drivers/net/ark/ark_global.h | 3 -- drivers/net/ark/ark_rqp.c| 70

Re: [PATCH 2/3] net/ark: remove RQ pacing firmware from PMD

2023-10-10 Thread Ed Czeck
On Tue, Oct 10, 2023 at 9:51 AM Ferruh Yigit wrote: > > On 10/5/2023 9:52 PM, Ed Czeck wrote: > > features and function have been removed from FPGA firmware > > > > I am always a little confused how you manage the deployment, if a > customer requires RQ pacing, how you

[PATCH 3/3] net/ark: support for large dataroom in FPGA

2023-10-05 Thread Ed Czeck
Allow for non-standard dataroom sizes for upstream data motion when using a custom mbuf pool. - New firmware version for UDM (Upstream Data Mover) - New layout on ark_rx_meta data Signed-off-by: Ed Czeck --- doc/guides/nics/ark.rst | 1 + drivers/net/ark/ark_ethdev_rx.c | 8

[PATCH 2/3] net/ark: remove RQ pacing firmware from PMD

2023-10-05 Thread Ed Czeck
features and function have been removed from FPGA firmware Signed-off-by: Ed Czeck --- drivers/net/ark/ark_ethdev.c | 62 drivers/net/ark/ark_global.h | 3 -- drivers/net/ark/ark_rqp.c| 70 drivers/net/ark/ark_rqp.h

[PATCH 1/3] net/ark: support for single function with multiple port

2023-10-05 Thread Ed Czeck
. Fixes: 6799275eeea6 ("net/ark: support virtual functions") Cc: sta...@dpdk.org Backporting is not requested. Signed-off-by: Ed Czeck --- drivers/net/ark/ark_ethdev.c| 15 ++- drivers/net/ark/ark_ethdev_rx.c | 6 +++--- drivers/net/ark/ark_ethdev_tx.c | 2 +- drive

[PATCH v4] net/ark: support for single function with multiple port

2023-02-21 Thread Ed Czeck
Support the creation of multiple ports from one ark device via the use of ark pmd extension, though the assignment of queues to port. Add unique dev_private data for each port. This patch repairs a latent issue uncovered during testing. Signed-off-by: Ed Czeck --- v3: * Backport to LTS version

[PATCH v3 2/2] net/ark: support for single function with multiple port

2023-02-20 Thread Ed Czeck
Allows the creation of multiple ports from one ark device via the use of ark pmd extension, though the splitting of queues Add unique dev_private data for each port. Signed-off-by: Ed Czeck --- v3: * Backport to LTS version is not recommended since firmware changes are required and limited

[PATCH v3 1/2] net/ark: limited support for secondary processes

2023-02-20 Thread Ed Czeck
From: John Miller disable fpga device configuration for secondary processes. This is minimum support to avoid unneeded fpga resets Signed-off-by: John Miller Signed-off-by: Ed Czeck --- v2: * Use standard logging v3: * clarify limits on secondary process support --- drivers/net/ark

Re: [PATCH v2 2/3] net/ark: support for single function with multiple port

2023-02-20 Thread Ed Czeck
n 2/17/2023 9:59 PM, Ed Czeck wrote: > > allows the creation of multiple ports from one ark device via > > the use of ark pmd extension, though the splitting of queues > > Hi Ed, > > As far as I can see "single function with multiple port" support was > already the

Re: [PATCH v2 1/3] net/ark: support secondary process

2023-02-20 Thread Ed Czeck
for the review. Ed. On Mon, Feb 20, 2023 at 9:17 AM Ferruh Yigit wrote: > On 2/17/2023 9:59 PM, Ed Czeck wrote: > > From: John Miller > > > > disable device configuration for secondary processes > > > > Signed-off-by: John Miller > > --- > > v2: &g

[PATCH v2 3/3] net/ark: resize data field to match fpga access

2023-02-17 Thread Ed Czeck
all fpga accesses are multiples of 4 bytes Signed-off-by: Ed Czeck --- drivers/net/ark/ark_mpu.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ark/ark_mpu.h b/drivers/net/ark/ark_mpu.h index 9d2b70d35f..10842ba484 100644 --- a/drivers/net/ark/ark_mpu.h +++ b

[PATCH v2 2/3] net/ark: support for single function with multiple port

2023-02-17 Thread Ed Czeck
allows the creation of multiple ports from one ark device via the use of ark pmd extension, though the splitting of queues Add unique dev_private data for each port Signed-off-by: Ed Czeck --- drivers/net/ark/ark_ethdev.c| 14 +- drivers/net/ark/ark_ethdev_rx.c | 6

[PATCH v2 1/3] net/ark: support secondary process

2023-02-17 Thread Ed Czeck
From: John Miller disable device configuration for secondary processes Signed-off-by: John Miller --- v2: * Use standard logging --- drivers/net/ark/ark_ethdev.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_e

[PATCH] net/ark: resize data field to match fpga access

2023-02-17 Thread Ed Czeck
all fpga accesses are multiples of 4 bytes Signed-off-by: Ed Czeck --- drivers/net/ark/ark_mpu.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ark/ark_mpu.h b/drivers/net/ark/ark_mpu.h index 9d2b70d35f..10842ba484 100644 --- a/drivers/net/ark/ark_mpu.h +++ b

[PATCH 3/3] net/ark: resize data field to match fpga access

2023-02-17 Thread Ed Czeck
all fpga accesses are multiples of 4 bytes Signed-off-by: Ed Czeck --- drivers/net/ark/ark_mpu.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ark/ark_mpu.h b/drivers/net/ark/ark_mpu.h index 9d2b70d35f..10842ba484 100644 --- a/drivers/net/ark/ark_mpu.h +++ b

[PATCH 2/3] net/ark: support for single function with multiple port

2023-02-17 Thread Ed Czeck
allows the creation of multiple ports from one ark device via the use of ark pmd extension, though the splitting of queues Add unique dev_private data for each port Signed-off-by: Ed Czeck --- drivers/net/ark/ark_ethdev.c| 14 +- drivers/net/ark/ark_ethdev_rx.c | 6

[PATCH 1/3] net/ark: support secondary process

2023-02-17 Thread Ed Czeck
From: John Miller disable device configuration for secondary processes Signed-off-by: John Miller --- drivers/net/ark/ark_ethdev.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c index b2995427c8..f9672

[PATCH] net/ark: resize data field to match fpga access

2023-02-17 Thread Ed Czeck
all fpga acces are multiples of 4 bytes Signed-off-by: Ed Czeck --- drivers/net/ark/ark_mpu.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ark/ark_mpu.h b/drivers/net/ark/ark_mpu.h index 9d2b70d35f..10842ba484 100644 --- a/drivers/net/ark/ark_mpu.h +++ b

[PATCH 3/3] net/ark: resize data field to match fpga access

2023-02-17 Thread Ed Czeck
all fpga acces are multiples of 4 bytes Signed-off-by: Ed Czeck --- drivers/net/ark/ark_mpu.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ark/ark_mpu.h b/drivers/net/ark/ark_mpu.h index 9d2b70d35f..10842ba484 100644 --- a/drivers/net/ark/ark_mpu.h +++ b

[PATCH 2/3] net/ark: support for single function with multiple port

2023-02-17 Thread Ed Czeck
allows the creation of multiple ports from one ark device via the use of ark pmd extension, though the splitting of queues Add unique dev_private data for each port Signed-off-by: Ed Czeck --- drivers/net/ark/ark_ethdev.c| 14 +- drivers/net/ark/ark_ethdev_rx.c | 6

[PATCH 1/3] net/ark: support secondary process

2023-02-17 Thread Ed Czeck
From: John Miller disable device configuration for secondary processes Signed-off-by: John Miller --- drivers/net/ark/ark_ethdev.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c index b2995427c8..f9672

[PATCH v4 7/7] net/ark: add PMD support for devices as virtual functions

2022-06-07 Thread Ed Czeck
Add capabilities field isvf to dev struct Disable configuration calls as required by vf Signed-off-by: Ed Czeck --- v2: feature Arkville vf support in release notes v3: feature new PCI device ids in release notes v4: split release note --- doc/guides/rel_notes/release_22_07.rst | 2 + drivers

[PATCH v4 6/7] net/ark: add new devices to support list

2022-06-07 Thread Ed Czeck
update device list is doc Signed-off-by: Ed Czeck --- v3: clarification in doc for LTS support v4: mention nee devices in release notes --- doc/guides/nics/ark.rst| 4 +++- doc/guides/rel_notes/release_22_07.rst | 2 ++ drivers/net/ark/ark_ethdev.c | 6 ++ 3 files

[PATCH v4 5/7] net/ark: report additional errors from firmware

2022-06-07 Thread Ed Czeck
detect and report completion errors from firmware Signed-off-by: Ed Czeck --- drivers/net/ark/ark_rqp.c | 6 -- drivers/net/ark/ark_rqp.h | 3 ++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/net/ark/ark_rqp.c b/drivers/net/ark/ark_rqp.c index ef9ccd0706

[PATCH v4 4/7] net/ark: update UDM functions for firmware update

2022-06-07 Thread Ed Czeck
new firmware version for UDM (Upstream Data Mover) remove device-level start, stop, and reset operations add queue-based start, stop and reset as required by firmware remove performance structs as they are not in the firmware module Signed-off-by: Ed Czeck --- v2: reword commit message v3

[PATCH v4 3/7] net/ark: update DDM functions for firmware update

2022-06-07 Thread Ed Czeck
new firmware version for DDM (Downstream Data Mover) remove device-level start, stop, and reset operations add queue-based start, stop and reset as required by firmware Signed-off-by: Ed Czeck --- v2: reword commit message --- drivers/net/ark/ark_ddm.c | 80

[PATCH v4 2/7] net/ark: update MPU functions for firmware update

2022-06-07 Thread Ed Czeck
new firmware version for MPU (Mbuf Prefetch Unit) remove device-level global operations remove ark_mpu_reset_stats function Signed-off-by: Ed Czeck --- v2: - document version compatibility between firmware and DPDK - reword commit message v4: - clarify version compatibility note - firmware

[PATCH v4 1/7] devtools: add Atomic Rules acronyms for commit checks

2022-06-07 Thread Ed Czeck
DDM -> Downstream Data Mover MPU -> Mbuf Prefetch Unit UDM -> Upstream Data Mover Signed-off-by: Ed Czeck --- devtools/words-case.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/devtools/words-case.txt b/devtools/words-case.txt index 2f1753bdc8..53e029a958 100644 --- a/devto

[PATCH v3 7/7] net/ark: add PMD support for devices as virtual functions

2022-06-07 Thread Ed Czeck
Add capabilities field isvf to dev struct Disable configuration calls as required by vf Signed-off-by: Ed Czeck --- v2: feature Arkville vf support in release notes v3: feature new PCI device ids in release notes --- doc/guides/rel_notes/release_22_07.rst | 5 ++ drivers/net/ark/ark_ethdev.c

[PATCH v3 6/7] net/ark: add new devices to support list

2022-06-07 Thread Ed Czeck
update device list is doc Signed-off-by: Ed Czeck --- v3: clarification in doc for LTS support --- doc/guides/nics/ark.rst | 7 +-- drivers/net/ark/ark_ethdev.c | 6 ++ 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/doc/guides/nics/ark.rst b/doc/guides/nics

[PATCH v3 5/7] net/ark: report additional errors from firmware

2022-06-07 Thread Ed Czeck
detect and report completion errors from firmware Signed-off-by: Ed Czeck --- drivers/net/ark/ark_rqp.c | 6 -- drivers/net/ark/ark_rqp.h | 3 ++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/net/ark/ark_rqp.c b/drivers/net/ark/ark_rqp.c index ef9ccd0706

[PATCH v3 4/7] net/ark: update UDM functions for firmware update

2022-06-07 Thread Ed Czeck
new firmware version for UDM (Upstream Data Mover) remove device-level start, stop, and reset operations add queue-based start, stop and reset as required by firmware remove performance structs as they are not in the firmware module Signed-off-by: Ed Czeck --- v2: reword commit message v3

[PATCH v3 3/7] net/ark: update DDM functions for firmware update

2022-06-07 Thread Ed Czeck
new firmware version for DDM (Downstream Data Mover) remove device-level start, stop, and reset operations add queue-based start, stop and reset as required by firmware Signed-off-by: Ed Czeck --- v2: reword commit message --- drivers/net/ark/ark_ddm.c | 80

[PATCH v3 2/7] net/ark: update MPU functions for firmware update

2022-06-07 Thread Ed Czeck
new firmware version for MPU (Mbuf Prefetch Unit) remove device-level global operations remove ark_mpu_reset_stats function Signed-off-by: Ed Czeck --- v2: - document version compatibility between firmware and DPDK - reword commit message --- doc/guides/nics/ark.rst | 15

[PATCH v3 1/7] devtools: add Atomic Rules acronyms for commit checks

2022-06-07 Thread Ed Czeck
DDM -> Downstream Data Mover MPU -> Mbuf Prefetch Unit UDM -> Upstream Data Mover Signed-off-by: Ed Czeck --- devtools/words-case.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/devtools/words-case.txt b/devtools/words-case.txt index bc33470532..fa92ab273e 100644 --- a/devto

[PATCH v2 7/7] net/ark: add PMD support for devices as virtual functions

2022-05-20 Thread Ed Czeck
Add capabilities field isvf to dev struct Disable configuration calls as required by vf Signed-off-by: Ed Czeck --- v2: feature Arkville vf support int release notes --- doc/guides/rel_notes/release_22_07.rst | 4 ++ drivers/net/ark/ark_ethdev.c | 83

[PATCH v2 6/7] net/ark: add new devices to support list

2022-05-20 Thread Ed Czeck
update device list is doc Signed-off-by: Ed Czeck --- doc/guides/nics/ark.rst | 4 +++- drivers/net/ark/ark_ethdev.c | 6 ++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/doc/guides/nics/ark.rst b/doc/guides/nics/ark.rst index 29c0a07d60..f4ffb05b2f 100644 --- a/doc

[PATCH v2 5/7] net/ark: report additional errors from firmware

2022-05-20 Thread Ed Czeck
detect and report completion errors from firmware Signed-off-by: Ed Czeck --- drivers/net/ark/ark_rqp.c | 6 -- drivers/net/ark/ark_rqp.h | 3 ++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/net/ark/ark_rqp.c b/drivers/net/ark/ark_rqp.c index ef9ccd0706

[PATCH v2 4/7] net/ark: update UDM functions for firmware update

2022-05-20 Thread Ed Czeck
new firmware version for UDM (Upstream Data Mover) remove device-level start, stop, and reset operations add queue-based start, stop and reset as required by firmware remove performance structs as they are not in the firmware module Signed-off-by: Ed Czeck --- v2: reword commit message

[PATCH v2 3/7] net/ark: update DDM functions for firmware update

2022-05-20 Thread Ed Czeck
new firmware version for DDM (Downstream Data Mover) remove device-level start, stop, and reset operations add queue-based start, stop and reset as required by firmware Signed-off-by: Ed Czeck --- v2: reword commit message --- drivers/net/ark/ark_ddm.c | 80

[PATCH v2 2/7] net/ark: update MPU functions for firmware update

2022-05-20 Thread Ed Czeck
new firmware version for MPU (Mbuf Prefetch Unit) remove device-level global operations remove ark_mpu_reset_stats function Signed-off-by: Ed Czeck --- v2: - document version compatibility between firmware and DPDK - reword commit message --- doc/guides/nics/ark.rst | 15

[PATCH v2 1/7] devtools: add Atomic Rules acronyms for commit checks

2022-05-20 Thread Ed Czeck
DDM -> Downstream Data Mover MPU -> Mbuf Prefetch Unit UDM -> Upstream Data Mover Signed-off-by: Ed Czeck --- devtools/words-case.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/devtools/words-case.txt b/devtools/words-case.txt index bc33470532..fa92ab273e 100644 --- a/devto

[PATCH v2 7/7] net/ark: add PMD support for devices as virtual functions

2022-05-19 Thread Ed Czeck
Add capabilities field isvf to dev struct Disable configuration calls as required by vf Signed-off-by: Ed Czeck --- v2: feature Arkville vf support int release notes --- doc/guides/rel_notes/release_22_07.rst | 4 ++ drivers/net/ark/ark_ethdev.c | 83

[PATCH v2 6/7] net/ark: add new devices to support list

2022-05-19 Thread Ed Czeck
update device list is doc Signed-off-by: Ed Czeck --- doc/guides/nics/ark.rst | 4 +++- drivers/net/ark/ark_ethdev.c | 6 ++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/doc/guides/nics/ark.rst b/doc/guides/nics/ark.rst index 29c0a07d60..f4ffb05b2f 100644 --- a/doc

[PATCH v2 5/7] net/ark: report additional errors from firmware

2022-05-19 Thread Ed Czeck
detect and report completion errors from firmware Signed-off-by: Ed Czeck --- drivers/net/ark/ark_rqp.c | 6 -- drivers/net/ark/ark_rqp.h | 3 ++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/net/ark/ark_rqp.c b/drivers/net/ark/ark_rqp.c index ef9ccd0706

[PATCH v2 4/7] net/ark: update UDM functions for firmware update

2022-05-19 Thread Ed Czeck
new firmware version for UDM (Upstream Data Mover) remove device-level start, stop, and reset operations add queue-based start, stop and reset as required by firmware remove performance structs as they are not in the firmware module Signed-off-by: Ed Czeck --- v2: reword commit message

[PATCH v2 3/7] net/ark: update DDM functions for firmware update

2022-05-19 Thread Ed Czeck
new firmware version for DDM (Downstream Data Mover) remove device-level start, stop, and reset operations add queue-based start, stop and reset as required by firmware Signed-off-by: Ed Czeck --- v2: reword commit message --- drivers/net/ark/ark_ddm.c | 80

[PATCH v2 2/7] net/ark: update MPU functions for firmware update

2022-05-19 Thread Ed Czeck
new firmware version for MPU (Mbuf Prefetch Unit) remove device-level global operations remove ark_mpu_reset_stats function Signed-off-by: Ed Czeck --- v2: - document version compatibility between firmware and DPDK - reword commit message --- doc/guides/nics/ark.rst | 15

[PATCH v2 1/7] devtools: add Atomic Rules acronyms for commit checks

2022-05-19 Thread Ed Czeck
DDM -> Downstream Data Mover MPU -> Mbuf Prefetch Unit UDM -> Upstream Data Mover Signed-off-by: Ed Czeck --- devtools/words-case.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/devtools/words-case.txt b/devtools/words-case.txt index bc33470532..fa92ab273e 100644 --- a/devto

[PATCH v1 5/5] net/ark: add PMD support for devices as virtual functions

2022-05-06 Thread Ed Czeck
Add capabilities field isvf to dev struct Disable configuration calls as required by vf Signed-off-by: Ed Czeck --- drivers/net/ark/ark_ethdev.c | 79 drivers/net/ark/ark_global.h | 1 + 2 files changed, 45 insertions(+), 35 deletions(-) diff --git a

[PATCH v1 4/5] net/ark: add new devices to support list

2022-05-06 Thread Ed Czeck
update device list is doc Signed-off-by: Ed Czeck --- doc/guides/nics/ark.rst | 4 +++- drivers/net/ark/ark_ethdev.c | 6 ++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/doc/guides/nics/ark.rst b/doc/guides/nics/ark.rst index c965406a7b..cec6fce2ff 100644 --- a/doc

[PATCH v1 3/5] net/ark: update udm code to match current hardware version

2022-05-06 Thread Ed Czeck
new version code remove device-level start, stop, and reset operations add queue-based start, stop and reset as required by hardware remove performance structs as they are not in the hardware module Signed-off-by: Ed Czeck --- drivers/net/ark/ark_ethdev.c| 34 +-- drivers/net/ark

[PATCH v1 2/5] net/ark: update ddm code to match current hardware version

2022-05-06 Thread Ed Czeck
new version code remove device-level start, stop, and reset operations add queue-based start, stop and reset as required by hardware Signed-off-by: Ed Czeck --- drivers/net/ark/ark_ddm.c | 80 +- drivers/net/ark/ark_ddm.h | 86

[PATCH v1 1/5] net/ark: update mpu code to match current hardware version

2022-05-06 Thread Ed Czeck
new version code remove device-level global operations remove ark_mpu_reset_stats function Signed-off-by: Ed Czeck --- drivers/net/ark/ark_ethdev.c| 2 -- drivers/net/ark/ark_ethdev_rx.c | 4 drivers/net/ark/ark_mpu.c | 21 - drivers/net/ark/ark_mpu.h

[PATCH v1 5/5] net/ark: add PMD support for devices as virtual functions

2022-05-05 Thread Ed Czeck
Add capabilities field isvf to dev struct Disable configuration calls as required by vf Signed-off-by: Ed Czeck --- drivers/net/ark/ark_ethdev.c | 79 drivers/net/ark/ark_global.h | 1 + 2 files changed, 45 insertions(+), 35 deletions(-) diff --git a

[PATCH v1 4/5] net/ark: add new devices to support list

2022-05-05 Thread Ed Czeck
update device list is doc Signed-off-by: Ed Czeck --- doc/guides/nics/ark.rst | 4 +++- drivers/net/ark/ark_ethdev.c | 6 ++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/doc/guides/nics/ark.rst b/doc/guides/nics/ark.rst index c965406a7b..cec6fce2ff 100644 --- a/doc

[PATCH v1 3/5] net/ark: update udm code to match current hardware version

2022-05-05 Thread Ed Czeck
new version code remove device-level start, stop, and reset operations add queue-based start, stop and reset as required by hardware remove performance structs as they are not in the hardware module Signed-off-by: Ed Czeck --- drivers/net/ark/ark_ethdev.c| 34 +-- drivers/net/ark

[PATCH v1 2/5] net/ark: update ddm code to match current hardware version

2022-05-05 Thread Ed Czeck
new version code remove device-level start, stop, and reset operations add queue-based start, stop and reset as required by hardware Signed-off-by: Ed Czeck --- drivers/net/ark/ark_ddm.c | 80 +- drivers/net/ark/ark_ddm.h | 86

[PATCH v1 1/5] net/ark: update mpu code to match current hardware version

2022-05-05 Thread Ed Czeck
new version code remove device-level global operations remove ark_mpu_reset_stats function Signed-off-by: Ed Czeck --- drivers/net/ark/ark_ethdev.c| 2 -- drivers/net/ark/ark_ethdev_rx.c | 4 drivers/net/ark/ark_mpu.c | 21 - drivers/net/ark/ark_mpu.h

[PATCH 4/4] net/ark: add new devices to support list

2022-05-02 Thread Ed Czeck
update device list is doc Signed-off-by: Ed Czeck --- doc/guides/nics/ark.rst | 4 +++- drivers/net/ark/ark_ethdev.c | 6 ++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/doc/guides/nics/ark.rst b/doc/guides/nics/ark.rst index c965406a7b..cec6fce2ff 100644 --- a/doc

[PATCH 3/4] net/ark: update udm code to match current hardware version

2022-05-02 Thread Ed Czeck
new version code remove device-level start, stop, and reset operations add queue-based start, stop and reset as required by hardware remove performance structs as they are not in the hardware module Signed-off-by: Ed Czeck --- drivers/net/ark/ark_ethdev.c| 34 +-- drivers/net/ark

[PATCH 2/4] net/ark: update ddm code to match current hardware version

2022-05-02 Thread Ed Czeck
new version code remove device-level start, stop, and reset operations add queue-based start, stop and reset as required by hardware Signed-off-by: Ed Czeck --- drivers/net/ark/ark_ddm.c | 80 + drivers/net/ark/ark_ddm.h | 30 +++-- drivers

[PATCH 1/4] net/ark: update mpu code to match current hardware version

2022-05-02 Thread Ed Czeck
new version code remove device-level global operations remove ark_mpu_reset_stats function Signed-off-by: Ed Czeck --- drivers/net/ark/ark_ethdev.c| 2 -- drivers/net/ark/ark_ethdev_rx.c | 4 drivers/net/ark/ark_mpu.c | 15 --- drivers/net/ark/ark_mpu.h | 3

Re: [dpdk-dev] [PATCH 1/2] net/ark: fix bug introduced during thread name addition

2021-05-11 Thread Ed Czeck
There is only one patch for this submission. (The second one remains under development). Thanks, On Tue, May 11, 2021 at 6:50 PM Ferruh Yigit wrote: > On 5/11/2021 11:48 PM, Ferruh Yigit wrote: > > On 5/11/2021 9:58 PM, Ed Czeck wrote: > >> Fixes: fdefe038eb9b ("net/a

[dpdk-dev] [PATCH 1/2] net/ark: fix bug introduced during thread name addition

2021-05-11 Thread Ed Czeck
Fixes: fdefe038eb9b ("net/ark: set generator delay thread name") Cc: fengcheng...@huawei.com Signed-off-by: Ed Czeck --- drivers/net/ark/ark_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c index

Re: [dpdk-dev] [PATCH 1/2] net/ark: fix leak on thread termination

2021-05-11 Thread Ed Czeck
Thank you. Acked-by: Ed Czeck On Thu, May 6, 2021 at 5:45 AM David Marchand wrote: > A terminated pthread should be joined or detached so that its associated > resources are released. > > The "ark-delay-pg" thread is just used to delay some task but it is never >

[dpdk-dev] [PATCH v5 6/6] net/ark: localize internal packet generator code

2021-03-18 Thread Ed Czeck
remove unnecessary includes no functional changes Signed-off-by: Ed Czeck --- drivers/net/ark/ark_ethdev.c | 17 ++--- drivers/net/ark/ark_pktchkr.c | 4 drivers/net/ark/ark_pktgen.c | 20 ++-- drivers/net/ark/ark_pktgen.h | 1 + 4 files changed, 17

[dpdk-dev] [PATCH v5 5/6] net/ark: generalize meta data between FPGA and PMD

2021-03-18 Thread Ed Czeck
paths - Update guide with example of hook function use - Add release notes Signed-off-by: Ed Czeck --- v3: - split function rename to separate commit v4: - reorder patches renaming before adding v5: - remove rte_pmd_ark.h --- doc/api/doxy-api-index.md | 1 - doc/guides/nics

[dpdk-dev] [PATCH v5 4/6] net/ark: cleanup ark dynamic extension interface

2021-03-18 Thread Ed Czeck
- Rename extension functions with rte_pmd_ark prefix - Update local function documentation Signed-off-by: Ed Czeck --- v3: - split function rename from previous commit v4: - reorder patches renaming before adding v5: - Keep the extension function changes in ark_ext.h --- drivers/net/ark

[dpdk-dev] [PATCH v5 3/6] net/ark: update internal structs to reflect FPGA updates

2021-03-18 Thread Ed Czeck
- New PCIe IDs using net/ark driver - Update Version IDs and structures specified by hardware - New internal descriptor status for TX - Adjust data placement in RX operations, headroom in retained for segmented mbufs Signed-off-by: Ed Czeck --- doc/guides/nics/ark.rst | 5 ++ drivers

[dpdk-dev] [PATCH v5 2/6] net/ark: refactor Rx buffer recovery

2021-03-18 Thread Ed Czeck
Allocate mbufs for Rx path in bulk of at least 64 buffers to improve performance. Allow recovery even without a Rx operation to support lack of buffers in pool. Fixes: be410a861598 ("net/ark: add recovery for lack of mbufs") Cc: sta...@dpdk.org Signed-off-by: Ed Czeck --- drive

[dpdk-dev] [PATCH v5 1/6] net/ark: update pkt director initial state

2021-03-18 Thread Ed Czeck
Fixes: b33ccdb17f55 ("net/ark: provide API for hardware modules MPU RQP and pktdir") Cc: sta...@dpdk.org Signed-off-by: Ed Czeck --- drivers/net/ark/ark_ethdev.c | 1 + drivers/net/ark/ark_pktdir.c | 2 +- drivers/net/ark/ark_pktdir.h | 2 +- 3 files changed, 3 insertions(+), 2

Re: [dpdk-dev] [PATCH v4 5/6] net/ark: generalize meta data between FPGA and PMD

2021-03-11 Thread Ed Czeck
On Wed, Mar 10, 2021 at 5:46 PM Ferruh Yigit wrote: > > On 3/10/2021 9:53 PM, Ed Czeck wrote: > > On Wed, Mar 10, 2021 at 11:44 AM Ferruh Yigit > > wrote: > >> > >> On 3/10/2021 3:02 PM, Ed Czeck wrote: > >>> On Tue, Mar 9, 2021 at 12:36 PM Ferru

Re: [dpdk-dev] [PATCH v4 5/6] net/ark: generalize meta data between FPGA and PMD

2021-03-10 Thread Ed Czeck
On Wed, Mar 10, 2021 at 11:44 AM Ferruh Yigit wrote: > > On 3/10/2021 3:02 PM, Ed Czeck wrote: > > On Tue, Mar 9, 2021 at 12:36 PM Ferruh Yigit wrote: > >> > >> On 3/9/2021 4:08 PM, Ed Czeck wrote: > >>> In this commit we generalize the movement of us

Re: [dpdk-dev] [PATCH v4 4/6] net/ark: cleanup ark dynamic extension interface

2021-03-10 Thread Ed Czeck
On Tue, Mar 9, 2021 at 12:50 PM Ferruh Yigit wrote: > > On 3/9/2021 4:08 PM, Ed Czeck wrote: > > - Rename extension functions with rte_pmd_ark prefix > > - Move extension prototype to rte_pmd_ark.h > > - Update local function documentation > > > > Sig

Re: [dpdk-dev] [PATCH v4 5/6] net/ark: generalize meta data between FPGA and PMD

2021-03-10 Thread Ed Czeck
On Tue, Mar 9, 2021 at 12:36 PM Ferruh Yigit wrote: > > On 3/9/2021 4:08 PM, Ed Czeck wrote: > > In this commit we generalize the movement of user-specified > > meta data between mbufs and FPGA AXIS tuser fields using > > user-defined hook functions. > > > >

[dpdk-dev] [PATCH v4 6/6] net/ark: localize internal packet generator code

2021-03-09 Thread Ed Czeck
remove unnecessary includes no functional changes Signed-off-by: Ed Czeck --- drivers/net/ark/ark_ethdev.c | 17 ++--- drivers/net/ark/ark_pktchkr.c | 4 drivers/net/ark/ark_pktgen.c | 20 ++-- drivers/net/ark/ark_pktgen.h | 1 + 4 files changed, 17

[dpdk-dev] [PATCH v4 5/6] net/ark: generalize meta data between FPGA and PMD

2021-03-09 Thread Ed Czeck
example of hook function use - Add release notes Signed-off-by: Ed Czeck --- v3: - split function rename to separate commit v4: - reorder patches renaming before adding - --- doc/guides/nics/ark.rst| 139 ++- doc/guides/rel_notes/release_21_05.rst | 11

[dpdk-dev] [PATCH v4 4/6] net/ark: cleanup ark dynamic extension interface

2021-03-09 Thread Ed Czeck
- Rename extension functions with rte_pmd_ark prefix - Move extension prototype to rte_pmd_ark.h - Update local function documentation Signed-off-by: Ed Czeck --- v3: - split function rename from previous commit v4: - reorder patches renaming before adding --- drivers/net/ark/ark_ethdev.c

[dpdk-dev] [PATCH v4 3/6] net/ark: update internal structs to reflect FPGA updates

2021-03-09 Thread Ed Czeck
- New PCIe IDs using net/ark driver - Update Version IDs and structures specified by hardware - New internal descriptor status for TX - Adjust data placement in RX operations, headroom in retained for segmented mbufs Signed-off-by: Ed Czeck --- doc/guides/nics/ark.rst | 5 ++ drivers

[dpdk-dev] [PATCH v4 2/6] net/ark: refactor Rx buffer recovery

2021-03-09 Thread Ed Czeck
Allocate mbufs for Rx path in bulk of at least 64 buffers to improve performance. Allow recovery even without a Rx operation to support lack of buffers in pool. Fixes: be410a861598 ("net/ark: add recovery for lack of mbufs") Cc: sta...@dpdk.org Signed-off-by: Ed Czeck --- drive

[dpdk-dev] [PATCH v4 1/6] net/ark: update pkt director initial state

2021-03-09 Thread Ed Czeck
Fixes: b33ccdb17f55 ("net/ark: provide API for hardware modules MPU RQP and pktdir") Cc: sta...@dpdk.org Signed-off-by: Ed Czeck --- drivers/net/ark/ark_ethdev.c | 1 + drivers/net/ark/ark_pktdir.c | 2 +- drivers/net/ark/ark_pktdir.h | 2 +- 3 files changed, 3 insertions(+), 2

[dpdk-dev] [PATCH v3 6/6] net/ark: localize internal packet generator code

2021-03-08 Thread Ed Czeck
remove unnecessary includes no functional changes Signed-off-by: Ed Czeck --- drivers/net/ark/ark_ethdev.c | 17 ++--- drivers/net/ark/ark_pktchkr.c | 4 drivers/net/ark/ark_pktgen.c | 20 ++-- drivers/net/ark/ark_pktgen.h | 1 + 4 files changed, 17

[dpdk-dev] [PATCH v3 5/6] net/ark: cleanup and document ark dynamic extansion

2021-03-08 Thread Ed Czeck
- Rename extension functions with rte_pmd_ark prefix - Move extension prototype to rte_pmd_ark.h - Update documentation for extension Signed-off-by: Ed Czeck --- v3: - split function rename from previous commit --- doc/guides/nics/ark.rst | 139 - drivers/net/ark

[dpdk-dev] [PATCH v3 4/6] net/ark: generalize meta data between FPGA and PMD

2021-03-08 Thread Ed Czeck
In this commit we generalize the movement of user-specified meta data between mbufs and FPGA AXIS tuser fields using user-defined hook functions. - Previous use of PMD dynfields are removed - Hook function added to ark_user_ext - Add hook function calls in Rx and Tx paths Signed-off-by: Ed Czeck

[dpdk-dev] [PATCH v3 3/6] net/ark: update internal structs to reflect FPGA updates

2021-03-08 Thread Ed Czeck
- New PCIe IDs using net/ark driver - Update Version IDs and structures specified by hardware - New internal descriptor status for TX - Adjust data placement in RX operations, headroom in retained for segmented mbufs Signed-off-by: Ed Czeck --- doc/guides/nics/ark.rst | 5 ++ drivers

[dpdk-dev] [PATCH v3 2/6] net/ark: refactor Rx buffer recovery

2021-03-08 Thread Ed Czeck
Allocate mbufs for Rx path in bulk of at least 64 buffers to improve performance. Allow recovery even without a Rx operation to support lack of buffers in pool. Fixes: be410a861598 ("net/ark: add recovery for lack of mbufs") Cc: sta...@dpdk.org Signed-off-by: Ed Czeck --- drive

[dpdk-dev] [PATCH v3 1/6] net/ark: update pkt director initial state

2021-03-08 Thread Ed Czeck
Fixes: b33ccdb17f55 ("net/ark: provide API for hardware modules MPU RQP and pktdir") Cc: sta...@dpdk.org Signed-off-by: Ed Czeck --- drivers/net/ark/ark_ethdev.c | 1 + drivers/net/ark/ark_pktdir.c | 2 +- drivers/net/ark/ark_pktdir.h | 2 +- 3 files changed, 3 insertions(+), 2

[dpdk-dev] [PATCH v2 3/5] net/ark: update internal structs to reflect FPGA updates

2021-03-04 Thread Ed Czeck
- New PCIe IDs using net/ark driver - Update Version IDs and structures specified by hardware - New internal descriptor status for TX - Adjust data placement in RX operations, headroom in retained for segmented mbufs Signed-off-by: Ed Czeck --- drivers/net/ark/ark_ddm.c | 18

[dpdk-dev] [PATCH v2 5/5] net/ark: localize internal packet generator code

2021-03-04 Thread Ed Czeck
remove unnecessary includes no functional changes Signed-off-by: Ed Czeck --- drivers/net/ark/ark_ethdev.c | 17 ++--- drivers/net/ark/ark_pktchkr.c | 4 drivers/net/ark/ark_pktgen.c | 20 ++-- drivers/net/ark/ark_pktgen.h | 1 + 4 files changed, 17

  1   2   3   >