[dpdk-dev] [PATCH v5 1/5] eal: added interrupts empty stubs

2020-08-10 Thread Fady Bader
The ethdev lib uses interrupts. Interrupts are not implemented for Windows. To solve this, empty interrupt stubs were added under Windows. Signed-off-by: Fady Bader --- lib/librte_eal/windows/eal_interrupts.c | 18 ++ lib/librte_eal/windows/meson.build | 1 + 2 files

[dpdk-dev] [PATCH v5 3/5] ethdev: remove structs from export list

2020-08-10 Thread Fady Bader
Some ethdev structs were present in ethdev export list. There structs were removed from the export list. Signed-off-by: Fady Bader --- lib/librte_ethdev/rte_ethdev_version.map | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/librte_ethdev/rte_ethdev_version.map b/lib/librte_ethdev

[dpdk-dev] [PATCH v5 2/5] eal: updated export list for Windows

2020-08-10 Thread Fady Bader
Added eal functions used by ethdev lib to the export list under Windows. Signed-off-by: Fady Bader --- lib/librte_eal/rte_eal_exports.def | 11 +++ 1 file changed, 11 insertions(+) diff --git a/lib/librte_eal/rte_eal_exports.def b/lib/librte_eal/rte_eal_exports.def index 69204a92c6

[dpdk-dev] [PATCH v5 0/5] compiling ethdev lib under windows

2020-08-10 Thread Fady Bader
ging issue in telemetry lib. Fady Bader (5): eal: added interrupts empty stubs eal: updated export list for Windows ethdev: remove structs from export list telemetry: implement empty stubs for Windows ethdev: compiling ethdev under Windows lib/librte_eal/rte_eal_exports.def | 11 ++

[dpdk-dev] [PATCH v5 5/5] ethdev: compiling ethdev under Windows

2020-08-10 Thread Fady Bader
Compiling needed libraries for ethdev under Windows. Signed-off-by: Fady Bader --- lib/meson.build | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/meson.build b/lib/meson.build index 6bbaf242a9..c145240eb9 100644 --- a/lib/meson.build +++ b/lib/meson.build @@ -38,9

[dpdk-dev] [PATCH v5 4/5] telemetry: implement empty stubs for Windows

2020-08-10 Thread Fady Bader
Telemetry didn't compile under Windows. Empty stubs implementation was added for Windows. Signed-off-by: Fady Bader --- lib/librte_telemetry/rte_telemetry.h| 4 +++ lib/librte_telemetry/telemetry.c| 50 + lib/librte_telemetry/telemetry_legacy.c

[dpdk-dev] [PATCH v4 4/5] telemetry: implement empty stubs for Windows

2020-08-03 Thread Fady Bader
Telemetry didn't compile under Windows. Empty stubs implementation was added for Windows. Signed-off-by: Fady Bader --- lib/librte_telemetry/rte_telemetry.h| 4 +++ lib/librte_telemetry/telemetry.c| 51 - lib/librte_telemetry/telemetry_legacy.c

[dpdk-dev] [PATCH v4 2/5] eal: updated export list for Windows

2020-08-03 Thread Fady Bader
Added eal functions used by ethdev lib to the export list under Windows. Signed-off-by: Fady Bader --- lib/librte_eal/rte_eal_exports.def | 11 +++ 1 file changed, 11 insertions(+) diff --git a/lib/librte_eal/rte_eal_exports.def b/lib/librte_eal/rte_eal_exports.def index 69204a92c6

[dpdk-dev] [PATCH v4 3/5] ethdev: remove structs from export list

2020-08-03 Thread Fady Bader
Some ethdev structs were present in ethdev export list. There structs were removed from the export list. Signed-off-by: Fady Bader --- lib/librte_ethdev/rte_ethdev_version.map | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/librte_ethdev/rte_ethdev_version.map b/lib/librte_ethdev

[dpdk-dev] [PATCH v4 0/5] compiling ethdev lib under windows

2020-08-03 Thread Fady Bader
Added needed changes in order to get ethdev compiling under windows. Depends-on: series-10382 ("compile librte_net for windows") v4: added comments to #else and fixed code issue. v3: rebased on current master, added more exports to export list v2: fixed logging issue in telemetry

[dpdk-dev] [PATCH v4 1/5] eal: added interrupts empty stubs

2020-08-03 Thread Fady Bader
The ethdev lib uses interrupts. Interrupts are not implemented for Windows. To solve this, empty interrupt stubs were added under Windows. Signed-off-by: Fady Bader --- lib/librte_eal/windows/eal_interrupts.c | 17 + lib/librte_eal/windows/meson.build | 1 + 2 files

[dpdk-dev] [PATCH v4 5/5] ethdev: compiling ethdev under Windows

2020-08-03 Thread Fady Bader
Compiling needed libraries for ethdev under Windows. Signed-off-by: Fady Bader --- lib/meson.build | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/meson.build b/lib/meson.build index 6bbaf242a9..c145240eb9 100644 --- a/lib/meson.build +++ b/lib/meson.build @@ -38,9

Re: [dpdk-dev] [PATCH v3 4/5] telemetry: implement empty stubs for Windows

2020-08-03 Thread Fady Bader
> -Original Message- > From: Narcisa Ana Maria Vasile > Sent: Tuesday, August 4, 2020 4:27 AM > To: Fady Bader > Cc: dev@dpdk.org; Thomas Monjalon ; Tasnim Bashar > ; Tal Shnaiderman ; Yohad Tor > ; dmitry.kozl...@gmail.com; > harini.ramakrish...@microsoft.com

[dpdk-dev] [PATCH v3 5/5] ethdev: compiling ethdev under Windows

2020-08-03 Thread Fady Bader
Compiling needed libraries for ethdev under Windows. Signed-off-by: Fady Bader --- lib/meson.build | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/meson.build b/lib/meson.build index 6bbaf242a9..c145240eb9 100644 --- a/lib/meson.build +++ b/lib/meson.build @@ -38,9

[dpdk-dev] [PATCH v3 0/5] compiling ethdev lib under windows

2020-08-03 Thread Fady Bader
Added needed changes in order to get ethdev compiling under windows. Depends-on: series-10382 ("compile librte_net for windows") v3: rebased on current master, added more exports to export list v2: fixed logging issue in telemetry lib. Fady Bader (5): eal: added interrupts empty s

[dpdk-dev] [PATCH v3 4/5] telemetry: implement empty stubs for Windows

2020-08-03 Thread Fady Bader
Telemetry didn't compile under Windows. Empty stubs implementation was added for Windows. Signed-off-by: Fady Bader --- lib/librte_telemetry/rte_telemetry.h| 4 +++ lib/librte_telemetry/telemetry.c| 52 - lib/librte_telemetry/telemetry_legacy.c

[dpdk-dev] [PATCH v3 3/5] ethdev: remove structs from export list

2020-08-03 Thread Fady Bader
Some ethdev structs were present in ethdev export list. There structs were removed from the export list. Signed-off-by: Fady Bader --- lib/librte_ethdev/rte_ethdev_version.map | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/librte_ethdev/rte_ethdev_version.map b/lib/librte_ethdev

[dpdk-dev] [PATCH v3 2/5] eal: updated export list for Windows

2020-08-03 Thread Fady Bader
Added eal functions used by ethdev lib to the export list under Windows. Signed-off-by: Fady Bader --- lib/librte_eal/rte_eal_exports.def | 11 +++ 1 file changed, 11 insertions(+) diff --git a/lib/librte_eal/rte_eal_exports.def b/lib/librte_eal/rte_eal_exports.def index 69204a92c6

[dpdk-dev] [PATCH v3 1/5] eal: added interrupts empty stubs

2020-08-03 Thread Fady Bader
The ethdev lib uses interrupts. Interrupts are not implemented for Windows. To solve this, empty interrupt stubs were added under Windows. Signed-off-by: Fady Bader --- lib/librte_eal/windows/eal_interrupts.c | 17 + lib/librte_eal/windows/meson.build | 1 + 2 files

Re: [dpdk-dev] [PATCH 0/5] compiling ethdev lib under windows

2020-08-02 Thread Fady Bader
> -Original Message- > From: Narcisa Ana Maria Vasile > Sent: Wednesday, July 29, 2020 4:02 AM > To: Fady Bader > Cc: dev@dpdk.org; Thomas Monjalon ; Tasnim Bashar > ; Tal Shnaiderman ; Yohad Tor > ; dmitry.kozl...@gmail.com; > harini.ramakrish...@microsoft.com

Re: [dpdk-dev] [PATCH v2 3/3] eal/windows: librte_net build on Windows

2020-07-27 Thread Fady Bader
> -Original Message- > From: Bruce Richardson > Sent: Wednesday, July 22, 2020 1:31 PM > To: Fady Bader > Cc: Dmitry Kozlyuk ; Narcisa Ana Maria Vasile > ; dev@dpdk.org; Thomas Monjalon > ; Tasnim Bashar ; Tal > Shnaiderman ; Yohad Tor ; > harini.ramakr

Re: [dpdk-dev] [PATCH v2 3/3] eal/windows: librte_net build on Windows

2020-07-27 Thread Fady Bader
> > On Mon, 20 Jul 2020 12:54:08 +, Fady Bader wrote: > > [snip] > > > > Getting the same error with a setup similar to Dmitry's. My setup: > > > > SDK 10.0.18362, > > > > > > I'm sending v4 patch that should resolve this. &

Re: [dpdk-dev] [PATCH v2 0/5] compiling ethdev lib under windows

2020-07-26 Thread Fady Bader
Hi Narcisa, I saw that the net patch was acked, can you also review this patch too to see if more work should be done. Thanks, Fady > -Original Message- > From: Fady Bader > Sent: Sunday, June 28, 2020 1:59 PM > To: dev@dpdk.org > Cc: Fady Bader ; Thomas Monjalon &g

[dpdk-dev] [PATCH v4 2/3] net: replace htons with RTE_BE16

2020-07-23 Thread Fady Bader
htons wasn't defined in Windows for the minGW compiler. htons was replaced with RTE_BE16 in order to compile under Windows. Signed-off-by: Fady Bader --- lib/librte_net/rte_arp.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/lib/librte_net/rte_arp.c

[dpdk-dev] [PATCH v4 3/3] eal/windows: librte_net build on Windows

2020-07-23 Thread Fady Bader
librte_net wasn't compiling under Windows. To solve this, needed header files were added. Signed-off-by: Fady Bader --- lib/librte_eal/windows/include/netinet/in.h | 23 +++ lib/librte_eal/windows/include/netinet/ip.h | 10 ++ lib/librte_net/rte_et

[dpdk-dev] [PATCH v4 1/3] net: fix s_addr redefinition in Windows

2020-07-23 Thread Fady Bader
s_addr in Windows is defined in defined winsock2.h which is included by windows.h so its undefined in order to be defined as part of rte_ether_hdr. Signed-off-by: Fady Bader --- lib/librte_net/rte_ether.h | 9 + 1 file changed, 9 insertions(+) diff --git a/lib/librte_net/rte_ether.h b

[dpdk-dev] [PATCH v4 0/3] compile librte_net for windows

2020-07-23 Thread Fady Bader
v2: * fixed style issue. v3: * replaced htons with rte_cpu_to_be_16. * rebased to current master. v4: * removed the use of rte_random in librte_net. * replaced htons with RTE_BE16. Fady Bader (3): net: fix s_addr redefinition in Windows net: replace htons with RTE_BE16 eal/windows

Re: [dpdk-dev] [PATCH v2 3/3] eal/windows: librte_net build on Windows

2020-07-22 Thread Fady Bader
> -Original Message- > From: Dmitry Kozlyuk > Sent: Monday, July 20, 2020 7:27 PM > To: Fady Bader > Cc: Narcisa Ana Maria Vasile ; dev@dpdk.org; > Thomas Monjalon ; Tasnim Bashar > ; Tal Shnaiderman ; Yohad Tor > ; harini.ramakrish...@microsoft.com; > ocard

Re: [dpdk-dev] [PATCH v2 3/3] eal/windows: librte_net build on Windows

2020-07-20 Thread Fady Bader
> > > Subject: Re: [PATCH v2 3/3] eal/windows: librte_net build on Windows > > > > > > > diff --git a/lib/librte_eal/common/meson.build > > > > b/lib/librte_eal/common/meson.build > > > > index e1bdaf024..05e40a26b 100644 > > > > --- a/lib/librte_eal/common/meson.build > > > > +++ b/lib/librte_ea

Re: [dpdk-dev] [PATCH v3 1/3] net: fix s_addr redefinition in Windows

2020-07-14 Thread Fady Bader
> -Original Message- > From: Olivier Matz > Sent: Monday, July 13, 2020 5:39 PM > To: Fady Bader > Cc: dev@dpdk.org; Thomas Monjalon ; Tasnim Bashar > ; Tal Shnaiderman ; Yohad Tor > ; dmitry.kozl...@gmail.com; > harini.ramakrish...@microsoft.com; ocard...@mic

Re: [dpdk-dev] [PATCH v3 2/3] net: replace htons with rte_cpu_to_be_16

2020-07-14 Thread Fady Bader
> -Original Message- > From: Olivier Matz > Sent: Monday, July 13, 2020 5:39 PM > To: Fady Bader > Cc: dev@dpdk.org; Thomas Monjalon ; Tasnim Bashar > ; Tal Shnaiderman ; Yohad Tor > ; dmitry.kozl...@gmail.com; > harini.ramakrish...@microsoft.com; ocard...@mic

Re: [dpdk-dev] [PATCH v3 3/3] eal/windows: librte_net build on Windows

2020-07-08 Thread Fady Bader
> -Original Message- > From: Thomas Monjalon > Sent: Wednesday, July 8, 2020 12:10 PM > To: Fady Bader > Cc: dev@dpdk.org; Tasnim Bashar ; Tal Shnaiderman > ; Yohad Tor ; > dmitry.kozl...@gmail.com; harini.ramakrish...@microsoft.com; > ocard...@microsoft.com;

[dpdk-dev] [PATCH v3 2/3] net: replace htons with rte_cpu_to_be_16

2020-07-08 Thread Fady Bader
htons wasn't defined in Windows for the minGW compiler. htons was replaced with rte_cpu_to_be_16 in order to compile under Windows. Signed-off-by: Fady Bader --- lib/librte_net/rte_arp.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/lib/librte_net/rte_ar

[dpdk-dev] [PATCH v3 3/3] eal/windows: librte_net build on Windows

2020-07-08 Thread Fady Bader
librte_net wasn't compiling under Windows. To solve this, needed exports and files were added for Windows. Signed-off-by: Fady Bader --- lib/librte_eal/common/meson.build | 1 + lib/librte_eal/rte_eal_exports.def | 1 + lib/librte_eal/windows/include/netinet/in.h

[dpdk-dev] [PATCH v3 1/3] net: fix s_addr redefinition in Windows

2020-07-08 Thread Fady Bader
s_addr in Windows is defined in windows.h so its undefined in order to be defined as part of rte_ether_hdr. Signed-off-by: Fady Bader --- lib/librte_net/rte_ether.h | 9 + 1 file changed, 9 insertions(+) diff --git a/lib/librte_net/rte_ether.h b/lib/librte_net/rte_ether.h index

[dpdk-dev] [PATCH v3 0/3] compile librte_net for windows

2020-07-08 Thread Fady Bader
Addded needed files and fixes for windows in order to get librte_net compiling under Windows. v3: * replaced htons with rte_cpu_to_be_16. * rebased to current master. Fady Bader (3): net: fix s_addr redefinition in Windows net: replace htons with rte_cpu_to_be_16 eal/windows

[dpdk-dev] [PATCH v7 2/3] mempool: use generic memory management

2020-07-06 Thread Fady Bader
Using generic memory management calls instead of Unix memory management calls for mempool. Signed-off-by: Fady Bader Acked-by: Olivier Matz Acked-by: Andrew Rybchenko Reviewed-by: Dmitry Kozlyuk --- lib/librte_mempool/rte_mempool.c | 26 -- 1 file changed, 12

[dpdk-dev] [PATCH v7 3/3] mempool: mempool build on Windows

2020-07-06 Thread Fady Bader
Some EAL functions are used by mempool lib but not exported on Windows. The functions are exported. Added mempool to supported libraries for Windows compilation. Signed-off-by: Fady Bader Acked-by: Olivier Matz --- lib/librte_eal/rte_eal_exports.def | 6 ++ lib/meson.build

[dpdk-dev] [PATCH v7 1/3] eal: disable function versioning on Windows

2020-07-06 Thread Fady Bader
Function versioning implementation is not supported by Windows. Function versioning is disabled on Windows. Signed-off-by: Fady Bader --- doc/guides/windows_gsg/intro.rst | 4 lib/meson.build | 6 +- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/doc

[dpdk-dev] [PATCH v7 0/3] build mempool on Windows

2020-07-06 Thread Fady Bader
added comments to unclear code. v3: * Rebased on current master and v5 of "eal/windows: ring build on Windows". v2: * Replace ifndef of tracepoints with symbol export from memory management patchset. Fady Bader (3): eal: disable function versioning on Windows mempool: u

Re: [dpdk-dev] [PATCH v5 1/3] eal: disable function versioning on Windows

2020-07-06 Thread Fady Bader
> -Original Message- > From: Bruce Richardson > Sent: Monday, July 6, 2020 11:20 AM > To: Fady Bader > Cc: dev@dpdk.org; Thomas Monjalon ; Tasnim Bashar > ; Tal Shnaiderman ; Yohad Tor > ; dmitry.kozl...@gmail.com; > harini.ramakrish...@microsoft.com

Re: [dpdk-dev] [PATCH v2 3/3] eal/windows: librte_net build on Windows

2020-07-06 Thread Fady Bader
https://code.woboq.org/qt5/include/netinet/in.h.html > -Original Message- > From: Thomas Monjalon > Sent: Tuesday, June 16, 2020 12:04 PM > To: Fady Bader > Cc: dev@dpdk.org; Tasnim Bashar ; Tal Shnaiderman > ; Yohad Tor ; > dmitry.kozl...@gmail.com; harini.ramakrish

Re: [dpdk-dev] [PATCH v6 1/3] eal: disable function versioning on Windows

2020-07-06 Thread Fady Bader
> -Original Message- > From: Thomas Monjalon > Sent: Sunday, July 5, 2020 11:24 PM > To: Fady Bader > Cc: dev@dpdk.org; Tasnim Bashar ; Tal Shnaiderman > ; Yohad Tor ; > dmitry.kozl...@gmail.com; harini.ramakrish...@microsoft.com; > ocard...@microsoft.com;

[dpdk-dev] [PATCH v6 3/3] mempool: mempool build on Windows

2020-07-05 Thread Fady Bader
Some eal functions are used by mempool lib but not exported on Windows. The functions were exported. Added mempool to supported libraries for Windows compilation. Signed-off-by: Fady Bader --- lib/librte_eal/rte_eal_exports.def | 6 ++ lib/meson.build| 2 +- 2 files

[dpdk-dev] [PATCH v6 1/3] eal: disable function versioning on Windows

2020-07-05 Thread Fady Bader
Function versioning implementation is not supported by Windows. Function versioning was disabled on Windows. Signed-off-by: Fady Bader --- lib/librte_eal/include/rte_function_versioning.h | 2 +- lib/meson.build | 5 + 2 files changed, 6 insertions(+), 1

[dpdk-dev] [PATCH v6 0/3] build mempool on Windows

2020-07-05 Thread Fady Bader
: * Rebased on current master and v5 of "eal/windows: ring build on Windows". v2: * Replace ifndef of tracepoints with symbol export from memory management patchset. Fady Bader (3): eal: disable function versioning on Windows mempool: use generic memory management mempool: mempoo

[dpdk-dev] [PATCH v6 2/3] mempool: use generic memory management

2020-07-05 Thread Fady Bader
Using generic memory management calls instead of Unix memory management calls for mempool. Signed-off-by: Fady Bader --- lib/librte_mempool/rte_mempool.c | 26 -- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/lib/librte_mempool/rte_mempool.c b/lib

Re: [dpdk-dev] [PATCH v5 2/3] mempool: use generic memory management

2020-07-05 Thread Fady Bader
> -Original Message- > From: Dmitry Kozlyuk > Sent: Sunday, July 5, 2020 3:08 PM > To: Fady Bader > Cc: dev@dpdk.org; Thomas Monjalon ; Tasnim Bashar > ; Tal Shnaiderman ; Yohad Tor > ; harini.ramakrish...@microsoft.com; > ocard...@microsoft.com; pallavi.ka

Re: [dpdk-dev] [PATCH v5 3/3] mempool: mempool build on Windows

2020-07-05 Thread Fady Bader
> -Original Message- > From: David Marchand > Sent: Sunday, July 5, 2020 3:01 PM > To: Fady Bader > Cc: dev ; Thomas Monjalon ; Tasnim > Bashar ; Tal Shnaiderman ; > Yohad Tor ; Dmitry Kozlyuk > ; Harini Ramakrishnan > ; Omar Cardona > ; Pallavi Kadam ;

[dpdk-dev] [PATCH v5 0/3] build mempool on Windows

2020-07-05 Thread Fady Bader
quot;. v2: * Replace ifndef of tracepoints with symbol export from memory management patchset. Fady Bader (3): eal: disable function versioning on Windows mempool: use generic memory management mempool: mempool build on Windows lib/librte_eal/include/rte_function_versioning.h |

[dpdk-dev] [PATCH v5 3/3] mempool: mempool build on Windows

2020-07-05 Thread Fady Bader
Some eal functions are used by mempool lib but not exported on Windows. The functions were exported. Added mempool to supported libraries for Windows compilation. Signed-off-by: Fady Bader --- lib/librte_eal/rte_eal_exports.def | 6 ++ lib/librte_eal/rte_eal_version.map | 1 + lib

[dpdk-dev] [PATCH v5 2/3] mempool: use generic memory management

2020-07-05 Thread Fady Bader
Using generic memory management calls instead of Unix memory management calls for mempool. Signed-off-by: Fady Bader --- lib/librte_mempool/rte_mempool.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/lib/librte_mempool/rte_mempool.c b/lib

[dpdk-dev] [PATCH v5 1/3] eal: disable function versioning on Windows

2020-07-05 Thread Fady Bader
Function versioning implementation is not supported by Windows. Function versioning was disabled on Windows. Signed-off-by: Fady Bader --- lib/librte_eal/include/rte_function_versioning.h | 2 +- lib/meson.build | 5 + 2 files changed, 6 insertions(+), 1

Re: [dpdk-dev] [PATCH v3 1/4] eal: disable function versioning on Windows

2020-07-05 Thread Fady Bader
> -Original Message- > From: Thomas Monjalon > Sent: Sunday, July 5, 2020 11:38 AM > To: Kinsella, Ray ; Fady Bader > Cc: dev@dpdk.org; Tasnim Bashar ; Tal Shnaiderman > ; Yohad Tor ; > dmitry.kozl...@gmail.com; harini.ramakrish...@microsoft.com; > ocard...@m

Re: [dpdk-dev] [PATCH v3 1/4] eal: disable function versioning on Windows

2020-07-05 Thread Fady Bader
> -Original Message- > From: Kinsella, Ray > Sent: Thursday, July 2, 2020 5:57 PM > To: Fady Bader ; dev@dpdk.org > Cc: Thomas Monjalon ; Tasnim Bashar > ; Tal Shnaiderman ; Yohad Tor > ; dmitry.kozl...@gmail.com; > harini.ramakrish...@microsoft.com; ocard...@mic

[dpdk-dev] [PATCH v4 3/3] mempool: mempool build on Windows

2020-07-02 Thread Fady Bader
Some eal functions are used by mempool lib but not exported on Windows. The functions were exported. Added mempool to supported libraries for Windows compilation. Signed-off-by: Fady Bader --- lib/librte_eal/rte_eal_exports.def | 6 ++ lib/librte_eal/rte_eal_version.map | 1 + lib

[dpdk-dev] [PATCH v4 0/3] build mempool on Windows

2020-07-02 Thread Fady Bader
management patchset. Fady Bader (3): eal: disable function versioning on Windows mempool: use generic memory management mempool: mempool build on Windows lib/librte_eal/include/rte_function_versioning.h | 8 lib/librte_eal/rte_eal_exports.def | 6 ++ lib/

[dpdk-dev] [PATCH v4 2/3] mempool: use generic memory management

2020-07-02 Thread Fady Bader
mempool used Unix memory management calls, which are not supported on Windows. Used generic memory management instead. Signed-off-by: Fady Bader --- lib/librte_mempool/rte_mempool.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/lib/librte_mempool

[dpdk-dev] [PATCH v4 1/3] eal: disable function versioning on Windows

2020-07-02 Thread Fady Bader
Function versioning implementation is not supported by Windows. Function versioning was disabled on Windows. Signed-off-by: Fady Bader --- lib/librte_eal/include/rte_function_versioning.h | 8 1 file changed, 8 insertions(+) diff --git a/lib/librte_eal/include

Re: [dpdk-dev] [PATCH v3 1/4] eal: disable function versioning on Windows

2020-07-02 Thread Fady Bader
> -Original Message- > From: Thomas Monjalon > Sent: Tuesday, June 30, 2020 2:26 AM > To: Fady Bader > Cc: dev@dpdk.org; Tasnim Bashar ; Tal Shnaiderman > ; Yohad Tor ; > dmitry.kozl...@gmail.com; harini.ramakrish...@microsoft.com; > ocard...@microsoft.com;

Re: [dpdk-dev] [PATCH v3 3/4] eal: export needed functions for mempool

2020-07-02 Thread Fady Bader
Ok, I'll send a new version today. > -Original Message- > From: Thomas Monjalon > Sent: Tuesday, June 30, 2020 2:29 AM > To: Fady Bader > Cc: dev@dpdk.org; Tasnim Bashar ; Tal Shnaiderman > ; Yohad Tor ; > dmitry.kozl...@gmail.com; harini.ramakrish

Re: [dpdk-dev] [PATCH 6/7] cmdline: support Windows

2020-06-28 Thread Fady Bader
eded places, is there any suggestions on how it can be done ? > -Original Message- > From: Dmitry Kozlyuk > Sent: Sunday, June 21, 2020 12:05 AM > To: dev@dpdk.org > Cc: Dmitry Malloy ; Narcisa Ana Maria Vasile > ; Fady Bader ; Tal > Shnaiderman ; Dmitry Kozlyuk > ; Thomas

[dpdk-dev] [PATCH v2 3/5] ethdev: remove structs from export list

2020-06-28 Thread Fady Bader
Some ethdev structs were present in ethdev export list. There structs were removed from the export list. Signed-off-by: Fady Bader --- lib/librte_ethdev/rte_ethdev_version.map | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/librte_ethdev/rte_ethdev_version.map b/lib/librte_ethdev

[dpdk-dev] [PATCH v2 5/5] ethdev: compiling ethdev under Windows

2020-06-28 Thread Fady Bader
Compiling needed libraries for ethdev under Windows. Signed-off-by: Fady Bader --- lib/meson.build | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/meson.build b/lib/meson.build index 6317309ecf..34366cd614 100644 --- a/lib/meson.build +++ b/lib/meson.build

[dpdk-dev] [PATCH v2 2/5] eal: updated export list for Windows

2020-06-28 Thread Fady Bader
Added eal functions used by ethdev lib to the export list under Windows. Signed-off-by: Fady Bader --- lib/librte_eal/rte_eal_exports.def | 10 ++ 1 file changed, 10 insertions(+) diff --git a/lib/librte_eal/rte_eal_exports.def b/lib/librte_eal/rte_eal_exports.def index 20f7346962

[dpdk-dev] [PATCH v2 0/5] compiling ethdev lib under windows

2020-06-28 Thread Fady Bader
Added needed changes in order to get ethdev compiling under windows. Depends-on: series-10382 ("compile librte_net for windows") v2: fixed logging issue in telemetry lib. Fady Bader (5): eal: added interrupts empty stubs eal: updated export list for Windows ethdev: remove st

[dpdk-dev] [PATCH v2 4/5] telemetry: implement empty stubs for Windows

2020-06-28 Thread Fady Bader
Telemetry didn't compile under Windows. Empty stubs implementation was added for Windows. Signed-off-by: Fady Bader --- lib/librte_telemetry/rte_telemetry.h| 4 +++ lib/librte_telemetry/telemetry.c| 51 - lib/librte_telemetry/telemetry_legacy.c

[dpdk-dev] [PATCH v2 1/5] eal: added interrupts empty stubs

2020-06-28 Thread Fady Bader
The ethdev lib uses interrupts. Interrupts are not implemented for Windows. To solve this, empty interrupt stubs were added under Windows. Signed-off-by: Fady Bader --- lib/librte_eal/windows/eal_interrupts.c | 17 + lib/librte_eal/windows/meson.build | 1 + 2 files

Re: [dpdk-dev] [PATCH v2 3/3] eal/windows: librte_net build on Windows

2020-06-28 Thread Fady Bader
> Subject: Re: [PATCH v2 3/3] eal/windows: librte_net build on Windows > > > diff --git a/lib/librte_eal/common/meson.build > > b/lib/librte_eal/common/meson.build > > index e1bdaf024..05e40a26b 100644 > > --- a/lib/librte_eal/common/meson.build > > +++ b/lib/librte_eal/common/meson.build > > @@ -

[dpdk-dev] [PATCH 3/5] ethdev: remove structs from export list

2020-06-25 Thread Fady Bader
Some ethdev structs were present in ethdev export list. There structs were removed from the export list. Signed-off-by: Fady Bader --- lib/librte_ethdev/rte_ethdev_version.map | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/librte_ethdev/rte_ethdev_version.map b/lib/librte_ethdev

[dpdk-dev] [PATCH 2/5] eal: updated export list for Windows

2020-06-25 Thread Fady Bader
Added eal functions used by ethdev lib to the export list under Windows. Signed-off-by: Fady Bader --- lib/librte_eal/rte_eal_exports.def | 10 ++ 1 file changed, 10 insertions(+) diff --git a/lib/librte_eal/rte_eal_exports.def b/lib/librte_eal/rte_eal_exports.def index 20f7346962

[dpdk-dev] [PATCH 0/5] compiling ethdev lib under windows

2020-06-25 Thread Fady Bader
Added needed changes in order to get ethdev compiling under windows. Depends-on: series-10382 ("compile librte_net for windows") Fady Bader (5): eal: added interrupts empty stubs eal: updated export list for Windows ethdev: remove structs from export list telemetry: implement e

[dpdk-dev] [PATCH 5/5] ethdev: compiling ethdev under Windows

2020-06-25 Thread Fady Bader
Compiling needed libraries for ethdev under Windows. Signed-off-by: Fady Bader --- lib/meson.build | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/meson.build b/lib/meson.build index 6317309ecf..34366cd614 100644 --- a/lib/meson.build +++ b/lib/meson.build

[dpdk-dev] [PATCH 1/5] eal: added interrupts empty stubs

2020-06-25 Thread Fady Bader
The ethdev lib uses interrupts. Interrupts are not implemented for Windows. To solve this, empty interrupt stubs were added under Windows. Signed-off-by: Fady Bader --- lib/librte_eal/windows/eal_interrupts.c | 17 + lib/librte_eal/windows/meson.build | 1 + 2 files

[dpdk-dev] [PATCH 4/5] telemetry: implement empty stubs for Windows

2020-06-25 Thread Fady Bader
Telemetry didn't compile under Windows. Empty stubs implementation was added for Windows. Signed-off-by: Fady Bader --- lib/librte_telemetry/rte_telemetry.h| 4 +++ lib/librte_telemetry/telemetry.c| 43 - lib/librte_telemetry/telemetry_legacy.c

[dpdk-dev] [PATCH v3 4/4] mempool: mempool build on Windows

2020-06-22 Thread Fady Bader
Added mempool to supported libraries for Windows compilation. Signed-off-by: Fady Bader --- lib/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/meson.build b/lib/meson.build index 9074cb58af..a9a5be0e5e 100644 --- a/lib/meson.build +++ b/lib/meson.build

[dpdk-dev] [PATCH v3 2/4] mempool: use generic memory management

2020-06-22 Thread Fady Bader
mempool used Unix memory management calls, which are not supported on Windows. Used generic memory management instead. Signed-off-by: Fady Bader --- lib/librte_mempool/rte_mempool.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/lib/librte_mempool

[dpdk-dev] [PATCH v3 3/4] eal: export needed functions for mempool

2020-06-22 Thread Fady Bader
Some eal functions were used by mempool lib but not exported on Windows. The function was exported. Signed-off-by: Fady Bader --- lib/librte_eal/rte_eal_exports.def | 6 ++ lib/librte_eal/rte_eal_version.map | 1 + 2 files changed, 7 insertions(+) diff --git a/lib/librte_eal

[dpdk-dev] [PATCH v3 1/4] eal: disable function versioning on Windows

2020-06-22 Thread Fady Bader
Function versioning is not needed on Windows, also the function versioning implementation is not supported by Windows. Function versioning was disabled on Windows. Signed-off-by: Fady Bader --- lib/librte_eal/include/rte_function_versioning.h | 4 1 file changed, 4 insertions(+) diff

[dpdk-dev] [PATCH v3 0/4] build mempool on Windows

2020-06-22 Thread Fady Bader
om memory management patchset. Fady Bader (4): eal: disable function versioning on Windows mempool: use generic memory management eal: export needed functions for mempool mempool: mempool build on Windows lib/librte_eal/include/rte_function_versioning.h | 4 lib/librte_eal

[dpdk-dev] [PATCH v5] eal/windows: ring build on Windows

2020-06-21 Thread Fady Bader
Building ring on Windows. Signed-off-by: Fady Bader --- Depends-on: series-10531 ("Windows bus/pci support") v5: rebase to current master and "Windows bus/pci support" v7. v4: rebase on "Windows basic memory management" v5. v3: Fix style issues. v2: Fix styl

Re: [dpdk-dev] [PATCH v7 7/9] bus/pci: introduce Windows support with stubs

2020-06-21 Thread Fady Bader
> diff --git a/lib/librte_eal/rte_eal_exports.def > b/lib/librte_eal/rte_eal_exports.def > index 61bcb8aca7..3b0c8b60a5 100644 > --- a/lib/librte_eal/rte_eal_exports.def > +++ b/lib/librte_eal/rte_eal_exports.def > @@ -3,6 +3,11 @@ EXPORTS > per_lcore__rte_errno > rte_calloc > rte

Re: [dpdk-dev] [PATCH v9 2/2] timer: support EAL functions on Windows

2020-06-18 Thread Fady Bader
> -Original Message- > From: Ranjit Menon > Sent: Thursday, June 18, 2020 1:16 AM > To: Fady Bader ; dev@dpdk.org > Cc: Thomas Monjalon ; Tasnim Bashar > ; Tal Shnaiderman ; Yohad Tor > ; dmitry.kozl...@gmail.com; > harini.ramakrish...@microsoft.com; ocard...@mic

[dpdk-dev] [PATCH v10 2/2] timer: support EAL functions on Windows

2020-06-17 Thread Fady Bader
Implemented the needed Windows eal timer functions. Signed-off-by: Fady Bader --- lib/librte_eal/common/meson.build | 1 + lib/librte_eal/windows/eal.c| 6 +++ lib/librte_eal/windows/eal_timer.c | 93 + lib/librte_eal/windows/include

[dpdk-dev] [PATCH v10 0/2] eal timer split and implementation for Windows

2020-06-17 Thread Fady Bader
oved unneded headers. v9: * rebasing to current master. * fixing correctness issue. v10: * fixing correctness issue. Fady Bader (2): timer: move from common to Unix directory timer: support EAL functions on Windows lib/librte_eal/common/eal_common_timer.c | 22 l

[dpdk-dev] [PATCH v10 1/2] timer: move from common to Unix directory

2020-06-17 Thread Fady Bader
sleep referenced in function set_tsc_freq The reason was that some functions called POSIX functions. The solution was to move POSIX dependent functions from common to Unix. Signed-off-by: Fady Bader --- lib/librte_eal/common/eal_common_timer.c | 22 -- lib/librte_eal/fr

[dpdk-dev] [PATCH v9 0/2] eal timer split and implementation for Windows

2020-06-17 Thread Fady Bader
oved unneded headers. v9: * rebasing to current master. * fixing correctness issue. Fady Bader (2): timer: move from common to Unix directory timer: support EAL functions on Windows lib/librte_eal/common/eal_common_timer.c | 22 lib/librte_eal/common/meson.build|

[dpdk-dev] [PATCH v9 2/2] timer: support EAL functions on Windows

2020-06-17 Thread Fady Bader
Implemented the needed Windows eal timer functions. Signed-off-by: Fady Bader --- lib/librte_eal/common/meson.build | 1 + lib/librte_eal/windows/eal.c| 6 +++ lib/librte_eal/windows/eal_timer.c | 91 + lib/librte_eal/windows/include

[dpdk-dev] [PATCH v9 1/2] timer: move from common to Unix directory

2020-06-17 Thread Fady Bader
sleep referenced in function set_tsc_freq The reason was that some functions called POSIX functions. The solution was to move POSIX dependent functions from common to Unix. Signed-off-by: Fady Bader --- lib/librte_eal/common/eal_common_timer.c | 22 -- lib/librte_eal/fr

Re: [dpdk-dev] [PATCH v8 3/3] timer: support EAL functions on Windows

2020-06-17 Thread Fady Bader
Sending a new version soon. > Subject: Re: [PATCH v8 3/3] timer: support EAL functions on Windows > > > On 6/14/2020 1:43 AM, Fady Bader wrote: > > Implemented the needed Windows eal timer functions. > > > > Signed-off-by: Fady Bader > > --- > > li

[dpdk-dev] [PATCH v2] meter: remove inline functions from export list

2020-06-17 Thread Fady Bader
3de30 ("lib: provide initial versioning") Cc: sta...@dpdk.org Signed-off-by: Fady Bader --- v2: fixed commit message style issue --- lib/librte_meter/rte_meter_version.map | 6 -- 1 file changed, 6 deletions(-) diff --git a/lib/librte_meter/rte_meter_version.map b/lib/librte_met

[dpdk-dev] [PATCH] meter: remove inline functions from export list

2020-06-17 Thread Fady Bader
3de30 ("lib: provide initial versioning") Cc: sta...@dpdk.org Signed-off-by: Fady Bader --- lib/librte_meter/rte_meter_version.map | 6 -- 1 file changed, 6 deletions(-) diff --git a/lib/librte_meter/rte_meter_version.map b/lib/librte_meter/rte_meter_version.map index b493bcebe

[dpdk-dev] [PATCH v8 2/3] eal: proc type function for Windows

2020-06-14 Thread Fady Bader
Implementation of rte_proc_type_t for Windows as it is needed for Windows eal timer. Signed-off-by: Fady Bader --- lib/librte_eal/windows/eal.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/librte_eal/windows/eal.c b/lib/librte_eal/windows/eal.c index d084606a6..feee91244 100644

[dpdk-dev] [PATCH v8 3/3] timer: support EAL functions on Windows

2020-06-14 Thread Fady Bader
Implemented the needed Windows eal timer functions. Signed-off-by: Fady Bader --- lib/librte_eal/common/meson.build | 1 + lib/librte_eal/windows/eal.c| 6 +++ lib/librte_eal/windows/eal_timer.c | 90 + lib/librte_eal/windows/include

[dpdk-dev] [PATCH v8 1/3] timer: move from common to Unix directory

2020-06-14 Thread Fady Bader
sleep referenced in function set_tsc_freq The reason was that some functions called POSIX functions. The solution was to move POSIX dependent functions from common to Unix. Signed-off-by: Fady Bader --- lib/librte_eal/common/eal_common_timer.c | 22 -- lib/librte_eal/fr

[dpdk-dev] [PATCH v8 0/3] eal timer split and implementation for Windows

2020-06-14 Thread Fady Bader
oved unneded headers. Fady Bader (3): timer: move from common to Unix directory eal: proc type function for Windows timer: support EAL functions on Windows lib/librte_eal/common/eal_common_timer.c | 22 lib/librte_eal/common/meson.build| 1 + lib/librte_eal/freebsd/Ma

[dpdk-dev] [PATCH v2 3/3] eal/windows: librte_net build on Windows

2020-06-10 Thread Fady Bader
librte_net wasn't compiling under Windows. To solve this, needed exports and files were added for Windows. Signed-off-by: Fady Bader --- lib/librte_eal/common/meson.build | 1 + lib/librte_eal/rte_eal_exports.def | 1 + lib/librte_eal/windows/include/netinet/in.h

[dpdk-dev] [PATCH v2 2/3] net: add htons to minGW for Windows

2020-06-10 Thread Fady Bader
htons wasnt defined in Windows for the minGW compiler. Definition of htons was added in order to use htons. Signed-off-by: Fady Bader --- lib/librte_eal/windows/include/rte_os.h | 4 lib/librte_net/rte_arp.c| 2 ++ 2 files changed, 6 insertions(+) diff --git a/lib

[dpdk-dev] [PATCH v2 1/3] net: fix s_addr redefinition in Windows

2020-06-10 Thread Fady Bader
s_addr in Windows is defined in windows.h so its undefined in order to be defined as part of rte_ether_hdr. Signed-off-by: Fady Bader --- lib/librte_net/rte_ether.h | 9 + 1 file changed, 9 insertions(+) diff --git a/lib/librte_net/rte_ether.h b/lib/librte_net/rte_ether.h index

[dpdk-dev] [PATCH v2 0/3] compile librte_net for windows

2020-06-10 Thread Fady Bader
Addded needed files and fixes for windows in order to get librte_net compiling under Windows. Depends-on: series-10282 ("build mempool on Windows") Fady Bader (3): net: fix s_addr redefinition in Windows net: add htons to minGW for Windows eal/windows: librte_net build on Win

  1   2   >