[dpdk-dev] [PATCH v4] meson: remove unnecessary explicit link to libpcap

2021-04-09 Thread Gabriel Ganne
t; is declared using the dependency() directive in config/meson.build meson automatically adds this dependency to the pkg-config file in the private section for static builds. Signed-off-by: Gabriel Ganne --- config/meson.build | 1 - 1 file changed, 1 deletion(-) diff --git a/config/meson.build

Re: [dpdk-dev] [PATCH v3] meson: remove unnecessary explicit link to libpcap

2021-04-09 Thread Gabriel Ganne
t; Thank you, the fix looks good. > I would like to improve the explanation. > > If I understand the issue, the title should be > "build: remove redundant libpcap link" > > 26/03/2021 09:22, Gabriel Ganne: > > libpcap is already found and registered as a dependency by

[dpdk-dev] [PATCH v3] meson: remove unnecessary explicit link to libpcap

2021-03-26 Thread Gabriel Ganne
you configure meson to prefer static linking over dynamic, this will cause the build to fail on librte_port, since the pcap deps are not yet seen by the linker. Signed-off-by: Gabriel Ganne --- config/meson.build | 1 - 1 file changed, 1 deletion(-) diff --git a/config/meson.build b/config

Re: [dpdk-dev] [PATCH v2 2/3] meson: use threads dependency as provided by meson

2021-03-23 Thread Gabriel Ganne
l, but my thinking was that the library has a genuine > threads dependency, but in the Windows case this is satisfied by EAL > and so threads_dep can perhaps legitimately be empty. It also means > there's only one place where the decision is made regardless of the > number of dependencies. > > Regards, > Nick > -- Gabriel Ganne

[dpdk-dev] [PATCH v4] meson: update minimum required meson version

2021-03-23 Thread Gabriel Ganne
in '0.48.0': console arg in custom_target 'console' argument is used within kernel/linux/kni/meson.build Signed-off-by: Gabriel Ganne --- .ci/linux-setup.sh| 2 +- doc/guides/linux_gsg/sys_reqs.rst | 2 +- doc/guides/prog_guide/build-sdk-meson.r

[dpdk-dev] [PATCH v3] meson: update minimum required meson version

2021-03-23 Thread Gabriel Ganne
in '0.48.0': console arg in custom_target 'console' argument is used within kernel/linux/kni/meson.build Signed-off-by: Gabriel Ganne --- .ci/linux-setup.sh| 2 +- doc/guides/linux_gsg/sys_reqs.rst | 2 +- doc/guides/prog_guide/build-sdk-meson.r

Re: [dpdk-dev] [PATCH 1/3] meson: fix minimum required meson version

2021-03-22 Thread Gabriel Ganne
; On Mon, Mar 22, 2021 at 09:38:59AM +0100, Gabriel Ganne wrote: > > > WARNING: Project targetting '>= 0.47.1' but tried to use feature > introduced > > > in '0.48.0': console arg in custom_target > > > > > > console argument

[dpdk-dev] [PATCH v2 3/3] meson: remove unnecessary explicit link to libpcap

2021-03-22 Thread Gabriel Ganne
you configure meson to prefer static linking over dynamic, this will cause the build to fail on librte_port, since the pcap deps are not yet seen by the linker. Signed-off-by: Gabriel Ganne --- config/meson.build | 1 - 1 file changed, 1 deletion(-) diff --git a/config/meson.build b/config

[dpdk-dev] [PATCH v2 2/3] meson: use threads dependency as provided by meson

2021-03-22 Thread Gabriel Ganne
meson guarantees this is portable, so this also allows us to remove a is_windows switch. Link: https://mesonbuild.com/howtox.html#enable-threads Signed-off-by: Gabriel Ganne --- config/meson.build | 5 + lib/librte_metrics/meson.build | 2 ++ lib/librte_telemetry/meson.build

[dpdk-dev] [PATCH v2 1/3] meson: fix minimum required meson version

2021-03-22 Thread Gabriel Ganne
WARNING: Project targeting '>= 0.47.1' but tried to use feature introduced in '0.48.0': console arg in custom_target console argument is used within kernel/linux/kni/meson.build Update documentation and travis setup script accordingly. Signed-off-by: Gabrie

[dpdk-dev] [PATCH 3/3] meson: remove unnecessary explicit link to libpcap

2021-03-22 Thread Gabriel Ganne
you configure meson to prefer static linking over dynamic, this will cause the build to fail on librte_port, since the pcap deps are not yet seen by the linker. Signed-off-by: Gabriel Ganne --- config/meson.build | 1 - 1 file changed, 1 deletion(-) diff --git a/config/meson.build b/config

[dpdk-dev] [PATCH 2/3] meson: use threads dependency as provided by meson

2021-03-22 Thread Gabriel Ganne
meson guarantees this is portable, so this also allows us to remove a is_windows switch. Link: https://mesonbuild.com/howtox.html#enable-threads Signed-off-by: Gabriel Ganne --- config/meson.build | 5 + lib/librte_metrics/meson.build | 2 ++ lib/librte_telemetry/meson.build

[dpdk-dev] [PATCH 1/3] meson: fix minimum required meson version

2021-03-22 Thread Gabriel Ganne
WARNING: Project targetting '>= 0.47.1' but tried to use feature introduced in '0.48.0': console arg in custom_target console argument is used within kernel/linux/kni/meson.build Signed-off-by: Gabriel Ganne --- meson.build | 2 +- 1 file changed, 1 insertion(

[dpdk-dev] [RFC PATCH] meson: remove unnecessary explicit link to libpcap

2021-03-15 Thread Gabriel Ganne
you configure meson to prefer static linking over dynamic, this will cause the build to fail on librte_port, since the pcap deps are not yet seen by the linker. Signed-off-by: Gabriel Ganne --- config/meson.build | 1 - 1 file changed, 1 deletion(-) diff --git a/config/meson.build b/config