RE: [PATCH v02] net/af_packet: add rollover and defrag options

2024-11-03 Thread Gur Stavi
not exist for HW > based > > PMDs and may confuse users. > > > > This patch adds 2 options to control these features: > > rollover=[0|1],defrag=[0|1] > > For backward compatibility both features are enabled by default even > > though most users will probably

[PATCH v02] net/af_packet: add rollover and defrag options

2024-10-31 Thread Gur Stavi
hough most users will probably want both of them disabled. Signed-off-by: Gur Stavi --- v2: * Improve error handling for parsing of arg strings. Add a wrapper around strtoul to replace atoi. * Fix checkpatch indentation error due to copy-paste. v1: https://mails.dpdk.org/archives/dev/2024-October/3

RE: [PATCH v01] net/af_packet: add rollover and defrag options

2024-10-29 Thread Gur Stavi
> > + if (strstr(pair->key, ETH_AF_PACKET_ROLLOVER) != NULL) { > > + rollover = atoi(pair->value); > > + if (rollover != 0 && rollover != 1) { > > + PMD_LOG(ERR, > > + "%s: invalid rollover val

RE: [PATCH v01] net/af_packet: add rollover and defrag options

2024-10-29 Thread Gur Stavi
> On Tue, 29 Oct 2024 15:48:05 +0200 > Gur Stavi wrote: > > > net_af_packet PMD multi "queue" support relies on Linux FANOUT > capability. > > Linux FANOUT is a SW based load balancer that is similar to HW RSS > which is > > more common for DPDK PMDs. I

[PATCH v01] net/af_packet: add rollover and defrag options

2024-10-29 Thread Gur Stavi
hough most users will probably want both of them disabled. Signed-off-by: Gur Stavi --- doc/guides/nics/af_packet.rst | 4 ++ drivers/net/af_packet/rte_eth_af_packet.c | 63 +-- 2 files changed, 51 insertions(+), 16 deletions(-) diff --git a/doc/guides/nics/af_packet

[PATCH v02] net/af_packet: support link status update

2024-10-15 Thread Gur Stavi
For net_af_packet PMD, eth_link_update was an empty function. Application may be interested in link up/down status. This patch adds implementation that updates dev_link->link_status based on socket IFF_RUNNING flag. Signed-off-by: Gur Stavi --- v2: * return error on ioctl error v1: ht

[PATCH v01] net/af_packet: support link status update

2024-10-14 Thread Gur Stavi
For net_af_packet PMD, eth_link_update was an empty function. Application may be interested in link up/down status. This patch adds implementation that updates dev_link->link_status based on socket IFF_RUNNING flag. Signed-off-by: Gur Stavi --- drivers/net/af_packet/rte_eth_af_packet.c |

[PATCH v01] net/af_packet: don't specify protocol on socket create

2024-10-14 Thread Gur Stavi
ation from ETH_P_ALL to 0. Signed-off-by: Gur Stavi --- drivers/net/af_packet/rte_eth_af_packet.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c index 68870dd3e2..b30f88d618 100644 ---