Re: [v4 00/10] DPAA specific fixes

2025-06-18 Thread Hemant Agrawal
for buffer count extracted from mcr->verb. V3: Fixed compilation errors for "bus/dpaa: optimize qman enqueue check" patch. V2: Handled review comments and checkpatch warnings Gagandeep Singh (1): bus/dpaa: improve DPAA cleanup Hemant Agrawal (2): bus/dpaa: avoid using same

Re: [PATCH v5 00/11] NXP DPAA2 driver enhancements and fixes

2025-06-18 Thread Hemant Agrawal
+- 15 files changed, 1238 insertions(+), 148 deletions(-) create mode 100644 drivers/net/dpaa2/mc/fsl_dpmac.h Series- Acked-by: Hemant Agrawal

RE: [PATCH] doc: fix anchors namespace in guides

2025-05-28 Thread Hemant Agrawal
. > > Signed-off-by: Nandini Persad Acked-by: Hemant Agrawal

Re: [PATCH 1/9] common/dpaax: fix invalid key command error

2025-05-19 Thread Hemant Agrawal
On 20-05-2025 11:21, Gagandeep Singh wrote: Due to race between KEY loading to CAAM’s internal memory and initiating crypto operations can SEC errors in PDCP AES algo combinations. Please fix grammar. To mitigate this, adding CALM instruction in SN 12bit case and using older version of descri

Re: [PATCH 6/9] crypto/dpaa2_sec: add null algo capability

2025-05-19 Thread Hemant Agrawal
On 20-05-2025 11:21, Gagandeep Singh wrote: This patch adds NULL algo capabilities. Do you also need to update documentation for the same? Signed-off-by: Gagandeep Singh --- drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 41 +++ 1 file changed, 41 insertions(+) diff --g

Re: [PATCH 3/9] common/dpaax: support 12bit SN in pdcp uplane

2025-05-19 Thread Hemant Agrawal
On 20-05-2025 11:21, Gagandeep Singh wrote: update pdcp_insert_uplane_no_int_op() to support 12bit SN size Signed-off-by: Gagandeep Singh --- drivers/common/dpaax/caamflib/desc/pdcp.h | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/common/dpaax/caa

RE: [PATCH] doc: add limitation in using segment-sz in crypto-perf

2025-05-18 Thread Hemant Agrawal
> -Original Message- > From: Anoob Joseph > Sent: 16 May 2025 20:11 > To: Akhil Goyal ; dev@dpdk.org > Cc: suanmi...@nvidia.com; kai...@intel.com; Hemant Agrawal > ; brian.doo...@intel.com; Akhil Goyal > > Subject: RE: [PATCH] doc: add limitation in using s

RE: [PATCH v1 1/1] bbdev: fix possible null pointer dereference

2025-05-12 Thread Hemant Agrawal
> -Original Message- > From: Maxime Coquelin > Sent: 12 May 2025 17:23 > To: Nicolas Chautru ; dev@dpdk.org > Cc: Hemant Agrawal ; hernan.var...@intel.com > Subject: Re: [PATCH v1 1/1] bbdev: fix possible null pointer dereference > Importance: High > > >

Re: [PATCH 1/4] license: add exception for Linux Kernel uAPI headers

2025-04-17 Thread Hemant Agrawal
| drivers/net/gve/base/* +GPL-2.0 WITH Linux-syscall-note | 12/11/2024 | 04/14/2025 | kernel/linux/uapi/linux/* +----- Acked-by: Hemant Agrawal

Re: [PATCH v7 5/8] build: mark exported symbols

2025-04-03 Thread Hemant Agrawal
for DPAA/FSLMC changes Acked-by: Hemant Agrawal

Re: [PATCH v7 2/8] drivers: remove incorrect exported symbols

2025-04-03 Thread Hemant Agrawal
On 03-04-2025 22:28, David Marchand wrote: Declaring inline helpers in version.map is unnecessary. There is no exported symbol and this will probably be treated as an error by MSVC linker. rte_dpaa2_dev_type is an enum token. roc_se_ctx_swap has no implementation (leftover from a previous rewo

RE: [PATCH v3 11/14] rawdev: remove unnecessary deref of function pointers

2025-02-21 Thread Hemant Agrawal
Acked-by: Hemant Agrawal

RE: [PATCH v2 3/7] bus/fslmc: fix use after free

2025-02-15 Thread Hemant Agrawal
Acked-by: Hemant Agrawal

RE: [PATCH 05/32] dma/dpaa2: replace memcpy with assignment

2025-02-10 Thread Hemant Agrawal
Acked-by: Hemant Agrawal

Re: [PATCH 25/32] net/dpaa2: replace memcpy with structure assignment

2025-02-10 Thread Hemant Agrawal
Acked-by: Hemant Agrawal On 09-02-2025 01:52, Stephen Hemminger wrote: Prefer structure assignment over memcpy. Found by struct-assign.cocci. Signed-off-by: Stephen Hemminger --- drivers/net/dpaa2/dpaa2_ethdev.c | 5 ++--- drivers/net/dpaa2/dpaa2_flow.c | 9 +++-- 2 files changed

Re: [PATCH 19/32] net/dpaa2: replace memcpy with assignment

2025-02-10 Thread Hemant Agrawal
Acked-by: Hemant Agrawal On 09-02-2025 01:52, Stephen Hemminger wrote: Prefer structure assignment over memcpy. Found by cocci/struct_assign.cocci Signed-off-by: Stephen Hemminger --- drivers/net/dpaa2/dpaa2_mux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

Re: [PATCH 07/32] event/dpaa2: replace memcpy with structure assignment

2025-02-10 Thread Hemant Agrawal
Acked-by: Hemant Agrawal On 09-02-2025 01:51, Stephen Hemminger wrote: Prefer structure assignment over memcpy. Found by struct-assign.cocci. Signed-off-by: Stephen Hemminger --- drivers/event/dpaa2/dpaa2_eventdev.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git

Re: [PATCH 04/32] crypto/dpaa_sec: replace memcpy with assignment

2025-02-10 Thread Hemant Agrawal
>cdb; - rte_memcpy(&c_cdb, cdb, sizeof(struct sec_cdb)); + c_cdb = *cdb; #ifdef RTE_LIB_SECURITY fprintf(f, "\nsession protocol type = %d\n", sess->proto_alg); #endif Acked-by: Hemant Agrawal

Re: [PATCH v5 2/4] lib: fix comparison between devices

2025-02-05 Thread Hemant Agrawal
; return devargs; @@ -235,7 +235,7 @@ scan_one_fslmc_device(char *dev_name) } static int -rte_fslmc_parse(const char *name, void *addr) +rte_fslmc_parse(const char *name, void *addr, int *size) { uint16_t dev_id; char *t_ptr; @@ -298,7 +298,10 @@ rte_f

RE: [PATCH] bus/fslmc: fix use after rte_free

2024-12-23 Thread Hemant Agrawal
Acked-by: Hemant Agrawal

Tech Board Meeting Minutes - 2024-Nov-27

2024-12-23 Thread Hemant Agrawal
Members Attending - Bruce Richardson Hemant Agrawal Jerin Jacob Kevin Traynor Maxime Coquelin Morten Brørup Stephen Hemminger Thomas Monjalon NOTE: The technical board meetings are on every second Wednesday at 3pm UTC. Meetings are public, and DPDK community members are

RE: [PATCH] crypto/openssl: fix CMAC auth context update

2024-12-05 Thread Hemant Agrawal
> > Signed-off-by: Wathsala Vithanage > Reviewed-by: Jack Bond-Preston Acked-by: Hemant Agrawal

Re: [PATCH v3] doc: add security document

2024-11-22 Thread Hemant Agrawal
++ 2 files changed, 337 insertions(+) create mode 100644 doc/guides/security/index.rst Reviewed-by:  Hemant Agrawal

Re: [PATCH v2] doc: add security document

2024-11-18 Thread Hemant Agrawal
Hi Nandini,         One minor comment.. - Hemant On 18-11-2024 22:43, Nandini Persad wrote: This is a new document covering security protocols implemented in DPDK. +PDCP + + +Packet Data Convergence Protocol (PDCP) is a sublayer in the LTE radio protocol stack +that provides security

Re: [PATCH 16/16] net/dpaa2: fix bitmask truncation

2024-11-18 Thread Hemant Agrawal
Acked-by: Hemant Agrawal On 15-11-2024 11:35, Stephen Hemminger wrote: The dqrr_held mask is 64 bit but updates were getting truncated because 1 is of type int (32 bit) and the result shift of int is of type int (32 bit); therefore any value >= 32 would get truncated. Link: https://

Re: [PATCH 13/16] crypto/dpaa_sec: fix bitmask truncation

2024-11-18 Thread Hemant Agrawal
PAA_PER_LCORE_DQRR_HELD |= 1 << index; + DPAA_PER_LCORE_DQRR_HELD |= UINT64_C(1) << index; DPAA_PER_LCORE_DQRR_MBUF(index) = ctx->op->sym->m_src; ev->impl_opaque = index + 1; *dpaa_seqn(ctx->op->sym->m_src) = (uint32_t)index + 1; Acked-by: Hemant Agrawal

Re: [PATCH 15/16] net/dpaa: fix bitmask truncation

2024-11-17 Thread Hemant Agrawal
Acked-by: Hemant Agrawal On 15-11-2024 11:35, Stephen Hemminger wrote: The dqrr_held mask is 64 bit but updates were getting truncated because 1 is of type int (32 bit) and the result shift of int is of type int (32 bit); therefore any value >= 32 would get truncated. Link: https://

Re: [PATCH 14/16] event/dpaa: fix bitmask truncation

2024-11-17 Thread Hemant Agrawal
uf) = DPAA_INVALID_MBUF_SEQN; - DPAA_PER_LCORE_DQRR_HELD &= ~(1 << i); + DPAA_PER_LCORE_DQRR_HELD &= ~(UINT64_C(1) << i); DPAA_PER_LCORE_DQRR_SIZE--; } i++; Acked-by: Hemant Agrawal

Re: [PATCH 12/16] crypto/dpaa2_sec: fix bitmask truncation

2024-11-17 Thread Hemant Agrawal
; - DPAA2_PER_LCORE_DQRR_HELD |= 1 << dqrr_index; + DPAA2_PER_LCORE_DQRR_HELD |= UINT64_C(1) << dqrr_index; DPAA2_PER_LCORE_DQRR_MBUF(dqrr_index) = crypto_op->sym->m_src; ev->event_ptr = crypto_op; } Acked-by: Hemant Agrawal

Re: [PATCH 1/2] bus/dpaa: fix lock condition during error handling

2024-11-13 Thread Hemant Agrawal
On 13-11-2024 22:18, David Marchand wrote: Hello Hemant, On Wed, Nov 13, 2024 at 5:15 PM Hemant Agrawal wrote: The error handling is missing FQ unlock code. Detected by pvr-studio Bug 89-93: very suspicious synchronization The analyzer issued a pack of V1020 warnings that a resource might

[PATCH v2 3/3] bus/dpaa: enabling clang thread safety for locks

2024-11-13 Thread Hemant Agrawal
To avoid regressions on this topic, could you look into enabling clang thread safety check? Signed-off-by: David Marchand Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/base/qbman/qman.c | 35 -- drivers/bus/dpaa/meson.build | 2 -- 2 files changed, 19

[PATCH v2 2/3] examples/l2fwd-event: fix spinlock handling

2024-11-13 Thread Hemant Agrawal
Detected by pvs-studio Bug 89-93: very suspicious synchronization The analyzer issued a pack of V1020 warnings that a resource might remain blocked. Fixes: 080f57bceca4 ("examples/l2fwd-event: add eventdev main loop") Cc: pbhagavat...@marvell.com Cc: sta...@dpdk.org Signed-off-by: Hema

[PATCH v2 1/3] bus/dpaa: fix lock condition during error handling

2024-11-13 Thread Hemant Agrawal
ned-off-by: Hemant Agrawal --- drivers/bus/dpaa/base/qbman/qman.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/bus/dpaa/base/qbman/qman.c b/drivers/bus/dpaa/base/qbman/qman.c index 9c90ee25a6..c48fa3e073 100644 --- a/drivers/bus/dpaa/base/qbman/qman.c +++ b/d

Re: [PATCH 2/2] common/dpaax: do not disable fallthrough warnings

2024-11-13 Thread Hemant Agrawal
& (GCC_VERSION >= 7) -#pragma GCC diagnostic ignored "-Wimplicit-fallthrough" -#endif - extern enum rta_sec_era rta_sec_era; static inline int Acked-by: Hemant Agrawal

[PATCH 2/2] examples/l2fwd-event: fix spinlock handling

2024-11-13 Thread Hemant Agrawal
Detected by pvr-studio Bug 89-93: very suspicious synchronization The analyzer issued a pack of V1020 warnings that a resource might remain blocked. Fixes: 080f57bceca4 ("examples/l2fwd-event: add eventdev main loop") Cc: pbhagavat...@marvell.com Cc: sta...@dpdk.org Signed-off-by: Hema

[PATCH 1/2] bus/dpaa: fix lock condition during error handling

2024-11-13 Thread Hemant Agrawal
ned-off-by: Hemant Agrawal --- drivers/bus/dpaa/base/qbman/qman.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/bus/dpaa/base/qbman/qman.c b/drivers/bus/dpaa/base/qbman/qman.c index 9c90ee25a6..c48fa3e073 100644 --- a/drivers/bus/dpaa/base/qbman/qman.c +++ b/d

Re: [PATCH] doc/guides: add security document

2024-11-12 Thread Hemant Agrawal
Hi Nandini,    On 13-11-2024 10:08, Nandini Persad wrote: This is a new document covering security protocols implemented in DPDK. Signed-off-by: Nandini Persad Signed-off-by: Thomas Monjalon Reviewed-by: Stephen Hemminger --- doc/guides/index.rst | 1 + doc/guides/secu

Re: [PATCH 2/3] net/dpaa2: remove unnecessary check for null before rte_free

2024-11-12 Thread Hemant Agrawal
Acked-by: Hemant Agrawal On 12-11-2024 23:08, Stephen Hemminger wrote: Calling rte_free() with NULL parameter is allowed. Found by nullfree.cocci Fixes: 5964d36a2904 ("net/dpaa2: release port upon close") Cc: sachin.sax...@oss.nxp.com Signed-off-by: Stephen Hemminger --- drivers

Re: [PATCH 1/3] bus/fslmc: remove unnecessary null check

2024-11-12 Thread Hemant Agrawal
Acked-by: Hemant Agrawal On 12-11-2024 23:08, Stephen Hemminger wrote: No need for check for null before calling free(). Caught by nullfree.cocci script. Fixes: 57cb02edf122 ("bus/fslmc: enhance MC VFIO multi-process support") Cc: jun.y...@nxp.com Signed-off-by: Stephen

[PATCH] bus/fslmc: fix bus scan return failure value

2024-11-11 Thread Hemant Agrawal
fslmc bus will not be available on non DPAA2 platform. Do not return error on scan failure. Signed-off-by: Hemant Agrawal --- drivers/bus/fslmc/fslmc_bus.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/bus/fslmc/fslmc_bus.c b/drivers/bus/fslmc/fslmc_bus.c

RE: Bus scan is too chatty

2024-11-11 Thread Hemant Agrawal
> -Original Message- > From: Thomas Monjalon > Sent: Monday, November 11, 2024 3:02 PM > To: Stephen Hemminger ; Gagandeep Singh > ; Sachin Saxena (OSS) ; > Hemant Agrawal > Cc: dev@dpdk.org > Subject: Re: Bus scan is too chatty > Importance: High >

RE: [v5 00/42] DPAA2 specific patches

2024-11-07 Thread Hemant Agrawal
ot;bus/fslmc: dynamic IOVA mode configuration" > > Apeksha Gupta (2): > net/dpaa2: add proper MTU debugging print > net/dpaa2: store drop priority in mbuf > > Brick Yang (1): > net/dpaa2: update DPNI link status method > > Gagandeep Singh (3): > bus/fslmc:

Re: [PATCH v1 1/2] app/bbdev: add capture of queue dump

2024-10-28 Thread Hemant Agrawal
Reviewed-by:  Hemant Agrawal On 25-10-2024 23:27, Nicolas Chautru wrote: Capturing additional queue dump information in the bbdev-test application using the api introduced earlier. Signed-off-by: Nicolas Chautru --- app/test-bbdev/test_bbdev_perf.c | 16 1 file changed

Re: [PATCH v1 2/2] app/bbdev: add support for interrupt disable

2024-10-28 Thread Hemant Agrawal
Reviewed-by:  Hemant Agrawal On 25-10-2024 23:27, Nicolas Chautru wrote: Adding support for calling the interrupt disable api for coverage. Signed-off-by: Nicolas Chautru --- app/test-bbdev/test_bbdev_perf.c | 24 1 file changed, 24 insertions(+) diff --git a/app

[PATCH 1/4] crypto/dpaa_sec: enhance IPsec extended sequence number

2024-10-25 Thread Hemant Agrawal
From: Gagandeep Singh Setting ESN seq number initialization. Initialize the sequence number of ESP to 1. Signed-off-by: Gagandeep Singh Signed-off-by: Barry Cao --- drivers/crypto/dpaa_sec/dpaa_sec.c | 17 ++--- drivers/crypto/dpaa_sec/dpaa_sec.h | 10 +++--- 2 files changed,

Re: [PATCH v2 0/6] Clean up many __builtin_* in drivers.

2024-10-25 Thread Hemant Agrawal
On 25-10-2024 12:34, David Marchand wrote: Here is a series cleaning up most of uses of __builtin_* helpers in drivers when they have a direct replacement in EAL. checkpatch is extended to forbid new additions. Series- Acked-by: Hemant Agrawal

[PATCH 2/4] crypto/dpaa_sec: enabling diffserv and ECN support

2024-10-24 Thread Hemant Agrawal
Enabling DIFFSERV and ECN in IPSEC proto offload descriptor. Signed-off-by: Hemant Agrawal --- drivers/crypto/dpaa_sec/dpaa_sec.c | 14 -- drivers/crypto/dpaa_sec/dpaa_sec.h | 8 2 files changed, 20 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/dpaa_sec

[PATCH 4/4] crypto/dpaa2_sec: add support for IPv6 UDP encap

2024-10-24 Thread Hemant Agrawal
This patch enables support for NAT-T traversal in IPSEC ESP protocol offload mode for IPv6 Signed-off-by: Hemant Agrawal --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 68 + 1 file changed, 43 insertions(+), 25 deletions(-) diff --git a/drivers/crypto/dpaa2_sec

[PATCH 3/4] crypto/dpaa_sec: add support for UDP-encapsulated ESP

2024-10-24 Thread Hemant Agrawal
From: Barry Cao This patch enables support for NAT-T traversal in IPSEC ESP protocol offload mode. Signed-off-by: Hemant Agrawal Signed-off-by: Barry Cao --- drivers/crypto/dpaa_sec/dpaa_sec.c | 63 -- drivers/crypto/dpaa_sec/dpaa_sec.h | 14 +++ 2 files

Re: [v7 02/15] dma/dpaa2: refactor driver code

2024-10-15 Thread Hemant Agrawal
On 16-10-2024 10:43, Stephen Hemminger wrote: On Wed, 16 Oct 2024 10:39:40 +0530 Hemant Agrawal wrote: diff --git a/devtools/build-dict.sh b/devtools/build-dict.sh index a8cac49029..d503fb52fc 100755 --- a/devtools/build-dict.sh +++ b/devtools/build-dict.sh @@ -17,6 +17,8 @@ sed '/^.

Re: [v7 02/15] dma/dpaa2: refactor driver code

2024-10-15 Thread Hemant Agrawal
^uint->/d' | sed "/^doesn'->/d" | sed '/^wasn->/d' | +sed '/^ser->/d' | +sed '/^fle->/d' | # print to stdout cat Hi Stephen,     It may not be good idea to add these.  For DPAA these are proper keyboard, however for others - *fle* can be a spelling mistake of *file* Regards, Hemant

[PATCH] net/dpaa/fmlib: remove new line char from the logs

2024-10-15 Thread Hemant Agrawal
This patch remove the new line char from several logs in the fmlib base driver. Signed-off-by: Hemant Agrawal --- drivers/net/dpaa/fmlib/fm_ext.h | 21 +++-- drivers/net/dpaa/fmlib/fm_lib.c | 76 - drivers/net/dpaa/fmlib/fm_vsp.c | 20 - 3 files

Re: [PATCH] cryptodev: remove unnecessary list end

2024-10-09 Thread Hemant Agrawal
num rte_crypto_rsa_padding_type { /**< RSA PKCS#1 OAEP padding scheme */ RTE_CRYPTO_RSA_PADDING_PSS, /**< RSA PKCS#1 PSS padding scheme */ - RTE_CRYPTO_RSA_PADDING_TYPE_LIST_END }; /** Acked-by: Hemant Agrawal

Re: [PATCH v2] rawdev: add API to get device from index

2024-10-08 Thread Hemant Agrawal
Reviewed-by:  Hemant Agrawal On 08-10-2024 13:10, Akhil Goyal wrote: Added an internal API for PMDs to get raw device pointer from a device id. Signed-off-by: Akhil Goyal --- - resend patch for main branch separated from rvu_lf raw driver https://patches.dpdk.org/project/dpdk/list/?series

Re: [PATCH v2 03/14] net/dpaa: remove broken debug macros

2024-10-01 Thread Hemant Agrawal
the calls to these macros? I was unclear if the fmlib enters the "base driver" category. So I simply removed macros from the header providing wrappers to dpdk API. Relooking, I see other changes in this directory, so I agree I may as well remove those calls. Hemant, opinion? Yes, fm

[PATCH v5 07/18] net/dpaa: add support to separate Tx conf queues

2024-10-01 Thread Hemant Agrawal
From: Vanshika Shukla This patch separates Tx confirmation queues for kernel and DPDK so as to support the VSP case. Signed-off-by: Vanshika Shukla Acked-by: Hemant Agrawal --- drivers/bus/dpaa/include/fsl_qman.h | 4 ++- drivers/net/dpaa/dpaa_ethdev.c | 45

[PATCH v5 01/18] bus/dpaa: fix PFDRs leaks due to FQRNIs

2024-10-01 Thread Hemant Agrawal
From: Gagandeep Singh When a Retire FQ command is executed on a FQ in the Tentatively Scheduled or Parked states, in that case FQ is retired immediately and a FQRNI (Frame Queue Retirement Notification Immediate) message is generated. Software must read this message from MR and consume it to free

[PATCH v5 03/18] bus/dpaa: fix VSP for 1G fm1-mac9 and 10

2024-10-01 Thread Hemant Agrawal
ned-off-by: Hemant Agrawal --- drivers/bus/dpaa/base/fman/fman.c | 29 +++-- 1 file changed, 27 insertions(+), 2 deletions(-) diff --git a/drivers/bus/dpaa/base/fman/fman.c b/drivers/bus/dpaa/base/fman/fman.c index 41195eb0a7..beeb03dbf2 100644 --- a/drivers/bus/dpaa/base/f

[PATCH v5 12/18] net/dpaa: enhance DPAA frame display

2024-10-01 Thread Hemant Agrawal
This patch enhances the received packet debugging capability. This help displaying the full packet parsing output. Signed-off-by: Jun Yang Signed-off-by: Hemant Agrawal --- doc/guides/nics/dpaa.rst | 5 ++ drivers/net/dpaa/dpaa_ethdev.c | 9 +++ drivers/net/dpaa/dpaa_rxtx.c | 138

[PATCH v5 15/18] bus/dpaa: add ONIC port mode for the DPAA eth

2024-10-01 Thread Hemant Agrawal
From: Rohit Raj The OH ports can also be used by two application, processing contexts to communicate to each other. This patch enables this mode for dpaa-eth OH port as ONIC port, so that application can use the dpaa-eth to communicate to each other on the same SoC. Again,this properties is driv

[PATCH v5 06/18] net/dpaa: support Tx confirmation to enable PTP

2024-10-01 Thread Hemant Agrawal
: Hemant Agrawal --- doc/guides/nics/dpaa.rst | 3 + drivers/net/dpaa/dpaa_ethdev.c | 124 ++--- drivers/net/dpaa/dpaa_ethdev.h | 4 +- drivers/net/dpaa/dpaa_rxtx.c | 49 + drivers/net/dpaa/dpaa_rxtx.h | 2 + 5 files changed, 154 insertions

[PATCH v5 17/18] net/dpaa: improve dpaa errata A010022 handling

2024-10-01 Thread Hemant Agrawal
From: Jun Yang This patch improves the errata handling for "RTE_LIBRTE_DPAA_ERRATA_LS1043_A010022" Signed-off-by: Jun Yang --- drivers/net/dpaa/dpaa_rxtx.c | 40 1 file changed, 32 insertions(+), 8 deletions(-) diff --git a/drivers/net/dpaa/dpaa_rxtx.c b/d

[PATCH v5 10/18] net/dpaa: support IEEE 1588 PTP

2024-10-01 Thread Hemant Agrawal
From: Vanshika Shukla This patch adds the support for the ethdev APIs to enable/disable and read/write/adjust IEEE1588 PTP timestamps for DPAA platform. Signed-off-by: Vanshika Shukla --- doc/guides/nics/dpaa.rst | 1 + doc/guides/nics/features/dpaa.ini | 1 + drivers/bus/dpaa/base/

[PATCH v5 16/18] net/dpaa: improve the dpaa port cleanup

2024-10-01 Thread Hemant Agrawal
From: Gagandeep Singh During DPAA cleanup in FMCLESS mode, application can see segmentation fault in device close API and in DPAA destructor execution. Segmentation fault in device close is because driver reducing the number of queues initialised during device configuration without releasing the

[PATCH v5 18/18] net/dpaa: fix reallocate_mbuf handling

2024-10-01 Thread Hemant Agrawal
From: Vanshika Shukla This patch fixes the bug in the reallocate_mbuf code handling. The source location is corrected when copying the data in the new mbuf. Fixes: f8c7a17a48c9 ("net/dpaa: support Tx scatter gather for non-DPAA buffer") Cc: sta...@dpdk.org Signed-off-by: Vanshika Shukla --- d

[PATCH v5 09/18] net/dpaa: support Rx/Tx timestamp read

2024-10-01 Thread Hemant Agrawal
From: Vanshika Shukla This patch implements Rx/Tx timestamp read operations for DPAA1 platform. Signed-off-by: Vanshika Shukla --- doc/guides/nics/features/dpaa.ini| 1 + drivers/bus/dpaa/base/fman/fman.c| 21 +++- drivers/bus/dpaa/base/fman/fman_hw.c | 6 ++- drivers/bus/dpaa/in

[PATCH v5 11/18] net/dpaa: implement detailed packet parsing

2024-10-01 Thread Hemant Agrawal
This patch implements the detailed packet parsing using the annotation info from the hardware. decode parser to set RX muf packet type by dpaa_slow_parsing. Support to identify the IPSec ESP, GRE and SCTP packets. Signed-off-by: Jun Yang Signed-off-by: Hemant Agrawal --- drivers/net/dpaa

[PATCH v5 14/18] bus/dpaa: add OH port mode for dpaa eth

2024-10-01 Thread Hemant Agrawal
From: Rohit Raj NXP DPAA architecture supports the concept of DPAA port as Offline Port - meaning - not connected to an actual MAC. This is an hardware assisted IPC mechanism for communiting between two applications. Offline(O/H) port is a type of hardware port which is able to dequeue and enque

[PATCH v5 13/18] net/dpaa: support mempool debug

2024-10-01 Thread Hemant Agrawal
From: Gagandeep Singh This patch adds support to compile time debug the mempool corruptions in dpaa driver. Signed-off-by: Gagandeep Singh --- drivers/net/dpaa/dpaa_rxtx.c | 40 1 file changed, 40 insertions(+) diff --git a/drivers/net/dpaa/dpaa_rxtx.c b/d

[PATCH v5 08/18] net/dpaa: share MAC FMC scheme and CC parse

2024-10-01 Thread Hemant Agrawal
ed-by: Hemant Agrawal --- drivers/bus/dpaa/include/fman.h | 1 + drivers/net/dpaa/dpaa_ethdev.c | 60 +++-- drivers/net/dpaa/dpaa_ethdev.h | 13 +- drivers/net/dpaa/dpaa_flow.c| 8 +- drivers/net/dpaa/dpaa_fmc.c | 421 drivers/net/dpaa/dpaa_rxtx.c

[PATCH v5 00/18] NXP DPAA ETH driver enhancement and fixes

2024-10-01 Thread Hemant Agrawal
: fix PFDRs leaks due to FQRNIs net/dpaa: support mempool debug net/dpaa: improve the dpaa port cleanup Hemant Agrawal (5): bus/dpaa: fix VSP for 1G fm1-mac9 and 10 bus/dpaa: fix the fman details status bus/dpaa: add port buffer manager stats net/dpaa: implement detailed packet parsing

[PATCH v5 04/18] bus/dpaa: fix the fman details status

2024-10-01 Thread Hemant Agrawal
Fix the incorrect placing of brackets to calculate stats. This corrects the "(a | b) << 32" to "a | (b << 32)" Fixes: e62a3f4183f1 ("bus/dpaa: fix statistics reading") Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/base/fman/

[PATCH v5 02/18] net/dpaa: fix typecasting ch ID to u32

2024-10-01 Thread Hemant Agrawal
From: Rohit Raj Avoid typecasting ch_id to u32 and passing it to another API since it can corrupt other data. Instead, create new u32 variable and typecase it back to u16 after it gets updated by the API. Fixes: 0c504f6950b6 ("net/dpaa: support push mode") Cc: hemant.agra...@nxp.com Cc: sta...@d

[PATCH v5 05/18] bus/dpaa: add port buffer manager stats

2024-10-01 Thread Hemant Agrawal
Add BMI statistics and improving the existing extended statistics Signed-off-by: Hemant Agrawal Signed-off-by: Gagandeep Singh --- drivers/bus/dpaa/base/fman/fman_hw.c | 61 drivers/bus/dpaa/include/fman.h | 4 +- drivers/bus/dpaa/include/fsl_fman.h | 12

[PATCH v4 13/18] net/dpaa: support mempool debug

2024-09-30 Thread Hemant Agrawal
From: Gagandeep Singh This patch adds support to compile time debug the mempool corruptions in dpaa driver. Signed-off-by: Gagandeep Singh --- drivers/net/dpaa/dpaa_rxtx.c | 40 1 file changed, 40 insertions(+) diff --git a/drivers/net/dpaa/dpaa_rxtx.c b/d

[PATCH v4 06/18] net/dpaa: support Tx confirmation to enable PTP

2024-09-30 Thread Hemant Agrawal
: Hemant Agrawal --- doc/guides/nics/dpaa.rst | 3 + drivers/net/dpaa/dpaa_ethdev.c | 124 ++--- drivers/net/dpaa/dpaa_ethdev.h | 4 +- drivers/net/dpaa/dpaa_rxtx.c | 49 + drivers/net/dpaa/dpaa_rxtx.h | 2 + 5 files changed, 154 insertions

[PATCH v4 04/18] bus/dpaa: fix the fman details status

2024-09-30 Thread Hemant Agrawal
Fix the incorrect placing of brackets to calculate stats. This corrects the "(a | b) << 32" to "a | (b << 32)" Fixes: e62a3f4183f1 ("bus/dpaa: fix statistics reading") Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/base/fman/

[PATCH v4 18/18] net/dpaa: fix reallocate_mbuf handling

2024-09-30 Thread Hemant Agrawal
From: Vanshika Shukla This patch fixes the bug in the reallocate_mbuf code handling. The source location is corrected when copying the data in the new mbuf. Fixes: f8c7a17a48c9 ("net/dpaa: support Tx scatter gather for non-DPAA buffer") Cc: sta...@dpdk.org Signed-off-by: Vanshika Shukla --- d

[PATCH v4 07/18] net/dpaa: add support to separate Tx conf queues

2024-09-30 Thread Hemant Agrawal
From: Vanshika Shukla This patch separates Tx confirmation queues for kernel and DPDK so as to support the VSP case. Signed-off-by: Vanshika Shukla Acked-by: Hemant Agrawal --- drivers/bus/dpaa/include/fsl_qman.h | 4 ++- drivers/net/dpaa/dpaa_ethdev.c | 45

[PATCH v4 16/18] net/dpaa: improve the dpaa port cleanup

2024-09-30 Thread Hemant Agrawal
From: Gagandeep Singh During DPAA cleanup in FMCLESS mode, application can see segmentation fault in device close API and in DPAA destructor execution. Segmentation fault in device close is because driver reducing the number of queues initialised during device configuration without releasing the

[PATCH v4 17/18] net/dpaa: improve dpaa errata A010022 handling

2024-09-30 Thread Hemant Agrawal
From: Jun Yang This patch improves the errata handling for "RTE_LIBRTE_DPAA_ERRATA_LS1043_A010022" Signed-off-by: Jun Yang --- drivers/net/dpaa/dpaa_rxtx.c | 40 1 file changed, 32 insertions(+), 8 deletions(-) diff --git a/drivers/net/dpaa/dpaa_rxtx.c b/d

[PATCH v4 15/18] bus/dpaa: add ONIC port mode for the DPAA eth

2024-09-30 Thread Hemant Agrawal
From: Rohit Raj The OH ports can also be used by two application, processing contexts to communicate to each other. This patch enables this mode for dpaa-eth OH port as ONIC port, so that application can use the dpaa-eth to communicate to each other on the same SoC. Again,this properties is driv

[PATCH v4 14/18] bus/dpaa: add OH port mode for dpaa eth

2024-09-30 Thread Hemant Agrawal
From: Rohit Raj NXP DPAA architecture supports the concept of DPAA port as Offline Port - meaning - not connected to an actual MAC. This is an hardware assited IPC mechanism for communiting between two applications. Offline(O/H) port is a type of hardware port which is able to dequeue and enqueu

[PATCH v4 12/18] net/dpaa: enhance DPAA frame display

2024-09-30 Thread Hemant Agrawal
This patch enhances the received packet debugging capability. This help displaying the full packet parsing output. Signed-off-by: Jun Yang Signed-off-by: Hemant Agrawal --- doc/guides/nics/dpaa.rst | 5 ++ drivers/net/dpaa/dpaa_ethdev.c | 9 +++ drivers/net/dpaa/dpaa_rxtx.c | 138

[PATCH v4 11/18] net/dpaa: implement detailed packet parsing

2024-09-30 Thread Hemant Agrawal
This patch implements the detailed packet parsing using the annotation info from the hardware. decode parser to set RX muf packet type by dpaa_slow_parsing. Support to identify the IPSec ESP, GRE and SCTP packets. Signed-off-by: Jun Yang Signed-off-by: Hemant Agrawal --- drivers/net/dpaa

[PATCH v4 10/18] net/dpaa: support IEEE 1588 PTP

2024-09-30 Thread Hemant Agrawal
From: Vanshika Shukla This patch adds the support for the ethdev APIs to enable/disable and read/write/adjust IEEE1588 PTP timestamps for DPAA platform. Signed-off-by: Vanshika Shukla --- doc/guides/nics/dpaa.rst | 1 + doc/guides/nics/features/dpaa.ini | 1 + drivers/bus/dpaa/base/

[PATCH v4 09/18] net/dpaa: support Rx/Tx timestamp read

2024-09-30 Thread Hemant Agrawal
From: Vanshika Shukla This patch implements Rx/Tx timestamp read operations for DPAA1 platform. Signed-off-by: Vanshika Shukla --- doc/guides/nics/features/dpaa.ini| 1 + drivers/bus/dpaa/base/fman/fman.c| 21 +++- drivers/bus/dpaa/base/fman/fman_hw.c | 6 ++- drivers/bus/dpaa/in

[PATCH v4 08/18] net/dpaa: share MAC FMC scheme and CC parse

2024-09-30 Thread Hemant Agrawal
ed-by: Hemant Agrawal --- drivers/bus/dpaa/include/fman.h | 1 + drivers/net/dpaa/dpaa_ethdev.c | 60 +++-- drivers/net/dpaa/dpaa_ethdev.h | 13 +- drivers/net/dpaa/dpaa_flow.c| 8 +- drivers/net/dpaa/dpaa_fmc.c | 421 drivers/net/dpaa/dpaa_rxtx.c

[PATCH v4 05/18] bus/dpaa: add port buffer manager stats

2024-09-30 Thread Hemant Agrawal
Add BMI statistics and improving the existing extended statistics Signed-off-by: Hemant Agrawal Signed-off-by: Gagandeep Singh --- drivers/bus/dpaa/base/fman/fman_hw.c | 61 drivers/bus/dpaa/include/fman.h | 4 +- drivers/bus/dpaa/include/fsl_fman.h | 12

[PATCH v4 02/18] net/dpaa: fix typecasting ch ID to u32

2024-09-30 Thread Hemant Agrawal
From: Rohit Raj Avoid typecasting ch_id to u32 and passing it to another API since it can corrupt other data. Instead, create new u32 variable and typecase it back to u16 after it gets updated by the API. Fixes: 0c504f6950b6 ("net/dpaa: support push mode") Cc: hemant.agra...@nxp.com Cc: sta...@d

[PATCH v4 01/18] bus/dpaa: fix PFDRs leaks due to FQRNIs

2024-09-30 Thread Hemant Agrawal
From: Gagandeep Singh When a Retire FQ command is executed on a FQ in the Tentatively Scheduled or Parked states, in that case FQ is retired immediately and a FQRNI (Frame Queue Retirement Notification Immediate) message is generated. Software must read this message from MR and consume it to free

[PATCH v4 00/18] NXP DPAA ETH driver enhancement and fixes

2024-09-30 Thread Hemant Agrawal
debug net/dpaa: improve the dpaa port cleanup Hemant Agrawal (5): bus/dpaa: fix VSP for 1G fm1-mac9 and 10 bus/dpaa: fix the fman details status bus/dpaa: add port buffer manager stats net/dpaa: implement detailed packet parsing net/dpaa: enhance DPAA frame display Jun Yang (2): net

[PATCH v4 03/18] bus/dpaa: fix VSP for 1G fm1-mac9 and 10

2024-09-30 Thread Hemant Agrawal
ned-off-by: Hemant Agrawal --- drivers/bus/dpaa/base/fman/fman.c | 29 +++-- 1 file changed, 27 insertions(+), 2 deletions(-) diff --git a/drivers/bus/dpaa/base/fman/fman.c b/drivers/bus/dpaa/base/fman/fman.c index 41195eb0a7..beeb03dbf2 100644 --- a/drivers/bus/dpaa/base/f

[PATCH v3 18/18] net/dpaa: fix reallocate_mbuf handling

2024-09-30 Thread Hemant Agrawal
From: Vanshika Shukla This patch fixes the bug in the reallocate_mbuf code handling. The source location is corrected when copying the data in the new mbuf. Fixes: f8c7a17a48c9 ("net/dpaa: support Tx scatter gather for non-DPAA buffer") Cc: sta...@dpdk.org Signed-off-by: Vanshika Shukla --- d

[PATCH v3 17/18] net/dpaa: improve dpaa errata A010022 handling

2024-09-30 Thread Hemant Agrawal
From: Jun Yang This patch improves the errata handling for "RTE_LIBRTE_DPAA_ERRATA_LS1043_A010022" Signed-off-by: Jun Yang --- drivers/net/dpaa/dpaa_rxtx.c | 40 1 file changed, 32 insertions(+), 8 deletions(-) diff --git a/drivers/net/dpaa/dpaa_rxtx.c b/d

[PATCH v3 16/18] net/dpaa: improve the dpaa port cleanup

2024-09-30 Thread Hemant Agrawal
From: Gagandeep Singh During DPAA cleanup in FMCLESS mode, application can see segmentation fault in device close API and in DPAA destructor execution. Segmentation fault in device close is because driver reducing the number of queues initialised during device configuration without releasing the

[PATCH v3 15/18] bus/dpaa: add ONIC port mode for the DPAA eth

2024-09-30 Thread Hemant Agrawal
From: Rohit Raj The OH ports can also be used by two application, processing contexts to communicate to each other. This patch enables this mode for dpaa-eth OH port as ONIC port, so that application can use the dpaa-eth to communicate to each other on the same SoC. Again,this properties is driv

[PATCH v3 14/18] bus/dpaa: add OH port mode for dpaa eth

2024-09-30 Thread Hemant Agrawal
From: Rohit Raj NXP DPAA architecture supports the concept of DPAA port as Offline Port - meaning - not connected to an actual MAC. This is an hardware assited IPC mechanism for communiting between two applications. Offline(O/H) port is a type of hardware port which is able to dequeue and enqueu

[PATCH v3 13/18] net/dpaa: support mempool debug

2024-09-30 Thread Hemant Agrawal
From: Gagandeep Singh This patch adds support to compile time debug the mempool corruptions in dpaa driver. Signed-off-by: Gagandeep Singh --- drivers/net/dpaa/dpaa_rxtx.c | 40 1 file changed, 40 insertions(+) diff --git a/drivers/net/dpaa/dpaa_rxtx.c b/d

[PATCH v3 12/18] net/dpaa: enhance DPAA frame display

2024-09-30 Thread Hemant Agrawal
This patch enhances the received packet debugging capability. This help displaying the full packet parsing output. Signed-off-by: Jun Yang Signed-off-by: Hemant Agrawal --- doc/guides/nics/dpaa.rst | 5 ++ drivers/net/dpaa/dpaa_ethdev.c | 9 +++ drivers/net/dpaa/dpaa_rxtx.c | 138

  1   2   3   4   5   6   7   8   9   10   >