[PATCH 0/2] usertools: use argparse module to get input and add an argment

2023-01-08 Thread Huisong Li
The telemetry client script uses argparse module to get input and addes an optional argment for file prefix. Huisong Li (2): usertools: use argparse module to get input parameter usertools: add an argment for file prefix usertools/dpdk-telemetry-client.py | 39

[PATCH 2/2] usertools: add an argment for file prefix

2023-01-08 Thread Huisong Li
ile prefix, like, "./dpdk-telemetry-client.py -f rte_xxx -s file_path" Signed-off-by: Huisong Li --- usertools/dpdk-telemetry-client.py | 25 - 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/usertools/dpdk-telemetry-client.py b/usertools/dpdk-t

[PATCH 1/2] usertools: use argparse module to get input parameter

2023-01-08 Thread Huisong Li
The telemetry client script uses argparse module to get input parameter. Signed-off-by: Huisong Li --- usertools/dpdk-telemetry-client.py | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/usertools/dpdk-telemetry-client.py b/usertools/dpdk-telemetry-client.py

[PATCH] net/hns3: fix inaccurate RTC time to read

2023-01-09 Thread Huisong Li
The sequence of reading current RTC time register doesn't meet the hardware requirements, which causes this time obtained is the one before modifying RTC time. Fixes: 38b539d96eb6 ("net/hns3: support IEEE 1588 PTP") Cc: sta...@dpdk.org Signed-off-by: Huisong Li --- drivers/net/

[PATCH v2 0/2] usertools: usertools: use argparse to get input and add an argument

2023-01-09 Thread Huisong Li
The telemetry client script uses argparse to get local socket file path and file prefix path. --- v2: use an optional positional arguments for local socket path to keep backward compatibility. Huisong Li (2): usertools: use argparse module to get input parameter usertools: add an

[PATCH v2 1/2] usertools: use argparse module to get input parameter

2023-01-09 Thread Huisong Li
The telemetry client script uses argparse module to get input parameter. argparse uses an optional positional arguments for local socket path to keep backward compatibility. Signed-off-by: Huisong Li --- usertools/dpdk-telemetry-client.py | 14 +++--- 1 file changed, 7 insertions(+), 7

[PATCH v2 2/2] usertools: add an argument for file prefix

2023-01-09 Thread Huisong Li
ile prefix, like, "./dpdk-telemetry-client.py -f rte_xxx sock_path" Signed-off-by: Huisong Li Acked-by: Bruce Richardson --- usertools/dpdk-telemetry-client.py | 25 - 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/usertools/dpdk-telemetry-cl

[PATCH V5 0/5] app/testpmd: support multiple process attach and detach port

2023-01-30 Thread Huisong Li
for other bus type. #2 add a RTE_ETH_DEV_ALLOCATED state in rte_eth_dev_state to resolve the probelm in patch 2/5. -v2: resend due to CI unexplained failure. Huisong Li (5): drivers/bus: restore driver assignment at front of probing ethdev: fix skip valid port in probing ca

[PATCH V5 2/5] ethdev: fix skip valid port in probing callback

2023-01-30 Thread Huisong Li
be8cd210379a ("ethdev: fix port probing notification") Cc: sta...@dpdk.org Signed-off-by: Huisong Li --- drivers/net/bnxt/bnxt_ethdev.c | 3 ++- drivers/net/mlx5/mlx5.c| 2 +- lib/ethdev/ethdev_driver.c | 13 ++--- lib/ethdev/ethdev_driver.h | 12

[PATCH V5 1/5] drivers/bus: restore driver assignment at front of probing

2023-01-30 Thread Huisong Li
need to be updated if we do that. The driver pointer in rte_device is set before probing and needs to be reset if probing failed. And rte_dev_is_probed can not be called inside probing. Fixes: 391797f04208 ("drivers/bus: move driver assignment to end of probing") Cc: sta...@dpdk.org Si

[PATCH V5 3/5] app/testpmd: check the validity of the port

2023-01-30 Thread Huisong Li
This patch checks the validity of port id for all events in 'eth_event_callback()'. Signed-off-by: Huisong Li Acked-by: Aman Singh --- app/test-pmd/testpmd.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testp

[PATCH V5 4/5] app/testpmd: add attach and detach port for multiple process

2023-01-30 Thread Huisong Li
state is changed from 'ATTACHED' to 'UNUSED' only after the event callback finished. But the remove_invalid_ports() function removes invalid port only if ethdev state is 'UNUSED'. If we don't add alarm callback, this detached port information can not be removed. Sig

[PATCH V5 5/5] app/testpmd: stop forwarding in new or destroy event

2023-01-30 Thread Huisong Li
When testpmd receives the new or destroy event, the port related information will be updated. Testpmd must stop packet forwarding before updating the information to avoid some serious problems. Signed-off-by: Huisong Li --- app/test-pmd/testpmd.c | 4 1 file changed, 4 insertions(+) diff

[PATCH V6] ethdev: fix one address occupies two entries in MAC addrs

2023-01-30 Thread Huisong Li
default address is removed from the rest of the list. Fixes: 854d8ad4ef68 ("ethdev: add default mac address modifier") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Acked-by: Chengwen Feng --- v6: fix commit log and some code comments.

[PATCH V7] ethdev: fix one address occupies two entries in MAC addrs

2023-02-01 Thread Huisong Li
default address is removed from the rest of the list if the address was already in the list. Fixes: 854d8ad4ef68 ("ethdev: add default mac address modifier") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Acked-by: Chengwen Feng --- v7: add announcement in the release notes and docum

[PATCH V8] ethdev: fix one address occupies two entries in MAC addrs

2023-02-02 Thread Huisong Li
the new default address is removed from the rest of the list if the address was already in the list. Fixes: 854d8ad4ef68 ("ethdev: add default mac address modifier") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Acked-by: Chengwen Feng --- v8: fix some comments. v7: add announcemen

[PATCH] net/bonding: fix bond4 drop valid MAC packets

2022-10-18 Thread Huisong Li
Cc: sta...@dpdk.org Signed-off-by: Huisong Li --- drivers/net/bonding/rte_eth_bond_pmd.c | 33 +++--- 1 file changed, 25 insertions(+), 8 deletions(-) diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c index 27005c747c..e2326883de 1006

[PATCH V5] ethdev: fix one address occupies two indexes in MAC addrs

2022-10-20 Thread Huisong Li
ts this behavior. Fixes: 854d8ad4ef68 ("ethdev: add default mac address modifier") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- v5: - merge the second patch into the first patch. - add error log when rollback failed. v4: - fix broken in the patchwork

[PATCH V3] net/bonding: add link speeds configuration

2022-09-21 Thread Huisong Li
This patch adds link speeds configuration. --- -v3: add an intersection of the supported speeds to check 'link_speeds'. -v2: resend due to CI compiling failure. Signed-off-by: Huisong Li --- drivers/net/bonding/eth_bond_private.h | 3 +++ drivers/net/bonding/rte_eth_bond_

[PATCH] net/bonding: fix slave device Rx/Tx offload configuration

2022-10-27 Thread Huisong Li
within the offload configurations of bond interface. Fixes: 57b156540f51 ("net/bonding: fix offloading configuration") Cc: sta...@dpdk.org Signed-off-by: Huisong Li --- drivers/net/bonding/rte_eth_bond_pmd.c | 17 - 1 file changed, 4 insertions(+), 13 deletions(-) di

[PATCH] app/testpmd: update bond port configurations when add slave

2022-10-27 Thread Huisong Li
cause failure when re-initialize bonding device. So port configurations of bonding device also need to be updated because of the added and removed capabilities. In addition, this also helps to ensure consistency between testpmd and bonding device. Signed-off-by: Huisong Li --- app/test-pmd/test

[PATCH V2] app/testpmd: update bond port configurations when add slave

2022-10-27 Thread Huisong Li
cause failure when re-initialize bonding device. So port configurations of bonding device also need to be updated because of the added and removed capabilities. In addition, this also helps to ensure consistency between testpmd and bonding device. Signed-off-by: Huisong Li --- - v2: fix a spelling

[PATCH V3] app/testpmd: update bond port configurations when add slave

2022-10-28 Thread Huisong Li
cause failure when re-initialize bonding device. So port configurations of bonding device also need to be updated because of the added and removed capabilities. In addition, this also helps to ensure consistency between testpmd and bonding device. Signed-off-by: Huisong Li --- - v3: fix code co

[PATCH V4] app/testpmd: update bond port configurations when add slave

2022-11-06 Thread Huisong Li
cause failure when re-initialize bonding device. So port configurations of bonding device need to be updated because of the added and removed capabilities. In addition, this also helps to ensure consistency between testpmd and bonding device. Signed-off-by: Huisong Li Reviewed-by: Min Hu (C

[PATCH V5] app/testpmd: update bond port configurations when add slave

2022-11-06 Thread Huisong Li
cause failure when re-initialize bonding device. So port configurations of bonding device need to be updated because of the added and removed capabilities. In addition, this also helps to ensure consistency between testpmd and bonding device. Signed-off-by: Huisong Li Reviewed-by: Min Hu (C

[PATCH 1/2] net/bonding: fix bond3 and bond4 process mbuf fast free

2022-11-08 Thread Huisong Li
ot;) Cc: sta...@dpdk.org Signed-off-by: Huisong Li --- drivers/net/bonding/rte_eth_bond_pmd.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c index 864e073db8..b5e832276a 100644 --- a/driver

[PATCH 2/2] app/testpmd: remove fast free offload for bond3 and bond4

2022-11-08 Thread Huisong Li
md: update bond port configurations when add slave") Signed-off-by: Huisong Li --- app/test-pmd/testpmd.c | 8 1 file changed, 8 insertions(+) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 7381dfd9e5..4063ffe0f2 100644 --- a/app/test-pmd/testpmd.c +++

[PATCH 0/2] net/bonding: fix mbuf fast free for bond3 and bond4

2022-11-08 Thread Huisong Li
This patchset fixes mbuf fast free offload for bond3 and bond4. Huisong Li (2): net/bonding: fix bond3 and bond4 process mbuf fast free app/testpmd: remove fast free offload for bond3 and bond4 app/test-pmd/testpmd.c | 8 drivers/net/bonding/rte_eth_bond_pmd.c | 6

[PATCH V2] net/bonding: fix bond3 and bond4 process mbuf fast free

2022-11-08 Thread Huisong Li
usage") Cc: sta...@dpdk.org Signed-off-by: Huisong Li --- -v2: report the correct txmode offloads based on bonding mode in the bonding driver, and not in testpmd. --- drivers/net/bonding/rte_eth_bond_api.c | 5 + drivers/net/bonding/rte_eth_bond_pmd.c | 11 --- 2 files

[PATCH V3 3/5] app/testpmd: check the validity of the port

2022-12-05 Thread Huisong Li
This patch checks the validity of port id for all events in 'eth_event_callback()'. Signed-off-by: Huisong Li Acked-by: Aman Singh --- app/test-pmd/testpmd.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testp

[PATCH V3 5/5] app/testpmd: stop forwarding in new or destroy event

2022-12-05 Thread Huisong Li
When testpmd receives the new or destroy event, the port related information will be updated. Testpmd must stop packet forwarding before updating the information to avoid some serious problems. Signed-off-by: Huisong Li --- app/test-pmd/testpmd.c | 4 1 file changed, 4 insertions(+) diff

[PATCH V3 0/5] app/testpmd: support mulitple process attach and detach port

2022-12-05 Thread Huisong Li
the probelm in patch 2/5. -v2: resend due to CI unexplained failure. Huisong Li (5): drivers/bus: restore driver assignment at front of probing ethdev: fix skip valid port in probing callback app/testpmd: check the validity of the port app/testpmd: add attach and detach port for multiple

[PATCH V3 1/5] drivers/bus: restore driver assignment at front of probing

2022-12-05 Thread Huisong Li
need to be updated if we do that. The driver pointer in rte_device is set before probing and needs to be reset if probing failed. And rte_dev_is_probed can not be called inside probing. Fixes: 391797f04208 ("drivers/bus: move driver assignment to end of probing") Cc: sta...@dpdk.org Si

[PATCH V3 2/5] ethdev: fix skip valid port in probing callback

2022-12-05 Thread Huisong Li
thdev: fix port probing notification") Cc: sta...@dpdk.org Signed-off-by: Huisong Li --- drivers/net/bnxt/bnxt_ethdev.c | 3 ++- drivers/net/mlx5/mlx5.c| 2 +- lib/ethdev/ethdev_driver.c | 13 ++--- lib/ethdev/ethdev_driver.h | 12 lib/ethdev/ethd

[PATCH V3 4/5] app/testpmd: add attach and detach port for multiple process

2022-12-05 Thread Huisong Li
This patch supports attach and detach port in primary and secondary process. Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- app/test-pmd/testpmd.c| 38 --- app/test-pmd/testpmd.h| 1 - drivers/net/bonding/bonding_testpmd.c

[PATCH V4 0/5] app/testpmd: support mulitple process attach and detach port

2022-12-06 Thread Huisong Li
resolve the probelm in patch 2/5. -v2: resend due to CI unexplained failure. Huisong Li (5): drivers/bus: restore driver assignment at front of probing ethdev: fix skip valid port in probing callback app/testpmd: check the validity of the port app/testpmd: add attach and detach port

[PATCH V4 4/5] app/testpmd: add attach and detach port for multiple process

2022-12-06 Thread Huisong Li
This patch supports attach and detach port in primary and secondary process. Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- app/test-pmd/testpmd.c| 38 --- app/test-pmd/testpmd.h| 1 - drivers/net/bonding/bonding_testpmd.c

[PATCH V4 5/5] app/testpmd: stop forwarding in new or destroy event

2022-12-06 Thread Huisong Li
When testpmd receives the new or destroy event, the port related information will be updated. Testpmd must stop packet forwarding before updating the information to avoid some serious problems. Signed-off-by: Huisong Li --- app/test-pmd/testpmd.c | 4 1 file changed, 4 insertions(+) diff

[PATCH V4 3/5] app/testpmd: check the validity of the port

2022-12-06 Thread Huisong Li
This patch checks the validity of port id for all events in 'eth_event_callback()'. Signed-off-by: Huisong Li Acked-by: Aman Singh --- app/test-pmd/testpmd.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testp

[PATCH V4 2/5] ethdev: fix skip valid port in probing callback

2022-12-06 Thread Huisong Li
thdev: fix port probing notification") Cc: sta...@dpdk.org Signed-off-by: Huisong Li --- drivers/net/bnxt/bnxt_ethdev.c | 3 ++- drivers/net/mlx5/mlx5.c| 2 +- lib/ethdev/ethdev_driver.c | 13 ++--- lib/ethdev/ethdev_driver.h | 12 lib/ethdev/ethd

[PATCH V4 1/5] drivers/bus: restore driver assignment at front of probing

2022-12-06 Thread Huisong Li
need to be updated if we do that. The driver pointer in rte_device is set before probing and needs to be reset if probing failed. And rte_dev_is_probed can not be called inside probing. Fixes: 391797f04208 ("drivers/bus: move driver assignment to end of probing") Cc: sta...@dpdk.org Si

[PATCH 1/8] telemetry: move to header to controllable range

2022-12-08 Thread Huisong Li
The "stdint.h" header is outside _RTE_TELEMETRY_H_ macro, which cause this header is uncontrollable. So this patch moves this header to inside _RTE_TELEMETRY_H_. Fixes: 99a2dd955fba ("lib: remove librte_ prefix from directory names") Cc: sta...@dpdk.org Signed-off-by:

[PATCH 0/8] fix possible data truncation and conversion error

2022-12-08 Thread Huisong Li
#x27;u64' API to add 'u64' data. Also, this patchset optimize the display of some capability related variables in ethdev by using hexadecimal data. Huisong Li (8): telemetry: move to header to controllable range telemetry: add u32 telemetry data type API test: add test cases

[PATCH 5/8] mempool: fix possible data truncation and conversion error

2022-12-08 Thread Huisong Li
The 'u32' and 'u64' data can not assigned to 'int' type variable. The 'u32' data need to use the 'u32' telemetry API to add, and the 'u64' data need to use the 'u64' telemetry API to add. Fixes: 2f5c4025abb3 ("mempo

[PATCH 2/8] telemetry: add u32 telemetry data type API

2022-12-08 Thread Huisong Li
eger and a series of 'u32' APIs. Cc: sta...@dpdk.org Signed-off-by: Huisong Li --- lib/telemetry/rte_telemetry.h | 35 +++ lib/telemetry/telemetry.c | 25 ++-- lib/telemetry/telemetry_data.c | 52 -- lib/telemetry/t

[PATCH 8/8] ethdev: telemetry convert capability related variable to hex

2022-12-08 Thread Huisong Li
536, "ethdev_rss_hf": 9100 --> now display "dev_flags": "0x3", "rx_offloads": "0x8", "tx_offloads": "0x1", "ethdev_rss_hf": "0x238c" Signed-off-by: Huisong Li --- lib/e

[PATCH 4/8] ethdev: fix possible data truncation and conversion error

2022-12-08 Thread Huisong Li
add telemetry endpoint for device info") Cc: sta...@dpdk.org Signed-off-by: Huisong Li --- lib/ethdev/rte_ethdev.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c index 5d5e18db1e..dfb269970e 10064

[PATCH 6/8] cryptodev: fix possible data conversion error

2022-12-08 Thread Huisong Li
The 'u32' data can not assigned to 'int' type variable. The 'u32' data need to use the 'u32' telemetry API to add. Fixes: d3d98f5ce9d0 ("cryptodev: support telemetry") Cc: sta...@dpdk.org Signed-off-by: Huisong Li --- lib/cryptodev/rte_cry

[PATCH 7/8] mem: possible data truncation and conversion error

2022-12-08 Thread Huisong Li
The 'u32' and 'u64' data can not assigned to 'int' type variable. The 'u32' data need to use the 'u32' telemetry API to add, and the 'u64' data need to use the 'u64' telemetry API to add. Fixes: e6732d0d6e26 ("mem: add tel

[PATCH 3/8] test: add test cases for u32 telemetry data API

2022-12-08 Thread Huisong Li
Add test cases for u32 telemetry data API. Cc: sta...@dpdk.org Signed-off-by: Huisong Li --- app/test/test_telemetry_data.c | 86 +- app/test/test_telemetry_json.c | 23 - 2 files changed, 105 insertions(+), 4 deletions(-) diff --git a/app/test

[PATCH V2 01/11] telemetry: move to header to controllable range

2022-12-09 Thread Huisong Li
The "stdint.h" header is outside '_RTE_TELEMETRY_H_' macro, which cause this header is uncontrollable. So this patch moves this header to inside '_RTE_TELEMETRY_H_'. Fixes: 99a2dd955fba ("lib: remove librte_ prefix from directory names") Cc: sta...@dpdk.

[PATCH V2 00/11] telemetry: add u32 value type and hex integer string API

2022-12-09 Thread Huisong Li
the 'u64' API to add 'u64' data. In addition, this patchset introduces two APIs to store u32 and u64 values as hexadecimal encoded strings in telemetry library. --- -v2: - fix ABI break warning. - introduce two APIs to store u32 and u64 values as hexadecimal encod

[PATCH V2 04/11] ethdev: fix possible data truncation and conversion error

2022-12-09 Thread Huisong Li
add telemetry endpoint for device info") Cc: sta...@dpdk.org Signed-off-by: Huisong Li --- lib/ethdev/rte_ethdev.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c index 5d5e18db1e..dfb269970e 10064

[PATCH V2 06/11] cryptodev: fix possible data conversion error

2022-12-09 Thread Huisong Li
The 'u32' data can not assigned to 'int' type variable. The 'u32' data need to use the 'u32' telemetry API to add. Fixes: d3d98f5ce9d0 ("cryptodev: support telemetry") Cc: sta...@dpdk.org Signed-off-by: Huisong Li --- lib/cryptodev/rte_cry

[PATCH V2 03/11] test: add test cases for adding u32 value API

2022-12-09 Thread Huisong Li
Add test cases for adding u32 value API. Cc: sta...@dpdk.org Signed-off-by: Huisong Li --- app/test/test_telemetry_data.c | 85 +- app/test/test_telemetry_json.c | 23 - 2 files changed, 104 insertions(+), 4 deletions(-) diff --git a/app/test

[PATCH V2 08/11] telemetry: refactor mapping betwween value and array type

2022-12-09 Thread Huisong Li
Currently, use rte_tel_value_type as index of array to find the tel_container_types in rte_tel_data_start_array. It's not good for maintenance. Fixes: ed1bfad7d384 ("telemetry: add functions for returning callback data") Cc: sta...@dpdk.org Signed-off-by: Huisong Li ---

[PATCH V2 10/11] test: add test cases for adding hex integer values API

2022-12-09 Thread Huisong Li
Add test cases for adding hexadecimal u32 and u64 values API. Signed-off-by: Huisong Li --- app/test/test_telemetry_data.c | 164 + 1 file changed, 164 insertions(+) diff --git a/app/test/test_telemetry_data.c b/app/test/test_telemetry_data.c index 8ab3441cbe

[PATCH V2 11/11] ethdev: display capability values in hexadecimal format

2022-12-09 Thread Huisong Li
536, "ethdev_rss_hf": 9100 --> now display "dev_flags": "0x3", "rx_offloads": "0x8", "tx_offloads": "0x1", "ethdev_rss_hf": "0x238c" Signed-off-by: Huisong Li --- l

[PATCH V2 05/11] mempool: fix possible data truncation and conversion error

2022-12-09 Thread Huisong Li
The 'u32' and 'u64' data can not assigned to 'int' type variable. The 'u32' data need to use the 'u32' telemetry API to add, and the 'u64' data need to use the 'u64' telemetry API to add. Fixes: 2f5c4025abb3 ("mempo

[PATCH V2 02/11] telemetry: add u32 value type

2022-12-09 Thread Huisong Li
r type and container type. Cc: sta...@dpdk.org Signed-off-by: Huisong Li --- lib/telemetry/rte_telemetry.h | 35 lib/telemetry/telemetry.c | 25 +++-- lib/telemetry/telemetry_data.c | 50 -- lib/telemetry/telemetry_d

[PATCH V2 07/11] mem: possible data truncation and conversion error

2022-12-09 Thread Huisong Li
The 'u32' and 'u64' data can not assigned to 'int' type variable. The 'u32' data need to use the 'u32' telemetry API to add, and the 'u64' data need to use the 'u64' telemetry API to add. Fixes: e6732d0d6e26 ("mem: add tel

[PATCH V2 09/11] telemetry: support adding integer value as hexadecimal

2022-12-09 Thread Huisong Li
Sometimes displaying a integer value as hexadecimal encoded style is more expected for human consumption, such as, offload capability and device falg. This patch introduces some APIs to add 'u32' and 'u64' value as hexadecimal encoded string to array or dictionary. Signe

[PATCH V3 06/11] cryptodev: fix possible data conversion error

2022-12-11 Thread Huisong Li
The 'u32' data can not assigned to 'int' type variable. The 'u32' data need to use the 'u32' telemetry API to add. Fixes: d3d98f5ce9d0 ("cryptodev: support telemetry") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Acked-by: Morten B

[PATCH V3 01/11] telemetry: move to header to controllable range

2022-12-11 Thread Huisong Li
The "stdint.h" header is outside '_RTE_TELEMETRY_H_' macro, which cause this header is uncontrollable. So this patch moves this header to inside '_RTE_TELEMETRY_H_'. Fixes: 99a2dd955fba ("lib: remove librte_ prefix from directory names") Cc: sta...@dpdk.

[PATCH V3 00/11] telemetry: add u32 value type and hex integer string API

2022-12-11 Thread Huisong Li
the 'u64' API to add 'u64' data. In addition, this patchset introduces two APIs to store u32 and u64 values as hexadecimal encoded strings in telemetry library. --- -v3: fix a misspelling mistake in commit log. -v2: - fix ABI break warning. - introduce two APIs to

[PATCH V3 04/11] ethdev: fix possible data truncation and conversion error

2022-12-11 Thread Huisong Li
add telemetry endpoint for device info") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Acked-by: Morten Brørup Acked-by: Chengwen Feng --- lib/ethdev/rte_ethdev.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethd

[PATCH V3 03/11] test: add test cases for adding u32 value API

2022-12-11 Thread Huisong Li
Add test cases for adding u32 value API. Cc: sta...@dpdk.org Signed-off-by: Huisong Li Acked-by: Morten Brørup Acked-by: Chengwen Feng --- app/test/test_telemetry_data.c | 85 +- app/test/test_telemetry_json.c | 23 - 2 files changed, 104 insertions

[PATCH V3 05/11] mempool: fix possible data truncation and conversion error

2022-12-11 Thread Huisong Li
The 'u32' and 'u64' data can not assigned to 'int' type variable. The 'u32' data need to use the 'u32' telemetry API to add, and the 'u64' data need to use the 'u64' telemetry API to add. Fixes: 2f5c4025abb3 ("mempool: add

[PATCH V3 07/11] mem: possible data truncation and conversion error

2022-12-11 Thread Huisong Li
The 'u32' and 'u64' data can not assigned to 'int' type variable. The 'u32' data need to use the 'u32' telemetry API to add, and the 'u64' data need to use the 'u64' telemetry API to add. Fixes: e6732d0d6e26 ("mem: add

[PATCH V3 02/11] telemetry: add u32 value type

2022-12-11 Thread Huisong Li
r type and container type. Cc: sta...@dpdk.org Signed-off-by: Huisong Li Acked-by: Morten Brørup Acked-by: Chengwen Feng --- lib/telemetry/rte_telemetry.h | 35 lib/telemetry/telemetry.c | 25 +++-- lib/telemetry/telemetry_d

[PATCH V3 08/11] telemetry: refactor mapping betwween value and array type

2022-12-11 Thread Huisong Li
Currently, use rte_tel_value_type as index of array to find the tel_container_types in rte_tel_data_start_array. It's not good for maintenance. Fixes: ed1bfad7d384 ("telemetry: add functions for returning callback data") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Acked-by

[PATCH V3 09/11] telemetry: support adding integer value as hexadecimal

2022-12-11 Thread Huisong Li
Sometimes displaying a integer value as hexadecimal encoded style is more expected for human consumption, such as, offload capability and device flag. This patch introduces some APIs to add 'u32' and 'u64' value as hexadecimal encoded string to array or dictionary. Signe

[PATCH V3 11/11] ethdev: display capability values in hexadecimal format

2022-12-11 Thread Huisong Li
536, "ethdev_rss_hf": 9100 --> now display "dev_flags": "0x3", "rx_offloads": "0x8", "tx_offloads": "0x1", "ethdev_rss_hf": "0x238c" Signed-off-by: Huisong Li

[PATCH V3 10/11] test: add test cases for adding hex integer values API

2022-12-11 Thread Huisong Li
Add test cases for adding hexadecimal u32 and u64 values API. Signed-off-by: Huisong Li Acked-by: Morten Brørup Acked-by: Chengwen Feng --- app/test/test_telemetry_data.c | 164 + 1 file changed, 164 insertions(+) diff --git a/app/test/test_telemetry_data.c b

[PATCH V4 0/9] telemetry: fix data truncation and conversion error and add hex integer API

2022-12-13 Thread Huisong Li
store u32 and u64 values as hexadecimal encoded strings. Huisong Li (9): telemetry: move to header to controllable range ethdev: fix possible data truncation and conversion error mempool: fix possible data truncation and conversion error cryptodev: fix possible data conversion error mem:

[PATCH V4 2/9] ethdev: fix possible data truncation and conversion error

2022-12-13 Thread Huisong Li
The 'u32' and 'u64' datas can not assigned to 'int' type variable. The 'u32' and 'u64' datas need to use the 'u64' APIs to add. Fixes: 58b43c1ddfd1 ("ethdev: add telemetry endpoint for device info") Cc: sta...@dpdk.org Signe

[PATCH V4 4/9] cryptodev: fix possible data conversion error

2022-12-13 Thread Huisong Li
The 'u32' data can not assigned to 'int' type variable. The 'u32' data needs to use the 'u64' APIs to add. Fixes: d3d98f5ce9d0 ("cryptodev: support telemetry") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Acked-by: Morten Brørup Acked-by: Che

[PATCH V4 1/9] telemetry: move to header to controllable range

2022-12-13 Thread Huisong Li
The "stdint.h" header is outside '_RTE_TELEMETRY_H_' macro, which cause this header is uncontrollable. So this patch moves this header to inside '_RTE_TELEMETRY_H_'. Fixes: 99a2dd955fba ("lib: remove librte_ prefix from directory names") Cc: sta...@dpdk.

[PATCH V4 3/9] mempool: fix possible data truncation and conversion error

2022-12-13 Thread Huisong Li
The 'u32' and 'u64' data can not assigned to 'int' type variable. The 'u32' and 'u64' datas need to use the 'u64' APIs to add. Fixes: 2f5c4025abb3 ("mempool: add telemetry endpoint") Cc: sta...@dpdk.org Signed-off-by: Huisong

[PATCH V4 5/9] mem: possible data truncation and conversion error

2022-12-13 Thread Huisong Li
The 'u32' and 'u64' data can not assigned to 'int' type variable. The 'u32' and 'u64' datas need to use the 'u64' APIs to add. Fixes: e6732d0d6e26 ("mem: add telemetry infos") Cc: sta...@dpdk.org Signed-off-by: Huisong Li

[PATCH V4 6/9] telemetry: refactor mapping between value and array type

2022-12-13 Thread Huisong Li
Currently, use rte_tel_value_type as index of array to find the tel_container_types in rte_tel_data_start_array. It's not good for maintenance. Fixes: ed1bfad7d384 ("telemetry: add functions for returning callback data") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Acked-by

[PATCH V4 7/9] telemetry: support adding integer value as hexadecimal

2022-12-13 Thread Huisong Li
encoded string to array or dictionary. If the 'val_bits' is zero, the value is stored as hexadecimal encoded string without padding zero. Signed-off-by: Huisong Li Acked-by: Morten Brørup Acked-by: Chengwen Feng --- lib/telemetry/rte_telemetry.h | 50

[PATCH V4 9/9] ethdev: display capability values in hexadecimal format

2022-12-13 Thread Huisong Li
536, "ethdev_rss_hf": 9100 --> now display "dev_flags": "0x3", "rx_offloads": "0x8", "tx_offloads": "0x1", "ethdev_rss_hf": "0x238c" Signed-off-by: Huisong Li Acked-b

[PATCH V4 8/9] test: add test cases for adding hex integer value API

2022-12-13 Thread Huisong Li
Add test cases for adding hexadecimal unsigned integer value API. Signed-off-by: Huisong Li Acked-by: Morten Brørup Acked-by: Chengwen Feng --- app/test/test_telemetry_data.c | 158 + 1 file changed, 158 insertions(+) diff --git a/app/test

[PATCH V5 4/8] cryptodev: fix possible data conversion error

2022-12-14 Thread Huisong Li
The 'u32' data can not assigned to 'int' type variable. The 'u32' data needs to use the 'u64' APIs to add. Fixes: d3d98f5ce9d0 ("cryptodev: support telemetry") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Acked-by: Morten Brørup Acked-by: Che

[PATCH V5 3/8] mempool: fix possible data truncation and conversion error

2022-12-14 Thread Huisong Li
The 'u32' and 'u64' data can not assigned to 'int' type variable. They need to use the 'u64' APIs to add. Fixes: 2f5c4025abb3 ("mempool: add telemetry endpoint") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Acked-by: Morten Brørup Acked-by:

[PATCH V5 1/8] telemetry: move to header to controllable range

2022-12-14 Thread Huisong Li
The "stdint.h" header is outside '_RTE_TELEMETRY_H_' macro, which cause this header is unconditional. So this patch moves this header to inside '_RTE_TELEMETRY_H_'. Fixes: 99a2dd955fba ("lib: remove librte_ prefix from directory names") Cc: sta...@dpdk.

[PATCH V5 2/8] ethdev: fix possible data truncation and conversion error

2022-12-14 Thread Huisong Li
The 'u32' and 'u64' data can not assigned to 'int' type variable. They need to use the 'u64' APIs to add. Fixes: 58b43c1ddfd1 ("ethdev: add telemetry endpoint for device info") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Acked-by: Morte

[PATCH V5 5/8] mem: possible data truncation and conversion error

2022-12-14 Thread Huisong Li
The 'u32' and 'u64' data can not assigned to 'int' type variable. They need to use the 'u64' APIs to add. Fixes: e6732d0d6e26 ("mem: add telemetry infos") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Acked-by: Morten Brørup Acked-by: Chengwen

[PATCH V5 0/8] telemetry: fix data truncation and conversion error and add hex integer API

2022-12-14 Thread Huisong Li
in commit log. -v2: - fix ABI break warning. - introduce two APIs to store u32 and u64 values as hexadecimal encoded strings. Huisong Li (8): telemetry: move to header to controllable range ethdev: fix possible data truncation and conversion error mempool: fix possible data tru

[PATCH V5 6/8] telemetry: support adding integer value as hexadecimal

2022-12-14 Thread Huisong Li
whether the stored value is padding to the specified width. Signed-off-by: Huisong Li Acked-by: Morten Brørup Acked-by: Chengwen Feng --- lib/telemetry/rte_telemetry.h | 47 + lib/telemetry/telemetry_data.c | 74 ++ lib/telemetry/version.map

[PATCH V5 8/8] ethdev: display capability values in hexadecimal format

2022-12-14 Thread Huisong Li
536, "ethdev_rss_hf": 9100 --> now display "dev_flags": "0x3", "rx_offloads": "0x8", "tx_offloads": "0x1", "ethdev_rss_hf": "0x238c" Signed-off-by: Huisong Li Acked-b

[PATCH V5 7/8] test: add test cases for adding hex integer value API

2022-12-14 Thread Huisong Li
Add test cases for adding hexadecimal unsigned integer value API. Signed-off-by: Huisong Li Acked-by: Morten Brørup Acked-by: Chengwen Feng --- app/test/test_telemetry_data.c | 150 + 1 file changed, 150 insertions(+) diff --git a/app/test

[PATCH V6 0/8] telemetry: fix data truncation and conversion error and add hex integer API

2022-12-15 Thread Huisong Li
g zero for hexadecimal value -v3: fix a misspelling mistake in commit log. -v2: - fix ABI break warning. - introduce two APIs to store u32 and u64 values as hexadecimal encoded strings. Huisong Li (8): telemetry: move to header to controllable range ethdev: fix possible data t

[PATCH V6 1/8] telemetry: move to header to controllable range

2022-12-15 Thread Huisong Li
The "stdint.h" header is outside '_RTE_TELEMETRY_H_' macro, which cause this header is unconditional. So this patch moves this header to inside '_RTE_TELEMETRY_H_'. Fixes: 99a2dd955fba ("lib: remove librte_ prefix from directory names") Cc: sta...@dpdk.

[PATCH V6 2/8] ethdev: fix possible data truncation and conversion error

2022-12-15 Thread Huisong Li
The 'u32' and 'u64' data can not assigned to 'int' type variable. They need to use the 'u64' APIs to add. Fixes: 58b43c1ddfd1 ("ethdev: add telemetry endpoint for device info") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Acked-by: Morte

[PATCH V6 4/8] cryptodev: fix possible data conversion error

2022-12-15 Thread Huisong Li
The 'u32' data can not assigned to 'int' type variable. The 'u32' data needs to use the 'u64' APIs to add. Fixes: d3d98f5ce9d0 ("cryptodev: support telemetry") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Acked-by: Morten Brørup Acked-by: Che

[PATCH V6 5/8] mem: possible data truncation and conversion error

2022-12-15 Thread Huisong Li
The 'u32' and 'u64' data can not assigned to 'int' type variable. They need to use the 'u64' APIs to add. Fixes: e6732d0d6e26 ("mem: add telemetry infos") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Acked-by: Morten Brørup Acked-by: Chengwen

[PATCH V6 3/8] mempool: fix possible data truncation and conversion error

2022-12-15 Thread Huisong Li
The 'u32' and 'u64' data can not assigned to 'int' type variable. They need to use the 'u64' APIs to add. Fixes: 2f5c4025abb3 ("mempool: add telemetry endpoint") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Acked-by: Morten Brørup Acked-by:

[PATCH V6 6/8] telemetry: support adding integer value as hexadecimal

2022-12-15 Thread Huisong Li
whether the stored value is padding to the specified width. Signed-off-by: Huisong Li Acked-by: Morten Brørup Acked-by: Chengwen Feng --- lib/telemetry/rte_telemetry.h | 47 ++ lib/telemetry/telemetry_data.c | 72 ++ lib/telemetry/version.map

  1   2   3   4   >