ernel tsc_hz value, just use it.
Signed-off-by: Isaac Boukris
---
lib/eal/common/eal_common_timer.c | 3 +-
lib/eal/common/eal_private.h | 2 +-
lib/eal/freebsd/eal_timer.c | 8 +++--
lib/eal/linux/eal_timer.c | 53 +--
lib/eal/windows/eal_ti
also bugzilla: 959
Signed-off-by: Isaac Boukris
---
lib/eal/linux/eal_timer.c | 6 +++---
lib/eal/windows/eal_timer.c | 6 +++---
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/lib/eal/linux/eal_timer.c b/lib/eal/linux/eal_timer.c
index 1cb1e92193..f56a7ae15b 100644
--- a/li
Changes if V5:
- fix absolute delta calculation per Bruce's comment.
Isaac Boukris (2):
timer: lower rounding of TSC estimation to 100KHz
timer: allow platform to override cpu TSC frequency
lib/eal/common/eal_common_timer.c | 3 +-
lib/eal/common/eal_private.h | 2 +-
li
On Thu, Oct 3, 2024 at 12:31 PM Bruce Richardson
wrote:
>
> On Wed, Oct 02, 2024 at 10:14:57PM +0300, Isaac Boukris wrote:
> > On Wed, Oct 2, 2024 at 8:11 PM Bruce Richardson
> > wrote:
> > >
> > > On Wed, Oct 02, 2024 at 07:56:36PM +0300, Isaac Boukris wrote
On Wed, Oct 2, 2024 at 8:11 PM Bruce Richardson
wrote:
>
> On Wed, Oct 02, 2024 at 07:56:36PM +0300, Isaac Boukris wrote:
> > The CPU value is often not accurate, allow overriding it based
> > on info from the host OS.
> >
> > On Linux X86, if the tsc_known_freq
also bugzilla: 959
Signed-off-by: Isaac Boukris
---
lib/eal/linux/eal_timer.c | 6 +++---
lib/eal/windows/eal_timer.c | 6 +++---
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/lib/eal/linux/eal_timer.c b/lib/eal/linux/eal_timer.c
index 1cb1e92193..f56a7ae15b 100644
--- a/li
sc_hz value, just use it.
Signed-off-by: Isaac Boukris
---
lib/eal/common/eal_common_timer.c | 3 +-
lib/eal/common/eal_private.h | 2 +-
lib/eal/freebsd/eal_timer.c | 8 +++--
lib/eal/linux/eal_timer.c | 53 +--
lib/eal/windows/eal_timer.c
Changes in V4:
- lower ronding on Windows too
- on freebsd prefer system tsc_hz
Isaac Boukris (2):
timer: lower rounding of TSC estimation to 100KHz
timer: allow platform to override cpu TSC frequency
lib/eal/common/eal_common_timer.c | 3 +-
lib/eal/common/eal_private.h | 2
On Tue, Oct 1, 2024 at 11:01 PM Bruce Richardson
wrote:
>
> On Tue, Oct 01, 2024 at 03:22:51AM +0300, Isaac Boukris wrote:
> > If the tsc_known_freq cpu flag is missing, it means the kernel doesn't
> > trust it and calculates its own. We should do the same to avoid drift
On Tue, Oct 1, 2024 at 6:22 PM Stephen Hemminger
wrote:
>
> On Tue, 1 Oct 2024 03:22:51 +0300
> Isaac Boukris wrote:
>
> > diff --git a/lib/eal/windows/eal_timer.c b/lib/eal/windows/eal_timer.c
> > index b070cb7751..cfd6c267ac 100644
> > --- a/lib/eal/windows
In practice, the estimation result is just a couple of KHz
away from the kernel's tsc_khz value, so it should suffice.
Rounding to 10MHz can cause a significant drift from real time,
up to a second per 10 minutes.
See also bugzilla: 959
Signed-off-by: Isaac Boukris
---
lib/eal/
If the tsc_known_freq cpu flag is missing, it means the kernel doesn't
trust it and calculates its own. We should do the same to avoid drift.
Signed-off-by: Isaac Boukris
---
lib/eal/common/eal_common_timer.c | 3 +-
lib/eal/common/eal_private.h | 2 +-
lib/eal/freebsd/eal_ti
Changes in V3:
- fixed ifdef logic.
- avoid breaking a debug line.
Isaac Boukris (2):
timer/linux: lower rounding of tsc estimation to 100KHz
timer/linux/x86: override TSC freq if no tsc_known_freq
lib/eal/common/eal_common_timer.c | 3 +-
lib/eal/common/eal_private.h | 2 +-
lib
In practice, the estimation result is just a couple of KHz
away from the kernel's tsc_khz value, so it should suffice.
Rounding to 10MHz can cause a significant drift from real time,
up to a second per 10 minutes.
See also bugzilla: 959
Signed-off-by: Isaac Boukris
---
lib/eal/
If the tsc_known_freq cpu flag is missing, it means the kernel doesn't
trust it and calculates its own. We should do the same to avoid drift.
Signed-off-by: Isaac Boukris
---
lib/eal/common/eal_common_timer.c | 3 +-
lib/eal/common/eal_private.h | 2 +-
lib/eal/freebsd/eal_ti
Changes in V2:
- changed rounding to 100KHz which should be pretty safe.
- limited the tsc_known_freq flag check to x86 arch.
Isaac Boukris (2):
timer/linux: lower rounding of tsc estimation to 100KHz
timer/linux/x86: override TSC freq if no tsc_known_freq
lib/eal/common
Hi,
On Mon, Sep 30, 2024 at 12:55 AM Ferruh Yigit wrote:
>
> On 9/17/2024 12:51 PM, Isaac Boukris wrote:
> > Normally, the MAC address of the kernel interface is the same as in the
> > interface in dpdk, as they represent the same interface. It is useful
> > to allow
Perhaps this was a bit hastily, I got an automated failure report on
"arm64-native-linuxapp-gcc":
https://lab.dpdk.org/results/dashboard/patchsets/31106/
Not sure which patch caused the problem, looking at the kernel code it
looks like 'tsc_known_freq' is only set for x86 arch, but it could be
th
If the tsc_known_freq cpu flag is missing, it means the kernel doesn't
trust it and calculates its own. We should do the same to avoid drift.
Signed-off-by: Isaac Boukris
---
lib/eal/common/eal_common_timer.c | 3 +-
lib/eal/common/eal_private.h | 2 +-
lib/eal/freebsd/eal_ti
In practice, the estimation result is just a couple of KHz
away from the kernel's tsc_khz value, so it should suffice.
Roundin to 10MHz can cause a significant drift from real time,
up to a second per 10 minutes.
See also bugzilla: 959
Signed-off-by: Isaac Boukris
---
lib/eal/
Hi,
This is a V2 addressing previous comments, I mistakenly passed the -v2
to send-mail instead of format-patch..
Thanks!
On Tue, Sep 17, 2024 at 2:52 PM Isaac Boukris wrote:
>
> Normally, the MAC address of the kernel interface is the same as in the
> interface in dpdk, as they repr
k and using the tap interface, as both the kernel and freebsd
stacks configure the MAC derived IPv6 address on the interface (as can
be seen with ifconfig for the kernel), and they both complain about
duplicate IPv6 address and the freebsd disables IPv6 as a result.
Signed-off-by: Isaac Bo
Hi Stephen
On Tue, Sep 17, 2024 at 6:36 AM Stephen Hemminger
wrote:
>
> On Mon, 16 Sep 2024 20:38:51 +0300
> Isaac Boukris wrote:
>
> > + if (mac_pair) {
> > + struct rte_ether_addr *mac;
> > +
k and using the tap interface, as both the kernel and freebsd
stacks configure the MAC derived IPv6 address on the interface (as can
be seen with ifconfig for the kernel), and they both complain about
duplicate IPv6 address and the freebsd disables IPv6 as a result.
Signed-off-by: Isaac Bo
On Fri, Mar 8, 2024 at 12:39 AM Stephen Hemminger
wrote:
>
> From: Isaac Boukris
>
> If request to set promiscious mode failed at startup,
> then it is not necessary to disable it when shutting down.
>
> This should only be issue if with a buggy driver because if
>
Signed-off-by: Isaac Boukris
---
app/dumpcap/main.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c
index d57db0589a..88cec43086 100644
--- a/app/dumpcap/main.c
+++ b/app/dumpcap/main.c
@@ -830,11 +830,12 @@ static void
Hi Stephen,
Please take a look.
Thanks!
dumpcap_fixes.patch
Description: Binary data
fail because of overlap in ring a pool names.
> > Fix by putting process id in the name.
> >
> > Fixes: cbb44143be74 ("app/dumpcap: add new packet capture application")
> > Reported-by: Isaac Boukris
> > Signed-off-by: Stephen Hemminger
> > ---
&g
On Sun, Feb 5, 2023 at 9:49 PM Stephen Hemminger
wrote:
>
> On Sun, 5 Feb 2023 18:54:20 +0200
> Isaac Boukris wrote:
>
> > Hi,
> >
> > I managed to reproduce it by modifying the helloworld app (see
> > attached). The report seem correct, as in case of 10 by
Mon Sep 17 00:00:00 2001
From: Isaac Boukris
Date: Sun, 5 Feb 2023 11:20:29 +0200
Subject: [PATCH] Demo bug in rte_hash_lookup
---
examples/helloworld/Makefile | 2 +-
examples/helloworld/main.c | 23 +++
2 files changed, 24 insertions(+), 1 deletion(-)
diff --git a/
Hi,
On Sun, Jan 15, 2023 at 2:46 PM Dmitry Kozlyuk wrote:
>
> 2023-01-14 18:27 (UTC-0800), Stephen Hemminger:
> > DAC_OVERRIDE is like having the master key. It opens all doors
> > and if so, running as non-root really doesn't matter that much.
> >
> > Ideally, a finer grain permission could be u
; >
> > Fixes: 979bb5d493fb ("doc: add more instructions for running as non-root")
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: Dmitry Kozlyuk
> > Reported-by: Boris Ouretskey
> > Reported-by: Isaac Boukris
>
> DAC_OVERRIDE is like having
32 matches
Mail list logo
