[dpdk-dev] [PATCH v3] vhost: make iotlb cache name unique among multi processes

MAX_VRING(256): max 3 digits. Fixes: d012d1f293f4 (vhost: add IOTLB helper functions) Cc: sta...@dpdk.org Signed-off-by: Itsuro Oda --- v3: * change format. * fix commit message. v2: * use the process id to make the iotlb cache name unique. lib/librte_vhost/iotlb.c | 5 +++-- 1 file changed, 3 insertions(

[dpdk-dev] [PATCH v2] vhost: make iotlb cache name unique among multi processes

293f4 (vhost: add IOTLB helper functions) Cc: sta...@dpdk.org Signed-off-by: Itsuro Oda --- v2: * use the process id to make the iotlb cache name unique. lib/librte_vhost/iotlb.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/librte_vhost/iotlb.c b/lib/librte_vhost/iotl

[dpdk-dev] [PATCH] vhost: make iotlb cache name unique among multi processes

Since the length of interface name is variable, this patch uses hash value calculated by the interface name. Fixes: d012d1f293f4 (vhost: add IOTLB helper functions) Cc: sta...@dpdk.org Signed-off-by: Itsuro Oda --- lib/librte_vhost/iotlb.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deleti

[dpdk-dev] [PATCH v3] net/vhost: fix potential memory leak

If a vhost device is closed before eth_dev_configure is done to the device, internal resources allocated to the device would not be freed. This patch fixes it. Fixes: 3d01b759d267 ("net/vhost: delay driver setup") Cc: sta...@dpdk.org Signed-off-by: Itsuro Oda Reviewed-by: Xiaolong

[dpdk-dev] [PATCH v2] net/vhost: fix potential memory leak

If a vhost device is closed before eth_dev_configure is done to the device, internal resources allocated to the device would not be freed. This patch fixes it. Fixes: 3d01b759d267 ("net/vhost: delay driver setup") Cc: sta...@dpdk.org Signed-off-by: Itsuro Oda Reviewd-by: Xiaolong

[dpdk-dev] [PATCH] net/vhost: fix potential memory leak

If a vhost device is closed before eth_dev_configure is done to the device, internal resources allocated to the device does not freed. This patch fixes it. Fixes: 3d01b759d267 ("net/vhost: delay driver setup") Signed-off-by: Itsuro Oda --- drivers/net/vhost/rte_eth_vh

Re: [dpdk-dev] [PATCH 2/2] net/vhost: prevent multiple setup on reconfig

> > > > https://github.com/DPDK/dpdk/blob/e6c78e736d77/drivers/net/vhost/rte_eth_vhost.c#L1058 > > https://github.com/DPDK/dpdk/blob/e6c78e736d77/drivers/net/vhost/rte_eth_vhost.c#L1075 > > > > It's not a common case and it's quite late in this release, > > probably it's fine to fix it later. > > That's a valid point, and I also agree there is no urgency for v20.02. > Itsuro, would you take care of fixing it for v20.05? Sure, I will do it. Thanks. Itsuro Oda > Thanks, > Maxime > > Thanks, > > Tiwei > > -- Itsuro ODA

Re: [dpdk-dev] [PATCH 0/2] Fix Vhost PMD setup

/vhost: prevent multiple setup on reconfig > > drivers/net/vhost/rte_eth_vhost.c | 26 +++--- > 1 file changed, 19 insertions(+), 7 deletions(-) > > -- > 2.24.1 -- Itsuro ODA

[dpdk-dev] [PATCH v3 4/4] net/vhost: remove an unused member

This patch removes an unused member from pmd_internal. Signed-off-by: Itsuro Oda Reviewed-by: Maxime Coquelin --- drivers/net/vhost/rte_eth_vhost.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c

[dpdk-dev] [PATCH v3 1/4] net/vhost: allocate interface name from heap

This patch allocates iface_name of pmd_internal from heap in order to be able to refer from secondary processes. Fixes: 4852aa8f6e21 (drivers/net: enable hotplug on secondary process) Cc: sta...@dpdk.org Signed-off-by: Itsuro Oda Reviewed-by: Maxime Coquelin --- drivers/net/vhost

[dpdk-dev] [PATCH v3 2/4] net/vhost: delay vhost driver setup

Vhost driver setup is delayed at eth_dev configuration in order to be able to set it from a secondary process. Fixes: 4852aa8f6e21 (drivers/net: enable hotplug on secondary process) Cc: sta...@dpdk.org Signed-off-by: Itsuro Oda Reviewed-by: Maxime Coquelin --- drivers/net/vhost

[dpdk-dev] [PATCH v3 3/4] net/vhost: make secondary probe complete

This patch adds lacking member setting and makes secondary probe complete. Fixes: 4852aa8f6e21 (drivers/net: enable hotplug on secondary process) Cc: sta...@dpdk.org Signed-off-by: Itsuro Oda Reviewed-by: Maxime Coquelin --- drivers/net/vhost/rte_eth_vhost.c | 5 - 1 file changed, 4

[dpdk-dev] [PATCH v3 0/4] make vhost PMD available for secondary processes

leaves it to user's responsibility.) This precondition will not be a problem in most use cases (including SPP). v2: - add signed-off-by - fix spelling error v3: - rebase on dpdk-next-virtio master - change patch order - fix subject and commit message Itsuro Oda (4): net/vhost: allocate inte

Re: [dpdk-dev] [PATCH 0/4] make vhost PMD available for secondary processes

Hi Maxime, Thank you for your reply and review. I will make fixes of the patches according to your indication and post them. Thanks. Itsuro Oda On Tue, 4 Feb 2020 18:54:23 +0100 Maxime Coquelin wrote: > Hi Itsuro, > > On 1/20/20 3:17 AM, Itsuro ODA wrote: > > Hi vhost

Re: [dpdk-dev] [PATCH 0/4] make vhost PMD available for secondary processes

Hi vhost PMD maitainers, I have not got any feedback yet. Since this is the first time I submit a patch, something may be wrong, would you tell me what should I do ? Thanks. On Thu, 9 Jan 2020 08:22:05 +0900 Itsuro Oda wrote: > vhost PMD has not been available for secondary processes si

[dpdk-dev] [PATCH 0/4] make vhost PMD available for secondary processes

leaves it to user's responsibility.) This precondition will not be a problem in most use cases (including SPP). v2: - add signed-off-by - fix spelling error Itsuro Oda (4): net/vhost: remove an unused member net/vhost: allocate iface_name from heap net/vhost: delay vhost driver setup

[dpdk-dev] [PATCH 2/4] net/vhost: allocate iface_name from heap

allocate iface_name of pmd_internal from heap in order to be able to refer from secondary processes. Signed-off-by: Itsuro Oda --- drivers/net/vhost/rte_eth_vhost.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost

[dpdk-dev] [PATCH 3/4] net/vhost: delay vhost driver setup

setting vhost driver is delayed at eth_dev configuration in order to be able to set it from a secondary process. Signed-off-by: Itsuro Oda --- drivers/net/vhost/rte_eth_vhost.c | 130 ++ 1 file changed, 78 insertions(+), 52 deletions(-) diff --git a/drivers/net

[dpdk-dev] [PATCH 4/4] net/vhost: make secondary probe complete

add lacking member setting and make secondary probe complete. Signed-off-by: Itsuro Oda --- drivers/net/vhost/rte_eth_vhost.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c index 44f44cea3..485a88794

[dpdk-dev] [PATCH 1/4] net/vhost: remove an unused member

remove an unused member from pmd_internal. Signed-off-by: Itsuro Oda --- drivers/net/vhost/rte_eth_vhost.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c index 46f01a7f4..d4e3485ce 100644 --- a

Re: [dpdk-dev] [PATCH 0/4] make vhost PMD available for secondary processes

Hi, I will fix to add signed-off-by and correct spelling error according to test-report@dpdk. Please check the content until then. Thanks. On Wed, 8 Jan 2020 15:25:06 +0900 o...@valinux.co.jp wrote: > From: Itsuro Oda > > vhost PMD has not been available for secondary processes sin