On 2023/8/21 14:06, Honnappa Nagarahalli wrote:
It would be good if you could fix the email on your side to text
format. Comments inline.
Seems a wrong setting on my email client. Sorry.
*From:* Jack Min
*Sent:* Friday, August 18, 2023 8:35 PM
*To:* Honnappa Nagarahalli ; Stephen
On 2023/8/19 19:57, Konstantin Ananyev wrote:
18/08/2023 10:38, Jack Min пишет:
On 2023/8/18 17:05, Konstantin Ananyev wrote:
On 2023/8/17 22:06, Stephen Hemminger wrote:
On Thu, 17 Aug 2023 05:06:20 +
Honnappa Nagarahalli wrote:
Hi Matan, Viacheslav,
Tyler pointed out that the
On 2023/8/18 21:59, Honnappa Nagarahalli wrote:
*From:* Jack Min
*Sent:* Friday, August 18, 2023 12:57 AM
*To:* Honnappa Nagarahalli ; Stephen
Hemminger
*Cc:* dev@dpdk.org; Matan Azrad ;
viachesl...@nvidia.com; Tyler Retzlaff ;
Wathsala Wathawana Vithanage ; nd
*Subject:* Re: MLX5 PMD
On 2023/8/18 17:05, Konstantin Ananyev wrote:
On 2023/8/17 22:06, Stephen Hemminger wrote:
On Thu, 17 Aug 2023 05:06:20 +
Honnappa Nagarahalli wrote:
Hi Matan, Viacheslav,
Tyler pointed out that the function __mlx5_hws_cnt_pool_enqueue_revert
is accessing the ring private struc
On 2023/8/18 12:30, Honnappa Nagarahalli wrote:
-Original Message-
From: Jack Min
Sent: Thursday, August 17, 2023 9:32 PM
To: Stephen Hemminger; Honnappa
Nagarahalli
Cc:dev@dpdk.org; Matan Azrad;
viachesl...@nvidia.com; Tyler Retzlaff;
Wathsala Wathawana Vithanage; nd
Subject: Re
On 2023/8/17 22:06, Stephen Hemminger wrote:
On Thu, 17 Aug 2023 05:06:20 +
Honnappa Nagarahalli wrote:
Hi Matan, Viacheslav,
Tyler pointed out that the function __mlx5_hws_cnt_pool_enqueue_revert
is accessing the ring private structure members (prod.head and prod.tail)
directly.
On 6/2/22 14:10, Ori Kam wrote:
Hi,
Hello,
-Original Message-
From: Andrew Rybchenko
Sent: Wednesday, June 1, 2022 9:21 PM
Subject: Re: [RFC v2 2/2] ethdev: queue-based flow aged report
Again, summary must not be a statement.
On 6/1/22 10:39, Xiaoyu Min wrote:
When application use
On 6/2/22 02:21, Andrew Rybchenko wrote:
Again, summary must not be a statement.
I'l re-phrase it.
On 6/1/22 10:39, Xiaoyu Min wrote:
When application use queue-based flow rule management and operate the
same flow rule on the same queue, e.g create/destroy/query, API of
querying aged flow rule
On 6/2/22 02:20, Andrew Rybchenko wrote:
Summary must not be a statement. May be:
ethdev: add strict queue to pre-configuration flow hints
Ok, I'll change to this.
On 6/1/22 10:39, Xiaoyu Min wrote:
The data-path focused flow rule management can manage flow rules in more
optimized way than tr
On 5/31/22 00:42, Thomas Monjalon wrote:
07/04/2022 07:30, Xiaoyu Min:
When application use queue-based flow management and operate the same
flow on the same queue, e.g create/destroy/query, API for querying aged
flows should also with queue id parameter just like other queue-based
flow APIs.
A
On 5/31/22 00:46, Thomas Monjalon wrote:
We were waiting for a v2 of this patch.
Hey Thomas,
Thank you for the comments.
Yes, I'll send v2.
More comments below.
I'll update the patch in v2 accordingly.
07/04/2022 07:30, Xiaoyu Min:
The data-path focused flow rule management can manage f
On 4/7/22 23:04, Stephen Hemminger wrote:
On Thu, 7 Apr 2022 13:30:46 +0800
Xiaoyu Min wrote:
* @b EXPERIMENTAL: this API may change without prior notice.
@@ -4972,6 +4983,11 @@ struct rte_flow_port_attr {
* @see RTE_FLOW_ACTION_TYPE_METER
*/
uint32_t nb_meters;
+
On 4/7/22 19:27, Ori Kam wrote:
Hi Jack,
Hey Ori,
-Original Message-
From: Jack Min
Sent: Thursday, April 7, 2022 8:31 AM
Subject: [RFC 1/2] ethdev: port flags for pre-configuration flow hints
The data-path focused flow rule management can manage flow rules in more
optimized way
On Mon, 21-07-12, 08:05, Raslan Darawsheh wrote:
Hey,
> Hi,
>
> > -Original Message-
> > From: dev On Behalf Of Xiaoyu Min
> > Sent: Wednesday, July 7, 2021 5:33 AM
> > To: Matan Azrad ; Shahaf Shuler
> > ; Slava Ovsiienko ; Dekel
> > Peled ; Ori Kam
> > Cc: dev@dpdk.org; sta...@dpdk.or
On Mon, 21-04-19, 16:40, Ferruh Yigit wrote:
> On 4/19/2021 8:43 AM, Jack Min wrote:
> > On Tue, 21-04-13, 16:10, Jeff Guo wrote:
> > > Add the new items to support the flow configuration for IP fragment
> > > packets.
> > >
> > > Signed-o
On Tue, 21-04-13, 16:10, Jeff Guo wrote:
> Add the new items to support the flow configuration for IP fragment
> packets.
>
> Signed-off-by: Ting Xu
> Signed-off-by: Jeff Guo
> ---
> app/test-pmd/cmdline_flow.c | 21 -
> 1 file changed, 20 insertions(+), 1 deletion(-)
[...s
Currently RSS expansion only support IPv4 as GRE payload or
delivery protocol (RFC2784). IPv6 as GRE payload or delivery protocol
(RFC7676) is not supported.
This patch add RSS expansion for RFC7676 so PMD can expand flow item
correctly.
Fixes: f4b901a46aec ("net/mlx5: add flow GRE item")
Cc: sta
Added more information of shared action on
how to update, query, and the benefits.
Signed-off-by: Xiaoyu Min
---
doc/guides/prog_guide/rte_flow.rst | 7 +++
1 file changed, 7 insertions(+)
diff --git a/doc/guides/prog_guide/rte_flow.rst
b/doc/guides/prog_guide/rte_flow.rst
index 0b8c243fe1
This series update documents as following:
1. Add more information about shared action in rte_flow.rst.
2. Group all supported shared actions in mlx5.rst
Xiaoyu Min (2):
doc: more info of rte flow shared action
doc: group mlx5 shared actions
doc/guides/nics/mlx5.rst | 30 +
Put all supported shared actions in one new table
Signed-off-by: Xiaoyu Min
---
doc/guides/nics/mlx5.rst | 30 +-
1 file changed, 21 insertions(+), 9 deletions(-)
diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst
index e99fea4342..dbd7ae1bb9 100644
---
> -Original Message-
> From: Ferruh Yigit
> Sent: Tuesday, November 17, 2020 00:23
> To: Xiaoyu Min ; Jingjing Wu ;
> Beilei Xing
> Cc: dev@dpdk.org; Jack Min ; NBU-Contact-Thomas
> Monjalon ; Andrew Rybchenko
> ; Ori Kam ; Dekel Peled
>
> Subject: Re: [
On Sun, 20-01-19, 22:08, Thomas Monjalon wrote:
> 17/01/2020 20:26, Ferruh Yigit:
> > On 1/17/2020 11:55 AM, Xiaoyu Min wrote:
> > > Xiaoyu Min (2):
> > > ethdev: add API to dump device internal flow info
> > > net/mlx5: support flow dump API
> > >
> > > Xueming Li (3):
> > > app/testpmd: ne
On Fri, 20-01-17, 16:47, Slava Ovsiienko wrote:
> Hi, Jack
>
> > -Original Message-
> > From: Xiaoyu Min
> > Sent: Thursday, January 16, 2020 12:14
> > To: jerinjac...@gmail.com; Ori Kam ; Slava Ovsiienko
> > ; Matan Azrad ; Raslan
> > Darawsheh ; Shahaf Shuler
> > ; Anatoly Burakov
> >
On Tue, 20-01-14, 19:30, Jerin Jacob wrote:
> On Tue, Jan 14, 2020 at 3:45 PM Jack Min wrote:
> >
> > On Tue, 20-01-14, 10:01, Jerin Jacob wrote:
> > > On Tue, Jan 14, 2020 at 9:15 AM Xiaoyu Min wrote:
> > > >
> > > > From: Xueming Li
> > &
On Tue, 20-01-14, 10:01, Jerin Jacob wrote:
> On Tue, Jan 14, 2020 at 9:15 AM Xiaoyu Min wrote:
> >
> > From: Xueming Li
> >
> > New flow dump CLI to dump MLX5 PMD specific flows into screen.
> >
> > Signed-off-by: Xueming Li
> > Signed-off-by: Xiaoyu Min
> > ---
> > app/test-pmd/Makefile
On Mon, 19-11-11, 10:42, Matan Azrad wrote:
> There is a rte_flow API which expands a RSS flow pattern to multipile
> patterns according to the RSS hash types in the RSS action
> configuration.
>
> Aa part of the expansion, detection of the last item of the flow uses
> the "next proto" field of th
On Tue, 19-11-05, 11:11, Thomas Monjalon wrote:
> Hi Jack,
>
> If it is a fix, please change your title.
>
Ok, I will add 'fix' in title.
> 05/11/2019 10:16, Xiaoyu Min:
> > When rte_flow_expand_rss expands rte_flow item list based on the RSS
> > types.
>
> There is no verb in this sentence.
>
Hey,
Anyone has any comments on this patch?
-Jack
On Mon, 19-09-16, 17:21, Xiaoyu Min wrote:
> In some scenarios, the raw_encap/raw_decap actions could be multiple in
> one single flow (e,g. hirepin flow):
>
> ... actions raw_decap / raw_encap / raw_decap / raw_encap / ...
>
> This requires
Hey,
Anyone has any comments?
-Jack
On Sat, 19-08-31, 16:28, Xiaoyu Min wrote:
> In some scenarios, the raw_encap/raw_decap actions could be multiple in
> one single flow (e,g. hirepin flow):
>
> ... actions raw_decap / raw_encap / raw_decap / raw_encap / ...
>
> This requires the testpmd su
On Mon, 19-07-22, 18:36, Dekel Peled wrote:
> NVGRE has a GRE header with c_rsvd0_ver value 0x2000 and protocol
> value 0x6558.
> These should be matched when item_nvgre is provided.
>
> This patch adds validation function of NVGRE item.
> It also updates the translate function of NVGRE item, to a
On Mon, 19-07-22, 19:33, Dekel Peled wrote:
> Thanks, PSB.
>
> > -Original Message-
> > From: Jack Min
> > Sent: Monday, July 22, 2019 12:31 PM
> > To: Dekel Peled
> > Cc: Yongseok Koh ; Slava Ovsiienko
> > ; Shahaf Shuler ; Ori
> > Kam
On Thu, 19-07-18, 22:42, Dekel Peled wrote:
> NVGRE has a GRE header with c_rsvd0_ver value 0x2000 and protocol
> value 0x6558.
> These should be matched when item_nvgre is provided.
>
> This patch adds validation function of NVGRE item, to validate that
> the input values, if exist, are as requir
On Thu, 19-07-18, 22:42, Dekel Peled wrote:
> In functions flow_dv_translate() and flow_dv_validate(), the flow
> items are scanned and each item is marked in item_flags bitmap.
> The code handling some of the items was ported from another project,
> where items are marked in a slightley different
On Thu, 19-07-18, 22:41, Dekel Peled wrote:
> The new define MLX5_FLOW_LAYER_IPIP is using the same value as
> existing define MLX5_FLOW_LAYER_GRE_KEY.
> This patch updates the values to be in order.
>
> Fixes: 1b5624cd9062 ("net/mlx5: support IP-in-IP tunnel")
> Signed-off-by: Dekel Peled
> ---
On Wed, 19-07-17, 09:20, Ferruh Yigit wrote:
> On 7/17/2019 2:24 AM, Jack Min wrote:
> > On Tue, 19-07-16, 18:41, Ferruh Yigit wrote:
> >> On 7/10/2019 11:43 AM, Xiaoyu Min wrote:
> >>> This patch intend to support
> >>> action_raw_encap/decap [1] in a g
On Tue, 19-07-16, 18:41, Ferruh Yigit wrote:
> On 7/10/2019 11:43 AM, Xiaoyu Min wrote:
> > This patch intend to support
> > action_raw_encap/decap [1] in a generic and convenient way.
> >
> > Two new commands - set raw_encap, set raw_decap are introduced just
> > like the other commands for encap
va
>
> > -Original Message-
> > From: dev On Behalf Of Slava Ovsiienko
> > Sent: Wednesday, July 10, 2019 17:20
> > To: Jack Min ; Raslan Darawsheh
> > ; Shahaf Shuler ;
> > Yongseok Koh ; John McNamara
> > ; Marko Kovacevic
> >
> >
On Tue, 19-07-09, 11:54, Thomas Monjalon wrote:
> 09/07/2019 11:02, Xiaoyu Min:
> > --- a/doc/guides/rel_notes/release_19_08.rst
> > +++ b/doc/guides/rel_notes/release_19_08.rst
> > @@ -191,6 +191,11 @@ New Features
> >Added telemetry mode to l3fwd-power application to report
> >application
On Mon, 19-07-08, 18:41, Ferruh Yigit wrote:
> On 7/2/2019 2:53 PM, Xiaoyu Min wrote:
> > This patch intend to support
> > action_raw_encap/decap [1] in a generic and convenient way.
> >
> > Two new commands - set raw_encap, set raw_decap are introduced just
> > like the other commands for encap/d
On Fri, 19-07-05, 10:58, Adrien Mazarguil wrote:
> On Fri, Jul 05, 2019 at 10:14:45AM +0800, Xiaoyu Min wrote:
> > support matching on GRE key and present bits (C,K,S)
> >
> > example testpmd command could be:
> > testpmd>flow create 0 ingress group 1 pattern eth / ipv4 /
> > gre / gre_key
On Thu, 19-07-04, 14:13, Adrien Mazarguil wrote:
> On Thu, Jul 04, 2019 at 11:56:35AM +0000, Jack Min wrote:
> > On Thu, 19-07-04, 11:52, Adrien Mazarguil wrote:
> > > On Thu, Jul 04, 2019 at 05:52:43AM +, Jack Min wrote:
> > > > On Wed, 19-07-03, 17:25, Adrien
On Thu, 19-07-04, 11:52, Adrien Mazarguil wrote:
> On Thu, Jul 04, 2019 at 05:52:43AM +0000, Jack Min wrote:
> > On Wed, 19-07-03, 17:25, Adrien Mazarguil wrote:
> > > On Tue, Jul 02, 2019 at 05:45:55PM +0800, Xiaoyu Min wrote:
> > > > support matching on G
On Wed, 19-07-03, 17:25, Adrien Mazarguil wrote:
> On Tue, Jul 02, 2019 at 05:45:55PM +0800, Xiaoyu Min wrote:
> > support matching on GRE key and present bits (C,K,S)
> >
> > example testpmd command could be:
> > testpmd>flow create 0 ingress group 1 pattern eth / ipv4 /
> > gre crksv
On Wed, 19-07-03, 17:25, Adrien Mazarguil wrote:
> On Tue, Jul 02, 2019 at 05:45:52PM +0800, Xiaoyu Min wrote:
> > Add new rte_flow_item_gre_key in order to match the optional key field.
> >
> > Signed-off-by: Xiaoyu Min
>
> OK with adding this feature, however I still have a bunch of comments b
On Wed, 19-07-03, 16:06, Thomas Monjalon wrote:
> 02/07/2019 11:45, Xiaoyu Min:
> > + /**
> > +* Matches a GRE optional key field.
> > +*
> > +* The value should a big-endian 32bit integer.
> > +*/
> > + RTE_FLOW_ITEM_TYPE_GRE_KEY,
>
> We probably want to use the same format as
On Wed, 19-07-03, 14:14, Slava Ovsiienko wrote:
> Hi, Xiaoyu
>
> Please, see below.
> With best regards,
> Slava
>
> > -Original Message-
> > From: dev On Behalf Of Xiaoyu Min
> > Sent: Tuesday, July 2, 2019 9:26
> > To: Raslan Darawsheh ; Shahaf Shuler
> > ; Yongseok Koh ; John
> > McNa
On Mon, 19-07-01, 13:40, Ori Kam wrote:
> Hi Jack,
>
> I know I acked this patch, but after Dekel patch,
> https://patches.dpdk.org/patch/55667/
>
> Where it was decided to remove structures for just one variable,
> and simply use the value. I wish if possible that you will also modify this
> p
On Mon, 19-05-27, 03:20, Shahaf Shuler wrote:
> From: Jack Min
>
> >Add support to match all TCP control bits (flags)
> >except "NS (ECN-nonce)" via Direct Verbs (DV) or Direct Rule (DR)
> >engine.
> >
> >Signed-off-by: Xiaoyu Min
> >Acked
On Tue, 19-05-14, 08:25, Stephen Hemminger wrote:
> On Tue, 14 May 2019 10:18:29 +0300
> Xiaoyu Min wrote:
>
> > Add GRE's checksum, key, and sequence field to the
> > struct rte_flow_item_gre in order to match.
> >
> > Signed-off-by: Xiaoyu Min
> > ---
> > lib/librte_ethdev/rte_flow.h | 4 +++
On Tue, 19-05-14, 11:00, Adrien Mazarguil wrote:
> On Tue, May 14, 2019 at 10:34:22AM +0300, Andrew Rybchenko wrote:
> > On 5/14/19 10:18 AM, Xiaoyu Min wrote:
> > > Add GRE's checksum, key, and sequence field to the
> > > struct rte_flow_item_gre in order to match.
> > >
> > > Signed-off-by: Xiao
Add support to match all TCP control bits (flags)
except "NS (ECN-nonce)" via Direct Verbs (DV) or Direct Rule (DR)
engine.
Signed-off-by: Xiaoyu Min
---
drivers/net/mlx5/mlx5_flow_dv.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5_flow_dv
On 19-01-03 22:20:58, Ori Kam wrote:
> PSB
>
> > -Original Message-
> > From: dev On Behalf Of Dekel Peled
> > Sent: Thursday, January 3, 2019 3:09 PM
> > To: Adrien Mazarguil
> > Cc: dev@dpdk.org; Ori Kam ; Dekel Peled
> > ; Jack Min
&g
add commands which supports following TTL actions:
- RTE_FLOW_ACTION_TYPE_DEC_TTL
- RTE_FLOW_ACTION_TYPE_SET_TTL
Signed-off-by: Xiaoyu Min
Acked-by: Yongseok Koh
---
app/test-pmd/cmdline_flow.c | 34 +
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 5 +++
2 f
rewrite TTL by decrease or just set it directly
it's not necessary to check if the final result
is zero or not
This is slightly different from the one defined
by openflow and more generic
Signed-off-by: Xiaoyu Min
Acked-by: Yongseok Koh
---
doc/guides/prog_guide/rte_flow.rst | 36 +
This patch series is for RFC[1]
Patch 1 adds generic TTL rewrite actions to flow API
Patch 2 adds corresponding testpmd commands
Patch 3 implements the offloading logic of E-Switch rules on Mellanox MLX5
[1]: https://patches.dpdk.org/patch/43617/
v2:
* fix misspelled issues reported by checkpat
Offload following modify TTL actions to E-Switch via
TC-Flower driver
- RTE_FLOW_ACTION_TYPE_SET_TTL
- RTE_FLOW_ACTION_TYPE_DEC_TTL
The corresponding IP protocol rte_flow_item_ipv[4|6]
must be present in rte_flow pattern otherwith PMD
return error
The example testpmd commands are:
flow crea
On 18-10-14 10:35:30, Andrew Rybchenko wrote:
> On 13.10.2018 06:24, Jack Min wrote:
> > rewrite TTL by decrease or just set it directly
> > it's not necessary to check if the final result
> > is zero or not
> >
> > This is slightly different from the one de
If the build environment hasn't 'linux/tc_act/tc_pedit.h',
compiler will use needed structs defined in mlx5_flow_tcf.c.
However, there is a zero-size array defined in one struct and
ISO C forbids this when -Wpedantic is set by debug mode.
Simply put __extension__ keyword before the struct in ques
Offload following modify TTL actions to E-Switch via
TC-Flower driver
- RTE_FLOW_ACTION_TYPE_SET_TTL
- RTE_FLOW_ACTION_TYPE_DEC_TTL
The corresponding IP protocol rte_flow_item_ipv[4|6]
must be present in rte_flow pattern otherwith PMD
return error
The example testpmd commands are:
flow crea
add commands which supports following TTL actions:
- RTE_FLOW_ACTION_TYPE_DEC_TTL
- RTE_FLOW_ACTION_TYPE_SET_TTL
Signed-off-by: Xiaoyu Min
Acked-by: Yongseok Koh
---
app/test-pmd/cmdline_flow.c | 34 +
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 5 +++
2 f
rewrite TTL by decrease or just set it directly
it's not necessary to check if the final result
is zero or not
This is slightly different from the one defined
by openflow and more generic
Signed-off-by: Xiaoyu Min
Acked-by: Yongseok Koh
---
doc/guides/prog_guide/rte_flow.rst | 30 +
This patch series is for RFC[1] and depends on patch[2]
Patch 1 adds generic TTL rewrite actions to flow API
Patch 2 adds corresponding testpmd commands
Patch 3 implements the offloading logic of E-Switch rules on Mellanox MLX5
[1]: https://patches.dpdk.org/patch/43617/
[2]: http://patches.dpdk.o
On 18-10-12 15:12:06, Ferruh Yigit wrote:
> On 10/11/2018 2:27 PM, Jack Min wrote:
> > rewrite TTL by decrease or just set it directly
> > it's not necessary to check if the final result
> > is zero or not
> >
> > This is slightly different from the one de
rte_flow actions:
- RTE_FLOW_ACTION_TYPE_SET_MAC_SRC
- RTE_FLOW_ACTION_TYPE_SET_MAC_DST
added in order to offload to NIC
The rte_flow_itme_eth must be present in rte_flow pattern
Signed-off-by: Xiaoyu Min
Acked-by: Yongseok Koh
Acked-by: Andrew Rybchenko
---
doc/guides/prog_guide/rte_flow.rst
add commands to support following actions:
- RTE_FLOW_ACTION_TYPE_SET_MAC_SRC
- RTE_FLOW_ACTION_TYPE_SET_MAC_DST
Signed-off-by: Xiaoyu Min
Acked-by: Yongseok Koh
---
app/test-pmd/cmdline_flow.c | 50 +
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 8
2
Offload following modify MAC address actions to E-Switch
via TC-Flower driver
- RTE_FLOW_ACTION_TYPE_SET_MAC_SRC
- RTE_FLOW_ACTION_TYPE_SET_MAC_DST
The corresponding rte_flow_item_eth must be present in
rte_flow pattern
Only support modify outer layer MAC address
The example testpmd command is:
This series is for RFC[1] and depends on patch[2]
Patch 1 adds generic MAC address rewrite actions to flow API
Patch 2 adds testpmd commands for that
Patch 3 offloads these actions on Mellanox MLX5 by using E-Switch rule
[1]: https://patches.dpdk.org/patch/44005/
[2]: http://patches.dpdk.org/patc
rewrite TTL by decrease or just set it directly
it's not necessary to check if the final result
is zero or not
This is slightly different from the one defined
by openflow and more generic
Signed-off-by: Xiaoyu Min
Acked-by: Yongseok Koh
---
doc/guides/prog_guide/rte_flow.rst | 24 +
Offload following modify TTL actions to E-Switch via
TC-Flower driver
- RTE_FLOW_ACTION_TYPE_SET_TTL
- RTE_FLOW_ACTION_TYPE_DEC_TTL
The corresponding IP protocol rte_flow_item_ipv[4|6]
must be present in rte_flow pattern otherwith PMD
return error
The example testpmd commands are:
flow crea
This patch series is for RFC[1] and depends on patch[2]
Patch 1 adds generic TTL rewrite actions to flow API
Patch 2 adds corresponding testpmd commands
Patch 3 implements the offloading logic of E-Switch rules on Mellanox MLX5
[1]: https://patches.dpdk.org/patch/43617/
[2]: http://patches.dpdk.o
add commands which supports following TTL actions:
- RTE_FLOW_ACTION_TYPE_DEC_TTL
- RTE_FLOW_ACTION_TYPE_SET_TTL
Signed-off-by: Xiaoyu Min
Acked-by: Yongseok Koh
---
app/test-pmd/cmdline_flow.c | 34 +
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 5 +++
2 f
Offload the following rte_flow actions by inserting accordingly
E-Switch rules via TC Flower driver
- RTE_FLOW_ACTION_TYPE_SET_IPV4_SRC
- RTE_FLOW_ACTION_TYPE_SET_IPV4_DST
- RTE_FLOW_ACTION_TYPE_SET_IPV6_SRC
- RTE_FLOW_ACTION_TYPE_SET_IPV6_DST
- RTE_FLOW_ACTION_TYPE_SET_TP_SRC
- RTE_FLOW_ACT
Offload the following rte_flow actions by inserting accordingly
E-Switch rules via TC Flower driver
- RTE_FLOW_ACTION_TYPE_SET_IPV4_SRC
- RTE_FLOW_ACTION_TYPE_SET_IPV4_DST
- RTE_FLOW_ACTION_TYPE_SET_IPV6_SRC
- RTE_FLOW_ACTION_TYPE_SET_IPV6_DST
- RTE_FLOW_ACTION_TYPE_SET_TP_SRC
- RTE_FLOW_ACT
Offload following modify MAC address actions to E-Switch
via TC-Flower driver
- RTE_FLOW_ACTION_TYPE_SET_MAC_SRC
- RTE_FLOW_ACTION_TYPE_SET_MAC_DST
The corresponding rte_flow_item_eth must be present in
rte_flow pattern
Only support modify outer layer MAC address
The example testpmd command is:
rte_flow actions:
- RTE_FLOW_ACTION_TYPE_SET_MAC_SRC
- RTE_FLOW_ACTION_TYPE_SET_MAC_DST
added in order to offload to NIC
The rte_flow_itme_eth must be present in rte_flow pattern
Signed-off-by: Xiaoyu Min
Acked-by: Yongseok Koh
Acked-by: Andrew Rybchenko
---
doc/guides/prog_guide/rte_flow.rst
add commands to support following actions:
- RTE_FLOW_ACTION_TYPE_SET_MAC_SRC
- RTE_FLOW_ACTION_TYPE_SET_MAC_DST
Signed-off-by: Xiaoyu Min
Acked-by: Yongseok Koh
---
app/test-pmd/cmdline_flow.c | 50 +
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 8
2
This series is for RFC[1] and depends on patch[2]
Patch 1 adds generic MAC address rewrite actions to flow API
Patch 2 adds testpmd commands for that
Patch 3 offloads these actions on Mellanox MLX5 by using E-Switch rule
[1]: https://patches.dpdk.org/patch/44005/
[2]: https://patches.dpdk.org/pat
rewrite TTL by decrease or just set it directly
it's not necessary to check if the final result
is zero or not
This is slightly different from the one defined
by openflow and more generic
Signed-off-by: Xiaoyu Min
Acked-by: Yongseok Koh
---
doc/guides/prog_guide/rte_flow.rst | 30 +
add commands which supports following TTL actions:
- RTE_FLOW_ACTION_TYPE_DEC_TTL
- RTE_FLOW_ACTION_TYPE_SET_TTL
Signed-off-by: Xiaoyu Min
Acked-by: Yongseok Koh
---
app/test-pmd/cmdline_flow.c | 34 +
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 5 +++
2 f
Offload following modify TTL actions to E-Switch via
TC-Flower driver
- RTE_FLOW_ACTION_TYPE_SET_TTL
- RTE_FLOW_ACTION_TYPE_DEC_TTL
The corresponding IP protocol rte_flow_item_ipv[4|6]
must be present in rte_flow pattern otherwith PMD
return error
The example testpmd commands are:
flow crea
This patch series is for RFC[1] and depends on patch[2]
Patch 1 adds generic TTL rewrite actions to flow API
Patch 2 adds corresponding testpmd commands
Patch 3 implements the offloading logic of E-Switch rules on Mellanox MLX5
[1]: https://patches.dpdk.org/patch/43617/
[2]: https://patches.dpdk.
Offload the following rte_flow actions by inserting accordingly
E-Switch rules via TC Flower driver
- RTE_FLOW_ACTION_TYPE_SET_IPV4_SRC
- RTE_FLOW_ACTION_TYPE_SET_IPV4_DST
- RTE_FLOW_ACTION_TYPE_SET_IPV6_SRC
- RTE_FLOW_ACTION_TYPE_SET_IPV6_DST
- RTE_FLOW_ACTION_TYPE_SET_TP_SRC
- RTE_FLOW_ACT
On 18-10-09 06:08:32, Yongseok Koh wrote:
> On Mon, Oct 08, 2018 at 07:22:03PM +0800, Xiaoyu Min wrote:
> > On 18-10-02 04:19:00, Yongseok Koh wrote:
> > > On Sun, Sep 30, 2018 at 03:21:04PM +0800, Xiaoyu Min wrote:
> > > > On 18-09-29 07:03:33, Yongseok Koh wrote:
> > > > > On Tue, Sep 25, 2018 at
Sorry, A wrong title. Please ignore this one.
-Jack
On Thu, Aug 30, 2018 at 02:54:12PM +0800, Xiaoyu Min wrote:
> There is a need to offload rewrite outermost MAC address for both
> destination and source from the matched flow
>
> The proposed actions could make above easily achieved
>
> Sign
On Tue, Aug 28, 2018 at 01:42:18PM -0700, Yongseok Koh wrote:
> On Fri, Aug 24, 2018 at 02:45:00PM +0800, Jack MIN wrote:
> > On Thu, Aug 23, 2018 at 02:08:09PM -0700, Yongseok Koh wrote:
> > > On Thu, Aug 23, 2018 at 02:38:51PM +0800, Xiaoyu Min wrote:
> > > > rte_
On Tue, Aug 28, 2018 at 01:15:09PM +0300, Andrew Rybchenko wrote:
> On 08/07/2018 05:20 PM, Jack Min wrote:
> > There is a need to offload rewrite MAC address for both destination and
> > source
> > from the matched flow
> >
> > The proposed actions
On Thu, Aug 23, 2018 at 03:00:53PM +0100, Ferruh Yigit wrote:
> On 8/7/2018 3:20 PM, Jack Min wrote:
> > There is a need to rewrite TTL by decrease or just set it directly,
> > and it's not necessary to check if the final result is zero or not.
> >
> > This is
On Thu, Aug 23, 2018 at 02:08:09PM -0700, Yongseok Koh wrote:
> On Thu, Aug 23, 2018 at 02:38:51PM +0800, Xiaoyu Min wrote:
> > rte_errno is a per thread variable and is widely used as an
> > error indicator, which means a function could affect
> > other functions' results by setting rte_errno care
On Tue, Aug 21, 2018 at 01:44:32PM +0530, Rahul Lakkireddy wrote:
> On Tuesday, August 08/14/18, 2018 at 14:45:45 +0530, Jack MIN wrote:
> > On Mon, Aug 13, 2018 at 03:38:18PM +0530, Rahul Lakkireddy wrote:
> > > On Tuesday, August 08/07/18, 2018 at 14:20:10 +, Jack Min wrote
On Mon, Aug 13, 2018 at 03:38:18PM +0530, Rahul Lakkireddy wrote:
> On Tuesday, August 08/07/18, 2018 at 14:20:10 +0000, Jack Min wrote:
> > There is a need to offload rewrite MAC address for both destination and
> > source
> > from the matched flow
> >
> > The
There is a need to rewrite TTL by decrease or just set it directly,
and it's not necessary to check if the final result is zero or not.
This is slightly different from the one defined by openflow and
make the actions more generic.
Signed-off-by: Xiaoyu Min
---
lib/librte_ethdev/rte_flow.h |
There is a need to offload rewrite MAC address for both destination and source
from the matched flow
The proposed actions could make above easily achieved
Signed-off-by: Xiaoyu Min mailto:jack...@mellanox.com>>
---
lib/librte_ethdev/rte_flow.h | 32
1 file changed
> -Original Message-
> From: Rahul Lakkireddy
> Sent: July 10, 2018 21:14
> To: Adrien Mazarguil
> Cc: Jack Min ; dev@dpdk.org; Shagun Agarwal
> ; Indranil Choudhury ; Nirranjan
> Kirubaharan ; Shahaf Shuler ;
> Xueming(Steven) Li
> Subject: Re: [dpdk-de
Rahul, Thank you 😊!
-Jack
> -Original Message-
> From: Rahul Lakkireddy
> Sent: July 3, 2018 21:39
> To: Jack Min
> Cc: dev@dpdk.org; Shagun Agarwal ; Indranil Choudhury
> ; Nirranjan Kirubaharan ; Shahaf
> Shuler ; Xueming(Steven) Li
> Subject: Re: [dpdk-de
-255
deeper if available */
};
What do you think ?
-Jack
> -Original Message-
> From: Rahul Lakkireddy
> Sent: July 2, 2018 20:04
> To: Jack Min
> Cc: dev@dpdk.org; Shagun Agarwal ; Indranil Choudhury
> ; Nirranjan Kirubaharan ; Shahaf
> Shuler ; Xueming(Stev
Hey,
I've one question:
Do those APIs support modify inner IP headers?
In our scenarios, we need to specific that NAT action is on inner or outer IP
header.
Thanks,
-Jack
> -Original Message-
> From: dev On Behalf Of Rahul Lakkireddy
> Sent: June 22, 2018 17:56
> To: dev@dpdk.org
96 matches
Mail list logo
