Re: [dpdk-dev][PATCH] ethdev: add send queue flow matching item

2023-05-12 Thread Jan Viktorin
Hi all, I'd like to test this feature somehow but this patch just implements the API... Will there be some PMD support soon? I could see that mlx5 implements some internal hidden RTE Flow item SC already that matches this behaviour... It would be great to make it available via this TX_QUEUE fea

Re: [PATCH 4/4] doc: note that testpmd on mlx5 has dedicated queues problem

2023-03-07 Thread Jan Viktorin
.vutbr.cz; Xiaoyun Li ; > >> Ferruh Yigit > >> ; Andrew Rybchenko > >> ; > >> Ajit Khaparde ; Haiyue Wang > >> ; Ori Kam ; Haifei Luo > >> ; Slava Ovsiienko ; > >> Andrey Vesnovaty ; Bing Zhao > >> ; Jiawei(Jonny) Wang

Re: [PATCH] MAINTAINERS: drop email address for Jan Viktorin

2022-09-05 Thread Jan Viktorin
On Wed, 31 Aug 2022 22:25:24 +0200 Thomas Monjalon wrote: > 31/08/2022 21:30, Stephen Hemminger: > > Going over list of active DPDK developers and MAINTAINERS > > and noticed that Jan's email was not active. His response was: > > > >well, that rehivetech.com address is probably receiving but

Re: [dpdk-dev] [PATCH 3/3] net/bonding: start ethdev prior to setting 8023ad flow

2021-08-26 Thread Jan Viktorin
On Tue, 24 Aug 2021 14:18:16 +0100 Ferruh Yigit wrote: > On 7/15/2021 2:58 PM, Thomas Monjalon wrote: > > 14/07/2021 17:00, Jan Viktorin: > >>>> On Tue, 13 Jul 2021 12:26:35 +0300 > >>>> Andrew Rybchenko wrote: > >>>>>&g

Re: [dpdk-dev] [PATCH 2/2] fib: announce experimental tag removal of the fib API

2021-08-05 Thread Jan Viktorin
On Thu, 5 Aug 2021 16:29:50 +0200 "Medvedkin, Vladimir" wrote: > On 05/08/2021 16:07, Jan Viktorin wrote: > > On Thu, 5 Aug 2021 15:57:14 +0200 > > "Medvedkin, Vladimir" wrote: > > > >> On 05/08/2021 15:32, Jan Viktorin wrote: > &

Re: [dpdk-dev] [PATCH 2/2] fib: announce experimental tag removal of the fib API

2021-08-05 Thread Jan Viktorin
On Thu, 5 Aug 2021 15:57:14 +0200 "Medvedkin, Vladimir" wrote: > On 05/08/2021 15:32, Jan Viktorin wrote: > > On Thu, 5 Aug 2021 15:27:15 +0200 > > "Medvedkin, Vladimir" wrote: > > > >> Hi Jan, > >> > >> The RIB is always

Re: [dpdk-dev] [PATCH 2/2] fib: announce experimental tag removal of the fib API

2021-08-05 Thread Jan Viktorin
can build a FIB for the data plane. And when the single RIB is updated (which can take quite a lot of time) I build a new FIB and locklessly give it to the dataplane. Such approach is not considered? Jan > > > On 05/08/2021 15:14, Jan Viktorin wrote: > > On Thu, 5 Aug 2021 15:08:13

Re: [dpdk-dev] [PATCH 3/3] net/bonding: start ethdev prior to setting 8023ad flow

2021-07-14 Thread Jan Viktorin
On Tue, 13 Jul 2021 17:17:51 + Ori Kam wrote: > Hi Jan, > > > -Original Message- > > From: Jan Viktorin > > Sent: Tuesday, July 13, 2021 2:06 PM > > > > On Tue, 13 Jul 2021 12:26:35 +0300 > > Andrew Rybchenko wrote: > >

Re: [dpdk-dev] [PATCH 3/3] net/bonding: start ethdev prior to setting 8023ad flow

2021-07-13 Thread Jan Viktorin
On Tue, 13 Jul 2021 12:26:35 +0300 Andrew Rybchenko wrote: > On 7/13/21 11:18 AM, Havlík Martin wrote: > > Dne 2021-07-12 15:07, Ori Kam napsal: > >> Hi Jan, > >> > >>> -----Original Message- > >>> From: Jan Viktorin > >>>

Re: [dpdk-dev] [PATCH 3/3] net/bonding: start ethdev prior to setting 8023ad flow

2021-07-11 Thread Jan Viktorin
On Sun, 11 Jul 2021 08:49:18 + Ori Kam wrote: > Hi Jan, Hi Ori, > > > > -Original Message- > > From: dev On Behalf Of Jan Viktorin > > Sent: Wednesday, July 7, 2021 6:54 PM > > > > On Sun, 4 Jul 2021 15:18:01 + > > Matan A

Re: [dpdk-dev] [PATCH 3/3] net/bonding: start ethdev prior to setting 8023ad flow

2021-07-07 Thread Jan Viktorin
desirable to accidently omit a packet that was received by primary ingress logic instead of being redirected into the dedicated queue. Are there any chances that for mlx5 it would be possible to insert flow rules before calling rte_eth_dev_start? Anyway, the behaviour should be specified and d

[dpdk-dev] [PATCH] ethdev: fix doc comment for struct rte_flow_action

2021-06-23 Thread Jan Viktorin
The struct rte_flow_action was missing from DPDK API documentation. Signed-off-by: Jan Viktorin --- lib/ethdev/rte_flow.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h index 961a5884fe..70f455d47d 100644 --- a/lib/ethdev

Re: [dpdk-dev] [PATCH 2/2] net/mlx5: avoid unbind step to enable switchdev mode

2021-03-15 Thread Jan Viktorin
On Mon, 15 Mar 2021 19:52:46 + Slava Ovsiienko wrote: > Hi, Jan > > > -Original Message- > > From: Jan Viktorin > > Sent: Monday, March 15, 2021 21:49 > > To: Slava Ovsiienko > > Cc: dev@dpdk.org; Asaf Penso ; Shahaf Shuler > > ; Matan Az

Re: [dpdk-dev] [PATCH 2/2] net/mlx5: avoid unbind step to enable switchdev mode

2021-03-15 Thread Jan Viktorin
dicated PCI device) > - ens1f0_2 (no dedicated PCI device) > > 6. As result we should get 7 netdevs - 1 PF (Uplink representor), 3 VFs, 3 > representors (no PCI device, pure netdev) > > With best regards, Slava > > > -Original Message- > > From: Jan Viktorin

Re: [dpdk-dev] Duplicating traffic with RTE Flow

2021-03-15 Thread Jan Viktorin
OK, after firmware update, it seems that it works now. Thank you for help! Jan On Mon, 15 Mar 2021 14:22:16 +0100 Jan Viktorin wrote: > Hello Jiawei, > > On Fri, 12 Mar 2021 09:32:44 + > "Jiawei(Jonny) Wang" wrote: > > > Hi Jan, > > > > &

[dpdk-dev] [PATCH 2/2] net/mlx5: avoid unbind step to enable switchdev mode

2021-03-15 Thread Jan Viktorin
From: Jan Viktorin The step 4 is a contradiction. It advices to unbind the device from the mlx5_core which removes the associated system network interface (e.g. eth0). In the step 5, the same system network interface (e.g. eth0) is required to exist. Signed-off-by: Jan Viktorin --- doc/guides

[dpdk-dev] [PATCH 1/2] net/mlx5: fix typos

2021-03-15 Thread Jan Viktorin
From: Jan Viktorin Signed-off-by: Jan Viktorin --- doc/guides/nics/mlx5.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index 7c50497fb..0a2dc3dee 100644 --- a/doc/guides/nics/mlx5.rst +++ b/doc/guides/nics/mlx5

Re: [dpdk-dev] [PATCH 2/2] net/mlx5: avoid unbind step to enable switchdev mode

2021-03-15 Thread Jan Viktorin
# echo switchdev > /sys/class/net//compat/devlink/mode It is good to mention that after the rebind, the can change. Regards, Jan > > echo -n "" > > /sys/bus/pci/drivers/mlx5_core/bind > > With best regards, > Slava > > > -Original Message

Re: [dpdk-dev] Duplicating traffic with RTE Flow

2021-03-15 Thread Jan Viktorin
Hello Jiawei, On Fri, 12 Mar 2021 09:32:44 + "Jiawei(Jonny) Wang" wrote: > Hi Jan, > > > -Original Message- > > From: Jan Viktorin > > Sent: Friday, March 12, 2021 12:33 AM > > To: Jiawei(Jonny) Wang > > Cc: Slava Ovsiienko ; Asaf

Re: [dpdk-dev] Duplicating traffic with RTE Flow

2021-03-11 Thread Jan Viktorin
ping port 0... Stopping ports... Done Stopping port 1... Stopping ports... Done Shutting down port 0... Closing ports... Port 0 is closed Done Shutting down port 1... Closing ports... Port 1 is closed Done Bye... Jan > > Thanks. > Jonny > > > -Original Message

Re: [dpdk-dev] Duplicating traffic with RTE Flow

2021-03-01 Thread Jan Viktorin
Jan [1] http://mails.dpdk.org/archives/dev/2021-March/200475.html > > With best regards, Slava > > > -Original Message- > > From: Jan Viktorin > > Sent: Monday, March 1, 2021 14:21 > > To: Asaf Penso > > Cc: dev@dpdk.org; Ori Kam ; Jiawei(J

Re: [dpdk-dev] Duplicating traffic with RTE Flow

2021-03-01 Thread Jan Viktorin
different traffic. > > [1] > http://patches.dpdk.org/project/dpdk/list/?series=12045 > > Regards, > Asaf Penso > > >-Original Message- > >From: dev On Behalf Of Jan Viktorin > >Sent: Friday, September 18, 2020 3:56 PM > >To: dev@dpdk.org > >Subject

Re: [dpdk-dev] Duplicating traffic with RTE Flow

2020-09-23 Thread Jan Viktorin
Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 ethdev: introduce sample action for rte flow Jan > > Thanks. > B.R. > > Jonny > > > -Original Message- > > From: Jan Viktorin > > Se

Re: [dpdk-dev] Duplicating traffic with RTE Flow

2020-09-21 Thread Jan Viktorin
failed: drivers/net/mlx5/mlx5_flow_dv.c:80 error: drivers/net/mlx5/mlx5_flow_dv.c: patch does not apply error: patch failed: drivers/net/mlx5/mlx5_flow_dv.c:9007 error: drivers/net/mlx5/mlx5_flow_dv.c: patch does not apply Jan > > Regards, > Asaf Penso > > >-Original Message----- >

[dpdk-dev] Duplicating traffic with RTE Flow

2020-09-18 Thread Jan Viktorin
was no support on mlx5 for passthru... flow isolate 0 true flow create 0 ingress pattern end actions passthru / rss end / end Is there any other possibility or PMD+NIC that is known to solve such issue? Thanks Jan Viktorin [1] https://doc.dpdk.org/guides/prog_guide/rte_flow.html#table-rte

Re: [dpdk-dev] [PATCH 01/51] ethdev: change rte_eth_dev_info_get() return value to int

2019-08-28 Thread Jan Viktorin
On Wed, 28 Aug 2019 13:09:51 +0300 Andrew Rybchenko wrote: > On 8/28/19 12:51 PM, Jan Viktorin wrote: > > On Tue, 27 Aug 2019 15:25:12 +0100 > > Andrew Rybchenko wrote: > > > >> From: Ivan Ilchenko > >> > >> Change rte_eth_dev_info_get() return

Re: [dpdk-dev] [PATCH 01/51] ethdev: change rte_eth_dev_info_get() return value to int

2019-08-28 Thread Jan Viktorin
On Tue, 27 Aug 2019 15:25:12 +0100 Andrew Rybchenko wrote: > From: Ivan Ilchenko > > Change rte_eth_dev_info_get() return value from void to int and return > negative errno values in case of error conditions. > Modify rte_eth_dev_info_get() usage across the ethdev according > to new return type

[dpdk-dev] [PATCH 4/6] test: use SPDX tag for RehiveTech copyright files

2018-04-09 Thread Jan Viktorin
Replace the BSD license header with the SPDX tag for files with only an RehiveTech copyright on them. Signed-off-by: Jan Viktorin --- test/test/resource.c | 33 ++--- test/test/resource.h | 33 ++--- test/test/test_resource.c

[dpdk-dev] [PATCH 5/6] config: use SPDX tag for RehiveTech copyright files

2018-04-09 Thread Jan Viktorin
Replace the BSD license header with the SPDX tag for files with only an RehiveTech copyright on them. Signed-off-by: Jan Viktorin --- config/defconfig_arm-armv7a-linuxapp-gcc | 31 ++- 1 file changed, 2 insertions(+), 29 deletions(-) diff --git a/config

[dpdk-dev] [PATCH 3/6] drivers: use SPDX tag for RehiveTech copyright files

2018-04-09 Thread Jan Viktorin
Replace the BSD license header with the SPDX tag for files with only an RehiveTech copyright on them. Signed-off-by: Jan Viktorin --- drivers/bus/vdev/rte_bus_vdev.h | 32 ++-- drivers/bus/vdev/vdev.c | 32 ++-- 2 files changed, 4

[dpdk-dev] [PATCH 6/6] lib: use SPDX tag for Cavium & RehiveTech copyright files

2018-04-09 Thread Jan Viktorin
Replace the BSD license header with the SPDX tag for files with a RehiveTech and Cavium copyright on them. Signed-off-by: Jan Viktorin --- lib/librte_eal/common/arch/arm/rte_cpuflags.c | 34 +++ 1 file changed, 3 insertions(+), 31 deletions(-) diff --git a/lib

[dpdk-dev] [PATCH 1/6] mk: use SPDX tag for RehiveTech copyright files

2018-04-09 Thread Jan Viktorin
Replace the BSD license header with the SPDX tag for files with only an RehiveTech copyright on them. Signed-off-by: Jan Viktorin --- mk/arch/arm/rte.vars.mk | 32 ++-- mk/machine/armv7a/rte.vars.mk | 31 ++- 2 files changed, 4

[dpdk-dev] [PATCH 0/6] Use SPDX identifier of RehiveTech code

2018-04-09 Thread Jan Viktorin
Hi all, I've updated all relevant code to SPDX license. The last commit also updates the Cavium copyright, I've separated it for clarity otherwise it can be squashed into 02. Jan Jan Viktorin (6): mk: use SPDX tag for RehiveTech copyright files lib: use SPDX tag for RehiveTech

[dpdk-dev] [PATCH 2/6] lib: use SPDX tag for RehiveTech copyright files

2018-04-09 Thread Jan Viktorin
Replace the BSD license header with the SPDX tag for files with only an RehiveTech copyright on them. Signed-off-by: Jan Viktorin --- .../common/include/arch/arm/rte_atomic.h | 32 ++ .../common/include/arch/arm/rte_atomic_32.h| 32

Re: [dpdk-dev] [PATCH v2] librte_eal: fix wrong assert for arm and ppc

2017-09-22 Thread Jan Viktorin
wer") > > Signed-off-by: Lukasz Majczak Acked-by: Jan Viktorin

Re: [dpdk-dev] [PATCH] librte_eal: fix wrong assert for arm and ppc

2017-09-21 Thread Jan Viktorin
call to open() will return 0 as a valid descriptor. Good catch! Please add also: Fixes: b94e5c9406b5 ("eal/arm: add CPU flags for ARMv7") Fixes: 97523f822ba9 ("eal/arm: add CPU flags for ARMv8") Fixes: 9ae155385686 ("eal/ppc: cpu flag checks for IBM Power") > &g

Re: [dpdk-dev] [PATCH v4 04/41] bus/dpaa: add OF parser for device scanning

2017-09-20 Thread Jan Viktorin
would be two separate devices with not information how they are connected to each other. Such information was accessible only via the device tree. Finally, I also needed to control the PHY from DPDK. Again, information about PHY is unavailable via /sys. Regards Jan -- Jan ViktorinE-mail: vikto...@rehivetech.com System ArchitectWeb:www.RehiveTech.com RehiveTech Brno, Czech Republic

Re: [dpdk-dev] compilation error in l3fwd for ARMv7 NEON

2017-07-07 Thread Jan Viktorin
es/2014-09/msg00162.html they ifdef it for __aarch64. Regards Jan -- Jan Viktorin E-mail: vikto...@rehivetech.com System Architect Web:www.RehiveTech.com RehiveTech Brno, Czech Republic

[dpdk-dev] cmdline.c: error: ‘cmd_set_vf_rxmode’ undeclared here (not in a function)

2017-06-15 Thread Jan Viktorin
md_bnxt.h | 19 +++ drivers/net/bnxt/rte_pmd_bnxt_version.map | 1 + 8 files changed, 124 insertions(+), 9 deletions(-) Regards Jan -- Jan Viktorin E-mail: vikto...@rehivetech.com System Architect Web:www.RehiveTech.com RehiveTech Br

Re: [dpdk-dev] [PATCH 2/6] eal/arm32: rte pause implementation for arm32

2017-05-18 Thread Jan Viktorin
On Thu, 11 May 2017 15:40:42 +0530 Jerin Jacob wrote: > The patch does not provide any functional change for ARM32 > with respect to existing rte_pause() definition. > > CC: Jan Viktorin > CC: Jianbo Liu > Signed-off-by: Jerin Jacob Acked-by: Jan Viktorin

Re: [dpdk-dev] Issue->Dpdk for arm cortex-a15 compilation

2017-05-16 Thread Jan Viktorin
@@ # Locally calculated -sha256 d631495bc6e8d4c4aec72999ac03c3ce213bb996cb88f3bf14bb980dad1d3f7b dpdk-16.04.tar.gz +sha256 f917875b1432adaaebb2761c154623bb101e0308153aa011f06a69bd1e9e98fb dpdk-16.04.tar.gz it works. $ ls output/images/ rootfs.ext2 vexpress-v2p-ca9.dtb zImage Regards Jan > > > Thanks > > On Tue, May 16, 2017

Re: [dpdk-dev] Issue->Dpdk for arm cortex-a15 compilation

2017-05-16 Thread Jan Viktorin
2017 at 5:14 PM, Neil Horman wrote: > > > On Tue, May 16, 2017 at 12:51:40PM +0200, Jan Viktorin wrote: > > > Hello Jimmy, > > > > > > On Tue, 16 May 2017 15:38:22 +0530 > > > Jimmy Carter wrote: > > > > > > > Hi All >

Re: [dpdk-dev] Issue->Dpdk for arm cortex-a15 compilation

2017-05-16 Thread Jan Viktorin
On Tue, 16 May 2017 07:44:59 -0400 Neil Horman wrote: > On Tue, May 16, 2017 at 12:51:40PM +0200, Jan Viktorin wrote: > > Hello Jimmy, > > > > On Tue, 16 May 2017 15:38:22 +0530 > > Jimmy Carter wrote: > > > > > Hi All > > > > >

Re: [dpdk-dev] [dpdk-maintainers] Issue->Dpdk for arm cortex-a15 compilation

2017-05-16 Thread Jan Viktorin
On Tue, 16 May 2017 13:22:19 +0200 Thomas Monjalon wrote: > 16/05/2017 12:51, Jan Viktorin: > > DPDK does not support OpenWRT because (as far as I know) nobody from > > the DPDK community is using it in this way. I build DPDK via Buildroot > > but this is unsupported

Re: [dpdk-dev] Issue->Dpdk for arm cortex-a15 compilation

2017-05-16 Thread Jan Viktorin
Hello Jimmy, On Tue, 16 May 2017 15:38:22 +0530 Jimmy Carter wrote: > Hi All > > I am using dpdk16.11.1 and want to use openwrt external toolchain so that I > can cross compile for arm cortex 15 > neon.(arm_cortex-a15+neon-vfpv4_gcc-5.4.0_musl_eabi) I've never built DPDK with musl-eabi. I don'

Re: [dpdk-dev] [PATCH v3 2/4] eal: move gcc version definition to common header

2017-05-04 Thread Jan Viktorin
compilation on x86 with gcc and clang Tested compilation on: * arm64 with gcc * x86 with gcc and clang > > Signed-off-by: Ashwin Sekhar T K Reviewed-by: Jan Viktorin

Re: [dpdk-dev] [PATCH v3 1/4] mk: add crypto capability for generic armv8a and thunderx

2017-05-04 Thread Jan Viktorin
ese > capabilities > * RTE_CPUFLAG_AES > * RTE_CPUFLAG_PMULL > * RTE_CPUFLAG_SHA1 > * RTE_CPUFLAG_SHA2 > > Signed-off-by: Ashwin Sekhar T K Reviewed-by: Jan Viktorin

Re: [dpdk-dev] [PATCH 1/2] net: add arm64 neon version of CRC compute APIs

2017-05-03 Thread Jan Viktorin
On Fri, 28 Apr 2017 10:19:20 + "Sekhar, Ashwin" wrote: > Hi Jan, > Thanks for the comments. Please see my responses inline. > > On Friday 28 April 2017 03:25 PM, Jan Viktorin wrote: > > Hello Ashwin Sekhar, > > > > some comments below... > &g

Re: [dpdk-dev] [PATCH 1/2] net: add arm64 neon version of CRC compute APIs

2017-04-28 Thread Jan Viktorin
Hello Ashwin Sekhar, some comments below... On Thu, 27 Apr 2017 07:10:20 -0700 Ashwin Sekhar T K wrote: > * Added CRC compute APIs for arm64 utilizing the pmull capability > * Added new file net_crc_neon.h to hold the arm64 pmull CRC > implementation > * Added crypto capability in compilation

Re: [dpdk-dev] [PATCH] mk: fix quoting for ARM mtune argument

2017-04-10 Thread Jan Viktorin
s: 02a8686263de ("mk: introduce ARMv7 architecture") > Fixes: 4a7e4626975a ("mk: introduce NXP dpaa2 architecture based on armv8-a") > > Reported-by: Jan Viktorin > Signed-off-by: Pascal Mazon Tested-by: Jan Viktorin > --- > > I couldn't test it

Re: [dpdk-dev] dpdk-armv7: build failure since de96fe68ae9

2017-04-07 Thread Jan Viktorin
ing HAVE_TC_FLOWER. sh -- '/home/viktorin/dpdk/buildtools/auto-config-h.sh' 'tap_autoconf.h.new' \ HAVE_TC_VLAN_ID \ linux/pkt_cls.h \ enum TCA_FLOWER_KEY_VLAN_PRIO \ It seems like the -mtune="cortex-a9" has extra quotes (or they are misinterpreted

Re: [dpdk-dev] dpdk-armv7: build failure since de96fe68ae9

2017-04-07 Thread Jan Viktorin
On Fri, 7 Apr 2017 14:05:59 +0200 Pascal Mazon wrote: > On Fri, 7 Apr 2017 13:13:13 +0200 > Jan Viktorin wrote: > > > Hello Pascal, > > > > my internal ARMv7 DPDK autobuilder is failing. I've bisected to the > > source of the problem: > > > &g

[dpdk-dev] dpdk-armv7: build failure since de96fe68ae9

2017-04-07 Thread Jan Viktorin
low.o] Error 1 make[3]: *** [tap] Error 2 make[2]: *** [net] Error 2 make[1]: *** [drivers] Error 2 make: *** [all] Error 2 Finished: FAILURE Regards Jan Viktorin -- Jan Viktorin E-mail: vikto...@rehivetech.com System Architect Web:www.RehiveTech.com Rehiv

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] net/virtio: fix performance regression due to TSO enabling

2017-01-12 Thread Jan Viktorin
On Thu, 12 Jan 2017 10:30:58 +0800 Yuanhan Liu wrote: > On Wed, Jan 11, 2017 at 03:51:22PM +0100, Thomas Monjalon wrote: > > 2017-01-11 12:27, Yuanhan Liu: > > > The fact that virtio net header is initiated to zero in PMD driver > > > init stage means that these costly writes are unnecessary an

[dpdk-dev] [PATCH v2 1/8] eal: define container_of macro

2016-11-22 Thread Jan Viktorin
is based on Jan Viktorin's original patch but also checks the > > > > type of the passed pointer against the type of the member. > > > > > > > > Signed-off-by: Jan Viktorin > > > > Signed-off-by: Shreyansh Jain > > > > [jblu

[dpdk-dev] pmdinfogen issues: cross compilation for ARM fails with older host compiler

2016-11-11 Thread Jan Viktorin
gt; > > > > /projects/dpdk_latest/lib/librte_vhost/vhost_user/virtio- > > > > > net-user.c:250:23: > > > > > > error: array subscript is above array bounds [-Werror=array-bounds] > > > > > >rvq = dev->virtqueue[i * VIRTIO_QNUM +

[dpdk-dev] [PATCH v2 1/2] arch/arm: fix file descriptor leakage when getting CPU features

2016-11-04 Thread Jan Viktorin
On Fri, 4 Nov 2016 15:16:42 +0530 Jianbo Liu wrote: > close the file descriptor after finish using it. s/close/Close/ > > Fixes: b94e5c94 (eal/arm: add CPU flags for ARMv7) > Fixes: 97523f82 (eal/arm: add CPU flags for ARMv8) > > Signed-off-by: Jianbo Liu Acked-by: Jan Viktorin

[dpdk-dev] [PATCH v2 2/2] arch/ppc: fix file descriptor leakage when getting CPU features

2016-11-04 Thread Jan Viktorin
On Fri, 4 Nov 2016 15:16:43 +0530 Jianbo Liu wrote: > close the file descriptor after finish using it. s/close/Close/ Please include my ack (below). Jan > > Fixes: 9ae15538 (eal/ppc: cpu flag checks for IBM Power) > > Signed-off-by: Jianbo Liu Acked-by: Jan Viktorin

[dpdk-dev] [PATCH v5 06/21] eal/soc: introduce very essential SoC infra definitions

2016-10-24 Thread Jan Viktorin
On Mon, 24 Oct 2016 17:29:25 +0530 Shreyansh Jain wrote: > From: Jan Viktorin > > Define initial structures and functions for the SoC infrastructure. > This patch supports only a very minimal functions for now. > More features will be added in the following commits. > >

[dpdk-dev] [PATCH v5 01/21] eal: generalize PCI kernel driver enum to EAL

2016-10-24 Thread Jan Viktorin
On Mon, 24 Oct 2016 17:29:20 +0530 Shreyansh Jain wrote: > From: Jan Viktorin > > Signed-off-by: Jan Viktorin > Signed-off-by: Shreyansh Jain I think, there is no reason to prevent merging this. Feel free to add: Acked-by: Jan Viktorin

[dpdk-dev] [PATCH v4 11/17] eal/soc: add default scan for Soc devices

2016-10-24 Thread Jan Viktorin
_TAIL(&soc_driver_list, driver, next); > >> } > > > > I am not in favor of a forced default. What if user never intended it - it > > would lead to wrong scan being used and only intimation which can provided > > to user is a log. > > Selecting such f

[dpdk-dev] [PATCH v4 11/17] eal/soc: add default scan for Soc devices

2016-10-16 Thread Jan Viktorin
On Sat, 15 Oct 2016 19:15:02 +0530 Shreyansh Jain wrote: > From: Jan Viktorin > > Default implementation which scans the sysfs platform devices hierarchy. > For each device, extract the ueven and convert into rte_soc_device. > > The information populated can then be used

[dpdk-dev] [PATCH] doc: arm64: document DPDK application profiling methods

2016-10-04 Thread Jan Viktorin
> > +This method can not be used in production systems as this may alter PMU > > +state used by standard Linux user space tool like perf. > > More details please? > -- Jan Viktorin E-mail: Viktorin at RehiveTech.com System Architect Web:www.RehiveTech.com RehiveTech Brno, Czech Republic

[dpdk-dev] [PATCH v1 0/4] Generalize PCI specific EAL function/structures

2016-10-03 Thread Jan Viktorin
; Probably you are talking about (Patch 3/4 and 4/4). > Is my understanding correct? > > So, movement to just Linux area is not enough? > I am not well versed with BSD way of doing something similar so if > someone can point it out, I can integrate that. (I will investigate it > at

[dpdk-dev] [PATCH v3 06/15] eal/soc: implement probing of drivers

2016-09-20 Thread Jan Viktorin
On Tue, 20 Sep 2016 06:46:31 + Shreyansh Jain wrote: > Hi Jan, > > > -Original Message- > > From: Jan Viktorin [mailto:viktorin at rehivetech.com] > > Sent: Monday, September 19, 2016 5:04 PM > > To: Shreyansh Jain > > Cc: dev at dpdk.org; Hemant

[dpdk-dev] [PATCH v3 06/15] eal/soc: implement probing of drivers

2016-09-19 Thread Jan Viktorin
On Mon, 19 Sep 2016 12:17:53 +0530 Shreyansh Jain wrote: > Hi Jan, > > On Friday 16 September 2016 05:57 PM, Jan Viktorin wrote: > > On Fri, 9 Sep 2016 14:13:50 +0530 > > Shreyansh Jain wrote: > > > >> Each SoC PMD registers a set of callback for scanning

[dpdk-dev] [PATCH v3 00/15] Introduce SoC device/driver framework for EAL

2016-09-18 Thread Jan Viktorin
On Sun, 18 Sep 2016 09:41:55 + Hemant Agrawal wrote: > > -Original Message- > > From: Jan Viktorin [mailto:viktorin at rehivetech.com] > [...] > > > And for each platform/product > > > > > > > I agree, that this can sometimes l

[dpdk-dev] [PATCH v3 00/15] Introduce SoC device/driver framework for EAL

2016-09-18 Thread Jan Viktorin
On Sun, 18 Sep 2016 16:56:54 +0800 Jianbo Liu wrote: > On 18 September 2016 at 15:22, Jan Viktorin > wrote: > > On Sun, 18 Sep 2016 13:58:50 +0800 > > Jianbo Liu wrote: > > > >> On 9 September 2016 at 16:43, Shreyansh Jain

[dpdk-dev] [PATCH v3 00/15] Introduce SoC device/driver framework for EAL

2016-09-18 Thread Jan Viktorin
esented by the OS. Otherwise, such system would introduce security issues. > > I think it can be done in devinit, not in scan function. devinit can > be different for each driver. +1 > > > = PCI based PMDs rely on EAL's capability to detect devices. This >

[dpdk-dev] [PATCH v3 06/15] eal/soc: implement probing of drivers

2016-09-16 Thread Jan Viktorin
al_soc_probe(). > > Patch also adds test case for scan and probe. > > Signed-off-by: Jan Viktorin > Signed-off-by: Shreyansh Jain > Signed-off-by: Hemant Agrawal > --- > app/test/test_soc.c | 138 ++- > lib/librte_eal/bsdapp/e

[dpdk-dev] [PATCH v10 05/25] crypto: no need for a crypto pmd type

2016-09-16 Thread Jan Viktorin
On Fri, 16 Sep 2016 09:59:40 +0530 Shreyansh Jain wrote: > From: David Marchand > > This information is not used and just adds noise. > > Signed-off-by: David Marchand > Signed-off-by: Shreyansh Jain Reviewed-by: Jan Viktorin

[dpdk-dev] [PATCH v10 02/25] eal: remove duplicate function declaration

2016-09-16 Thread Jan Viktorin
5177 ("eal: make vdev init path generic for both virtual and > pci devices") > > Signed-off-by: David Marchand > Signed-off-by: Shreyansh Jain Reviewed-by: Jan Viktorin

[dpdk-dev] [PATCH v3 04/15] eal: introduce --no-soc option

2016-09-16 Thread Jan Viktorin
2016 14:13:48 +0530 Shreyansh Jain wrote: > This option has the same meaning for the SoC infra as the --no-pci > for the PCI infra. > > Signed-off-by: Jan Viktorin > Signed-off-by: Shreyansh Jain > Signed-off-by: Hemant Agrawal > --- > lib/librte_eal/common/

[dpdk-dev] [PATCH v3 02/15] eal/soc: add rte_eal_soc_register/unregister logic

2016-09-15 Thread Jan Viktorin
On Thu, 15 Sep 2016 14:00:25 +0100 "Hunt, David" wrote: > > new file mode 100644 > > index 000..56135ed > > --- /dev/null > > +++ b/lib/librte_eal/common/eal_common_soc.c > > @@ -0,0 +1,56 @@ > > +/*- > > + * BSD LICENSE > > + * > > + * Copyright(c) 2016 RehiveTech. All rights reserved. >

[dpdk-dev] [PATCH v8 00/25] Introducing rte_driver/rte_device generalization

2016-09-01 Thread Jan Viktorin
ff2) > > Background: > === > > It includes two different patch-sets floated on ML earlier: > * Original patch series is from David Marchand [1], [2]. > `- This focused mainly on PCI (PDEV) part > `- v7 of this was posted by me [8] in August/2016 > * Patc

[dpdk-dev] [PATCH] eal/armv8: high-resolution cycle counter

2016-08-19 Thread Jan Viktorin
he cycle count register is not > > disabled (PMCNTENCLR_EL0). It shall be better to disable the cycle count > > register too at module exit. > > OK +1 I've got a private kernel driver enabling and disabling (hopefully) properly this for ARMv7. If we'd like to merge it, I'd like to have a single module or at least single module with 2 implementations... I can post it if it would be helpful. Regards Jan > > > > > > + * > > > + */ > > > +static inline uint64_t > > > +rte_rdtsc(void) > > > +{ > > > + uint64_t tsc; > > > + > > > + asm volatile("mrs %0, pmccntr_el0" : "=r"(tsc)); > > > + return tsc; > > > +} > > > +#endif > > > > > > static inline uint64_t > > > rte_rdtsc_precise(void) > > > -- > > > 2.5.5 > > > > Do you also plan to support performance monitor event counters? > > No. This patch was inspired by armv7 PMU scheme and its part of DPDK. > The sole reason to add this support to catch any performance regression > through app/test application.Other than that, I think cntvct_el0 based > existing scheme is good enough for all the use cases. > > > > > Regards, > > Nipun > > -- Jan Viktorin E-mail: Viktorin at RehiveTech.com System Architect Web:www.RehiveTech.com RehiveTech Brno, Czech Republic

[dpdk-dev] DPDK support for on system bus connected embedded MAC

2016-08-06 Thread Jan Viktorin
me support which will help a lot for my > > development . > > Please check the work of Jan Viktorin: > http://dpdk.org/dev/patchwork/project/dpdk/list/?submitter=292&state=* > Some review would be welcome :) Thanks The patchset has very low number of reviews. If you h

[dpdk-dev] test: failed to clone dpdk source in windows

2016-08-06 Thread Jan Viktorin
> > Not sure to understand the use case. > > This is a fake sysfs, we cannot change the names. > > In other words, Windows is not supported, neither for runtime > nor for development. > For information, which filesystem do not support ':'? > > If someo

[dpdk-dev] [PATCH v7 00/17] Prepare for rte_device / rte_driver

2016-08-01 Thread Jan Viktorin
Thank you. Hope to find some time this week to do my part. Jan On Mon, 1 Aug 2016 16:15:15 +0530 Shreyansh Jain wrote: > * Original patch series is from David Marchand [1], [2]. > * Link with patch series [4] from Jan Viktorin for a more complete picture > of proposed EAL device

[dpdk-dev] [PATCH v6 05/17] eal: introduce init macros

2016-07-30 Thread Jan Viktorin
On Thu, 28 Jul 2016 15:06:10 +0530 Shreyansh Jain wrote: > Hi Jan, > > On Friday 15 July 2016 04:18 PM, Shreyansh jain wrote: > > On Thursday 14 July 2016 09:27 PM, Jan Viktorin wrote: [...] > >>>>> (drv).name = RTE_STR(nm); > >>> &g

[dpdk-dev] doc: announce ivshmem support removal

2016-07-27 Thread Jan Viktorin
K objects (ring/mempool) allocated by EAL > > As nobody seems interested, it is time to remove this code which > makes EAL improvements harder. > > Signed-off-by: Thomas Monjalon > Acked-by: David Marchand > Acked-by: Maxime Coquelin Acked-by: Jan Viktorin

[dpdk-dev] doc: deprecate vhost-cuse

2016-07-27 Thread Jan Viktorin
will be > removed in the next release (v16.11). > > Signed-off-by: Yuanhan Liu > Acked-by: Ciara Loftus > Acked-by: Thomas Monjalon > Acked-by: Rich Lane Acked-by: Jan Viktorin

[dpdk-dev] doc: announce renaming of ethdev library

2016-07-27 Thread Jan Viktorin
library filename as every other libraries. > > Signed-off-by: Thomas Monjalon > Acked-by: Jan Viktorin

[dpdk-dev] [PATCH v1 00/15] rte_driver/device infrastructure

2016-07-15 Thread Jan Viktorin
On Fri, 15 Jul 2016 15:19:14 +0200 Thomas Monjalon wrote: > 2016-07-08 21:09, Jan Viktorin: > > Hello, > > > > based on the discussions with Shreyansh, I propose a patchset with > > the important EAL changes. It is incomplete and I suppose to extend > >

[dpdk-dev] [PATCH v6 12/17] pci: add a helper for device name

2016-07-15 Thread Jan Viktorin
On Fri, 15 Jul 2016 11:56:38 +0200 Thomas Monjalon wrote: > 2016-07-15 15:09, Shreyansh jain: > > On Thursday 14 July 2016 10:25 PM, Jan Viktorin wrote: > > > What is meant by "resources" here? > > > > This has historic context (from earlier version

[dpdk-dev] [PATCH v6 16/17] ethdev: convert to eal hotplug

2016-07-15 Thread Jan Viktorin
On Fri, 15 Jul 2016 16:06:25 +0530 Shreyansh jain wrote: > On Thursday 14 July 2016 10:21 PM, Jan Viktorin wrote: > > On Tue, 12 Jul 2016 11:31:21 +0530 > > Shreyansh Jain wrote: > > > >> Remove bus logic from ethdev hotplug by using eal for this. >

[dpdk-dev] [PATCH v6 12/17] pci: add a helper for device name

2016-07-15 Thread Jan Viktorin
On Fri, 15 Jul 2016 15:09:58 +0530 Shreyansh jain wrote: > On Thursday 14 July 2016 10:25 PM, Jan Viktorin wrote: > > On Tue, 12 Jul 2016 11:31:17 +0530 > > Shreyansh Jain wrote: > > > >> eal is a better place than crypto / ethdev for naming resources.

[dpdk-dev] spinlock: Move constructor function out of header file

2016-07-14 Thread Jan Viktorin
Hello Damjan, thank you for the patch. It makes sense to me. Next time, please CC the appropriate maintainers. (See the MAINTAINERS file in the root of the DPDK source tree.) In the subject after "spinlock:" you should start with a lower case letter, so "move constructor..." On Thu, 14 Jul 2016

[dpdk-dev] [PATCH v6 13/17] pci: add a helper to update a device

2016-07-14 Thread Jan Viktorin
/librte_eal/linuxapp/eal/eal_pci.c > @@ -417,6 +417,19 @@ pci_scan_one(const char *dirname, uint16_t domain, > uint8_t bus, > return 0; > } > > +int > +pci_update_device(const struct rte_pci_addr *addr) > +{ > + char filename[PATH_MAX]; > + > +

[dpdk-dev] [PATCH v6 12/17] pci: add a helper for device name

2016-07-14 Thread Jan Viktorin
On Tue, 12 Jul 2016 11:31:17 +0530 Shreyansh Jain wrote: > eal is a better place than crypto / ethdev for naming resources. s/for naming/to name/ What is meant by "resources" here? > Add a helper in eal and make use of it in crypto / ethdev. > > Signed-off-by: David Marchand > Signed-off-by:

[dpdk-dev] [PATCH v6 16/17] ethdev: convert to eal hotplug

2016-07-14 Thread Jan Viktorin
On Tue, 12 Jul 2016 11:31:21 +0530 Shreyansh Jain wrote: > Remove bus logic from ethdev hotplug by using eal for this. > > Current api is preserved: > - the last port that has been created is tracked to return it to the > application when attaching, > - the internal device name is reused when

[dpdk-dev] [PATCH v6 15/17] eal: add hotplug operations for pci and vdev

2016-07-14 Thread Jan Viktorin
On Tue, 12 Jul 2016 11:31:20 +0530 Shreyansh Jain wrote: > Hotplug which deals with resources should come from the layer that already > handles them, i.e. EAL. > > For both attach and detach operations, 'name' is used to select the bus > that will handle the request. > > Signed-off-by: David Ma

[dpdk-dev] [PATCH v6 17/17] ethdev: get rid of device type

2016-07-14 Thread Jan Viktorin
On Tue, 12 Jul 2016 11:31:22 +0530 Shreyansh Jain wrote: > Now that hotplug has been moved to eal, there is no reason to keep the device > type in this layer. > > Signed-off-by: David Marchand > Signed-off-by: Shreyansh Jain > --- > app/test/virtual_pmd.c| 2 +- > drivers

[dpdk-dev] [PATCH v6 05/17] eal: introduce init macros

2016-07-14 Thread Jan Viktorin
On Thu, 14 Jul 2016 10:57:55 +0530 Shreyansh jain wrote: > Hi Jan, > > On Wednesday 13 July 2016 11:04 PM, Jan Viktorin wrote: > > On Wed, 13 Jul 2016 11:20:43 +0200 > > Jan Viktorin wrote: > > > >> Hello Shreyansh, > >> > >> On Tue,

[dpdk-dev] [PATCH] virtio: fix missing curly braces

2016-07-13 Thread Jan Viktorin
On Wed, 13 Jul 2016 11:27:18 +0200 Maxime Coquelin wrote: > Hi Jan, > > On 07/13/2016 11:24 AM, Jan Viktorin wrote: > > GCC 6 is complaining and seems to be correct here. > > > > virtio_user_ethdev.c:345:2: error: > > this ?if? clause does not guard..

[dpdk-dev] [PATCH] virtio: fix missing curly braces

2016-07-13 Thread Jan Viktorin
On Wed, 13 Jul 2016 11:27:18 +0200 Maxime Coquelin wrote: > Hi Jan, > > On 07/13/2016 11:24 AM, Jan Viktorin wrote: > > GCC 6 is complaining and seems to be correct here. > > > > virtio_user_ethdev.c:345:2: error: > > this ?if? clause does not guard..

[dpdk-dev] [PATCH v6 05/17] eal: introduce init macros

2016-07-13 Thread Jan Viktorin
On Wed, 13 Jul 2016 11:20:43 +0200 Jan Viktorin wrote: > Hello Shreyansh, > > On Tue, 12 Jul 2016 11:31:10 +0530 > Shreyansh Jain wrote: > > > Introduce a RTE_INIT macro used to mark an init function as a constructor. > > Current eal macros have been converted

[dpdk-dev] [PATCH] virtio: fix missing curly braces

2016-07-13 Thread Jan Viktorin
latter is misleadingly indented as if it is guarded by the ?if? if (ret < 0) { Fixes: 404bd6bfe360 ("net/virtio-user: fix return value not checked") Signed-off-by: Jan Viktorin --- drivers/net/virtio/virtio_user_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 delet

[dpdk-dev] [PATCH v6 05/17] eal: introduce init macros

2016-07-13 Thread Jan Viktorin
i drivers. > > Suggested-by: Jan Viktorin > Signed-off-by: David Marchand > Signed-off-by: Shreyansh Jain > --- [...] > +#define RTE_INIT(func) \ > +static void __attribute__((constructor, used)) func(void) > + > #ifdef __cplusplus > } > #endif > diff --git a/lib

[dpdk-dev] [PATCH v1 28/28] ether: support SoC device/driver

2016-07-12 Thread Jan Viktorin
On Tue, 12 Jul 2016 14:15:17 +0530 Shreyansh jain wrote: > Hi Jan, > > On Monday 04 July 2016 08:06 PM, Jan Viktorin wrote: > > On Mon, 4 Jul 2016 19:57:18 +0530 > > Shreyansh jain wrote: > > > > [...] > > > >>>>> @@ -1431,

  1   2   3   4   5   6   7   >