Hi, Slava
Thanks for your detailed explanation！You are right，I didn't look
carefully!
With best regards,
Jiawei
On 2021/3/25 7:55 下午, Slava Ovsiienko wrote:
Hi, Jiawei
-Original Message-
From: Jiawei Zhu <17826875...@163.com>
Sent: Wednesday, March 24, 2021 18:2
, Slava Ovsiienko wrote:
Hi, Jiawei
-Original Message-
From: Jiawei Zhu <17826875...@163.com>
Sent: Monday, March 22, 2021 17:46
To: dev@dpdk.org
Cc: zhujiawe...@huawei.com; Matan Azrad ; Shahaf
Shuler ; Slava Ovsiienko
Subject: [PATCH] net/mlx5: add Rx checksum offload flag return bad
From: Jiawei Zhu
When open the rx checksum offload and receive the wrong checksum,
add the ol_flags return bad. And it's not best to use multiplication
and division here.
Signed-off-by: Jiawei Zhu
---
drivers/net/mlx5/mlx5_rxtx.c | 17 ++---
drivers/net/mlx5/mlx5_utils.h
From: Jiawei Zhu
When open the rx checksum offload and receive the wrong checksum,
add the ol_flags return bad. And it's not best to use multiplication
and division here.
Signed-off-by: Jiawei Zhu
---
drivers/net/mlx5/mlx5_rxtx.c | 17 ++---
drivers/net/mlx5/mlx5_utils.h
ssage-
From: Jiawei Zhu <17826875...@163.com>
Sent: Monday, March 1, 2021 19:02
To: Slava Ovsiienko ; dev@dpdk.org
Cc: zhujiawe...@huawei.com; Matan Azrad ; Shahaf
Shuler ; sta...@dpdk.org
Subject: Re: [PATCH] net/mlx5: fix wrong segmented packet in Rx
Hi, Slava
Thank you for your agreement. Her
packet.
Hence, we should skip these mbufs in the stride and
we should advance the consumer index on loop exit.
Fixes: 15a756b63734 ("net/mlx5: fix possible NULL dereference in Rx path")
Cc: sta...@dpdk.org
Signed-off-by: Jiawei Zhu <17826875...@163.com>
---
v3:
* Reword the
that we have updated elts
array
with new allocated mbufs and are not able to retry packet building anymore.
Very good catch, thank you! Could you, please, add this extra explanation
to the commit message and send the v2 ?
With best regards,
Slava
-Original Message-
From: Jiawei Zhu
consumer index.
Fixes: 15a756b63734 ("net/mlx5: fix possible NULL dereference in Rx path")
Cc: sta...@dpdk.org
Signed-off-by: Jiawei Zhu <17826875...@163.com>
---
v2:
* Added extra explanation in commit message.
---
drivers/net/mlx5/mlx5_rxtx.c | 3 +++
1 file changed, 3 insertions(
n 0;
/* Update the consumer index. */
rxq->rq_ci = rq_ci >> sges_n;
hence, rq_ci is always shifted by sges_n, all increments happened
during failed packet processing are just discarded, it seems no fix is needed.
Did I miss something?
With best regards,
Slava
-----Origina
t;net/mlx5: fix possible NULL dereference in Rx path")
Cc: sta...@dpdk.org
Signed-off-by: Jiawei Zhu <17826875...@163.com>
---
drivers/net/mlx5/mlx5_rxtx.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c
index 2e4b87c..e3ce
From: Jiawei Zhu
When i < VIRTIO_MAX_VIRTQUEUES and j == i,
dev->callfds[i] and dev->kickfds[i] are default 0.
So it will close(0), close the standard input (stdin).
And when the code fails in kickfd creation,
it will leaves one callfd not closed.
Fixes: e6e7ad8b3024 ("net/vir
From: Jiawei Zhu
When i < VIRTIO_MAX_VIRTQUEUES and j == i,
dev->callfds[i] and dev->kickfds[i] are default 0.
So it will close(0), close the standard input (stdin).
And when the code fails in kickfd creation,
it will leaves one callfd not closed.
Fixes: e6e7ad8b3024 ("net/vir
From: Jiawei Zhu
When i < VIRTIO_MAX_VIRTQUEUES and j == i,
dev->callfds[i] and dev->kickfds[i] are default 0.
So it will close(0), close the standard input (stdin).
And when the code fails in kickfd creation,
it will leaves one callfd not closed.
Fixes: e6e7ad8b3024 ("net/vir
From: Jiawei Zhu
When i < VIRTIO_MAX_VIRTQUEUES and j == i,
dev->callfds[i] and dev->kickfds[i] are default 0.
So it will close(0), close the standard input (stdin).
And when the code fails in kickfd creation,
it will leaves one callfd not closed.
Fixes: e6e7ad8b3024 ("net/vir
From: Jiawei Zhu
When i < VIRTIO_MAX_VIRTQUEUES and j == i,
dev->callfds[i] and dev->kickfds[i] are default 0.
So it will close(0), close the standard input (stdin).
And when the code fails in kickfd creationg,
it will leaves one callfd not closed.
Fixes: e6e7ad8b3024 ("net/vir
From: Jiawei Zhu
When i < VIRTIO_MAX_VIRTQUEUES and j == i,
dev->callfds[i] and dev->kickfds[i] are default 0.
So it will close(0), close the standard input (stdin).
Fixes: e6e7ad8b3024 ("net/virtio-user: move eventfd open/close into
init/uninit")
Cc: sta...@dpdk.org
Signed
From: Jiawei Zhu
When i < VIRTIO_MAX_VIRTQUEUES and j == i,
dev->callfds[i] and dev->kickfds[i] are default 0.
So it will close(0), close the standard input (stdin).
Fixes: e6e7ad8b3024 ("net/virtio-user: move eventfd open/close into
init/uninit")
Cc: sta...@dpdk.org
Signed
17 matches
Mail list logo
