Reviewed-by: John Daley
Thanks,
John
From: Weiguo Li
Date: Wednesday, November 1, 2023 at 12:28 AM
To: John Daley (johndale)
Cc: dev@dpdk.org , sta...@dpdk.org , Weiguo Li
Subject: [PATCH] net/enic: avoid extra unlock when setting MTU in enic
The 'set_mtu_done' goto statemen
Acked-by: John Daley
From: Thomas Monjalon
Date: Thursday, October 19, 2023 at 8:41 AM
To: dev@dpdk.org
Cc: David Marchand , chen...@nvidia.com
, Jerin Jacob , Michal Krawczyk
, Shai Brandes , Evgeny Schemeilin
, Igor Chauskin , Ron Beider
, John Daley (johndale) , Hyong Youb
Kim
o: Jie Hai , dev@dpdk.org , John Daley
(johndale) , Hyong Youb Kim (hyonkim)
Cc: lihuis...@huawei.com , fengcheng...@huawei.com
, liudongdo...@huawei.com
Subject: Re: [PATCH v5 14/40] net/enic: check RSS hash algorithms
On 10/11/2023 10:27 AM, Jie Hai wrote:
> A new field 'algorithm
Reviewed-by: John Daley johnd...@cisco.com<mailto:johnd...@cisco.com>
From: Chengwen Feng
Date: Monday, March 20, 2023 at 2:28 AM
To: tho...@monjalon.net , ferruh.yi...@amd.com
, John Daley (johndale) , Hyong Youb
Kim (hyonkim)
Cc: dev@dpdk.org
Subject: [PATCH v2 13/44] net/eni
Thank you, I will take a look and get back to you.
-john
From: Kevin Traynor
Date: Wednesday, March 15, 2023 at 10:47 AM
To: John Daley (johndale) , Hyong Youb Kim (hyonkim)
Cc: Luca Boccassi , David Marchand
, dev@dpdk.org
Subject: Fwd: [Bug 1185] enic: no longer accepting 2048 descriptor
Acked-by: John Daley
From: Stephen Hemminger
Date: Friday, January 13, 2023 at 1:52 PM
To: dev@dpdk.org
Cc: Stephen Hemminger , John Daley (johndale)
, Hyong Youb Kim (hyonkim)
Subject: [PATCH 6/7] enic: replace zero length array with flex array
Zero length arrays are GNU extension. Replace
Reviewed-by: John Daley
Thanks,
John
-Original Message-
From: Weiguo Li
Sent: Tuesday, January 25, 2022 4:01 AM
To: John Daley (johndale)
Cc: dev@dpdk.org
Subject: [PATCH] net/enic: adjust memory check and use in proper order
Fixes: bb66d562aefc ("net/enic: share flow actions
You are right, just need to cast #define parameters, then can use the RTE_MIN
and MAX.
Will do a patch.
Thanks,
john
> -Original Message-
> From: Thomas Monjalon
> Sent: Sunday, January 19, 2020 12:24 PM
> To: John Daley (johndale) ; Hyong Youb Kim
> (hyonkim)
> -Original Message-
> From: Stephen Hemminger
> Sent: Friday, July 26, 2019 1:51 PM
> To: Hyong Youb Kim (hyonkim)
> Cc: John Daley (johndale) ; Ferruh Yigit
> ; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/enic: retain previous message logging
>
> O
> -Original Message-
> From: Ferruh Yigit
> Sent: Friday, July 26, 2019 3:01 AM
> To: John Daley (johndale)
> Cc: dev@dpdk.org; Hyong Youb Kim (hyonkim)
> Subject: Re: [PATCH] net/enic: retain previous message logging
>
> On 7/26/2019 9:17 AM, Joh
fd.io.
-john
> -Original Message-
> From: John Daley (johndale)
> Sent: Thursday, July 25, 2019 1:26 PM
> To: Ferruh Yigit
> Cc: dev@dpdk.org; Hyong Youb Kim (hyonkim)
> Subject: RE: [PATCH] net/enic: retain previous message logging
>
> Ok, lets NAK this patch.
Ok, lets NAK this patch. See comment inline.
Thanks,
John
> -Original Message-
> From: Ferruh Yigit
> Sent: Thursday, July 25, 2019 3:07 AM
> To: John Daley (johndale)
> Cc: dev@dpdk.org
> Subject: Re: [PATCH] net/enic: retain previous message logging
>
> On
Due to time zone differences, I'll answer for Hyong (below).
-john
> -Original Message-
> From: Thomas Monjalon
> Sent: Wednesday, March 13, 2019 1:36 PM
> To: Ferruh Yigit ; Hyong Youb Kim (hyonkim)
>
> Cc: Andrew Rybchenko ; Qi Zhang
> ; dev@dpdk.org; John D
Ok, makes sense now, both flow query and flow list work with this patch, yeah.
Tested-by: John Daley
Remember that https://patches.dpdk.org/patch/46221/ still needs to be reverted
out of dpdk-next-net/master otherwise we are still broken. The patch was
squished into e5b652ea34.
-johnd
>
Hi Kevin,
Inline.
-john
> -Original Message-
> From: Kevin Traynor
> Sent: Wednesday, July 25, 2018 11:37 AM
> To: John Daley (johndale) ; ferruh.yi...@intel.com
> Cc: dev@dpdk.org; sta...@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2 00/15] enic PMD fixes and performa
Hi,
Inline.
Thanks,
John
> -Original Message-
> From: Thomas Monjalon
> Sent: Friday, March 30, 2018 6:48 AM
> To: dev@dpdk.org
> Cc: Ajit Khaparde ; Jerin Jacob
> ; Shijith Thotton
> ; Santosh Shukla
> ; Rahul Lakkireddy
> ; John Daley (johndale) ;
> W
Hi Anatoly,
Looks good, see inline for details.
Acked-by: John Daley
Thanks,
John
> -Original Message-
> From: Anatoly Burakov [mailto:anatoly.bura...@intel.com]
> Sent: Saturday, March 03, 2018 5:46 AM
> To: dev@dpdk.org
> Cc: John Daley (johndale) ; Hyong Yo
Hi Declan and Shahaf,
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Doherty, Declan
> Sent: Tuesday, January 09, 2018 9:31 AM
> To: Shahaf Shuler ; dev@dpdk.org
> Subject: Re: [dpdk-dev] [RFC] tunnel endpoint hw acceleration enablement
>
> On 24/12/2017 5:30
Hi,
One comment on DECAP action and a "feature request". I'll also reply to the
top of thread discussion separately. Thanks for the RFC Declan!
Feature request associated with ENCAP action:
VPP (and probably other apps) would like the ability to simply specify an
independent tunnel ID as part
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Aaron Conole
> Sent: Tuesday, September 26, 2017 11:53 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [RFC 4/4] enic: remove anscillary assignment
>
> The assignment at initialization is overwritten immediately. Dr
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Aaron Conole
> Sent: Tuesday, September 26, 2017 11:53 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [RFC 3/4] enic: remove unused code
>
> The functions here aren't called anywhere in code, at least according to b
Aaron,
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Aaron Conole
> Sent: Tuesday, September 26, 2017 11:53 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [RFC 2/4] enic: fix assignment
>
> As it stands, the existing assingment to mbuf has no effect outside of t
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Aaron Conole
> Sent: Tuesday, September 26, 2017 11:53 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [RFC 1/4] enic: update format string to match arg types
>
> The argument `index` (and unique_id) is unsigned, but
Hi Ferruh,
-johnd
> -Original Message-
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com]
> Sent: Tuesday, September 19, 2017 5:59 AM
> To: John Daley (johndale) ; Thomas Monjalon
>
> Cc: dev@dpdk.org; Sergio Gonzalez Monroy
> ; Adrien Mazarguil
> ; Neli
> -Original Message-
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> Sent: Monday, September 18, 2017 3:25 PM
> To: John Daley (johndale)
> Cc: Ferruh Yigit ; dev@dpdk.org; Sergio Gonzalez
> Monroy
> Subject: Re: [PATCH] net/enic: fix multi-process operation
> -Original Message-
> From: Aaron Conole [mailto:acon...@redhat.com]
> Sent: Wednesday, August 02, 2017 11:02 AM
> To: dev@dpdk.org
> Cc: sta...@dpdk.org; John Daley (johndale) ; Bruce
> Richardson
> Subject: [PATCH] enic: check for nb_free > 0
>
> Occas
Hi Adrien,
I understand why applications may want to operate in this sort of isolated
mode. Just to better understand the value of adding this feature can you
contrast it to simply having the application add a very low priority "catch
all" flow rule with DROP action?
Thanks,
Johnd
> -Orig
Hi Adrien,
> -Original Message-
> From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com]
> Sent: Friday, March 24, 2017 2:47 AM
> To: John Daley (johndale)
> Cc: dev@dpdk.org
> Subject: Re: [PATCH 0/1] proposed minor change in rte_flow_validate
> semantics
>
> -Original Message-
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com]
> Sent: Thursday, February 09, 2017 4:15 AM
> To: John Daley (johndale)
> Cc: dev@dpdk.org
> Subject: Re: [PATCH v2] enic flow director fixes
>
> On 2/9/2017 12:40 AM, John Daley wrote:
> -Original Message-
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com]
> Sent: Thursday, February 09, 2017 2:16 AM
> To: John Daley (johndale)
> Cc: dev@dpdk.org; sta...@dpdk.org
> Subject: Re: [PATCH v2] net/enic: fix hardcoding of some flow director masks
>
&
> -Original Message-
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com]
> Sent: Friday, January 27, 2017 3:07 AM
> To: John Daley (johndale)
> Cc: dev@dpdk.org
> Subject: Re: [PATCH] net/enic: fix MAC address add and remove
>
> On 1/26/2017 8:12 PM, J
Hi,
-john
> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Monday, November 28, 2016 3:03 AM
> To: dev at dpdk.org; Rahul Lakkireddy ;
> Stephen Hurd ; Jan Medala
> ; Jakub Palider ; John Daley
> (johndale) ; Adrien Mazarguil
Hi,
Please see inline.
Thanks,
john
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas F Herbert
> Sent: Tuesday, October 18, 2016 1:35 PM
> To: dev at dpdk.org
> Cc: Keith Burns ; Edward Warnicke
> ; opnfv-tech-discuss at lists.opnfv.org
> Subject: [dpdk
> -Original Message-
> From: Ferruh Yigit [mailto:ferruh.yigit at intel.com]
> Sent: Tuesday, October 11, 2016 2:22 AM
> To: John Daley (johndale) ;
> bruce.richardson at intel.com
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 4/4] net/enic: extend fdir supp
Hi, this is an old thread, but I'll reply to this instead of the RFC v2 since
there is more context here.
Thanks for pushing the new api forward Adrien.
-john daley
> > >>> - Match range of Physical Functions (PFs) on the NIC in a single rule
> > >>> via masks. For ex: match all traffic coming
>
> For 16.11, the mbuf structure will be modified implying ABI breakage.
> Some discussions already took place here:
> http://www.dpdk.org/dev/patchwork/patch/12878/
>
> Signed-off-by: Olivier Matz
> ---
Acked-by: John Daley
Also, definitely +1 on trying to get m->next into the first cache l
> -Original Message-
> From: Olivier Matz [mailto:olivier.matz at 6wind.com]
> Sent: Monday, July 11, 2016 3:04 AM
> To: John Daley (johndale) ; dev at dpdk.org
> Cc: bruce.richardson at intel.com
> Subject: Re: [dpdk-dev] [PATCH] net/enic: decrement Tx mbuf refere
> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Wednesday, July 06, 2016 8:25 AM
> To: John Daley (johndale) ; Nelson Escobar
> (neescoba)
> Cc: dev at dpdk.org
> Subject: [PATCH] net/enic: remove useless assert macro
>
Hi Bruce,
> > * What was the MTU set to by default before this patch is applied? Was
> > it just set to 1518 or something else?
> > * What happens, if anything, if buffers bigger than the MTU size are sent
> down?
> This is obviously referring to buffers bigger than MTU on TX. There is also
> the
> -Original Message-
> From: Kerlin, MarcinX [mailto:marcinx.kerlin at intel.com]
> Sent: Monday, June 20, 2016 4:12 AM
> To: John Daley (johndale) ; Nelson Escobar
> (neescoba)
> Cc: 'dev at dpdk.org'
> Subject: RE: unchecked return value in enic
Hi Ruth,
I'm the enic pmd maintainer. To cut down on chatter I can work with you off
list and then we can post the result to dev at .
I'd like to see the packet formed in the app and what's on the wire egress,
that you are sending on a configured VLAN, etc.
I'll contact you directly.
-john
> ---
> -Original Message-
> From: Bruce Richardson [mailto:bruce.richardson at intel.com]
> Sent: Friday, June 10, 2016 2:18 PM
> To: John Daley (johndale)
> Cc: dev at dpdk.org; bruce.richarsdon at intel.com
> Subject: Re: [dpdk-dev] [PATCH v3 07/13] enic: use Tx c
John,
As just discussed, what you suggest was considered but there are other apps
depending a different behavior of the flag, so we thought the best thing to do
is deprecate it. That is part of what Olivier's patch discussed in
http://www.dpdk.org/ml/archives/dev/2016-May/038786.html does. Addi
Hi Olivier,
> ...
> This is a draft patch that implements what was previously discussed, except
> the packet_type, which does not exist for vlan today (and I think it is not
> mandatory for now, let's do it in another patch).
>
> After doing this patch, it appeared that ixgbe was the only driver
Hi,
> -Original Message-
> From: Olivier Matz [mailto:olivier.matz at 6wind.com]
> Sent: Tuesday, May 10, 2016 1:40 AM
> To: dev at dpdk.org
> Cc: konstantin.ananyev at intel.com; John Daley (johndale)
> ; helin.zhang at intel.com; arnon at qwilt.com;
> rolette at
Hi,
> -Original Message-
> From: Olivier Matz [mailto:olivier.matz at 6wind.com]
> Sent: Friday, April 29, 2016 5:25 AM
> To: dev at dpdk.org; Zhang, Helin
> Cc: Ananyev, Konstantin ; John Daley
> (johndale)
> Subject: removing mbuf error flags
>
> Hi,
>
; To: Ananyev, Konstantin ; John Daley
> (johndale) ; dev at dpdk.org
> Subject: Re: [dpdk-dev] PKT_RX_VLAN_PKT when VLAN stripping is disabled
>
> Hi,
>
> On 04/25/2016 02:02 PM, Ananyev, Konstantin wrote:
> > Hi John,
> > From rte_mbuf.h:
> > #define PKT_
Hi,
When VLAN stripping is disabled, X710 and 82599ES act differently for me in
this case when receiving VLAN tagged packets. On 82599ES the flag is set but on
X710 the flag not set.
Do I maybe have old X710 firmware? Or is it not set for X710 on purpose in this
case and instead the flag is us
I found a data corruption in further testing, so please reject the patch and
I'll send a V2.
Thanks,
John
> -Original Message-
> From: John Daley (johndale)
> Sent: Monday, February 15, 2016 9:37 PM
> To: dev at dpdk.org
> Cc: John Daley (johndale)
> Subje
49 matches
Mail list logo
