[dpdk-dev] [PATCH] crypto: remove unused digest-appended feature

2016-11-18 Thread John Griffin
; > Signed-off-by: Fiona Trahe > --- > drivers/crypto/qat/qat_adf/qat_algs_build_desc.c | 2 ++ > drivers/crypto/qat/qat_crypto.c | 18 +- > lib/librte_cryptodev/rte_crypto_sym.h| 10 +- > 3 files changed, 4 insertions(+), 26 deletions(-) > Acked-by: John Griffin

[dpdk-dev] [PATCH v2] doc: add known issue on QAT PMD into release notes

2016-11-10 Thread John Griffin
On 10/11/16 17:27, Fiona Trahe wrote: > Issue is with the digest appended feature on QAT PMD. > A workaround is also documented. > > Signed-off-by: Fiona Trahe > Acked-by: John McNamara > --- > v2 > - fixed trailing whitespace checkpatch errors > Acked-by: John Griffin

[dpdk-dev] [PATCH] crypto/qat: fix memzone creation to use a fixed size string

2016-09-14 Thread John Griffin
Hi Liu, Comments embedded. Rgds, John. On 05/09/16 04:23, Yuanhan Liu wrote: > On Thu, Sep 01, 2016 at 11:21:38AM +0100, John Griffin wrote: >> Remove the dependency on dev->driver->pci_drv.name when >> creating the memzone for the qat hardware queues. >> The pci_

[dpdk-dev] [PATCH] crypto/qat: fix memzone creation to use a fixed size string

2016-09-01 Thread John Griffin
Remove the dependency on dev->driver->pci_drv.name when creating the memzone for the qat hardware queues. The pci_drv.name may grow too large for RTE_MEMZONE_NAMESIZE. Fixes: 1703e94ac5ce ("qat: add driver for QuickAssist devices") Signed-off-by: John Griffin --- drivers/cry

[dpdk-dev] [PATCH] crypto/qat: optimisation of request copy

2016-08-04 Thread John Griffin
ile changed, 1 insertion(+), 1 deletion(-) > Acked-by: John Griffin

[dpdk-dev] [PATCH v1] crypto/qat: make the session struct variable in size

2016-08-04 Thread John Griffin
by PCIe. Signed-off-by: John Griffin --- v1: * Fixed a compile issue with icc. drivers/crypto/qat/qat_adf/qat_algs.h| 5 +- drivers/crypto/qat/qat_adf/qat_algs_build_desc.c | 463 +-- drivers/crypto/qat/qat_crypto.c | 15 +- 3 files changed, 184

[dpdk-dev] [PATCH] qat: change the session structure to be variable sized

2016-08-04 Thread John Griffin
On 02/08/16 09:30, John Griffin wrote: > This patch changes the qat session data structure sent to qat from a > fixed size to a variable size which is dependent on the size of > the chosen algorithm. > This reduces the amount of bytes which are transferred across > PCIe and thus he

[dpdk-dev] [PATCH] qat: change the session structure to be variable sized

2016-08-02 Thread John Griffin
is bound by PCIe. Signed-off-by: John Griffin --- drivers/crypto/qat/qat_adf/qat_algs.h| 5 +- drivers/crypto/qat/qat_adf/qat_algs_build_desc.c | 462 +-- drivers/crypto/qat/qat_crypto.c | 15 +- 3 files changed, 183 insertions(+), 299 deletions

[dpdk-dev] [PATCH] app/test: fix for icc compilation error

2016-06-22 Thread John Griffin
On 22/06/16 17:13, Deepak Kumar Jain wrote: > Icc complains about variable may be used without setting. > > Fixes: 97fe6461c7cbfb ("app/test: add SNOW 3G performance test) > > Signed-off-by: Deepak Kumar Jain Acked-by: John Griffin

[dpdk-dev] [PATCH] qat: addition of optimized content descriptor for AES128-SHA1-HMAC

2016-06-21 Thread John Griffin
Adding an optimized content descriptor for AES128-SHA1-HMAC to improve thoughput performance. Signed-off-by: John Griffin --- drivers/crypto/qat/qat_adf/qat_algs.h| 7 ++ drivers/crypto/qat/qat_adf/qat_algs_build_desc.c | 91 drivers/crypto/qat/qat_crypto.c

[dpdk-dev] [PATCH v2 0/2] Out of place operations for symmetric crypto

2016-03-30 Thread John Griffin
495 > ++- > doc/guides/cryptodevs/qat.rst |1 - > drivers/crypto/qat/qat_crypto.c | 22 +- > 3 files changed, 504 insertions(+), 14 deletions(-) > Acked-by: John Griffin

[dpdk-dev] [PATCH 3/3] qat: fixes premature addition of AES_CMAC in session creation

2016-03-11 Thread John Griffin
On 11/03/16 00:16, Thomas Monjalon wrote: > 2016-03-08 16:22, John Griffin: >> Remove support for AES CMAC support for which was added to >> the code in error. AES CMAC will be added in a subsequent release >> when testing completes. > [...] >> case RTE_CRY

[dpdk-dev] [PATCH v4] aesni_gcm: PMD to support AES_GCM crypto operations

2016-03-10 Thread John Griffin
itecture Processors" > > This PMD supports AES_GCM authenticated encryption and authenticated > decryption using > 128-bit AES keys > > The patch also contains the related unit tests functions for the implemented > functionality > > Signed-off-by: Declan Doherty

[dpdk-dev] [PATCH 3/3] qat: fixes premature addition of AES_CMAC in session creation

2016-03-08 Thread John Griffin
Remove support for AES CMAC support for which was added to the code in error. AES CMAC will be added in a subsequent release when testing completes. Fixes: 1703e94ac5ce ("qat: add driver for QuickAssist devices") Signed-off-by: John Griffin --- drivers/crypto/qat/qat_crypto.c | 2

[dpdk-dev] [PATCH 2/3] app/test: add AES GCM tests for QAT

2016-03-08 Thread John Griffin
Signed-off-by: John Griffin --- app/test/test_cryptodev.c | 34 +- 1 file changed, 33 insertions(+), 1 deletion(-) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index d7e80c4..a5d4208 100644 --- a/app/test/test_cryptodev.c +++ b/app/test

[dpdk-dev] [PATCH 1/3] qat: fix AES GCM decryption

2016-03-08 Thread John Griffin
AES GCM on the cryptodev API was giving invalid results in some cases, due to an incorrect IV setting. Added AES GCM in the QAT supported algorithms, as encryption/decryption is fully functional. Fixes: 1703e94ac5ce ("qat: add driver for QuickAssist devices") Signed-off-by: Jo

[dpdk-dev] [PATCH 0/3] AES GCM, AES CMAC fixes and addition of GCM tests for QAT.

2016-03-08 Thread John Griffin
release when testing completes. AES CMAC was not advertised in the qat documentation. This patchset depends on patches: - aesni_gcm: PMD to support AES_GCM crypto operations (http://dpdk.org/dev/patchwork/patch/11201/) John Griffin (3): qat: fix AES GCM decryption app/test: add AES GCM

[dpdk-dev] [PATCH] Adding maintainers for Intel QAT PMD

2016-02-29 Thread John Griffin
On 05/02/16 16:36, Fiona Trahe wrote: > Signed-off-by: Fiona Trahe Acked-by: John Griffin

[dpdk-dev] [PATCH v2] qat:fix build on 32-bit systems

2016-02-18 Thread John Griffin
: add driver for QuickAssist devices") Signed-off-by: John Griffin Acked-by: Pablo de Lara --- v1->v2: - Corrected subject text and included build failure. drivers/crypto/qat/qat_crypto.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/qat/q

[dpdk-dev] [PATCH] qat pmd:Fixing build issue on 32-bit systems

2016-02-17 Thread John Griffin
Hi Pablo, Sure - will resubmit a v2 with those modifications. Thanks, John. On 16/02/16 15:52, De Lara Guarch, Pablo wrote: > Hi John, > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of John Griffin >> Sent: Tuesday, February 16,

[dpdk-dev] [PATCH] qat pmd:Fixing build issue on 32-bit systems

2016-02-16 Thread John Griffin
Fixing build issue on 32-bit systems. Fixes: 1703e94ac5ce ("qat: add driver for QuickAssist devices") Signed-off-by: John Griffin --- drivers/crypto/qat/qat_crypto.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/qat/qat_crypto.c b/drivers/

[dpdk-dev] [PATCH] Correcting upstream kernel version in driver

2016-02-10 Thread John Griffin
Fixing the version of the kernel required in the QAT documentation. Signed-off-by: John Griffin --- doc/guides/cryptodevs/qat.rst | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst index 1901842..23402b4