RE: [PATCH v4 1/2] config: correct cpu instruction set for cross build

2023-12-07 Thread Joyce Kong
> -Original Message- > From: Stephen Hemminger > Sent: Friday, December 8, 2023 6:41 AM > To: Joyce Kong > Cc: tho...@monjalon.net; Ruifeng Wang ; > bruce.richard...@intel.com; dev@dpdk.org; nd ; > sta...@dpdk.org > Subject: Re: [PATCH v4 1/2] config: correct

RE: [PATCH v1] net/memif: fix segfault with Tx burst larger than 255

2023-12-05 Thread Joyce Kong
> -Original Message- > From: Stephen Hemminger > Sent: Wednesday, December 6, 2023 2:34 AM > To: Joyce Kong > Cc: Jakub Grajciar ; Morten Brørup > ; Ruifeng Wang ; > dev@dpdk.org; nd ; sta...@dpdk.org; Liangxing Wang > > Subject: Re: [PATCH v1] net/memif:

[PATCH v1] net/memif: fix segfault with Tx burst larger than 255

2023-12-04 Thread Joyce Kong
eported-by: Liangxing Wang Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang --- drivers/net/memif/rte_eth_memif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/memif/rte_eth_memif.c b/drivers/net/memif/rte_eth_memif.c index 7cc8c0da91..6f45a00172 100644 --- a/d

[PATCH v4 2/2] config/arm: use common cpu arch for cross files

2023-12-04 Thread Joyce Kong
ed-by: Honnappa Nagarahalli Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang --- config/arm/arm32_armv8_linux_gcc | 2 +- config/arm/arm64_altra_linux_gcc | 2 +- config/arm/arm64_ampereone_linux_gcc | 2 +- config/arm/arm64_armada_linux_gcc | 2 +- confi

[PATCH v4 1/2] config: correct cpu instruction set for cross build

2023-12-04 Thread Joyce Kong
The platform value would be 'native' only when not cross build. Move the operation about modifying cpu_instruction_set while platform equals 'native' to the not cross build branch. Fixes: bf66003b51ec ("build: use platform for generic and native builds") Cc: sta...@

[PATCH v4 0/2] config changes for cross build

2023-12-04 Thread Joyce Kong
files. v2: * Add the missing cross files which are not changed to use the common cpu arch in v1. --- Joyce Kong (2): config: correct cpu instruction set for cross build config/arm: use common cpu arch for cross files config/arm/arm32_armv8_linux_gcc | 2 +- config/arm

Recall: [PATCH v3] config/arm: correct cpu arch for cross build

2023-11-21 Thread Joyce Kong
Joyce Kong would like to recall the message, "[PATCH v3] config/arm: correct cpu arch for cross build".

RE: [PATCH v3] config/arm: correct cpu arch for cross build

2023-11-21 Thread Joyce Kong
> -Original Message- > From: Thomas Monjalon > Sent: Tuesday, November 21, 2023 12:55 AM > To: Joyce Kong > Cc: Ruifeng Wang ; bruce.richard...@intel.com; > dev@dpdk.org; nd > Subject: Re: [PATCH v3] config/arm: correct cpu arch for cross build > > 20/11/2023

[PATCH v3] config/arm: correct cpu arch for cross build

2023-11-20 Thread Joyce Kong
The cn10k cross build file sets cpu to 'armv8.6-a' while it is armv8.5-a arch. Meanwhile, the cpu field in the cross file doesn't take effect as config/arm/meson.build controls machine_args for march. Then change the 'cpu' value in all arm cross files to 'aut

RE: [PATCH v2] config/arm: correct cpu arch for cross build

2023-11-20 Thread Joyce Kong
> -Original Message- > From: Thomas Monjalon > Sent: Sunday, November 12, 2023 8:54 PM > To: Ruifeng Wang ; Joyce Kong > > Cc: bruce.richard...@intel.com; dev@dpdk.org; nd > Subject: Re: [PATCH v2] config/arm: correct cpu arch for cross build > > 0

[PATCH v2] config/arm: correct cpu arch for cross build

2023-11-06 Thread Joyce Kong
The cn10k cross build file sets cpu to 'armv8.6-a' while it is armv8.5-a arch. The cpu field in the cross file doesn't take effect as config/arm/meson.build controls machine_args for march. Then correct the value in arm cross files to 'auto'. Signed-off-by: Joyce Kong

RE: [PATCH v1] config/arm: correct cpu arch for cross build

2023-11-06 Thread Joyce Kong
> -Original Message- > From: Thomas Monjalon > Sent: Monday, November 6, 2023 11:38 PM > To: Ruifeng Wang > Cc: dev@dpdk.org; Bruce Richardson ; nd > ; Paul Szczepanek ; Joyce Kong > > Subject: Re: [PATCH v1] config/arm: correct cpu arch for cross build > >

RE: [PATCH v1] config/arm: correct cpu arch for cross build

2023-11-06 Thread Joyce Kong
> -Original Message- > From: Thomas Monjalon > Sent: Monday, November 6, 2023 10:10 PM > To: Ruifeng Wang ; Joyce Kong > > Cc: dev@dpdk.org; Bruce Richardson ; > dev@dpdk.org; nd ; Paul Szczepanek > > Subject: Re: [PATCH v1] config/arm: correct cpu arch for

RE: [PATCH] bitops: mark new symbols as stable

2023-10-23 Thread Joyce Kong
> -Original Message- > From: David Marchand > Sent: Wednesday, October 18, 2023 5:11 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; techbo...@dpdk.org; Joyce Kong > ; Tyler Retzlaff > Subject: [PATCH] bitops: mark new symbols as stable > > Calling an experim

RE: [PATCH v2 01/14] eal: make bitops a stable API

2023-10-22 Thread Joyce Kong
> -Original Message- > From: Stephen Hemminger > Sent: Saturday, October 21, 2023 5:41 AM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Cristian > Dumitrescu ; Joyce Kong > > Subject: [PATCH v2 01/14] eal: make bitops a stable API > > These were added in 20

RE: [PATCH v1] config/arm: correct cpu arch for cross build

2023-10-17 Thread Joyce Kong
> -Original Message- > From: Thomas Monjalon > Sent: Wednesday, October 18, 2023 3:42 AM > To: Joyce Kong > Cc: Ruifeng Wang ; Bruce Richardson > ; dev@dpdk.org; nd > Subject: Re: [PATCH v1] config/arm: correct cpu arch for cross build > > 22/08/2023 09:47

[PATCH v1] net/memif: fix segfault with large burst size

2023-09-04 Thread Joyce Kong
.@dpdk.org Signed-off-by: Joyce Kong Reviewed-by: Feifei Wang Reviewed-by: Ruifeng Wang --- drivers/net/memif/rte_eth_memif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/memif/rte_eth_memif.c b/drivers/net/memif/rte_eth_memif.c index 6a8ff5b4eb..f595656af5 10

[PATCH v1] config/arm: correct cpu arch for cross build

2023-08-22 Thread Joyce Kong
The cn10k cross build file sets cpu to 'armv8.6-a' while N2 is armv8.5-a arch. The cpu field in the cross file doesn't take effect as config/arm/meson.build controls machine_args for march. Then correct the value in arm cross files to 'auto'. Signed-off-by: Joyce Kong

RE: [PATCH] ixgbe: Allow setting IVAR register for X550EM_a

2023-06-19 Thread Joyce Kong
Hi All, It seems a false positive. I have tested the patch with aarch32 link_bond_autotest on arm server, and the test cases all succeed. Best Regards, Joyce > -Original Message- > From: Zhang, Qi Z > Sent: Monday, June 19, 2023 9:09 AM > To: Vladimir Ratnikov ; Yang, Qiming > ; Wu, We

RE: [PATCH] pdump: fix build issue with GCC 12

2023-03-27 Thread Joyce Kong
> -Original Message- > From: Tyler Retzlaff > Sent: Monday, March 27, 2023 10:35 PM > To: Joyce Kong > Cc: reshma.pat...@intel.com; step...@networkplumber.org; > konstantin.v.anan...@yandex.ru; dev@dpdk.org; nd ; > sta...@dpdk.org; Ruifeng Wang > Subject: Re:

[PATCH] pdump: fix build issue with GCC 12

2023-03-27 Thread Joyce Kong
alias warning as -O3 enables strict alias. This patch fixes it by replacing 'dup_bufs' with '&dup_bufs[0]' as the compiler represents them differently. Fixes: 278f945402c5 ("pdump: add new library for packet capture") Cc: sta...@dpdk.org Signed-off-by: Joy

[PATCH v2] config/arm: support ldapr on neoverse n1

2023-03-21 Thread Joyce Kong
costs associated with LDAR. GCC13.0 has supported LDAPR. For Armv8.3 and higher, LDAPR is default. For Armv8.2 such as neoverse n1, LDAPR is supported with enabling rcpc feature. For Armv8.1 and lower, LDAPR is not supported. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang --- config/arm

RE: [PATCH] config/arm: enable rcpc feature on neoverse n1

2023-03-20 Thread Joyce Kong
> -Original Message- > From: Thomas Monjalon > Sent: Tuesday, March 21, 2023 12:10 AM > To: dev@dpdk.org; Joyce Kong > Cc: Ruifeng Wang ; Bruce Richardson > ; nd > Subject: Re: [PATCH] config/arm: enable rcpc feature on neoverse n1 > > 20/03/2023 04:26,

[PATCH] config/arm: enable rcpc feature on neoverse n1

2023-03-19 Thread Joyce Kong
Enable rcpc meson configuration for Neoverse N1 platform. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang --- config/arm/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config/arm/meson.build b/config/arm/meson.build index 5ff66248de..5213434ca4 100644 --- a

[PATCH v4 2/2] net/memif: add a Tx fast path

2022-09-14 Thread Joyce Kong
memif < mbuf | non-zc gain | 7.32% |-0.85%| zc gain |12.75% |-0.16%| Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang A

[PATCH v4 1/2] net/memif: add a Rx fast path

2022-09-14 Thread Joyce Kong
memif > mbuf | non-zc gain | 17.54%|-0.42%| zc gain | 10.67%| 0.26%| Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang Acked-by: Morten Brørup --- drivers/net/memif/

[PATCH v4 0/2] add a fast path for memif Rx/Tx

2022-09-14 Thread Joyce Kong
.62%|12.42% - v4: 1.Fix incorrect indentation. 2.Fix the mbuf array length to avoid additional overhead if stack-protector strong is enabled. v3: Add bulk allocation to get additional speedup for memif Rx fast path. v2: Rebase v1 and update commit message. Joy

RE: [PATCH v3 1/2] net/memif: add a Rx fast path

2022-09-06 Thread Joyce Kong
Hi Stephen, > -Original Message- > From: Stephen Hemminger > Sent: Thursday, September 1, 2022 12:26 AM > To: Joyce Kong > Cc: jgraj...@cisco.com; huzaifa.rah...@emumba.com; dev@dpdk.org; nd > ; m...@smartsharesystems.com; Ruifeng Wang > > Subject: Re: [PATCH

[PATCH v3 2/2] net/memif: add a Tx fast path

2022-08-21 Thread Joyce Kong
memif < mbuf | non-zc gain | 7.32% |-0.85%| zc gain |12.75% |-0.16%| Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang Acked-by

[PATCH v3 1/2] net/memif: add a Rx fast path

2022-08-21 Thread Joyce Kong
memif > mbuf | non-zc gain | 17.54%|-0.42%| zc gain | 10.67%| 0.26%| Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang Acked-by: Morten Brørup --- drivers/net/memif/

[PATCH v3 0/2] add a fast path for memif Rx/Tx

2022-08-21 Thread Joyce Kong
.62%|12.42% - v3: Add bulk allocation to get additional speedup for memif Rx fast path. v2: Rebase v1 and update commit message. Joyce Kong (2): net/memif: add a Rx fast path net/memif: add a Tx fast path drivers/net/memif/rte_eth_memif.c | 271

RE: [PATCH] memif: memif driver does not crashes when there's different N of TX and RX queues

2022-08-08 Thread Joyce Kong
selected and for TX, C2S rings are selected. > Fixes: 09c7e63a71f9 ("net/memif: introduce memory interface PMD") Cc: sta...@dpdk.org > Signed-off-by: huzaifa.rahman Reviewed-by: Joyce Kong > --- > drivers/net/memif/rte_eth_memif.c | 8 > 1 file changed, 4 inser

[PATCH v2 2/2] net/memif: add a Tx fast path

2022-07-01 Thread Joyce Kong
8.87% |-0.99%| ------ Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang Acked-by: Morten Brørup --- drivers/net/memif/rte_eth_memif.c | 134 -- 1 file changed, 92 insertions(+), 42 deletions(-) diff --git a/drivers/net/memif/rte_eth_memif.c

[PATCH v2 1/2] net/memif: add a Rx fast path

2022-07-01 Thread Joyce Kong
0.18% | 0.48%| ------ Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang Acked-by: Morten Brørup --- drivers/net/memif/rte_eth_memif.c | 123 -- 1 file changed, 83 insertions(+), 40 deletions(-) diff --git a/drivers/net/memif/rte_eth_memif.c

[PATCH v2 0/2] add a fast path for memif Rx/Tx

2022-07-01 Thread Joyce Kong
base v1 and update commit message. Joyce Kong (2): net/memif: add a Rx fast path net/memif: add a Tx fast path drivers/net/memif/rte_eth_memif.c | 257 -- 1 file changed, 175 insertions(+), 82 deletions(-) -- 2.25.1

[PATCH] net/memif: fix overwriting of head segment

2022-05-24 Thread Joyce Kong
The 'dst_off' was reset in multi segment case. This caused memif buffer segment to write to beginning of mbuf, overwriting previous data. Fix it with this patch. Fixes: 09c7e63a71f9 ("net/memif: introduce memory interface PMD") Cc: sta...@dpdk.org Reported-by: Ferruh Yigit

RE: [PATCH v1 1/2] net/memif: add a Rx fast path

2022-05-19 Thread Joyce Kong
> -Original Message- > From: Ferruh Yigit > Sent: Thursday, May 19, 2022 1:06 AM > To: Joyce Kong ; Jakub Grajciar > Cc: Ruifeng Wang ; dev@dpdk.org; nd > > Subject: Re: [PATCH v1 1/2] net/memif: add a Rx fast path > > On 5/17/2022 11:51 AM, Joyce Kong wr

RE: [PATCH v1 1/2] net/memif: add a Rx fast path

2022-05-19 Thread Joyce Kong
> -Original Message- > From: Joyce Kong > Sent: Thursday, May 19, 2022 3:00 PM > To: Ferruh Yigit ; Jakub Grajciar > > Cc: Ruifeng Wang ; dev@dpdk.org; nd > > Subject: RE: [PATCH v1 1/2] net/memif: add a Rx fast path > > Hi Ferruh, > > >

RE: [PATCH v1 1/2] net/memif: add a Rx fast path

2022-05-19 Thread Joyce Kong
Hi Ferruh, > -Original Message- > From: Ferruh Yigit > Sent: Thursday, May 19, 2022 12:53 AM > To: Joyce Kong ; Jakub Grajciar > Cc: Ruifeng Wang ; dev@dpdk.org; nd > > Subject: Re: [PATCH v1 1/2] net/memif: add a Rx fast path > > On 5/17/2022 11:51 AM, Joyc

[PATCH v1 2/2] net/memif: add a Tx fast path

2022-05-17 Thread Joyce Kong
memif < mbuf | non-zc gain |10.10% |-0.29%| zc gain | 8.87% |-0.99%| Signed-off-by: Joyce Kong --- drivers/net/memif/rte_et

[PATCH v1 1/2] net/memif: add a Rx fast path

2022-05-17 Thread Joyce Kong
memif > mbuf | --- non-zc gain | 2.13% |-1.40%| --- zc gain | 0.18% | 0.48%| --- Signed-off-by: Joyce Kong --- drivers/net/memif/rte_et

[PATCH v1 0/2] add a fast path for memif Rx/Tx

2022-05-17 Thread Joyce Kong
| memif > mbuf - non-zc gain |19.97%| 2.35%|21.43% - zc gain |14.30%|-1.21%|11.98% ----- Joy

[RFC] net/memif: add a fast path for Rx

2022-04-12 Thread Joyce Kong
ain with zero-copy mode. Signed-off-by: Joyce Kong --- drivers/net/memif/rte_eth_memif.c | 124 -- 1 file changed, 84 insertions(+), 40 deletions(-) diff --git a/drivers/net/memif/rte_eth_memif.c b/drivers/net/memif/rte_eth_memif.c index 587ad45576..f55776ca46 100

[PATCH v1] net/i40e: fix build issue with 16B descriptor on Arm

2022-03-03 Thread Joyce Kong
is to add interpretation between type 'uint64x2_t' and type 'uint32x4_t'. Fixes: dba9e3bcd9bb ("net/i40e: add flow mark capability to NEON Rx") Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang --- drivers/net/i40e/i40e_rxtx_vec_neon.c | 12 1 fi

RE: [PATCH v4 1/7] eal: fix header build with C++

2022-02-14 Thread Joyce Kong
ketlock: introduce fair ticket based locking") > Fixes: 032a7e5499a0 ("trace: implement provider payload") > Cc: joyce.k...@arm.com > Cc: jer...@marvell.com > Cc: sta...@dpdk.org > > Signed-off-by: Bruce Richardson Acked-by: Joyce Kong > --- > lib/eal/includ

[PATCH v1] net/i40e: add flow mark capability to NEON vector routine

2021-12-16 Thread Joyce Kong
ading the 2nd 16 bytes of each descriptor, to get the FLEXBH_STAT and FD Filter ID from qword3. The resulting data must also be stored to mbuf->fdir.hi, same as the 16B code path. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang --- drivers/net/i40e/i40e_rxtx_vec_neon.c | 145 +

[PATCH v3 12/12] app: remove unnecessary include of atomic header file

2021-11-17 Thread Joyce Kong
Remove the unnecessary rte_atomic.h included in app modules. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang --- app/proc-info/main.c| 1 - app/test-pipeline/config.c | 1 - app/test-pipeline/init.c| 1 - app/test-pipeline/main.c| 1 - app

[PATCH v3 11/12] app/bbdev: use compiler atomics for shared data sync

2021-11-17 Thread Joyce Kong
Convert rte_atomic usages to compiler atomic built-ins for shared data sync in bbdev cases. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli --- app/test-bbdev/test_bbdev_perf.c | 135 ++- 1 file changed, 59 insertions(+), 76

[PATCH v3 10/12] app/testpmd: remove atomic operations for port status

2021-11-17 Thread Joyce Kong
The port_status changes do not need to be handled atomically, as they are modified during initialization or through the testpmd prompt instead of multiple threads. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli --- app/test-pmd/testpmd.c | 58

[PATCH v3 09/12] app/compress: use compiler atomic builtins for display sync

2021-11-17 Thread Joyce Kong
Convert rte_atomic_test_and_set usage to compiler atomic CAS operation for display sync. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli --- app/test-compress-perf/comp_perf_test_common.h| 2 +- .../comp_perf_test_cyclecount.c | 15

[PATCH v3 08/12] app/crypto: use compiler atomic builtins for display sync

2021-11-17 Thread Joyce Kong
Convert rte_atomic_test_and_set usage to compiler atomic CAS operation for display sync in crypto cases. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli --- app/test-crypto-perf/cperf_test_latency.c| 6 -- app/test-crypto-perf

[PATCH v3 07/12] app/eventdev: use compiler atomics for shared data sync

2021-11-17 Thread Joyce Kong
Convert rte_atomic usages to compiler atomic built-ins for shared data sync in eventdev cases. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang --- app/test-eventdev/evt_main.c | 1 - app/test-eventdev/test_order_atq.c| 4 ++-- app/test-eventdev/test_order_common.c | 4

[PATCH v3 06/12] test/func_reentrancy: use compiler atomics for data sync

2021-11-17 Thread Joyce Kong
Convert rte_atomic usages to compiler atomic built-ins for shared data sync in func_reentrancy test cases. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli --- app/test/test_func_reentrancy.c | 27 +-- 1 file changed, 13 insertions

[PATCH v3 05/12] test/bpf: use compiler atomics for calculation

2021-11-17 Thread Joyce Kong
Convert rte_atomic usages to compiler atomic built-ins for calculation in bpf test cases. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang --- app/test/test_bpf.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/app/test/test_bpf.c b/app

[PATCH v3 04/12] test/stack_perf: use compiler atomics for lcore sync

2021-11-17 Thread Joyce Kong
Convert rte_atomic usages to compiler atomic built-ins for lcore sync in stack_perf test cases. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli --- app/test/test_stack_perf.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git

[PATCH v3 03/12] test/timer: use compiler atomic builtins for sync

2021-11-17 Thread Joyce Kong
Convert rte_atomic usages to compiler atomic built-ins for lcore_state and collisions sync. Also, move 'main_init_workers' outside of 'timer_stress2_main_loop' to guarantee lcore_state initialized correctly before the threads launched. Signed-off-by: Joyce Kong Revie

[PATCH v3 02/12] test/ring_perf: use compiler atomic builtins for lcores sync

2021-11-17 Thread Joyce Kong
Convert rte_atomic usages to compiler atomic built-ins for lcores sync in ring_perf test cases. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli --- app/test/test_ring_perf.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/app

[PATCH v3 01/12] test/pmd_perf: use compiler atomic builtins for polling sync

2021-11-17 Thread Joyce Kong
Convert rte_atomic usages to compiler atomic built-ins for polling sync in pmd_perf test cases. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang --- app/test/test_pmd_perf.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/app/test

[PATCH v3 00/12] use compiler atomic builtins for app modules

2021-11-17 Thread Joyce Kong
with suitable ones for shared data sync in pmd_perf and timer test cases. 2. Avoid unnecessary atomic operations in compress and testpmd modules. 3. Fix some typo. Joyce Kong (12): test/pmd_perf: use compiler atomic builtins for polling sync test/ring_perf: use compiler atomic

RE: [PATCH v2 12/12] app: remove unnecessary include of atomic header file

2021-11-16 Thread Joyce Kong
> Subject: Re: [PATCH v2 12/12] app: remove unnecessary include of atomic > header file > > On Tue, Nov 16, 2021 at 10:44 AM Joyce Kong wrote: > > > > Remove the unnecessary rte_atomic.h included in app modules. > > > > Signed-off-by: Joyce Kong > > R

[PATCH v2 12/12] app: remove unnecessary include of atomic header file

2021-11-16 Thread Joyce Kong
Remove the unnecessary rte_atomic.h included in app modules. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang --- app/proc-info/main.c | 1 - app/test-pipeline/config.c | 1 - app/test-pipeline/init.c | 1 - app/test-pipeline/main.c | 1 - app/test-pipeline/runtime.c | 1

[PATCH v2 11/12] app/bbdev: use compiler atomics for shared data sync

2021-11-16 Thread Joyce Kong
Convert rte_atomic usages to compiler atomic built-ins for shared data sync in bbdev cases. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli --- app/test-bbdev/test_bbdev_perf.c | 135 ++- 1 file changed, 59 insertions(+), 76

[PATCH v2 10/12] app/testpmd: remove atomic operations for port status

2021-11-16 Thread Joyce Kong
The port_status changes do not need to be handled atomically, as they are modified during initialization or through the testpmd prompt instead of multiple threads. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang --- app/test-pmd/testpmd.c | 58 ++ 1

[PATCH v2 09/12] app/compress: use compiler atomic builtins for display sync

2021-11-16 Thread Joyce Kong
Convert rte_atomic_test_and_set usage to compiler atomic CAS operation for display sync. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang --- app/test-compress-perf/comp_perf_test_common.h| 2 +- .../comp_perf_test_cyclecount.c | 15

[PATCH v2 08/12] app/crypto: use compiler atomic builtins for display sync

2021-11-16 Thread Joyce Kong
Convert rte_atomic_test_and_set usage to compiler atomic CAS operation for display sync in crypto cases. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli --- app/test-crypto-perf/cperf_test_latency.c| 6 -- app/test-crypto-perf

[PATCH v2 07/12] app/eventdev: use compiler atomics for shared data sync

2021-11-16 Thread Joyce Kong
Convert rte_atomic usages to compiler atomic built-ins for shared data sync in eventdev cases. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang --- app/test-eventdev/evt_main.c | 1 - app/test-eventdev/test_order_atq.c| 4 ++-- app/test-eventdev/test_order_common.c | 4

[PATCH v2 06/12] test/func_reentrancy: use compiler atomics for data sync

2021-11-16 Thread Joyce Kong
Convert rte_atomic usages to compiler atomic built-ins for shared data sync in func_reentrancy test cases. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli --- app/test/test_func_reentrancy.c | 27 +-- 1 file changed, 13 insertions

[PATCH v2 05/12] test/bpf: use compiler atomics for calculation

2021-11-16 Thread Joyce Kong
Convert rte_atomic usages to compiler atomic built-ins for calculation in bpf test cases. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang --- app/test/test_bpf.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/app/test/test_bpf.c b/app

[PATCH v2 04/12] test/stack_perf: use compiler atomics for lcore sync

2021-11-16 Thread Joyce Kong
Convert rte_atomic usages to compiler atomic built-ins for lcore sync in stack_perf test cases. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli --- app/test/test_stack_perf.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git

[PATCH v2 03/12] test/timer: use compiler atomic builtins for sync

2021-11-16 Thread Joyce Kong
Convert rte_atomic usages to compiler atomic built-ins for lcore_state and collisions sync. Also, move 'main_init_workers' outside of 'timer_stress2_main_loop' to guarantee lcore_state initialized correctly before the threads launched. Signed-off-by: Joyce Kong Revie

[PATCH v2 02/12] test/ring_perf: use compiler atomic builtins for lcores sync

2021-11-16 Thread Joyce Kong
Convert rte_atomic usages to compiler atomic built-ins for lcores sync in ring_perf test cases. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli --- app/test/test_ring_perf.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/app

[PATCH v2 01/12] test/pmd_perf: use compiler atomic builtins for polling sync

2021-11-16 Thread Joyce Kong
Convert rte_atomic usages to compiler atomic built-ins for polling sync in pmd_perf test cases. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang --- app/test/test_pmd_perf.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/app/test/test_pmd_perf.c b/app

[PATCH v2 00/12] use compiler atomic builtins for app modules

2021-11-16 Thread Joyce Kong
nappa Nagarahalli: 1. Replace the RELAXED barriers with suitable ones for shared data sync in pmd_perf and timer test cases. 2. Avoid unnecessary atomic operations in compress and testpmd modules. 3. Fix some typo. Joyce Kong (12): test/pmd_perf: use compiler atomic builtins for polling

[PATCH v3] examples/flow_filtering: fix wrong comment

2021-11-11 Thread Joyce Kong
The 'IPv4' in the comment is to mark the code snippet, while it made some confusion. Then removing 'IPv4' description will be clearer. Fixes: 9a212dc06c7a ("doc: use code snippets in sample app guides") Cc: sta...@dpdk.org Signed-off-by: Joyce Kong Reviewed-by: Ru

RE: [PATCH v1 10/12] app/testpmd: use compiler atomic builtins for port sync

2021-11-11 Thread Joyce Kong
pmd > prompt. > > Do we really need atomic operations on port_status? > Hi Honnappa, Seem you are right, I shall remove the atomic operations for port_status. Joyce > > > > Replace rte_atomic16_cmpset operation with compiler atomic CAS > > operation for port status s

RE: [PATCH v1 09/12] app/compress: use compiler atomic builtins for display sync

2021-11-11 Thread Joyce Kong
> > > > > > + exp = 0; > > /* R E P O R T processing */ > > - if (rte_atomic16_test_and_set(&display_once)) { > > + if (__atomic_compare_exchange_n(&display_once, &exp, 1, 0, > > + __ATOMIC_RELAXED, __ATOMIC_RELAXED)) { > I think we can re-organize the current code whi

RE: [PATCH v1 07/12] app/eventdev: use compiler atomic builtins for packets sync

2021-11-10 Thread Joyce Kong
> > > > Subject: [PATCH v1 07/12] app/eventdev: use compiler atomic builtins > > for packets sync > How about the following: > app/eventdev: use compiler atomic builtins for shared data synchronization > Yes, please see next version. > > > > Convert rte_atomic usages to compiler atomic built-i

Re: [dpdk-dev] [PATCH v1 01/12] test/pmd_perf: use compiler atomic builtins for polling sync

2021-11-09 Thread Joyce Kong
> > > > > > Convert rte_atomic usages to compiler atomic built-ins for polling > > sync in pmd_perf test cases. > > > > Signed-off-by: Joyce Kong > > Reviewed-by: Ruifeng Wang > > --- > > app/test/test_pmd_perf.c | 12 +---

Re: [dpdk-dev] [PATCH v1] examples/flow_filtering: fix wrong comment

2021-11-04 Thread Joyce Kong
> > --- > > examples/flow_filtering/flow_blocks.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/examples/flow_filtering/flow_blocks.c > > b/examples/flow_filtering/flow_blocks.c > > index 3251ed9f8f..b168dc6e71 100644 > > --- a/examples/flow_filtering/flow_blocks

[dpdk-dev] [PATCH v2] examples/flow_filtering: fix wrong comment

2021-11-04 Thread Joyce Kong
Change the 'IPV4' level to 'ETH' level in the comment as it was previously misdescribed. Fixes: 9a212dc06c7a ("doc: use code snippets in sample app guides") Cc: sta...@dpdk.org Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang --- doc/guides/sample_app_ug/flow_

[dpdk-dev] [PATCH v1] examples/flow_filtering: fix wrong comment

2021-11-02 Thread Joyce Kong
Change the 'IPV4' level to 'ETH' level in the comment as it was previously misdescribed. Fixes: 9a212dc06c7a ("doc: use code snippets in sample app guides") Cc: sta...@dpdk.org Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang --- examples/flow_filtering/flow_b

Re: [dpdk-dev] [PATCH v1 00/12] use compiler atomic builtins for app

2021-10-20 Thread Joyce Kong
Hi all, Would you please help review the patch series? Thanks! Best Regards, Joyce > -Original Message- > From: dev On Behalf Of Joyce Kong > Sent: Monday, August 2, 2021 6:19 PM > To: tho...@monjalon.net; david.march...@redhat.com; Honnappa > Nagarahalli

Re: [dpdk-dev] [PATCH] kni: remove non-C11 path from FIFO sync

2021-10-20 Thread Joyce Kong
Joyce > -Original Message- > From: dev On Behalf Of Joyce Kong > Sent: Thursday, August 19, 2021 2:05 PM > To: ferruh.yi...@intel.com; Honnappa Nagarahalli > ; Ruifeng Wang > > Cc: dev@dpdk.org; nd > Subject: [dpdk-dev] [PATCH] kni: remove non-C11 path from FIFO sync &

[dpdk-dev] [PATCH v1] lib/ethdev: fix a typo in ethdev comment

2021-09-05 Thread Joyce Kong
Fix a typo that mb_pool was misspelt as mp_pool. Fixes: 4ff702b5dfa9 ("ethdev: introduce Rx buffer split") Cc: Viacheslav Ovsiienko Cc: sta...@dpdk.org Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang --- lib/ethdev/rte_ethdev.h | 2 +- 1 file changed, 1 insertion(+), 1 deletio

Re: [dpdk-dev] [PATCH v2 8/8] examples: remove unnecessary include of atomic

2021-08-23 Thread Joyce Kong
> Hi Joyce, > > > -Original Message- > > From: Joyce Kong > > Sent: Monday, August 23, 2021 1:50 PM > > To: Chas Williams ; Min Hu (Connor) > > ; Ananyev, Konstantin > > ; Nicolau, Radu > > ; Akhil Goyal ; Doherty, > > Declan ; S

[dpdk-dev] [PATCH v2 8/8] examples: remove unnecessary include of atomic

2021-08-22 Thread Joyce Kong
Remove the unnecessary header file rte_atomic.h included in example module. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang --- examples/bond/main.c | 1 - examples/ip_fragmentation/main.c | 1 - examples/ip_reassembly/main.c

[dpdk-dev] [PATCH v2 7/8] examples/server_node_efd: use compiler atomics for sync

2021-08-22 Thread Joyce Kong
Convert rte_atomic32_test_and_set to compiler CAS atomic operation for display_stats sync. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang --- examples/server_node_efd/server/main.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/examples/server_node_efd/server

[dpdk-dev] [PATCH v2 6/8] examples/vm_power_manager: use compiler atomics for sync

2021-08-22 Thread Joyce Kong
Convert rte_atomic32_cmpset to compiler atomic CAS operation for channel status sync. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang --- examples/vm_power_manager/channel_monitor.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/examples/vm_power_manager

[dpdk-dev] [PATCH v2 5/8] examples/l2fwd-jobstats: use compiler atomics for stats sync

2021-08-22 Thread Joyce Kong
Convert rte_atomic usages to compiler atomic built-ins for stats_read_pending sync in l2fwd_jobstats module. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang --- examples/l2fwd-jobstats/main.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/examples/l2fwd

[dpdk-dev] [PATCH v2 4/8] examples/performance-thread: use compiler atomics for sync

2021-08-22 Thread Joyce Kong
Convert rte_atomic usages to compiler atomic built-ins for thread sync. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang --- examples/performance-thread/common/lthread.c | 10 +++--- .../performance-thread/common/lthread_diag.h | 10 +++--- .../performance-thread/common/lthread_int.h

[dpdk-dev] [PATCH v2 3/8] examples/kni: use compiler atomics for status sync

2021-08-22 Thread Joyce Kong
Convert rte_atomic usages to compiler atomic builit-ins for kni_stop and kni_pause sync. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang --- examples/kni/main.c | 27 +-- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/examples/kni/main.c b/examples

[dpdk-dev] [PATCH v2 2/8] examples/multi_process: use compiler atomics for sync

2021-08-22 Thread Joyce Kong
Convert rte_atomic32_test_and_set usage to compiler atomic CAS operation for display_stats sync. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang --- examples/multi_process/client_server_mp/mp_server/main.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/examples

[dpdk-dev] [PATCH v2 1/8] examples/bbdev_app: use compiler atomics for flag sync

2021-08-22 Thread Joyce Kong
Convert rte_atomic usages to compiler atomic built-ins for global_exit_flag sync. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang --- examples/bbdev_app/main.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/examples/bbdev_app/main.c b/examples/bbdev_app

[dpdk-dev] [PATCH v2 0/8] use compiler atomic builtins for examples

2021-08-22 Thread Joyce Kong
x the compiling error of performance-thread patch. Joyce Kong (8): examples/bbdev_app: use compiler atomics for flag sync examples/multi_process: use compiler atomics for sync examples/kni: use compiler atomics for status sync examples/performance-thread: use compiler atomics for sync examples/

[dpdk-dev] [PATCH v1] stack: remove duplicated include of atomic

2021-08-22 Thread Joyce Kong
In stack module, remove the duplicated header file rte_atomic.h as it has been included in rte_spinlock.h/rte_pause.h Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang --- app/test/test_stack.c | 1 - lib/stack/rte_stack.c | 1 - lib/stack/rte_stack.h | 1 - 3 files changed, 3 deletions

[dpdk-dev] [PATCH v4] test/func_reentrancy: free memzones after creating test

2021-08-22 Thread Joyce Kong
se on main thread. Fixes: 104a92bd026f ("app: add reentrancy tests") Fixes: 995eec619024 ("test: clean up memory for function reentrancy test") Cc: sta...@dpdk.org Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang Reviewed-by: Feifei Wang --- v3/v4: Add the synchronization between

Re: [dpdk-dev] [PATCH v2] test/func_reentrancy: free memzones after creating test case

2021-08-22 Thread Joyce Kong
> > > Subject: Re: [dpdk-dev] [PATCH v2] test/func_reentrancy: free > > > memzones after creating test case > > > > > > On Sat, Jul 31, 2021 at 2:04 PM Joyce Kong wrote: > > > > > > > > Function reentrancy test limits maximum number o

[dpdk-dev] [PATCH v3] test/func_reentrancy: free memzones after creating test

2021-08-20 Thread Joyce Kong
se on main thread. Fixes: 104a92bd026f ("app: add reentrancy tests") Fixes: 995eec619024 ("test: clean up memory for function reentrancy test") Cc: sta...@dpdk.org Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang Reviewed-by: Feifei Wang --- app/test/test_func_reentrancy.c | 27 ++

Re: [dpdk-dev] [PATCH v2] test/func_reentrancy: free memzones after creating test case

2021-08-20 Thread Joyce Kong
> -Original Message- > From: David Marchand > Sent: Tuesday, August 17, 2021 4:17 PM > To: Joyce Kong > Cc: Burakov, Anatoly ; Olivier Matz > ; Andrew Rybchenko > ; Wang, Yipeng1 > ; Gobriel, Sameh ; > Bruce Richardson ; Vladimir Medvedkin > ; Ananyev, Konst

[dpdk-dev] [PATCH v1 8/8] examples: remove unnecessary include of atomic

2021-08-19 Thread Joyce Kong
Remove the unnecessary header file rte_atomic.h included in example module. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang --- examples/bond/main.c | 1 - examples/ip_fragmentation/main.c | 1 - examples/ip_reassembly/main.c

  1   2   3   4   5   >