[dpdk-dev] [PATCH] app/testpmd: fix potential out of bounds read

After the last enabled port has been seen, and the last time we evaluate the loop condition, there is an out of bounds read in ports[p].enabled because p is equal to size, which is the length of ports. Signed-off-by: Julien Cretin --- app/test-pmd/testpmd.c | 2 +- 1 file changed, 1 insertion

[dpdk-dev] Clang Scan build results

Hi all! I took a look at the scan-results from Keith to compare with my analysis. My analysis is on test-pmd (called with a specific command-line and with start tx_first at the prompt) and scans exhaustively for all undefined behaviors (overflow, division by zero, invalid pointer dereference or

[dpdk-dev] [PATCH] kni: fix missing backslash in Makefile

With GNU Make 3.81 on Ubuntu 14.04, I get: lib/librte_eal/linuxapp/kni/Makefile:49: *** unterminated call to function `shell': missing `)'. Stop. Signed-off-by: Julien Cretin --- lib/librte_eal/linuxapp/kni/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

[dpdk-dev] [PATCH 3/3] app/testpmd: fix incompatible sign for printf arguments

int when used in the ellipsis notation of a function. These minor bugs were found using TrustInSoft Analyzer. Signed-off-by: Julien Cretin --- app/test-pmd/config.c | 16 app/test-pmd/testpmd.c | 2 +- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/app/test-pmd

[dpdk-dev] [PATCH 2/3] mem: remove redundant check in optimize_object_size

ition was found using TrustInSoft Analyzer. Signed-off-by: Julien Cretin --- lib/librte_mempool/rte_mempool.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c index fdc1586..8e6c86a 100644 --- a/lib

[dpdk-dev] [PATCH 1/3] app/testpmd: fix minor signed overflow in a constant

s defined as (192 x 2^24) % (UINT_MAX + 1) This minor bug was found using TrustInSoft Analyzer. Signed-off-by: Julien Cretin --- app/test-pmd/txonly.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/txonly.c b/app/test-pmd/txonly.c index 1cf2574..5bbd34f 1006

[dpdk-dev] [PATCH 0/3] Various patches

without actually running it. Julien Cretin (3): app/testpmd: fix minor signed overflow in a constant mem: remove redundant check in optimize_object_size app/testpmd: fix incompatible sign for printf arguments app/test-pmd/config.c| 16 app/test-pmd/testpmd.c