Re: [dpdk-dev] [PATCH v2] vhost: fix corner case for enqueue operation

2018-09-27 Thread Kevin Traynor
On 09/27/2018 01:37 PM, Maxime Coquelin wrote: > > > On 09/27/2018 02:24 PM, Maxime Coquelin wrote: >> >> >> On 09/17/2018 05:54 AM, Jiayu Hu wrote: >>> When perform enqueue operations on the split and packed ring, >> s/perform/performing/ >> s/ring/rings/ >>> if the reserved buffer length from t

Re: [dpdk-dev] [PATCH v8] app/testpmd: add noisy neighbour forwarding mode

2018-10-02 Thread Kevin Traynor
On 10/02/2018 08:44 AM, Jens Freimann wrote: > This adds a new forwarding mode to testpmd to simulate > more realistic behavior of a guest machine engaged in receiving > and sending packets performing Virtual Network Function (VNF). > As there's going to be a v9 anyway, you can also fix the bel

Re: [dpdk-dev] [PATCH v9] app/testpmd: add noisy neighbour forwarding mode

2018-10-05 Thread Kevin Traynor
per packet should be > performed, simulating FIB/table lookups. 64 bits per read, > all write in different cache lines. > > --noisy-lkup-num-reads-writes [num] > Number of random reads and writes in memory per packet should > be performed, simulating stats update. 64 bits per read-write, all > reads and writes in different cache lines. > > Signed-off-by: Jens Freimann > Acked-by: Kevin Traynor

[dpdk-dev] [PATCH] doc: note min required kernel version increase for 19.02

2018-10-10 Thread Kevin Traynor
Updating docs to reflect decision made at the techboard that the min kernel version should be bumped from 3.2 to the latest longterm stable release (3.16), but that compatiblity for commonly used distribution kernels should be kept also. Signed-off-by: Kevin Traynor --- I namechecked RHEL

[dpdk-dev] [PATCH v2] doc: note min required kernel version increase for 19.02

2018-10-10 Thread Kevin Traynor
Updating docs to reflect decision made at the techboard that the min kernel version should be bumped from 3.2 to the latest longterm stable release (3.16), but that compatiblity for commonly used distribution kernels should be kept also. Signed-off-by: Kevin Traynor Acked-by: Maxime Coquelin

Re: [dpdk-dev] [PATCH v2] net/i40e: firmware status check

2018-12-14 Thread Kevin Traynor
On 12/03/2018 08:07 AM, Zhang, Qi Z wrote: > > >> -Original Message- >> From: Li, Xiaoyun >> Sent: Monday, December 3, 2018 3:08 PM >> To: Zhang, Qi Z >> Cc: dev@dpdk.org; Li, Xiaoyun >> Subject: [PATCH v2] net/i40e: firmware status check >> >> Check the firmware status at init time. If

Re: [dpdk-dev] [PATCH v2] net/igb: fix LSC interrupt when using MSI-X

2018-12-14 Thread Kevin Traynor
On 11/20/2018 04:16 AM, Zhang, Qi Z wrote: > > >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhao1, Wei >> Sent: Monday, November 19, 2018 7:29 PM >> To: Player, Timmons >> Cc: dev@dpdk.org; Lu, Wenzhuo >> Subject: Re: [dpdk-dev] [PATCH v2] net/igb: fix L

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/i40e: firmware status check

2018-12-17 Thread Kevin Traynor
On 12/17/2018 10:57 AM, Ferruh Yigit wrote: > On 12/14/2018 4:59 PM, Kevin Traynor wrote: >> On 12/03/2018 08:07 AM, Zhang, Qi Z wrote: >>> >>> >>>> -Original Message- >>>> From: Li, Xiaoyun >>>> Sent: Monday, December

[dpdk-dev] 18.08.1 patches review and test

2018-12-20 Thread Kevin Traynor
/browse/dpdk-stable/ Thanks. Kevin Traynor --- Adrien Mazarguil (1): net/mlx5: fix artificial L4 limitation on switch flow rules Agalya Babu RadhaKrishnan (4): vfio: disable in FreeBSD build with meson net/nfp: disable in FreeBSD build with meson net/avp: disable in FreeBSD

[dpdk-dev] 18.08.1 patches review and test

2018-12-21 Thread Kevin Traynor
. Kevin Traynor --- Adrien Mazarguil (1): net/mlx5: fix artificial L4 limitation on switch flow rules Agalya Babu RadhaKrishnan (4): vfio: disable in FreeBSD build with meson net/nfp: disable in FreeBSD build with meson net/avp: disable in FreeBSD build with meson net

Re: [dpdk-dev] [PATCH v1] net/i40e: perform basic validation on the VF messages

2019-01-10 Thread Kevin Traynor
On 01/10/2019 12:07 PM, Haiyue Wang wrote: > Do the VF message basic validation such as OPCODE message length check, > some special OPCODE message format check, to protect the i40e PMD from > malicious VF message attack. > > Fixes: 4861cde46116 ("i40e: new poll mode driver") > Missing Cc: sta...

Re: [dpdk-dev] [PATCH v2] doc: fix MAC address rewrite actions documentation

2019-01-10 Thread Kevin Traynor
On 01/09/2019 11:37 AM, Dekel Peled wrote: > This patch fixes a typo in SET_MAC_DST action description. > It also adds restriction note for set MAC src/dst actions description. > > Fixes: 15dbcdaada77 ("ethdev: add generic MAC address rewrite actions") Cc: sta...@dpdk.org unless there's a reason

Re: [dpdk-dev] [PATCH v1] net/i40e: perform basic validation on the VF messages

2019-01-11 Thread Kevin Traynor
27;s a question for i40e maintainer. Kevin. > Thanks > Vipin Varghese > >> -Original Message- >> From: dev On Behalf Of Kevin Traynor >> Sent: Thursday, January 10, 2019 11:18 PM >> To: Wang, Haiyue ; dev@dpdk.org; Zhang, Qi Z >> >> Subject: Re

Re: [dpdk-dev] [PATCH v1] net/i40e: support request any number of queues

2019-01-15 Thread Kevin Traynor
On 01/15/2019 02:57 PM, Zhirun Yan wrote: > Before this patch, VF must request a specific queues(1/2/4/8/16) with > DPDK PF. This patch align the number of requested queues to next power > of 2. So VF can request any number queues from 1 to 16. > > Signed-off-by: Zhirun Yan > --- > drivers/net/i

Re: [dpdk-dev] [PATCH 1/2] eal: remove experimental tag for probe/remove

2018-11-05 Thread Kevin Traynor
impler to use and > more flexible by accepting any devargs string. > Let's encourage applications to use it. > > The old functions rte_eal_hotplug_* may be deprecated later. > > Signed-off-by: Thomas Monjalon one minor comment below, but it's no big deal.. Ack

Re: [dpdk-dev] [PATCH 2/2] ethdev: remove experimental tag for iterator API

2018-11-05 Thread Kevin Traynor
uld not be experimental. > That's why the experimental status of the ethdev iterator is removed. > > Signed-off-by: Thomas Monjalon Acked-by: Kevin Traynor Tested-by: Kevin Traynor > --- > lib/librte_ethdev/rte_ethdev.c | 6 +++--- > lib/librte_ethdev/rte_e

Re: [dpdk-dev] [PATCH v2 1/3] net/af_packet: set_mtu() decrements sockaddr twice

2018-11-20 Thread Kevin Traynor
On 11/20/2018 10:26 AM, Tiago Lam wrote: > When setting the MTU, eth_dev_mtu_set() is called to validate the > provided MTU. As part of that, it calculates the useful area to store > data and compares it against the MTU, to guarantee that there's enough > space to store the data. It calculates that

Re: [dpdk-dev] [PATCH] pci/vfio: fixup rte_intr_callback_unregister() handling

2018-11-20 Thread Kevin Traynor
On 10/24/2018 11:11 AM, Darek Stojaczyk wrote: > This function is documented to return the number of unregistered > callbacks or negative numbers on error, but pci_vfio checks for > ret != 0 to detect failures. Not anymore. > > Fixes: c115fd000c32 ("vfio: handle hotplug request notifier") > Cc: ji

Re: [dpdk-dev] [PATCH] pci/vfio: fixup rte_intr_callback_unregister() handling

2018-11-20 Thread Kevin Traynor
On 11/20/2018 11:04 AM, Kevin Traynor wrote: > On 10/24/2018 11:11 AM, Darek Stojaczyk wrote: >> This function is documented to return the number of unregistered >> callbacks or negative numbers on error, but pci_vfio checks for >> ret != 0 to detect failures. Not

Re: [dpdk-dev] [PATCH v3 0/2] IOPL related fixes

2018-11-23 Thread Kevin Traynor
On 11/23/2018 04:25 PM, Maxime Coquelin wrote: > > > On 11/23/18 4:53 PM, Ilya Maximets wrote: >> On 23.11.2018 18:41, Maxime Coquelin wrote: >>> Hi, >>> >>> On 11/23/18 4:39 PM, Ilya Maximets wrote: Patches primary targeted to fix OVS unit test failures with DPDK 18.11 due to following

Re: [dpdk-dev] [PATCH v3 0/2] IOPL related fixes

2018-11-26 Thread Kevin Traynor
On 11/25/2018 10:42 AM, Thomas Monjalon wrote: > 23/11/2018 23:29, Thomas Monjalon: >> 23/11/2018 21:07, Kevin Traynor: >>> On 11/23/2018 04:25 PM, Maxime Coquelin wrote: >>>> On 11/23/18 4:53 PM, Ilya Maximets wrote: >>>>> On 23.11.2018 18:41, Maxi

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] mem: Fix anonymous mapping on Power9.

2018-11-27 Thread Kevin Traynor
On 11/18/2018 01:41 PM, Thomas Monjalon wrote: > 16/11/2018 18:35, David Wilder: >> Removed the use of MAP_HUGETLB for anonymous mapping on ppc64. The >> MAP_HUGETLB had previously been added to workaround issues on IBM Power8 >> systems when mapping /dev/zero (see: commit >> 284ae3e9ff9a92575c28c

Re: [dpdk-dev] [PATCH] net/mlx5: revert mbuf address calculation for x86

2019-03-27 Thread Kevin Traynor
On 25/03/2019 19:13, Yongseok Koh wrote: > When replenishing mbufs on Rx, buffer address (mbuf->buf_addr) should be > loaded. non-x86 processors (mostly RISC such as ARM and Power) are more > vulnerable to load stall. For x86, reducing the number of instructions > seems to matter most. > > For x86

Re: [dpdk-dev] 18.11.1 patches review and test

2019-03-27 Thread Kevin Traynor
On 27/03/2019 14:41, Ali Alnubani wrote: > Hi > >> -Original Message- >> From: dev On Behalf Of Kevin Traynor >> Sent: Friday, March 22, 2019 5:10 PM >> To: dpdk stable >> Cc: dev@dpdk.org >> Subject: [dpdk-dev] 18.11.1 patches review and

[dpdk-dev] [PATCH v2] doc: note validation and timeline required for stables

2019-03-27 Thread Kevin Traynor
stable release no later than 1 month after it's initial master release. Signed-off-by: Kevin Traynor --- v2: add 1 month deadline to designate as stable release. I didn't add v1 acks, as this is something new. doc/guides/contributing/stable.rst | 4 +++- 1 file changed, 3 insertions(+),

Re: [dpdk-dev] [PATCH] app/test-crypto-perf: improve dequeue logic

2019-03-27 Thread Kevin Traynor
On 27/03/2019 11:47, Akhil Goyal wrote: > In case of hardware PMDs (which may take a longer duration > for processing the packets), there may be a case when the > number of enqueued packets are more than the dequeued. > > So if the difference is more than 8 times the burst size, > more dequeue ope

Re: [dpdk-dev] 18.11.1 patches review and test

2019-04-02 Thread Kevin Traynor
On 02/04/2019 14:21, Luca Boccassi wrote: > Thank you, Ju! > +1, thanks Ju for running these and sharing. I will add summary of them to the 18.11.1 release notes. > Some additional information: this test was run via the LISAv2 framework > that Microsoft uses to validate Linux and other applicati

Re: [dpdk-dev] 18.11.1 patches review and test

2019-04-03 Thread Kevin Traynor
On 03/04/2019 10:16, Ian Stokes wrote: > On 3/22/2019 3:10 PM, Kevin Traynor wrote: >> Hi all, >> >> Here is a list of patches targeted for LTS release 18.11.1. Please >> help review and test. The planned date for the final release is >> April 8th. Before

Re: [dpdk-dev] DPDK ABI/API Stability

2019-04-04 Thread Kevin Traynor
On 03/04/2019 16:42, Ray Kinsella wrote: > Hi folks, > > Recently I started a discussion with the DPDK Technical Board on DPDK > ABI/API stability. This was born out informal feedback I had received > from a number of users of DPDK about ABI churn. In turn this feedback > then prompted an ABI anal

Re: [dpdk-dev] [dpdk-techboard] DPDK ABI/API Stability

2019-04-04 Thread Kevin Traynor
On 04/04/2019 11:54, Bruce Richardson wrote: > > My thoughts on the matter are: > 1. I think we really need to do work to start hiding more of our data > structures - like what Stephen's latest RFC does. This hiding should reduce > the scope for ABI breaks. > 2. Once done, I think we should commi

Re: [dpdk-dev] [dpdk-techboard] DPDK ABI/API Stability

2019-04-04 Thread Kevin Traynor
On 04/04/2019 20:08, Wiles, Keith wrote: > > >> On Apr 4, 2019, at 11:56 AM, Kevin Traynor wrote: >> >> On 04/04/2019 11:54, Bruce Richardson wrote: >> >> >>> >>> My thoughts on the matter are: >>> 1. I think we really need to do w

[dpdk-dev] [dpdk-announce] DPDK 18.08.1 released

2019-04-05 Thread Kevin Traynor
/rel_notes/release_18_08.html#id1 Note, this is the only planned stable release for DPDK 18.08 and the 18.08 stable branch is no longer be maintained. Kevin Traynor --- app/pdump/main.c | 10 +- app/test-bbdev/test_bbdev_perf.c | 14 +- app

[dpdk-dev] [dpdk-announce] DPDK 18.11.1 released

2019-04-09 Thread Kevin Traynor
#validation Kevin Traynor --- app/pdump/main.c | 9 + app/test-bbdev/test_bbdev_perf.c | 10 +- app/test-eventdev/test_perf_common.c | 3 +- app/test-pmd/cmdline.c | 16 +- app/test-pmd/cmdline_flow.c

Re: [dpdk-dev] [PATCH v2 13/13] net/enic: fix several issues with inner packet matching

2019-04-10 Thread Kevin Traynor
On 04/03/2019 16:58, Ferruh Yigit wrote: > On 3/2/2019 10:42 AM, Hyong Youb Kim wrote: >> Inner packet matching is currently buggy in many cases. >> >> 1. Mishandling null spec ("match any"). >> The copy_item functions do nothing if spec is null. This is incorrect, >> as all patterns should be appe

Re: [dpdk-dev] [PATCH v2 2/3] test: remove prefix _acpi from UT power function/test names

2019-04-15 Thread Kevin Traynor
On 03/04/2019 11:32, Lukasz Krakowiak wrote: > This patch remove prefix _acpi from power UT function/test names. > Hi, why is it better? Asking because it might mean you have to send some future fixes separately to stable branches. > Signed-off-by: Lukasz Krakowiak > ---

Re: [dpdk-dev] [PATCH] examples/vm_power: add conditional compilation for PMD specific code

2019-04-15 Thread Kevin Traynor
On 02/04/2019 19:14, David Christensen wrote: I think it should have Fixes: and probably stable tags. > Signed-off-by: David Christensen > --- > Running the devtools/test-build.sh script on IBM Power systems fails > because the IXGBE_PMD is explicity disabled for Power as an untested > driver, b

Re: [dpdk-dev] [PATCH v3] eal: support strlcat function

2019-04-16 Thread Kevin Traynor
On 17/01/2019 17:30, Bruce Richardson wrote: > Add the strlcat function to DPDK to exist alongside the strlcpy one. > While strncat is generally safe for use for concatenation, the API for the > strlcat function is perhaps a little nicer to use, and supports truncation > detection. > > See commit

Re: [dpdk-dev] [PATCH v5 0/3] rwlock: reimplement rwlock with atomic and add relevant perf test case

2019-04-16 Thread Kevin Traynor
On 25/03/2019 09:14, Joyce Kong wrote: > Gavin Hu (1): > rwlock: reimplement with atomic builtins > Hi - for 18.11 branch, I applied above (queued for push) rebased to remove the trylock modifications. > Joyce Kong (2): > test/rwlock: add perf test case on all available cores > test/rwlock

Re: [dpdk-dev] [Bug 248] Bonding PMD: Invalid array dimension in TX burst for 802.3ad mode with fast queue leads to SEGFAULT

2019-04-18 Thread Kevin Traynor
On 15/04/2019 10:50, Przemysław Ołtarzewski wrote: > Hello, > > Last week I attempted to migrate our system from DPDK 18.11.1 to current > master with David's patches applied. I haven't been able to make it work > correctly - probably due to other changes in master since 18.11.1 - so > unfortunate

Re: [dpdk-dev] [PATCH] eal: promote some experimental functions as stable

2019-04-18 Thread Kevin Traynor
xperimental. > > The function rte_dev_is_probed() was introduced half a year ago > in DPDK 18.11. It is no longer experimental. > > Signed-off-by: Thomas Monjalon Acked-by: Kevin Traynor

Re: [dpdk-dev] [PATCH v1] doc: fix spelling errors reported by aspell

2019-04-18 Thread Kevin Traynor
On 03/04/2019 14:26, John McNamara wrote: > Signed-off-by: John McNamara > --- > > Some notes on this. > > It is probably best not to apply this patch until just before the release > since it could potentially create a lot of conflicts. I'll resubmit a v2 > prior to the 19.05 release. > > The

Re: [dpdk-dev] [PATCH] config: reduce memory requirements for DPDK

2018-07-25 Thread Kevin Traynor
On 07/24/2018 01:03 PM, Thomas Monjalon wrote: > 24/07/2018 13:04, Burakov, Anatoly: >> On 24-Jul-18 11:23 AM, Thomas Monjalon wrote: >>> 24/07/2018 12:03, Anatoly Burakov: It has been reported that current memory limitations do not work well on an 8-socket machines in default configurati

Re: [dpdk-dev] [PATCH] net/i40e: fix tx queue setup after stop queue

2018-07-25 Thread Kevin Traynor
On 07/10/2018 11:37 AM, Shaopeng He wrote: > Currently, i40e_dev_tx_queue_setup_runtime checks simple tx and treats > mbuf fast free offloading as No-simple, which is classified as simple tx > in i40e_set_tx_function_flag. This inconsistent behavior causes tx queue > setup fail after queue was stop

Re: [dpdk-dev] [PATCH v2 00/15] enic PMD fixes and performance improvements

2018-07-25 Thread Kevin Traynor
On 06/29/2018 10:29 AM, John Daley wrote: > Updated a few commits in the patchset per suggestions by Ferrus Yigit. > thanks, > John > > Hyong Youb Kim (12): > net/enic: fix receive packet types > net/enic: update the UDP RSS detection mechanism > net/enic: do not overwrite admin Tx queue lim

Re: [dpdk-dev] Stable ABI status of rte_meter_[t|s]rtcm_profile_config

2018-08-01 Thread Kevin Traynor
On 05/28/2018 04:31 AM, Andy Green wrote: > Hi - > > Between 18.02 and the putative 18.05 there were changes in the way the > meter stuff deals with its config. > > I updated the related code in lagopus, but I get warnings about using > the new APIs (it's the same for rte_meter_trtcm_profile_conf

Re: [dpdk-dev] Stable ABI status of rte_meter_[t|s]rtcm_profile_config

2018-08-01 Thread Kevin Traynor
On 08/01/2018 03:30 PM, Dumitrescu, Cristian wrote: > > >> -Original Message----- >> From: Kevin Traynor [mailto:ktray...@redhat.com] >> Sent: Wednesday, August 1, 2018 11:48 AM >> To: dev@dpdk.org; Dumitrescu, Cristian >> Cc: Andy Green ; Singh, Jas

[dpdk-dev] [PATCH] meter: remove experimental from profile APIs

2018-08-01 Thread Kevin Traynor
As per guideline that new APIs must be experimental for at least one release, it is now possible to remove the experimental tag from: rte_meter_srtcm_profile_config() rte_meter_trtcm_profile_config() Cc: Cristian Dumitrescu Signed-off-by: Kevin Traynor --- examples/qos_meter/Makefile

[dpdk-dev] [PATCH] ethdev: decrease log level for successful API

2018-08-02 Thread Kevin Traynor
Change log level of messages from ERR back to DEBUG where existing API indicates that the condition is a success. This means applications using the API in its current form will not get new ERR logs. Fixes: bea1e0c70cfc ("ethdev: convert static log type usage to dynamic") Signed-off

Re: [dpdk-dev] [PATCH] ethdev: decrease log level for successful API

2018-08-02 Thread Kevin Traynor
On 08/02/2018 01:59 PM, Andrew Rybchenko wrote: > On 02.08.2018 15:33, Kevin Traynor wrote: >> Change log level of messages from ERR back to DEBUG where >> existing API indicates that the condition is a success. >> >> This means applications using the API in its curre

Re: [dpdk-dev] [PATCH] ethdev: decrease log level for successful API

2018-08-02 Thread Kevin Traynor
On 08/02/2018 02:52 PM, Andrew Rybchenko wrote: > On 02.08.2018 16:35, Kevin Traynor wrote: >> On 08/02/2018 01:59 PM, Andrew Rybchenko wrote: >>> On 02.08.2018 15:33, Kevin Traynor wrote: >>>> Change log level of messages from ERR back to DEBUG where >>>>

Re: [dpdk-dev] [PATCH] ethdev: decrease log level for successful API

2018-08-02 Thread Kevin Traynor
On 08/02/2018 03:41 PM, Andrew Rybchenko wrote: > On 02.08.2018 17:09, Kevin Traynor wrote: >> On 08/02/2018 02:52 PM, Andrew Rybchenko wrote: >>> On 02.08.2018 16:35, Kevin Traynor wrote: >>>> On 08/02/2018 01:59 PM, Andrew Rybchenko wrote: >>>>

Re: [dpdk-dev] [PATCH] ethdev: decrease log level for successful API

2018-08-02 Thread Kevin Traynor
On 08/02/2018 07:01 PM, Andrew Rybchenko wrote: > On 02.08.2018 19:14, Thomas Monjalon wrote: >> 02/08/2018 16:52, Kevin Traynor: >>> On 08/02/2018 03:41 PM, Andrew Rybchenko wrote: >>>> On 02.08.2018 17:09, Kevin Traynor wrote: >>>>> On 08/02/201

[dpdk-dev] [PATCH] ethdev: decrease log level for successful API

2018-08-02 Thread Kevin Traynor
ge to dynamic") Signed-off-by: Kevin Traynor --- lib/librte_ethdev/rte_ethdev.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c index c7ab157..4c32025 100644 --- a/lib/librte_ethdev/rte_ethdev.c

Re: [dpdk-dev] [PATCH] ethdev: decrease log level for successful API

2018-08-02 Thread Kevin Traynor
subject prefix not updated - will resend as [PATCH v2] On 08/02/2018 07:33 PM, Kevin Traynor wrote: > Change log level of messages from ERR to INFO where > the post condition of the API is success, but no action > was actually needed as the condition already existed. >

[dpdk-dev] [PATCH v2] ethdev: decrease log level for successful API

2018-08-02 Thread Kevin Traynor
ge to dynamic") Signed-off-by: Kevin Traynor --- lib/librte_ethdev/rte_ethdev.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c index c7ab157..4c32025 100644 --- a/lib/librte_ethdev/rte_ethdev.c

Re: [dpdk-dev] [RFC 1/4] ethdev: claim device reset as async

2018-08-08 Thread Kevin Traynor
On 08/08/2018 08:00 AM, Qi Zhang wrote: > rte_eth_dev_reset should be implemented in an async way since it is > possible be invoked in interrupt thread and sometimes to reset a > device need to wait for some dependency, for example, a VF expects > for PF ready, or a NIC function as part of a SOC wa

Re: [dpdk-dev] [PATCH v7 01/11] crypto/dpaa: replace rte_panic instances in crypto/dpaa driver

2018-04-26 Thread Kevin Traynor
On 04/24/2018 11:16 PM, Arnon Warshavsky wrote: > replace panic calls with log and return value. > > Signed-off-by: Arnon Warshavsky > --- > drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 8 +--- > drivers/crypto/dpaa_sec/dpaa_sec.c | 10 ++ > 2 files changed, 11 insertions(

Re: [dpdk-dev] [PATCH v9 02/10] bond: replace rte_panic instances in bonding driver

2018-04-26 Thread Kevin Traynor
On 04/26/2018 07:20 AM, Arnon Warshavsky wrote: > Replace panic calls with log and return value. > Local functions to this file, > changing from void to int are non-abi-breaking > > Signed-off-by: Arnon Warshavsky > --- > drivers/net/bonding/rte_eth_bond_8023ad.c | 29 > ++--

Re: [dpdk-dev] [PATCH v5 05/11] eal: replace rte_panic instances in eventdev

2018-04-26 Thread Kevin Traynor
On 04/23/2018 10:28 PM, Arnon Warshavsky wrote: > replace panic calls with log and return value. > > Signed-off-by: Arnon Warshavsky > --- > lib/librte_eventdev/rte_eventdev_pmd_pci.h | 8 +--- > lib/librte_eventdev/rte_eventdev_pmd_vdev.h | 8 +--- > 2 files changed, 10 insertions(+),

Re: [dpdk-dev] [PATCH v9 08/10] eal: replace rte_panic instances in ethdev

2018-04-26 Thread Kevin Traynor
On 04/26/2018 07:21 AM, Arnon Warshavsky wrote: > Local function to this file, > changing from void to int is non-abi-breaking > > Signed-off-by: Arnon Warshavsky > --- > lib/librte_ether/rte_ethdev.c | 42 ++ > lib/librte_ether/rte_ethdev.h | 4 +++- > 2

Re: [dpdk-dev] [PATCH v9 09/10] eal: replace rte_panic instances in init sequence

2018-04-26 Thread Kevin Traynor
On 04/26/2018 07:21 AM, Arnon Warshavsky wrote: > Change some local functions return type from void to int. > This change does not break ABI as the functions are internal. > Panic thrown from threads was not handled in this patch > > Signed-off-by: Arnon Warshavsky > Acked-by: Anatoly Burakov >

Re: [dpdk-dev] [PATCH v9 10/10] devtools: prevent new instances of rte_panic and rte_exit

2018-04-26 Thread Kevin Traynor
I think the first line of the commit msg ^^^ should change as it no longer prevents but just warns On 04/26/2018 07:21 AM, Arnon Warshavsky wrote: > This patch adds a new function that is called > per every checked patch, > and alerts for new instances of rte_panic/rte_exit. > The check excludes c

Re: [dpdk-dev] [PATCH v7 01/11] crypto/dpaa: replace rte_panic instances in crypto/dpaa driver

2018-04-26 Thread Kevin Traynor
On 04/26/2018 05:05 PM, Kevin Traynor wrote: > On 04/24/2018 11:16 PM, Arnon Warshavsky wrote: >> replace panic calls with log and return value. >> Replied to wrong version. Comments are still relevant for v9, Kevin. >> Signed-off-by: Arnon Warshavsky >> --- &

Re: [dpdk-dev] [PATCH v9 09/10] eal: replace rte_panic instances in init sequence

2018-04-27 Thread Kevin Traynor
On 04/26/2018 11:08 PM, Arnon Warshavsky wrote: > Hi Kevin > > > + if (rte_config_init() != 0) > > + return -1; > > + > > I'm confused, is this deliberate? there is now two rte_config_init() > calls. > > > Please note that there are 2 eal.c files. One under

Re: [dpdk-dev] [PATCH v9 10/10] devtools: prevent new instances of rte_panic and rte_exit

2018-04-27 Thread Kevin Traynor
On 04/26/2018 10:57 PM, Arnon Warshavsky wrote: > > > On Thu, Apr 26, 2018 at 7:08 PM, Kevin Traynor <mailto:ktray...@redhat.com>> wrote: > > I think the first line of the commit msg ^^^ should change as it no > longer prevents but just warns > >

Re: [dpdk-dev] [PATCH v7 01/11] crypto/dpaa: replace rte_panic instances in crypto/dpaa driver

2018-04-27 Thread Kevin Traynor
On 04/26/2018 10:28 PM, Arnon Warshavsky wrote: > > > - if (cryptodev->data->dev_private == NULL) > > - rte_panic("Cannot allocate memzone for private " > > - "device data"); > > + if (cryptodev->data->dev_pr

Re: [dpdk-dev] [dpdk-web] [PATCH v2] update stable releases roadmap

2018-05-01 Thread Kevin Traynor
On 05/01/2018 03:16 PM, Aaron Conole wrote: > Thomas Monjalon writes: > >> 25/04/2018 12:03, Luca Boccassi: >>> On Wed, 2018-04-25 at 09:33 +0100, Ferruh Yigit wrote: >>>> On 4/20/2018 4:52 PM, Aaron Conole wrote: >>>>> Kevin Traynor writes: >

Re: [dpdk-dev] [PATCH v10] devtools: alert on new instances of rte_panic and rte_exit

2018-05-04 Thread Kevin Traynor
ls. > > Signed-off-by: Arnon Warshavsky > Reviewed-by: Stephen Hemminger Tested-by: Kevin Traynor > --- > devtools/checkpatches.sh | 96 > +++- > 1 file changed, 95 insertions(+), 1 deletion(-) > > diff --git a/devtools/

Re: [dpdk-dev] [PATCH v5 5/8] testpmd: new commands to load/unload BPF filters

2018-05-09 Thread Kevin Traynor
On 05/09/2018 06:09 PM, Ferruh Yigit wrote: > On 5/4/2018 1:45 PM, Konstantin Ananyev wrote: >> Introduce new testpmd commands to load/unload RX/TX BPF-based filters. >> >> Signed-off-by: Konstantin Ananyev >> --- >> app/test-pmd/bpf_sup.h | 25 >> app/test-pmd/cmdline.c | 149 >> +

Re: [dpdk-dev] [PATCH 1/2] app/testpmd: add custom topology command

2018-05-15 Thread Kevin Traynor
On 05/09/2018 01:34 PM, Wisam Jaddo wrote: > Set custom topology for forwading packets by making the ^ > given two ports as pair, in custom topology the active > ports will be the defiend in custum-topo only. ^^^^^ typos above and si

Re: [dpdk-dev] [PATCH 1/2] app/testpmd: add custom topology command

2018-05-16 Thread Kevin Traynor
On 05/15/2018 03:05 PM, Wisam Monther wrote: > Hey Kevin, > > What if I have 10 ports and want all 9 ports to forward packets to port > 0, this cannot done in paired. > But with this topo the user can overwrite the topo. > E.g: > - Set custom-topo 1 0 > Will make those paired and those two as acti

Re: [dpdk-dev] [PATCH] doc: advise to specify LTS branch when backporting patches

2018-05-16 Thread Kevin Traynor
cify exactly which branch the patch is for in the cover > letter, in the annotation or using ``git send-email --subject-prefix='16.11' > ...`` > + s/branch/branch(es)/ How about [16.11] instead of '16.11' ? I would be in favour that the prefix(es) should always be added for this very specific case, as it will make it stand out more. either way, Acked-by: Kevin Traynor > + > The Review Process > -- > >

Re: [dpdk-dev] [PATCH v2] doc: advise to specify LTS branch when backporting patches

2018-05-16 Thread Kevin Traynor
via the cover letter, > annotation or using --subject-prefix. > Also note to send only to sta...@dpdk.org, not dev@dpdk.org. > Acked-by: Kevin Traynor > Signed-off-by: Luca Boccassi > --- > > v2: hint that --subject-prefix is required, fix typos > > doc/guides/

Re: [dpdk-dev] [dpdk-stable] 17.11.3 (LTS) patches review and test

2018-05-28 Thread Kevin Traynor
On 05/27/2018 06:35 AM, Yuanhan Liu wrote: > Hi all, > > Here is a list of patches targeted for LTS release 17.11.3. Please > help review and test. The planned date for the final release is 8th, > Jun. Before that, please let me know if anyone has objections with > these patches being applied. >

Re: [dpdk-dev] [PATCH] net/qede: fix L2-handles used for RSS hash update

2018-06-05 Thread Kevin Traynor
On 06/01/2018 06:16 PM, Rasesh Mody wrote: > Fix fast path array index which is used for passing L2 handles to RSS > indirection table. Currently, it is using the local copy of indirection > table. When the RX queue configuration changes the local copy becomes > invalid. > > Fixes: 69d7ba88f1a1 ("

Re: [dpdk-dev] [PATCH] net/qede: fix L2-handles used for RSS hash update

2018-06-05 Thread Kevin Traynor
On 06/05/2018 05:16 PM, Mody, Rasesh wrote: >> From: Kevin Traynor [mailto:ktray...@redhat.com] >> Sent: Tuesday, June 05, 2018 6:40 AM >> >> On 06/01/2018 06:16 PM, Rasesh Mody wrote: >>> Fix fast path array index which is used for passing L2 handles to RSS >&g

Re: [dpdk-dev] [PATCH v2] net/qede: fix L2-handles used for RSS hash update

2018-06-06 Thread Kevin Traynor
changes the local copy becomes invalid. > > Fixes: 69d7ba88f1a1 ("net/qede/base: use L2-handles for RSS configuration") > Cc: sta...@dpdk.org > > Signed-off-by: Rasesh Mody > Reviewed-by: Kevin Traynor LGTM > --- > drivers/net/qede/qede_ethdev.c |2 +-

Re: [dpdk-dev] [PATCH] net/qede: fix memory alloc for multiple port reconfig

2018-06-08 Thread Kevin Traynor
gt; Release Rx and Tx queue rings allocated during queue setup. > > Fixes: a39001d90dbd ("net/qede: fix DMA memory leak") > Cc: sta...@dpdk.org > > Signed-off-by: Rasesh Mody Reviewed-by: Kevin Traynor > --- > drivers/net/qede/base/bcm_osal.c |5

[dpdk-dev] [PATCH] docs: add default that all fixes are backported

2018-06-21 Thread Kevin Traynor
between what is backported to stable/LTS branches, remove some subjectivity as to what constitutes "a fix" and avoid possible conflicts for future backports. Signed-off-by: Kevin Traynor --- doc/guides/contributing/stable.rst | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff -

Re: [dpdk-dev] [PATCH v4 1/2] testpmd: add forwarding mode to simulate a noisy neighbour

2018-06-27 Thread Kevin Traynor
On 06/23/2018 09:08 AM, Maxime Coquelin wrote: > From: Jens Freimann > > This adds a new forwarding mode to testpmd to simulate > more realistic behavior of a guest machine engaged in receiving > and sending packets performing Virtual Network Function (VNF). > > The goal is to enable a simple wa

Re: [dpdk-dev] [PATCH v4 1/2] lib/librte_power: traffic pattern aware power control

2018-06-27 Thread Kevin Traynor
On 06/26/2018 12:40 PM, Radu Nicolau wrote: > From: Liang Ma > > 1. Abstract > > For packet processing workloads such as DPDK polling is continuous. > This means CPU cores always show 100% busy independent of how much work > those cores are doing. It is critical to accurately determine how busy

Re: [dpdk-dev] [PATCH] docs: add default that all fixes are backported

2018-06-29 Thread Kevin Traynor
On 06/29/2018 05:15 PM, Thomas Monjalon wrote: > 21/06/2018 18:45, Ferruh Yigit: >> On 6/21/2018 5:00 PM, Kevin Traynor wrote: >>> Set the starting point that all commits on master branch >>> with Fixes tag are backported to relevant stable/LTS branches. >>> &g

[dpdk-dev] [PATCH v2] docs: add default that all fixes should be backported

2018-06-29 Thread Kevin Traynor
, so also add a sentence for that. This is to ensure that there is consistency between what is backported to stable/LTS branches, remove some subjectivity as to what constitutes "a fix" and avoid possible conflicts for future backports. Signed-off-by: Kevin Traynor Acked-by: Luca Boccassi

[dpdk-dev] [PATCH v3] docs: add default that all fixes should be backported

2018-06-29 Thread Kevin Traynor
, so also add a sentence for that. This is to ensure that there is consistency between what is backported to stable/LTS branches, remove some subjectivity as to what constitutes "a fix" and avoid possible conflicts for future backports. Signed-off-by: Kevin Traynor Acked-by: Luca Boccassi

Re: [dpdk-dev] [PATCH v2] docs: add default that all fixes should be backported

2018-06-29 Thread Kevin Traynor
On 06/29/2018 11:02 PM, Thomas Monjalon wrote: > 29/06/2018 23:47, Kevin Traynor: >> -Backporting should be limited to bug fixes. >> +Backporting should be limited to bug fixes. All patches accepted on the >> master >> +branch with Fixes tags should be backported

Re: [dpdk-dev] [PATCH v5] app/testpmd: add forwarding mode to simulate a noisy neighbour

2018-08-29 Thread Kevin Traynor
On 08/10/2018 03:49 PM, Jens Freimann wrote: > This adds a new forwarding mode to testpmd to simulate > more realistic behavior of a guest machine engaged in receiving > and sending packets performing Virtual Network Function (VNF). > Hi Jens, comments below, thanks, Kevin. > The goal is to ena

Re: [dpdk-dev] [PATCH] doc: update API deprecation for device reset

2018-09-10 Thread Kevin Traynor
On 09/10/2018 03:04 PM, Qi Zhang wrote: > Device reset may have the dependency, for example, a VF reset expects > PF ready, or a NIC function as a part of a SOC need to wait for other > parts of the system be ready, these are time-consuming tasks and will > block current thread. > > So we claimed

Re: [dpdk-dev] [PATCH v4 1/2] lib/librte_power: traffic pattern aware power control

2018-09-13 Thread Kevin Traynor
On 09/11/2018 10:19 AM, Hunt, David wrote: > Hi Kevin, > Hi Dave, > > On 27/6/2018 6:33 PM, Kevin Traynor wrote: >> On 06/26/2018 12:40 PM, Radu Nicolau wrote: >>> From: Liang Ma >>> >>> 1. Abstract > > --snip-- > >>> 2.

Re: [dpdk-dev] [PATCH v7 1/4] lib/librte_power: traffic pattern aware power control

2018-09-13 Thread Kevin Traynor
On 09/04/2018 03:10 PM, Liang Ma wrote: > 1. Abstract > Hi Liang, I didn't review the code, but some comments on API below, > For packet processing workloads such as DPDK polling is continuous. > This means CPU cores always show 100% busy independent of how much work > those cores are doing. It

Re: [dpdk-dev] [PATCH v6] app/testpmd: add forwarding mode to simulate a noisy neighbour

2018-09-20 Thread Kevin Traynor
On 09/18/2018 10:35 AM, Jens Freimann wrote: > This adds a new forwarding mode to testpmd to simulate > more realistic behavior of a guest machine engaged in receiving > and sending packets performing Virtual Network Function (VNF). > > The goal is to enable a simple way of measuring performance i

Re: [dpdk-dev] [PATCH v2 00/21] net/atlantic: Aquantia aQtion 10G NIC Family DPDK PMD driver

2018-09-21 Thread Kevin Traynor
On 09/13/2018 01:22 PM, Igor Russkikh wrote: > Hello DPDK community! > > Aquantia would like to contribute PMD for aQtion AQC10X NIC family: > https://www.aquantia.com/products/aqtion/chips/ > These are 10G ethernet NICs with various features. > > We do base this work on parts of the existing nat

Re: [dpdk-dev] [PATCH v7] app/testpmd: add forwarding mode to simulate a noisy neighbour

2018-09-25 Thread Kevin Traynor
per packet should be > performed, simulating FIB/table lookups. 64 bits per read, > all write in different cache lines. > > --noisy-lkup-num-reads-writes [num] > Number of random reads and writes in memory per packet should > be performed, simulating stats update. 64 bits per read-write, all > reads and writes in different cache lines. > > Signed-off-by: Jens Freimann > --- Acked-by: Kevin Traynor

Re: [dpdk-dev] [PATCH] net/i40e: update Rx checksum offload

2018-09-25 Thread Kevin Traynor
On 09/21/2018 08:36 AM, Beilei Xing wrote: > HW supports Rx scatter offload, this patch updates > Rx scatter offload for PF. > Should this be for stable branch also? > Signed-off-by: Beilei Xing > --- > drivers/net/i40e/i40e_ethdev.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/dr

Re: [dpdk-dev] [PATCH v2] net/ifc: do not notify before HW ready

2018-09-25 Thread Kevin Traynor
On 09/14/2018 02:25 AM, Xiao Wang wrote: > If the device is not clearly reset by the previous driver and holds > some invalid ring addr, and the relay thread kicks it before HW is > properly re-configured, a bad DMA request may happen. > > Besides, the notify_addr which is used by the relay thread

Re: [dpdk-dev] [PATCH v3 3/3] doc: add deprecation marker usage

2019-01-23 Thread Kevin Traynor
Acked-by: Luca Boccassi > --- > Cc: Luca Boccassi > Cc: Kevin Traynor > Cc: Yongseok Koh > Cc: Neil Horman > > v2: > * Rephrased as commented > > v3: > * changed when to remove the deprecated API. It is now just after > an LTS release, the motiva

Re: [dpdk-dev] [PATCH v3 3/3] doc: add deprecation marker usage

2019-01-24 Thread Kevin Traynor
On 01/24/2019 03:31 PM, Ferruh Yigit wrote: > On 1/23/2019 11:07 PM, Kevin Traynor wrote: >> On 01/22/2019 05:23 PM, Ferruh Yigit wrote: >>> Define '__rte_deprecated' usage process. >>> >>> Suggests keeping old API with '__rte_deprecated'

[dpdk-dev] 18.08.1 patches review and test

2019-01-30 Thread Kevin Traynor
. Kevin Traynor --- Adrien Mazarguil (1): net/mlx5: fix artificial L4 limitation on switch flow rules Agalya Babu RadhaKrishnan (4): vfio: disable in FreeBSD build with meson net/nfp: disable in FreeBSD build with meson net/avp: disable in FreeBSD build with meson net

Re: [dpdk-dev] [PATCH] eal: fix strdup usages in internal config

2019-01-31 Thread Kevin Traynor
On 01/10/2019 01:38 PM, Anatoly Burakov wrote: > Currently, we use strdup in a few places to store command-line > parameter values for certain internal config values. There are > several issues with that. > > First of all, they're never freed, so memory ends up leaking > either after EAL exit, or

Re: [dpdk-dev] [PATCH] eal: fix strdup usages in internal config

2019-01-31 Thread Kevin Traynor
On 01/31/2019 02:10 PM, Burakov, Anatoly wrote: > On 31-Jan-19 11:21 AM, Kevin Traynor wrote: >> On 01/10/2019 01:38 PM, Anatoly Burakov wrote: >>> Currently, we use strdup in a few places to store command-line >>> parameter values for certain internal config values. T

Re: [dpdk-dev] [PATCH 0/5] net/mlx5: add inner tunnel items support on E-Switch

2019-01-31 Thread Kevin Traynor
On 12/27/2018 03:34 PM, Viacheslav Ovsiienko wrote: > The generic Flow rule for tunnels looks like: > > flow create \ > \ > \ > > > Current design supports only L2 addresses as inner pattern > items. This patchset adds support for

  1   2   3   4   5   6   7   8   >