Re: [dpdk-dev] [PATCH v5 0/4] Vhost: fix mq=on but VIRTIO_NET_F_MQ not negotiated

2017-12-13 Thread Laszlo Ersek
ou do VIRTIO_NET_CTRL_MQ_VQ_PAIRS_SET. But since this requires a > vhost-user update, doing both makes sense. Based on this, plus reviewing patch #4 for: + vq = dev->virtqueue[--dev->nr_vring]; + if (!vq) + continue; + + dev->virtqueue[dev->nr_vring] = NULL; Acked-by: Laszlo Ersek Thanks Laszlo

Re: [dpdk-dev] [PATCH v4 0/4] Vhost: fix mq=on but VIRTIO_NET_F_MQ not negotiated

2017-12-11 Thread Laszlo Ersek
vhost.c | 22 -- > lib/librte_vhost/vhost.h | 3 +++ > lib/librte_vhost/vhost_user.c | 39 +-- > 3 files changed, 52 insertions(+), 12 deletions(-) > I compared patch #1 between v3 and v4 -- I think you could have carried forward my A-b. (Perhaps a more thorough R-b should have been dropped indeed.) Anyways, for v4: Acked-by: Laszlo Ersek Thanks Laszlo

Re: [dpdk-dev] [PATCH v3 0/4] Vhost: fix mq=on but VIRTIO_NET_F_MQ not negotiated

2017-12-06 Thread Laszlo Ersek
t; I have no background in DPDK (as I've stated) and I didn't look at a wider code context than what is captured in the patches. So whatever opinion I hold may have little value. With that disclaimer, if you want it: Acked-by: Laszlo Ersek Thanks, Laszlo

Re: [dpdk-dev] [PATCH v2 4/4] vhost: destroy unused virtqueues when multiqueue not negotiated

2017-12-05 Thread Laszlo Ersek
Hi Maxime, On 12/05/17 09:34, Maxime Coquelin wrote: > QEMU sends VHOST_USER_SET_VRING_CALL requests for all queues > declared in QEMU command line before the guest is started. > It has the effect in DPDK vhost-user backend to allocate vrings > for all queues declared by QEMU. > > If the first dr