[dpdk-dev] [PATCH v5 3/3] mempool: allow for user-owned mempool caches

2016-06-29 Thread Lazaros Koromilas
use the per-lcore default local cache. Signed-off-by: Lazaros Koromilas Acked-by: Olivier Matz --- app/test/test_mempool.c | 73 --- app/test/test_mempool_perf.c| 73 +-- doc/guides/prog_guide/env_abstraction_layer.rst | 4 +- doc

[dpdk-dev] [PATCH v5 2/3] mempool: use bit flags to set multi consumers and producers

2016-06-29 Thread Lazaros Koromilas
Pass the same flags as in rte_mempool_create(). Changes API calls: rte_mempool_generic_put(mp, obj_table, n, flags) rte_mempool_generic_get(mp, obj_table, n, flags) Signed-off-by: Lazaros Koromilas Acked-by: Olivier Matz --- lib/librte_mempool/rte_mempool.h | 58

[dpdk-dev] [PATCH v5 1/3] mempool: deprecate specific get and put functions

2016-06-29 Thread Lazaros Koromilas
) rte_mempool_sp_put(mp, obj) rte_mempool_mc_get_bulk(mp, obj_table, n) rte_mempool_sc_get_bulk(mp, obj_table, n) rte_mempool_mc_get(mp, obj_p) rte_mempool_sc_get(mp, obj_p) We also check cookies in one place now. Signed-off-by: Lazaros Koromilas Acked-by: Olivier Matz --- app

[dpdk-dev] [PATCH v5 0/3] mempool: user-owned mempool caches

2016-06-29 Thread Lazaros Koromilas
ble, n) rte_mempool_sp_put_bulk(mp, obj_table, n) rte_mempool_mp_put(mp, obj) rte_mempool_sp_put(mp, obj) rte_mempool_mc_get_bulk(mp, obj_table, n) rte_mempool_sc_get_bulk(mp, obj_table, n) rte_mempool_mc_get(mp, obj_p) rte_mempool_sc_get(mp, obj_p) Lazaros Koromi

[dpdk-dev] [PATCH v4 3/3] mempool: allow for user-owned mempool caches

2016-06-28 Thread Lazaros Koromilas
Hi Olivier, thanks for fixing those, just one comment below On Mon, Jun 27, 2016 at 4:50 PM, Olivier Matz wrote: > From: Lazaros Koromilas > > The mempool cache is only available to EAL threads as a per-lcore > resource. Change this so that the user can create and provide their

[dpdk-dev] [PATCH v3 3/3] mempool: allow for user-owned mempool caches

2016-06-18 Thread Lazaros Koromilas
On Fri, Jun 17, 2016 at 11:37 AM, Olivier Matz wrote: > > > On 06/16/2016 01:02 PM, Lazaros Koromilas wrote: >> The mempool cache is only available to EAL threads as a per-lcore >> resource. Change this so that the user can create and provide their own >> cache on mem

[dpdk-dev] [PATCH v3 3/3] mempool: allow for user-owned mempool caches

2016-06-16 Thread Lazaros Koromilas
use the per-lcore default local cache. Signed-off-by: Lazaros Koromilas --- app/test/test_mempool.c | 94 -- app/test/test_mempool_perf.c | 70 ++--- lib/librte_mempool/rte_mempool.c | 66 +++- lib/librte_mempool/rte_mempool.h | 163

[dpdk-dev] [PATCH v3 2/3] mempool: use bit flags instead of is_mp and is_mc

2016-06-16 Thread Lazaros Koromilas
Pass the same flags as in rte_mempool_create(). Changes API calls: rte_mempool_generic_put(mp, obj_table, n, flags) rte_mempool_generic_get(mp, obj_table, n, flags) Signed-off-by: Lazaros Koromilas --- lib/librte_mempool/rte_mempool.h | 58 +--- 1

[dpdk-dev] [PATCH v3 1/3] mempool: deprecate specific get/put functions

2016-06-16 Thread Lazaros Koromilas
) rte_mempool_sp_put(mp, obj) rte_mempool_mc_get_bulk(mp, obj_table, n) rte_mempool_sc_get_bulk(mp, obj_table, n) rte_mempool_mc_get(mp, obj_p) rte_mempool_sc_get(mp, obj_p) We also check cookies in one place now. Signed-off-by: Lazaros Koromilas --- app/test/test_mempool.c

[dpdk-dev] [PATCH v3 0/3] mempool: user-owned mempool caches

2016-06-16 Thread Lazaros Koromilas
obj_p) Lazaros Koromilas (3): mempool: deprecate specific get/put functions mempool: use bit flags instead of is_mp and is_mc mempool: allow for user-owned mempool caches app/test/test_mempool.c | 104 +++- app/test/test_mempool_perf.c | 70 +-- lib/librte_m

[dpdk-dev] [PATCH v2 1/2] mempool: allow for user-owned mempool caches

2016-06-14 Thread Lazaros Koromilas
Hi Olivier, I have it in my queue, I'll do my best to have it before the deadline. Thanks! Lazaros. On Mon, Jun 13, 2016 at 1:21 PM, Olivier Matz wrote: > Hi Lazaros, > > On 05/11/2016 11:56 AM, Olivier MATZ wrote: >> Hi Lazaros, >> >> Sorry for the late review. Please find some comments, >>

[dpdk-dev] [PATCH v2 1/2] mempool: allow for user-owned mempool caches

2016-04-19 Thread Lazaros Koromilas
_persec=1965896498 > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Lazaros Koromilas >> Sent: Monday, April 04, 2016 4:43 PM >> To: dev at dpdk.org >> Subject: [dpdk-dev] [PATCH v2 1/2] mempool: allow for user-owned mempool

[dpdk-dev] [PATCH v2 1/2] mempool: allow for user-owned mempool caches

2016-04-05 Thread Lazaros Koromilas
Hi all, I forgot to mention that this series applies on top of: http://www.dpdk.org/dev/patchwork/patch/10492/ Thanks, Lazaros. On Mon, Apr 4, 2016 at 6:43 PM, Lazaros Koromilas wrote: > The mempool cache is only available to EAL threads as a per-lcore > resource. Change t

[dpdk-dev] [PATCH] doc: announce ABI changes for user-owned mempool caches

2016-04-05 Thread Lazaros Koromilas
Deprecation notice for 16.04 for changes targeting release 16.07. The changes affect struct rte_mempool, rte_mempool_cache and the mempool API. Signed-off-by: Lazaros Koromilas --- doc/guides/rel_notes/deprecation.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git a/doc/guides

[dpdk-dev] [PATCH v2 2/2] mempool: use bit flags instead of is_mp and is_mc

2016-04-04 Thread Lazaros Koromilas
Pass the same flags as in rte_mempool_create(). Signed-off-by: Lazaros Koromilas --- app/test/test_mempool.c | 18 +-- app/test/test_mempool_perf.c | 4 +-- lib/librte_mempool/rte_mempool.h | 66 +--- 3 files changed, 45 insertions

[dpdk-dev] [PATCH v2 1/2] mempool: allow for user-owned mempool caches

2016-04-04 Thread Lazaros Koromilas
(mp, obj) rte_mempool_get(mp, obj) Signed-off-by: Lazaros Koromilas --- app/test/test_mempool.c| 58 +-- app/test/test_mempool_perf.c | 46 +- lib/librte_eal/common/eal_common_log.c | 8 +- lib/librte_mempool/rte_mempool.c | 76 - lib

[dpdk-dev] [PATCH v2] ring: check for zero objects mc dequeue / mp enqueue

2016-03-29 Thread Lazaros Koromilas
On Tue, Mar 29, 2016 at 7:04 PM, Bruce Richardson wrote: > > On Tue, Mar 29, 2016 at 05:29:12PM +0200, Olivier MATZ wrote: > > Hi, > > > > > > On 03/29/2016 10:54 AM, Bruce Richardson wrote: > > >On Mon, Mar 28, 2016 at 06:48:07PM +0300, Lazaros Koromilas w

[dpdk-dev] [PATCH v2] ring: check for zero objects mc dequeue / mp enqueue

2016-03-28 Thread Lazaros Koromilas
832 (gdb) p cons_head $3 = 254348896 (gdb) p cons_next $4 = 254348928 I haven't been able to trigger this with the patch so far, but it should be possible. Lazaros. On Fri, Mar 25, 2016 at 1:15 PM, Olivier Matz wrote: > Hi Lazaros, > > On 03/17/2016 04:49 PM, Lazaros Koromilas wrote:

[dpdk-dev] [PATCH] mempool: allow for user-owned mempool caches

2016-03-24 Thread Lazaros Koromilas
On Mon, Mar 21, 2016 at 3:49 PM, Wiles, Keith wrote: >>Hi Lazaros, >> >>Thanks for this patch. To me, this is a valuable enhancement. >>Please find some comments inline. >> >>On 03/10/2016 03:44 PM, Lazaros Koromilas wrote: >>> The mempool cache is

[dpdk-dev] [PATCH] mempool: allow for user-owned mempool caches

2016-03-24 Thread Lazaros Koromilas
function call. This can be part of free() that Olivier proposed. Thanks! Lazaros. > >> >> On 03/10/2016 03:44 PM, Lazaros Koromilas wrote: >> > The mempool cache is only available to EAL threads as a per-lcore >> > resource. Change this so that the user can c

[dpdk-dev] [PATCH v2] ring: check for zero objects mc dequeue / mp enqueue

2016-03-17 Thread Lazaros Koromilas
when n = 0: cons_next = cons_head + n; success = rte_atomic32_cmpset(>cons.head, cons_head, cons_next); The same is possible on the enqueue path. Signed-off-by: Lazaros Koromilas --- lib/librte_ring/rte_ring.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/

[dpdk-dev] [PATCH] ring: assert on zero objects dequeue/enqueue

2016-03-17 Thread Lazaros Koromilas
Sure, I'm sending it again with your suggestions. Lazaros. On Wed, Mar 16, 2016 at 1:21 PM, Bruce Richardson wrote: > On Tue, Mar 15, 2016 at 06:58:45PM +0200, Lazaros Koromilas wrote: >> Issuing a zero objects dequeue with a single consumer has no effect. >> Doing so with mul

[dpdk-dev] [PATCH] ring: assert on zero objects dequeue/enqueue

2016-03-15 Thread Lazaros Koromilas
when n = 0: cons_next = cons_head + n; success = rte_atomic32_cmpset(>cons.head, cons_head, cons_next); The same is possible on the enqueue path. Signed-off-by: Lazaros Koromilas --- lib/librte_ring/rte_ring.h | 26 ++ 1 file changed, 26 insertions(+) diff --

[dpdk-dev] [PATCH] mempool: allow for user-owned mempool caches

2016-03-10 Thread Lazaros Koromilas
the current ones default to the per-lcore local cache. Signed-off-by: Lazaros Koromilas --- lib/librte_mempool/rte_mempool.c | 65 +- lib/librte_mempool/rte_mempool.h | 442 --- 2 files changed, 467 insertions(+), 40 deletions(-) diff --git a/lib/librte_mempool