Re: Libtpa: a DPDK based userspace TCP stack implementation

2023-12-11 Thread Liang Ma
Hi Yuanhan, Congratulations! Regards Liang On Mon, Dec 11, 2023 at 05:56:54PM +0800, Yuanhan Liu wrote: > Hi all, > > I'd like to share a new DPDK open source project, libtpa(Transport > Protocol Acceleration)[0], which is just another userspace TCP stack > implementation so far, written fro

Re: [PATCH v4 15/19] event/opdl: remove term sanity

2023-08-21 Thread Liang Ma
On Wed, Aug 02, 2023 at 04:25:46PM -0700, Stephen Hemminger wrote: > Don't use non-inclusive term. > > Signed-off-by: Stephen Hemminger > --- Acked-by: Liang Ma > drivers/event/opdl/opdl_evdev.c | 2 +- > drivers/event/opdl/opdl_evdev_init.c | 2 +- > 2 f

Re: [PATCH v2 41/44] event/opdl: fix segment fault when parse devargs

2023-03-23 Thread Liang Ma
7;. > > This patch fixes segment fault when parse input args with 'only keys'. > > Fixes: 3c7f3dcfb099 ("event/opdl: add PMD main body and helper function") > Cc: sta...@dpdk.org > > Signed-off-by: Chengwen Feng Acked-by: Liang Ma > > --- > drivers

Re: TCP stack support on DPDK

2023-02-16 Thread Liang Ma
On Thu, Feb 16, 2023 at 03:01:28PM +, Van Haaren, Harry wrote: > > -Original Message- > > From: Liang Ma > > Sent: Thursday, February 16, 2023 2:40 PM > > To: Sam Kirubakaran > > Cc: dev@dpdk.org > > Subject: Re: TCP stack support on DPDK > &g

Re: [PATCH v5 0/4] add support for self monitoring

2023-02-16 Thread Liang Ma
PMU is kind of MSR. Precisely , that's MSR per core. All MSR reading will lead to IPI(Please reference the kernel implementation of MSR driver). The IPI will disturb the DPDK application because the userspace/kernel context switch, which has impact to the tail latency.

Re: TCP stack support on DPDK

2023-02-16 Thread Liang Ma
On Tue, Jan 24, 2023 at 01:24:38PM +0530, Sam Kirubakaran wrote: > Hi Liang, > > Thank you so much for your response. > I would like to convert our in-house tool into a high performance traffic > generator and it is written in Python. > Is it possible to use any of the user space TCP stack by comp

Re: [PATCH] malloc: fix malloc performance may becomes worse as the number of malloc increases

2023-02-16 Thread Liang Ma
On Wed, Feb 15, 2023 at 12:10:23PM +0100, Morten Brørup wrote: > +CC: Fidaullah Noonari , your name also shows > up in the git log; perhaps you can help review this patch. > > > I gave up reviewing in depth, because the existing code is not easy to > quickly understand, and it would take too lo

Re: [PATCH] malloc: fix malloc performance may becomes worse as the number of malloc increases

2023-02-16 Thread Liang Ma
On Wed, Feb 15, 2023 at 11:10:25AM +0100, Thomas Monjalon wrote: > Looking for reviewers please. I will help on this. > > 10/02/2023 07:30, Fengnan Chang: > > Here is a simple test case: > > " > > uint64_t entry_time, time; > > size_t size = 4096; > > unsigned align = 4096; > > for (int j = 0; j

Re: TCP stack support on DPDK

2023-01-23 Thread Liang Ma
On Fri, Jan 20, 2023 at 01:41:56PM +0530, Sam Kirubakaran wrote: > Hi team, > > My name is Sam and I am a Software Engineer. > Currently, we are trying to improve the performance of proprietary in-house > tools by using DPDK but we are not sure whether DPDK has support for TCP > stack. > If yes, c

Re: [PATCH] ip_frag: replace the rte memcpy with memcpy

2022-06-27 Thread Liang Ma
On Fri, Jun 24, 2022 at 06:25:10PM +0100, Konstantin Ananyev wrote: > 23/06/2022 03:35, Stephen Hemminger пишет: > > On Wed, 22 Jun 2022 23:49:39 +0100 > > Konstantin Ananyev wrote: > > > > > > @@ -26,7 +25,7 @@ static inline void __fill_ipv4hdr_frag(struct > > > > rte_ipv4_hdr *dst, > > > >

Re: [PATCH] devtools: fix symbols check

2022-03-08 Thread Liang Ma
On Tue, Mar 08, 2022 at 11:05:49PM +0100, Thomas Monjalon wrote: > 08/03/2022 22:27, Liang Ma: > > On Tue, Mar 08, 2022 at 10:18:59PM +0100, Thomas Monjalon wrote: > > > In some environments, the check of local symbols catch-all > > > was failing. Note: this script

Re: [PATCH] devtools: fix symbols check

2022-03-08 Thread Liang Ma
53,7 +53,7 @@ if [ -n "$duplicate_symbols" ] ; then > ret=1 > fi > > -local_miss_maps=$(grep -L 'local: \*;' $@) > +local_miss_maps=$(grep -L 'local: \*;' $@ || true) reviewed-by Liang Ma I'm curious to know how can the CI passed with or

Re: [PATCH v1 1/1] vhost: integrate dmadev in asynchronous datapath

2021-12-30 Thread Liang Ma
On Thu, Dec 30, 2021 at 04:55:05PM -0500, Jiayu Hu wrote: > Since dmadev is introduced in 21.11, to avoid the overhead of vhost DMA > abstraction layer and simplify application logics, this patch integrates > dmadev in asynchronous data path. > > Signed-off-by: Jiayu Hu > Signed-off-by: Sunil Pai

Re: [PATCH v3] net/ixgbe: add vector Rx parameter check

2021-12-15 Thread Liang Ma
make some restrictions to ensure that > + * `rx_tail` will not exceed `rxrearm_start`. > + */ > + nb_pkts = RTE_MIN(nb_pkts, RTE_IXGBE_RXQ_REARM_THRESH); > + > /* nb_pkts has to be floor-aligned to RTE_IXGBE_DESCS_PER_LOOP */ > nb_pkts = RTE_ALIGN_FLOOR(nb_pkts, RTE_IXGBE_DESCS_PER_LOOP); > > -- > 2.25.1 > Reviewed-by Liang Ma

Re: [PATCH] ring: fix overflow in memory size calcuation

2021-12-15 Thread Liang Ma
* esize; > sz = RTE_ALIGN(sz, RTE_CACHE_LINE_SIZE); > return sz; > } > -- > 2.11.0 > Reviewed-by Liang Ma

[dpdk-dev] [PATCH v4] build: check for broken AVX-512 compiler support

2021-07-20 Thread Liang Ma
From: Liang Ma GCC 6.3.0 has a known bug which related to _mm512_extracti64x4_epi64. Please reference https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82887 Some DPDK PMD avx512 version heavily use _mm512_extracti64x4_epi6, which cause building failure with debug buildtype. Therefore, it's he

Re: [dpdk-dev] [PATCH v3] build: check AVX512 rather than compiler version

2021-07-20 Thread Liang Ma
On Tue, Jul 20, 2021 at 12:58:13PM +0100, Bruce Richardson wrote: > One minor comment below. Also the commit title needs rewording, since the > current title is based on the changes from V1->V2 of your patch. I'd > suggest something like: > "build: check for broken AVX-512 compiler support" > >

Re: [dpdk-dev] [PATCH v2] build: check AVX512 rather than compiler version

2021-07-20 Thread Liang Ma
On Tue, Jul 20, 2021 at 11:19:48AM +0100, Bruce Richardson wrote: > On Mon, Jul 19, 2021 at 11:34:33PM +0100, Liang Ma wrote: > > From: Liang Ma > > > > GCC 6.3.0 has a known bug which related to _mm512_extracti64x4_epi64. > > Please reference https://gcc.gnu.org/bug

[dpdk-dev] [PATCH v3] build: check AVX512 rather than compiler version

2021-07-20 Thread Liang Ma
From: Liang Ma GCC 6.3.0 has a known bug which related to _mm512_extracti64x4_epi64. Please reference https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82887 Some DPDK PMD avx512 version heavily use _mm512_extracti64x4_epi6, which cause building failure with debug buildtype. Therefore, it's he

[dpdk-dev] [PATCH v2] build: check AVX512 rather than compiler version

2021-07-19 Thread Liang Ma
From: Liang Ma GCC 6.3.0 has a known bug which related to _mm512_extracti64x4_epi64. Please reference https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82887 Some DPDK PMD avx512 version heavily use _mm512_extracti64x4_epi6, which cause building failure with debug buildtype. Therefore, it's he

Re: [dpdk-dev] [PATCH] buildtools: Check GCC version to avoid GCC 6.3.0 avx512 bug

2021-07-19 Thread Liang Ma
On Mon, Jul 19, 2021 at 09:38:14AM +0100, Bruce Richardson wrote: > On Sun, Jul 18, 2021 at 10:33:15AM +0100, Liang Ma wrote: > > On Sat, Jul 17, 2021 at 06:08:04PM -0700, Stephen Hemminger wrote: > > > On Sat, 17 Jul 2021 23:13:04 +0100 > > > Liang Ma wrote: > >

[dpdk-dev] [PATCH] net/mlx5: export rte_pmd_mlx5 header

2021-07-18 Thread Liang Ma
From: Liang Ma rte prefix header should be exported in meson.build Fixes: 23f627e0ed28 (net/mlx5: add flow sync API) Signed-off-by: Liang Ma --- drivers/net/mlx5/meson.build | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/mlx5/meson.build b/drivers/net/mlx5/meson.build

Re: [dpdk-dev] [PATCH] buildtools: Check GCC version to avoid GCC 6.3.0 avx512 bug

2021-07-18 Thread Liang Ma
On Sat, Jul 17, 2021 at 06:08:04PM -0700, Stephen Hemminger wrote: > On Sat, 17 Jul 2021 23:13:04 +0100 > Liang Ma wrote: > > > On Sat, Jul 17, 2021 at 10:48:49AM -0700, Stephen Hemminger wrote: > > > On Sat, 17 Jul 2021 18:08:30 +0100 > > > Liang Ma wrote

Re: [dpdk-dev] [PATCH] buildtools: Check GCC version to avoid GCC 6.3.0 avx512 bug

2021-07-17 Thread Liang Ma
On Sat, Jul 17, 2021 at 10:48:49AM -0700, Stephen Hemminger wrote: > On Sat, 17 Jul 2021 18:08:30 +0100 > Liang Ma wrote: > > > From: Liang Ma > > > > GCC 6.3.0 has a known bug which related to _mm512_extracti64x4_epi64. > > Please reference https://gcc.gnu.o

[dpdk-dev] [PATCH] buildtools: Check GCC version to avoid GCC 6.3.0 avx512 bug

2021-07-17 Thread Liang Ma
From: Liang Ma GCC 6.3.0 has a known bug which related to _mm512_extracti64x4_epi64. Please reference https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82887 Some DPDK PMD avx512 version heavily use _mm512_extracti64x4_epi6, which casue building failure with debug buildtype. Therefore, it's he

Re: [dpdk-dev] dmadev discussion summary

2021-07-02 Thread Liang Ma
On Sat, Jun 26, 2021 at 11:59:49AM +0800, fengchengwen wrote: > Hi, all > I analyzed the current DPAM DMA driver and drew this summary in conjunction > with the previous discussion, and this will as a basis for the V2 > implementation. > Feedback is welcome, thanks > > > dpaa2_qdma: > [pro

[dpdk-dev] DPDK will benefit from incoming linux kernel mm patch(HugeTLB related)

2021-07-01 Thread Liang Ma
Hi all, FYI The incoming kernel mm patch will save ~1.6% Memory for 1G hugepage and ~1.2% for 2M hugepage, which is a good news for DPDK. https://lore.kernel.org/linux-doc/20210510030027.56044-5-songmuc...@bytedance.com/ if you run a server with 1TB Dram, you can save ~16G. this patc

Re: [dpdk-dev] [21.08 PATCH v1 2/2] net/af_xdp: add power monitor support

2021-06-01 Thread Liang Ma
AF_XDP eventually support umwait. looking forward to reviewing the updated version

Re: [dpdk-dev] [PATCH] acl: fix build with GCC 6.3

2021-05-21 Thread Liang Ma
itute constant variable 'match_log' with its actual value. > > The fix replaces constant variable with its immediate value. > > > > Bugzilla ID: 717 > > Fixes: b64c2295f7fc ("acl: add 256-bit AVX512 classify method") > > Fixes: 45da22e42ec3 ("

Re: [dpdk-dev] [PATCH] acl: fix build with GCC 6.3

2021-05-21 Thread Liang Ma
On Fri, May 21, 2021 at 03:42:07PM +0100, Konstantin Ananyev wrote: I apply this patch but it caused i40e pmd avx512 build failure. not sure about the root cause. I build debug version with latest repo.

Re: [dpdk-dev] Question Of binutils-avx512-check

2021-05-21 Thread Liang Ma
On Fri, May 21, 2021 at 09:52:30AM +, Ananyev, Konstantin wrote: > > > > On Fri, May 21, 2021 at 09:19:53AM +0100, Bruce Richardson wrote: > > > On Fri, May 21, 2021 at 08:56:50AM +0100, Liang Ma wrote: > > > > On Fri, May 21, 2021 at 09:04:06AM +0200, Thoma

Re: [dpdk-dev] Question Of binutils-avx512-check

2021-05-21 Thread Liang Ma
On Fri, May 21, 2021 at 10:07:07AM +0100, Bruce Richardson wrote: > On Fri, May 21, 2021 at 09:55:37AM +0100, Liang Ma wrote: > > On Fri, May 21, 2021 at 09:19:53AM +0100, Bruce Richardson wrote: > > > On Fri, May 21, 2021 at 08:56:50AM +0100, Liang Ma wrote: > > > >

Re: [dpdk-dev] Question Of binutils-avx512-check

2021-05-21 Thread Liang Ma
On Fri, May 21, 2021 at 09:19:53AM +0100, Bruce Richardson wrote: > On Fri, May 21, 2021 at 08:56:50AM +0100, Liang Ma wrote: > > On Fri, May 21, 2021 at 09:04:06AM +0200, Thomas Monjalon wrote: > > > 20/05/2021 23:22, Liang Ma: > > > > Hi All, > > > >

Re: [dpdk-dev] Question Of binutils-avx512-check

2021-05-21 Thread Liang Ma
On Fri, May 21, 2021 at 09:04:06AM +0200, Thomas Monjalon wrote: > 20/05/2021 23:22, Liang Ma: > > Hi All, > >I try to build DPDK with debug build-type but the building process is > >failed becuase of AVX512 code from librte-acl. The release build type > >

[dpdk-dev] Question Of binutils-avx512-check

2021-05-20 Thread Liang Ma
Hi All, I try to build DPDK with debug build-type but the building process is failed becuase of AVX512 code from librte-acl. The release build type is fine. Hence, I dig a bit into the avx512 enabling logic of meson. I found the main logic is implemented inside binutils-avx512-check.

Re: [dpdk-dev] [PATCH] examples/vhost: fix ioat ring space in callbacks

2021-04-18 Thread Liang Ma
On Wed, Apr 07, 2021 at 10:43:36AM +0200, Thomas Monjalon wrote: > +Cc more people to start a discussion about a potential DMA API. > If you think it is interesting, we can start a fresh discussion thread. +1 that's ineresting to have a abstract layer of DMA offload engine. I would like join th

Re: [dpdk-dev] Question about enable CBDMA with ioat PMD ?

2021-04-18 Thread Liang Ma
On Wed, Apr 14, 2021 at 04:33:10PM +0100, Burakov, Anatoly wrote: > On 14-Apr-21 2:45 PM, Liang Ma wrote: > > On Wed, Apr 14, 2021 at 02:21:53PM +0100, Bruce Richardson wrote: > > > On Wed, Apr 14, 2021 at 01:52:14PM +0100, Liang Ma wrote: > > > > On Wed, Apr 14, 2

Re: [dpdk-dev] Question about enable CBDMA with ioat PMD ?

2021-04-14 Thread Liang Ma
On Wed, Apr 14, 2021 at 02:21:53PM +0100, Bruce Richardson wrote: > On Wed, Apr 14, 2021 at 01:52:14PM +0100, Liang Ma wrote: > > On Wed, Apr 14, 2021 at 11:48:03AM +0100, Bruce Richardson wrote: > > > On Wed, Apr 14, 2021 at 11:37:48AM +0100, Liang Ma wrote: > > > >

Re: [dpdk-dev] Question about enable CBDMA with ioat PMD ?

2021-04-14 Thread Liang Ma
On Wed, Apr 14, 2021 at 11:48:03AM +0100, Bruce Richardson wrote: > On Wed, Apr 14, 2021 at 11:37:48AM +0100, Liang Ma wrote: > > On Tue, Apr 13, 2021 at 07:24:41PM +0100, Bruce Richardson wrote: > > > On Tue, Apr 13, 2021 at 06:36:38PM +0100, Liang Ma wrote: > > > >

Re: [dpdk-dev] Question about enable CBDMA with ioat PMD ?

2021-04-14 Thread Liang Ma
On Tue, Apr 13, 2021 at 07:24:41PM +0100, Bruce Richardson wrote: > On Tue, Apr 13, 2021 at 06:36:38PM +0100, Liang Ma wrote: > > Hi Bruce, > >I look into current IOAT PMD. I found that looks only support the > >latest DSA device which is part of SPR(Please co

[dpdk-dev] Question about enable CBDMA with ioat PMD ?

2021-04-13 Thread Liang Ma
Hi Bruce, I look into current IOAT PMD. I found that looks only support the latest DSA device which is part of SPR(Please correct me if I'm wrong). However, there still is lots existing CPU that support previous CBDMA Intel Quick-DATA technology. SPDK enable those device with uio.

Re: [dpdk-dev] [PATCH v3 3/3] test/power: add delay before checking cpuinfo cur freq

2021-04-08 Thread Liang Ma
On Thu, Apr 08, 2021 at 05:16:34AM +, Richael Zhuang wrote: > Hi Liang, > Sorry that last email contains "confidential notice", so I resend it. > > -Original Message----- > > From: Liang Ma > > Sent: Wednesday, April 7, 2021 6:15 PM > > To: Richa

Re: [dpdk-dev] [PATCH] power: fix use-after-free in pstate code

2021-04-07 Thread Liang Ma
On Wed, Apr 07, 2021 at 05:53:48PM +0100, Burakov, Anatoly wrote: > On 07-Apr-21 5:31 PM, Burakov, Anatoly wrote: > > On 07-Apr-21 4:56 PM, Anatoly Burakov wrote: > > > Previous fix has addressed the incorrect handling of `base_frequency` > > > file, but has added a use-after-free error due to the

Re: [dpdk-dev] [PATCH] power: fix use-after-free in pstate code

2021-04-07 Thread Liang Ma
Reviewed-by: Liang Ma On Wed, Apr 07, 2021 at 03:56:42PM +, Anatoly Burakov wrote: > Previous fix has addressed the incorrect handling of `base_frequency` > file, but has added a use-after-free error due to the fact that all > further code paths will lead to an `fclose()` call at th

Re: [dpdk-dev] Questions about API with no parameter check

2021-04-07 Thread Liang Ma
On Wed, Apr 07, 2021 at 01:40:32PM +0200, Thomas Monjalon wrote: > 07/04/2021 13:28, Min Hu (Connor): > > Hi, all, > > Many APIs in DPDK does not check if the pointer parameter is > > NULL or not. For example, in 'rte_ethdev.c': > > int > > rte_eth_rx_queue_setup(uint16_t port_id, uint16_t rx_q

Re: [dpdk-dev] [PATCH v3 3/3] test/power: add delay before checking cpuinfo cur freq

2021-04-07 Thread Liang Ma
On Wed, Apr 07, 2021 at 03:46:36PM +0800, Richael Zhuang wrote: > Sleep for 1s before checking the newly updated value from > "/sys/devices/system/cpu/cpu%u/cpufreq/cpuinfo_cur_freq", because > for some systems it may not be effective immediately. > > Fixes: ed7c51a6a680 ("app/test: vm power manag

Re: [dpdk-dev] [PATCH] maintainer: email update maintainer

2021-04-07 Thread Liang Ma
On Tue, Apr 06, 2021 at 03:56:16PM +0200, Thomas Monjalon wrote: > 03/04/2021 12:35, Liang Ma: > > I would like to change my email to personal email address. > > > > Signed-off-by: Liang Ma > > Applied Hi Thomas, Many thanks. Regards Liang

Re: [dpdk-dev] vfio error

2021-04-05 Thread Liang Ma
On Sun, Apr 04, 2021 at 07:10:43PM +0430, hamidreza Kheirabadi wrote: > Hi, > I have a dpdk application which binds nic with igb_uio. My problem is > whenever the kernel updates, I must recompile igb_uio.ko as well. > I want to use vfio instead but I got an error: > > Error: bind failed for :0

[dpdk-dev] [PATCH] maintainer: email update maintainer

2021-04-03 Thread Liang Ma
I would like to change my email to personal email address. Signed-off-by: Liang Ma --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 0ec558854..bca79c52b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1237,7 +1237,7 @@ F: drivers

Re: [dpdk-dev] [PATCH] eal: fix incorrect API doc for power intrinsics

2020-11-03 Thread Liang, Ma
I to do said check. Fix the typo. > > Fixes: 128021421256 ("eal: add intrinsics support check infrastructure") > Cc: liang.j...@intel.com > > Signed-off-by: Anatoly Burakov Acked-by: Liang Ma > --- > lib/librte_eal/include/generic/rte_power_intrinsics.h | 6 +

[dpdk-dev] [PATCH v11 6/6] examples/l3fwd-power: enable PMD power mgmt

2020-11-02 Thread Liang Ma
Add PMD power management feature support to l3fwd-power sample app. Signed-off-by: Liang Ma Signed-off-by: Anatoly Burakov Acked-by: David Hunt --- Notes: v11: - Update l3fwd-power documentation v8: - Add return status check for queue enable v6: - Fixed typos in

[dpdk-dev] [PATCH v11 5/6] net/ice: implement power management API

2020-11-02 Thread Liang Ma
Implement support for the power management API by implementing a `get_wake_addr` function that will return an address of an RX ring's status bit. Signed-off-by: Liang Ma Signed-off-by: Anatoly Burakov Acked-by: Konstantin Ananyev --- drivers/net/ice/ice_ethdev.c | 1 + drivers/ne

[dpdk-dev] [PATCH v11 4/6] net/i40e: implement power management API

2020-11-02 Thread Liang Ma
Implement support for the power management API by implementing a `get_wake_addr` function that will return an address of an RX ring's status bit. Signed-off-by: Liang Ma Signed-off-by: Anatoly Burakov Acked-by: Konstantin Ananyev Acked-by: Jeff Guo --- drivers/net/i40e/i40e_ethdev.c

[dpdk-dev] [PATCH v11 2/6] power: add PMD power management API and callback

2020-11-02 Thread Liang Ma
scaling Reuse existing DPDK power library to scale up/down core frequency depending on traffic volume. Signed-off-by: Liang Ma Signed-off-by: Anatoly Burakov Acked-by: David Hunt Acked-by: Konstantin Ananyev --- Notes: v11: - Updated power library document - Updated release

[dpdk-dev] [PATCH v11 1/6] ethdev: add simple power management API

2020-11-02 Thread Liang Ma
Add a simple API to allow getting address of getting notification information from the PMD, as well as release notes information. Signed-off-by: Liang Ma Signed-off-by: Anatoly Burakov Acked-by: Konstantin Ananyev --- Notes: v11: - Rework the API Doxygen documentation v10

[dpdk-dev] [PATCH v11 3/6] net/ixgbe: implement power management API

2020-11-02 Thread Liang Ma
Implement support for the power management API by implementing a `get_wake_addr` function that will return an address of an RX ring's status bit. Signed-off-by: Anatoly Burakov Signed-off-by: Liang Ma Acked-by: Konstantin Ananyev --- drivers/net/ixgbe/ixgbe_ethdev.c | 1 + drivers/net/

[dpdk-dev] [PATCH v11 0/6] Add PMD power mgmt

2020-11-02 Thread Liang Ma
d to other device types Liang Ma (6): ethdev: add simple power management API power: add PMD power management API and callback net/ixgbe: implement power management API net/i40e: implement power management API net/ice: implement power management API examples/l3fwd-power: enable PMD power

Re: [dpdk-dev] [PATCH v10 0/9] Add PMD power mgmt

2020-10-30 Thread Liang, Ma
On 29 Oct 18:42, Thomas Monjalon wrote: > 27/10/2020 15:59, Liang Ma: > > Liang Ma (9): > > eal: add new x86 cpuid support for WAITPKG > > eal: add power management intrinsics > > eal: add intrinsics support check infrastructure > > EAL patches applied, tha

Re: [dpdk-dev] [PATCH v10 0/9] Add PMD power mgmt

2020-10-29 Thread Liang, Ma
On 28 Oct 09:54, McDaniel, Timothy wrote: > > > > > > > > > > > > > > > > > > It would be nice if the low level definition of the UMWAIT and UMONOTOR > instructions were split out > into their own inline function or macro so that any PMD could use the > intrinsic without being tied to ethdev or

Re: [dpdk-dev] [PATCH v10 0/9] Add PMD power mgmt

2020-10-28 Thread Liang, Ma
On 28 Oct 21:27, Jerin Jacob wrote: > On Wed, Oct 28, 2020 at 9:19 PM Ananyev, Konstantin > wrote: > > > > > > > 28/10/2020 14:49, Jerin Jacob: > > > > > > > > On Wed, Oct 28, 2020 at 7:05 PM Liang, Ma > > > > > > > >

Re: [dpdk-dev] [PATCH v10 0/9] Add PMD power mgmt

2020-10-28 Thread Liang, Ma
On 28 Oct 21:31, Jerin Jacob wrote: > On Wed, Oct 28, 2020 at 9:14 PM Liang, Ma wrote: > > > > On 28 Oct 21:06, Jerin Jacob wrote: > > > On Wed, Oct 28, 2020 at 9:00 PM Liang, Ma wrote: > > > > > > > > On 28 Oct 20:44, Jerin Jacob wrote: &

Re: [dpdk-dev] [PATCH v10 0/9] Add PMD power mgmt

2020-10-28 Thread Liang, Ma
On 28 Oct 21:06, Jerin Jacob wrote: > On Wed, Oct 28, 2020 at 9:00 PM Liang, Ma wrote: > > > > On 28 Oct 20:44, Jerin Jacob wrote: > > > On Wed, Oct 28, 2020 at 8:27 PM Ananyev, Konstantin > > > wrote: > > > > > > > > > > > >

Re: [dpdk-dev] [PATCH v10 0/9] Add PMD power mgmt

2020-10-28 Thread Liang, Ma
On 28 Oct 20:44, Jerin Jacob wrote: > On Wed, Oct 28, 2020 at 8:27 PM Ananyev, Konstantin > wrote: > > > > > > > > > 28/10/2020 14:49, Jerin Jacob: > > > > On Wed, Oct 28, 2020 at 7:05 PM Liang, Ma wrote: > > > > > > > > &

Re: [dpdk-dev] [PATCH v10 0/9] Add PMD power mgmt

2020-10-28 Thread Liang, Ma
Hi Thomas, I think I addressed all of the questions in relation to V9. I don't think I can solve the issue of a generic API on my own. From the Community Call last week Jerin also said that a generic was investigated but that a single solution wasn't feasible. This API is experimental and oth

Re: [dpdk-dev] [PATCH v9 04/10] ethdev: add simple power management API

2020-10-28 Thread Liang, Ma
com; shah...@nvidia.com; > > sthem...@microsoft.com; g.si...@nxp.com; rm...@marvell.com; > > maxime.coque...@redhat.com; david.march...@redhat.com > > Subject: Re: [dpdk-dev] [PATCH v9 04/10] ethdev: add simple power > > management API > > > > 27/10/2020 18:43, Ana

Re: [dpdk-dev] [PATCH v10 0/9] Add PMD power mgmt

2020-10-28 Thread Liang, Ma
On 27 Oct 13:53, Ajit Khaparde wrote: > On Tue, Oct 27, 2020 at 7:59 AM Liang Ma wrote: > > > > This patchset proposes a simple API for Ethernet drivers > > to cause the CPU to enter a power-optimized state while > > waiting for packets to arrive, along with a set of

[dpdk-dev] [PATCH v10 8/9] net/ice: implement power management API

2020-10-27 Thread Liang Ma
Implement support for the power management API by implementing a `get_wake_addr` function that will return an address of an RX ring's status bit. Signed-off-by: Liang Ma Signed-off-by: Anatoly Burakov Acked-by: Konstantin Ananyev --- drivers/net/ice/ice_ethdev.c | 1 + drivers/ne

[dpdk-dev] [PATCH v10 9/9] examples/l3fwd-power: enable PMD power mgmt

2020-10-27 Thread Liang Ma
Add PMD power management feature support to l3fwd-power sample app. Signed-off-by: Liang Ma Signed-off-by: Anatoly Burakov Acked-by: David Hunt --- Notes: v8: - Add return status check for queue enable v6: - Fixed typos in documentation --- .../sample_app_ug

[dpdk-dev] [PATCH v10 6/9] net/ixgbe: implement power management API

2020-10-27 Thread Liang Ma
Implement support for the power management API by implementing a `get_wake_addr` function that will return an address of an RX ring's status bit. Signed-off-by: Anatoly Burakov Signed-off-by: Liang Ma Acked-by: Konstantin Ananyev --- drivers/net/ixgbe/ixgbe_ethdev.c | 1 + drivers/net/

[dpdk-dev] [PATCH v10 7/9] net/i40e: implement power management API

2020-10-27 Thread Liang Ma
Implement support for the power management API by implementing a `get_wake_addr` function that will return an address of an RX ring's status bit. Signed-off-by: Liang Ma Signed-off-by: Anatoly Burakov Acked-by: Konstantin Ananyev Acked-by: Jeff Guo --- drivers/net/i40e/i40e_ethdev.c

[dpdk-dev] [PATCH v10 5/9] power: add PMD power management API and callback

2020-10-27 Thread Liang Ma
library to scale up/down core frequency depending on traffic volume. Signed-off-by: Liang Ma Signed-off-by: Anatoly Burakov Acked-by: David Hunt Acked-by: Konstantin Ananyev --- Notes: v10: - Updated power library document v8: - Rename version map file name v7: - Fixed

[dpdk-dev] [PATCH v10 4/9] ethdev: add simple power management API

2020-10-27 Thread Liang Ma
Add a simple API to allow getting address of next RX descriptor from the PMD, as well as release notes information. Signed-off-by: Liang Ma Signed-off-by: Anatoly Burakov Acked-by: Konstantin Ananyev --- Notes: v10: - Address minor issue on comments and release notes v8

[dpdk-dev] [PATCH v10 3/9] eal: add intrinsics support check infrastructure

2020-10-27 Thread Liang Ma
-by: Liang Ma Acked-by: David Christensen Acked-by: Jerin Jacob Acked-by: Ruifeng Wang Acked-by: Ray Kinsella -- Notes: v8: - Rename eal version.map v6: - Fix the comments --- lib/librte_eal/arm/rte_cpuflags.c | 6 + lib/librte_eal/include/generic/rte_cpuflags.h

[dpdk-dev] [PATCH v10 2/9] eal: add power management intrinsics

2020-10-27 Thread Liang Ma
happened, and no more writes are expected. For more details, please refer to Intel(R) 64 and IA-32 Architectures Software Developer's Manual, Volume 2. Signed-off-by: Liang Ma Signed-off-by: Anatoly Burakov Acked-by: David Christensen Acked-by: Jerin Jacob Acked-by: Konstantin Ananyev Ack

[dpdk-dev] [PATCH v10 1/9] eal: add new x86 cpuid support for WAITPKG

2020-10-27 Thread Liang Ma
Add a new CPUID flag indicating processor support for UMONITOR/UMWAIT and TPAUSE instructions instruction. Signed-off-by: Liang Ma Signed-off-by: Anatoly Burakov Acked-by: Konstantin Ananyev --- lib/librte_eal/x86/include/rte_cpuflags.h | 1 + lib/librte_eal/x86/rte_cpuflags.c | 2

[dpdk-dev] [PATCH v10 0/9] Add PMD power mgmt

2020-10-27 Thread Liang Ma
d to other device types Liang Ma (9): eal: add new x86 cpuid support for WAITPKG eal: add power management intrinsics eal: add intrinsics support check infrastructure ethdev: add simple power management API power: add PMD power management API and callback net/ixgbe: implement power management

Re: [dpdk-dev] [PATCH v9 04/10] ethdev: add simple power management API

2020-10-27 Thread Liang, Ma
thanks for your information. Sorry for that. All related maintainer(include other NIC PMD) will be Cced in v10. > You keep forgetting Cc ethdev maintainers > (it is automatic when using --cc-cmd devtools/get-maintainer.sh). > As a result we still don't have any feedback from Ferruh and Andrew.

Re: [dpdk-dev] [PATCH v9 10/10] doc: update programmer's guide for power library

2020-10-27 Thread Liang, Ma
Hi Thomas, all is fixed in v10. Regards Liang On 24 Oct 22:49, Thomas Monjalon wrote: > 24/10/2020 01:06, Liang Ma: > > Update programmer's guide to document PMD power management usage. > > > > Signed-off-by: Liang Ma > > Signed-off-by: Anatoly B

[dpdk-dev] [PATCH v9 08/10] net/ice: implement power management API

2020-10-23 Thread Liang Ma
Implement support for the power management API by implementing a `get_wake_addr` function that will return an address of an RX ring's status bit. Signed-off-by: Liang Ma Signed-off-by: Anatoly Burakov Acked-by: Konstantin Ananyev --- drivers/net/ice/ice_ethdev.c | 1 + drivers/ne

[dpdk-dev] [PATCH v9 09/10] examples/l3fwd-power: enable PMD power mgmt

2020-10-23 Thread Liang Ma
Add PMD power management feature support to l3fwd-power sample app. Signed-off-by: Liang Ma Signed-off-by: Anatoly Burakov Acked-by: David Hunt --- Notes: v8: - Add return status check for queue enable v6: - Fixed typos in documentation --- .../sample_app_ug

[dpdk-dev] [PATCH v9 10/10] doc: update programmer's guide for power library

2020-10-23 Thread Liang Ma
Update programmer's guide to document PMD power management usage. Signed-off-by: Liang Ma Signed-off-by: Anatoly Burakov Acked-by: David Hunt --- doc/guides/prog_guide/power_man.rst | 42 + 1 file changed, 42 insertions(+) diff --git a/doc/guides/prog_

[dpdk-dev] [PATCH v9 07/10] net/i40e: implement power management API

2020-10-23 Thread Liang Ma
Implement support for the power management API by implementing a `get_wake_addr` function that will return an address of an RX ring's status bit. Signed-off-by: Liang Ma Signed-off-by: Anatoly Burakov Acked-by: Konstantin Ananyev Acked-by: Jeff Guo --- drivers/net/i40e/i40e_ethdev.c

[dpdk-dev] [PATCH v9 06/10] net/ixgbe: implement power management API

2020-10-23 Thread Liang Ma
Implement support for the power management API by implementing a `get_wake_addr` function that will return an address of an RX ring's status bit. Signed-off-by: Anatoly Burakov Signed-off-by: Liang Ma Acked-by: Konstantin Ananyev --- drivers/net/ixgbe/ixgbe_ethdev.c | 1 + drivers/net/

[dpdk-dev] [PATCH v9 04/10] ethdev: add simple power management API

2020-10-23 Thread Liang Ma
Add a simple API to allow getting address of next RX descriptor from the PMD, as well as release notes information. Signed-off-by: Liang Ma Signed-off-by: Anatoly Burakov Acked-by: Konstantin Ananyev --- Notes: v8: - Rename version map file name. v7: - Fixed queue ID

[dpdk-dev] [PATCH v9 03/10] eal: add intrinsics support check infrastructure

2020-10-23 Thread Liang Ma
-by: Liang Ma Acked-by: David Christensen Acked-by: Jerin Jacob Acked-by: Ruifeng Wang Acked-by: Ray Kinsella --- Notes: v6: - Fix the comments v8: - Rename eal version.map --- lib/librte_eal/arm/rte_cpuflags.c | 6 + lib/librte_eal/include/generic

[dpdk-dev] [PATCH v9 05/10] power: add PMD power management API and callback

2020-10-23 Thread Liang Ma
library to scale up/down core frequency depending on traffic volume. Signed-off-by: Liang Ma Signed-off-by: Anatoly Burakov Acked-by: David Hunt Acked-by: Konstantin Ananyev --- Notes: v8: - Rename version map file name v7: - Fixed race condition (Konstantin) - Slight

[dpdk-dev] [PATCH v9 02/10] eal: add power management intrinsics

2020-10-23 Thread Liang Ma
happened, and no more writes are expected. For more details, please refer to Intel(R) 64 and IA-32 Architectures Software Developer's Manual, Volume 2. Signed-off-by: Liang Ma Signed-off-by: Anatoly Burakov Acked-by: David Christensen Acked-by: Jerin Jacob Acked-by: Konstantin Ananyev Ack

[dpdk-dev] [PATCH v9 00/10] Add PMD power mgmt

2020-10-23 Thread Liang Ma
d to other device types Liang Ma (10): eal: add new x86 cpuid support for WAITPKG eal: add power management intrinsics eal: add intrinsics support check infrastructure ethdev: add simple power management API power: add PMD power management API and callback net/ixgbe: implement power mana

[dpdk-dev] [PATCH v9 01/10] eal: add new x86 cpuid support for WAITPKG

2020-10-23 Thread Liang Ma
Add a new CPUID flag indicating processor support for UMONITOR/UMWAIT and TPAUSE instructions instruction. Signed-off-by: Liang Ma Signed-off-by: Anatoly Burakov Acked-by: Konstantin Ananyev --- lib/librte_eal/x86/include/rte_cpuflags.h | 1 + lib/librte_eal/x86/rte_cpuflags.c | 2

[dpdk-dev] [PATCH v8 10/10] doc: update programmer's guide for power library

2020-10-23 Thread Liang Ma
Update programmer's guide to document PMD power management usage. Signed-off-by: Liang Ma Signed-off-by: Anatoly Burakov Acked-by: David Hunt --- doc/guides/prog_guide/power_man.rst | 42 + 1 file changed, 42 insertions(+) diff --git a/doc/guides/prog_

[dpdk-dev] [PATCH v8 09/10] examples/l3fwd-power: enable PMD power mgmt

2020-10-23 Thread Liang Ma
Add PMD power management feature support to l3fwd-power sample app. Signed-off-by: Liang Ma Signed-off-by: Anatoly Burakov Acked-by: David Hunt --- Notes: v8: - Add return status check for queue enable v6: - Fixed typos in documentation --- .../sample_app_ug

[dpdk-dev] [PATCH v8 08/10] net/ice: implement power management API

2020-10-23 Thread Liang Ma
Implement support for the power management API by implementing a `get_wake_addr` function that will return an address of an RX ring's status bit. Signed-off-by: Liang Ma Signed-off-by: Anatoly Burakov Acked-by: Konstantin Ananyev --- drivers/net/ice/ice_ethdev.c | 1 + drivers/ne

[dpdk-dev] [PATCH v8 07/10] net/i40e: implement power management API

2020-10-23 Thread Liang Ma
Implement support for the power management API by implementing a `get_wake_addr` function that will return an address of an RX ring's status bit. Signed-off-by: Liang Ma Signed-off-by: Anatoly Burakov Acked-by: Konstantin Ananyev Acked-by: Jeff Guo --- drivers/net/i40e/i40e_ethdev.c

[dpdk-dev] [PATCH v8 06/10] net/ixgbe: implement power management API

2020-10-23 Thread Liang Ma
Implement support for the power management API by implementing a `get_wake_addr` function that will return an address of an RX ring's status bit. Signed-off-by: Anatoly Burakov Signed-off-by: Liang Ma Acked-by: Konstantin Ananyev --- drivers/net/ixgbe/ixgbe_ethdev.c | 1 + drivers/net/

[dpdk-dev] [PATCH v8 05/10] power: add PMD power management API and callback

2020-10-23 Thread Liang Ma
library to scale up/down core frequency depending on traffic volume. Signed-off-by: Liang Ma Signed-off-by: Anatoly Burakov Acked-by: David Hunt Acked-by: Konstantin Ananyev --- Notes: v8: - Rename version map file name v7: - Fixed race condition (Konstantin) - Slight

[dpdk-dev] [PATCH v8 04/10] ethdev: add simple power management API

2020-10-23 Thread Liang Ma
Add a simple API to allow getting address of next RX descriptor from the PMD, as well as release notes information. Signed-off-by: Liang Ma Signed-off-by: Anatoly Burakov Acked-by: Konstantin Ananyev --- Notes: v8: - Rename version map file name. v7: - Fixed queue ID

[dpdk-dev] [PATCH v8 03/10] eal: add intrinsics support check infrastructure

2020-10-23 Thread Liang Ma
-by: Liang Ma Acked-by: David Christensen Acked-by: Jerin Jacob Acked-by: Ruifeng Wang Acked-by: Ray Kinsella --- Notes: v6: - Fix the comments v8: - Rename eal version.map --- lib/librte_eal/arm/rte_cpuflags.c | 6 + lib/librte_eal/include/generic

[dpdk-dev] [PATCH v8 02/10] eal: add power management intrinsics

2020-10-23 Thread Liang Ma
happened, and no more writes are expected. For more details, please refer to Intel(R) 64 and IA-32 Architectures Software Developer's Manual, Volume 2. Signed-off-by: Liang Ma Signed-off-by: Anatoly Burakov Acked-by: David Christensen Acked-by: Jerin Jacob Acked-by: Konstantin Ananyev Ack

[dpdk-dev] [PATCH v8 01/10] eal: add new x86 cpuid support for WAITPKG

2020-10-23 Thread Liang Ma
Add a new CPUID flag indicating processor support for UMONITOR/UMWAIT and TPAUSE instructions instruction. Signed-off-by: Liang Ma Signed-off-by: Anatoly Burakov Acked-by: Konstantin Ananyev --- lib/librte_eal/x86/include/rte_cpuflags.h | 1 + lib/librte_eal/x86/rte_cpuflags.c | 2

Re: [dpdk-dev] [PATCH v6 04/10] ethdev: add simple power management API

2020-10-15 Thread Liang, Ma
On 14 Oct 14:30, Anatoly Burakov wrote: > From: Liang Ma > > Add a simple API to allow getting address of next RX descriptor from the > PMD, as well as release notes information. > > Signed-off-by: Liang Ma > Signed-off-by: Anatoly Burakov > Acked-by: Konstantin Anan

  1   2   3   >