#Configuration-Files)
that to me is more readable and user-friendly than JSON (not to mention
XML).
* As you, Thomas say, and as it has been discussed previously [1]; it would
be good that eal_init was not depending on argv and had a _simple_, and
with reasonable defaults, struct-based init API, a
2016-04-07 13:51 GMT+02:00 Panu Matilainen :
> [ change of subject since this is about ABI policy, not namespacing ]
>
> On 04/07/2016 01:16 PM, Marc Sune wrote:
>
>>
>>
>> 2016-04-07 11:33 GMT+02:00 Panu Matilainen > <mailto:pmatilai at redhat.com>>
rted stuff, yes of course we can make trees
> and
> branches for this, they are basically free in Git. But at that point
> community
> people in need of LTS forks of features need to step up to the plate to
> help
> out.
>
Completely agree.
Marc
>
> Matthew.
>
e
> unused=igb_uio,uio_pci_generic
> :81:00.1 'Ethernet Controller 10-Gigabit X540-AT2' if=eth5 drv=ixgbe
> unused=igb_uio,uio_pci_generic
>
> Other network devices
> ===
break (example: mempool).
>>>
>>
>> The slow change has been clearly rejected in favor of a complete change
>> in one patch.
>> The timing was also discussed as it could impact the pending patches.
>> So it would be done at the end or the beginning of a release.
s a list of #defines for the
> old symbols pointing them at the new symbols? That would also allow
> people with old applications to update DPDK without having to modify
> their applications.
>
You would also have to add all typedefs for type names.
Why bothering? Moving from 2.2 to 1
From: Thomas Monjalon <thomas.monja...@6wind.com>
The link speed configuration is now done with bitmaps so 100G speed
requires only a new bit flag.
The actual link speed is a number so its size must be increased from
16-bit to 32-bit.
Signed-off-by: Marc Sune
Signed-off-by: Thomas Mo
It is a helper for the bitmap configuration.
Signed-off-by: Marc Sune
Signed-off-by: Thomas Monjalon
---
lib/librte_ether/rte_ethdev.c | 31 +++
lib/librte_ether/rte_ethdev.h | 13 +
lib/librte_ether/rte_ether_version.map | 1 +
3
autoneg in struct rte_eth_link indicates if link speed was a
result of auto-negociation or was fixed by configuration.
Signed-off-by: Marc Sune
Tested-by: Nelio Laranjeiro
Signed-off-by: Thomas Monjalon
---
app/test-pmd/cmdline.c| 26
doc/guides/rel_notes
The speed numbers ETH_LINK_SPEED_ are renamed ETH_SPEED_NUM_.
The prefix ETH_LINK_SPEED_ is kept for AUTONEG and will be used
for bit flags in next patch.
Signed-off-by: Marc Sune
---
app/test-pmd/cmdline.c| 10 +-
app/test/virtual_pmd.c| 2
The code for checking and parsing speed/duplex was duplicated.
The new function is also checking the speed/duplex combination.
Signed-off-by: Marc Sune
---
app/test-pmd/cmdline.c | 99 --
1 file changed, 47 insertions(+), 52 deletions(-)
diff
Some duplex values are replaced from 0 to half-duplex when link is down.
Some drivers are still using their own constants for duplex modes.
Signed-off-by: Marc Sune
---
drivers/net/e1000/em_ethdev.c | 2 +-
drivers/net/e1000/igb_ethdev.c | 2 +-
drivers/net/ixgbe/ixgbe_ethdev.c | 2
From: Thomas Monjalon <thomas.monja...@6wind.com>
Define and use ETH_LINK_UP and ETH_LINK_DOWN where appropriate.
Signed-off-by: Marc Sune
Signed-off-by: Thomas Monjalon
---
app/test-pipeline/init.c | 2 +-
app/test-pmd/tes
From: Marc Sune <m...@voltanet.io>
This series of patches adds the following capabilities:
* speed_capa bitmap in rte_eth_dev_info, which is filled by the PMDs
according to the physical device capabilities.
* refactors link API in ethdev to allow the definition of the advertised
link
On 29 March 2016 at 15:31, Alejandro Lucero
wrote:
> For nfp.c, speed_capa should be ETH_LINK_SPEED_40G instead of
> ETH_LINK_SPEED_50G.
> By the way, the change in patch 4 sets the right link speed using the new
> constants.
>
> Regards
>
Noted for v14, thanks
Marc
>
On 29 March 2016 at 03:19, Lu, Wenzhuo wrote:
> Hi Marc,
>
>
>
> *From:* marc.sune at gmail.com [mailto:marc.sune at gmail.com] *On Behalf Of *
> Marc
> *Sent:* Monday, March 28, 2016 7:03 PM
> *To:* Lu, Wenzhuo
> *Cc:* dev at dpdk.org
> *Subject:* Re: e1000: rando
On 29 March 2016 at 08:18, Xing, Beilei wrote:
>
>
> > -Original Message-
> > From: Marc Sune [mailto:marcdevel at gmail.com]
> > Sent: Saturday, March 26, 2016 9:27 AM
> > To: Thomas Monjalon ; Xu, Qian Q
> > ; Xing, Beilei ;
> dev at dpdk.org
On 28 March 2016 at 15:42, Thomas Monjalon
wrote:
> Hi Marc,
>
> 2016-03-27 21:39, Marc:
> > On 27 March 2016 at 11:53, Thomas Monjalon
> > wrote:
> > > 2016-03-26 11:24, Marc:
> > > > On 26 March 2016 at 09:08, Thomas Monjalon <
> thomas.monjalo
On 28 March 2016 at 03:54, Lu, Wenzhuo wrote:
> Hi Marc
>
>
>
> *From:* Marc Sune [mailto:marcdevel at gmail.com]
> *Sent:* Saturday, March 26, 2016 9:43 AM
> *To:* dev at dpdk.org; Lu, Wenzhuo
> *Subject:* e1000: randomly loosing link change events triggered by th
On 27 March 2016 at 11:53, Thomas Monjalon
wrote:
> 2016-03-26 11:24, Marc:
> > On 26 March 2016 at 09:08, Thomas Monjalon
> > wrote:
> > > 2016-03-25 22:30, Marc:
> > > > From v9 to v10 patchset the values ETH_LINK_SPEED_AUTONEG and
> > > ETH_LINK_S
On 26 March 2016 at 09:08, Thomas Monjalon
wrote:
> Hi Marc,
>
> Thanks for finding time to help.
>
> 2016-03-25 22:30, Marc:
> > From v9 to v10 patchset the values ETH_LINK_SPEED_AUTONEG and
> ETH_LINK_SPEED_FIXED were flipped. Reverting this makes it work:
> >
changing the duplex mode.
However, when one or more link change events have been lost and the phy
medium is disconnected and reconnected, the link speed and duplex mode are
then correctly updated.
Marc
From: Thomas Monjalon <thomas.monja...@6wind.com>
The link speed configuration is now done with bitmaps so 100G speed
requires only a new bit flag.
The actual link speed is a number so its size must be increased from
16-bit to 32-bit.
Signed-off-by: Marc Sune
Signed-off-by: Thomas Mo
It is a helper for the bitmap configuration.
Signed-off-by: Marc Sune
Signed-off-by: Thomas Monjalon
---
lib/librte_ether/rte_ethdev.c | 31 +++
lib/librte_ether/rte_ethdev.h | 13 +
lib/librte_ether/rte_ether_version.map | 1 +
3
autoneg in struct rte_eth_link indicates if link speed was a
result of auto-negociation or was fixed by configuration.
Signed-off-by: Marc Sune
Tested-by: Nelio Laranjeiro
Signed-off-by: Thomas Monjalon
---
app/test-pmd/cmdline.c| 26
doc/guides/rel_notes
-off-by: Marc Sune
---
doc/guides/nics/overview.rst | 1 +
doc/guides/rel_notes/release_16_04.rst | 8
drivers/net/bnx2x/bnx2x_ethdev.c | 1 +
drivers/net/cxgbe/cxgbe_ethdev.c | 1 +
drivers/net/e1000/em_ethdev.c | 4
drivers/net/e1000/igb_ethdev.c
The speed numbers ETH_LINK_SPEED_ are renamed ETH_SPEED_NUM_.
The prefix ETH_LINK_SPEED_ is kept for AUTONEG and will be used
for bit flags in next patch.
Signed-off-by: Marc Sune
---
app/test-pmd/cmdline.c| 10 +-
app/test/virtual_pmd.c| 2
The code for checking and parsing speed/duplex was duplicated.
The new function is also checking the speed/duplex combination.
Signed-off-by: Marc Sune
---
app/test-pmd/cmdline.c | 99 --
1 file changed, 47 insertions(+), 52 deletions(-)
diff
Some duplex values are replaced from 0 to half-duplex when link is down.
Some drivers are still using their own constants for duplex modes.
Signed-off-by: Marc Sune
---
drivers/net/e1000/em_ethdev.c | 2 +-
drivers/net/e1000/igb_ethdev.c | 2 +-
drivers/net/ixgbe/ixgbe_ethdev.c | 2
From: Thomas Monjalon <thomas.monja...@6wind.com>
Define and use ETH_LINK_UP and ETH_LINK_DOWN where appropriate.
Signed-off-by: Marc Sune
Signed-off-by: Thomas Monjalon
---
app/test-pipeline/init.c | 2 +-
app/test-pmd/tes
d M. Brorup. Fixed spelling
issues.
v2: rebase, converted speed_capa into 32 bits bitmap, fixed alignment
(checkpatch).
Marc Sune (6):
ethdev: use constants for link duplex
app/testpmd: move speed and duplex parsing in a function
ethdev: rename link speed constants
ethdev: add sp
On 25 March 2016 at 22:30, Marc wrote:
>
>
> On 25 March 2016 at 21:41, Marc wrote:
>
>>
>> On 25 March 2016 at 16:07, Zhang, Helin wrote:
>>
>>> Hi Thomas
>>>
>>> Beilei is investigating that, she will give her findings soon later,
On 25 March 2016 at 21:41, Marc wrote:
>
> On 25 March 2016 at 16:07, Zhang, Helin wrote:
>
>> Hi Thomas
>>
>> Beilei is investigating that, she will give her findings soon later, and
>> possibly a fix after validating that.
>> Thanks!
>>
>
st patchsets, but i40 (XL710) and igb (82540EM) were working on
my side for previous versions. Which exact NICs were used to test the
patchset for igb?
Marc
> Regards,
> Helin
>
> > -Original Message-
> > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com
y, such as VHOST_USER_SET_MEM_TABLE. Thus,
> we introduced vhost_user_one_time_request() to avoid such case.
I am not familiar with multi-queue, but I can see that in vhost_net_start.
> So, good question, and we may need add it to the "one time request"
> group, Marc?
That wo
On 24 March 2016 at 07:21, Xu, Qian Q wrote:
> Marc
>
> I didn?t quite get your points, I observed that after applying this
> patchset, all intel nic can?t be started, maybe something wrong happened
> when you check the duplex/autoneg value for different NICs. If we want to
>
e enabled on this txq.
> PMD: i40e_dev_rx_queue_setup(): Rx Burst Bulk Alloc Preconditions are
> satisfied. Rx Burst Bulk Alloc function will be used on port=1, queue=0.
> PMD: i40e_dev_start(): Invalid link_speeds for port 1; autonegotiation
> disabled
>
Just to double-check; is the test#
On 10 March 2016 at 19:23, Thomas Monjalon
wrote:
> 2016-03-03 00:34, Marc Sune:
> > RTE_PMD_DEBUG_TRACE used RTE_FUNC_PTR_OR_ERR_RET was redefined
> > in rte_cryptodev_pmd.h which produced MACRO redefinition warnings
> > when including both rte_cryptodev_p
On 9 March 2016 at 11:09, N?lio Laranjeiro
wrote:
> On Wed, Mar 09, 2016 at 10:29:38AM +0100, N?lio Laranjeiro wrote:
> > On Tue, Mar 08, 2016 at 05:53:05PM +0100, N?lio Laranjeiro wrote:
> > > On Tue, Mar 08, 2016 at 04:00:29PM +0100, Marc Sune wrote:
> > > > 2016-
On 9 March 2016 at 09:45, N?lio Laranjeiro
wrote:
> Hi Marc,
>
> A small remark bellow.
>
> On Tue, Mar 01, 2016 at 01:45:50AM +0100, Marc Sune wrote:
> > This patch redesigns the API to set the link speed/s configure
> > for an ethernet port. Specifically:
> >
2016-03-01 1:45 GMT+01:00 Marc Sune :
> The current rte_eth_dev_info abstraction does not provide any mechanism to
> get the supported speed(s) of an ethdev.
>
> For some drivers (e.g. ixgbe), an educated guess could be done based on the
> driver's name (driver_name in rte_eth
cmdline_parse_*.h headers use struct cmdline_token_hdr /
cmdline_parse_token_hdr_t which is defined in cmdline_parse.h, but
do not include it, forcing manual inclusion.
This commit includes cmdline_parse.h in all cmdline_parse_*.h.
---
lib/librte_cmdline/cmdline_parse_etheraddr.h | 2 ++
RTE_PMD_DEBUG_TRACE used RTE_FUNC_PTR_OR_ERR_RET was redefined
in rte_cryptodev_pmd.h which produced MACRO redefinition warnings
when including both rte_cryptodev_pmd.h and rte_ethdev.h.
This commit moves MACRO definition to rte_cryptodev.c to prevent
this warning.
---
Add new features, ABI changes and resolved issues notice for
the refactored link patch.
Signed-off-by: Marc Sune
---
doc/guides/nics/overview.rst | 1 +
doc/guides/rel_notes/release_16_04.rst | 27 +++
2 files changed, 28 insertions(+)
diff --git a/doc/guides
or was fixed
by configuration.
* Added utility function to convert numeric speeds to bitmap
fields.
* Added rte_eth_speed_to_bm_flag() to version map.
Signed-off-by: Marc Sune
---
app/test-pipeline/init.c | 2 +-
app/test-pmd/cmdline.c| 124
Added speed capabilities to all pmds supporting physical NICs:
* e1000
* ixgbe
* i40
* bnx2x
* cxgbe
* mlx4
* mlx5
* nfp
* fm10k
Signed-off-by: Marc Sune
---
drivers/net/bnx2x/bnx2x_ethdev.c | 1 +
drivers/net/cxgbe/cxgbe_ethdev.c | 1 +
drivers/net/e1000/em_ethdev.c| 6 ++
drivers
Added constants and bitmap to struct rte_eth_dev_info to be used by PMDs.
Signed-off-by: Marc Sune
---
lib/librte_ether/rte_ethdev.h | 24
1 file changed, 24 insertions(+)
diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
index 16da821..83ddbb7
HEAD. Reverted numeric speed to 32 bit in struct
rte_eth_link (no atomic link get > 64bit). Fixed mlx5 driver compilation
and link speeds. Moved documentation to release_16_04.rst and fixed several
issues. Upgrade NIC notes with speed capabilities.
Marc Sune (4):
ethdev: Ad
On 18 February 2016 at 19:14, Mcnamara, John
wrote:
> Hi,
>
> Some minor comments below in order to get a consistent set of release
> notes.
>
> > -Original Message-
> > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Marc Sune
> > Sent: S
;
> When it happens to me I am using a Skylake Core i7-6700K.
>
Broadwell qemu emulated.
Marc
>
> Matthew.
>
Matej,
On 16 February 2016 at 11:28, Matej Vido wrote:
> D?a 14.02.2016 o 23:17 Marc Sune nap?sal(a):
>
>> This patch redesigns the API to set the link speed/s configure
>> for an ethernet port. Specifically:
>>
>> - it allows to define a set of advertised spe
> #endif
>
> int
> main(int argc, char **argv)
> {
> RTE_LOG(NOTICE, USER1, "function %s\n", __func__);
> return 0;
> }
>
>
I don't know what you have in mind for the test, but with this file you can
only detect things like using reserved keywords of C++ in DPDK headers and
things like that. It will not detect linking issues (fundamentally missing
extern "C" in function declarations), which happen from time to time,
specially with new headers.
We would need to compile a .cc/.cpp file including all these headers and
link against all the functions on those headers, similarly to what autoconf
does to test libs. I could help on that for 2.4.
Marc
On 16 February 2016 at 12:49, Mcnamara, John
wrote:
>
>
> > -Original Message-
> > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Marc
> > Sent: Sunday, February 14, 2016 10:21 PM
> > To: dev at dpdk.org
> > Subject: [dpdk-dev] x86_64-nati
Rahul, Neilo, Jing D, et al
On 15 February 2016 at 15:43, Rahul Lakkireddy wrote:
> Hi Marc,
>
> On Sunday, February 02/14/16, 2016 at 23:17:37 +0100, Marc Sune wrote:
> > Added speed capabilities to all pmds supporting physical NICs:
> >
> > * e1000
> &
On 15 February 2016 at 09:46, N?lio Laranjeiro
wrote:
> On Sun, Feb 14, 2016 at 11:17:38PM +0100, Marc Sune wrote:
> > This patch redesigns the API to set the link speed/s configure
> > for an ethernet port. Specifically:
> >
> > - it allows to define a set of adver
It seems compilation for clang Linux target is broken:
In file included from
/home/marc/dpdk/lib/librte_eal/linuxapp/eal/eal_pci.c:42:
/home/marc/dpdk/x86_64-native-linuxapp-clang/include/rte_memcpy.h:870:2:
error: implicit declaration of function '_mm_alignr_epi8' is invalid in C99
Add new features, ABI changes and resolved issues notice for
the refactored link patch.
Signed-off-by: Marc Sune
---
doc/guides/rel_notes/release_2_3.rst | 102 +++
1 file changed, 102 insertions(+)
create mode 100644 doc/guides/rel_notes/release_2_3.rst
diff
or was fixed
by configuration.
* Added utility function to convert numeric speeds to bitmap
fields.
* Added rte_eth_speed_to_bm_flag() to version map.
Signed-off-by: Marc Sune
---
app/test-pipeline/init.c | 2 +-
app/test-pmd/cmdline.c| 124
Added constants and bitmap to struct rte_eth_dev_info to be used by PMDs.
Signed-off-by: Marc Sune
---
lib/librte_ether/rte_ethdev.h | 24
1 file changed, 24 insertions(+)
diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
index 16da821..83ddbb7
to current HEAD. Modified em driver impl. to not touch base files.
Merged patch 5 into 3 (map file). Changed numeric speed to a 64 bit value.
Filled-in speed capabilities for drivers bnx2x, cxgbe, mlx5 and nfp in
addition to the ones of previous patch sets.
Marc Sune (4):
ethdev
On 11 February 2016 at 16:27, N?lio Laranjeiro
wrote:
> On Tue, Feb 02, 2016 at 11:30:59PM +0100, Marc wrote:
> > On 2 February 2016 at 03:20, Stephen Hemminger <
> stephen at networkplumber.org>
> > wrote:
> >
> > > On Thu, 28 Jan 2016 1
think is enough for future rates in mbps.
Since these constants were there, and before doing something to have to
revert it, can someone else give his/her opinion on this?
If there is consensus, I've no problem on removing it for v8
Thanks
marc
On 1 February 2016 at 01:40, Zhang, Helin wrote:
>
>
> > -Original Message-
> > From: Ananyev, Konstantin
> > Sent: Friday, January 29, 2016 6:18 PM
> > To: Thomas Monjalon
> > Cc: dev at dpdk.org; Marc Sune; Lu, Wenzhuo; Zhang, Helin; Harish Patil
On 29 January 2016 at 17:16, N?lio Laranjeiro
wrote:
> Hi Marc,
>
> On Fri, Jan 29, 2016 at 01:42:05AM +0100, Marc Sune wrote:
> >[...]
> > /**
> > - * Device supported speeds
> > - */
> > -#define ETH_SPEED_CAP_NOT_PHY(0) /*< No phy media >
On 29 January 2016 at 14:05, Panu Matilainen wrote:
> On 01/29/2016 02:42 AM, Marc Sune wrote:
>
>> Added rte_eth_speed_to_bm_flag() to DPDK2.2 version map.
>>
>> Signed-off-by: Marc Sune
>> ---
>> lib/librte_ether/rte_ether_version.map | 6
On 29 January 2016 at 11:17, Ananyev, Konstantin <
konstantin.ananyev at intel.com> wrote:
>
>
> > -Original Message-
> > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> > Sent: Friday, January 29, 2016 9:54 AM
> > To: Ananyev, Konstanti
Added rte_eth_speed_to_bm_flag() to DPDK2.2 version map.
Signed-off-by: Marc Sune
---
lib/librte_ether/rte_ether_version.map | 6 ++
1 file changed, 6 insertions(+)
diff --git a/lib/librte_ether/rte_ether_version.map
b/lib/librte_ether/rte_ether_version.map
index d8db24d..2c14ad7 100644
Add new features, ABI changes and resolved issues notice for
the refactored link patch.
Signed-off-by: Marc Sune
---
doc/guides/rel_notes/release_2_3.rst | 26 ++
1 file changed, 26 insertions(+)
diff --git a/doc/guides/rel_notes/release_2_3.rst
b/doc/guides/rel_notes
by configuration.
* Added utility function to convert numeric speeds to bitmap
fields.
Signed-off-by: Marc Sune
---
app/test-pmd/cmdline.c | 124 +++--
app/test/virtual_pmd.c | 4 +-
drivers/net/af_packet/rte_eth_af_packet.c
Added speed capabilities to all pmds supporting physical NICs:
* e1000
* ixgbe
* i40
* mlx4
* fm10k
Signed-off-by: Marc Sune
---
drivers/net/e1000/em_ethdev.c| 6 ++
drivers/net/e1000/igb_ethdev.c | 6 ++
drivers/net/fm10k/fm10k_ethdev.c | 4
drivers/net/i40e
Added constants and bitmap to struct rte_eth_dev_info to be used by PMDs.
Signed-off-by: Marc Sune
---
lib/librte_ether/rte_ethdev.h | 24
1 file changed, 24 insertions(+)
diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
index 8710dd7..dbc1599
link_duplex to be part of bitfield. Fixed i40 autoneg flag link
update code. Added rte_eth_speed_to_bm_flag() to .map file. Fixed other
spelling issues. Rebased to current HEAD.
v7: Rebased to current HEAD. Moved documentation to v2.3. Still needs testing
from PMD maintainers.
Marc Sune
2015-10-25 22:59 GMT+01:00 Marc Sune :
> The current rte_eth_dev_info abstraction does not provide any mechanism to
> get the supported speed(s) of an ethdev.
>
> For some drivers (e.g. ixgbe), an educated guess could be done based on the
> driver's name (driver_name in rte_eth
the mix?
>
> Can we make use of the fact that make config creates a directory called
> "build"
> by default. Then running "make" alone in that directory does the expected
> behaviour of a compile of the whole sdk. How about having "make install"
> in the
> build directory behave like a generic "make install" call for other
> packages?
>
> I'm imagining the following sequence of steps to install:
>
> ./configure --machine=[default|native|other]
> # configure is a simple script that just calls "make
> config T=..."
> cd build
>
Why not the inverse, configure in the folder where you build so that you
have all the compilation environment in the target folder (as in
autoconf+automake and as of now in DPDK). You can have easily parallel
builds in different folders.
> make
> make install
>
If you want this workflow, why not directly using autoconf + maybe the
config file there is now (since there are a ton of parameters)? Putting
general configuration parameters into configure.ac and leave the rest to
the config files.
The PREFIX and installation of files is something that automake+autoconf
solves too (probably without libtool for DPDK).
In any case, for install-fhs, I would name it install-all, to make it
consistent with typical autotools build envs, which is what users are used
to.
Marc
> Thoughts?
>
> /Bruce
>
Hi Thomas,
2015-11-01 23:11 GMT+01:00 Thomas Monjalon :
> 2015-10-25 22:59, Marc Sune:
> > +#define ETH_SPEED_CAP_NOT_PHY(0) /*< No phy media > */
> > +#define ETH_SPEED_CAP_10M_HD (1 << 0) /*< 10 Mbps half-duplex> */
> > +#define ETH_SPEED_CAP_1
Hi Thomas,
2015-11-01 23:16 GMT+01:00 Thomas Monjalon :
> 2015-10-25 22:59, Marc Sune:
> > This patch redesigns the API to set the link speed/s configure
> > for an ethernet port. Specifically:
> >
> > - it allows to define a set of advertised speeds for
> >
While testing this patch with some XL710, it seems even with current HEAD,
setting link speed into dev_conf to 10G does not work, it always takes
autoneg with all speeds.
Besides, this patch in particular should be tested for the rest of drivers
which I don't have HW for.
Regards
marc
2015-10
Added rte_eth_speed_to_bm_flag() to DPDK2.2 version map.
Signed-off-by: Marc Sune
---
lib/librte_ether/rte_ether_version.map | 6 ++
1 file changed, 6 insertions(+)
diff --git a/lib/librte_ether/rte_ether_version.map
b/lib/librte_ether/rte_ether_version.map
index 8345a6c..cbfe0c8 100644
Add new features, ABI changes and resolved issues notice for
the refactored link patch.
Signed-off-by: Marc Sune
---
doc/guides/rel_notes/release_2_2.rst | 23 +++
1 file changed, 23 insertions(+)
diff --git a/doc/guides/rel_notes/release_2_2.rst
b/doc/guides/rel_notes
by configuration.
* Added utility function to convert numeric speeds to bitmap
fields.
Signed-off-by: Marc Sune
---
app/test-pmd/cmdline.c | 124 +++--
app/test/virtual_pmd.c | 4 +-
drivers/net/af_packet/rte_eth_af_packet.c
Added speed capabilities to all pmds supporting physical NICs:
* e1000
* ixgbe
* i40
* mlx4
* fm10k
Signed-off-by: Marc Sune
---
drivers/net/e1000/em_ethdev.c| 6 ++
drivers/net/e1000/igb_ethdev.c | 6 ++
drivers/net/fm10k/fm10k_ethdev.c | 3 +++
drivers/net/i40e/i40e_ethdev.c
Added constants and bitmap to struct rte_eth_dev_info to be used by PMDs.
Signed-off-by: Marc Sune
---
lib/librte_ether/rte_ethdev.h | 24
1 file changed, 24 insertions(+)
diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
index 8a8c82b..951a423
of bitfield. Fixed i40 autoneg flag link
update code. Added rte_eth_speed_to_bm_flag() to .map file. Fixed other
spelling issues. Rebased to current HEAD.
Marc Sune (5):
ethdev: Added ETH_SPEED_CAP bitmap for ports
ethdev: Fill speed capability bitmaps in the PMDs
ethdev: redesign link speed
During the revision of an application I maintain that is currently using
DPDK v1.7.1 and about to port it to 2.1.0, I realised that 2.1.0rc4 and
above (at least) are broken when compiling applications without C++11
support:
In file included from
/home/marc/personal/xdpd/build/src/xdpd/drivers
I would, at most, use a separate git submodule in that location, only
populated at wish.
Having completely separate repository under dpdk.org or simply the PDFs/raw
RST in the website seem better options.
Marc
>
> > * On dpdk.org in PDF format.
> > * Elsewhere.
> >
> &
2015-10-06 15:48 GMT+02:00 N?lio Laranjeiro :
> Hi Marc,
>
> On Sun, Oct 04, 2015 at 11:12:46PM +0200, Marc Sune wrote:
> >[...]
> > /**
> > + * Device supported speeds bitmap flags
> > + */
> > +#define ETH_LINK_SPEED_AUTONEG (0
2015-10-05 12:59 GMT+02:00 Neil Horman :
> On Sun, Oct 04, 2015 at 11:12:46PM +0200, Marc Sune wrote:
> > This patch redesigns the API to set the link speed/s configure
> > for an ethernet port. Specifically:
> >
> > - it allows to define a set of advertised speeds
2015-10-04 23:12 GMT+02:00 Marc Sune :
> The current rte_eth_dev_info abstraction does not provide any mechanism to
> get the supported speed(s) of an ethdev.
>
> For some drivers (e.g. ixgbe), an educated guess could be done based on the
> driver's name (driver_name in rte_eth
Add new features, ABI changes and resolved issues notice for
the refactored link patch.
Signed-off-by: Marc Sune
---
doc/guides/rel_notes/release_2_2.rst | 22 +-
1 file changed, 21 insertions(+), 1 deletion(-)
diff --git a/doc/guides/rel_notes/release_2_2.rst
b/doc/guides
by configuration.
* Added utility function to convert numeric speeds to bitmap
fields.
* Adapted testpmd to the new link API.
Signed-off-by: Marc Sune
---
app/test-pmd/cmdline.c | 124 +++--
app/test/virtual_pmd.c | 4
Added speed capabilities to all pmds supporting physical NICs:
* e1000
* ixgbe
* i40
* mlx4
* fm10k
Signed-off-by: Marc Sune
---
drivers/net/e1000/em_ethdev.c| 6 ++
drivers/net/e1000/igb_ethdev.c | 6 ++
drivers/net/fm10k/fm10k_ethdev.c | 3 +++
drivers/net/i40e/i40e_ethdev.c
patch. Fixed MLX4 speed capabilities
(thanks N. Laranjeiro). Refactored link speed API to allow setting
advertised speeds (3/4). Added NO_AUTONEG option to explicitely disable
auto-negociation. Updated 2.2 rel. notes (4/4). Rebased to current HEAD.
Marc Sune (4):
ethdev: Added
Adrien,
2015-09-15 12:04 GMT+02:00 Adrien Mazarguil :
> Hi Marc,
>
> Adding my thoughts to the discussion, see below.
>
> On Tue, Sep 15, 2015 at 10:48:03AM +0200, Marc Sune wrote:
> > I will answer Morten in another mail, because I got his point on the
> >
> >
> > Med venlig hilsen / kind regards
> > - Morten Br?rup
> >
> > Marc Sune on 14. september 2015 23:34 wrote:
> >
> > 2015-09-14 12:52 GMT+02:00 Morten Br?rup :
> > > It is important to consider that a multipath link (bonding etc.) is
> not a ph
ed. I would suggest to add the encoded speed+duplex bitmap flag for
consistency (although redundant).
* or you return a single value, the bitmap with a single flag set of the
unrolled speeds, and then have the helpers int rte_eth_speed_from_bm(int
val_bm) and bool rte_eth_duplex_from_bm(int v
know if you really want to come back to v2 or not.
Marc
> Thanks
>
7463 at autoinstall.dev.6wind.com>
>
> Marc,
>
> On Tue, Sep 08, 2015 at 10:24:36PM +0200, Marc Sune wrote:
> > Neilo,
> >
> > 2015-09-08 12:03 GMT+02:00 N?lio Laranjeiro >:
> >
> > On Mon, Sep 07, 2015 at 10:52:53PM +0200, Marc Sune wrote:
Neilo,
2015-09-08 12:03 GMT+02:00 N?lio Laranjeiro :
> On Mon, Sep 07, 2015 at 10:52:53PM +0200, Marc Sune wrote:
> > 2015-08-29 2:16 GMT+02:00 Marc Sune :
> >
> > > The current rte_eth_dev_info abstraction does not provide any
> mechanism to
> > > get
2015-08-29 2:16 GMT+02:00 Marc Sune :
> The current rte_eth_dev_info abstraction does not provide any mechanism to
> get the supported speed(s) of an ethdev.
>
> For some drivers (e.g. ixgbe), an educated guess can be done based on the
> driver's name (driver_name in rte_eth
by existing applications, and build a
command line API on top of eal_init() that parses argv as of now (e.g.
eal_init_cl) seems to me cleaner. There are users that make use of the
parsing of argv (e.g. dpdk-pktgen) in DPDK, so I think it makes sense to
keep it.
So if you'd agree on this general propo
1 - 100 of 213 matches
Mail list logo
