[PATCH] net/ice: allow setting CIR

2023-07-06 Thread markus . theil
From: Michael Rossberg ice only allowed to set peak information rate (PIR), while the hardware also supports setting committed information rate (CIR). In many use cases both values are needed, therefore add support for CIR. Signed-off-by: Michael Rossberg --- drivers/net/ice/ice_tm.c | 39

Re: [PATCH] build: list selected applications

2022-10-28 Thread Markus Theil
-by: Markus Theil |

Re: [PATCH] telemetry: make usable from C++

2022-10-27 Thread Markus Theil
On 10/27/22 14:04, David Marchand wrote: On Wed, Oct 12, 2022 at 2:05 PM Markus Theil wrote: From: Markus Theil Add missing include in order to make C++ compilers happy. We have build checks for headers (-Dcheck_includes meson option), like for C++: $ cat $BUILDDIR/buildtools/chkincs

Re: [PATCH v4 1/2] build: allow to conditionally build apps

2022-10-27 Thread Markus Theil
On 10/27/22 16:22, David Marchand wrote: On Thu, Oct 27, 2022 at 3:13 PM David Marchand wrote: On Fri, Oct 14, 2022 at 9:51 AM Markus Theil wrote: Makes apps configurable from meson, like already possible for drivers. Signed-off-by: Markus Theil With these new options, it's hard to

[PATCH] doc: add deprecation notice for inconsistent socket_id types

2022-10-14 Thread Markus Theil
DPDK uses many different types for socket_id's in its whole code base. This leads to many warnings and casts in DPDK-based applications compiled with -Wconversion. Announce a treewide consolidation to the return type of rte_socket_id in DPDK 23.11. Signed-off-by: Markus Theil --- doc/g

Re: [PATCH v3 2/2] build: export dpdk_includes for subproject usage.

2022-10-14 Thread Markus Theil
On 10/13/22 18:38, Bruce Richardson wrote: Rather than changing all these meson.build files, I think we should be able to check in drivers/meson.build if the "headers" array is empty. If not, then add the include path, otherwise skip it. Thanks for the feedback. Changed in v4. /Bruce

[PATCH v2 1/2] eal: expose lcore pthread id

2022-10-14 Thread Markus Theil
From: Michael Pfeiffer Also expose the pthread id of each lcore, in order to allow modification of pthread attributes, for example use rte_thread_setname without executing pthread_self() on the maybe already running lcore. The rte_lcore_to_thread_id function is added to API. Signed-off-by: Mich

[PATCH v2 2/2] eal: prevent OOB read in rte_lcore_to_socket_id

2022-10-14 Thread Markus Theil
rte_lcore_to_socket_id did not check the lcore_id range before accessing an array with RTE_MAX_LCORE elements. Signed-off-by: Markus Theil --- lib/eal/common/eal_common_lcore.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/eal/common/eal_common_lcore.c b/lib/eal/common

[PATCH v4 2/2] build: export dpdk_includes for subproject usage

2022-10-14 Thread Markus Theil
In order to perform things like LTO more easily in our DPDK applications, we use DPDK as a meson subproject. Also export includes in order to be usable in this context. Signed-off-by: Markus Theil --- drivers/meson.build | 4 lib/meson.build | 1 + meson.build | 1 + 3 files

[PATCH v4 1/2] build: allow to conditionally build apps

2022-10-14 Thread Markus Theil
Makes apps configurable from meson, like already possible for drivers. Signed-off-by: Markus Theil --- app/meson.build | 13 - meson_options.txt | 4 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/app/meson.build b/app/meson.build index 93d8c15032..96b9a78d3a

[PATCH 2/2] eal: prevent OOB read in rte_lcore_to_socket_id

2022-10-13 Thread Markus Theil
Signed-off-by: Markus Theil --- lib/eal/common/eal_common_lcore.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/eal/common/eal_common_lcore.c b/lib/eal/common/eal_common_lcore.c index 48c333cff1..94625c2ebc 100644 --- a/lib/eal/common/eal_common_lcore.c +++ b/lib/eal/common

[PATCH 1/2] eal: expose lcore pthread id

2022-10-13 Thread Markus Theil
From: Michael Pfeiffer Also expose the pthread id of each lcore, in order to allow modification of pthread attributes, for example use rte_thread_setname without executing pthread_self() on the maybe already running lcore. The rte_lcore_to_thread_id function is added to API. Signed-off-by: Mich

[PATCH] net/ice: fix module EEPROM read

2022-10-13 Thread Markus Theil
From: David MacDougal Fix issue with final word being dropped when retrieving module EEPROM data for the ice driver. Take for simplicity the case when `info->offset` is zero and `info->len` is equal to `SFF_READ_BLOCK_SIZE`. In this case, memcpy would not be called despite there presumably being

[PATCH v3 2/2] build: export dpdk_includes for subproject usage.

2022-10-13 Thread Markus Theil
From: Thorben Roemer In order to perform things like LTO more easily in our DPDK applications, we use DPDK as a meson subproject. Also export includes in order to be usable in this context. Signed-off-by: Thorben Roemer --- drivers/baseband/fpga_5gnr_fec/meson.build | 2 ++ drivers/dma/dpaa2/m

[PATCH v3 1/2] build: allow to conditionally build apps

2022-10-13 Thread Markus Theil
Makes apps configurable from meson, like already possible for drivers. Signed-off-by: Markus Theil --- app/meson.build | 9 - meson_options.txt | 4 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/app/meson.build b/app/meson.build index 93d8c15032..24096e8108

[PATCH v2 1/2] build: allow to conditionally build apps

2022-10-13 Thread Markus Theil
Makes apps configurable from meson, like already possible for drivers. Signed-off-by: Markus Theil --- app/meson.build | 9 - meson_options.txt | 4 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/app/meson.build b/app/meson.build index 93d8c15032..24096e8108

[PATCH v2 2/2] build: export dpdk_includes for subproject usage.

2022-10-13 Thread Markus Theil
From: Thorben Roemer In order to perform things like LTO more easily in our DPDK applications, we use DPDK as a meson subproject. Also export includes in order to be usable in this context. Signed-off-by: Thorben Roemer --- lib/meson.build | 1 + meson.build | 1 + 2 files changed, 2 inser

Re: [PATCH 2/2] build: export dpdk_includes for subproject usage.

2022-10-13 Thread Markus Theil
On 10/12/22 17:21, Bruce Richardson wrote: On Wed, Oct 12, 2022 at 04:47:04PM +0200, Markus Theil wrote: From: Thorben Roemer In order to perform things like LTO more easily in our DPDK applications, we use DPDK as a meson subproject. Also export includes in order to be usable in this context

Re: [PATCH 1/2] build: allow to conditionally build apps

2022-10-13 Thread Markus Theil
On 10/12/22 17:19, Bruce Richardson wrote: On Wed, Oct 12, 2022 at 04:47:03PM +0200, Markus Theil wrote: Makes apps configureable from meson, like already possible for drivers. Signed-off-by: Markus Theil --- app/meson.build | 17 - meson_options.txt | 4 2 files

[PATCH 2/2] build: export dpdk_includes for subproject usage.

2022-10-12 Thread Markus Theil
From: Thorben Roemer In order to perform things like LTO more easily in our DPDK applications, we use DPDK as a meson subproject. Also export includes in order to be usable in this context. Signed-off-by: Thorben Roemer --- drivers/meson.build | 1 + lib/meson.build | 1 + meson.build

[PATCH 1/2] build: allow to conditionally build apps

2022-10-12 Thread Markus Theil
Makes apps configureable from meson, like already possible for drivers. Signed-off-by: Markus Theil --- app/meson.build | 17 - meson_options.txt | 4 2 files changed, 16 insertions(+), 5 deletions(-) diff --git a/app/meson.build b/app/meson.build index 93d8c15032

Re: [PATCH] ethdev: add include for vtune

2022-10-12 Thread Markus Theil
On 10/12/22 14:26, Ferruh Yigit wrote: On 10/12/2022 1:02 PM, Markus Theil wrote: From: Michael Pfeiffer Adding this include allowed us to use vtune with DPDK. Signed-off-by: Michael Pfeiffer ---   lib/ethdev/ethdev_profile.c | 1 +   1 file changed, 1 insertion(+) diff --git a/lib/ethdev

Re: [PATCH] net/bonding: fix socket_id type

2022-10-12 Thread Markus Theil
On 10/12/22 14:23, Ferruh Yigit wrote: On 10/12/2022 12:45 PM, Markus Theil wrote: From: Thorben Roemer DPDK uses int or u32 in most other places for socket IDs. Fix compilation warnings by also using int in the bonding code. Hi Markus, 'rte_eth_bond_create()' is part of API, s

[PATCH] build: make headroom and max memzones configurable

2022-10-12 Thread Markus Theil
We often set headroom and memzones to a different value in our builds. This should also be useful in other projects. Signed-off-by: Markus Theil --- config/meson.build | 2 ++ config/rte_config.h | 2 -- meson_options.txt | 4 3 files changed, 6 insertions(+), 2 deletions(-) diff --git

[PATCH v2] power: fix pstate number parsing

2022-10-12 Thread Markus Theil
From: Markus Theil When converting atoi to strtol in a revision of introducing sysfs support for turbo percentage, a necessary check against '\n' returned by sysfs was not introduced. Fixes: de254dac608e ("power: read P-state turbo percentage from sysfs") Reviewed-by: Res

[PATCH] net/ice: null field checks in ice_{r,t}x_queue_release

2022-10-12 Thread Markus Theil
From: Tomasz Jonak In case rte_eth_dma_zone_reserve fails in ice_tx_queue_setup ice_tx_queue_release is called on 0 allocated but not initialized txq struct. This may happen on ENOMEM condition, size exhaustion of memconfig->memzones array as well as some others. Signed-off-by: Tomasz Jonak ---

[PATCH] telemetry: make usable from C++

2022-10-12 Thread Markus Theil
From: Markus Theil Add missing include in order to make C++ compilers happy. Signed-off-by: Markus Theil --- lib/telemetry/rte_telemetry.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/telemetry/rte_telemetry.h b/lib/telemetry/rte_telemetry.h index 5e5ddaa25d..ded8e26b8b 100644

[PATCH] ethdev: add include for vtune

2022-10-12 Thread Markus Theil
From: Michael Pfeiffer Adding this include allowed us to use vtune with DPDK. Signed-off-by: Michael Pfeiffer --- lib/ethdev/ethdev_profile.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/ethdev/ethdev_profile.c b/lib/ethdev/ethdev_profile.c index 7978f351ac..90339cb2ee 100644 --- a/

[PATCH] net/bonding: fix socket_id type

2022-10-12 Thread Markus Theil
From: Thorben Roemer DPDK uses int or u32 in most other places for socket IDs. Fix compilation warnings by also using int in the bonding code. Signed-off-by: Thorben Roemer --- drivers/net/bonding/rte_eth_bond.h | 2 +- drivers/net/bonding/rte_eth_bond_api.c | 2 +- 2 files changed, 2 inse

[PATCH] power: fix pstate number parsing

2022-10-12 Thread Markus Theil
From: Markus Theil When converting atoi to strtol in a revision of introducing sysfs support for turbo percentage, a necessary check against '\n' returned by sysfs was not introduced. Fixes: de254dac608e ("power: read P-state turbo percentage from sysfs") Signed-off-by: Ma

[PATCH v2] net/ice: add nic blinking support

2022-09-14 Thread Markus Theil
From: Markus Theil Signed-off-by: Markus Theil --- v2: add LED feature in ice.ini doc/guides/nics/features/ice.ini | 1 + drivers/net/ice/ice_ethdev.c | 22 ++ 2 files changed, 23 insertions(+) diff --git a/doc/guides/nics/features/ice.ini b/doc/guides/nics/features

Re: [PATCH 1/2] net/ice: add nic blinking support

2022-09-14 Thread Markus Theil
Thanks for the hint/advice. I will resend the led patch and drop the fc patch for now (see another reply). On 9/4/22 04:10, Zhang, Qi Z wrote: -Original Message- From: Markus Theil Sent: Friday, September 2, 2022 5:14 AM To: dev@dpdk.org Cc: Yang, Qiming ; Zhang, Qi Z ; Theil

Re: [PATCH 2/2] net/ice: add basic flow ctrl support for enable/disable/get

2022-09-14 Thread Markus Theil
On 9/4/22 04:06, Zhang, Qi Z wrote: -Original Message- From: Markus Theil Sent: Friday, September 2, 2022 5:14 AM To: dev@dpdk.org Cc: Yang, Qiming ; Zhang, Qi Z ; Theil, Markus Subject: [PATCH 2/2] net/ice: add basic flow ctrl support for enable/disable/get From: Markus Theil

[PATCH 2/2] net/ice: add basic flow ctrl support for enable/disable/get

2022-09-01 Thread Markus Theil
From: Markus Theil Signed-off-by: Markus Theil --- drivers/net/ice/ice_ethdev.c | 108 +++ 1 file changed, 108 insertions(+) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index f5820d6ccb..ad93ec8155 100644 --- a/drivers/net/ice

[PATCH 1/2] net/ice: add nic blinking support

2022-09-01 Thread Markus Theil
From: Markus Theil Signed-off-by: Markus Theil --- drivers/net/ice/ice_ethdev.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index fc889420c7..f5820d6ccb 100644 --- a/drivers/net/ice/ice_ethdev.c +++ b

[PATCH v2] power: add unpriv. read of turbo % for pstate

2022-08-25 Thread Markus Theil
updates should include the sysfs interface for this (I only looked this up for CentOS 7). Tested-by: David Hunt Acked-by: David Hunt Signed-off-by: Markus Theil --- v2: atol -> strol (as suggested by David Hunt), close newly introduced fd lib/power/power_pstate_cpufreq.c |

[PATCH] power: add unpriv. read of turbo % for pstate

2022-08-24 Thread Markus Theil
updates should include the sysfs interface for this (I only looked this up for CentOS 7). Signed-off-by: Markus Theil --- lib/power/power_pstate_cpufreq.c | 69 ++-- 1 file changed, 40 insertions(+), 29 deletions(-) diff --git a/lib/power/power_pstate_cpufreq.c b/lib

[PATCH v3] kni: fix ioctl signature

2021-12-02 Thread Markus Theil
From: Markus Theil Fix kni's ioctl signature to correctly match the kernel's structs. This shaves off the (void*) casts and uses struct file* instead of struct inode*. With the correct signature, control flow integrity checkers are no longer confused at this point. Signed-off-by: Ma

[PATCH v2] kni: fix ioctl signature

2021-11-28 Thread Markus Theil
From: Markus Theil Fix kni's ioctl signature to correctly match the kernel's structs. This shaves off the (void*) casts and uses struct file* instead of struct inode*. With the correct signature, control flow integrity checkers are no longer confused at this point. Signed-off-by: Ma

[PATCH] kni: fix ioctl signature

2021-11-20 Thread Markus Theil
From: Markus Theil Fix kni's ioctl signature to correctly match the kernel's structs. This shaves off the (void*) casts and uses struct file* instead of struct inode*. With the correct signature, control flow integrity checkers are no longer confused at this point. Signed-off-by: Ma

Re: [dpdk-dev] [BUG] net/af_xdp: Current code can only create one af_xdp device

2019-04-24 Thread Markus Theil
Hi Xiaolong, with only one vdev everything works. It stops working if I use two vdevs. Both interfaces were brought up before testing. Best regards, Markus On 24.04.19 16:47, Ye Xiaolong wrote: > Hi, Markus > > On 04/24, Markus Theil wrote: >> Hi Xiaolong, >> >> I al

Re: [dpdk-dev] [BUG] net/af_xdp: Current code can only create one af_xdp device

2019-04-24 Thread Markus Theil
(910c475f09e5c269f441d7496c27dace30dc2335) - DPDK and libbpf build with meson Best regards, Markus On 4/24/19 8:35 AM, Ye Xiaolong wrote: > Hi, Markus > > On 04/23, Markus Theil wrote: >> Hi Xiaolong, >> >> I tested your commit "net/af_xdp: fix creating multiple instance" on the >>

Re: [dpdk-dev] [BUG] net/af_xdp: Current code can only create one af_xdp device

2019-04-23 Thread Markus Theil
ou need some program output or more information from me. Best regards, Markus On 4/18/19 3:05 AM, Ye Xiaolong wrote: > Hi, Markus > > On 04/17, Markus Theil wrote: >> I tested the new af_xdp based device on the current master branch and >> noticed, that the usage of static m

[dpdk-dev] [BUG] net/af_xdp: Current code can only create one af_xdp device

2019-04-17 Thread Markus Theil
I tested the new af_xdp based device on the current master branch and noticed, that the usage of static mempool names allows only for the creation of a single af_xdp vdev. If a second vdev of the same type gets created, the mempool allocation fails. Best regards, Markus Theil

Re: [dpdk-dev] Support for Intel 82579LM (8086:1502)

2017-10-13 Thread Markus Theil
Hi, I wrote a little patch for you. You can apply it to the current dpdk-master branch and test it. My Thinkpad T430 has such a NIC and shows some rx packets and the link status change with the patch, when using testpmd. Maybe 82579LM was not supported for a reason, so simply try out if it works f

[dpdk-dev] [PATCH] net/e1000: add pci ids for 82579LM

2017-10-13 Thread Markus Theil
This patch adds the PCI IDs for Intel 82579LM. Signed-off-by: Markus Theil --- drivers/net/e1000/em_ethdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/e1000/em_ethdev.c b/drivers/net/e1000/em_ethdev.c index 6ebfa6d4c..85607c322 100644 --- a/drivers/net/e1000/em_ethdev.c

[dpdk-dev] [PATCH] igb_uio: fix legacy msi masking

2017-10-13 Thread Markus Theil
MSI masks contain a 1 if interrupt is masked, 0 if unmasked. I got that wrong with the !!state calculation. For better readability, the mask is now changed like in igbuio_msi_mask_irq. Fixes: a8ea1e5fb647 ("igb_uio: fix unknown MSI symbols") Signed-off-by: Markus Theil Tested-by: Ma

Re: [dpdk-dev] [PATCH v7 1/6] igb_uio: refactor irq enable/disable into own functions

2017-09-14 Thread Markus Theil
Tested-by: Markus Theil The MSI mode was tested in two setups: 1. With a custom driver I'm currently developing. 2. With i210 based APU2C4 boards and check of link status interrupt in testpmd. On 11.09.2017 19:48, Ferruh Yigit wrote: > On 9/5/2017 1:04 PM, Markus Theil wrote: >> I

[dpdk-dev] [PATCH v7 2/6] igb_uio: fix irq disable on recent kernels

2017-09-05 Thread Markus Theil
I-X") Cc: nicolas.dich...@6wind.com Signed-off-by: Markus Theil --- lib/librte_eal/linuxapp/igb_uio/compat.h | 4 ++-- lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 9 +++-- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/lib/librte_eal/linuxapp/igb_uio/compat.h b/l

[dpdk-dev] [PATCH v7 5/6] igb_uio: use kernel functions for masking MSI-X

2017-09-05 Thread Markus Theil
This patch removes the custom MSI-X mask/unmask code and uses already existing kernel functions. Signed-off-by: Markus Theil --- lib/librte_eal/linuxapp/igb_uio/compat.h | 26 +--- lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 51 --- 2 files changed, 28

[dpdk-dev] [PATCH v7 6/6] igb_uio: MSI IRQ mode

2017-09-05 Thread Markus Theil
This patch adds MSI IRQ mode in a way, that should also work on older kernel versions. The base for my patch was an attempt to do this in cf705bc36c which was later reverted in d8ee82745a. Compilation was tested on Linux 3.2, 4.10 and 4.12. Signed-off-by: Markus Theil --- lib/librte_eal

[dpdk-dev] [PATCH v7 1/6] igb_uio: refactor irq enable/disable into own functions

2017-09-05 Thread Markus Theil
Interrupt setup code in igb_uio has to deal with multiple types of interrupts and kernel versions. This patch moves the setup and teardown code into own functions, to make it more readable. Signed-off-by: Markus Theil --- lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 112

[dpdk-dev] [PATCH v7 4/6] igb_uio: release in exact reverse order

2017-09-05 Thread Markus Theil
For better readability throughout the module, the destruction order is changed to the exact inverse construction order. Signed-off-by: Markus Theil --- lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/librte_eal/linuxapp

[dpdk-dev] [PATCH v7 3/6] igb_uio: fix MSI-X IRQ assignment with new IRQ function

2017-09-05 Thread Markus Theil
colas.dich...@6wind.com Signed-off-by: Markus Theil --- lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c index 93bb71d..6885e72 100644 --- a/lib/librte_eal/linuxapp/igb_uio

[dpdk-dev] [PATCH v6 5/5] igb_uio: MSI IRQ mode, use kernel functions for masking MSI and MSI-X

2017-09-04 Thread Markus Theil
and already existing kernel APIs are used for MSI and MSI-X. Feedback/small corrections to the previous patch of this series are also incorporated. Signed-off-by: Markus Theil --- lib/librte_eal/linuxapp/igb_uio/compat.h | 26 +++--- lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 81

[dpdk-dev] [PATCH v6 4/5] igb_uio: release in exact reverse order

2017-09-04 Thread Markus Theil
For better readability throughout the module, the destruction order is changed to the exact inverse construction order. Signed-off-by: Markus Theil --- lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/librte_eal/linuxapp

[dpdk-dev] [PATCH v6 3/5] igb_uio: fix MSI-X IRQ assignment with new IRQ function

2017-09-04 Thread Markus Theil
colas.dich...@6wind.com Signed-off-by: Markus Theil --- lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c index 9bb74b2..6885e72 100644 --- a/lib/librte_eal/linuxapp/igb_uio

[dpdk-dev] [PATCH v6 1/5] igb_uio: refactor irq enable/disable into own functions

2017-09-04 Thread Markus Theil
Interrupt setup code in igb_uio has to deal with multiple types of interrupts and kernel versions. This patch moves the setup and teardown code into own functions, to make it more readable. Signed-off-by: Markus Theil --- lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 112

[dpdk-dev] [PATCH v6 2/5] igb_uio: fix irq disable on recent kernels

2017-09-04 Thread Markus Theil
I-X") Cc: nicolas.dich...@6wind.com Signed-off-by: Markus Theil --- lib/librte_eal/linuxapp/igb_uio/compat.h | 4 ++-- lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 11 --- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/lib/librte_eal/linuxapp/igb_uio/compat.h b/l

Re: [dpdk-dev] [PATCH v5 4/5] igb_uio: use msi mask functions from kernel, little corrections

2017-09-04 Thread Markus Theil
On 04.09.2017 14:43, Ferruh Yigit wrote: > On 8/31/2017 10:46 PM, Markus Theil wrote: >> This patch substitutes the custom MSI/MSI-X mask code and uses >> already existing kernel APIs. Feedback/small corrections to the previous >> patch of this series are also incorporated

Re: [dpdk-dev] [PATCH v4 3/3] igb_uio: MSI IRQ mode

2017-08-31 Thread Markus Theil
On 31.08.2017 17:32, Stephen Hemminger wrote: > On Thu, 31 Aug 2017 12:22:29 +0200 > Markus Theil wrote: > >> +/* >> + * It masks the msi on/off of generating MSI messages. >> + */ >> +static void >> +igbuio_msi_mask_irq(struct pci_dev *pdev, s

Re: [dpdk-dev] [PATCH v3] igb_uio: MSI IRQ mode, irq enable/disable refactored

2017-08-31 Thread Markus Theil
On 30.08.2017 18:32, Ferruh Yigit wrote: > Please add fall back comment: /* fall back to MSI */ > > And related this fallback, previously flow was: > Try MSIX, if fails try legacy. > > Now it is: > Try MSIX, if fails try MSI, if fails try legacy. > > Do you think, does this new step included may br

[dpdk-dev] [PATCH v5 5/5] igb_uio: release in exact reverse order

2017-08-31 Thread Markus Theil
Signed-off-by: Markus Theil --- lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c index 5830453..b578c4a 100644 --- a/lib/librte_eal/linuxapp

[dpdk-dev] [PATCH v5 2/5] igb_uio: fix irq disable on recent kernels

2017-08-31 Thread Markus Theil
I-X") Cc: nicolas.dich...@6wind.com Signed-off-by: Markus Theil --- lib/librte_eal/linuxapp/igb_uio/compat.h | 4 ++-- lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 9 +++-- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/lib/librte_eal/linuxapp/igb_uio/compat.h b/l

[dpdk-dev] [PATCH v5 1/5] igb_uio: refactor irq enable/disable into own functions

2017-08-31 Thread Markus Theil
Interrupt setup code in igb_uio has to deal with multiple types of interrupts and kernel versions. This patch moves the setup and teardown code into own functions, to make it more readable. Signed-off-by: Markus Theil --- lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 112

[dpdk-dev] [PATCH v5 3/5] igb_uio: MSI IRQ mode

2017-08-31 Thread Markus Theil
This patch adds MSI IRQ mode and in a way, that should also work on older kernel versions. The base for my patch was an attempt to do this in cf705bc36c which was later reverted in d8ee82745a. Compilation was tested on Linux 3.2, 4.10 and 4.12. Signed-off-by: Markus Theil --- lib/librte_eal

[dpdk-dev] [PATCH v5 4/5] igb_uio: use msi mask functions from kernel, little corrections

2017-08-31 Thread Markus Theil
This patch substitutes the custom MSI/MSI-X mask code and uses already existing kernel APIs. Feedback/small corrections to the previous patch of this series are also incorporated. Signed-off-by: Markus Theil --- lib/librte_eal/linuxapp/igb_uio/compat.h | 26 +++-- lib/librte_eal/linuxapp

[dpdk-dev] [PATCH v4 3/3] igb_uio: MSI IRQ mode

2017-08-31 Thread Markus Theil
This patch adds MSI IRQ mode and in a way, that should also work on older kernel versions. The base for my patch was an attempt to do this in cf705bc36c which was later reverted in d8ee82745a. Compilation was tested on Linux 3.2, 4.10 and 4.12. Signed-off-by: Markus Theil --- lib/librte_eal

[dpdk-dev] [PATCH v4 1/3] igb_uio: refactor irq enable/disable into own functions

2017-08-31 Thread Markus Theil
Interrupt setup code in igb_uio has to deal with multiple types of interrupts and kernel versions. This patch moves the setup and teardown code into own functions, to make it more readable. Signed-off-by: Markus Theil --- lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 112

[dpdk-dev] [PATCH v4 2/3] igb_uio: fix irq disable on recent kernels

2017-08-31 Thread Markus Theil
I-X") Cc: nicolas.dich...@6wind.com Signed-off-by: Markus Theil --- lib/librte_eal/linuxapp/igb_uio/compat.h | 4 ++-- lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 9 +++-- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/lib/librte_eal/linuxapp/igb_uio/compat.h b/l

Re: [dpdk-dev] [PATCH] igb_uio: MSI IRQ mode, irq enable/disable refactored

2017-08-22 Thread Markus Theil
On 22.08.2017 18:55, Stephen Hemminger wrote: > On Mon, 21 Aug 2017 19:33:45 +0200 > Markus Theil wrote: > >> This patch adds MSI IRQ mode and in a way, that should >> also work on older kernel versions. The base for my patch >> was an attempt to do this in cf705bc36c

[dpdk-dev] [PATCH v3] igb_uio: MSI IRQ mode, irq enable/disable refactored

2017-08-22 Thread Markus Theil
before, but calls to pci_free_irq_vectors were missing and added. Signed-off-by: Markus Theil --- lib/librte_eal/linuxapp/igb_uio/compat.h | 9 +- lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 175 ++ 2 files changed, 135 insertions(+), 49 deletions(-) diff --git a

[dpdk-dev] [PATCH v2 2/2] igb_uio: conform to coding conventions

2017-08-21 Thread Markus Theil
Signed-off-by: Markus Theil --- lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c index 0a2f993..bd94eb4 100644 --- a/lib/librte_eal/linuxapp/igb_uio

[dpdk-dev] [PATCH v2 1/2] igb_uio: MSI IRQ mode, irq enable/disable refactored

2017-08-21 Thread Markus Theil
before, but calls to pci_free_irq_vectors were missing and added. Signed-off-by: Markus Theil --- lib/librte_eal/linuxapp/igb_uio/compat.h | 9 +- lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 175 ++ 2 files changed, 135 insertions(+), 49 deletions(-) diff --git a

[dpdk-dev] [PATCH] igb_uio: MSI IRQ mode, irq enable/disable refactored

2017-08-21 Thread Markus Theil
before, but calls to pci_free_irq_vectors were missing and added. Signed-off-by: Markus Theil --- lib/librte_eal/linuxapp/igb_uio/compat.h | 9 +- lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 175 ++ 2 files changed, 135 insertions(+), 49 deletions(-) diff --git a

[dpdk-dev] [PATCH] net/igb: add i210 flashless device ids

2017-08-21 Thread Markus Theil
This patch adds two missing device IDs for Intel i210 chips in flashless mode. Copper flashless mode was tested on a PC Engines APU2C4 board. Signed-off-by: Markus Theil --- drivers/net/e1000/igb_ethdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/e1000/igb_ethdev.c b

[dpdk-dev] [PATCH v3 2/2] net/igb: fix add/delete of flex filters

2017-05-22 Thread Markus Theil
Before this patch, flex_filter->index was always zero when it was read and used after rte_zmalloc. The corresponding code was therefore moved into the add and delete parts of the if/else statement. Fixes: 231d43909a31 ("igb: migrate flex filter to new API") Signed-off-by:

[dpdk-dev] [PATCH v3 1/2] net/igb: support flex filters on i210/i211

2017-05-22 Thread Markus Theil
i210/i211 also support flex filters. Tested on i210. Signed-off-by: Markus Theil --- drivers/net/e1000/igb_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c index e1702d8..631ace6 100644 --- a/drivers

[dpdk-dev] [PATCH v2] net/igb: fix add/delete of flex filters

2017-05-18 Thread Markus Theil
Before this patch, flex_filter->index was always zero when it was read and used after rte_zmalloc. The corresponding code was therefore moved into the add and delete parts of the if/else statement. i210 and i211 also support flex filters. Signed-off-by: Markus Theil --- drivers/net/e1

[dpdk-dev] [PATCH] net/igb: fix add/delete of flex filters

2017-05-18 Thread Markus Theil
Before this patch, flex_filter->index was always zero when it was read and used after rte_zmalloc. The corresponding code was therefore moved into the add and delete parts of the if/else statement. i210 and i211 also support flex filters. Signed-off-by: Markus Theil --- drivers/net/e1

[dpdk-dev] [PATCH] net/e1000: support MAC filters for i210 and i211 chips

2017-05-17 Thread Markus Theil
i210 and i211 also support unicast MAC filters. The patch was tested on i210 based hw, for i211 support was looked up in the specs. Signed-off-by: Markus Theil --- drivers/net/e1000/igb_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/e1000/igb_ethdev.c