[dpdk-dev] [PATCH 0/4] doc: update RTE flow rule and bonding related info

2021-07-21 Thread Martin Havlik
t;Min Hu (Connor)" Martin Havlik (4): doc: clarify RTE flow behaviour on port stop/start doc: specify RTE flow create behaviour doc: update bonding mode 8023ad info doc: note that testpmd on mlx5 has dedicated queues problem doc/guides/nics/mlx5.rst |

[dpdk-dev] [PATCH 1/4] doc: clarify RTE flow behaviour on port stop/start

2021-07-21 Thread Martin Havlik
It is now clearly stated that RTE flow rules can be created only after the port is started. Signed-off-by: Martin Havlik --- doc/guides/nics/mlx5.rst | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index f5b727c1ee

[dpdk-dev] [PATCH 2/4] doc: specify RTE flow create behaviour

2021-07-21 Thread Martin Havlik
The ability to create RTE flow rules, depending on port status, can and does differ between PMDs. Now the doc reflects that. Signed-off-by: Martin Havlik --- doc/guides/prog_guide/rte_flow.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/prog_guide/rte_flow.rst b/doc

[dpdk-dev] [PATCH 3/4] doc: update bonding mode 8023ad info

2021-07-21 Thread Martin Havlik
Included info on dedicated queues and added related note about issue on mlx5. Signed-off-by: Martin Havlik --- doc/guides/prog_guide/link_bonding_poll_mode_drv_lib.rst | 8 1 file changed, 8 insertions(+) diff --git a/doc/guides/prog_guide/link_bonding_poll_mode_drv_lib.rst b/doc

[dpdk-dev] [PATCH 4/4] doc: note that testpmd on mlx5 has dedicated queues problem

2021-07-21 Thread Martin Havlik
In bonding mode 4 (8023ad), dedicated queues are not working on mlx5 NICs. Signed-off-by: Martin Havlik --- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug

[dpdk-dev] [PATCH 0/3] net/bonding: make dedicated queues work with mlx5

2021-06-22 Thread Martin Havlik
oherty Cc: Tomasz Kulasek Cc: Jan Viktorin Martin Havlik (3): net/bonding: fix proper return value check and correct log message net/bonding: fix not checked return value net/bonding: start ethdev prior to setting 8023ad flow drivers/net/bonding/rte_eth_bond_

[dpdk-dev] [PATCH 1/3] net/bonding: fix proper return value check and correct log message

2021-06-22 Thread Martin Havlik
Return value is now saved to errval and log message on error reports correct function name, doesn't use q_id which was out of context, and uses up-to-date errval. Fixes: 112891cd27e5 ("net/bonding: add dedicated HW queues for LACP control") Cc: tomaszx.kula...@intel.com Signed

[dpdk-dev] [PATCH 2/3] net/bonding: fix not checked return value

2021-06-22 Thread Martin Havlik
Return value from bond_ethdev_8023ad_flow_set() is now checked and appropriate message is logged on error. Fixes: 112891cd27e5 ("net/bonding: add dedicated HW queues for LACP control") Cc: tomaszx.kula...@intel.com Signed-off-by: Martin Havlik Cc: Jan Viktorin --- drivers/n

[dpdk-dev] [PATCH 3/3] net/bonding: start ethdev prior to setting 8023ad flow

2021-06-22 Thread Martin Havlik
When dedicated queues are enabled, mlx5 PMD fails to install RTE Flows if the underlying ethdev is not started: bond_ethdev_8023ad_flow_set(267) - bond_ethdev_8023ad_flow_set: port not started (slave_port=0 queue_id=1) Signed-off-by: Martin Havlik Cc: Jan Viktorin --- drivers/net/bonding

[dpdk-dev] [PATCH 0/2] net/bonding: fix dedicated queues flow rule issue

2021-10-05 Thread Martin Havlik
all appropriate PMDs in `rte_eth_dev_info->dev_capa`. That is not pretty, but it holds the semantics of a capability correctly, as opposed to making it a requirement to have the device started before creating flow rules. [1] https://www.mail-archive.com/dev@dpdk.org/msg214840.html Martin Havlik

[dpdk-dev] [PATCH 2/2] net/bonding: ensure device is started for dedicated queues setup

2021-10-05 Thread Martin Havlik
The flow rule governing dedicated queues is now created when the slave allows it. That is before or after the start of the slave device, as the PMD is able to. Signed-off-by: Martin Havlik --- drivers/net/bonding/rte_eth_bond_pmd.c | 25 +++-- 1 file changed, 19 insertions

[dpdk-dev] [PATCH 1/2] lib/ethdev: introduce RTE_ETH_DEV_CAPA_FLOW_CREATE_BEFORE_START

2021-10-05 Thread Martin Havlik
Not all PMDs allow RTE flow rules to be created before start. This capability will be set for the ones that allow it. Signed-off-by: Martin Havlik --- lib/ethdev/rte_ethdev.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h index bef24173cf